[jira] [Commented] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread Klaus Ma (JIRA) 

[ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338295#comment-15338295
 ] 

Klaus Ma commented on MYRIAD-228:
-

That's great :). Thanks very much :).

Thanks
Klaus

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread DarinJ (JIRA) 

[ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338047#comment-15338047
 ] 

DarinJ edited comment on MYRIAD-228 at 6/18/16 5:22 PM:


I have a wip PR which addresses this.  Should be ready next week.
https://github.com/apache/incubator-myriad/pull/79



was (Author: darinj):
I have a wip PR which addresses this.  Should be ready next week.

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread DarinJ (JIRA) 

[ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338047#comment-15338047
 ] 

DarinJ commented on MYRIAD-228:
---

I have a wip PR which addresses this.  Should be ready next week.

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread Klaus Ma (JIRA) 

[ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337978#comment-15337978
 ] 

Klaus Ma edited comment on MYRIAD-228 at 6/18/16 3:31 PM:
--

It seems we should clear environments when generate command, draft code diff:

{code}
index db945ec..424ecf6 100644
--- 
a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ 
b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements 
ExecutorCommandLineGenerator {

   protected void generateEnvironment(ServiceResourceProfile profile, NMPorts 
ports) {
+// clear old environment.
+environment.clear();
+
 //yarnEnvironemnt configuration from yaml file
 Map yarnEnvironmentMap = cfg.getYarnEnvironment();
 if (yarnEnvironmentMap != null) {
{code}

[~adam-mesos], any comments on that?


was (Author: klaus1982):
It seems we should clear environments when generate command, draft code diff:

{code}
index db945ec..424ecf6 100644
--- 
a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ 
b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements 
ExecutorCommandLineGenerator {

   protected void generateEnvironment(ServiceResourceProfile profile, NMPorts 
ports) {
+// clear old environment.
+environment.clear();
+
 //yarnEnvironemnt configuration from yaml file
 Map yarnEnvironmentMap = cfg.getYarnEnvironment();
 if (yarnEnvironmentMap != null) {
{code}

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Issue Comment Deleted] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread Klaus Ma (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Klaus Ma updated MYRIAD-228:

Comment: was deleted

(was: It seems we should clear environments when generate command, draft code 
diff:

{code}
index db945ec..424ecf6 100644
--- 
a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ 
b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements 
ExecutorCommandLineGenerator {

   protected void generateEnvironment(ServiceResourceProfile profile, NMPorts 
ports) {
+// clear old environment.
+environment.clear();
+
 //yarnEnvironemnt configuration from yaml file
 Map yarnEnvironmentMap = cfg.getYarnEnvironment();
 if (yarnEnvironmentMap != null) {
{code})

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MYRIAD-228) Duplicated NM opts

2016-06-18 Thread Klaus Ma (JIRA) 

[ 
https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337978#comment-15337978
 ] 

Klaus Ma commented on MYRIAD-228:
-

It seems we should clear environments when generate command, draft code diff:

{code}
index db945ec..424ecf6 100644
--- 
a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ 
b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements 
ExecutorCommandLineGenerator {

   protected void generateEnvironment(ServiceResourceProfile profile, NMPorts 
ports) {
+// clear old environment.
+environment.clear();
+
 //yarnEnvironemnt configuration from yaml file
 Map yarnEnvironmentMap = cfg.getYarnEnvironment();
 if (yarnEnvironmentMap != null) {
{code}

> Duplicated NM opts
> --
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
>  Issue Type: Bug
>Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM 
> Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Question on Mesos Reservation

2016-06-18 Thread Klaus Ma 
Hi Adam,


Just go through the code of Myriad on resource usage, there's some behaviour 
I'd like to confirm with you.


1. Myriad can not use reserved resource and normal resource together

2. There's no priority on which resources will be used firstly, reserved 
resource vs. normal resources


If any comments, please let me know :).




Da (Klaus), Ma (??), PMP(r)| Advisory Software Engineer
Platform DCOS Development & Support, STG, IBM GCG
+86-10-8245 4084 | mad...@cn.ibm.com | http://k82.me



From: Adam Bordelon 
Sent: Tuesday, June 14, 2016 6:00:40 PM
To: dev@myriad.incubator.apache.org
Subject: Re: Question on Mesos Reservation

The Myriad framework can register with a Mesos role if you set the
'frameworkRole'
config param. Then you can configure Mesos agents to have static
reservations, or use the operator endpoints to grant dynamic reservations
to that role, or configure a minimum resource quota for that role. See
http://mesos.apache.org/documentation/latest/roles/ and
http://mesos.apache.org/documentation/latest/reservation/ and
http://mesos.apache.org/documentation/latest/quota/

There is currently no support yet for Myriad to create dynamic reservations
on its own (I just created MYRIAD-221
 to track it), nor for
Myriad to take advantage of revocable resources (MYRIAD-179
). These would be great
features for Myriad 0.3, but I don't think we have anybody committed to
work on them yet. Your comments/help are appreciated.

On Tue, Jun 14, 2016 at 2:24 AM, Sam Chen  wrote:

> Guys,
> Talking about the latest Myriad distribution, can it support the feature
> of Mesos Reservation? If no, what's the roadmap and plan on this?
> Appreciated.
>
> Regards,
> Sam
>
> Sent from my iPhone