[jira] Closed: (OFBIZ-4162) Checkout Shipping Options
[ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4162. -- Checkout Shipping Options - Key: OFBIZ-4162 URL: https://issues.apache.org/jira/browse/OFBIZ-4162 Project: OFBiz Issue Type: Bug Components: order, specialpurpose/ecommerce Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4162.patch When the user selects a shipping option and moves to the next step and then comes back to the Shipping Options step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (OFBIZ-4162) Checkout Shipping Options
[ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux resolved OFBIZ-4162. Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Stephen, I fixed only in trunk at r1068286, since it was not breaking OOTB Thanks Checkout Shipping Options - Key: OFBIZ-4162 URL: https://issues.apache.org/jira/browse/OFBIZ-4162 Project: OFBiz Issue Type: Bug Components: order, specialpurpose/ecommerce Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4162.patch When the user selects a shipping option and moves to the next step and then comes back to the Shipping Options step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1068279 [1/2] - in /ofbiz/trunk/applications: order/entitydef/ order/script/org/ofbiz/order/olap/ order/script/org/ofbiz/order/reports/ order/servicedef/ order/webapp/ordermgr/WEB-INF
Le 08/02/2011 08:10, hans...@apache.org a écrit : Author: hansbak Date: Tue Feb 8 07:10:36 2011 New Revision: 1068279 URL: http://svn.apache.org/viewvc?rev=1068279view=rev Log: remove log messages from image managment, correct sales report and popular categories Modified: ofbiz/trunk/applications/order/entitydef/entitymodel_olap.xml ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml ofbiz/trunk/applications/order/script/org/ofbiz/order/reports/SalesReportEvent.xml ofbiz/trunk/applications/order/servicedef/services_olap.xml ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/CheckReportBy.groovy ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/SalesReport.groovy ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReport.rptdesign ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReportMonth.rptdesign ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReportWeek.rptdesign ofbiz/trunk/applications/order/widget/ordermgr/ReportForms.xml ofbiz/trunk/applications/product/script/org/ofbiz/product/category/CategoryServices.xml ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml ofbiz/trunk/applications/product/servicedef/services.xml ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/showPeopleApprove.ftl Hi Hans, shouldn't this have been at least 2 commits ? Cheers, -- Erwan de FERRIERES www.nereide.biz
[jira] Created: (OFBIZ-4168) DateTimePicker shows wrong time on reselect
DateTimePicker shows wrong time on reselect --- Key: OFBIZ-4168 URL: https://issues.apache.org/jira/browse/OFBIZ-4168 Project: OFBiz Issue Type: Bug Environment: Win XP SP3, JRE 1.6.0_23-b05, german locale Reporter: Nikkel K If you open the DTP (DateTimePicker) and choose a time (i.e. now), close it and open it again, the hours are set to 23. Same while open the DTP and switch (alt+tab) in an other window and switch back again. Appers nearly always. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4169) DateTimePicker shows wrong current time
DateTimePicker shows wrong current time --- Key: OFBIZ-4169 URL: https://issues.apache.org/jira/browse/OFBIZ-4169 Project: OFBiz Issue Type: Bug Environment: Win XP SP3, JRE 1.6.0_23-b05, german locale Reporter: Nikkel K The DateTimePicker calculates *nearly* always in 5m steps and rounds up or down, depending on the nearest result. This means, that you have at 14:11:10 and at 14:12:10 a time of 14:10:10 in the DTP and at 14:13:10 and 14:14:10 already 14:15:10 (so on the one hand you have a current time that shows in the future and on the other hand the same time 5 times in the DTP (while the mins. dont increase, the seconds do). comment to the *nearly* always: i had exactly *one* case, where i had xx:*01*:xx, and i cant recreate it... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4170) The Time-Slider of the DateTimePicker seems to be bugged at the first Item
The Time-Slider of the DateTimePicker seems to be bugged at the first Item -- Key: OFBIZ-4170 URL: https://issues.apache.org/jira/browse/OFBIZ-4170 Project: OFBiz Issue Type: Bug Environment: Win XP SP3, JRE 1.6.0_23-b05, german locale Reporter: Nikkel K If you open the DTP you can see 3 sliders at the bottom line displaying hours, minutes and seconds. If you move those sliders to the very left you will notice that the first two positions are equal. For example on the hour slider the first 2 Slider-Positions are 1. So effectivly you cannot set the time to 00:00:00 but only to 01:05:10. The first Element seems to be buggy. Case: Your time is xx:00:xx you select 20 minutes and click on now. result: the minutes dont change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4168) DateTimePicker shows wrong time on reselect
[ https://issues.apache.org/jira/browse/OFBIZ-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991842#comment-12991842 ] Sascha Rodekamp commented on OFBIZ-4168: Ui hm interesting, i will check and fix. Thanks for reporting! Have a good day Sascha DateTimePicker shows wrong time on reselect --- Key: OFBIZ-4168 URL: https://issues.apache.org/jira/browse/OFBIZ-4168 Project: OFBiz Issue Type: Bug Environment: Win XP SP3, JRE 1.6.0_23-b05, german locale Reporter: Nikkel K If you open the DTP (DateTimePicker) and choose a time (i.e. now), close it and open it again, the hours are set to 23. Same while open the DTP and switch (alt+tab) in an other window and switch back again. Appers nearly always. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4170) The Time-Slider of the DateTimePicker seems to be bugged at the first Item
[ https://issues.apache.org/jira/browse/OFBIZ-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991883#comment-12991883 ] Sascha Rodekamp commented on OFBIZ-4170: Hi, seems that there is a little bit more work todo ... i'll check. Thanks for reporting. Have a good day Sascha The Time-Slider of the DateTimePicker seems to be bugged at the first Item -- Key: OFBIZ-4170 URL: https://issues.apache.org/jira/browse/OFBIZ-4170 Project: OFBiz Issue Type: Bug Environment: Win XP SP3, JRE 1.6.0_23-b05, german locale Reporter: Nikkel K If you open the DTP you can see 3 sliders at the bottom line displaying hours, minutes and seconds. If you move those sliders to the very left you will notice that the first two positions are equal. For example on the hour slider the first 2 Slider-Positions are 1. So effectivly you cannot set the time to 00:00:00 but only to 01:05:10. The first Element seems to be buggy. Case: Your time is xx:00:xx you select 20 minutes and click on now. result: the minutes dont change. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4158) Pagination Problem in Accounting Module
[ https://issues.apache.org/jira/browse/OFBIZ-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991944#comment-12991944 ] Naveen Kumar N commented on OFBIZ-4158: --- Hi Jacques, I've added some data to the current trunk demo server to reproduce the error message. Here is the link: https://demo-trunk.ofbiz.apache.org/accounting/control/findSalesInvoicesByDueDate?daysOffset=100partyIdFrom=CompanyinvoiceTypeId=SALES_INVOICEVIEW_SIZE_1=50VIEW_INDEX_1=1# Go to: Accounting Payments Find Sales Invoice by Due Date Then select Company as 'Organization Party Id' and a 'Days Offset' of 100 or more. Then try to use the pagination link to access the next 50 items to get the error. Thanks Naveen Pagination Problem in Accounting Module --- Key: OFBIZ-4158 URL: https://issues.apache.org/jira/browse/OFBIZ-4158 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Environment: Ubuntu 10.04, Java(TM) SE Runtime Environment (build 1.6.0_15-b03) Reporter: Naveen Kumar N Labels: accounting, pagination Attachments: FindSalesInvoicesByDueDate.png, Screenshot.png Ofbiz Trunk Used (SVN Revision No): 1065553 In accounting module, the pagination is not working when the following request was performed. Requested URL: https://localhost:8443/accounting/control/findSalesInvoicesByDueDate?daysOffset=365partyIdFrom=CompanyinvoiceTypeId=SALES_INVOICEVIEW_SIZE_1=50VIEW_INDEX_1=1#; Ofbiz throws the following error: The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [invoiceTypeId] passed to secure (https) request-map with uri [findSalesInvoicesByDueDate] with an event that calls service [getInvoicePaymentInfoListByDueDateOffset]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4158) Pagination Problem in Accounting Module
[ https://issues.apache.org/jira/browse/OFBIZ-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Kumar N updated OFBIZ-4158: -- Attachment: Screenshot.png Here is the screenshot of the error message generated by ofbiz when the pagination link was clicked to access the next 50 items. Pagination Problem in Accounting Module --- Key: OFBIZ-4158 URL: https://issues.apache.org/jira/browse/OFBIZ-4158 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Environment: Ubuntu 10.04, Java(TM) SE Runtime Environment (build 1.6.0_15-b03) Reporter: Naveen Kumar N Labels: accounting, pagination Attachments: FindSalesInvoicesByDueDate.png, Screenshot.png Ofbiz Trunk Used (SVN Revision No): 1065553 In accounting module, the pagination is not working when the following request was performed. Requested URL: https://localhost:8443/accounting/control/findSalesInvoicesByDueDate?daysOffset=365partyIdFrom=CompanyinvoiceTypeId=SALES_INVOICEVIEW_SIZE_1=50VIEW_INDEX_1=1#; Ofbiz throws the following error: The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [invoiceTypeId] passed to secure (https) request-map with uri [findSalesInvoicesByDueDate] with an event that calls service [getInvoicePaymentInfoListByDueDateOffset]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A: dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs? It seems like all we get are unneeded comments and a few more
chunks to review.
But please don't take my comments as criticism, I appreciate the effort you're
putting in and have spent many hours doing similar work myself over the years.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 9/02/2011, at 12:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we
could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A: dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
smime.p7s
Description: S/MIME cryptographic signature
[jira] Created: (OFBIZ-4171) Blank year in UtilValidate.isYear should return false
Blank year in UtilValidate.isYear should return false - Key: OFBIZ-4171 URL: https://issues.apache.org/jira/browse/OFBIZ-4171 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Priority: Minor UtilValidate.isYear returns true for a blank year which the calling function UtilValidate.isDate(String, String, String) tries to parse. This causes an exception to be thrown ValidateMethod.java:96 :ERROR] [ValidateMethod.exec] Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null I found this error when trying to add a new credit card in the eCommerce checkout flow. # Add a product to the cart # login as any user I used admin # Checkout Step Shipping Address (Step 1: Where shall we ship it?) #* Click Next # Checkout Step Shipping Options (Step 2: How shall we ship it?) #* Choose UPS Air #* Click Next # Checkout Step Payment Options (Step 3: How shall you pay?) # Create Credit Card #* Fill Name #* Card Type Visa #* Card Number 4111 #* Expiration Date Month drop-down 01 #* Expiration Date Year drop-down leave blank #* Choose billing address #* Click Save button Should see Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null My fix is to change isYear, isMonth, and isDay to return false when a blank value is entered. After I make my change the message is The expiration date is before today -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4171) Blank year in UtilValidate.isYear should return false
[ https://issues.apache.org/jira/browse/OFBIZ-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-4171: - Attachment: OFBIZ-4171.patch Changes UtilValidate isYear, isMonth, and isDay to return false when a blank value is entered. Blank year in UtilValidate.isYear should return false - Key: OFBIZ-4171 URL: https://issues.apache.org/jira/browse/OFBIZ-4171 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Priority: Minor Attachments: OFBIZ-4171.patch UtilValidate.isYear returns true for a blank year which the calling function UtilValidate.isDate(String, String, String) tries to parse. This causes an exception to be thrown ValidateMethod.java:96 :ERROR] [ValidateMethod.exec] Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null I found this error when trying to add a new credit card in the eCommerce checkout flow. # Add a product to the cart # login as any user I used admin # Checkout Step Shipping Address (Step 1: Where shall we ship it?) #* Click Next # Checkout Step Shipping Options (Step 2: How shall we ship it?) #* Choose UPS Air #* Click Next # Checkout Step Payment Options (Step 3: How shall you pay?) # Create Credit Card #* Fill Name #* Card Type Visa #* Card Number 4111 #* Expiration Date Month drop-down 01 #* Expiration Date Year drop-down leave blank #* Choose billing address #* Click Save button Should see Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null My fix is to change isYear, isMonth, and isDay to return false when a blank value is entered. After I make my change the message is The expiration date is before today -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
I still continue to do it when stumble upon one/some. Fortunately there are
less and less.
I agree that not all of them are useful...
Jacques
Scott Gray wrote:
To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs? It seems like all we get are
unneeded comments and a few more chunks to review.
But please don't take my comments as criticism, I appreciate the effort you're
putting in and have spent many hours doing similar
work myself over the years.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 9/02/2011, at 12:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A: dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
smime.p7s
Description: S/MIME cryptographic signature
[jira] Commented: (OFBIZ-4158) Pagination Problem in Accounting Module
[ https://issues.apache.org/jira/browse/OFBIZ-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991952#comment-12991952 ] Jacques Le Roux commented on OFBIZ-4158: Thanks Naveen, I will have a look before tomorrow morning... Pagination Problem in Accounting Module --- Key: OFBIZ-4158 URL: https://issues.apache.org/jira/browse/OFBIZ-4158 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Environment: Ubuntu 10.04, Java(TM) SE Runtime Environment (build 1.6.0_15-b03) Reporter: Naveen Kumar N Labels: accounting, pagination Attachments: FindSalesInvoicesByDueDate.png, Screenshot.png Ofbiz Trunk Used (SVN Revision No): 1065553 In accounting module, the pagination is not working when the following request was performed. Requested URL: https://localhost:8443/accounting/control/findSalesInvoicesByDueDate?daysOffset=365partyIdFrom=CompanyinvoiceTypeId=SALES_INVOICEVIEW_SIZE_1=50VIEW_INDEX_1=1#; Ofbiz throws the following error: The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [invoiceTypeId] passed to secure (https) request-map with uri [findSalesInvoicesByDueDate] with an event that calls service [getInvoicePaymentInfoListByDueDateOffset]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4172) Managing of lot number and tracking
Managing of lot number and tracking --- Key: OFBIZ-4172 URL: https://issues.apache.org/jira/browse/OFBIZ-4172 Project: OFBiz Issue Type: New Feature Components: manufacturing, product Affects Versions: SVN trunk Reporter: Pierre TALLOTTE Priority: Minor Attachments: facility-tracking.patch This patch adds features who allows a user to managing all product by lot id : - when he buys a product, he can specify the lot id ; - at each time he produces an inventory item in manufacturing, he can specify the lot id ; - he can choose the lot he wants when he makes a sale order or a manufacturing process ; - there is a new screen who allows the user to realize the tracking of their lots. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4172) Managing of lot number and tracking
[ https://issues.apache.org/jira/browse/OFBIZ-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre TALLOTTE updated OFBIZ-4172: --- Attachment: facility-tracking.patch Managing of lot number and tracking --- Key: OFBIZ-4172 URL: https://issues.apache.org/jira/browse/OFBIZ-4172 Project: OFBiz Issue Type: New Feature Components: manufacturing, product Affects Versions: SVN trunk Reporter: Pierre TALLOTTE Priority: Minor Labels: lot, tracking Attachments: facility-tracking.patch This patch adds features who allows a user to managing all product by lot id : - when he buys a product, he can specify the lot id ; - at each time he produces an inventory item in manufacturing, he can specify the lot id ; - he can choose the lot he wants when he makes a sale order or a manufacturing process ; - there is a new screen who allows the user to realize the tracking of their lots. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4172) Managing of lot number and tracking
[ https://issues.apache.org/jira/browse/OFBIZ-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre TALLOTTE updated OFBIZ-4172: --- Attachment: facility-tracking.patch Managing of lot number and tracking --- Key: OFBIZ-4172 URL: https://issues.apache.org/jira/browse/OFBIZ-4172 Project: OFBiz Issue Type: New Feature Components: manufacturing, product Affects Versions: SVN trunk Reporter: Pierre TALLOTTE Priority: Minor Labels: lot, tracking Attachments: facility-tracking.patch, facility-tracking.patch This patch adds features who allows a user to managing all product by lot id : - when he buys a product, he can specify the lot id ; - at each time he produces an inventory item in manufacturing, he can specify the lot id ; - he can choose the lot he wants when he makes a sale order or a manufacturing process ; - there is a new screen who allows the user to realize the tracking of their lots. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: svn commit: r1068279 [1/2] - in /ofbiz/trunk/applications: order/entitydef/ order/script/org/ofbiz/order/olap/ order/script/org/ofbiz/order/reports/ order/servicedef/ order/webapp/ordermgr/WEB-INF
Yes you are right, this was given to me by my people affecting sales report and popular categories both using bi sales data We will try to avoid this in the future. Regards, Hans On Tue, 2011-02-08 at 09:42 +0100, Erwan de FERRIERES wrote: Le 08/02/2011 08:10, hans...@apache.org a écrit : Author: hansbak Date: Tue Feb 8 07:10:36 2011 New Revision: 1068279 URL: http://svn.apache.org/viewvc?rev=1068279view=rev Log: remove log messages from image managment, correct sales report and popular categories Modified: ofbiz/trunk/applications/order/entitydef/entitymodel_olap.xml ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml ofbiz/trunk/applications/order/script/org/ofbiz/order/reports/SalesReportEvent.xml ofbiz/trunk/applications/order/servicedef/services_olap.xml ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/CheckReportBy.groovy ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/SalesReport.groovy ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReport.rptdesign ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReportMonth.rptdesign ofbiz/trunk/applications/order/webapp/ordermgr/reports/SalesReportWeek.rptdesign ofbiz/trunk/applications/order/widget/ordermgr/ReportForms.xml ofbiz/trunk/applications/product/script/org/ofbiz/product/category/CategoryServices.xml ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml ofbiz/trunk/applications/product/servicedef/services.xml ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/showPeopleApprove.ftl Hi Hans, shouldn't this have been at least 2 commits ? Cheers, -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Agreed, so in this case we could remove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove
it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we
could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in
JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Hi Scott,
agreed I will try to reduce at minimum the use of FIXME in case of unused
variable but sometimes it's not easy to understand if it's correct to remove it
or not.
Thanks
Marco
Messaggio originale
Da: scott.g...@hotwaxmedia.com
Data: 08/02/2011 12.57
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs? It seems like all we get are unneeded comments and a few more
chunks to review.
But please don't take my comments as criticism, I appreciate the effort
you're putting in and have spent many hours doing similar work myself over the
years.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 9/02/2011, at 12:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove
it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we
could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A: dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in
JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
I understand you are working on a big task, and I truly appreciate all
of your work. I agree that someone else could follow along later and
fix some of these errors. But it would be easier for that person to
find the errors if they were not hidden by @suppress annotations.
-Adrian
Quoting mrisal...@libero.it mrisal...@libero.it:
Agreed, so in this case we could remove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove
it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we
could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in
JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
I agree it's easier for me (in Eclipse) to find red lines (dots actually) in a
page (class) than looking in the crowded FIXMEs list
Thanks Marco for all the hard work BTW!
Jacques
adrian.c...@sandglass-software.com wrote:
I understand you are working on a big task, and I truly appreciate all
of your work. I agree that someone else could follow along later and
fix some of these errors. But it would be easier for that person to
find the errors if they were not hidden by @suppress annotations.
-Adrian
Quoting mrisal...@libero.it mrisal...@libero.it:
Agreed, so in this case we could remove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
(original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Hi Jacques,
I have removed the last FIXME introduced by me on the last commits and now
those variables/method that was never used it's now removed.
What about the serial warnings, may I could add a @SuppressWarnings(serial) ?
Thanks
Marco
Il giorno 08/feb/2011, alle ore 20.55, Jacques Le Roux ha scritto:
I agree it's easier for me (in Eclipse) to find red lines (dots actually) in
a page (class) than looking in the crowded FIXMEs list
Thanks Marco for all the hard work BTW!
Jacques
adrian.c...@sandglass-software.com wrote:
I understand you are working on a big task, and I truly appreciate all
of your work. I agree that someone else could follow along later and
fix some of these errors. But it would be easier for that person to
find the errors if they were not hidden by @suppress annotations.
-Adrian
Quoting mrisal...@libero.it mrisal...@libero.it:
Agreed, so in this case we could remove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove
it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we
could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in
JNDIConfigUtil (OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
---
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java (original)
+++
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws
GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Yes, that's what we do generally. We don't use class serialisation, so it's the
better way
Jacques
risali...@gmail.com wrote:
Hi Jacques,
I have removed the last FIXME introduced by me on the last commits and now
those variables/method that was never used it's now
removed.
What about the serial warnings, may I could add a @SuppressWarnings(serial) ?
Thanks
Marco
Il giorno 08/feb/2011, alle ore 20.55, Jacques Le Roux ha scritto:
I agree it's easier for me (in Eclipse) to find red lines (dots actually) in a
page (class) than looking in the crowded FIXMEs
list
Thanks Marco for all the hard work BTW!
Jacques
adrian.c...@sandglass-software.com wrote:
I understand you are working on a big task, and I truly appreciate all
of your work. I agree that someone else could follow along later and
fix some of these errors. But it would be easier for that person to
find the errors if they were not hidden by @suppress annotations.
-Adrian
Quoting mrisal...@libero.it mrisal...@libero.it:
Agreed, so in this case we could remove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A: dev@ofbiz.apache.org
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
Messaggio originale
Da: jacques.le.r...@les7arts.com
Data: 08/02/2011 8.29
A:dev@ofbiz.apache.org
Ogg: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
Maybe there is a reason? Because I saw Marco fixing a lot of them...
Jacques
From: Adrian Crumadrian.c...@sandglass-software.com
It would be nice if we fixed the warnings instead of just hiding them.
-Adrian
On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
Author: mrisaliti
Date: Mon Feb 7 20:46:53 2011
New Revision: 1068120
URL: http://svn.apache.org/viewvc?rev=1068120view=rev
Log:
Remove compilation warnings of an unused private method in JNDIConfigUtil
(OFBIZ-4102)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
URL:
http://svn.apache.
org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
java?rev=1068120r1=1068119r2=1068120view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
(original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java
Mon Feb 7 20:46:53 2011
@@ -43,6 +43,7 @@ public class JNDIConfigUtil {
}
}
+@SuppressWarnings(unused)
private static Document getXmlDocument() throws GenericConfigException {
try {
return ResourceLoader.getXmlDocument(JNDIConfigUtil.
JNDI_CONFIG_XML_FILENAME);
Re: svn commit: r1068279 [1/2] - in /ofbiz/trunk/applications: order/entitydef/ order/script/org/ofbiz/order/olap/ order/script/org/ofbiz/order/reports/ order/servicedef/ order/webapp/ordermgr/WEB-INF
Le 08/02/2011 15:53, Hans Bakker a écrit : Yes you are right, this was given to me by my people affecting sales report and popular categories both using bi sales data We will try to avoid this in the future. Regards, Hans Thanks a lot ! Cheers, -- Erwan de FERRIERES www.nereide.biz
[jira] Created: (OFBIZ-4173) ATP requirement generation should look for ORDERED requirements attached to CANCELLED order items.
ATP requirement generation should look for ORDERED requirements attached to CANCELLED order items. -- Key: OFBIZ-4173 URL: https://issues.apache.org/jira/browse/OFBIZ-4173 Project: OFBiz Issue Type: Improvement Components: order Reporter: Ean Schuessler Priority: Minor The createATPRequirementsForOrder method currently subtracts any PENDING requirements from the amount needed to fulfill orders before creating additional requirements. It seems like it would also be useful for this method to look for ORDERED requirements that are associated with CANCELLED order items. This would prevent the system from generating additional requirements for stock that is actually available for allocation to new orders. Is there some kind of race condition or other problem I'm not seeing here? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
quote/order term/datamodelbook discrepancy
Hi OFBiz developers. There is currently a discrepancy between quote- and order terms and the data model resource book: they are all different. I already added some fields to quote term to at least remove that difference. The problem now is with the order and quote terms that it is not possible to add a term to a whole quote or order: itemSeqId cannot be null so it is not possible to add a term for the whole quote. This is solved in the order by filling _NA_ in the itemSeqId and create a dummy _NA_ item. According to me not a nice solution. So for quote i would not like to not follow this pattern and would rather allow null in the itemSeqId field in quoteterm to make the change as easy as possible. The datamodel book is also not inconsistent having termtype in quote term in the prim key and in orderterm not. itemSeqId in the book is for both entities not in the prim key. termId is the key here Any opinions? Regards, Hans -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
