[GitHub] [openoffice] leginee commented on pull request #167: Translate German comments in swhtml.cxx
leginee commented on PR #167: URL: https://github.com/apache/openoffice/pull/167#issuecomment-1574667758 Thanks Arrigo for the review. Very nice suggestions. can you check [these lines please](https://github.com/apache/openoffice/blob/cd8df0c879df4c07f6fa5a97c3d5f3ceaa9d50b5/main/sw/source/filter/html/swhtml.hxx#L797-L807) the code looks odd. I think there is an ); to much in line 802 but this is not a translation issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a diff in pull request #167: Translate German comments in swhtml.cxx
leginee commented on code in PR #167:
URL: https://github.com/apache/openoffice/pull/167#discussion_r1215216406
##
main/sw/source/filter/html/swhtml.hxx:
##
@@ -204,40 +204,40 @@ struct _HTMLAttrTable
class _HTMLAttrContext_SaveDoc;
enum SwHTMLAppendMode {
-AM_NORMAL, // keine Absatz-Abstand-Behandlung
-AM_NOSPACE,// Abstand hart auf 0cm setzen
-AM_SPACE, // Abstand hart auf 0.5cm setzen
-AM_SOFTNOSPACE,// Abstand nicht setzen aber 0cm merken
-AM_NONE// gar kein Append
+AM_NORMAL, // no paragraph spacing treatment
+AM_NOSPACE,// Set distance hard to 0cm
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: blog migration
Sent from my iPhone > On Jun 2, 2023, at 9:10 PM, Peter Kovacs wrote: > > >> Am 03.06.23 um 01:42 schrieb Dave Fisher: >> Excellent work! Thank you! > Drew and Chris helped a lot. They deserve our thanks. As always the ASF Infrastructure is first class. >> >> Sent from my iPhone >> On Jun 2, 2023, at 2:10 PM, Peter Kovacs wrote: >>> >>> Hi all, >>> >>> >>> The roller migration can be reviewed at [1]. >>> >>> Please, have a look through the page if something broke that I missed. Or >>> Other things we need to look at. >>> >>> All pages where moved into a page sub folder. In folder blogs all our blog >>> post can be found. >>> >>> >>> Open Points fron my side: >>> >>> # FAQ - Blog needs to be rewritten >> https://openoffice-blog-migration.staged.apache.org/pmc-faqs.html >> >> Correct? This can follow on separately. > > yes. I made the list so it becomes easier to construct a project backlog or > similar (see other thread looking for Contributor "campaign"). I agree there are many updates that would help the project. Maybe start creating GitHub issues in OpenOffice-project? Best, Dave > >>> # figure out how we can automate the Announcement part in General about >>> >>> # fixate the banner and menu on top without overlap effect >> I didn’t see any problems on my iPhone browser. >> >> +1 to publish! >> >> Best, >> Dave >>> >>> All the best >>> >>> Peter >>> >>> >>> [1]https://openoffice-blog-migration.staged.apache.org/index.html >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a diff in pull request #167: Translate German comments in swhtml.cxx
leginee commented on code in PR #167: URL: https://github.com/apache/openoffice/pull/167#discussion_r1215191573 ## main/sw/source/filter/html/swhtml.hxx: ## @@ -94,14 +94,14 @@ class _HTMLAttr SwNodeIndex nSttPara, nEndPara; xub_StrLen nSttCntnt, nEndCntnt; sal_Bool bInsAtStart : 1; - sal_Bool bLikePara : 1; // Attribut ueber dem gesamten Absatz setzen - sal_Bool bValid : 1;// ist das Attribut gueltig? + sal_Bool bLikePara : 1; // Set attribute over the entire paragraph + sal_Bool bValid : 1;// is the attribute valid? SfxPoolItem* pItem; - sal_uInt16 nCount; // Anzahl noch zu schliessender Attrs mit einem Wert - _HTMLAttr *pNext; // noch zu schliessene Attrs mit unterschiedl. Werten - _HTMLAttr *pPrev; // bereits geschlossene aber noch nicht gesetze Attrs - _HTMLAttr **ppHead; // der Listenkopf + sal_uInt16 nCount; // Number of attrs still to be closed with a value of + _HTMLAttr *pNext; // Attrs with different values still to be closed. Values Review Comment: This is awkward too. How about: `open attrs, with different values` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: blog migration
Am 03.06.23 um 01:42 schrieb Dave Fisher: Excellent work! Thank you! Drew and Chris helped a lot. They deserve our thanks. Sent from my iPhone On Jun 2, 2023, at 2:10 PM, Peter Kovacs wrote: Hi all, The roller migration can be reviewed at [1]. Please, have a look through the page if something broke that I missed. Or Other things we need to look at. All pages where moved into a page sub folder. In folder blogs all our blog post can be found. Open Points fron my side: # FAQ - Blog needs to be rewritten https://openoffice-blog-migration.staged.apache.org/pmc-faqs.html Correct? This can follow on separately. yes. I made the list so it becomes easier to construct a project backlog or similar (see other thread looking for Contributor "campaign"). # figure out how we can automate the Announcement part in General about # fixate the banner and menu on top without overlap effect I didn’t see any problems on my iPhone browser. +1 to publish! Best, Dave All the best Peter [1]https://openoffice-blog-migration.staged.apache.org/index.html - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: blog migration
Excellent work! Thank you! Sent from my iPhone > On Jun 2, 2023, at 2:10 PM, Peter Kovacs wrote: > > Hi all, > > > The roller migration can be reviewed at [1]. > > Please, have a look through the page if something broke that I missed. Or > Other things we need to look at. > > All pages where moved into a page sub folder. In folder blogs all our blog > post can be found. > > > Open Points fron my side: > > # FAQ - Blog needs to be rewritten https://openoffice-blog-migration.staged.apache.org/pmc-faqs.html Correct? This can follow on separately. > > # figure out how we can automate the Announcement part in General about > > # fixate the banner and menu on top without overlap effect I didn’t see any problems on my iPhone browser. +1 to publish! Best, Dave > > > All the best > > Peter > > > [1]https://openoffice-blog-migration.staged.apache.org/index.html > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org >
blog migration
Hi all, The roller migration can be reviewed at [1]. Please, have a look through the page if something broke that I missed. Or Other things we need to look at. All pages where moved into a page sub folder. In folder blogs all our blog post can be found. Open Points fron my side: # FAQ - Blog needs to be rewritten # figure out how we can automate the Announcement part in General about # fixate the banner and menu on top without overlap effect All the best Peter [1]https://openoffice-blog-migration.staged.apache.org/index.html - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
