Re: [sidebar] warning in module svx during build

2013-02-15 Thread Andre Fischer

On 14.02.2013 11:23, Oliver-Rainer Wittmann wrote:

Hi,

I am currently building branch sidebar, revision 1444704.

I observed the following warning during the build in module svx:
warning
Text [ en-US ] = Color Light Preview;
^
f4099: c:/AOO/sources/sidebar/main/svx/source/engine3d/float3d.src, 
line 1440: Warning in the object (Type: String, 162):

Global resources should have an identifier = 256.
/warning

Is this a critical warning?


Probably not, because the comment indicates that this is a change for an 
early, incomplete and not integrated changes for iAccessible2.  That 
means that the string is probably not used.


There are two ways to fix this:

- Remove the string after making sure that it is really not used.

- Move it a couple of lines up into the

   DockingWindow RID_SVXFLOAT_3D
   {
   ...
   }

   block, where it, according to svx/inc/float3d.hrc belongs.


Oh, and we can ignore it, of course.

-Andre



Re: [sidebar] warning in module svx during build

2013-02-15 Thread Oliver-Rainer Wittmann

Hi,

On 15.02.2013 11:37, Andre Fischer wrote:

On 14.02.2013 11:23, Oliver-Rainer Wittmann wrote:

Hi,

I am currently building branch sidebar, revision 1444704.

I observed the following warning during the build in module svx:
warning
Text [ en-US ] = Color Light Preview;
^
f4099: c:/AOO/sources/sidebar/main/svx/source/engine3d/float3d.src,
line 1440: Warning in the object (Type: String, 162):
Global resources should have an identifier = 256.
/warning

Is this a critical warning?


Probably not, because the comment indicates that this is a change for an
early, incomplete and not integrated changes for iAccessible2.  That
means that the string is probably not used.

There are two ways to fix this:

- Remove the string after making sure that it is really not used.

- Move it a couple of lines up into the

DockingWindow RID_SVXFLOAT_3D
{
...
}

block, where it, according to svx/inc/float3d.hrc belongs.


Oh, and we can ignore it, of course.



Thanks for the response.

Thus, we have this warning which can be ignored also on trunk. Right?


Best regards, Oliver.


Re: [sidebar] warning in module svx during build

2013-02-15 Thread Andre Fischer
On Feb 15, 2013 12:09 PM, Oliver-Rainer Wittmann 
orwittm...@googlemail.com wrote:

 Hi,


 On 15.02.2013 11:37, Andre Fischer wrote:

 On 14.02.2013 11:23, Oliver-Rainer Wittmann wrote:

 Hi,

 I am currently building branch sidebar, revision 1444704.

 I observed the following warning during the build in module svx:
 warning
 Text [ en-US ] = Color Light Preview;
 ^
 f4099: c:/AOO/sources/sidebar/main/svx/source/engine3d/float3d.src,
 line 1440: Warning in the object (Type: String, 162):
 Global resources should have an identifier = 256.
 /warning

 Is this a critical warning?


 Probably not, because the comment indicates that this is a change for an
 early, incomplete and not integrated changes for iAccessible2.  That
 means that the string is probably not used.

 There are two ways to fix this:

 - Remove the string after making sure that it is really not used.

 - Move it a couple of lines up into the

 DockingWindow RID_SVXFLOAT_3D
 {
 ...
 }

 block, where it, according to svx/inc/float3d.hrc belongs.


 Oh, and we can ignore it, of course.


 Thanks for the response.

 Thus, we have this warning which can be ignored also on trunk. Right?

I think so, but it would still be better to fix this.  There could be a
collision of ids with very subtle errors.

-Andre



 Best regards, Oliver.


[sidebar] warning in module svx during build

2013-02-14 Thread Oliver-Rainer Wittmann

Hi,

I am currently building branch sidebar, revision 1444704.

I observed the following warning during the build in module svx:
warning
Text [ en-US ] = Color Light Preview;
^
f4099: c:/AOO/sources/sidebar/main/svx/source/engine3d/float3d.src, 
line 1440: Warning in the object (Type: String, 162):

Global resources should have an identifier = 256.
/warning

Is this a critical warning?


Thanks in advance, Oliver.