Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
If you read through the LO bug report, you'll see that there are many patches for this bug, affecting multiple modules. Why? The historical files that are valid but have the wrong checksum due to having been written by the broken [OO.org-derivative] implementations when they were created, will still be accepted as valid by future versions of LO. I think they have quite an involved bug fix, with new UI dialogs for those cases, etc. On Sat, Jul 27, 2019 at 9:50 AM Peter Kovacs wrote: > Hi Brane, > > This is a very nice Idea. Maybe even beyond the immediate idea on fixing > the SHA implementation. > > Thanks a lot for this Idea. > > > All the Best > > Peter > > On 26.07.19 12:36, Branko Čibej wrote: > > On 25.07.2019 00:43, Peter Kovacs wrote: > >> Hello all, > >> > >> > >> I would like to ask if I or any other from OpenOffice Development team > >> can port the patch from LibreOffice to OpenOffice to fix this Issue > >> under the APL2 License, so the Issue can be fixed in OpenOffice without > >> more work then necessary. > > > > Would it be appropriate to use the hash code from APR > > (https://apr.apacha.org)? The license fits, and that code has been > > stable and well tested for ages. But I'm not sure if it fits your FIPS > > compliance requirements. > > > > -- Brane > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
Hi Brane, This is a very nice Idea. Maybe even beyond the immediate idea on fixing the SHA implementation. Thanks a lot for this Idea. All the Best Peter On 26.07.19 12:36, Branko Čibej wrote: > On 25.07.2019 00:43, Peter Kovacs wrote: >> Hello all, >> >> >> I would like to ask if I or any other from OpenOffice Development team >> can port the patch from LibreOffice to OpenOffice to fix this Issue >> under the APL2 License, so the Issue can be fixed in OpenOffice without >> more work then necessary. > > Would it be appropriate to use the hash code from APR > (https://apr.apacha.org)? The license fits, and that code has been > stable and well tested for ages. But I'm not sure if it fits your FIPS > compliance requirements. > > -- Brane > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
OT: Welcome back Rafael! On 25.07.19 22:57, Raphael Bircher wrote: > If the code is released from the original author under Apache License > v2.0 then we can include it, else we have to write our own solution > > On Thu, Jul 25, 2019 at 9:54 PM Keith N. McKenna > wrote: >> On 7/25/2019 1:26 PM, Peter Kovacs wrote: >>> Call me naive. I wanted to have the question asked. No one should say that >>> we did not try it this way. >>> >>> Am 25. Juli 2019 09:38:28 MESZ schrieb Bidouille : - Mail original - > I believe that unless the LO developer agrees to license it also > under the ALv2 we cannot commit it to our code base. +1 The author is Michael Stahl, employed at CIB GmbH. This company is copyleft addicted and LibO side only. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org >> Peter; >> >> For other questions around handling other licenses see the 3rd Party >> License Policy at https://www.apache.org/legal/resolved.html >> > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
On 25.07.2019 00:43, Peter Kovacs wrote: > Hello all, > > > I would like to ask if I or any other from OpenOffice Development team > can port the patch from LibreOffice to OpenOffice to fix this Issue > under the APL2 License, so the Issue can be fixed in OpenOffice without > more work then necessary. Would it be appropriate to use the hash code from APR (https://apr.apacha.org)? The license fits, and that code has been stable and well tested for ages. But I'm not sure if it fits your FIPS compliance requirements. -- Brane - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
OT: Hi, Raphael - wb Regards Michael signature.asc Description: OpenPGP digital signature
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
If the code is released from the original author under Apache License v2.0 then we can include it, else we have to write our own solution On Thu, Jul 25, 2019 at 9:54 PM Keith N. McKenna wrote: > > On 7/25/2019 1:26 PM, Peter Kovacs wrote: > > Call me naive. I wanted to have the question asked. No one should say that > > we did not try it this way. > > > > Am 25. Juli 2019 09:38:28 MESZ schrieb Bidouille : > >> > >> > >> - Mail original - > >>> I believe that unless the LO developer agrees to license it also > >>> under the ALv2 we cannot commit it to our code base. > >> +1 > >> The author is Michael Stahl, employed at CIB GmbH. > >> This company is copyleft addicted and LibO side only. > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > >> For additional commands, e-mail: dev-h...@openoffice.apache.org > > > Peter; > > For other questions around handling other licenses see the 3rd Party > License Policy at https://www.apache.org/legal/resolved.html > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
On 7/25/2019 1:26 PM, Peter Kovacs wrote: > Call me naive. I wanted to have the question asked. No one should say that we > did not try it this way. > > Am 25. Juli 2019 09:38:28 MESZ schrieb Bidouille : >> >> >> - Mail original - >>> I believe that unless the LO developer agrees to license it also >>> under the ALv2 we cannot commit it to our code base. >> +1 >> The author is Michael Stahl, employed at CIB GmbH. >> This company is copyleft addicted and LibO side only. >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org > Peter; For other questions around handling other licenses see the 3rd Party License Policy at https://www.apache.org/legal/resolved.html signature.asc Description: OpenPGP digital signature
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
Call me naive. I wanted to have the question asked. No one should say that we did not try it this way. Am 25. Juli 2019 09:38:28 MESZ schrieb Bidouille : > > >- Mail original - >> I believe that unless the LO developer agrees to license it also >> under the ALv2 we cannot commit it to our code base. >+1 >The author is Michael Stahl, employed at CIB GmbH. >This company is copyleft addicted and LibO side only. > >- >To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
- Mail original - > I believe that unless the LO developer agrees to license it also > under the ALv2 we cannot commit it to our code base. +1 The author is Michael Stahl, employed at CIB GmbH. This company is copyleft addicted and LibO side only. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
On 7/24/2019 6:43 PM, Peter Kovacs wrote: > Hello all, > > > I would like to ask if I or any other from OpenOffice Development team > can port the patch from LibreOffice to OpenOffice to fix this Issue > under the APL2 License, so the Issue can be fixed in OpenOffice without > more work then necessary. > > LO Issue: 114939 > > OO Issue: 127661 > > Thanks for your considerations. > > > All the Best > > Peter > Peter; I believe that unless the LO developer agrees to license it also under the ALv2 we cannot commit it to our code base. Regards Keith signature.asc Description: OpenPGP digital signature
