Re: win32 and apache_1.3.19

2001-04-27 Thread Doug MacEachern 

On Fri, 27 Apr 2001, Randy Kobes wrote:
 
 that's great ... this is done in the attached patch (against today's
 cvs mod_perl), and all works with perl-5.6.1 and apache_1.3.19.
 i also included in this patch the earlier patches for getting the
 right apache_1.3.19 inc directories, inserting some win32-specific
 values in Apache::MyConfig, and changing some apache paths
 in mod_perl.dsp to more generic values. 

cool, applied, thanks!


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: win32 and apache_1.3.19

2001-04-23 Thread Randy Kobes 

- Original Message - 
From: Randy Kobes [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Monday, April 23, 2001 1:25 AM
Subject: win32 and apache_1.3.19


 Hi,
 Apache_1.3.19 on Win32 has changed the way os.h in
 the apache source tree is included, so that mod_perl no
 longer finds it if built via command-line arguments. I've
 attached a patch against the cvs mod_perl which builds
 a mod_perl.dsp to include the relevant apache directory.
This patch also includes the t/TEST.win32 patch sent
 earlier to account for the fact that apache_1.3.19 on Win32
 sets the relative server root to the path to the apache binary, 
 so that $Apache::Server::CWD in t/docs/startup.pl and t/docs/rl.pl
 points to the path of the apache binary, rather than the mod_perl
 build directory, and subsequently the tests get confused
 since @INC doesn't contain the mod_perl build directory.
 Finally, there's some changes in mod_perl.dsp to use some
 generic include and lib paths - these don't really matter, as
 they have to be set anyway for the local system, but this
 may make the needed changes more obvious to a
 user if things are configured manually.

Additionally, a recent patch to the top-level Makefile.PL
removed some Win32-specific values that were
present in Apache::MyConfig that recorded the mod_perl
and apache paths used to build mod_perl. These are put
back in in the attached patch, which also includes the
patches described above.

best regards,
randy kobes


 win32.patch

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: win32 and apache_1.3.19

2001-04-23 Thread Doug MacEachern 

On Mon, 23 Apr 2001, Randy Kobes wrote:

This patch also includes the t/TEST.win32 patch sent
 earlier to account for the fact that apache_1.3.19 on Win32
 sets the relative server root to the path to the apache binary, 
 so that $Apache::Server::CWD in t/docs/startup.pl and t/docs/rl.pl
 points to the path of the apache binary, rather than the mod_perl
 build directory, and subsequently the tests get confused
 since @INC doesn't contain the mod_perl build directory.

did you see my reply to your original message (included below) ?
thanks as always randy!

From [EMAIL PROTECTED] Tue Apr 17 15:20:39 2001 -0700
Status: 
X-Status: 
X-Keywords:
Date: Tue, 17 Apr 2001 15:20:39 -0700 (PDT)
From: Doug MacEachern [EMAIL PROTECTED]
To: Randy Kobes [EMAIL PROTECTED]
cc: [EMAIL PROTECTED]
Subject: Re: relative ServerRoot in Win32
In-Reply-To: 005e01c0c521$32c2e540$443fc8cd@oemcomputer
Message-ID: [EMAIL PROTECTED]
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Sat, 14 Apr 2001, Randy Kobes wrote:

 Hi,
One of the changes in apache_1.3.19 for Win32 is that the
 relative ServerRoot was changed to root to the path
 of the apache binary. This has the effect of setting
 $Apache::Server::CWD in t/docs/startup.pl and t/docs/rl.pl
 to the path of the apache binary, rather than the mod_perl
 build directory, and subsequently the tests can't be run
 since @INC doesn't contain the mod_perl build directory.
 The following patch against mod_perl-1.25, tested on
 apache_1.3.19 and perl-5.6.1, fixes this by simply
 substituting the mod_perl build directory for
 $Apache::Server::CWD in these two files.

i'd rather not iedit those files.  will something like the patch below
solve the problem?  thanks randy.

Index: Makefile.PL
===
RCS file: /home/cvs/modperl/Makefile.PL,v
retrieving revision 1.179
diff -u -r1.179 Makefile.PL
--- Makefile.PL 2001/04/17 21:38:52 1.179
+++ Makefile.PL 2001/04/17 22:20:02
@@ -95,6 +95,7 @@
 $Apache::MyConfig::Setup{Apache_Src} ; 
 
 my $PWD = cwd;
+$ENV{APACHE_CWD} = $PWD;
 $ENV{PERL5LIB} = $PWD/lib;
 
 my %SSL = (
Index: t/docs/startup.pl
===
RCS file: /home/cvs/modperl/t/docs/startup.pl,v
retrieving revision 1.40
diff -u -r1.40 startup.pl
--- t/docs/startup.pl   2000/12/23 00:32:21 1.40
+++ t/docs/startup.pl   2001/04/17 22:20:08
@@ -5,6 +5,10 @@
 }
 
 BEGIN {
+$Apache::Server::CWD = $ENV{APACHE_CWD} if $ENV{APACHE_CWD};
+}
+
+BEGIN {
 #./blib/lib:./blib/arch
 use ExtUtils::testlib;
 
Index: t/conf/httpd.conf-dist
===
RCS file: /home/cvs/modperl/t/conf/httpd.conf-dist,v
retrieving revision 1.32
diff -u -r1.32 httpd.conf-dist
--- t/conf/httpd.conf-dist  2000/09/26 16:55:41 1.32
+++ t/conf/httpd.conf-dist  2001/04/17 22:20:14
@@ -55,7 +55,7 @@
 #mod_perl stuff
 
 
-PerlPassEnv TERM EDITOR NOCHANCE USER PERL5LIB
+PerlPassEnv TERM EDITOR NOCHANCE USER PERL5LIB APACHE_CWD
 PerlSetEnv KeyForPerlSetEnv OK
 PerlSetVar KeyForPerlSetVar OK
  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]