Re: [PATCH] Version for Apache2.pm

[Leon Brocard]

Doug MacEachern sent the following bits through the ether:

> Apache2.pm is generated, no problem to add a $VERSION.  i don't think it 
> should be the same as $mod_perl::VERSION, or do you need it to be?

No, as long as it has a version anything is fine ;-)

Leon
-- 
Leon Brocard.http://www.astray.com/
scribot.http://www.scribot.com/

... Forty-two, said Deep Thought, with infinite majesty and calm

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: modperl-2.0 STATUS

[Randy Kobes]

On 1 Jan 2003 [EMAIL PROTECTED] wrote:

> dougm   2003/01/01 10:43:51
> 
>   Modified:.STATUS
>   Log:
>   must be fixed before 1.99_08
>   
>   Revision  ChangesPath
>   1.28  +3 -5  modperl-2.0/STATUS
>   
>   + * Makefile.PL process ugly "unknown typemap" warnings must go away

What about something like the following?


Index: lib/ModPerl/TypeMap.pm
===
RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/TypeMap.pm,v
retrieving revision 1.18
diff -u -r1.18 TypeMap.pm
--- lib/ModPerl/TypeMap.pm  30 Dec 2002 00:27:13 -  1.18
+++ lib/ModPerl/TypeMap.pm  1 Jan 2003 22:33:58 -
@@ -6,6 +6,7 @@
 use ModPerl::FunctionMap ();
 use ModPerl::StructureMap ();
 use ModPerl::MapUtil qw(list_first);
+use Apache::TestTrace qw(debug);
 
 our @ISA = qw(ModPerl::MapBase);
 
@@ -235,7 +236,7 @@
 map $_->{type}, @{ $func->{args} });
 
 unless ($status) {
-warn "unknown typemap: '$failed_type' (skipping $func->{name})\n";
+debug "unknown typemap: '$failed_type' (skipping $func->{name})\n";
 return;
 }
 


-- 
best regards,
randy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: modperl-2.0 STATUS

[Stas Bekman]

Randy Kobes wrote:

On 1 Jan 2003 [EMAIL PROTECTED] wrote:



dougm   2003/01/01 10:43:51

 Modified:.STATUS
 Log:
 must be fixed before 1.99_08
 
 Revision  ChangesPath
 1.28  +3 -5  modperl-2.0/STATUS
 
 + * Makefile.PL process ugly "unknown typemap" warnings must go away


What about something like the following?


Index: lib/ModPerl/TypeMap.pm
===
RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/TypeMap.pm,v
retrieving revision 1.18
diff -u -r1.18 TypeMap.pm
--- lib/ModPerl/TypeMap.pm	30 Dec 2002 00:27:13 -	1.18
+++ lib/ModPerl/TypeMap.pm	1 Jan 2003 22:33:58 -
@@ -6,6 +6,7 @@
 use ModPerl::FunctionMap ();
 use ModPerl::StructureMap ();
 use ModPerl::MapUtil qw(list_first);
+use Apache::TestTrace qw(debug);
 
 our @ISA = qw(ModPerl::MapBase);
 
@@ -235,7 +236,7 @@
 map $_->{type}, @{ $func->{args} });
 
 unless ($status) {
-warn "unknown typemap: '$failed_type' (skipping $func->{name})\n";
+debug "unknown typemap: '$failed_type' (skipping $func->{name})\n";
 return;
 }

This is the same as saying
  #warn "unknown...
because the default level is 'info' and there is no way to enable 
'debug', without changing the code. TestTrace is a testing package, not 
a build package. You can modify the trace level in TestTrace when you 
run TestRun: t/TEST -trace=debug
Seems like we have used a bunch of trace calls in the build code which 
will never be invoked, which should be fixed as well.

I think the right solution in this particular case is to fix the map 
files. These unresolved types has be fixed anyways before the skipped 
functions can be enabled.

__
Stas BekmanJAm_pH --> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]