[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2

2023-04-03 Thread via GitHub


mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1494635543

   you are saying that struts 2.5.30+ is not compatible with the bootstrap 
(plugin) version roller uses at the moment? I assumed it might have something 
to do with the double evaluation fix which is mentioned on the struts release 
notes. I hoped there might be a chance to update struts without bootstrap for 
now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub


mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1480915374

   i wouldn't recommend to skip so many major versions at once, this rarely 
works. The very next minor release already causes problems.
   migration guide
   https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub


mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1480832131

   > Were there any failing tests?
   
   yes. see CI. Or try starting roller and open the management UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org