Re: [sc-dev] patch for i71814
hi,erAck: The original position of text is up to aPaperSize and nTextWidth,but the value of aPaperSize in the function is 100 which is fixed.It ignores the length of cell and text,so if the length of text is longer than cell's width,it has to be reset. Yes,as you said aOutputArea and aLogicEdit are essentially the same,so aOutputArea can be replaced with aLogicEdit. Best regards! - Original Message - From: Eike Rathke [EMAIL PROTECTED] To: dev@sc.openoffice.org Sent: Wednesday, November 21, 2007 3:10 AM Subject: Re: [sc-dev] patch for i71814
Re: [sc-dev] patch for i71814
Hi YunJingtao, On Thursday, 2007-11-15 17:13:34 +0800, YunJingtao wrote: aLogicEdit is to show the area of hyperlink with mouse,when the text is beyond the cell border, border of aLogicEdit has to be coordinated with cell. the coordinates of text and mouse are different, and it leads to the result.Findings is shown in ImpEditEngine::GetChar. the original position of text is up to aPaperSize and nTextWidth, position of mouse is up to aTempView and OutputArea. Well, yes, I think we know what the variables are used for, but that doesn't explain why setting a new paper width would be necessary, as it is done in the patch. Also, the portion around if ( nTextWidth nThisColLogic ) introduced in the patch is very similar to the already existing one near line 4741 if ( nTextWidth nThisColLogic ) that treats the aLogicEdit's nStartX, so I wonder whether it is coincidence that these cases differ from the default path, or maybe could be rewritten to generalize the behavior. This especially because Rectangle aOutputArea = PixelToLogic( aEditRect, aEditMode ); is essentially the same as Rectangle aLogicEdit = PixelToLogic( aEditRect, aEditMode ); at line 4705 (line numbers as present in m236). Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks. pgpaX37UMSAhn.pgp Description: PGP signature
Re: [sc-dev] patch for i71814
hi,erAck: Yes, you are right. I will do that from now on. aLogicEdit is to show the area of hyperlink with mouse,when the text is beyond the cell border, border of aLogicEdit has to be coordinated with cell. the coordinates of text and mouse are different, and it leads to the result.Findings is shown in ImpEditEngine::GetChar. the original position of text is up to aPaperSize and nTextWidth, position of mouse is up to aTempView and OutputArea. - Original Message - From: Eike Rathke [EMAIL PROTECTED] To: dev@sc.openoffice.org Sent: Wednesday, November 14, 2007 1:38 AM Subject: Re: [sc-dev] patch for i71814
Re: [sc-dev] patch for i71814
Hi YunJingtao, On Tuesday, 2007-11-13 16:33:44 +0800, YunJingtao wrote: A patch for i71814 was submitted.Check it! I don't know whether it's satisfied, if not, please give some advice. It would be nice if you not just attached some patch to the issue but also explained what your findings were, what the problem was, what the patch changes and why it would be a solution. Or at least some of that ;-) This would ease discussion a bit, I think. Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks. pgpfx2pKGa4uC.pgp Description: PGP signature
