[VOTE RESULT] Parent POM 18
The vote was successful with 5 binding +1 votes No other votes have been cast Thanks for voting Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [Cassandra Resource] Create Update Sling Resource
Hi, Thanks, now I see how you're doing it. Its good. So to do a Write (CUD[1]) test, create another class that extends HttpBaseTest and write a test method that invokes testClient.createNode(...) with an appropriate set of properties and a collection managed by the CassandraProvider. You will probably need to create that collection first, and its parent, or better still, reuse the existing pre-populated collections since we are looking for the scalability of CUD relative to collection size. I think if you use createNode on an existing node it will update it, and there is a delete method as well. testClient is a org.apache.sling.commons.testing.integration.SlingIntegrationTestClient and is protected in HttpBaseTest so you should have access. As I said, perform CUD on 100 new nodes in each collection and print the results out. Obviously add all new code to you repository so its all in one place. Best Regards Ian 1 Create Update Delete (you've done read, we need stats for each of these operations) On 6 September 2013 04:31, Dishara Wijewardana ddwijeward...@gmail.com wrote: Hi Ian, Done. On Thu, Sep 5, 2013 at 10:53 AM, Ian Boston i...@tfd.co.uk wrote: Hi Dishara, On Thursday, September 5, 2013, Dishara Wijewardana wrote: Hi Ian, Did you mean the sling integration test (which runs the performance tests and provides reports) to move inside google code repo ? Yes please. Thanks Best regards Ian On Wed, Sep 4, 2013 at 5:41 PM, Ian Boston i...@tfd.co.uk wrote: On 4 September 2013 13:42, Dishara Wijewardana ddwijeward...@gmail.com wrote: HI Ian, On Wed, Sep 4, 2013 at 4:00 PM, Ian Boston i...@tfd.co.uk wrote: On 4 September 2013 12:20, Dishara Wijewardana ddwijeward...@gmail.com wrote: snip How long does it take to add, update and delete, 100 new items to the existing collections that you used for the read tests. If its quick, you may need to make that 1000 new items. Hi Ian, In the modify provider interface there is no update method. Am I missing something? You need to support adapTo(ModifyableValueMap.class) IIRC. I saw the interface ModifyableValueMap, but could not find a clear example usage of it as in PlanetResource case. But will see further. IIRC the MongoDB ResourceProvider allows modification. grep the Sling source code for it. Can you please elaborate more on exact scope and goals on what is expected from the new performance test class?Is it to capture the add/delete latency on nodes added in each collection. yes. If so, is it possible to test add/delete extending HTTPBase test as done for reading ? Or any other class that provides abstract test class/ APIs to add/delete ? Where are the classes that you used to perform the read tests, I cant see them in the repo ? The class that I used was org.apache.sling.commons.testing.integration.HttpTestBase . I have attached the patch of my class which extends this class. There I am usinf getContent() method of the base class to do HTTP get content operations. Could we get your test classes to run the load test into your repository please, even if its something that has to be run manually. Thanks Best Regards Ian Ian Best regards Ian Best Regards Ian On 3 September 2013 01:23, Dishara Wijewardana ddwijeward...@gmail.comjavascript:; wrote: Hi Ian, Thank you for the references. I just commited the changes. There I have completed the whole implementation of ModifyingResourceProvider interface for Cassandra Resource Provider (create, delete, commit , rollback etc) and wrote 3 test classes ( CassandraModifyResourceProvide**rAddTest, Cassan draModif-- Thanks /Dishara -- Thanks /Dishara
[jira] [Commented] (SLING-3028) Support for progress tracking of jobs
[ https://issues.apache.org/jira/browse/SLING-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760055#comment-13760055 ] Carsten Ziegeler commented on SLING-3028: - The JobExecutionContext is more than just progress tracking, it provides a log and the feedback for async handlers. For timestamps, yes, the log would contain the timestamp of the log message provided. I'm not happy with the progress tracking api yet, the general idea is that a job consumer calls first start() to indicate that it's able to track progress (not every job consumer is able to do so). With the start method, the consumer gives a hint (if possible) when processing might be finished (either a count, or an ETA - number of seconds from now). During processing it updates this information and/or the current state (ETA can be updated, step count can be set). I've committed an updated version of the API (where I also changed the feedback for async processing) Support for progress tracking of jobs - Key: SLING-3028 URL: https://issues.apache.org/jira/browse/SLING-3028 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Victor Saar Labels: jobs For long-running jobs, it would be useful to have some means to track progress, which can be shown in a console for the user. This should include the following: * ETA * Completeness value computed from (optional, defaults to 1.0) max and current value (e.g. 42% or 23/100) * Log output stream for detailed progress information * Failure reason in case job failed AFAICS this requires a few changes to the existing implementation: * Jobs need additional support for setting properties, e.g. max and current progress value * Jobs need to be kept at least for a while after they completed/failed to give access to failure information/log stream -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3037) IllegalArgumentException in logback Logger
[ https://issues.apache.org/jira/browse/SLING-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-3037: Affects Version/s: (was: Scripting Core 2.0.24) IllegalArgumentException in logback Logger -- Key: SLING-3037 URL: https://issues.apache.org/jira/browse/SLING-3037 Project: Sling Issue Type: Bug Components: Engine Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Scripting Core 2.0.26 Attachments: SLING-3037.patch Since switching to logback in SLING-2024, a number of integration tests are failing, typical stack trace: java.lang.IllegalArgumentException: For logger [apps.integration-test] child name [apps.integration-test.srt$1378284549103 passed as parameter, may not include '.' after index22 at ch.qos.logback.classic.Logger.createChildByName(Logger.java:357) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:143) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:45) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:253) at org.apache.sling.scripting.core.impl.DefaultSlingScript.verifySlingBindings(DefaultSlingScript.java:676) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3037) IllegalArgumentException in logback Logger
[ https://issues.apache.org/jira/browse/SLING-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-3037: Component/s: (was: Engine) Commons IllegalArgumentException in logback Logger -- Key: SLING-3037 URL: https://issues.apache.org/jira/browse/SLING-3037 Project: Sling Issue Type: Bug Components: Commons Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Scripting Core 2.0.26 Attachments: SLING-3037.patch Since switching to logback in SLING-2024, a number of integration tests are failing, typical stack trace: java.lang.IllegalArgumentException: For logger [apps.integration-test] child name [apps.integration-test.srt$1378284549103 passed as parameter, may not include '.' after index22 at ch.qos.logback.classic.Logger.createChildByName(Logger.java:357) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:143) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:45) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:253) at org.apache.sling.scripting.core.impl.DefaultSlingScript.verifySlingBindings(DefaultSlingScript.java:676) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3037) IllegalArgumentException in logback Logger
[ https://issues.apache.org/jira/browse/SLING-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-3037: Fix Version/s: (was: Scripting Core 2.0.26) Commons Log 4.0.0 IllegalArgumentException in logback Logger -- Key: SLING-3037 URL: https://issues.apache.org/jira/browse/SLING-3037 Project: Sling Issue Type: Bug Components: Commons Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Commons Log 4.0.0 Attachments: SLING-3037.patch Since switching to logback in SLING-2024, a number of integration tests are failing, typical stack trace: java.lang.IllegalArgumentException: For logger [apps.integration-test] child name [apps.integration-test.srt$1378284549103 passed as parameter, may not include '.' after index22 at ch.qos.logback.classic.Logger.createChildByName(Logger.java:357) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:143) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:45) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:253) at org.apache.sling.scripting.core.impl.DefaultSlingScript.verifySlingBindings(DefaultSlingScript.java:676) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Managing Queues based on Topology ?
Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian
[jira] [Created] (SLING-3042) Latest org.apache.sling.scripting.api breaks Groovy script engine
Bertrand Delacretaz created SLING-3042: -- Summary: Latest org.apache.sling.scripting.api breaks Groovy script engine Key: SLING-3042 URL: https://issues.apache.org/jira/browse/SLING-3042 Project: Sling Issue Type: Bug Components: Scripting Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Installing the current org.apache.sling.scripting.api trunk bundle on a launchpad/testing instance causes this error: org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory Cannot register ScriptEngineFactory org.codehaus.groovy.jsr223.GroovyScriptEngineFactory java.lang.ClassCastException: org.codehaus.groovy.jsr223.GroovyScriptEngineFactory cannot be cast to javax.script.ScriptEngineFactory And .groovy scripts are not recognized anymore, though .gsp still works. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2076) Make MapEntries more dynamic
[ https://issues.apache.org/jira/browse/SLING-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2076: Fix Version/s: Resource Resolver 1.1.0 Make MapEntries more dynamic Key: SLING-2076 URL: https://issues.apache.org/jira/browse/SLING-2076 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: JCR Resource 2.0.10 Reporter: Vidar S. Ramdal Assignee: Vidar S. Ramdal Fix For: Resource Resolver 1.1.0 In some scenarios it would be nice to be able to store mapping specs other places than under /etc/map (for instance scattered around the repository/resource tree, or in an external XML file). It would be better if the entire map specification was provided by a separate service. The current MapEntries would act as the default implementation. Mailing list discussion: http://markmail.org/thread/5ww634sqarxtudks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3043) Allow regexp filtering of vanity paths
Carsten Ziegeler created SLING-3043: --- Summary: Allow regexp filtering of vanity paths Key: SLING-3043 URL: https://issues.apache.org/jira/browse/SLING-3043 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Carsten Ziegeler Fix For: Resource Resolver 1.1.0 Right now a sling:vanityPath can appear anywhere in the resource tree and it can point to any other location in the tree. In some cases, it's helpful to limit the possibilities. Therefore we should add regexps to exclude certain parts in the tree for scanning and another set of regexps for filtering the location -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build became unstable: sling-trunk-1.7 #244
See https://builds.apache.org/job/sling-trunk-1.7/244/changes
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #244
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/244/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Event Support #244
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.event/244/changes
[jira] [Commented] (SLING-2944) Replace administrative login by service-based login
[ https://issues.apache.org/jira/browse/SLING-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760085#comment-13760085 ] Carsten Ziegeler commented on SLING-2944: - I've removed the header stuff in rev 1520522 Replace administrative login by service-based login --- Key: SLING-2944 URL: https://issues.apache.org/jira/browse/SLING-2944 Project: Sling Issue Type: New Feature Components: API, JCR, ResourceResolver, Service User Mapper Affects Versions: JCR Resource 2.2.8, JCR Jackrabbit Server 2.1.0, JCR Base 2.1.2, JCR API 2.1.0, API 2.4.2, Resource Resolver 1.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Service User Mapper 1.0.0, Servlets Resolver 2.2.6, JCR Resource 2.3.0, JCR Jackrabbit Server 2.2.0, JCR Base 2.1.4, JCR API 2.2.0, File System Resource Provider 1.1.4, Extensions Bundleresource 2.1.4, API 2.5.0, Resource Resolver 1.1.0 Attachments: serviceusermapper.tgz, SLING-2944.patch From the start Sling tried to solve the problem of providing services access to the repository and resource tree without having to hard code and configure any passwords. This was done first with the SlingRepository.loginAdministrative and later with the ResourceResolverFactory.getAdministrativeResourceResolver methods. Over time this mechanism proved to be the hammer to hit all nails. Particularly these methods while truly useful have the disadvantage of providing full administrative privileges to services where just some specific kind of privilege would be enough. For example for the JSP compiler it would be enough to be able to read the JSP source scripts and write the Java classes out to the JSP compiler's target location. Other access is not required. Similarly to manage users user management privileges are enough and no access to /content is really required. To solve this problem a new API for Service Authentication has been proposed at https://cwiki.apache.org/confluence/display/SLING/Service+Authentication. The prototype of which is implemented in http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/deprecate_login_administrative. This issue is about merging the prototype code back into trunk and thus fully implementing the feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Installer Integration Tests #1870
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/1870/
Jenkins build is back to normal : sling-trunk-1.6 #1870
See https://builds.apache.org/job/sling-trunk-1.6/1870/changes
[jira] [Created] (SLING-3044) Add exclusion rule to .gitignore for IntelliJ projects
Gilles Knobloch created SLING-3044: -- Summary: Add exclusion rule to .gitignore for IntelliJ projects Key: SLING-3044 URL: https://issues.apache.org/jira/browse/SLING-3044 Project: Sling Issue Type: Improvement Components: IDE Reporter: Gilles Knobloch Priority: Minor When using the github.com Apache mirror and importing it as IntelliJ project, there are 500+ files marked as unversioned, all located below .idea folder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Managing Queues based on Topology ?
Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org
[jira] [Updated] (SLING-3044) Add exclusion rule to .gitignore for IntelliJ projects
[ https://issues.apache.org/jira/browse/SLING-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Knobloch updated SLING-3044: --- Attachment: SLING-3044.patch Attached a patch Add exclusion rule to .gitignore for IntelliJ projects -- Key: SLING-3044 URL: https://issues.apache.org/jira/browse/SLING-3044 Project: Sling Issue Type: Improvement Components: IDE Reporter: Gilles Knobloch Priority: Minor Attachments: SLING-3044.patch When using the github.com Apache mirror and importing it as IntelliJ project, there are 500+ files marked as unversioned, all located below .idea folder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-3044) Add exclusion rule to .gitignore for IntelliJ projects
[ https://issues.apache.org/jira/browse/SLING-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-3044. Resolution: Fixed Fixed in http://svn.apache.org/r1520523, thanks! Add exclusion rule to .gitignore for IntelliJ projects -- Key: SLING-3044 URL: https://issues.apache.org/jira/browse/SLING-3044 Project: Sling Issue Type: Improvement Components: IDE Reporter: Gilles Knobloch Priority: Minor Attachments: SLING-3044.patch When using the github.com Apache mirror and importing it as IntelliJ project, there are 500+ files marked as unversioned, all located below .idea folder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2779) Support for default properties values of a resource
[
https://issues.apache.org/jira/browse/SLING-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2779.
-
Resolution: Fixed
Support for default properties values of a resource
---
Key: SLING-2779
URL: https://issues.apache.org/jira/browse/SLING-2779
Project: Sling
Issue Type: New Feature
Components: API
Affects Versions: API 2.3.0
Reporter: Gilles Knobloch
Assignee: Carsten Ziegeler
Fix For: API 2.5.0
Attachments: SLING-2779_20130828.patch, SLING-2779.patch
I already noticed several times it would be useful to be able to specify a
default properties for a resource:
* if the resource itself contains the property, it will override the default
one.
* but if it doesn't, the default value is used.
This could be done either via:
* specifying a {{sling:defaults}} property on the resource, which contains
the path to the resource which properties will be used by default.
* providing a default map of properties
Attaching a patch for review.
For testing purpose, I put it under {{org.apache.sling.defaults}}, but I
imagine it could go to {{org.apache.sling.api.resource}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3028) Support for progress tracking of jobs
[
https://issues.apache.org/jira/browse/SLING-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victor Saar updated SLING-3028:
---
Attachment: SLING-3028.patch
I think the biggest issue of the current version is, that ETA and steps are
mutually exclusive, which is usually not the case. The process needs to carry
out a certain number of steps, which will take a certain time (ETA).
I've attached a patch with a single {{startProgress()}} method, {{setSteps()}}
for setting the total number of steps, and {{setProgress()}} and {{setETA()}}
for setting the current step and ETA.
Support for progress tracking of jobs
-
Key: SLING-3028
URL: https://issues.apache.org/jira/browse/SLING-3028
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Victor Saar
Labels: jobs
Attachments: SLING-3028.patch
For long-running jobs, it would be useful to have some means to track
progress, which can be shown in a console for the user. This should include
the following:
* ETA
* Completeness value computed from (optional, defaults to 1.0) max and
current value (e.g. 42% or 23/100)
* Log output stream for detailed progress information
* Failure reason in case job failed
AFAICS this requires a few changes to the existing implementation:
* Jobs need additional support for setting properties, e.g. max and current
progress value
* Jobs need to be kept at least for a while after they completed/failed to
give access to failure information/log stream
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Managing Queues based on Topology ?
Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org
Build failed in Jenkins: sling-trunk-1.6 #1871
See https://builds.apache.org/job/sling-trunk-1.6/1871/changes Changes: [bdelacretaz] SLING-3044 - ignore .idea folder in git [cziegeler] SLING-2944 : Replace administrative login by service-based login [cziegeler] Add ProviderType and ConsumerType annotations -- [...truncated 12717 lines...] 26 [main] INFO org.apache.sling.scripting.jsp.taglib.TestGetResourceTag - testRelativePath 26 [main] INFO org.apache.sling.scripting.jsp.taglib.TestGetResourceTag - Test successful! Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag 28 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - init 28 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - init Complete 28 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - testAdaptObject 28 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - Setting up tests 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - Checking result 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - Test successful! 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - init 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - init Complete 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - testMissingClass 29 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag - Setting up tests 30 [main] WARN org.apache.sling.scripting.jsp.taglib.AdaptToTag - Unable to retrieve class com.bad.class java.lang.ClassNotFoundException: com.bad.class at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at org.apache.sling.scripting.jsp.taglib.AdaptToTag.doEndTag(AdaptToTag.java:55) at org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag.testMissingClass(TestAdaptObjectTag.java:99) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) 33 [main] INFO org.apache.sling.scripting.jsp.taglib.TestAdaptObjectTag -
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Sample Integration Tests #245
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/245/
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Event Support #245
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.event/245/
Jenkins build is back to stable : sling-trunk-1.7 #245
See https://builds.apache.org/job/sling-trunk-1.7/245/changes
[jira] [Commented] (SLING-3028) Support for progress tracking of jobs
[ https://issues.apache.org/jira/browse/SLING-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760141#comment-13760141 ] Carsten Ziegeler commented on SLING-3028: - This depends :) If I understand you correctly, you say that you have an ETA for each step, right? The steps are intended to be used when you don't know the eta but you know the progress, so for example if you have ten steps to do, you can calculate a percentage once each step is finished. Of course assuming that each step takes the same time - but that's as good as having a rough ETA. I've looked at other progress tracker api's and they usually provide both ways Support for progress tracking of jobs - Key: SLING-3028 URL: https://issues.apache.org/jira/browse/SLING-3028 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Victor Saar Labels: jobs Attachments: SLING-3028.patch For long-running jobs, it would be useful to have some means to track progress, which can be shown in a console for the user. This should include the following: * ETA * Completeness value computed from (optional, defaults to 1.0) max and current value (e.g. 42% or 23/100) * Log output stream for detailed progress information * Failure reason in case job failed AFAICS this requires a few changes to the existing implementation: * Jobs need additional support for setting properties, e.g. max and current progress value * Jobs need to be kept at least for a while after they completed/failed to give access to failure information/log stream -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Managing Queues based on Topology ?
Hi, Just to be clear you are saying programatically manipulate the OSGi configuration of the JobConsumerManager when an instance initialises or transitions from master-slave ? eg on a topology change get a serviceReference to the JobConsumerManager using serviceReference.setProperties(Dictionary) set a blacklist appropriate to the master/slave status of the instance. I am assuming I don't need to worry about the other OSGi properties, however the JavaDoc on setProperties is not explicit on what happens to properties that are not set ? I am also assuming this wont interact badly with any stored configuration state ? Best Regards Ian On 6 September 2013 12:35, Ian Boston i...@tfd.co.uk wrote: Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org
Re: Managing Queues based on Topology ?
I meant serviceRegistration not serviceReference, but I cant get it seems like its not possible to get hold of a serviceRegistration from another bundle. On 6 September 2013 13:31, Ian Boston i...@tfd.co.uk wrote: Hi, Just to be clear you are saying programatically manipulate the OSGi configuration of the JobConsumerManager when an instance initialises or transitions from master-slave ? eg on a topology change get a serviceReference to the JobConsumerManager using serviceReference.setProperties(Dictionary) set a blacklist appropriate to the master/slave status of the instance. I am assuming I don't need to worry about the other OSGi properties, however the JavaDoc on setProperties is not explicit on what happens to properties that are not set ? I am also assuming this wont interact badly with any stored configuration state ? Best Regards Ian On 6 September 2013 12:35, Ian Boston i...@tfd.co.uk wrote: Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org
[jira] [Updated] (SLING-3042) org.apache.sling.scripting.api should not export javax.script anymore
[ https://issues.apache.org/jira/browse/SLING-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-3042: --- Affects Version/s: Scripting API 2.1.4 Fix Version/s: Scripting API 2.1.6 Summary: org.apache.sling.scripting.api should not export javax.script anymore (was: Latest org.apache.sling.scripting.api breaks Groovy script engine) This is caused by org.apache.sling.scripting.api embedding and exporting the javax.script package, which is now also (rightly IMO) exported by org.apache.felix.framework 4.2.0. As a result, some javax.script classes are loaded from the framework bundle and others from org.apache.sling.scripting.api, which causes errors like the above one and maybe others depending on the order of bundles activation. org.apache.sling.scripting.api should not export javax.script anymore - Key: SLING-3042 URL: https://issues.apache.org/jira/browse/SLING-3042 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting API 2.1.4 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Scripting API 2.1.6 Installing the current org.apache.sling.scripting.api trunk bundle on a launchpad/testing instance causes this error: org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory Cannot register ScriptEngineFactory org.codehaus.groovy.jsr223.GroovyScriptEngineFactory java.lang.ClassCastException: org.codehaus.groovy.jsr223.GroovyScriptEngineFactory cannot be cast to javax.script.ScriptEngineFactory And .groovy scripts are not recognized anymore, though .gsp still works. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
FYI, org.apache.sling.scripting.api does not embed and export javax.script anymore
See https://issues.apache.org/jira/browse/SLING-3042 - this might break compatibility with JDK 1.5 but I think dropping that is fine now. -Bertrand
[jira] [Resolved] (SLING-3042) org.apache.sling.scripting.api should not export javax.script anymore
[ https://issues.apache.org/jira/browse/SLING-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-3042. Resolution: Fixed Fixed in http://svn.apache.org/r1520551 by having the scripting.api bundle just import the javax.script package, without embedding or exporting it. All integration tests pass after this change, with JDK 1.6. This might break compatibility with JDK 1.5 but I don't think we really care about that anymore. I have left the custom javax.script.ScriptEngineManager implementation in the bundle for now, removing it would need more analysis. org.apache.sling.scripting.api should not export javax.script anymore - Key: SLING-3042 URL: https://issues.apache.org/jira/browse/SLING-3042 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting API 2.1.4 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Scripting API 2.1.6 Installing the current org.apache.sling.scripting.api trunk bundle on a launchpad/testing instance causes this error: org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory Cannot register ScriptEngineFactory org.codehaus.groovy.jsr223.GroovyScriptEngineFactory java.lang.ClassCastException: org.codehaus.groovy.jsr223.GroovyScriptEngineFactory cannot be cast to javax.script.ScriptEngineFactory And .groovy scripts are not recognized anymore, though .gsp still works. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Managing Queues based on Topology ?
If the config is stored in the repository, wont that propagate from master to slave and visa versa ? The JavaDocs on Configuration.update(Dictionary) say changes are stored. On 6 September 2013 13:40, Carsten Ziegeler cziege...@apache.org wrote: Hmm, I would rather get the configuration dictionary from the config admin and update that Carsten 2013/9/6 Ian Boston i...@tfd.co.uk I meant serviceRegistration not serviceReference, but I cant get it seems like its not possible to get hold of a serviceRegistration from another bundle. On 6 September 2013 13:31, Ian Boston i...@tfd.co.uk wrote: Hi, Just to be clear you are saying programatically manipulate the OSGi configuration of the JobConsumerManager when an instance initialises or transitions from master-slave ? eg on a topology change get a serviceReference to the JobConsumerManager using serviceReference.setProperties(Dictionary) set a blacklist appropriate to the master/slave status of the instance. I am assuming I don't need to worry about the other OSGi properties, however the JavaDoc on setProperties is not explicit on what happens to properties that are not set ? I am also assuming this wont interact badly with any stored configuration state ? Best Regards Ian On 6 September 2013 12:35, Ian Boston i...@tfd.co.uk wrote: Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
Re: Managing Queues based on Topology ?
In general yes, but not for the Job Consumer Manager - the configuration has a special property set which excludes it from writing back to the repository and therefore distributing it Carsten 2013/9/6 Ian Boston i...@tfd.co.uk If the config is stored in the repository, wont that propagate from master to slave and visa versa ? The JavaDocs on Configuration.update(Dictionary) say changes are stored. On 6 September 2013 13:40, Carsten Ziegeler cziege...@apache.org wrote: Hmm, I would rather get the configuration dictionary from the config admin and update that Carsten 2013/9/6 Ian Boston i...@tfd.co.uk I meant serviceRegistration not serviceReference, but I cant get it seems like its not possible to get hold of a serviceRegistration from another bundle. On 6 September 2013 13:31, Ian Boston i...@tfd.co.uk wrote: Hi, Just to be clear you are saying programatically manipulate the OSGi configuration of the JobConsumerManager when an instance initialises or transitions from master-slave ? eg on a topology change get a serviceReference to the JobConsumerManager using serviceReference.setProperties(Dictionary) set a blacklist appropriate to the master/slave status of the instance. I am assuming I don't need to worry about the other OSGi properties, however the JavaDoc on setProperties is not explicit on what happens to properties that are not set ? I am also assuming this wont interact badly with any stored configuration state ? Best Regards Ian On 6 September 2013 12:35, Ian Boston i...@tfd.co.uk wrote: Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
Re: Managing Queues based on Topology ?
Sorry, not slightly correct - if you create the configuration for the first time, make sure to set the property org.apache.sling.installer.configuration.persist to the value false Carsten 2013/9/6 Carsten Ziegeler cziege...@apache.org In general yes, but not for the Job Consumer Manager - the configuration has a special property set which excludes it from writing back to the repository and therefore distributing it Carsten 2013/9/6 Ian Boston i...@tfd.co.uk If the config is stored in the repository, wont that propagate from master to slave and visa versa ? The JavaDocs on Configuration.update(Dictionary) say changes are stored. On 6 September 2013 13:40, Carsten Ziegeler cziege...@apache.org wrote: Hmm, I would rather get the configuration dictionary from the config admin and update that Carsten 2013/9/6 Ian Boston i...@tfd.co.uk I meant serviceRegistration not serviceReference, but I cant get it seems like its not possible to get hold of a serviceRegistration from another bundle. On 6 September 2013 13:31, Ian Boston i...@tfd.co.uk wrote: Hi, Just to be clear you are saying programatically manipulate the OSGi configuration of the JobConsumerManager when an instance initialises or transitions from master-slave ? eg on a topology change get a serviceReference to the JobConsumerManager using serviceReference.setProperties(Dictionary) set a blacklist appropriate to the master/slave status of the instance. I am assuming I don't need to worry about the other OSGi properties, however the JavaDoc on setProperties is not explicit on what happens to properties that are not set ? I am also assuming this wont interact badly with any stored configuration state ? Best Regards Ian On 6 September 2013 12:35, Ian Boston i...@tfd.co.uk wrote: Cool, thanks, I'll go down the route you suggest. Ian On 6 September 2013 11:45, Carsten Ziegeler cziege...@apache.org wrote: Hi Ian, no, you don't implement a PropertyProvider for this - this is done by the job implementation for you (JobConsumerManager). The JobConsumerManager collects all active JobConsumer queries their supported topics and provides this information through the topology by registering the PropertyProvider. Basically, you have three choices: either you disable the job consumer on an instance, you change the topics registration property of that service or the consumer manager allows to configure whitelist and blacklist topics. Which in most cases is the easiest solution. A topology change causes the job handling to restart, if you do a consumer change based on that, this results in a new topology event and the job handler will restart again. At least that's how it is implemented right now, as this is the easiest way of implementing it. However, the restart comes with a delay, so if the additional events happen within this delay, you end up with exactly one restart (this is why we have the delay). Regards Carsten 2013/9/6 Ian Boston i...@tfd.co.uk Hi, (Probably a question for Carsten). Is the right way to implement topology based queue exclusion by implementing a topology discovery PropertyProvider that provides the property: org.apache.sling.event.jobs.consumer.topics containing a , separated list of topics the instance can handle. If so I have 2 questions: Since this list is topology dependent (depends on which is master) and will itself have to be generated after a topology change which may take some time to filter through the discovery hub spoke implementation, will it cause the Job Queue to restart multiple times on a relevant property change. ? Also, how are Topics excluded from a list of capabilities for each instance. I have read through the code in the constructor of TopologyCapabilities and the getPotentialTargets, detectTartgets and I cant see how to exclude a topic from an instance, only how to include. What is the best way of excluding a topic from a instance without having to whitelist all known topics. ? Best Regards Ian -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
Build failed in Jenkins: sling-trunk-1.7 #247
See https://builds.apache.org/job/sling-trunk-1.7/247/changes Changes: [cziegeler] Update to parent pom 18 [bdelacretaz] SLING-3042 - do not export javax.script from org.apache.sling.scripting.api anymore -- [...truncated 611 lines...] Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JCR ClassLoader .. SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Initial Content Loader ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Jackrabbit Embedded Repository ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Jackrabbit UserManager Support ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Jackrabbit JSR-283 Access Control Manager Support SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Wrapper Bundle for the JCR API ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Object Content Mapping ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JCR Resource Resolver SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JCR Repository Registration .. SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Simple WebDAV Access to repositories . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling DavEx Access to repositories . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JCR WebConsole Bundle SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Servlet Resolver . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Default GET Servlets . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Default POST Servlets SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Compat Servlets .. SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scripting Implementation API . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scripting Core implementation SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scripting JavaScript Support . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scripting JSP Support SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSP Tag Library .. SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSP Standard Tag Library . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Adapter Manager Implementation ... SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Bundle Resource Provider . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Discovery API SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource-Based Discovery Service . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Discovery Support Bundle . SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Discovery Standalone Implementation .. SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Event Support SKIPPED Sep 06, 2013 12:54:24 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Filesystem
Build failed in Jenkins: sling-trunk-1.7 » Apache Sling (Parent) #247
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$sling/247/ -- Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Building Apache Sling (Parent) 19-SNAPSHOT Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-clean-plugin:2.5:clean (default-clean) @ sling --- [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$sling/ws/target Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 06, 2013 12:54:22 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ sling --- Sep 06, 2013 12:54:23 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 06, 2013 12:54:23 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ sling --- [INFO] Executing tasks main: [INFO] Executed tasks Sep 06, 2013 12:54:23 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 06, 2013 12:54:23 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-remote-resources-plugin:1.4:process (default) @ sling ---
[ANN] New committer: Oliver Lietz
The Project Management Committee (PMC) for Apache Slinghas asked Oliver Lietz to become a committer and we are pleased to announce that he has accepted. So please welcome Oliver as a committer! Being a committer enables easier contribution to theproject since there is no need to go via the patchsubmission process. This should enable better productivity.Being a PMC member enables assistance with the managementand to guide the direction of the project. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
[jira] [Resolved] (SLING-3038) Take context service property into account when using BindingsValuesProvider
[ https://issues.apache.org/jira/browse/SLING-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-3038. Resolution: Fixed Implemented in http://svn.apache.org/r1520565 , the SlingScriptAdapterFactory now takes the context service property into account, tested in BindingsValuesProvidersByContextIT. The new BindingsValuesProvidersByContext service can be used for other code that wants context-specific BindingsValuesProviders, and the implementation also takes the scripting language into account to include BVPs or not, and to provide them in the appropriate order. One can also just select BindingsValuesProviders based on their context service property, which avoids depending on the latest scripting.api bundle version, but you won't get the language-specific selection when doing that. All integration tests pass after this change. Take context service property into account when using BindingsValuesProvider -- Key: SLING-3038 URL: https://issues.apache.org/jira/browse/SLING-3038 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Core 2.0.24 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: SLING-3038.patch As discussed at http://sling.markmail.org/thread/dzdgfx3n6i5ftkjw , being able to restrict BindingsValuesProvider (BVP) services to specific contexts (request processing, health checks, workflow etc) would be useful. The first step is to modify the scripting setup in DefaultSlingScript so that any BVP which has a context service property which doesn't include a request value is ignored. Other components which use BVPs can then select then based on the value of their context service property. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Adding a usage service property to BindingsValuesProvider ?
On Thu, Sep 5, 2013 at 1:28 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: ...Maybe addContextBindings(Bindings b, ScriptEngineFactory f, String context) ... FYI I didn't do it like that in the end, as that would have caused more changes than I like to existing code. The new service API is at https://svn.apache.org/repos/asf/sling/trunk/bundles/scripting/api/src/main/java/org/apache/sling/scripting/api/BindingsValuesProvidersByContext.java Apart from that this is now done, see SLING-3038 for details, -Bertrand
Re: Adding a usage service property to BindingsValuesProvider ?
The constants should really be defined in the BVP class, this is the service declaring them I don't understand what you mean by changes to existing code - this is new, isn't it? Carsten 2013/9/6 Bertrand Delacretaz bdelacre...@apache.org On Thu, Sep 5, 2013 at 1:28 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: ...Maybe addContextBindings(Bindings b, ScriptEngineFactory f, String context) ... FYI I didn't do it like that in the end, as that would have caused more changes than I like to existing code. The new service API is at https://svn.apache.org/repos/asf/sling/trunk/bundles/scripting/api/src/main/java/org/apache/sling/scripting/api/BindingsValuesProvidersByContext.java Apart from that this is now done, see SLING-3038 for details, -Bertrand -- Carsten Ziegeler cziege...@apache.org
Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Installer Integration Tests #1873
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/1873/changes
Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1873
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1873/changes
Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1873
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1873/changes
Jenkins build is unstable: sling-trunk-1.6 #1873
See https://builds.apache.org/job/sling-trunk-1.6/1873/changes
Jenkins build is unstable: sling-trunk-1.7 #248
See https://builds.apache.org/job/sling-trunk-1.7/248/changes
Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling (Parent) #248
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$sling/248/
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #248
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing-war/248/
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #248
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/248/
Re: [ANN] New committer: Oliver Lietz
On Fri, 2013-09-06 at 14:58 +0200, Carsten Ziegeler wrote: The Project Management Committee (PMC) for Apache Slinghas asked Oliver Lietz to become a committer and we are pleased to announce that he has accepted. So please welcome Oliver as a committer! Being a committer enables easier contribution to theproject since there is no need to go via the patchsubmission process. This should enable better productivity.Being a PMC member enables assistance with the managementand to guide the direction of the project. Regards Carsten Oliver, welcome and congratulations! Looking forward to seeing your unmediated contributions to Sling. Robert
[jira] [Commented] (SLING-2989) [Tooling] integrate with vlt once available
[
https://issues.apache.org/jira/browse/SLING-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760232#comment-13760232
]
Robert Munteanu commented on SLING-2989:
More changes:
* Fixed directory creation in
http://svn.apache.org/viewvc?view=revisionrevision=1520580
* Implemented node deletion in
http://svn.apache.org/viewvc?view=revisionrevision=1520581
* Fixed applicability of default filter.xml in
http://svn.apache.org/viewvc?view=revisionrevision=1520582
* Added basic sync of .content.xml-defined properties to the repository in
http://svn.apache.org/viewvc?view=revisionrevision=1520584
Note that the property serialization ( aka .content.xml ) is very basic right
now:
1. It does not support all types of aggregates defined at [1]
2. It only supports sync'ing properties of type String and incorrectly ignores
type hints such as {Boolean} stored by vlt
These, alongside some tests, are the next issues I'll be working on.
[1]: http://wiki.apache.org/jackrabbit/JackrabbitFileVaultFS#Aggregates
[Tooling] integrate with vlt once available
---
Key: SLING-2989
URL: https://issues.apache.org/jira/browse/SLING-2989
Project: Sling
Issue Type: Task
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Integrate the eclipse tooling with vault, once available open source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [ANN] New committer: Oliver Lietz
On Fri, Sep 6, 2013 at 2:58 PM, Carsten Ziegeler cziege...@apache.org wrote: The Project Management Committee (PMC) for Apache Sling has asked Oliver Lietz to become a committer and we are pleased to announce that he has accepted Welcome and congrats Oliver! -Bertrand
Jenkins build is back to normal : sling-contrib-1.6 » Apache Sling Dojo JavaScript Library #1070
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.dojo/1070/
Build failed in Jenkins: sling-contrib-1.6 #1070
See https://builds.apache.org/job/sling-contrib-1.6/1070/changes Changes: [bdelacretaz] SLING-3034 - avoid NPE [bdelacretaz] SLING-3034 - rename JmxScriptBindingsProvider [bdelacretaz] SLING-3034 - move OsgiScriptBindingsProvider to samples module [bdelacretaz] SLING-3034 - use BindingsValuesProvider for script bindings -- [...truncated 1513 lines...] INFO: Sep 6, 2013 2:57:31 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ org.apache.sling.ftpserver --- [INFO] Checking legal files in: org.apache.sling.ftpserver-0.0.1-SNAPSHOT.jar [INFO] Checking legal files in: org.apache.sling.ftpserver-0.0.1-SNAPSHOT-sources.jar Sep 6, 2013 2:57:31 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:31 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-install-plugin:2.3.1:install (default-install) @ org.apache.sling.ftpserver --- [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/ftpserver/target/org.apache.sling.ftpserver-0.0.1-SNAPSHOT.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.ftpserver/0.0.1-SNAPSHOT/org.apache.sling.ftpserver-0.0.1-SNAPSHOT.jar [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/ftpserver/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.ftpserver/0.0.1-SNAPSHOT/org.apache.sling.ftpserver-0.0.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/ftpserver/target/org.apache.sling.ftpserver-0.0.1-SNAPSHOT-sources.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.ftpserver/0.0.1-SNAPSHOT/org.apache.sling.ftpserver-0.0.1-SNAPSHOT-sources.jar Sep 6, 2013 2:57:31 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:31 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-bundle-plugin:2.4.0:install (default-install) @ org.apache.sling.ftpserver --- [INFO] Local OBR update disabled (enable with -DobrRepository) Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Building Apache Sling Google Web Toolkit Servlet Library 3.0.1-SNAPSHOT Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/gwt/servlet/target Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ org.apache.sling.extensions.gwt.servlet --- Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Executing tasks main: [INFO] Executed tasks Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-remote-resources-plugin:1.4:process (default) @ org.apache.sling.extensions.gwt.servlet --- Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 0 resource [INFO] Copying 3 resources Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Executing tasks main: [echo]
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1874
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1874
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/changes
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Installer Integration Tests #1874
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/1874/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #249
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing-war/249/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #249
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/249/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Launchpad Base #249
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.base/249/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #249
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/249/
Jenkins build is still unstable: sling-trunk-1.7 #249
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.6 #1874
See https://builds.apache.org/job/sling-trunk-1.6/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #250
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing-war/250/
Jenkins build is back to normal : sling-contrib-1.6 » Apache Sling Google Web Toolkit Servlet Library #1071
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.gwt.servlet/1071/changes
LogBack Support : Adding an appender without changing the log level
Hi, I'm having a look at the new logging support for logback appenders and it seems that I can only attach an Appender to a logger if I specify a log level as well. I have a use case where I just want to add an additional Appender to a logger - without influencing the log level. Is that possible? Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Jenkins build is unstable: sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1071
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/1071/
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Launchpad Base #250
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.base/250/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #250
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/250/
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Sample Integration Tests #250
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/250/
Jenkins build is still unstable: sling-trunk-1.7 #250
See https://builds.apache.org/job/sling-trunk-1.7/changes
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Google Web Toolkit Servlet Library #1070
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.gwt.servlet/1070/ -- Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Building Apache Sling Google Web Toolkit Servlet Library 3.0.1-SNAPSHOT Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.gwt.servlet/ws/target Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ org.apache.sling.extensions.gwt.servlet --- Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Executing tasks main: [INFO] Executed tasks Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-remote-resources-plugin:1.4:process (default) @ org.apache.sling.extensions.gwt.servlet --- Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 0 resource [INFO] Copying 3 resources Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:32 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-compiler-plugin:2.5.1:compile (default-compile) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Compiling 1 source file to https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.gwt.servlet/ws/target/classes Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.extensions.gwt.servlet --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.extensions.gwt.servlet/ws/src/test/resources [INFO] Copying 3 resources Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ org.apache.sling.extensions.gwt.servlet --- [INFO] No sources to compile Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Sep 6, 2013 2:57:33 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-surefire-plugin:2.12.4:test (default-test) @ org.apache.sling.extensions.gwt.servlet --- Sep 6, 2013 2:57:33 PM
Build failed in Jenkins: sling-trunk-1.6 #1875
See https://builds.apache.org/job/sling-trunk-1.6/1875/changes
Changes:
[cziegeler] Revert to old maven bundle plugin if DynamicImport-Package is used
--
[...truncated 35374 lines...]
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runners.Suite.runChild(Suite.java:127)
at org.junit.runners.Suite.runChild(Suite.java:26)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at
org.apache.sling.launchpad.testing.LoggingSuite.runTest(LoggingSuite.java:56)
at junit.framework.TestSuite.run(TestSuite.java:250)
at
org.apache.sling.launchpad.testing.LoggingSuite.run(LoggingSuite.java:46)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
runScripts[3 -
installer-duplicate.jsp](org.apache.sling.launchpad.webapp.integrationtest.ServerSideScriptsTest)
Time elapsed: 0.134 sec FAILURE!
java.lang.AssertionError: Expected 0 failing tests but got 1 for
/tmp/1378485883220.dir/scripts/sling-it/installer-duplicate.jsp:
[verifyContent[0](org.apache.sling.junit.scriptable.TestAllPaths): Unexpected
content at path
/apps/testing/sling/scripted-tests/installer-duplicate.test.txt, should be just
TEST_PASSED (lines starting with # and empty lines are ignored)
content was:
** Resource dumped by PlainTextRendererServlet**
Resource path:/apps/testing/sling/scripted-tests/installer-duplicate
Resource metadata: {sling.resolutionPathInfo=.test.txt,
sling.resolutionPath=/apps/testing/sling/scripted-tests/installer-duplicate}
Resource type: testing/sling/scripted-tests/installer-duplicate
Resource super type: -
** Resource properties **
sling:resourceType: testing/sling/scripted-tests/installer-duplicate
jcr:createdBy: admin
jcr:mixinTypes: [sling:Test]
jcr:created:
java.util.GregorianCalendar[time=1378486053876,areFieldsSet=true,areAllFieldsSet=true,lenient=false,zone=sun.util.calendar.ZoneInfo[id=GMT,offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null],firstDayOfWeek=1,minimalDaysInFirstWeek=1,ERA=1,YEAR=2013,MONTH=8,WEEK_OF_YEAR=36,WEEK_OF_MONTH=1,DAY_OF_MONTH=6,DAY_OF_YEAR=249,DAY_OF_WEEK=6,DAY_OF_WEEK_IN_MONTH=1,AM_PM=1,HOUR=4,HOUR_OF_DAY=16,MINUTE=47,SECOND=33,MILLISECOND=876,ZONE_OFFSET=0,DST_OFFSET=0]
jcr:primaryType: sling:Folder
]
at org.junit.Assert.fail(Assert.java:88)
at
org.apache.sling.launchpad.webapp.integrationtest.ServerSideScriptsTest.runScripts(ServerSideScriptsTest.java:235)
at
Re: Maven Bundle Plugin 2.4 causing problems
Hi It looks like the auth.core bundle has a uses constraint: org.apache.sling.engine.auth; version=2.0.6; uses:=javax.jcr,javax.servlet.http,org.apache.sling.api I could imagine that due to this uses constraint, the import is hard. Can we fix this constraint ? Regards Felix Am 06.09.2013 um 08:23 schrieb Carsten Ziegeler: Hi, I updated today to the new parent pom 18 which is using latest Maven Bundle Plugin 2.4.0. Unfortunately this is now causing problems if DymamicImport-Package is used, you can see this in the auth.core bundle for example. With previous versions of the plugin, the Import-Package was calculated with taking DynamicImport-Package in mind, which means a package declared as dynamic import was not added to the import list. With 2.4.0 this changed, and the package is listed in both statements - while browsing through the docs, it looks to me, that this is the wanted behaviour nevertheless... I'Ve reverted those projects which use DynamicImport-Package (only a few) to use the older version of the plugin for now. But I think this is something we should follow up with the Felix project. Carsten -- Carsten Ziegeler cziege...@apache.org smime.p7s Description: S/MIME cryptographic signature
Maven Bundle Plugin 2.4 causing problems
Hi, I updated today to the new parent pom 18 which is using latest Maven Bundle Plugin 2.4.0. Unfortunately this is now causing problems if DymamicImport-Package is used, you can see this in the auth.core bundle for example. With previous versions of the plugin, the Import-Package was calculated with taking DynamicImport-Package in mind, which means a package declared as dynamic import was not added to the import list. With 2.4.0 this changed, and the package is listed in both statements - while browsing through the docs, it looks to me, that this is the wanted behaviour nevertheless... I'Ve reverted those projects which use DynamicImport-Package (only a few) to use the older version of the plugin for now. But I think this is something we should follow up with the Felix project. Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [ANN] New committer: Oliver Lietz
Welcome and Congratulations. Regards Felix Am 06.09.2013 um 05:58 schrieb Carsten Ziegeler: The Project Management Committee (PMC) for Apache Slinghas asked Oliver Lietz to become a committer and we are pleased to announce that he has accepted. So please welcome Oliver as a committer! Being a committer enables easier contribution to theproject since there is no need to go via the patchsubmission process. This should enable better productivity.Being a PMC member enables assistance with the managementand to guide the direction of the project. Regards Carsten -- Carsten Ziegeler cziege...@apache.org smime.p7s Description: S/MIME cryptographic signature
Re: Adding a usage service property to BindingsValuesProvider ?
Hmm, why not turning this around and ammed the BindingsValueProvider interface ?
public interface BindingsValuesProvider2 extends BindingsValueProvider {
void addBindings(Bindings bindings, ScriptEngineFactory, String context);
}
The BindingsValuesProvider2 is a marker interface to the BindginsValuesProvider
service interface. A consumer would do
BindingsValuesProvider[] bvps = getProviders();
foreach (BindingsValuesProvider bvp: bvps) {
if (bvp instanceof BindingsValuesProvider2) {
// use with scope
} else {
// use without scope
}
}
Regards
Felix
Am 06.09.2013 um 06:04 schrieb Bertrand Delacretaz:
On Thu, Sep 5, 2013 at 1:28 PM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
...Maybe
addContextBindings(Bindings b, ScriptEngineFactory f, String context)
...
FYI I didn't do it like that in the end, as that would have caused
more changes than I like to existing code. The new service API is at
https://svn.apache.org/repos/asf/sling/trunk/bundles/scripting/api/src/main/java/org/apache/sling/scripting/api/BindingsValuesProvidersByContext.java
Apart from that this is now done, see SLING-3038 for details,
-Bertrand
smime.p7s
Description: S/MIME cryptographic signature
[jira] [Commented] (SLING-2944) Replace administrative login by service-based login
[ https://issues.apache.org/jira/browse/SLING-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760624#comment-13760624 ] Felix Meschberger commented on SLING-2944: -- [~cziegeler] Why did you remove the getServiceID method ? This is unrelated to the bundle header. Replace administrative login by service-based login --- Key: SLING-2944 URL: https://issues.apache.org/jira/browse/SLING-2944 Project: Sling Issue Type: New Feature Components: API, JCR, ResourceResolver, Service User Mapper Affects Versions: JCR Resource 2.2.8, JCR Jackrabbit Server 2.1.0, JCR Base 2.1.2, JCR API 2.1.0, API 2.4.2, Resource Resolver 1.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Service User Mapper 1.0.0, Servlets Resolver 2.2.6, JCR Resource 2.3.0, JCR Jackrabbit Server 2.2.0, JCR Base 2.1.4, JCR API 2.2.0, File System Resource Provider 1.1.4, Extensions Bundleresource 2.1.4, API 2.5.0, Resource Resolver 1.1.0 Attachments: serviceusermapper.tgz, SLING-2944.patch From the start Sling tried to solve the problem of providing services access to the repository and resource tree without having to hard code and configure any passwords. This was done first with the SlingRepository.loginAdministrative and later with the ResourceResolverFactory.getAdministrativeResourceResolver methods. Over time this mechanism proved to be the hammer to hit all nails. Particularly these methods while truly useful have the disadvantage of providing full administrative privileges to services where just some specific kind of privilege would be enough. For example for the JSP compiler it would be enough to be able to read the JSP source scripts and write the Java classes out to the JSP compiler's target location. Other access is not required. Similarly to manage users user management privileges are enough and no access to /content is really required. To solve this problem a new API for Service Authentication has been proposed at https://cwiki.apache.org/confluence/display/SLING/Service+Authentication. The prototype of which is implemented in http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/deprecate_login_administrative. This issue is about merging the prototype code back into trunk and thus fully implementing the feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3043) Allow regexp filtering of vanity paths
[ https://issues.apache.org/jira/browse/SLING-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760625#comment-13760625 ] Felix Meschberger commented on SLING-3043: -- -.7 I am only lukewarm with such a feature for reasons of complexity to configure and building cruft for backwards compatibility. Allow regexp filtering of vanity paths -- Key: SLING-3043 URL: https://issues.apache.org/jira/browse/SLING-3043 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Carsten Ziegeler Fix For: Resource Resolver 1.1.0 Right now a sling:vanityPath can appear anywhere in the resource tree and it can point to any other location in the tree. In some cases, it's helpful to limit the possibilities. Therefore we should add regexps to exclude certain parts in the tree for scanning and another set of regexps for filtering the location -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #1875
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1875/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1875
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1875/
[jira] [Commented] (SLING-3042) org.apache.sling.scripting.api should not export javax.script anymore
[ https://issues.apache.org/jira/browse/SLING-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760606#comment-13760606 ] Felix Meschberger commented on SLING-3042: -- That change makes sense to me (nowadays). But then we should mark the bundle as requiring Java 6 using the appropriate Bundle-RequiredExecutionEvibronment header (or simple declare build for Java 6 in the pom) org.apache.sling.scripting.api should not export javax.script anymore - Key: SLING-3042 URL: https://issues.apache.org/jira/browse/SLING-3042 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting API 2.1.4 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Scripting API 2.1.6 Installing the current org.apache.sling.scripting.api trunk bundle on a launchpad/testing instance causes this error: org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory Cannot register ScriptEngineFactory org.codehaus.groovy.jsr223.GroovyScriptEngineFactory java.lang.ClassCastException: org.codehaus.groovy.jsr223.GroovyScriptEngineFactory cannot be cast to javax.script.ScriptEngineFactory And .groovy scripts are not recognized anymore, though .gsp still works. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: FYI, org.apache.sling.scripting.api does not embed and export javax.script anymore
Hi Makes sense to me. How about adding the Bundle-RequiredExecutionEnvironment header to the bundle (see my comment to the issue). Regards Felix Am 06.09.2013 um 04:54 schrieb Bertrand Delacretaz: See https://issues.apache.org/jira/browse/SLING-3042 - this might break compatibility with JDK 1.5 but I think dropping that is fine now. -Bertrand smime.p7s Description: S/MIME cryptographic signature
