[jira] [Closed] (SLING-2899) Directly register script engine as event handler
[ https://issues.apache.org/jira/browse/SLING-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2899. --- Directly register script engine as event handler Key: SLING-2899 URL: https://issues.apache.org/jira/browse/SLING-2899 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting JSP 2.0.28 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Priority: Minor Fix For: Scripting JSP 2.1.0 Currently the jsp script engine registers itself as an event handler service during activate - which complicates the code and service registration without any benefit. We can directly let DS register the engine as an event handler -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-2934) Wasted work in ValidateVisitor.checkXmlAttributes()
[ https://issues.apache.org/jira/browse/SLING-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2934. --- Wasted work in ValidateVisitor.checkXmlAttributes() --- Key: SLING-2934 URL: https://issues.apache.org/jira/browse/SLING-2934 Project: Sling Issue Type: Bug Components: Scripting Environment: any Reporter: Adrian Nistor Assignee: Carsten Ziegeler Labels: patch, performance Fix For: Scripting JSP 2.1.0 Attachments: patch.diff The problem appears in version 6 and in revision 1495454. I attached a one-line patch that fixes it. In method ValidateVisitor.checkXmlAttributes, the loop over nodes should break immediately after elExpression and deferredValueIsLiteral are set to true. All the iterations after elExpression and deferredValueIsLiteral are set to true do not perform any useful work, at best they just set elExpression and deferredValueIsLiteral again to true. Method isLive in class ResourceResolverContext has a similar loop (over dynamicProviders), and this loop breaks immediately after result is set to false, just like in the proposed patch. Other methods (e.g., FactoryPreconditions.checkPreconditions, JspUtil.checkAttributes, EclipseJavaCompiler.compile, SecondPassVisitor.appendPageDirective) also have similar loops with similar breaks, just like in the proposed patch. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-3509) Add web console plugin to remove all compiled class files
[ https://issues.apache.org/jira/browse/SLING-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3509. --- Add web console plugin to remove all compiled class files - Key: SLING-3509 URL: https://issues.apache.org/jira/browse/SLING-3509 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Scripting JSP 2.1.0 Recompilation of jsps is done based on observation and only by observing the source files. There are some rare cases where a user wants to force a recompilation, e.g. if the settings of the jsp engine are changed etc. We should add a web console plugin which allows this. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-2933) Wasted work in ValidateVisitor.getJspAttribute()
[ https://issues.apache.org/jira/browse/SLING-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2933. --- Wasted work in ValidateVisitor.getJspAttribute() Key: SLING-2933 URL: https://issues.apache.org/jira/browse/SLING-2933 Project: Sling Issue Type: Bug Components: Scripting Environment: any Reporter: Adrian Nistor Assignee: Carsten Ziegeler Labels: patch, performance Fix For: Scripting JSP 2.1.0 Attachments: patch.diff The problem appears in version 6 and in revision 1495454. I attached a one-line patch that fixes it. In method ValidateVisitor.getJspAttribute, the loop over nodes should break immediately after deferred is set to true. All the iterations after deferred is set to true do not perform any useful work, at best they just set deferred again to true. Method isLive in class ResourceResolverContext has a similar loop (over dynamicProviders), and this loop breaks immediately after result is set to false, just like in the proposed patch. Other methods (e.g., FactoryPreconditions.checkPreconditions, JspUtil.checkAttributes, EclipseJavaCompiler.compile, SecondPassVisitor.appendPageDirective) also have similar loops with similar breaks, just like in the proposed patch. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-2927) Wasted work in ValidateVisitor.isExpression()
[ https://issues.apache.org/jira/browse/SLING-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2927. --- Wasted work in ValidateVisitor.isExpression() - Key: SLING-2927 URL: https://issues.apache.org/jira/browse/SLING-2927 Project: Sling Issue Type: Bug Components: Scripting Environment: any Reporter: Adrian Nistor Assignee: Carsten Ziegeler Labels: patch, performance Fix For: Scripting JSP 2.1.0 Attachments: patch.diff The problem appears in version 6 and in revision 1495454. I attached a two-line patch that fixes it. In method ValidateVisitor.isExpression, the loop over nodes should break immediately after elExpression is set to true. All the iterations after elExpression is set to true do not perform any useful work, at best they just set elExpression again to true. Method isLive in class ResourceResolverContext has a similar loop (over dynamicProviders), and this loop breaks immediately after result is set to false, just like in the proposed patch. Other methods (e.g., FactoryPreconditions.checkPreconditions, JspUtil.checkAttributes, EclipseJavaCompiler.compile, SecondPassVisitor.appendPageDirective) also have similar loops with similar breaks, just like in the proposed patch. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-3545) SlingJSPTaglibTest fails due to missing ELContextWrapper/JspValueExpression
[ https://issues.apache.org/jira/browse/SLING-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3545. --- SlingJSPTaglibTest fails due to missing ELContextWrapper/JspValueExpression --- Key: SLING-3545 URL: https://issues.apache.org/jira/browse/SLING-3545 Project: Sling Issue Type: Bug Components: Scripting Reporter: Bertrand Delacretaz Assignee: Carsten Ziegeler Fix For: Scripting JSP 2.1.0 The SlingJSPTaglibTest (from launchpad/integration-tests) fails, probably due to the recent JSP compiler changes, due to the following classes not being found. I'm not familiar with that code but I suspect those were implementation classes that are gone now. The failing script is taglib-test.jsp [1]. {code} The type org.apache.sling.scripting.jsp.jasper.JasperException cannot be resolved. It is indirectly referenced from required .class files org.apache.sling.scripting.jsp.jasper.el.ELContextWrapper cannot be resolved to a type org.apache.sling.scripting.jsp.jasper.el.JspValueExpression cannot be resolved to a type {code} [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/taglib-test.jsp -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: [VOTE] Release Apache Sling SLF4J MDC Filter 1.0.0
+1 2014-05-20 7:16 GMT+02:00 Chetan Mehrotra chetan.mehro...@gmail.com: Gentle reminder! Chetan Mehrotra On Thu, May 15, 2014 at 3:09 PM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: +1 Approve the release Chetan Mehrotra On Thu, May 15, 2014 at 3:08 PM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: Hi, This is to vote for the Apache Sling SLF4J MDC Filter 1.0.0 release. This is the first release of this module The docs are up to date at https://github.com/apache/sling/tree/trunk/contrib/extensions/slf4j-mdc Issues fixed https://issues.apache.org/jira/browse/SLING/fixforversion/12326853 Release Notes https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12326853projectId=12310710 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1061 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1061 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. regards Chetan -- Carsten Ziegeler cziege...@apache.org
[jira] [Closed] (SLING-3405) Support Java 8 for compiling scripts
[ https://issues.apache.org/jira/browse/SLING-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3405. --- Support Java 8 for compiling scripts Key: SLING-3405 URL: https://issues.apache.org/jira/browse/SLING-3405 Project: Sling Issue Type: Bug Components: Scripting, Testing Reporter: Bertrand Delacretaz Assignee: Carsten Ziegeler Priority: Minor Fix For: Scripting JSP 2.1.0, Commons Compiler 2.2.0 Attachments: jasper-upgrade.patch Running the launchpad/integration-tests SLING2094Test fails due to a compilation error for the test script [1]: Unable to compile class for JSP, the import java.util.Arrays cannot be resolved. [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/issues/sling2094/sling2094.jsp -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-3486) Configuration changes like jasper.trimSpaces only work after cleaning /var/classes and bundle restart
[ https://issues.apache.org/jira/browse/SLING-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3486. --- Configuration changes like jasper.trimSpaces only work after cleaning /var/classes and bundle restart - Key: SLING-3486 URL: https://issues.apache.org/jira/browse/SLING-3486 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting JSP 2.0.28 Reporter: Markus Haack Assignee: Carsten Ziegeler Labels: jsp, scripting Fix For: Scripting JSP 2.1.0 Enabling jasper.trimSpaces of org.apache.sling.scripting.jsp has not immediately effect and therefor does not work. Fix is to clean /var/classes and restart the instance, then it works. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (SLING-3542) Use commons compiler (instead of embedding own jdt compiler)
[ https://issues.apache.org/jira/browse/SLING-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3542. --- Use commons compiler (instead of embedding own jdt compiler) Key: SLING-3542 URL: https://issues.apache.org/jira/browse/SLING-3542 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting JSP 2.0.28 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Scripting JSP 2.1.0 Currently the jsp scripting embeds its own compiler (which is quiet large). Instead of doing this, the compiler from the commons compiler bundle can be used. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3124) SetupServerWizardPage should not hardcode username/password to admin/admin
[ https://issues.apache.org/jira/browse/SLING-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3124: -- Assignee: Robert Munteanu SetupServerWizardPage should not hardcode username/password to admin/admin -- Key: SLING-3124 URL: https://issues.apache.org/jira/browse/SLING-3124 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3124) SetupServerWizardPage should not hardcode username/password to admin/admin
[ https://issues.apache.org/jira/browse/SLING-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3124. Resolution: Fixed * http://svn.apache.org/viewvc?view=revisionrevision=1596137 minor cleanups * http://svn.apache.org/viewvc?view=revisionrevision=1596138 implementation SetupServerWizardPage should not hardcode username/password to admin/admin -- Key: SLING-3124 URL: https://issues.apache.org/jira/browse/SLING-3124 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002978#comment-14002978 ] Robert Munteanu commented on SLING-3174: I see your point. For this simple bundle project we must minimally have: * a MANIFEST.MF * dependencies to a couple of jars - org.apache.sling.api and javax.servlet * an OSGi component, probably configured with a XML DS descriptor I have done this for the [BundleDeploymentTest|https://github.com/apache/sling/blob/c6b87d8043efde46dad6cb360df738b821da206c/tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/BundleDeploymentTest.java#L75], and therefore know what to do. I see a couple of problems with this approach though: * We should not use the DS annotations, because we can't enable a builder which will generate the XML descriptors * We do not have access to the Maven repository for dependencies since the simple archetypes must be Maven-free My proposal would then be to stick to the Maven-driven process for creating bundle projects, and only add a wizard for simple content projects for 1.0.0 . We can always revisit later, but I don't think this is critical for the 1.0.0 release. [~egli] - how does that sound? [Tooling] add 'new simple content/bundle project' wizards - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[ https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3570: -- Assignee: Robert Munteanu Assertion failed when trying to create new Sling Bundle project --- Key: SLING-3570 URL: https://issues.apache.org/jira/browse/SLING-3570 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 When I try to create a new Sling Bundle project with the wizard I get the following exception: {code} !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020 !MESSAGE assertion failed: !STACK 0 org.eclipse.core.runtime.AssertionFailedException: assertion failed: at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110) at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96) at org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574) at org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124) at org.eclipse.core.internal.resources.Project$1.run(Project.java:612) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345) at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597) at org.eclipse.core.internal.resources.Project.build(Project.java:114) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89) at org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372) {code} I tested with SVN revision 1595036. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3579) Allow performance tests to report custom class name to the report logger
Andrei Dulvac created SLING-3579: Summary: Allow performance tests to report custom class name to the report logger Key: SLING-3579 URL: https://issues.apache.org/jira/browse/SLING-3579 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Priority: Minor allow performance tests to overwrite the class name passed in by the junit runner to the report logger. This is useful for test factories and the like. SLING-3294 breaks SLING-2727 because it forces a toString method on the test class. The proposed solution allows this only if the test case implements IdentifiableClassName#testClassName() -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3579) Allow performance tests to report custom class name to the report logger
[ https://issues.apache.org/jira/browse/SLING-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-3579: - Attachment: SLING-3579.patch Attached svn patch Allow performance tests to report custom class name to the report logger Key: SLING-3579 URL: https://issues.apache.org/jira/browse/SLING-3579 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Priority: Minor Labels: PatchAvailable Attachments: SLING-3579.patch allow performance tests to overwrite the class name passed in by the junit runner to the report logger. This is useful for test factories and the like. SLING-3294 breaks SLING-2727 because it forces a toString method on the test class. The proposed solution allows this only if the test case implements IdentifiableClassName#testClassName() -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3579) Allow performance tests to report custom class name to the report logger
[ https://issues.apache.org/jira/browse/SLING-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-3579: - Labels: PatchAvailable (was: ) Allow performance tests to report custom class name to the report logger Key: SLING-3579 URL: https://issues.apache.org/jira/browse/SLING-3579 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Priority: Minor Labels: PatchAvailable Attachments: SLING-3579.patch allow performance tests to overwrite the class name passed in by the junit runner to the report logger. This is useful for test factories and the like. SLING-3294 breaks SLING-2727 because it forces a toString method on the test class. The proposed solution allows this only if the test case implements IdentifiableClassName#testClassName() -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3294) Simplify Performance Test Creation
[ https://issues.apache.org/jira/browse/SLING-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003031#comment-14003031 ] Andrei Dulvac commented on SLING-3294: -- [~asanso], please see SLING-3579 Simplify Performance Test Creation -- Key: SLING-3294 URL: https://issues.apache.org/jira/browse/SLING-3294 Project: Sling Issue Type: Improvement Components: Testing Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor The current mechanism of differentiate between performance tests is a bit cumbersome and requires to have a different class for different test parameter. The new mechanism will avoid to have those ad-hoc classes -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Silng Models Validation Framework
The problem with connecting something like that with Sling Models is the way the adaptTo method was specified. It is supposed to return null and never throw an exception. So all exceptions being caused by e.g. validation errors must be caught within Sling Models. Currently I don’t see any way to propagate those exceptions across the adaptTo boundary. That might already be a problem when for example some required properties are missing. It is much harder to debug because the exception is caught within the Sling Models framework. I would like to have the possibility to instantiate a model class and to be able to catch all potential exceptions within my own code. Konrad On 19 May 2014, at 14:53, Bertrand Delacretaz bdelacre...@apache.org wrote: On Mon, May 19, 2014 at 1:43 PM, Radu Cotescu r...@cotescu.com wrote: ...Maybe we can revive that topic and merge the two ideas That would be great, IIRC Radu's SLING-2803 validator is meant to be generic, using it within Sling models should then just be another use case. -Bertrand
[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003052#comment-14003052 ] Konrad Windszus commented on SLING-3499: Hi [~justinedelson], my intent was to make it possible to define defaults also within the custom annotations. I didn't leverage that for my custom annotations, because it is just a lot of effort due to type limitations on annotation attributes (http://stackoverflow.com/questions/1458535/which-types-can-be-used-for-java-annotation-members). Therefore I decided to still leverage the default annotation for that. Otherwise a lot of boilerplate code would be necessary, which wouldn't add too much value IMHO. I still would leave it within the annotation processor, because I can image that there might be use cases for that (in other annotations). Support custom annotations with Sling Models Key: SLING-3499 URL: https://issues.apache.org/jira/browse/SLING-3499 Project: Sling Issue Type: New Feature Components: Extensions Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 Reporter: Konrad Windszus To support custom annotations the API needs to be extended. The reasons for custom annotations are listed in http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is much more comfortable for developers, since they can use code completion in the IDE to see which options are available for each injector-specific annotation, apart from that it is less code to write (instead of multiple annotations on one field/method I would only have to write one annotation with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3359) Classloader Leak Detector Console Tab
[ https://issues.apache.org/jira/browse/SLING-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-3359. Resolution: Fixed Classloader Leak Detector Console Tab - Key: SLING-3359 URL: https://issues.apache.org/jira/browse/SLING-3359 Project: Sling Issue Type: New Feature Components: Console Reporter: Ian Boston Assignee: Chetan Mehrotra Fix For: ClassLoader Leak Detector 1.0.0 Attachments: org.apache.sling.extensions.classloader-leak-detector-0.0.1-SNAPSHOT-src.zip Chetan has created a classloader leak detector console at https://github.com/chetanmeh/sling-leak-detector. It would be really good to get this into the contrib are and released so that consumers of Sling can use it to locate code in bundles that is leaking classloaders. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3574) JDBC DataSource Provider bundle
[ https://issues.apache.org/jira/browse/SLING-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated SLING-3574: --- Fix Version/s: DataSource Provider 0.0.2 JDBC DataSource Provider bundle --- Key: SLING-3574 URL: https://issues.apache.org/jira/browse/SLING-3574 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: DataSource Provider 0.0.2 Attachments: org.apache.sling.extensions.datasource-0.0.1-SNAPSHOT-src.zip This patch provides a DataSource provider bundle which configures and registers a DataSource services based on OSGi configuration. it uses Tomcat JDBC pool [1] as the backing Connection Pool # Supports configuring the DataSource based on OSGi config wihich rich metatype # Supports deploying of JDBC Driver as independent bundles and not as fragment # Exposes the DataSource stats as JMX MBean Refer to [2] for further details [1] http://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html [2] https://github.com/chetanmeh/sling-datasource -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3574) JDBC DataSource Provider bundle
[ https://issues.apache.org/jira/browse/SLING-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-3574. Resolution: Fixed Committed the patch with http://svn.apache.org/r1596184 JDBC DataSource Provider bundle --- Key: SLING-3574 URL: https://issues.apache.org/jira/browse/SLING-3574 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: DataSource Provider 0.0.2 Attachments: org.apache.sling.extensions.datasource-0.0.1-SNAPSHOT-src.zip This patch provides a DataSource provider bundle which configures and registers a DataSource services based on OSGi configuration. it uses Tomcat JDBC pool [1] as the backing Connection Pool # Supports configuring the DataSource based on OSGi config wihich rich metatype # Supports deploying of JDBC Driver as independent bundles and not as fragment # Exposes the DataSource stats as JMX MBean Refer to [2] for further details [1] http://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html [2] https://github.com/chetanmeh/sling-datasource -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3580) Remove embedded Tomcat Juli jar by overriding LogFactory which delegates to Slf4j
[ https://issues.apache.org/jira/browse/SLING-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated SLING-3580: --- Summary: Remove embedded Tomcat Juli jar by overriding LogFactory which delegates to Slf4j (was: Remove embedded Tomcat Juli jar by providing overriding LoggerFactory impl which delegates to Slf4j) Remove embedded Tomcat Juli jar by overriding LogFactory which delegates to Slf4j - Key: SLING-3580 URL: https://issues.apache.org/jira/browse/SLING-3580 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Priority: Minor Fix For: DataSource Provider 0.0.2 DataSource provider bundle currently embed the Tomcat Juli jar ~38 kb (required by Tomcat JDBC). This can be easily removed by inlining and overriding the org.apache.juli.logging.LogFactory implementation which delegates to Slf4j -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3582) Support OSGi DataSourceFactory for obtaining connection
Chetan Mehrotra created SLING-3582: -- Summary: Support OSGi DataSourceFactory for obtaining connection Key: SLING-3582 URL: https://issues.apache.org/jira/browse/SLING-3582 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Priority: Minor Fix For: DataSource Provider 0.0.2 DataSource provider currently obtains connection via using the Driver class directly. OSGi provides DataSourceFactory [1]. This factory is supposed to be provided by driver providers and is preferred way to creating DataSource in OSGi env Pax Jdbc [2] provides DataSourceFactory impls for quite a few drivers [3] [1] http://www.osgi.org/javadoc/r4v42/org/osgi/service/jdbc/DataSourceFactory.html [2] https://ops4j1.jira.com/wiki/display/PAXJDBC/Pax+JDBC [3] https://ops4j1.jira.com/wiki/display/PAXJDBC/Native+Driver+Adapters -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
Stefan Egli created SLING-3583: -- Summary: children of folder, containing files besides .content.xml, will get deleted on content-sync Key: SLING-3583 URL: https://issues.apache.org/jira/browse/SLING-3583 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 In slingclipse, when content is synched to a launchpad-server, children of certain folders are immediately deleted after creation. Details: * consider a sling-content project which contains e.g the following structure (node names of children describe their primary type) {code} someparent ├── osgiconfig ├── ntfolder ├── ntunstructured │ └── childofntunstructured └── slingfolder └── childofslingfolder {code} * The SlingLaunchpadBehavior.publishContentModule, which is in charge of updating the launchpad with changes in the eclipse-filesystem, goes through the list of files (Let's assume an initial publish for simplicity reason). * It so happens, that the order of iteration is in such a way, that the someparent/.content.xml is handled last - after the other children have properly been synched with the server. * Upon handling of someparent/.content.xml, SlingLaunchpadBehavior.addFileCommand is executed, and in there, serializationManager.readSerializationData() (or more precisely in VltSerializationManager.readSerializationData()) returns the *parent of the .content.xml file*, namely the 'someparent' node. * With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims that the someparent(ex ./.content.xml) has no children, hence deletes all existing ones from the server. [~rombert], assigning this to you as you're more familiar with the code in that area. I'm uncertain if the real bug is in the readSerializationData or in the AddOrUpdateNodeCommand.. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is unstable: sling-trunk-1.7 #494
See https://builds.apache.org/job/sling-trunk-1.7/494/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #494
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/494/
[jira] [Resolved] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[ https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3570. Resolution: Fixed Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1596228 . I was unable to reproduce this particular issue, but the operations should be properly serialized and hopefully even faster. In my tests everything works, please reopen if there are still problems. Assertion failed when trying to create new Sling Bundle project --- Key: SLING-3570 URL: https://issues.apache.org/jira/browse/SLING-3570 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 When I try to create a new Sling Bundle project with the wizard I get the following exception: {code} !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020 !MESSAGE assertion failed: !STACK 0 org.eclipse.core.runtime.AssertionFailedException: assertion failed: at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110) at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96) at org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574) at org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124) at org.eclipse.core.internal.resources.Project$1.run(Project.java:612) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345) at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597) at org.eclipse.core.internal.resources.Project.build(Project.java:114) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89) at org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372) {code} I tested with SVN revision 1595036. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3581: -- Assignee: (was: Robert Munteanu) Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3581: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.0) Sling Eclipse IDE 1.0.2 Requires changes in the tooling support bundle - Moving to 1.0.2 Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.2 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[ https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003172#comment-14003172 ] Robert Munteanu commented on SLING-3583: [~egli] - can you please attach an archive of the content structure? It's much faster than trying to re-create it myself children of folder, containing files besides .content.xml, will get deleted on content-sync --- Key: SLING-3583 URL: https://issues.apache.org/jira/browse/SLING-3583 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 In slingclipse, when content is synched to a launchpad-server, children of certain folders are immediately deleted after creation. Details: * consider a sling-content project which contains e.g the following structure (node names of children describe their primary type) {code} someparent ├── osgiconfig ├── ntfolder ├── ntunstructured │ └── childofntunstructured └── slingfolder └── childofslingfolder {code} * The SlingLaunchpadBehavior.publishContentModule, which is in charge of updating the launchpad with changes in the eclipse-filesystem, goes through the list of files (Let's assume an initial publish for simplicity reason). * It so happens, that the order of iteration is in such a way, that the someparent/.content.xml is handled last - after the other children have properly been synched with the server. * Upon handling of someparent/.content.xml, SlingLaunchpadBehavior.addFileCommand is executed, and in there, serializationManager.readSerializationData() (or more precisely in VltSerializationManager.readSerializationData()) returns the *parent of the .content.xml file*, namely the 'someparent' node. * With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims that the someparent(ex ./.content.xml) has no children, hence deletes all existing ones from the server. [~rombert], assigning this to you as you're more familiar with the code in that area. I'm uncertain if the real bug is in the readSerializationData or in the AddOrUpdateNodeCommand.. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3581: -- Assignee: Robert Munteanu Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
Build failed in Jenkins: sling-samples-1.6 #440
See https://builds.apache.org/job/sling-samples-1.6/440/ -- Started by an SCM change Building remotely on ubuntu1 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/sling-samples-1.6/ws/ java.io.IOException at hudson.remoting.FastPipedInputStream.read(FastPipedInputStream.java:177) at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) at java.io.InputStreamReader.read(InputStreamReader.java:184) at java.io.Reader.read(Reader.java:140) at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2001) at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1980) at org.apache.commons.io.IOUtils.copy(IOUtils.java:1957) at org.apache.commons.io.IOUtils.copy(IOUtils.java:1907) at org.apache.commons.io.IOUtils.toString(IOUtils.java:778) at org.apache.commons.io.IOUtils.toString(IOUtils.java:759) at hudson.FilePath.readToString(FilePath.java:1664) at hudson.tools.DownloadFromUrlInstaller.isUpToDate(DownloadFromUrlInstaller.java:43) at hudson.tools.DownloadFromUrlInstaller.performInstallation(DownloadFromUrlInstaller.java:67) at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:61) at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:107) at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:204) at hudson.tasks.Maven$MavenInstallation.forNode(Maven.java:609) at hudson.maven.MavenModuleSetBuild.getEnvironment(MavenModuleSetBuild.java:182) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:866) at hudson.model.AbstractProject.checkout(AbstractProject.java:1251) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:513) at hudson.model.Run.execute(Run.java:1706) at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:231) Retrying after 10 seconds java.io.IOException at hudson.remoting.FastPipedInputStream.read(FastPipedInputStream.java:177) at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) at java.io.InputStreamReader.read(InputStreamReader.java:184) at java.io.Reader.read(Reader.java:140) at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2001) at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1980) at org.apache.commons.io.IOUtils.copy(IOUtils.java:1957) at org.apache.commons.io.IOUtils.copy(IOUtils.java:1907) at org.apache.commons.io.IOUtils.toString(IOUtils.java:778) at org.apache.commons.io.IOUtils.toString(IOUtils.java:759) at hudson.FilePath.readToString(FilePath.java:1664) at hudson.tools.DownloadFromUrlInstaller.isUpToDate(DownloadFromUrlInstaller.java:43) at hudson.tools.DownloadFromUrlInstaller.performInstallation(DownloadFromUrlInstaller.java:67) at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:61) at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:107) at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:204) at hudson.tasks.Maven$MavenInstallation.forNode(Maven.java:609) at hudson.maven.MavenModuleSetBuild.getEnvironment(MavenModuleSetBuild.java:182) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:866) at hudson.model.AbstractProject.checkout(AbstractProject.java:1251) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:513) at hudson.model.Run.execute(Run.java:1706) at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:231) Retrying after 10 seconds java.io.IOException at hudson.remoting.FastPipedInputStream.read(FastPipedInputStream.java:177) at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
[jira] [Updated] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[ https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-3583: --- Attachment: bugproject.zip zipped content for reproducing the bug children of folder, containing files besides .content.xml, will get deleted on content-sync --- Key: SLING-3583 URL: https://issues.apache.org/jira/browse/SLING-3583 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: bugproject.zip In slingclipse, when content is synched to a launchpad-server, children of certain folders are immediately deleted after creation. Details: * consider a sling-content project which contains e.g the following structure (node names of children describe their primary type) {code} someparent ├── osgiconfig ├── ntfolder ├── ntunstructured │ └── childofntunstructured └── slingfolder └── childofslingfolder {code} * The SlingLaunchpadBehavior.publishContentModule, which is in charge of updating the launchpad with changes in the eclipse-filesystem, goes through the list of files (Let's assume an initial publish for simplicity reason). * It so happens, that the order of iteration is in such a way, that the someparent/.content.xml is handled last - after the other children have properly been synched with the server. * Upon handling of someparent/.content.xml, SlingLaunchpadBehavior.addFileCommand is executed, and in there, serializationManager.readSerializationData() (or more precisely in VltSerializationManager.readSerializationData()) returns the *parent of the .content.xml file*, namely the 'someparent' node. * With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims that the someparent(ex ./.content.xml) has no children, hence deletes all existing ones from the server. [~rombert], assigning this to you as you're more familiar with the code in that area. I'm uncertain if the real bug is in the readSerializationData or in the AddOrUpdateNodeCommand.. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling SLF4J Implementation (Logback) #2117
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.commons.log/2117/
Jenkins build is unstable: sling-trunk-1.6 #2117
See https://builds.apache.org/job/sling-trunk-1.6/2117/changes
[jira] [Updated] (SLING-3493) Javashell demo doesn't work
[ https://issues.apache.org/jira/browse/SLING-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert updated SLING-3493: Attachment: (was: SLING-3493.diff) Javashell demo doesn't work --- Key: SLING-3493 URL: https://issues.apache.org/jira/browse/SLING-3493 Project: Sling Issue Type: Bug Components: Commons, Samples Reporter: David Bosschaert Assignee: Carsten Ziegeler The JavaShell demo doesn't work because its dependencies have issues with their metadata. The JavaShell demo has dependencies on the org.apache.sling.commons.compiler and org.apache.sling.scripting.java bundles. Both these bundles don't resolve. The org.apache.sling.commons.compiler bundle has: org.osgi.service.prefs,version=[1.1,2) -- Cannot be resolved The org.apache.sling.scripting.java bundle has: org.osgi.framework,version=[1.7,2) -- Cannot be resolved -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3493) Javashell demo doesn't work
[ https://issues.apache.org/jira/browse/SLING-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert updated SLING-3493: Attachment: javashell.diff Thanks for getting back on this, [~cziegeler]. I checked again and indeed those poms have now been fixed and the default deployed content in the launcher too. So I have removed my previous patch. I have attached a new patch that changes the instructions for the demo slightly as with the current code base one less step is required to get the demo running. Javashell demo doesn't work --- Key: SLING-3493 URL: https://issues.apache.org/jira/browse/SLING-3493 Project: Sling Issue Type: Bug Components: Commons, Samples Reporter: David Bosschaert Assignee: Carsten Ziegeler Attachments: javashell.diff The JavaShell demo doesn't work because its dependencies have issues with their metadata. The JavaShell demo has dependencies on the org.apache.sling.commons.compiler and org.apache.sling.scripting.java bundles. Both these bundles don't resolve. The org.apache.sling.commons.compiler bundle has: org.osgi.service.prefs,version=[1.1,2) -- Cannot be resolved The org.apache.sling.scripting.java bundle has: org.osgi.framework,version=[1.7,2) -- Cannot be resolved -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[ https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003244#comment-14003244 ] Robert Munteanu commented on SLING-3583: That's perfect, thanks. children of folder, containing files besides .content.xml, will get deleted on content-sync --- Key: SLING-3583 URL: https://issues.apache.org/jira/browse/SLING-3583 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: bugproject.zip In slingclipse, when content is synched to a launchpad-server, children of certain folders are immediately deleted after creation. Details: * consider a sling-content project which contains e.g the following structure (node names of children describe their primary type) {code} someparent ├── osgiconfig ├── ntfolder ├── ntunstructured │ └── childofntunstructured └── slingfolder └── childofslingfolder {code} * The SlingLaunchpadBehavior.publishContentModule, which is in charge of updating the launchpad with changes in the eclipse-filesystem, goes through the list of files (Let's assume an initial publish for simplicity reason). * It so happens, that the order of iteration is in such a way, that the someparent/.content.xml is handled last - after the other children have properly been synched with the server. * Upon handling of someparent/.content.xml, SlingLaunchpadBehavior.addFileCommand is executed, and in there, serializationManager.readSerializationData() (or more precisely in VltSerializationManager.readSerializationData()) returns the *parent of the .content.xml file*, namely the 'someparent' node. * With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims that the someparent(ex ./.content.xml) has no children, hence deletes all existing ones from the server. [~rombert], assigning this to you as you're more familiar with the code in that area. I'm uncertain if the real bug is in the readSerializationData or in the AddOrUpdateNodeCommand.. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3584) Offline-mode for NodeTypeRegistry
Stefan Egli created SLING-3584: -- Summary: Offline-mode for NodeTypeRegistry Key: SLING-3584 URL: https://issues.apache.org/jira/browse/SLING-3584 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.2 The current NodeTypeRegistry introduced with SLING-3571 only works when connected to a running server (as it retrieves the nodetypes under /jcr:system...). During development a server might not always be running though and/or you might not want to be connected to it all the time (to support batch-publishing for example). Therefore I think we should have an offline-mode for the NodeTypeRegistry (by eg storing the node types in the .settings directory or similar) -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2117
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/2117/
[jira] [Updated] (SLING-3578) Support mapping amendments for service user mapper
[ https://issues.apache.org/jira/browse/SLING-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-3578: Summary: Support mapping amendments for service user mapper (was: [loginservice] serviceusermapper merged configuration) Support mapping amendments for service user mapper -- Key: SLING-3578 URL: https://issues.apache.org/jira/browse/SLING-3578 Project: Sling Issue Type: Improvement Components: Service User Mapper Reporter: Antonio Sanso Assignee: Carsten Ziegeler Priority: Minor Fix For: Service User Mapper 1.0.2 It would be nice to have a way to support an application deployment providing some service user mapping configuration to ammend/merge the existing configuration. See also discussion in [0] [0] http://sling.markmail.org/thread/nxs4dqqiejvvkcx2 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003307#comment-14003307 ] Stefan Egli commented on SLING-3174: bq. * an OSGi component, probably configured with a XML DS descriptor is this really needed for the bare minimum? bq. how does that sound? I agree. Given the timing we should focus on other things for 1.0.0. So: Let's do a 'new simple content wizard' for now, and look at an 'even simpler (than sling's archetypes/bundle) new bundle wizard' later. wdyt? [Tooling] add 'new simple content/bundle project' wizards - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3578) Support mapping amendments for service user mapper
[ https://issues.apache.org/jira/browse/SLING-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003308#comment-14003308 ] Carsten Ziegeler commented on SLING-3578: - I've done a first implementation in rev 1596248 Support mapping amendments for service user mapper -- Key: SLING-3578 URL: https://issues.apache.org/jira/browse/SLING-3578 Project: Sling Issue Type: Improvement Components: Service User Mapper Reporter: Antonio Sanso Assignee: Carsten Ziegeler Priority: Minor Fix For: Service User Mapper 1.0.2 It would be nice to have a way to support an application deployment providing some service user mapping configuration to ammend/merge the existing configuration. See also discussion in [0] [0] http://sling.markmail.org/thread/nxs4dqqiejvvkcx2 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3493) Javashell demo doesn't work
[ https://issues.apache.org/jira/browse/SLING-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3493. - Resolution: Fixed Fix Version/s: Launchpad Builder 7 Thanks David for checking and the updated readme. Your patch is applied Javashell demo doesn't work --- Key: SLING-3493 URL: https://issues.apache.org/jira/browse/SLING-3493 Project: Sling Issue Type: Bug Components: Commons, Samples Reporter: David Bosschaert Assignee: Carsten Ziegeler Fix For: Launchpad Builder 7 Attachments: javashell.diff The JavaShell demo doesn't work because its dependencies have issues with their metadata. The JavaShell demo has dependencies on the org.apache.sling.commons.compiler and org.apache.sling.scripting.java bundles. Both these bundles don't resolve. The org.apache.sling.commons.compiler bundle has: org.osgi.service.prefs,version=[1.1,2) -- Cannot be resolved The org.apache.sling.scripting.java bundle has: org.osgi.framework,version=[1.7,2) -- Cannot be resolved -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[ https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3583. Resolution: Fixed This should now be fixed, your example project works fine for me. * http://svn.apache.org/viewvc?view=revisionrevision=1596257 - simplify usage of ProjectAdapter.createOrUpdateFile * http://svn.apache.org/viewvc?view=revisionrevision=1596258 - added tracing to the node deletion code * http://svn.apache.org/viewvc?view=revisionrevision=1596259 - fixed bug + added regression test children of folder, containing files besides .content.xml, will get deleted on content-sync --- Key: SLING-3583 URL: https://issues.apache.org/jira/browse/SLING-3583 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: bugproject.zip In slingclipse, when content is synched to a launchpad-server, children of certain folders are immediately deleted after creation. Details: * consider a sling-content project which contains e.g the following structure (node names of children describe their primary type) {code} someparent ├── osgiconfig ├── ntfolder ├── ntunstructured │ └── childofntunstructured └── slingfolder └── childofslingfolder {code} * The SlingLaunchpadBehavior.publishContentModule, which is in charge of updating the launchpad with changes in the eclipse-filesystem, goes through the list of files (Let's assume an initial publish for simplicity reason). * It so happens, that the order of iteration is in such a way, that the someparent/.content.xml is handled last - after the other children have properly been synched with the server. * Upon handling of someparent/.content.xml, SlingLaunchpadBehavior.addFileCommand is executed, and in there, serializationManager.readSerializationData() (or more precisely in VltSerializationManager.readSerializationData()) returns the *parent of the .content.xml file*, namely the 'someparent' node. * With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims that the someparent(ex ./.content.xml) has no children, hence deletes all existing ones from the server. [~rombert], assigning this to you as you're more familiar with the code in that area. I'm uncertain if the real bug is in the readSerializationData or in the AddOrUpdateNodeCommand.. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3585) Wizard for creating a new simple OSGi bundle
Robert Munteanu created SLING-3585: -- Summary: Wizard for creating a new simple OSGi bundle Key: SLING-3585 URL: https://issues.apache.org/jira/browse/SLING-3585 Project: Sling Issue Type: New Feature Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.2 (Created as a spin-off from SLING-3174). We should support a simple bundle project which does not require Maven for execution. Open questions * how do we resolve the needed jars in order to add them to the classpath? * what sort of content do we add to the project? A service using DS annotations is out since we don't have the proper builder installed to generate the XML descriptors -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Description: We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. (was: We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse.) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Summary: Add new simple project content wizard (was: [Tooling] add 'new simple content/bundle project' wizards) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003344#comment-14003344 ] Robert Munteanu commented on SLING-3174: {quote}is this really needed for the bare minimum?{quote} We can of course discuss this. But I think we need to create a project that when deployed does something useful, and one example is an OSGi service. Perhaps we can register a service using the classic OSGi approach, but I don't like the idea of promoting a very verbose approach. {quote} Let's do a 'new simple content wizard' for now, and look at an 'even simpler (than sling's archetypes/bundle) new bundle wizard' later. wdyt?{quote} Agreed. Created SLING-3585. [Tooling] add 'new simple content/bundle project' wizards - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Description: We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} was:We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Assignee: Robert Munteanu Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003372#comment-14003372 ] Robert Munteanu commented on SLING-3174: I'm going to need to move some functionality out of the eclipse-m2e-ui plugin, notably the org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard class to make it reusable for this task. That class will move to eclipse-ui, with the Maven-specific functionality remaining in eclipse-m2e-ui as an AbstractNewMavenBasedSlingApplicationWizard ( or a better name , if someone suggests one ) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3587) Publish not triggered by WST on folder creation
Stefan Egli created SLING-3587: -- Summary: Publish not triggered by WST on folder creation Key: SLING-3587 URL: https://issues.apache.org/jira/browse/SLING-3587 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When you create a folder in a directory that is hooked up to a (WST)server, the corresponding publish mechanism doesn't get triggered. The core issue seems to be a WST-bug IMHO: the org.eclipse.wst.server.core.internal.ResourceManager.getPublishRequiredServers's IResourceDeltaVisitor.visit() only returns true if anything related to an IFile has changed. If a folder has changed, it will navigate down to that folder, but won't necessarily find anything changed below there and thus ignore the change. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3587) Publish not triggered by WST on folder creation
[ https://issues.apache.org/jira/browse/SLING-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003384#comment-14003384 ] Stefan Egli commented on SLING-3587: As a workaround, introduced ServerUtil.triggerIncrementalBuild - this can be explicitly triggered wherever a fit is seen. Eg when a new node is created, this can be used to 'force' a publish Publish not triggered by WST on folder creation --- Key: SLING-3587 URL: https://issues.apache.org/jira/browse/SLING-3587 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When you create a folder in a directory that is hooked up to a (WST)server, the corresponding publish mechanism doesn't get triggered. The core issue seems to be a WST-bug IMHO: the org.eclipse.wst.server.core.internal.ResourceManager.getPublishRequiredServers's IResourceDeltaVisitor.visit() only returns true if anything related to an IFile has changed. If a folder has changed, it will navigate down to that folder, but won't necessarily find anything changed below there and thus ignore the change. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003409#comment-14003409 ] Robert Munteanu commented on SLING-3174: Reusable code moved to eclipse-ui in http://svn.apache.org/viewvc?view=revisionrevision=1596282 . Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003431#comment-14003431 ] Robert Munteanu commented on SLING-3174: Added a skeletal implementation in http://svn.apache.org/viewvc?view=revisionrevision=1596287 . Pending: - create more content ( see TODO in code ) - decide how we can test this ( SWT bot? ) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. The initial content should be something like {code} . ├── jcr_root │ ├── content │ └─ example └── META-INF └── vault ├── config.xml ├── filter.xml └── settings.xml {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3587) Publish not triggered by WST on folder creation
[ https://issues.apache.org/jira/browse/SLING-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003436#comment-14003436 ] Robert Munteanu commented on SLING-3587: Yup, see this as well. I think that if we want to force this behaviour, we can introduce a new Builder for content projects which uses the triggerIncrementalBuild facility you just added whenever just a folder is created. Publish not triggered by WST on folder creation --- Key: SLING-3587 URL: https://issues.apache.org/jira/browse/SLING-3587 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When you create a folder in a directory that is hooked up to a (WST)server, the corresponding publish mechanism doesn't get triggered. The core issue seems to be a WST-bug IMHO: the org.eclipse.wst.server.core.internal.ResourceManager.getPublishRequiredServers's IResourceDeltaVisitor.visit() only returns true if anything related to an IFile has changed. If a folder has changed, it will navigate down to that folder, but won't necessarily find anything changed below there and thus ignore the change. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3587) Publish not triggered by WST on folder creation
[ https://issues.apache.org/jira/browse/SLING-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003442#comment-14003442 ] Stefan Egli commented on SLING-3587: Agreed - as a workaround .. PS: I now added taking the server's publish settings into account too.. (at least the mode, not the delay) Publish not triggered by WST on folder creation --- Key: SLING-3587 URL: https://issues.apache.org/jira/browse/SLING-3587 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When you create a folder in a directory that is hooked up to a (WST)server, the corresponding publish mechanism doesn't get triggered. The core issue seems to be a WST-bug IMHO: the org.eclipse.wst.server.core.internal.ResourceManager.getPublishRequiredServers's IResourceDeltaVisitor.visit() only returns true if anything related to an IFile has changed. If a folder has changed, it will navigate down to that folder, but won't necessarily find anything changed below there and thus ignore the change. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3588) Sling console: keep console history since start
Stefan Egli created SLING-3588: -- Summary: Sling console: keep console history since start Key: SLING-3588 URL: https://issues.apache.org/jira/browse/SLING-3588 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Just as an idea: currently the SlingConsoleEventListener throws away events if the console is not showing (==null). Even though it might not be standard, but IMHO it could be useful if the listener keeps the history (with a limit..) and shows it as soon as the console is started. The reasoning is: you don't always start the console right away at startup - but likely when you run into issues - at which point you don't have any history (yet/anymore). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[ https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003542#comment-14003542 ] Konrad Windszus commented on SLING-3570: [~rombert] - Thanks a lot. Works perfectly now for me as well and indeed a lot faster. Assertion failed when trying to create new Sling Bundle project --- Key: SLING-3570 URL: https://issues.apache.org/jira/browse/SLING-3570 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 When I try to create a new Sling Bundle project with the wizard I get the following exception: {code} !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020 !MESSAGE assertion failed: !STACK 0 org.eclipse.core.runtime.AssertionFailedException: assertion failed: at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110) at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96) at org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546) at org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574) at org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124) at org.eclipse.core.internal.resources.Project$1.run(Project.java:612) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345) at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597) at org.eclipse.core.internal.resources.Project.build(Project.java:114) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137) at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89) at org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299) at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161) at org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372) {code} I tested with SVN revision 1595036. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3237) Refine new node creation workflow
[ https://issues.apache.org/jira/browse/SLING-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-3237. Resolution: Fixed Implemented the following: * there's a NodeTypeRegistry, loaded from the repository at start time (offline-mode pending: SLING-3584) * node creation dialog takes NodeTypeRegistry into account when listing possible node types * node creation handles different serializationKinds accordingly Considering this done therefore. Additional issues can be treated separately. Refine new node creation workflow - Key: SLING-3237 URL: https://issues.apache.org/jira/browse/SLING-3237 Project: Sling Issue Type: Sub-task Components: IDE Reporter: Robert Munteanu Assignee: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When creating a new node the dialog unconditionally generates a ${node-name}.xml file. This doesn't really account for whether we are allowed to generate such a node in this location, or whether the node has full or partial coverage. This can lead to invalid structures being serialized on disk. Originally reported by [~dsuess] -- This message was sent by Atlassian JIRA (v6.2#6252)
[RESULT] [VOTE] Release Apache Sling JCR ContentLoader 2.1.8
Hi, the vote has passed with the following result: +1 (binding): Justin Edelson, Carsten Ziegeler, Bertrand Delacretaz +1 (non-binding): Oliver Lietz Thanks for voting! Can a member of the PMC perform the next steps, please? Thanks, O.
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003581#comment-14003581 ] Konrad Windszus commented on SLING-3589: This is due to the fact, that the ProjectUtil.findFilterPath(IProject) does return null for a newly created Sling Content Project. BTW: How do I set the filter appropriately, didn't find anything in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor in the project properties? Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003589#comment-14003589 ] Konrad Windszus commented on SLING-3589: Would it be possible to create a project with a preconfigured filter, when using the wizard? At least the error message should be improved. Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003673#comment-14003673 ] Stefan Egli commented on SLING-3589: [~kwin], added a check for existance of filter.xml - if the filter.xml does not exist, everything is allowed [~rombert], wdyt re supplying a filter.xml as part of the simple content wizard? Plus we should probably (eventually..) have support for filter.xml editing Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003850#comment-14003850 ] Robert Munteanu commented on SLING-3589: [~egli] - yes, the simple content project wizard ( SLING-3174 ) will create a filter.xml file. However, it's safer to guard against filter.xml missing, there's no guarantee that it exists. [~kwin] - I've created a placeholder for the filter docs at https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide#SlingIDEtoolingUserGuide-Filteringtopics-includingfilter.xmldefinition , to make sure it's not forgotten. Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003853#comment-14003853 ] Robert Munteanu commented on SLING-3589: [~egli] - if you already handle missing filter.xml files, can this be closed? Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus Fix For: Sling Eclipse IDE 1.0.0 {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3589: --- Fix Version/s: Sling Eclipse IDE 1.0.0 Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus Fix For: Sling Eclipse IDE 1.0.0 {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[ https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-3589. Resolution: Fixed Assignee: Stefan Egli yup, this one can be closed. Creating new nodes within a new Sling Content Project leads to NPE -- Key: SLING-3589 URL: https://issues.apache.org/jira/browse/SLING-3589 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus Assignee: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 {code} !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NullPointerException at org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938) at org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) {code} I just created a new Sling Content Project with the Wizard and tried to add a new node via right click on jcr_root/apps/example/item - New - New JCR Node. The project is connected to a running server. I tested with SVN rev. 1596303 -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to normal : sling-samples-1.6 #441
See https://builds.apache.org/job/sling-samples-1.6/441/changes
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #495
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/495/
Jenkins build is back to stable : sling-trunk-1.7 #495
See https://builds.apache.org/job/sling-trunk-1.7/495/changes