[jira] [Commented] (SLING-4407) introduce an audit-style logger to job handling
[ https://issues.apache.org/jira/browse/SLING-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322930#comment-14322930 ] Carsten Ziegeler commented on SLING-4407: - Thanks, yepp both makes sense to me introduce an audit-style logger to job handling --- Key: SLING-4407 URL: https://issues.apache.org/jira/browse/SLING-4407 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Event 3.5.0 Reporter: Stefan Egli To help with debugging issues around the job handling we could introduce an 'audit-style logger' which - when enabled - would log the most important actions available on each job, ie: * when the job is created * when it is assigned, reassigned * when it is finished/fails -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: sling-contrib-1.6 #1558
See https://builds.apache.org/job/sling-contrib-1.6/1558/changes Changes: [asanso] SLING-4019 - ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false [radu] SLING-4358 - Add the 'Provide-Capability' OSGi header to the org.apache.sling.scripting.sightly bundle * added Provide-Capability / Require-Capability headers to Sightly bundles [radu] SLING-4285 - Support for resource.getChildren in data-sly-list * added support for obtaining collections from Iterable objects [radu] SLING-4423 - Add support for URI Manipulation options * added support for URI manipulation options according to the language specification * modified Expression such that object is not immutable (helps when transforming the same expression over and over by filters) * defined and ExpressionContext such that filters can choose to process and expression based on this context [radu] SLING-4402 - The selector manipulation options for data-sly-resource should accept string arrays * implemented support for using string arrays in the options for data-sly-resource -- [...truncated 9918 lines...] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.contrib-testing --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 50 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 13 source files to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/test-classes [INFO] [INFO] --- maven-surefire-plugin:2.17:test (default-test) @ org.apache.sling.launchpad.contrib-testing --- [JENKINS] Recording test results[INFO] [INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [INFO] [INFO] --- maven-launchpad-plugin:2.3.0:prepare-package (prepare-package) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Using bundle list file from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT-bundlelist.xml [INFO] Copying base artifact from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.base/2.5.1-SNAPSHOT/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/org.apache.sling.launchpad.base.jar. [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/slf4j-api/1.7.6/slf4j-api-1.7.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/slf4j-api-1.7.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.log/4.0.0/org.apache.sling.commons.log-4.0.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.commons.log-4.0.0.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.commons.logservice-1.0.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/jcl-over-slf4j/1.7.6/jcl-over-slf4j-1.7.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/jcl-over-slf4j-1.7.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/log4j-over-slf4j/1.7.6/log4j-over-slf4j-1.7.6.jar to
[jira] [Resolved] (SLING-4019) ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false
[
https://issues.apache.org/jira/browse/SLING-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso resolved SLING-4019.
--
Resolution: Fixed
fixed in r1660146
ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false
---
Key: SLING-4019
URL: https://issues.apache.org/jira/browse/SLING-4019
Project: Sling
Issue Type: Bug
Reporter: Antonio Sanso
Assignee: Antonio Sanso
The ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false.
The reasons is that the attacker can force an empty referrer in at least two
ways:
- is the victim site runs using http the attacker can create a mallory page
under an https site. In this case (namely https-to-http) the referrer is not
passed.
- The attacker create a dynamic post doing something like:
{code}
head
script
function load() {
var postdata = 'form id=dynForm method=POST
action=\'https://www.google.com\'' +
'input type=hidden name=email value=exam...@live.com /'
+
'input type=hidden name=pass value=password /' +
'input type=hidden name=locale value=en_US /' +
'/form';
top.frames[0].document.body.innerHTML=postdata;
top.frames[0].document.getElementById('dynForm').submit();
}
/script
/head
body onload=load()
iframe src=about:blank id=noreferer/iframe
/body
/html
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4377) Add JSR305 nullness annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4377:
---
Summary: Add JSR305 nullness annotations to Sling API (was: Add JSR305
annotations to Sling API)
Add JSR305 nullness annotations to Sling API
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.6 #3063
See https://builds.apache.org/job/sling-trunk-1.6/3063/changes
Jenkins build is still unstable: sling-trunk-1.8 #741
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.8 #742
See https://builds.apache.org/job/sling-trunk-1.8/changes
Re: [VOTE] Release Apache Sling Engine Implementation 2.4.0
+1 Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build is still unstable: sling-trunk-1.8 #744
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.8 #743
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.6 #3064
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Resolved] (SLING-4364) Integrate new JavaScript node type library
[ https://issues.apache.org/jira/browse/SLING-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-4364. -- Resolution: Done fixed in rev. 1660179 Integrate new JavaScript node type library -- Key: SLING-4364 URL: https://issues.apache.org/jira/browse/SLING-4364 Project: Sling Issue Type: New Feature Components: Commons Reporter: Sandro Boehme Assignee: Sandro Boehme This copies the code I ([~sandro]) have written at GitHub [1] to Apache Sling as discussed [2] at the mailing list. [1] - https://github.com/sandroboehme/jsNodeTypes [2] - http://apache-sling.73963.n3.nabble.com/PROPOSAL-JSNodeTypes-contribution-tp4045070.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.7 #1453
See https://builds.apache.org/job/sling-trunk-1.7/1453/changes
Jenkins build is still unstable: sling-trunk-1.6 #3065
See https://builds.apache.org/job/sling-trunk-1.6/changes
Jenkins build is still unstable: sling-trunk-1.8 #745
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.7 #1455
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is back to stable : sling-trunk-1.6 #3067
See https://builds.apache.org/job/sling-trunk-1.6/3067/changes
[jira] [Created] (SLING-4424) JcrCellLabelProvider leaks font instances
Robert Munteanu created SLING-4424: -- Summary: JcrCellLabelProvider leaks font instances Key: SLING-4424 URL: https://issues.apache.org/jira/browse/SLING-4424 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 JcrCellLabelProvider creates Font instances in its contructor but does not dispose of them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.6 #3066
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Created] (SLING-4425) java.lang.NoClassDefFoundError: org/w3c/dom/ElementTraversal when parsing HTML5 templates
Oliver Lietz created SLING-4425: --- Summary: java.lang.NoClassDefFoundError: org/w3c/dom/ElementTraversal when parsing HTML5 templates Key: SLING-4425 URL: https://issues.apache.org/jira/browse/SLING-4425 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Thymeleaf 0.0.4 Environment: AEM6SP2 Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Scripting Thymeleaf 0.0.6 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4377) Add JSR305 nullness annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323791#comment-14323791
]
Carsten Ziegeler commented on SLING-4377:
-
Thanks for the hard work, [~kwin]
The changes look good to me, with some minor exceptions:
- with this in place, we require Java 6 for the API; I don't think this is a
problem, but we should be aware of it
- ResourceProvider#listChildren is allowed to return null - we should enhance
the javadocs to mention this
+1 for applying it (with the above change)
Add JSR305 nullness annotations to Sling API
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 #1456
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is back to stable : sling-trunk-1.8 #746
See https://builds.apache.org/job/sling-trunk-1.8/746/changes
[jira] [Commented] (SLING-4407) introduce an audit-style logger to job handling
[ https://issues.apache.org/jira/browse/SLING-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322804#comment-14322804 ] Carsten Ziegeler commented on SLING-4407: - [~egli] Nice idea, right now we create OSGi events for created/start/finished/failed - assigned is identical with created due to the push model we're using; reassigned is missing. We could create OSGi events for that as well and could then implement an audit log based on the events. Or we could really do the logging at the low level. Now, I'm wondering what the best approach wrt clustered installations is - as the action can take place on any node in a cluster, we could log on each node whenever an action is taken; of course this would require log aggregation later on to get the full picture. Or we could log on the master only, but then the master might change. WDYT? introduce an audit-style logger to job handling --- Key: SLING-4407 URL: https://issues.apache.org/jira/browse/SLING-4407 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Event 3.5.0 Reporter: Stefan Egli To help with debugging issues around the job handling we could introduce an 'audit-style logger' which - when enabled - would log the most important actions available on each job, ie: * when the job is created * when it is assigned, reassigned * when it is finished/fails -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #740
See https://builds.apache.org/job/sling-trunk-1.8/changes
[VOTE] Release Apache Sling Engine Implementation 2.4.0
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12329015https://issues.apache.org/jira/browse/SLING/fixforversion/12329064 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1185/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1185 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Engine Implementation 2.4.0
+1 regards antonio On Feb 16, 2015, at 3:28 PM, Antonio Sanso asa...@adobe.com wrote: Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12329015https://issues.apache.org/jira/browse/SLING/fixforversion/12329064 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1185/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1185 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Commented] (SLING-3829) Add support for Content-Disposition attachment
[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322710#comment-14322710 ] Oliver Lietz commented on SLING-3829: - Then check for content type in an additional rule and (re)set header there. Add support for Content-Disposition attachment --- Key: SLING-3829 URL: https://issues.apache.org/jira/browse/SLING-3829 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor In some situation will be useful (and safer) to force Content-Disposition attachment for some Content-Type (configurable ) under some specific (and sensitive) path (configurable) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #739
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Created] (SLING-4422) In distribution servlets use sling.commons.json to build json responses
Marius Petria created SLING-4422: Summary: In distribution servlets use sling.commons.json to build json responses Key: SLING-4422 URL: https://issues.apache.org/jira/browse/SLING-4422 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4407) introduce an audit-style logger to job handling
[ https://issues.apache.org/jira/browse/SLING-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322819#comment-14322819 ] Stefan Egli commented on SLING-4407: bq. ...reassigned is missing. We could create OSGi events for that as well... one argument against that would be that it then becomes part of the API and would have to be supported going forward - even if we change the job implementation entirely. But maybe that's not that much of a problem. Just wondering who would be interested in receiving reassigned events and doing anything based on it? bq. we could log on each node whenever an action is taken I was assuming it would work that way, yes. So more of a technical logging to follow the job if something goes wrong - or to understand why a job was 'routed' to a particular node etc. Re aggregation, I'd point to tools like splunk or similar..? introduce an audit-style logger to job handling --- Key: SLING-4407 URL: https://issues.apache.org/jira/browse/SLING-4407 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Event 3.5.0 Reporter: Stefan Egli To help with debugging issues around the job handling we could introduce an 'audit-style logger' which - when enabled - would log the most important actions available on each job, ie: * when the job is created * when it is assigned, reassigned * when it is finished/fails -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4423) Add support for URI Manipulation options
Radu Cotescu created SLING-4423: --- Summary: Add support for URI Manipulation options Key: SLING-4423 URL: https://issues.apache.org/jira/browse/SLING-4423 Project: Sling Issue Type: Sub-task Components: Scripting Reporter: Radu Cotescu Assignee: Radu Cotescu Fix For: Scripting Sightly Engine 1.0.0 The Sling implementation of Sightly should provide support for URI Manipulation options \[0\]. \[0\] - https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#125-uri-manipulation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4423) Add support for URI Manipulation options
[ https://issues.apache.org/jira/browse/SLING-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-4423. - Resolution: Fixed Fixed in [r1660131|https://svn.apache.org/viewvc?view=revisionrevision=1660131]. Add support for URI Manipulation options Key: SLING-4423 URL: https://issues.apache.org/jira/browse/SLING-4423 Project: Sling Issue Type: Sub-task Components: Scripting Reporter: Radu Cotescu Assignee: Radu Cotescu Fix For: Scripting Sightly Engine 1.0.0 The Sling implementation of Sightly should provide support for URI Manipulation options \[0\]. \[0\] - https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#125-uri-manipulation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: sling-contrib-1.6 #1557
See https://builds.apache.org/job/sling-contrib-1.6/1557/changes Changes: [mpetria] SLING-4422: using commons.json to build distribution servlet responses -- [...truncated 10321 lines...] [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.launchpad.contrib-testing --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 50 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 13 source files to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/test-classes [INFO] [INFO] --- maven-surefire-plugin:2.17:test (default-test) @ org.apache.sling.launchpad.contrib-testing --- [JENKINS] Recording test results[INFO] [INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [INFO] [INFO] --- maven-launchpad-plugin:2.3.0:prepare-package (prepare-package) @ org.apache.sling.launchpad.contrib-testing --- [INFO] Using bundle list file from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT-bundlelist.xml [INFO] Copying base artifact from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.base/2.5.1-SNAPSHOT/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/org.apache.sling.launchpad.base.jar. [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/slf4j-api/1.7.6/slf4j-api-1.7.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/slf4j-api-1.7.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.log/4.0.0/org.apache.sling.commons.log-4.0.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.commons.log-4.0.0.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.commons.logservice-1.0.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/jcl-over-slf4j/1.7.6/jcl-over-slf4j-1.7.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/jcl-over-slf4j-1.7.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/log4j-over-slf4j/1.7.6/log4j-over-slf4j-1.7.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/log4j-over-slf4j-1.7.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.settings/1.3.2/org.apache.sling.settings-1.3.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.settings-1.3.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.fragment.xml-1.0.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/launchpad/testing/target/launchpad-bundles/resources/bundles/1/org.apache.sling.fragment.transaction-1.0.0.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar to
[jira] [Updated] (SLING-4285) Support for resource.getChildren in data-sly-list
[
https://issues.apache.org/jira/browse/SLING-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4285:
Fix Version/s: (was: Scripting Sightly Engine 1.0.2)
Scripting Sightly Engine 1.0.0
Support for resource.getChildren in data-sly-list
-
Key: SLING-4285
URL: https://issues.apache.org/jira/browse/SLING-4285
Project: Sling
Issue Type: Improvement
Components: Scripting
Reporter: Feike Visser
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
Currently this is not working in sightly:
{code}
data-sly-list=${resource.children}
data-sly-list=${resource.getChildren}
{code}
Feedback from [~radu.cotescu]
Resource#getChildren returns an Iterable. Currently the Sightly
implementation doesn’t attempt to obtain a collection from an Iterable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SLING-4019) ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false
[
https://issues.apache.org/jira/browse/SLING-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso reassigned SLING-4019:
Assignee: Antonio Sanso
ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false
---
Key: SLING-4019
URL: https://issues.apache.org/jira/browse/SLING-4019
Project: Sling
Issue Type: Bug
Reporter: Antonio Sanso
Assignee: Antonio Sanso
The ReferrerFilter should have DEFAULT_ALLOW_EMPTY set to false.
The reasons is that the attacker can force an empty referrer in at least two
ways:
- is the victim site runs using http the attacker can create a mallory page
under an https site. In this case (namely https-to-http) the referrer is not
passed.
- The attacker create a dynamic post doing something like:
{code}
head
script
function load() {
var postdata = 'form id=dynForm method=POST
action=\'https://www.google.com\'' +
'input type=hidden name=email value=exam...@live.com /'
+
'input type=hidden name=pass value=password /' +
'input type=hidden name=locale value=en_US /' +
'/form';
top.frames[0].document.body.innerHTML=postdata;
top.frames[0].document.getElementById('dynForm').submit();
}
/script
/head
body onload=load()
iframe src=about:blank id=noreferer/iframe
/body
/html
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4422) In distribution servlets use sling.commons.json to build json responses
[ https://issues.apache.org/jira/browse/SLING-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322827#comment-14322827 ] Marius Petria commented on SLING-4422: -- Committed revision 1660129. In distribution servlets use sling.commons.json to build json responses Key: SLING-4422 URL: https://issues.apache.org/jira/browse/SLING-4422 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria Fix For: Content Distribution 0.1.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4422) In distribution servlets use sling.commons.json to build json responses
[ https://issues.apache.org/jira/browse/SLING-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria resolved SLING-4422. -- Resolution: Fixed Fix Version/s: Content Distribution 0.1.0 Assignee: Marius Petria In distribution servlets use sling.commons.json to build json responses Key: SLING-4422 URL: https://issues.apache.org/jira/browse/SLING-4422 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria Assignee: Marius Petria Fix For: Content Distribution 0.1.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4402) The selector manipulation options for data-sly-resource should accept string arrays
[
https://issues.apache.org/jira/browse/SLING-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4402.
-
Resolution: Fixed
Fixed in
[r1660132|https://svn.apache.org/viewvc?view=revisionrevision=1660132].
The selector manipulation options for data-sly-resource should accept string
arrays
---
Key: SLING-4402
URL: https://issues.apache.org/jira/browse/SLING-4402
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The Sightly specification allows using string arrays for options that
manipulate selectors for the {{data-sly-resource}} block element \[0\].
However, the current implementation only allows string values.
\[0\] -
https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#229-resource
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4402) The selector manipulation options for data-sly-resource should accept string arrays
[
https://issues.apache.org/jira/browse/SLING-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322835#comment-14322835
]
Radu Cotescu edited comment on SLING-4402 at 2/16/15 3:04 PM:
--
Fixed in
[r1660131|https://svn.apache.org/viewvc?view=revisionrevision=1660131].
was (Author: radu.cotescu):
Fixed in
[r1660132|https://svn.apache.org/viewvc?view=revisionrevision=1660132].
The selector manipulation options for data-sly-resource should accept string
arrays
---
Key: SLING-4402
URL: https://issues.apache.org/jira/browse/SLING-4402
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The Sightly specification allows using string arrays for options that
manipulate selectors for the {{data-sly-resource}} block element \[0\].
However, the current implementation only allows string values.
\[0\] -
https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#229-resource
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4423) Add support for URI Manipulation options
[ https://issues.apache.org/jira/browse/SLING-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322838#comment-14322838 ] Radu Cotescu edited comment on SLING-4423 at 2/16/15 3:04 PM: -- Fixed in [r1660132|https://svn.apache.org/viewvc?view=revisionrevision=1660132]. was (Author: radu.cotescu): Fixed in [r1660131|https://svn.apache.org/viewvc?view=revisionrevision=1660131]. Add support for URI Manipulation options Key: SLING-4423 URL: https://issues.apache.org/jira/browse/SLING-4423 Project: Sling Issue Type: Sub-task Components: Scripting Reporter: Radu Cotescu Assignee: Radu Cotescu Fix For: Scripting Sightly Engine 1.0.0 The Sling implementation of Sightly should provide support for URI Manipulation options \[0\]. \[0\] - https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/master/SPECIFICATION.md#125-uri-manipulation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4285) Support for resource.getChildren in data-sly-list
[
https://issues.apache.org/jira/browse/SLING-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4285.
-
Resolution: Fixed
Fixed in revision
[r1660135|https://svn.apache.org/viewvc?view=revisionrevision=1660135].
Support for resource.getChildren in data-sly-list
-
Key: SLING-4285
URL: https://issues.apache.org/jira/browse/SLING-4285
Project: Sling
Issue Type: Improvement
Components: Scripting
Reporter: Feike Visser
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
Currently this is not working in sightly:
{code}
data-sly-list=${resource.children}
data-sly-list=${resource.getChildren}
{code}
Feedback from [~radu.cotescu]
Resource#getChildren returns an Iterable. Currently the Sightly
implementation doesn’t attempt to obtain a collection from an Iterable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] sling pull request: SLING-4377, add JSR 305 annotations to Sling A...
GitHub user kwin opened a pull request: https://github.com/apache/sling/pull/63 SLING-4377, add JSR 305 annotations to Sling API You can merge this pull request into a Git repository by running: $ git pull https://github.com/kwin/sling SLING-4377-jsr305 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit c2a34c7ee8930af7bba9d9dd871f60d1c9045928 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-02T09:47:56Z SLING-4377, initial version of JSR 305 annotations commit d77d9b01b53df5d498b659bb55e34b26ff11b41b Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-02T09:55:46Z SLING-4377, upgrade to Java 6 commit c7a24338591bf00ab2c9d6543d11c2c219592966 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-02T09:56:07Z SLING-4377, revert excessive version increase commit 44f3a2e28aa3fe48ce075212e8cc958613bf1e2f Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-04T09:22:18Z SLING-4377 use @CheckForNull instead of @Nullable as this is also understood by Findbugs commit ab0e6fb1a9e1fa9fc83dba2c639766f23ff406b9 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-16T11:15:00Z Merge branch 'trunk' into SLING-4377-jsr305 Conflicts: bundles/api/src/main/java/org/apache/sling/api/resource/package-info.java commit fad1934e33ee896de5f8b2d42e16dd9b06e64de0 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-16T13:19:13Z restrict JSR 305 annotations to @CheckForNull and @Nonnull commit e2111ad76cd5cd1c21e8d15bfdc5e727e04af980 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-16T13:37:23Z bugfixing commit f13596462a680cd7f642161ddcc14a8350b096bf Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-16T14:23:41Z fix version, cannot determine null semantics for ValueMap.get with a default value commit 86dfebe65805eb9478335f50217b6d84b0996a56 Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2015-02-16T15:26:23Z revert to 2.8.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (SLING-4377) Add JSR305 annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322872#comment-14322872
]
ASF GitHub Bot commented on SLING-4377:
---
GitHub user kwin opened a pull request:
https://github.com/apache/sling/pull/63
SLING-4377, add JSR 305 annotations to Sling API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwin/sling SLING-4377-jsr305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
commit c2a34c7ee8930af7bba9d9dd871f60d1c9045928
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-02T09:47:56Z
SLING-4377, initial version of JSR 305 annotations
commit d77d9b01b53df5d498b659bb55e34b26ff11b41b
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-02T09:55:46Z
SLING-4377, upgrade to Java 6
commit c7a24338591bf00ab2c9d6543d11c2c219592966
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-02T09:56:07Z
SLING-4377, revert excessive version increase
commit 44f3a2e28aa3fe48ce075212e8cc958613bf1e2f
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-04T09:22:18Z
SLING-4377 use @CheckForNull instead of @Nullable as this is also
understood by Findbugs
commit ab0e6fb1a9e1fa9fc83dba2c639766f23ff406b9
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-16T11:15:00Z
Merge branch 'trunk' into SLING-4377-jsr305
Conflicts:
bundles/api/src/main/java/org/apache/sling/api/resource/package-info.java
commit fad1934e33ee896de5f8b2d42e16dd9b06e64de0
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-16T13:19:13Z
restrict JSR 305 annotations to @CheckForNull and @Nonnull
commit e2111ad76cd5cd1c21e8d15bfdc5e727e04af980
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-16T13:37:23Z
bugfixing
commit f13596462a680cd7f642161ddcc14a8350b096bf
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-16T14:23:41Z
fix version, cannot determine null semantics for ValueMap.get with a
default value
commit 86dfebe65805eb9478335f50217b6d84b0996a56
Author: Konrad Windszus konrad.winds...@netcentric.biz
Date: 2015-02-16T15:26:23Z
revert to 2.8.0
Add JSR305 annotations to Sling API
---
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4358) Add the 'Provide-Capability' OSGi header to the org.apache.sling.scripting.sightly bundle
[
https://issues.apache.org/jira/browse/SLING-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4358.
-
Resolution: Fixed
Fixed in
[r1660139|https://svn.apache.org/viewvc?view=revisionrevision=1660139].
Add the 'Provide-Capability' OSGi header to the
org.apache.sling.scripting.sightly bundle
-
Key: SLING-4358
URL: https://issues.apache.org/jira/browse/SLING-4358
Project: Sling
Issue Type: Sub-task
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The OSGi {{Provide-Capability}} \[0\] header should be added to the
{{org.apache.sling.scripting.sightly}} bundle to easily identify what version
of the Sightly specification \[1\] the bundle implements.
\[0\] - http://wiki.osgi.org/wiki/Provide-Capability
\[1\] - https://github.com/Adobe-Marketing-Cloud/sightly-spec/releases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4353) Update the Sightly implementation to comply with version 1.1 of the language specification
[
https://issues.apache.org/jira/browse/SLING-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4353.
-
Resolution: Fixed
Update the Sightly implementation to comply with version 1.1 of the language
specification
--
Key: SLING-4353
URL: https://issues.apache.org/jira/browse/SLING-4353
Project: Sling
Issue Type: Improvement
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The Sightly language specification \[0\] has been updated to version 1.1,
therefore the implementation from {{org.apache.sling.scripting.sightly}}
should be updated.
\[0\] -
https://github.com/Adobe-Marketing-Cloud/sightly-spec/blob/1.1/SPECIFICATION.md
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4377) Add JSR305 annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322888#comment-14322888
]
Konrad Windszus commented on SLING-4377:
[~cziegeler] Can you have a look at the Pull request and directly comment on
that if there are any issues with it? Thanks a lot.
Add JSR305 annotations to Sling API
---
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[VOTE RESULT] Release Apache Sling Event 3.5.2
This vote passed with four binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE RESULT] Release Apache Sling Resource Resolver 1.1.14
This vote passed with five binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Closed] (SLING-4378) Make handling of unregistering a resource provider configurable
[ https://issues.apache.org/jira/browse/SLING-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-4378. --- Make handling of unregistering a resource provider configurable --- Key: SLING-4378 URL: https://issues.apache.org/jira/browse/SLING-4378 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.12 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Resource Resolver 1.1.14 With SLING-4363 we introduced a more agressive handling of resource provider unregistration (not factories). We should make this configurable and set the default to disable it to be more in line with the behaviour before this change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4418) Round robin queue is handled as an ordered queue
[ https://issues.apache.org/jira/browse/SLING-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-4418. --- Round robin queue is handled as an ordered queue Key: SLING-4418 URL: https://issues.apache.org/jira/browse/SLING-4418 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.5.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Event 3.5.2 The round robin queue is treated as an ordered queue and there all processing takes place on master and it's limited to one job at a time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4372) The use of finalize in ResourceResolver leads to performance issues
[ https://issues.apache.org/jira/browse/SLING-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-4372. --- The use of finalize in ResourceResolver leads to performance issues --- Key: SLING-4372 URL: https://issues.apache.org/jira/browse/SLING-4372 Project: Sling Issue Type: Improvement Affects Versions: Resource Resolver 1.1.12 Reporter: Konrad Windszus Assignee: Carsten Ziegeler Fix For: Resource Resolver 1.1.14 Currently there is a finalizer implemented for the ResourceResolverImpl (http://svn.apache.org/repos/asf/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java). This defers garbage collection. For a more detailed analysis and also some metrics around that have a look at https://issues.apache.org/jira/browse/JCR-2768. A similar approach like in the patch attached to JCR-2768 should be implemented for the ResourceResolverImpl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4421) Remove duplicate API method bodys
Carsten Ziegeler created SLING-4421: --- Summary: Remove duplicate API method bodys Key: SLING-4421 URL: https://issues.apache.org/jira/browse/SLING-4421 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.3.10 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.3.12 The engine API deprecates RequestUtil and ResponseUtil in favour of the variants from the Sling API. Instead of duplication the code from the Sling API, we should simply call the Sling API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4421) Remove duplicate API method bodys
[ https://issues.apache.org/jira/browse/SLING-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-4421. - Resolution: Fixed Solved by simply calling the Sling API methods (which are identical) Remove duplicate API method bodys - Key: SLING-4421 URL: https://issues.apache.org/jira/browse/SLING-4421 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.3.10 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.3.12 The engine API deprecates RequestUtil and ResponseUtil in favour of the variants from the Sling API. Instead of duplication the code from the Sling API, we should simply call the Sling API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4398) Potential NPE when non existing resource has no parent
[ https://issues.apache.org/jira/browse/SLING-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-4398. --- Potential NPE when non existing resource has no parent -- Key: SLING-4398 URL: https://issues.apache.org/jira/browse/SLING-4398 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Resource Merger 1.2.4 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Resource Merger 1.2.6 There is a potential NPE in MergingResourceProvider#getResource if a non existing resource returns null for getParent() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4410) Make default bundle location configurable
[ https://issues.apache.org/jira/browse/SLING-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-4410. --- Make default bundle location configurable - Key: SLING-4410 URL: https://issues.apache.org/jira/browse/SLING-4410 Project: Sling Issue Type: Improvement Components: Installer Affects Versions: Installer Configuration Factory 1.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Installer Configuration Factory 1.1.2 We should make the default bundle location for a new configuration handled by the installer configurable. WIth versions 1.0.x this was null, with 1.1.0 we switched to ?. We should revert the default to null but provide a way to change that default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Apache Sling Installer Configuration Factory 1.1.2
The vote passed with three binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE RESULT] Release Apache Sling Resource Merger 1.2.6
The vote passed with four binding +1 votes Thanks -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build became unstable: sling-trunk-1.8 #737
See https://builds.apache.org/job/sling-trunk-1.8/737/changes
Jenkins build is still unstable: sling-trunk-1.8 #738
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Updated] (SLING-4377) Add JSR305 annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4377:
---
Description:
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is using
those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should therefore
not be used. The package annotation for the default handling should also not be
used (because either {{@Nullable}} or {{@CheckForNull}} is ignored by Eclipse
then.
was:
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is using
those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 3 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}}, the
parameters are usually covered by the {{@ParametersAreNonNullByDefault}}
annotation.
# {{@CheckForNull}}, for return values wich may be null {{null}}}
# {{@Nullable}}, for parameter which may be {{null}}, overwriting the
{{@ParametersAreNonNullByDefault}} annotation on package/class level
# {{@ParametersAreNonNullByDefault}}, should only be used o package or class
level.
Those are the only ones being supported by both Eclipse and Findbugs.
Nullable is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should therefore
not be used. Eclipse can be configured so it can deal with CheckForNull as
well. Also Solr is only using {{@Nonnull}} and {{@CheckForNull}}.
Add JSR305 annotations to Sling API
---
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4332) Malformed .content.xml files cause unhandled errors and break the content navigator
[
https://issues.apache.org/jira/browse/SLING-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-4332.
Resolution: Fixed
Malformed .content.xml files cause unhandled errors and break the content
navigator
---
Key: SLING-4332
URL: https://issues.apache.org/jira/browse/SLING-4332
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.6
Assume a broken XML file named .content.xml is placed in a content project,
as below ( note the missing xmlns:rep attribute )
{code:xml}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:sling=http://sling.apache.org/jcr/sling/1.0;
xmlns:jcr=http://www.jcp.org/jcr/1.0;
jcr:mixinTypes=[rep:AccessControllable]
jcr:primaryType=sling:OrderedFolder
rep:policy/
/jcr:root
{code}
An unhandled exception will be propagated to the user and the content
navigator will be broken - only the jcr_root entry will appear, without an
icon, and can't be expanded.
We should be more resilient and skip resources with XML parsing errors.
Perhaps we should also turn off namespace validation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4332) Malformed .content.xml files cause unhandled errors and break the content navigator
[
https://issues.apache.org/jira/browse/SLING-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322662#comment-14322662
]
Robert Munteanu commented on SLING-4332:
F8xed in https://svn.apache.org/viewvc?view=revisionrevision=r1660070
Malformed .content.xml files cause unhandled errors and break the content
navigator
---
Key: SLING-4332
URL: https://issues.apache.org/jira/browse/SLING-4332
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.6
Assume a broken XML file named .content.xml is placed in a content project,
as below ( note the missing xmlns:rep attribute )
{code:xml}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:sling=http://sling.apache.org/jcr/sling/1.0;
xmlns:jcr=http://www.jcp.org/jcr/1.0;
jcr:mixinTypes=[rep:AccessControllable]
jcr:primaryType=sling:OrderedFolder
rep:policy/
/jcr:root
{code}
An unhandled exception will be propagated to the user and the content
navigator will be broken - only the jcr_root entry will appear, without an
icon, and can't be expanded.
We should be more resilient and skip resources with XML parsing errors.
Perhaps we should also turn off namespace validation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3829) Add support for Content-Disposition attachment
[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322676#comment-14322676 ] Antonio Sanso commented on SLING-3829: -- [~olli] bq. You can exclude by extension, no? I wouldn't mix request's extension and response's content type specially on something that is a security concern as this issue Add support for Content-Disposition attachment --- Key: SLING-3829 URL: https://issues.apache.org/jira/browse/SLING-3829 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor In some situation will be useful (and safer) to force Content-Disposition attachment for some Content-Type (configurable ) under some specific (and sensitive) path (configurable) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[VOTE][RESULT] Release Apache Sling Authentication Service 1.3.6
This vote passed with 4 binding +1 votes Thanks Antonio
[jira] [Closed] (SLING-4399) Regression in the SlingAuthenticator
[
https://issues.apache.org/jira/browse/SLING-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso closed SLING-4399.
Regression in the SlingAuthenticator
Key: SLING-4399
URL: https://issues.apache.org/jira/browse/SLING-4399
Project: Sling
Issue Type: Bug
Components: Authentication
Affects Versions: Auth Core 1.3.4
Reporter: Antonio Sanso
Assignee: Antonio Sanso
Fix For: Auth Core 1.3.6
SLING-3936 introduced a regression.
Obseving the diff
{code}
- for (int i = 0; !done i holderList.size(); i++) {
- final AbstractAuthenticationHandlerHolder holder = holderList.get(i);
+ for (AbstractAuthenticationHandlerHolder holder : holderList) {
{code}
it is clear that {{!done}} has been lost in translation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
