date:20150309


[ 
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352842#comment-14352842
 ] 

ASF GitHub Bot commented on SLING-4483:
---

GitHub user vladbailescu opened a pull request:

https://github.com/apache/sling/pull/66

SLING-4483 - Sightly: data-sly-resource does not properly resolve relative 
paths

Prepended current resource path to relative paths to make sure 
normalization doesn't break the paths. The same approach is used by 
sling:include ../

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladbailescu/sling 
SLING-4483-sightly-resource-relative-paths

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 9728f8ae36001c174fa9ae74a9a6ac17e0979df9
Author: vladbailescu baile...@adobe.com
Date:   2015-03-09T11:39:34Z

SLING-4483 - Sightly: data-sly-resource does not properly resolve relative 
paths

Prepended current resource path to relative paths to make sure 
normalization doesn't break the paths. The same approach is used by 
sling:include ../




 Sightly: data-sly-resource does not properly resolve relative paths
 ---

 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
Reporter: Vlad Bailescu
Priority: Minor

 The following resource inclusion is not working:
 {code:html}
 div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
 {code}
 The returned error is: 
 {{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
  Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling Resource Merger 1.2.8

+1

Robert

On Mon, Mar 9, 2015 at 10:55 AM, Carsten Ziegeler cziege...@apache.org wrote:
 +1

 --
 Carsten Ziegeler
 Adobe Research Switzerland
 cziege...@apache.org

[jira] [Closed] (SLING-4383) Extend @since inJavadoc of Sling API to include package version and bundle version


 [ 
https://issues.apache.org/jira/browse/SLING-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4383.
---

 Extend @since inJavadoc of Sling API to include package version and bundle 
 version
 --

 Key: SLING-4383
 URL: https://issues.apache.org/jira/browse/SLING-4383
 Project: Sling
  Issue Type: Bug
Affects Versions: API 2.7.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Priority: Trivial
 Fix For: API 2.9.0

 Attachments: SLING-4383-v01.patch


 It currently states that this method was added with 2.5.0 but this is not 
 correct. It was only added with 2.7.0 (SLING-3451)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352894#comment-14352894
 ] 

Carsten Ziegeler commented on SLING-4312:
-

+1 to Felix comments

 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4484) XSS POM references wrong scm URLs


 [ 
https://issues.apache.org/jira/browse/SLING-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4484:

Component/s: (was: Scripting)
 Extensions

 XSS POM references wrong scm URLs
 -

 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


 The XSS API {{pom.xml}} references wrong locations of the project:
 {code:xml}
 scm
 
 connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection
 
 developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
 urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
 /scm
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-4484) XSS POM references wrong scm URLs

2015-03-09 Thread Vlad Bailescu (JIRA)

Vlad Bailescu created SLING-4484:


 Summary: XSS POM references wrong scm URLs
 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


The XSS API {{pom.xml}} references wrong locations of the project:

{code:xml}
scm

connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection

developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
/scm
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-4485) JcrSystemUserValidator uses a non synchronized set


 [ 
https://issues.apache.org/jira/browse/SLING-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-4485:
---

Assignee: Carsten Ziegeler

 JcrSystemUserValidator uses a non synchronized set
 --

 Key: SLING-4485
 URL: https://issues.apache.org/jira/browse/SLING-4485
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 The set used in JcrSystemUserValidator is a simply HashSet which might be 
 modified/read concurrently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-4485) JcrSystemUserValidator uses a non synchronized set


 [ 
https://issues.apache.org/jira/browse/SLING-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-4485.
-
Resolution: Fixed

Changed the HashSet to a CopyOnWriteArraySet - which should be fine as we don't 
expect that many different users, but probably way more reads

 JcrSystemUserValidator uses a non synchronized set
 --

 Key: SLING-4485
 URL: https://issues.apache.org/jira/browse/SLING-4485
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 The set used in JcrSystemUserValidator is a simply HashSet which might be 
 modified/read concurrently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-4484) XSS POM references wrong scm URLs


 [ 
https://issues.apache.org/jira/browse/SLING-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-4484:
---

Assignee: Radu Cotescu

 XSS POM references wrong scm URLs
 -

 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


 The XSS API {{pom.xml}} references wrong locations of the project:
 {code:xml}
 scm
 
 connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection
 
 developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
 urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
 /scm
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4461) Remove fallbacks for service users resolution


[ 
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352987#comment-14352987
 ] 

Felix Meschberger commented on SLING-4461:
--

As commented in SLING-4312 the first fallback approach can be solved by the 
slightly more complicated setup as proposed by Carsten. 

The global default can be implemented by registering a special kind of 
ServiceUserMapping marker service which is passed through by the 
ServiceUserMappingBundleFilter and thus matches references.

Finally: How about a new Felix DS annotation extending @Reference to simplify 
setting the reference target ? Such that service could just do

* @ServiceMapping(subService=theName) == 
|((!(subServiceName=*))(subServiceName=foo))
* @ServiceMapping() == !(subServiceName=*)


 Remove fallbacks for service users resolution
 -

 Key: SLING-4461
 URL: https://issues.apache.org/jira/browse/SLING-4461
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
 Fix For: Service User Mapper 1.1.2


 ServiceUserMapperImpl has several levels of fallback for service user 
 resolution (fallback to bundle default, or to global default). While this 
 offers a lot of flexibility, it introduces non-determinism in a security 
 feature. If defaults are set, it can happen (especially at startup) that code 
 is executed using different serviceUsers, e.g. a component can execute using 
 the bundle default or global default until its specific subService is 
 available, and it can be easily imagined how this can cause subtle errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-4461) Remove fallbacks for service users resolution


[ 
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352987#comment-14352987
 ] 

Felix Meschberger edited comment on SLING-4461 at 3/9/15 1:54 PM:
--

As commented in SLING-4312 the first fallback approach can be solved by the 
slightly more complicated setup as proposed by Carsten. 

The global default can be implemented by registering a special kind of 
ServiceUserMapping marker service which is passed through by the 
ServiceUserMappingBundleFilter and thus matches references.

Finally: How about a new Felix DS annotation extending @Reference to simplify 
setting the reference target ? Such that service could just do

* @ServiceMapping(subService=theName) == 
|((!(subServiceName=*))(subServiceName=theName))
* @ServiceMapping() == !(subServiceName=*)



was (Author: fmeschbe):
As commented in SLING-4312 the first fallback approach can be solved by the 
slightly more complicated setup as proposed by Carsten. 

The global default can be implemented by registering a special kind of 
ServiceUserMapping marker service which is passed through by the 
ServiceUserMappingBundleFilter and thus matches references.

Finally: How about a new Felix DS annotation extending @Reference to simplify 
setting the reference target ? Such that service could just do

* @ServiceMapping(subService=theName) == 
|((!(subServiceName=*))(subServiceName=foo))
* @ServiceMapping() == !(subServiceName=*)


 Remove fallbacks for service users resolution
 -

 Key: SLING-4461
 URL: https://issues.apache.org/jira/browse/SLING-4461
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
 Fix For: Service User Mapper 1.1.2


 ServiceUserMapperImpl has several levels of fallback for service user 
 resolution (fallback to bundle default, or to global default). While this 
 offers a lot of flexibility, it introduces non-determinism in a security 
 feature. If defaults are set, it can happen (especially at startup) that code 
 is executed using different serviceUsers, e.g. a component can execute using 
 the bundle default or global default until its specific subService is 
 available, and it can be easily imagined how this can cause subtle errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-4485) JcrSystemUserValidator uses a non synchronized set

Carsten Ziegeler created SLING-4485:
---

 Summary: JcrSystemUserValidator uses a non synchronized set
 Key: SLING-4485
 URL: https://issues.apache.org/jira/browse/SLING-4485
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler


The set used in JcrSystemUserValidator is a simply HashSet which might be 
modified/read concurrently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4125) ResourceUtil.getOrCreateResource might create SNS nodes


 [ 
https://issues.apache.org/jira/browse/SLING-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4125.
---

 ResourceUtil.getOrCreateResource might create SNS nodes
 ---

 Key: SLING-4125
 URL: https://issues.apache.org/jira/browse/SLING-4125
 Project: Sling
  Issue Type: Bug
  Components: API
Affects Versions: API 2.8.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.9.0


 There are some cases where the ResourceUtil.getOrCreateResource methods 
 create SNS nodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to stable : sling-trunk-1.7 #1530

See https://builds.apache.org/job/sling-trunk-1.7/1530/changes

Build failed in Jenkins: sling-trunk-1.6 #3139

See https://builds.apache.org/job/sling-trunk-1.6/3139/changes

Changes:

[cziegeler] Potential fix for the failing test cases in Jenkins

--
[...truncated 60612 lines...]
Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPrivilegesUpdateTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPrivilegesUpdateTest
Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
Running 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.CustomPostOperationTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.096 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.CustomPostOperationTest
Running org.apache.sling.launchpad.webapp.integrationtest.ValueFromTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.ValueFromTest
Running org.apache.sling.launchpad.webapp.integrationtest.GeneratedNodeNameTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.208 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.GeneratedNodeNameTest
Running 
org.apache.sling.launchpad.webapp.integrationtest.NodeTypeBasedRenderingTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.768 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.NodeTypeBasedRenderingTest
Running org.apache.sling.launchpad.webapp.integrationtest.ResourceDecoratorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.ResourceDecoratorTest
Running org.apache.sling.launchpad.webapp.integrationtest.JspIncludeTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.874 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.JspIncludeTest
Running org.apache.sling.launchpad.webapp.integrationtest.IncludeTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.837 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.IncludeTest
Running org.apache.sling.launchpad.webapp.integrationtest.UploadFileTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.UploadFileTest
Running org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.136 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
Running org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest
Running 
org.apache.sling.launchpad.webapp.integrationtest.ServletResolverConfigTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.ServletResolverConfigTest
Running org.apache.sling.launchpad.webapp.integrationtest.StaticContentTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.StaticContentTest
Running org.apache.sling.launchpad.webapp.integrationtest.NamespaceMappingTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.NamespaceMappingTest
Running org.apache.sling.launchpad.webapp.integrationtest.JavascriptWrappersTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.JavascriptWrappersTest
Running org.apache.sling.launchpad.webapp.integrationtest.ForwardTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.904 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.ForwardTest
Running org.apache.sling.launchpad.webapp.integrationtest.WebdavOptionsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.WebdavOptionsTest
Running org.apache.sling.launchpad.webapp.integrationtest.BundleContentTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.BundleContentTest
Running 
org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in 
org.apache.sling.launchpad.webapp.integrationtest.LaunchpadConfigInstallerTest
Running org.apache.sling.launchpad.webapp.integrationtest.xml.XPathTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time

Re: [VOTE] Release Apache Sling Event 3.5.4

+1

Robert

On Mon, Mar 9, 2015 at 10:54 AM, Carsten Ziegeler cziege...@apache.org wrote:
 +1
 --
 Carsten Ziegeler
 Adobe Research Switzerland
 cziege...@apache.org

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352876#comment-14352876
 ] 

Felix Meschberger commented on SLING-4312:
--

Ok, thanks. This starts to look ok. I think we can agree on this new service to 
be a marker. And a marker only.

As such I still (sorry) have a few comments of feedback:

* I think we should properly document the fact that the new service is a 
marker. Maybe even name it something like ServiceUserMapped ?
* Suggest to change the Mapping.SERVICENAME value to have a leading dot, that 
is {{.serviceName}} instead if {{serviceName}}. This marks the property private.
* I think we can remove the {{ServiceUserMapping.getSubServiceName()}} method 
since it adds no value. If a dependent service needs the subservice name due 
to, for example, multiple cardinality dependency, the service property of the 
ServiceReference can be queried.
* Suggest to defaine  ServiceUserMapper.SERVICE_NAME constant with the service 
name to prevent these tons of {{ServiceUserMapper.class.getName()}} calls.
* Suggest to implement an internal helper method to retrieve the service name 
for a bundle. This common method would be called from at least three locations 
(two in ServiceUserMappingBundleFilter and one in ServiceUserMapperImpl)

 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-4484) XSS POM references wrong scm URLs


 [ 
https://issues.apache.org/jira/browse/SLING-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-4484.
-
Resolution: Fixed

Fixed in 
[r1665226|https://svn.apache.org/viewvc?view=revisionrevision=1665226].

 XSS POM references wrong scm URLs
 -

 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


 The XSS API {{pom.xml}} references wrong locations of the project:
 {code:xml}
 scm
 
 connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection
 
 developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
 urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
 /scm
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352981#comment-14352981
 ] 

Felix Meschberger commented on SLING-4312:
--

bq. ServiceUserMapping.getSubServiceName() is useful if a component takes the 
subServiceName as a parameter via an osgi config

I don't fully understand why the getSubServiceName() may be usefull in this 
context ? If the Subservice Name is available as a property from the service 
reference, which is required to support the target filter, you can get that 
exact value from the respective ServiceReference, which in turn is always the 
first step in getting a service.

bq. Can you also share your thoughts on the relation with SLING-4461?

I think, as proposed in SLING-4461, the filter to support this situation could 
be used as such, yet I agree this is complicated. In addition, if we have a 
default mapping, we could register that with a default service name, which can 
be passed through by the ServiceUserMappingBundleFilter and thus made visible.

Or maybe the default mapping setup was just a bad idea ?

 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4461) Remove fallbacks for service users resolution


[ 
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353004#comment-14353004
 ] 

Carsten Ziegeler commented on SLING-4461:
-

The problem I see with this is, while you specify (subServiceName=theName), 
this reference might never be satisfied. However the service user lookup passes 
due to the fallbacks. 

Therefore I think we should treat either remove the fallbacks or treat 
subServiceName=theName) as  
|((!(subServiceName=*))(subServiceName=theName)) - which is not possible with 
the hooks (you can only shrink the selection). 
Regardless of the references, this has also the problem mentioned by Marius - 
that you get a service user when no mapping is defined and are not updated if 
such a specific mapping is defined later on.

 Remove fallbacks for service users resolution
 -

 Key: SLING-4461
 URL: https://issues.apache.org/jira/browse/SLING-4461
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
 Fix For: Service User Mapper 1.1.2


 ServiceUserMapperImpl has several levels of fallback for service user 
 resolution (fallback to bundle default, or to global default). While this 
 offers a lot of flexibility, it introduces non-determinism in a security 
 feature. If defaults are set, it can happen (especially at startup) that code 
 is executed using different serviceUsers, e.g. a component can execute using 
 the bundle default or global default until its specific subService is 
 available, and it can be easily imagined how this can cause subtle errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths

2015-03-09 Thread Vlad Bailescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vlad Bailescu updated SLING-4483:
-
  Component/s: Scripting
Affects Version/s: Scripting Sightly Engine 1.0.0
Fix Version/s: Scripting Sightly Engine 1.0.0

 Sightly: data-sly-resource does not properly resolve relative paths
 ---

 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Vlad Bailescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0


 The following resource inclusion is not working:
 {code:html}
 div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
 {code}
 The returned error is: 
 {{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
  Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling Settings 1.3.6

+1

Robert

On Mon, Mar 9, 2015 at 10:54 AM, Carsten Ziegeler cziege...@apache.org wrote:
 +1

 --
 Carsten Ziegeler
 Adobe Research Switzerland
 cziege...@apache.org

[jira] [Commented] (SLING-4484) XSS POM references wrong scm URLs


[ 
https://issues.apache.org/jira/browse/SLING-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352870#comment-14352870
 ] 

ASF GitHub Bot commented on SLING-4484:
---

GitHub user vladbailescu opened a pull request:

https://github.com/apache/sling/pull/67

SLING-4484 - XSS POM references wrong scm URLs

Updated URLs to point to correct location.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladbailescu/sling 
SLING-4484-XSS-POM-references-wrong-scm-URLs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 3af7540b410f8aa26abe6ad0a10142e90059bd0b
Author: vladbailescu baile...@adobe.com
Date:   2015-03-09T12:11:18Z

SLING-4484 - XSS POM references wrong scm URLs

Updated URLs to point to correct location.




 XSS POM references wrong scm URLs
 -

 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


 The XSS API {{pom.xml}} references wrong locations of the project:
 {code:xml}
 scm
 
 connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection
 
 developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
 urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
 /scm
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] sling pull request: SLING-4484 - XSS POM references wrong scm URLs

GitHub user vladbailescu opened a pull request:

https://github.com/apache/sling/pull/67

SLING-4484 - XSS POM references wrong scm URLs

Updated URLs to point to correct location.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladbailescu/sling 
SLING-4484-XSS-POM-references-wrong-scm-URLs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 3af7540b410f8aa26abe6ad0a10142e90059bd0b
Author: vladbailescu baile...@adobe.com
Date:   2015-03-09T12:11:18Z

SLING-4484 - XSS POM references wrong scm URLs

Updated URLs to point to correct location.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (SLING-4485) JcrSystemUserValidator uses a non synchronized set


 [ 
https://issues.apache.org/jira/browse/SLING-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-4485:

Fix Version/s: JCR Resource 2.5.2

 JcrSystemUserValidator uses a non synchronized set
 --

 Key: SLING-4485
 URL: https://issues.apache.org/jira/browse/SLING-4485
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 The set used in JcrSystemUserValidator is a simply HashSet which might be 
 modified/read concurrently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-3887) API: Un-deprecate ResourceUtil.getValueMap method


 [ 
https://issues.apache.org/jira/browse/SLING-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-3887.
---
Assignee: Carsten Ziegeler

 API: Un-deprecate ResourceUtil.getValueMap method
 -

 Key: SLING-3887
 URL: https://issues.apache.org/jira/browse/SLING-3887
 Project: Sling
  Issue Type: Improvement
  Components: API
Affects Versions: API 2.8.0
Reporter: Stefan Seifert
Assignee: Carsten Ziegeler
Priority: Trivial
 Fix For: API 2.9.0

 Attachments: 140827_SLING-3887_getValueMap.patch


 the method {{ResourceUtil.getValueMap(Resource)}} is deprecated since rev. 
 1577527 (in context of SLING-3453/SLING-3451) referring to 
 {{Resource.getValueMap()}}.
 but these two methods are not fully equivalent from a convenience 
 perspective: {{ResourceUtil.getValueMap}} supports returning an empty map if 
 the resource is null, while for the {{Resource.getValueMap()}} an explicit 
 null check and returning an empty map has to be implemented by the caller, 
 which is too much boilerplate code.
 the simplest solution would be to just undeprecate it. patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4220) SlingException constructor must not call initCause


 [ 
https://issues.apache.org/jira/browse/SLING-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4220.
---

 SlingException constructor must not call initCause
 --

 Key: SLING-4220
 URL: https://issues.apache.org/jira/browse/SLING-4220
 Project: Sling
  Issue Type: Bug
  Components: API
Affects Versions: API 2.8.0
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: API 2.9.0


 The SlingException constructors taking Throwable arguments both call 
 {{Throwable.initCause(Throwable)}} after calling the actual super-constructor.
 This dates back to Rev. 609649 (Jan. 7th, 2008!) where I added this to make 
 sure the Throwable class is initialized with the given cause. At that time 
 SlingException extended from ServletException which does not do proper Java 
 1.4 exception chaining but implements its own chaining.
 Later with SLING-186 (Rev. 614480, Jan. 23rd, 2008) SlingException was 
 modified to extend from RuntimeException which would do proper chaining. But 
 the call to {{Throwable.initCause(Throwable)}} was not removed back then. So 
 this method is still called when a SlingException is instantiated with a 
 Throwable.
 The problem comes from the implementation of the Throwable though, which 
 throws {{IllegalStateException}} if {{initCause(Throwable)}} is called after 
 the cause has already been set.
 Throwable sets the cause field to {{this}} to indicate the cause has not been 
 set yet. But {{getCause()}} returns {{null}} both for no cause having been 
 set or the cause being {{null}}.
 If the SlingException is instantiated with a {{null}} cause, this sets the 
 {{Throwable.cause}} field to {{nul}} thus returning {{null}} on 
 {{getCause()}} thus causing the SlingException to call {{initCause}}. This in 
 turn causes {{initCause(Throwable)}} to throw {{IllegalStateException}} 
 because the cause has already been set.
 Long story short: SlingException must not call {{initCause}} because that is 
 not needed anymore since SLING-186/Rev. 614480



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user

2015-03-09 Thread Marius Petria (JIRA)

[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352935#comment-14352935
]

Marius Petria commented on SLING-4312:
--

Hi [~fmeschbe]

I think your points are fine, one I would like to comment though.
ServiceUserMapping.getSubServiceName() is useful if a component takes the
subServiceName as a parameter via an osgi config. You would need to provide the
subServiceName to bind the ServiceUserMapping
(mapping.target=(subServiceName=dedicatedUserService)) and again as a dedicated
OSGI config property (componentSubServiceName=dedicatedUserService). That
redundancy can be avoided by being able to query the mapping for the mapped
subServiceName.

Can you also share your thoughts on the relation with SLING-4461? One issue
with the current implementation of this marker interface is that it cannot
accurately represent the fact that a call to ServiceUserMapper.getServiceUserID
will succeed if and only if a mapping is registered. That happens because of
fallback mappings. More exactly consumer components that bind to a specific
subServiceName will not be started even if a default has been configured. That
breaks the separation of concerns, meaning that an administrator is forced to
configure the service users in a particular way (not using the fallbacks).
SLING-4461 proposes to drop the fallbacks but that will introduce a breaking
change. WDYT?

Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
Fix For: Service User Mapper 1.1.2

Attachments: SLING-4312.1.diff, SLING-4312.diff

In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] sling pull request: SLING-4484 - XSS POM references wrong scm URLs

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/67


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SLING-4484) XSS POM references wrong scm URLs


[ 
https://issues.apache.org/jira/browse/SLING-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352960#comment-14352960
 ] 

ASF GitHub Bot commented on SLING-4484:
---

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/67


 XSS POM references wrong scm URLs
 -

 Key: SLING-4484
 URL: https://issues.apache.org/jira/browse/SLING-4484
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: XSS Protection API 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Trivial
 Fix For: XSS Protection API 1.0.0


 The XSS API {{pom.xml}} references wrong locations of the project:
 {code:xml}
 scm
 
 connectionscm:svn:http://svn.apache.org/repos/asf/sling/trunk/bundles/xss/connection
 
 developerConnectionscm:svn:https://svn.apache.org/repos/asf/sling/trunk/bundles/xss/developerConnection
 urlhttp://svn.apache.org/viewvc/sling/trunk/bundles/xss/url
 /scm
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : sling-trunk-1.6 #3140

See https://builds.apache.org/job/sling-trunk-1.6/3140/changes

[jira] [Commented] (SLING-4461) Remove fallbacks for service users resolution


[ 
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353012#comment-14353012
 ] 

Felix Meschberger commented on SLING-4461:
--

Yes, but what is the problem really ? How many uses do we have ? Who does it ? 
Would the @ServiceMapping annotation help mitigate the situation.

Are we sure to not overexagerate the problem ?

 Remove fallbacks for service users resolution
 -

 Key: SLING-4461
 URL: https://issues.apache.org/jira/browse/SLING-4461
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
 Fix For: Service User Mapper 1.1.2


 ServiceUserMapperImpl has several levels of fallback for service user 
 resolution (fallback to bundle default, or to global default). While this 
 offers a lot of flexibility, it introduces non-determinism in a security 
 feature. If defaults are set, it can happen (especially at startup) that code 
 is executed using different serviceUsers, e.g. a component can execute using 
 the bundle default or global default until its specific subService is 
 available, and it can be easily imagined how this can cause subtle errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths


 [ 
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-4483:
---

Assignee: Radu Cotescu

 Sightly: data-sly-resource does not properly resolve relative paths
 ---

 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0


 The following resource inclusion is not working:
 {code:html}
 div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
 {code}
 The returned error is: 
 {{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
  Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [Vote] Release Apache Sling Provisioning Model 1.1.0

Anyone?

Thanks
Carsten

Am 06.03.15 um 17:04 schrieb Carsten Ziegeler:
 Hi,
 
 We solved 2 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12328894
 
 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1200/
 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
 Usage:
 sh check_staged_release.sh 1200 /tmp/sling-staging
 
 Please vote to approve this release:
 
 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...
 
 This majority vote is open for at least 72 hours.
 
 Regards
 Carsten
 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Slingstart Maven Plugin 1.0.4

Anyone else?

Thanks
Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[GitHub] sling pull request: SLING-4483 - Sightly: data-sly-resource does n...

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build became unstable: sling-trunk-1.8 #820

See https://builds.apache.org/job/sling-trunk-1.8/820/changes

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353010#comment-14353010
 ] 

Carsten Ziegeler commented on SLING-4312:
-

You have the ServiceReference with the properties for this, no need to parse 
the target. I'm also wondering what use case this will have?

 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353011#comment-14353011
 ] 

Carsten Ziegeler commented on SLING-4312:
-

bq. Or maybe the default mapping setup was just a bad idea ?

While it looked pretty good when we added this, today I tend to think that we 
shouldn't have done it in the first place

 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] sling pull request: SLING-4483 - Sightly: data-sly-resource does n...

GitHub user vladbailescu opened a pull request:

https://github.com/apache/sling/pull/66

SLING-4483 - Sightly: data-sly-resource does not properly resolve relative 
paths

Prepended current resource path to relative paths to make sure 
normalization doesn't break the paths. The same approach is used by 
sling:include ../

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladbailescu/sling 
SLING-4483-sightly-resource-relative-paths

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 9728f8ae36001c174fa9ae74a9a6ac17e0979df9
Author: vladbailescu baile...@adobe.com
Date:   2015-03-09T11:39:34Z

SLING-4483 - Sightly: data-sly-resource does not properly resolve relative 
paths

Prepended current resource path to relative paths to make sure 
normalization doesn't break the paths. The same approach is used by 
sling:include ../




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths


 [ 
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-4483.
-
Resolution: Fixed

Fixed in 
[r1665219|https://svn.apache.org/viewvc?view=revisionrevision=1665219]:

* applied patch provided by Vlad Băilescu for ResourceRuntimeExtension 
(https://github.com/apache/sling/pull/66)
* added test to check the behaviour of resource inclusion

 Sightly: data-sly-resource does not properly resolve relative paths
 ---

 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0


 The following resource inclusion is not working:
 {code:html}
 div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
 {code}
 The returned error is: 
 {{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
  Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4312) Register an osgi service for each available service user

2015-03-09 Thread Marius Petria (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353006#comment-14353006
 ] 

Marius Petria commented on SLING-4312:
--

bq. you can get that exact value from the respective ServiceReference, which in 
turn is always the first step in getting a service.

That is right but then you will have to parse the target filter which might be 
hard (imagine an OR filter). The guarantee offered by the ServiceUserMapping is 
that if it is bound to something then calling 
getServiceUserID(bundle,mapping.getSubServiceName()) will succeed. But we can 
drop this method if you think the argument is not strong enough.




 Register an osgi service for each available service user 
 -

 Key: SLING-4312
 URL: https://issues.apache.org/jira/browse/SLING-4312
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Marius Petria
Assignee: Marius Petria
 Fix For: Service User Mapper 1.1.2

 Attachments: SLING-4312.1.diff, SLING-4312.diff


 In order to only activate osgi components when a service user mapping is 
 available it would be useful to have an osgi service registered for a service 
 user. A component can reference the registered service name and only start 
 when that becomes available.
 {code}
 @Reference(target=(name=serviceName))
 ServiceUserExists userExists;
 {code}
  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling Launchpad Base 4.6.1-2.5.8

+1

Robert

On Mon, Mar 9, 2015 at 10:54 AM, Carsten Ziegeler cziege...@apache.org wrote:
 +1


 --
 Carsten Ziegeler
 Adobe Research Switzerland
 cziege...@apache.org

[jira] [Closed] (SLING-4377) Add JSR305 nullness annotations to Sling API


 [ 
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4377.
---

 Add JSR305 nullness annotations to Sling API
 

 Key: SLING-4377
 URL: https://issues.apache.org/jira/browse/SLING-4377
 Project: Sling
  Issue Type: Improvement
  Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: API 2.9.0


 Since consumers of the Sling API always have to keep in mind whether a 
 null-check is necessary it would be good to add JSR 305 annotations to the 
 API.
 See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
 At least Eclipse as well as Findbugs are supporting those and Oak Solr is 
 using those already (https://issues.apache.org/jira/browse/OAK-2303).
 Only the following 2 annotations should be used:
 # {{@Nonnull}}, for return values which are not supposed to be {{null}} or 
 parameters which must not be {{null}}.
 # {{@CheckForNull}}, for return values wich may be null {{null}}.
 Those are the only ones being supported by both Eclipse and Findbugs (compare 
 with http://sourceforge.net/p/findbugs/bugs/1355/)
 {{@Nullable}} is basically ignored by Findbugs 
 (http://findbugs.sourceforge.net/manual/annotations.html) and should 
 therefore not be used. The package annotation for the default handling should 
 also not be used (because either {{@Nullable}} or {{@CheckForNull}} is 
 ignored by Eclipse then.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-848) Support getting versioned resources by using uri path parameters


 [ 
https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-848.
--

 Support getting versioned resources by using uri path parameters
 

 Key: SLING-848
 URL: https://issues.apache.org/jira/browse/SLING-848
 Project: Sling
  Issue Type: New Feature
  Components: API, JCR, ResourceResolver
Affects Versions: JCR Resource 2.0.2
Reporter: Carsten Ziegeler
Assignee: Tomek Rękawek
 Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0

 Attachments: SLING-848-metadata.patch


 Getting versioned content should be support thorough uri path parameters, 
 like /something/hello;v=1.1
 For jcr based resources the value of the version should either point to a 
 version name or label.
 In order to not change our existing apis, we introduce a new utility method 
 which removes all uri path parameters
 and returns a map of these. Every resource provider could use this utility 
 method and then decide to act on these
 parameters.
 If a requested version does not exists, a 404 is returned.
 If the requested node does not directly point to a versionable node, the 
 algorithm checks the parent hierarchy until a versionable node is found, and 
 tries to get the version of this node and then goes down the path again. If 
 the versionable node does not have the requested version or the child, a 404 
 is returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-3854) Add configuration option to restrict service user mapper to system users


 [ 
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-3854.
---

 Add configuration option to restrict service user mapper to system users
 

 Key: SLING-3854
 URL: https://issues.apache.org/jira/browse/SLING-3854
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
 Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0

 Attachments: SLING-3854-patch2.txt, SLING-3854.patch


 JCR-3802 introduces the concept of system users that distinct from regular 
 user accounts and never have a password set. the API extensions include to 
 following ability to discover if a given User is actually a system user: 
 {{User.isSystemUser}}.
 It would be good if the service user mapping had a configuration option that 
 would restrict the mapping to dedicated service users i.e. to users which are 
 defined to be system users in case sling is running on a JCR repository that 
 implements jackrabbit API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths


[ 
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352947#comment-14352947
 ] 

ASF GitHub Bot commented on SLING-4483:
---

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/66


 Sightly: data-sly-resource does not properly resolve relative paths
 ---

 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0


 The following resource inclusion is not working:
 {code:html}
 div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
 {code}
 The returned error is: 
 {{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
  Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to stable : sling-trunk-1.8 #821

See https://builds.apache.org/job/sling-trunk-1.8/821/changes

[VOTE] Release Apache Sling XSS Protection Bundle version 1.0.0

2015-03-09 Thread Radu Cotescu

Hi,

We solved 7 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329024/

There are still some outstanding issues:
http://s.apache.org/sling_xss_1.0.2

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1206

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1206 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Thanks,
Radu

[jira] [Commented] (SLING-4461) Remove fallbacks for service users resolution

[
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353032#comment-14353032
]

Carsten Ziegeler commented on SLING-4461:
-

The problem is a missmatch between the reference and the call to the API:

ServiceUserMapper#getServiceUserID(bundle, foo) might return something while
there is no service registered for a mapping with subServiceName=foo

That sounds wrong.

This *can* be solved by specifying the longer target filter as shown above. I'm
fine with doing so

However, there is still the global fallback - which if configured always
returns something from ServiceUserMapper#getServiceUserID(bundle, foo) even
if there is no mapping for that bundle! However rethinking this, this would
probably match the !(subServiceName=*) part.

So we could keep the fallbacks in place.

However, we have a problem with dynamics: imagine a running system with a
mapping defined for a bundle, then you want to specify a more fine grained
mapping for the (bundle, sub service name) tuple. Creating the configs is easy,
however the new configuration is not picked up. But that's a different issue.

I'm not in favour of yet adding another proprietary annotation as I hope that
we can move to the official DS annotations soon.

Remove fallbacks for service users resolution
-

Key: SLING-4461
URL: https://issues.apache.org/jira/browse/SLING-4461
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Fix For: Service User Mapper 1.1.2

ServiceUserMapperImpl has several levels of fallback for service user
resolution (fallback to bundle default, or to global default). While this
offers a lot of flexibility, it introduces non-determinism in a security
feature. If defaults are set, it can happen (especially at startup) that code
is executed using different serviceUsers, e.g. a component can execute using
the bundle default or global default until its specific subService is
available, and it can be easily imagined how this can cause subtle errors.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to stable : sling-trunk-1.7 #1533

See https://builds.apache.org/job/sling-trunk-1.7/1533/changes

Jenkins build became unstable: sling-trunk-1.8 #822

See https://builds.apache.org/job/sling-trunk-1.8/822/changes

[jira] [Updated] (SLING-4223) Make Content Loader extensible to support new import formats

2015-03-09 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/SLING-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-4223:
-
Attachment: SLING-4223.patch

Please find the new version of the patch attached. It's less extensive in terms 
of changed classes and architecture.

{quote}
create an abstract base component for {{DefaultContentImporter}} and 
{{ContentLoaderService}} instead of doing an indirection with whiteboard 
pattern (service holder)
{quote}
I integrated the whiteboard into {{BaseImportLoader}}. Because the 
{{BaseImportLoader}} is sometimes extended by an OSGi service 
({{DefaultContentImporter}}) and sometimes by a POJO ({{BundleContentLoader}}) 
there are two ways of setting the whiteboard service.

{quote}
decouple {{ContentLoaderService}} and ({{BundleContent}}){{Loader}} and make 
({{BundleContent}}){{Loader}} a (prototype) service like 
{{DefaultContentImporter}}
{quote}

It'll be hard to decouple it, as there is two-way dependency between 
{{BundleContentLoader}} and the {{ContentLoaderService}}. I think this task 
should be extracted to a separate JIRA, as it isn't that much related to the 
extensible content readers.

{quote}
drop {{ImportProvider}}
{quote}
Done. I also renamed all variables and edited comments.

It's quite difficult to keep such a big patch up-to-date with incoming changes, 
so may we can integrate it and work on the trunk (or create a branch)? It 
passes all integration tests.

 Make Content Loader extensible to support new import formats
 

 Key: SLING-4223
 URL: https://issues.apache.org/jira/browse/SLING-4223
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR ContentLoader 2.1.10
Reporter: Oliver Lietz
Assignee: Tomek Rękawek
 Fix For: JCR ContentLoader 2.2.0

 Attachments: SLING-4223.patch


 The current Content Loader supports a basic set of import formats which are 
 identified by extension: {{.xml}}, {{.jcr.xml}}, {{.json}}, {{.jar}} and 
 {{.zip}}.
 There is a [user 
 request|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3cd0a6198c.20fbeb%25bruce.e...@nextissuemedia.com%3e]
  to support custom formats like Adobe Folio and [some ideas how to 
 implement|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3ca2ab572f-fa83-4ae2-806e-49cce87b9...@adobe.com%3e]:
 * we create a new org.apache.sling.contentloader.reader package to be 
 exported at version 1.0
 * move the ContentCreator (@ProviderType) and ContentReader (@ConsumerType) 
 to that new package
 * convert the BaseImportLoader into a standalone ContentReader service holder 
 used by the DefaultContentImporter and ContentLoaderService components.
 * For the ContentReader service interface we define service registration 
 properties for the service to expose the file name extension (and maybe 
 content type) the reader supports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4461) Remove fallbacks for service users resolution

2015-03-09 Thread Marius Petria (JIRA)

[
https://issues.apache.org/jira/browse/SLING-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353031#comment-14353031
]

Marius Petria commented on SLING-4461:
--

The way I see it there are two problems:
1. Overlapping concerns: an administrator cannot set a default for a bundle
and expect everything to work because some bundles might not start.

This can be fixed using the extended DS annotation as you suggested.

2. If one sets up fallbacks and subServices for a bundle then it can happen
that the same code executes with different privileges.

I can imagine the scenario of a cleanup service that deletes all files that is
sees, older than 10 days in a folder. It does the execution with a
cleanupSubService. However if a bundle fallback is configured and it can see
more files than the cleanupSubService then it will delete more files during the
startup period when the cleanupSubService is not yet loaded and the fallback is
used. This might be not the perfect example but it shows the kind of issues
that can come up.

Remove fallbacks for service users resolution
-

Key: SLING-4461
URL: https://issues.apache.org/jira/browse/SLING-4461
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Fix For: Service User Mapper 1.1.2

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4223) Make Content Loader extensible to support new import formats

2015-03-09 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/SLING-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-4223:
-
Attachment: (was: SLING-4223.patch)

 Make Content Loader extensible to support new import formats
 

 Key: SLING-4223
 URL: https://issues.apache.org/jira/browse/SLING-4223
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR ContentLoader 2.1.10
Reporter: Oliver Lietz
Assignee: Tomek Rękawek
 Fix For: JCR ContentLoader 2.2.0

 Attachments: SLING-4223.patch


 The current Content Loader supports a basic set of import formats which are 
 identified by extension: {{.xml}}, {{.jcr.xml}}, {{.json}}, {{.jar}} and 
 {{.zip}}.
 There is a [user 
 request|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3cd0a6198c.20fbeb%25bruce.e...@nextissuemedia.com%3e]
  to support custom formats like Adobe Folio and [some ideas how to 
 implement|http://mail-archives.apache.org/mod_mbox/sling-users/201412.mbox/%3ca2ab572f-fa83-4ae2-806e-49cce87b9...@adobe.com%3e]:
 * we create a new org.apache.sling.contentloader.reader package to be 
 exported at version 1.0
 * move the ContentCreator (@ProviderType) and ContentReader (@ConsumerType) 
 to that new package
 * convert the BaseImportLoader into a standalone ContentReader service holder 
 used by the DefaultContentImporter and ContentLoaderService components.
 * For the ContentReader service interface we define service registration 
 properties for the service to expose the file name extension (and maybe 
 content type) the reader supports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build became unstable: sling-trunk-1.7 #1532

See https://builds.apache.org/job/sling-trunk-1.7/1532/changes

[jira] [Updated] (SLING-4293) [XSS] Reduce footprint and dependencies


 [ 
https://issues.apache.org/jira/browse/SLING-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4293:

Fix Version/s: (was: XSS Protection API 1.0.0)
   XSS Protection API 1.0.2

 [XSS] Reduce footprint and dependencies
 ---

 Key: SLING-4293
 URL: https://issues.apache.org/jira/browse/SLING-4293
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Felix Meschberger
 Fix For: XSS Protection API 1.0.2

 Attachments: SLING-4293.patch


 The XSS bundle currently embeds all of the Antisamy, ESAPI, and Encoder 
 libraries as well as substantial parts of Batik, NekoHTML, and Xerces. This 
 is done by means of Private-Package and Embed-Dependency statements.
 Leveraging the BND Conditional-Package statement, both the size of the XSS 
 bundle and the dependencies of it can be drastically reduced. The 
 Conditional-Package statement basically causes just to include those packages 
 that are actually needed to be embedded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4365) Streamline ESAPI configuration


 [ 
https://issues.apache.org/jira/browse/SLING-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4365:

Fix Version/s: (was: XSS Protection API 1.0.0)
   XSS Protection API 1.0.2

 Streamline ESAPI configuration
 --

 Key: SLING-4365
 URL: https://issues.apache.org/jira/browse/SLING-4365
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Felix Meschberger
 Fix For: XSS Protection API 1.0.2


 Currently the ESAPI is configured using the DefaultSecurityConfiguration 
 class. This configuration is configured such as to:
   * read configuration from various file system locations, e.g. the user's 
 home folder
   * list the helper classes to be used
   * configure the checking
   * configure logging
 In our context and setup, we don't want to have different classes configured, 
 we want logging to always go through SLF4J logging and we want to limit and 
 control where the configuration is read from.
 This issues is about creating a custom SecurityConfiguration class :
   * read from defined locations, probably one in the repository and one 
 embedded in the bundle as a fallback. For example using the same 
 configuration file as embedded default as for Sling Initial Content 
 installation in the repository.
   * always log to SLF4J, maybe requiring an SLF4J based ESAPI LogFactory 
 implementation. As a fallback, Log4J or commons logging APIs could still be 
 used through the existing *-to-SLF4J API bridges we use.
   * Only support configuration of validation patterns (hence all classes 
 statically defined)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4273) Check list of required imports


 [ 
https://issues.apache.org/jira/browse/SLING-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4273:

Fix Version/s: (was: XSS Protection API 1.0.0)
   XSS Protection API 1.0.2

 Check list of required imports
 --

 Key: SLING-4273
 URL: https://issues.apache.org/jira/browse/SLING-4273
 Project: Sling
  Issue Type: Task
  Components: Extensions
Reporter: Carsten Ziegeler
 Fix For: XSS Protection API 1.0.2


 This is the current list of required imports for the xss module:
 javax.annotation,
 javax.crypto,
 javax.crypto.spec,
 javax.mail.internet,
 javax.naming,j
 avax.servlet,
 javax.servlet.http,
 javax.servlet.jsp,
 javax.servlet.jsp.tagext,
 javax.sql,
 javax.swing,
 javax.swing.border,
 javax.swing.event,
 javax.swing.filechooser,
 javax.swing.table,
 javax.swing.text,
 javax.swing.tree,
 javax.xml.datatype,
 javax.xml.namespace,
 javax.xml.parsers,
 javax.xml.transform,
 javax.xml.transform.dom,
 javax.xml.transform.sax,
 javax.xml.transform.stream,
 javax.xml.validation,
 org.apache.commons.codec.binary,
 org.apache.commons.collections,
 org.apache.commons.collections.comparators,
 org.apache.commons.collections.iterators,
 org.apache.commons.collections.keyvalue,
 org.apache.commons.collections.list,
 org.apache.commons.collections.map,
 org.apache.commons.collections.set,
 org.apache.commons.fileupload,
 org.apache.commons.fileupload.disk,
 org.apache.commons.fileupload.servlet,
 org.apache.commons.fileupload.util,
 org.apache.commons.httpclient,
 org.apache.commons.httpclient.methods,
 org.apache.commons.httpclient.params,
 org.apache.commons.lang,
 org.apache.commons.lang.exception,
 org.apache.commons.lang.text,
 org.apache.commons.logging,
 org.apache.log4j,
 org.apache.sling.api;version=[2.1,3),
 org.apache.sling.api.adapter;version=[2.2,3),
 org.apache.sling.api.resource;version=[2.1,3),
 org.apache.sling.commons.json;version=[2.0,3),
 org.apache.sling.commons.json.io;version=[2.0,3),
 org.apache.sling.xss;version=[1.0,1.1),
 org.osgi.service.event;version=[1.1,2),
 org.slf4j;version=[1.5,2),
 org.w3c.dom,
 org.w3c.dom.css,
 org.w3c.dom.events,
 org.w3c.dom.html,
 org.w3c.dom.ls,
 org.w3c.dom.ranges,
 org.w3c.dom.traversal,
 org.w3c.dom.views,
 org.xml.sax,
 org.xml.sax.ext,
 org.xml.sax.helpers
 Some of them shouldn't really be required like javax.mail.internet or the jsp 
 api; for others like the apache commons stuff it would be nice to have 
 versioned imports



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling XSS Protection Bundle version 1.0.0

Hi,

On Mon, Mar 9, 2015 at 6:30 PM, Radu Cotescu r...@apache.org wrote:
 Hi,

 We solved 7 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12329024/

 There are still some outstanding issues:
 http://s.apache.org/sling_xss_1.0.2

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1206

 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1206 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.

 Thanks,
 Radu

The -Prat build fails for me

$ svn co https://svn.apache.org/repos/asf/sling/tags/org.apache.sling.xss-1.0.0/
$ cd org.apache.sling.xss-1.0.0/
$ mvn verify -Prat
(snip...)
[ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.10:check (default) on project
org.apache.sling.xss: Too many files with unapproved license: 3 See
RAT report in: 
/home/ADOBENET/rmuntean/w/workspace/org.apache.sling.xss-1.0.0/target/rat.txt
- [Help 1]

I think this should be fixed for the initial release, even if the
failures are trivial.

Thanks,

Robert

Re: [VOTE] Release Apache Sling XSS Protection Bundle version 1.0.0

2015-03-09 Thread Radu Cotescu

Hi Robert,

Thanks for the heads up. I did include a rat file for the module since
donating the code; I guess I just have to configure the plug-in to take it
into consideration.

Cheers,
Radu

On Mon, Mar 9, 2015 at 6:34 PM, Robert Munteanu romb...@apache.org wrote:

 Hi,

 On Mon, Mar 9, 2015 at 6:30 PM, Radu Cotescu r...@apache.org wrote:
  Hi,
 
  We solved 7 issues in this release:
  https://issues.apache.org/jira/browse/SLING/fixforversion/12329024/
 
  There are still some outstanding issues:
  http://s.apache.org/sling_xss_1.0.2
 
  Staging repository:
  https://repository.apache.org/content/repositories/orgapachesling-1206
 
  You can use this UNIX script to download the release and verify the
  signatures:
  http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
  Usage:
  sh check_staged_release.sh 1206 /tmp/sling-staging
 
  Please vote to approve this release:
 
[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...
 
  This majority vote is open for at least 72 hours.
 
  Thanks,
  Radu

 The -Prat build fails for me

 $ svn co
 https://svn.apache.org/repos/asf/sling/tags/org.apache.sling.xss-1.0.0/
 $ cd org.apache.sling.xss-1.0.0/
 $ mvn verify -Prat
 (snip...)
 [ERROR] Failed to execute goal
 org.apache.rat:apache-rat-plugin:0.10:check (default) on project
 org.apache.sling.xss: Too many files with unapproved license: 3 See
 RAT report in:
 /home/ADOBENET/rmuntean/w/workspace/org.apache.sling.xss-1.0.0/target/rat.txt
 - [Help 1]

 I think this should be fixed for the initial release, even if the
 failures are trivial.

 Thanks,

 Robert

Jenkins build is still unstable: sling-trunk-1.8 #823

See https://builds.apache.org/job/sling-trunk-1.8/changes

Re: [VOTE] Release Apache Sling XSS Protection Bundle version 1.0.0

Hi Radu,

On Mon, Mar 9, 2015 at 7:59 PM, Radu Cotescu r...@apache.org wrote:
 Hi Robert,

 Thanks for the heads up. I did include a rat file for the module since
 donating the code; I guess I just have to configure the plug-in to take it
 into consideration.

The rat parameters are configured in the parent pom for all projects.
However, I don't think you need to exclude anything more. The files
which cause the rat check to fail are:

 !? src/main/resources/ESAPI.properties
 !? src/main/resources/validation.properties
 !? rat.exclude

rat.exclude is not needed, and the two properties files should get a
Apache-2.0 license, see [1] for an example

Robert

[1]: 
https://svn.apache.org/repos/asf/sling/trunk/tooling/maven/archetypes/launchpad-standalone/src/main/resources/archetype-resources/src/test/config/sling.properties



 Cheers,
 Radu

 On Mon, Mar 9, 2015 at 6:34 PM, Robert Munteanu romb...@apache.org wrote:

 Hi,

 On Mon, Mar 9, 2015 at 6:30 PM, Radu Cotescu r...@apache.org wrote:
  Hi,
 
  We solved 7 issues in this release:
  https://issues.apache.org/jira/browse/SLING/fixforversion/12329024/
 
  There are still some outstanding issues:
  http://s.apache.org/sling_xss_1.0.2
 
  Staging repository:
  https://repository.apache.org/content/repositories/orgapachesling-1206
 
  You can use this UNIX script to download the release and verify the
  signatures:
  http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
  Usage:
  sh check_staged_release.sh 1206 /tmp/sling-staging
 
  Please vote to approve this release:
 
[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...
 
  This majority vote is open for at least 72 hours.
 
  Thanks,
  Radu

 The -Prat build fails for me

 $ svn co
 https://svn.apache.org/repos/asf/sling/tags/org.apache.sling.xss-1.0.0/
 $ cd org.apache.sling.xss-1.0.0/
 $ mvn verify -Prat
 (snip...)
 [ERROR] Failed to execute goal
 org.apache.rat:apache-rat-plugin:0.10:check (default) on project
 org.apache.sling.xss: Too many files with unapproved license: 3 See
 RAT report in:
 /home/ADOBENET/rmuntean/w/workspace/org.apache.sling.xss-1.0.0/target/rat.txt
 - [Help 1]

 I think this should be fixed for the initial release, even if the
 failures are trivial.

 Thanks,

 Robert




-- 
Sent from my (old) computer

Re: [VOTE] Release Apache Sling Query version 3.0.0

2015-03-09 Thread Tomek Rękawek

Hello all,

we could use 2 more binding votes...

Regards,
Tomek

On Wed, Mar 4, 2015 at 2:47 PM, Tomek Rękawek tomasz.reka...@cognifide.com
wrote:

 Hi,

 We solved 3 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12327846

 There are no outstanding issues:
 https://issues.apache.org/jira/browse/SLING/component/12323406

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1199/

 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1199 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.

 Regards,
 Tomek

 --
 Tomek Rękawek
 Senior Software Engineer

 Cognifide Polska Sp. z o.o.
 skype: trekawek

 www.cognifide.com




-- 
Tomek Rękawek
Senior Software Engineer

Cognifide Polska Sp. z o.o.
skype: trekawek

www.cognifide.com

Build failed in Jenkins: sling-trunk-1.6 #3137

See https://builds.apache.org/job/sling-trunk-1.6/3137/changes

Changes:

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.settings-1.3.6

[cziegeler] SLING-4482 : Settings plugin might not show current values for 
sling properties

[cziegeler] Correct version

[cziegeler] Use latest base

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.launchpad.base-4.6.1-2.5.8

[cziegeler] SLING-4471 : Update to framework 4.6.1

--
[...truncated 40122 lines...]
[INFO] Apache Sling JSON Library . SUCCESS [7.696s]
[INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [36.125s]
[INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [6.287s]
[INFO] Apache Sling MIME type mapping support  SUCCESS [8.025s]
[INFO] Apache Sling Commons OSGi support . SUCCESS [6.634s]
[INFO] Apache Sling Scheduler Support  SUCCESS [11.481s]
[INFO] Apache Sling Testing Utilities  SUCCESS [15.583s]
[INFO] Apache Sling Thread Dumper  SUCCESS [6.214s]
[INFO] Apache Sling Thread Support ... SUCCESS [6.364s]
[INFO] Apache Sling Authentication Service ... SUCCESS [7.534s]
[INFO] Apache Sling Form Based Authentication Handler  SUCCESS [17.680s]
[INFO] Apache Sling Engine Implementation  SUCCESS [17.145s]
[INFO] Apache Sling Repository API Bundle  SUCCESS [7.458s]
[INFO] Apache Sling JCR Base Bundle .. SUCCESS [8.268s]
[INFO] Apache Sling JCR ClassLoader .. SUCCESS [5.719s]
[INFO] Apache Sling Initial Content Loader ... SUCCESS [7.305s]
[INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [19.610s]
[INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [6.289s]
[INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support  SUCCESS 
[10.001s]
[INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [5.073s]
[INFO] Apache Sling JCR Resource Resolver  SUCCESS [39.713s]
[INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver  
SUCCESS [19.603s]
[INFO] Apache Sling Versioning Integration Tests . SUCCESS [13.350s]
[INFO] Apache Sling JCR Repository Registration .. SUCCESS [7.762s]
[INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [6.850s]
[INFO] Apache Sling DavEx Access to repositories . SUCCESS [7.419s]
[INFO] Apache Sling JCR WebConsole Bundle  SUCCESS [12.377s]
[INFO] Apache Sling Oak Repository Server  SUCCESS [12.684s]
[INFO] Apache Sling SlingRepository Integration Tests  SUCCESS [58.623s]
[INFO] Apache Sling Servlet Resolver . SUCCESS [14.484s]
[INFO] Apache Sling Default GET Servlets . SUCCESS [8.715s]
[INFO] Apache Sling Default POST Servlets  SUCCESS [9.070s]
[INFO] Apache Sling Compat Servlets .. SUCCESS [6.601s]
[INFO] Apache Sling Scripting Implementation API . SUCCESS [6.252s]
[INFO] Apache Sling Scripting Core implementation  SUCCESS [15.663s]
[INFO] Apache Sling Scripting JavaScript Support . SUCCESS [14.632s]
[INFO] Apache Sling Scripting JSP Support  SUCCESS [16.859s]
[INFO] Apache Sling JSP Tag Library .. SUCCESS [8.953s]
[INFO] Apache Sling JSP Standard Tag Library . SUCCESS [6.896s]
[INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [6.492s]
[INFO] Apache Sling Bundle Resource Provider . SUCCESS [7.492s]
[INFO] Apache Sling Distributed Event Admin .. SUCCESS [8.226s]
[INFO] Apache Sling Discovery API  SUCCESS [5.562s]
[INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [4:40.092s]
[INFO] Apache Sling Discovery Support Bundle . SUCCESS [6.577s]
[INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [5.055s]
[INFO] Apache Sling Event Support  SUCCESS [12:34.707s]
[INFO] Apache Sling Feature Flags  SUCCESS [7.698s]
[INFO] Apache Sling Filesystem Resource Provider . SUCCESS [6.985s]
[INFO] Apache Sling javax.activation bundle .. SUCCESS [7.767s]
[INFO] Apache Sling Service User Mapper .. SUCCESS [6.151s]
[INFO] Apache Sling Settings . FAILURE [3.708s]
[INFO] Apache Sling Web Console Branding . SKIPPED
[INFO] Apache Sling Web Console Security Provider  SKIPPED
[INFO] Apache Sling Explorer . SKIPPED
[INFO] Apache Sling Health Check Core  SKIPPED
[INFO] Apache Sling Health Check Annotations . SKIPPED
[INFO] Apache Sling Health Check Samples

[VOTE] Release Apache Sling Settings 1.3.6

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12328791

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1203/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1203 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Event 3.5.4

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329450

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1204/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1204 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Resource Merger 1.2.8

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329445

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1205/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1205 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Created] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths

2015-03-09 Thread Vlad Bailescu (JIRA)

Vlad Bailescu created SLING-4483:


 Summary: Sightly: data-sly-resource does not properly resolve 
relative paths
 Key: SLING-4483
 URL: https://issues.apache.org/jira/browse/SLING-4483
 Project: Sling
  Issue Type: Bug
Reporter: Vlad Bailescu
Priority: Minor


The following resource inclusion is not working:

{code:html}
div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
{code}

The returned error is: 

{{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
 Script path cannot be empty}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-4482) Settings plugin might not show current values for sling properties


 [ 
https://issues.apache.org/jira/browse/SLING-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-4482.
-
Resolution: Fixed

 Settings plugin might not show current values for sling properties
 --

 Key: SLING-4482
 URL: https://issues.apache.org/jira/browse/SLING-4482
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Settings 1.3.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Settings 1.3.6


 The settings plugin for the web console reads the sling.properties file from 
 disk to display the properties. However, if these are overlayed e.g. through 
 system properties or through init parameters in the webapp, the wrong value 
 is displayed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

March Board Report

Hi,

I'll submit the following report to the board for March:

https://cwiki.apache.org/confluence/display/SLING/Status+Report+March+2015

Please correct, update, comment :)

Thanks
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-4471) Update to framework 4.6.1


 [ 
https://issues.apache.org/jira/browse/SLING-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-4471.
-
Resolution: Fixed

 Update to framework 4.6.1
 -

 Key: SLING-4471
 URL: https://issues.apache.org/jira/browse/SLING-4471
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Launchpad Base 2.5.8


 Once the framework 4.6.1 release is available, we should update in order to 
 get the fix for FELIX-4806



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-4482) Settings plugin might not show current values for sling properties

Carsten Ziegeler created SLING-4482:
---

 Summary: Settings plugin might not show current values for sling 
properties
 Key: SLING-4482
 URL: https://issues.apache.org/jira/browse/SLING-4482
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Settings 1.3.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Settings 1.3.6


The settings plugin for the web console reads the sling.properties file from 
disk to display the properties. However, if these are overlayed e.g. through 
system properties or through init parameters in the webapp, the wrong value is 
displayed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE] Release Apache Sling Launchpad Base 4.6.1-2.5.8

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329327

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1202/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1202 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Launchpad Base 4.6.1-2.5.8

+1


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Resource Merger 1.2.8

+1

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Event 3.5.4

+1
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Settings 1.3.6

+1

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Jenkins build is still unstable: sling-trunk-1.7 #1529

See https://builds.apache.org/job/sling-trunk-1.7/changes

[jira] [Commented] (SLING-1437) GSoC project: create more unit and integration tests for Sling and expand test coverage information

2015-03-09 Thread Petr Shypila (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352755#comment-14352755
 ] 

Petr Shypila commented on SLING-1437:
-

I've got a JaCoCo code coverage summary and it looks like some modules under 
/bundles are not covered with tests at all:
{noformat}
#bundles/commons
org.apache.sling.commons.logservice - Code coverage 0%
org.apache.sling.commons.scheduler - Code coverage 0%
org.apache.sling.commons.threaddump - Code coverage 0%
org.apache.sling.commons.threads - Code coverage 0%

#bundles/extensions
org.apache.sling.bundleresource.impl - Code coverage 0%
org.apache.sling.discovery.api - Code coverage 0%

#bundles/engine
org.apache.sling.engine - Code coverage 20%

#bundles/extensions
org.apache.sling.featureflags - Code coverage 0%
org.apache.sling.fsprovider.internal - Code coverage 0%
org.apache.sling.hc.webconsole.impl - Code coverage 0%
org.apache.sling.models - Code coverage 0%
org.apache.sling.extensions.webconsolesecurityprovider.internal - Code coverage 
0%

#bundles/jcr
org.apache.sling.jcr.base - Code coverage 0%
org.apache.sling.jcr.classloader.internal - Code coverage 0%
org.apache.sling.jcr.jackrabbit.accessmanager - Code coverage 0%
org.apache.sling.jcr.jackrabbit.server - Code coverage 0%
org.apache.sling.jackrabbit.usermanager - Code coverage 0%
org.apache.sling.jcr.registration - Code coverage 0%
org.apache.sling.jcr.webconsole.internal - Code coverage 0%
org.apache.sling.jcr.webdav.impl - Code coverage 0%
org.apache.sling.resourceaccesssecurity - Code coverage 0%

#bundles/scripting
org.apache.sling.scripting.jsp - Code coverage 0%

#bundles/servlets
org.apache.sling.servlets.get.impl - Code coverage 13%
org.apache.sling.servlets.post - Code coverage 16%
{noformat}
I still don't have a clarity of the scope of work to cover all these modules 
with test, but I think it's a good task improve my skills in unit and 
integration tests development. So I still want to be applied for this project 
as a part of GSoC. And my next point is to present some examples of my work.

BTW: It's also looks like all changes from SLING-1803 are already in trunk. 
Anyway I have deployed trunk branch with maven jacoco-report profile and it has 
created for me all reports I need.

Best,
Petr

 GSoC project: create more unit and integration tests for Sling and expand 
 test coverage information
 ---

 Key: SLING-1437
 URL: https://issues.apache.org/jira/browse/SLING-1437
 Project: Sling
  Issue Type: Task
  Components: Testing
Reporter: Bertrand Delacretaz
  Labels: gsoc, gsoc2010sling, gsoc2013, gsoc2015, java, mentor, 
 testing

 Sling already has fairly good test coverage, but there's always room for 
 improvement. 
 The goal of this Google Summer of Code project is to create more unit and 
 integration tests for Sling, as well as measure the test coverage that the 
 combination of unit and integration tests provide.
 Interested students are welcome to get in touch with the Sling community via 
 its developers mailing list to discuss the project, see 
 http://sling.apache.org/project-information.html#mailing-lists
 The student will have to get familiar with the Sling codebase, identify areas 
 where tests are missing, write unit and integration tests and submit the 
 results as patches that the Sling committers can verify and hopefully apply.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : sling-trunk-1.6 #3138