[jira] [Created] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

Alexander Klimetschek created SLING-5274:


 Summary: Include authentication in RequestProgressTracker
 Key: SLING-5274
 URL: https://issues.apache.org/jira/browse/SLING-5274
 Project: Sling
  Issue Type: Improvement
  Components: Engine
Reporter: Alexander Klimetschek


The request progress tracker only starts with the sling filters, after the 
sling authentication ran through. Since authentication steps can be complex 
with multiple handlers (just like filters) and can have a major performance 
impact (custom auth handlers, slow resource resolver login) it would be very 
useful to include it with detailed information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994940#comment-14994940
 ] 

Alexander Klimetschek commented on SLING-5274:
--

Maybe a separate topic, but it would be super awesome if we could also log the 
osgi httpservice level steps (in Sling's default setup, where it's embedded 
into that). This includes filters that most folks aren't even aware of, and 
also httpservice level servlets that never appear here.

It would require to generalize the tracker a bit and somehow hook it into the 
felix http service impl...

> Include authentication in RequestProgressTracker
> 
>
> Key: SLING-5274
> URL: https://issues.apache.org/jira/browse/SLING-5274
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Alexander Klimetschek
> Attachments: SLING-5274.patch
>
>
> The request progress tracker only starts with the sling filters, after the 
> sling authentication ran through. Since authentication steps can be complex 
> with multiple handlers (just like filters) and can have a major performance 
> impact (custom auth handlers, slow resource resolver login) it would be very 
> useful to include it with detailed information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5275) RequestProgressTracker should log microseconds

[Alexander Klimetschek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Klimetschek updated SLING-5275:
-
Attachment: SLING-5275.patch

Attached patch: [^SLING-5275.patch]

This switches completely. Another option might be to have this configurable. if 
requests are usually slow and say in the 10s to 100s of milliseconds, using 
microseconds is overkill.

> RequestProgressTracker should log microseconds
> --
>
> Key: SLING-5275
> URL: https://issues.apache.org/jira/browse/SLING-5275
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Alexander Klimetschek
> Attachments: SLING-5275.patch
>
>
> The RequestProgressTracker logs timings as milliseconds. If requests are very 
> fast and in the milliseconds range, more resolution is required for fine 
> tuning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek edited comment on SLING-5274 at 11/7/15 2:31 AM:
---

Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth handler: OAuth Authentication Handler
 78 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 81 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 83 LOG Calling auth handler: Token Authentication Handler
 88 LOG Calling auth handler: ImageServer Authentication Handler
 91 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
115 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
120 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
121 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
125 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
160 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
   4572 LOG Login failed: UserId/Password mismatch.
   4738 TIMER_END{4720,Authentication} failed
{noformat}

Note that the examples include microsecond logging from the patch in SLING-5275.

Notes about the changes:
- the SlingRequestProgressTracker is now created in 
SlingHttpContext#handleSecurity() to start early
- and passed around as request attribute (since at that early stage there is no 
SlingHttpServletRequest present yet)
- also getPathInfo() will be null at this early stage and actually never 
resolved if the authentication fails, hence using getRequestURI() if it's null 
(in the recent request console printer)
- tried to log all pluggable parts and their actual order (auth handlers, auth 
post processors)


was (Author: alexander.klimetschek):
Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 

[jira] [Comment Edited] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek edited comment on SLING-5274 at 11/7/15 2:32 AM:
---

Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth handler: OAuth Authentication Handler
 78 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 81 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 83 LOG Calling auth handler: Token Authentication Handler
 88 LOG Calling auth handler: ImageServer Authentication Handler
 91 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
115 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
120 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
121 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
125 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
160 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
   4572 LOG Login failed: UserId/Password mismatch.
   4738 TIMER_END{4720,Authentication} failed
{noformat}

Note that the examples include microsecond logging from the patch in SLING-5275.

Notes about the changes:
- the SlingRequestProgressTracker is now created in 
SlingHttpContext#handleSecurity() to start early enough
- and passed around as request attribute (since at that early stage there is no 
SlingHttpServletRequest present yet)
- also getPathInfo() will be null at this early stage and actually never 
resolved if the authentication fails, hence using getRequestURI() if it's null 
(in the recent request console printer)
- tried to log all pluggable parts and their actual order (auth handlers, auth 
post processors)


was (Author: alexander.klimetschek):
Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 

[jira] [Comment Edited] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek edited comment on SLING-5274 at 11/7/15 2:32 AM:
---

Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth handler: OAuth Authentication Handler
 78 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 81 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 83 LOG Calling auth handler: Token Authentication Handler
 88 LOG Calling auth handler: ImageServer Authentication Handler
 91 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
115 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
120 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
121 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
125 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
160 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
   4572 LOG Login failed: UserId/Password mismatch.
   4738 TIMER_END{4720,Authentication} failed
{noformat}

Note that the examples include microsecond logging from the patch in SLING-5275.

Notes about the changes:
- the SlingRequestProgressTracker is now created in 
SlingHttpContext#handleSecurity() to start early enough
- and passed around as request attribute (since at that early stage there is no 
SlingHttpServletRequest yet)
- also getPathInfo() will be null at this early stage and actually never 
resolved if the authentication fails, hence using getRequestURI() if it's null 
(in the recent request console printer)
- tried to log all pluggable parts and their actual order (auth handlers, auth 
post processors)


was (Author: alexander.klimetschek):
Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 

[jira] [Created] (SLING-5275) RequestProgressTracker should log microseconds

[Alexander Klimetschek (JIRA)]

Alexander Klimetschek created SLING-5275:


 Summary: RequestProgressTracker should log microseconds
 Key: SLING-5275
 URL: https://issues.apache.org/jira/browse/SLING-5275
 Project: Sling
  Issue Type: Improvement
  Components: Engine
Reporter: Alexander Klimetschek


The RequestProgressTracker logs timings as milliseconds. If requests are very 
fast and in the milliseconds range, more resolution is required for fine tuning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek edited comment on SLING-5274 at 11/7/15 2:23 AM:
---

Attached patch: [^SLING-5274.patch]

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth handler: OAuth Authentication Handler
 78 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 81 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 83 LOG Calling auth handler: Token Authentication Handler
 88 LOG Calling auth handler: ImageServer Authentication Handler
 91 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
115 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
120 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
121 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
125 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
160 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
   4572 LOG Login failed: UserId/Password mismatch.
   4738 TIMER_END{4720,Authentication} failed
{noformat}



was (Author: alexander.klimetschek):
Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth 

[jira] [Updated] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Klimetschek updated SLING-5274:
-
Attachment: SLING-5274.patch

> Include authentication in RequestProgressTracker
> 
>
> Key: SLING-5274
> URL: https://issues.apache.org/jira/browse/SLING-5274
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Alexander Klimetschek
> Attachments: SLING-5274.patch
>
>
> The request progress tracker only starts with the sling filters, after the 
> sling authentication ran through. Since authentication steps can be complex 
> with multiple handlers (just like filters) and can have a major performance 
> impact (custom auth handlers, slow resource resolver login) it would be very 
> useful to include it with detailed information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek edited comment on SLING-5274 at 11/7/15 2:20 AM:
---

Example authentication success:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

Example authentication failure (note that these were not recorded/visible so 
far!):
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, Path=/bin/ping
 15 TIMER_START{Authentication}
 31 LOG Calling auth handler: Cloud IMS Authentication Handler
 59 LOG Calling auth handler: OAuth Authentication Handler
 78 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 81 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 83 LOG Calling auth handler: Token Authentication Handler
 88 LOG Calling auth handler: ImageServer Authentication Handler
 91 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
115 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
120 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
121 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
125 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
160 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
   4572 LOG Login failed: UserId/Password mismatch.
   4738 TIMER_END{4720,Authentication} failed
{noformat}



was (Author: alexander.klimetschek):
Example:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

> Include authentication in RequestProgressTracker
> 
>
> Key: SLING-5274
> URL: https://issues.apache.org/jira/browse/SLING-5274
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Alexander Klimetschek
>
> The request progress tracker only starts with the 

[jira] [Commented] (SLING-5274) Include authentication in RequestProgressTracker

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994887#comment-14994887
 ] 

Alexander Klimetschek commented on SLING-5274:
--

Example:
{noformat}
  0 TIMER_START{Request Processing}
  1 COMMENT timer_end format is {,} 
  8 LOG Method=GET, 
Path=/is/image/content/dam/geometrixx/portraits/scott_reynolds.jpg
 12 TIMER_START{Authentication}
 24 LOG Calling auth handler: Cloud IMS Authentication Handler
 46 LOG Calling auth handler: OAuth Authentication Handler
 65 LOG Calling auth handler: Day CQ Login Selector Authentication Handler
 68 LOG Calling auth handler: Granite Client Certificate Authentication 
Handler
 71 LOG Calling auth handler: Token Authentication Handler
 77 LOG Calling auth handler: ImageServer Authentication Handler
 80 LOG Calling auth handler: 
org.apache.sling.auth.core.impl.HttpBasicAuthenticationHandler
101 LOG AuthenticationHandlers returned: type=BASIC, userId=admin
105 LOG Calling auth post processor: 
com.adobe.cq.social.commons.cors.CORSAuthInfoPostProcessor
106 LOG Calling auth post processor: 
org.apache.sling.jcr.resource.internal.WorkspaceAuthInfoPostProcessor
109 LOG Calling auth post processor: 
com.adobe.cq.creativecloud.cloudims.impl.auth.cookie.TokenAuthenticationInfoPostProcessor
144 LOG Trying to get a resource resolver for: type=BASIC, userId=admin
  12408 LOG Login success: Resource Resolver, userId=admin
  12428 TIMER_END{12415,Authentication} succeeded
  12611 TIMER_START{ResourceResolution}

  ... existing logs
{noformat}

> Include authentication in RequestProgressTracker
> 
>
> Key: SLING-5274
> URL: https://issues.apache.org/jira/browse/SLING-5274
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Alexander Klimetschek
>
> The request progress tracker only starts with the sling filters, after the 
> sling authentication ran through. Since authentication steps can be complex 
> with multiple handlers (just like filters) and can have a major performance 
> impact (custom auth handlers, slow resource resolver login) it would be very 
> useful to include it with detailed information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Build failed in Jenkins: sling-trunk-1.7 #2672

[Robert Munteanu]

On Fri, 2015-11-06 at 02:26 +, Apache Jenkins Server wrote:
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-
> plugin:0.11:check (default) on project
> org.apache.sling.installer.factory.subsystems-base: Too many files
> with unapproved license: 1 See RAT report in:  org/job/sling-trunk-
> 1.7/ws/trunk/installer/factories/subsystem_base/target/rat.txt> ->
> [Help 1]
> [ERROR]

This seems to fail at due to the test1.subsystem-base file placed in
the source tree. However, locally it is correctly detected as a binary
file ( it's a Jar ).

I'll add a rat plugin exclusion anyway.

Robert

[jira] [Comment Edited] (SLING-5134) Donation of sling pipes

[Nicolas Peltier (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993344#comment-14993344
 ] 

Nicolas Peltier edited comment on SLING-5134 at 11/6/15 8:30 AM:
-

[~clr] (cc [~olli]) sorry about that :-/ should i forward the aknowledgment to 
some list? (would be sling-dev, here)


was (Author: npeltier):
[~clr] (cc [~olli]) sorry about that :-/ should i forward the aknowledgment to 
some list?

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5134) Donation of sling pipes

[Nicolas Peltier (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993344#comment-14993344
 ] 

Nicolas Peltier commented on SLING-5134:


[~clr] (cc [~olli]) sorry about that :-/ should i forward the aknowledgment to 
some list?

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Making service user and ACL provisioning available in Sling

[Robert Munteanu]

Wrong list, please ignore :-)

[jira] [Created] (SLING-5269) Sling Pipes IP clearance

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-5269:
---

 Summary: Sling Pipes IP clearance
 Key: SLING-5269
 URL: https://issues.apache.org/jira/browse/SLING-5269
 Project: Sling
  Issue Type: Task
  Components: Extensions
Reporter: Oliver Lietz
Assignee: Bertrand Delacretaz


This issue tracks the IP clearance for the donation of Sling Pipes (SLING-5134).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[RESULT][VOTE] Donation of Sling Pipes

[Oliver Lietz]

Hi,

the vote has passed with the following result :

+1 (binding): Robert Munteanu, Carsten Ziegeler, Oliver Lietz
+1 (non-binding): Sandro Boehme

SLING-5269 will track the IP clearance of this donation.

Thanks,
O.

[jira] [Updated] (SLING-5165) Add subsystem support to the launchpad

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-5165:

Attachment: SLING-5165.diff

The attached SLING-5165.diff patch adds the required bundles to the launchpad.

It includes the latest Felix Coordinator, Subsystems API and Core and Equinox 
Digraph bundles.
It also includes installer factories for subsystem .esa files and 
subsystem-base files. For more information in subsystem-base files see 
SLING-5149 and SLING-5210

I think that it would also be good to include the Felix subsystem webconsole 
plugin, but since that has not yet been released it should be added later.

> Add subsystem support to the launchpad
> --
>
> Key: SLING-5165
> URL: https://issues.apache.org/jira/browse/SLING-5165
> Project: Sling
>  Issue Type: New Feature
>  Components: Launchpad
>Affects Versions: Launchpad Builder 8
>Reporter: David Bosschaert
> Attachments: SLING-5165.diff
>
>
> To make OSGi subsystems work at runtime, the Sling Launchpad needs to provide 
> subsystem support. This can be achieved by including the following bundles:
> Felix Coordinator
> Subsystem API and Core
> Equinox Region bundle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5165) Add subsystem support to the launchpad

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5165.

Resolution: Fixed

Patch applied in https://svn.apache.org/r1712930, thanks for the contribution!

> Add subsystem support to the launchpad
> --
>
> Key: SLING-5165
> URL: https://issues.apache.org/jira/browse/SLING-5165
> Project: Sling
>  Issue Type: New Feature
>  Components: Launchpad
>Affects Versions: Launchpad Builder 8
>Reporter: David Bosschaert
>Assignee: Robert Munteanu
> Fix For: Launchpad Builder 9
>
> Attachments: SLING-5165.diff
>
>
> To make OSGi subsystems work at runtime, the Sling Launchpad needs to provide 
> subsystem support. This can be achieved by including the following bundles:
> Felix Coordinator
> Subsystem API and Core
> Equinox Region bundle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5165) Add subsystem support to the launchpad

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5165:
---
Fix Version/s: Launchpad Builder 9

> Add subsystem support to the launchpad
> --
>
> Key: SLING-5165
> URL: https://issues.apache.org/jira/browse/SLING-5165
> Project: Sling
>  Issue Type: New Feature
>  Components: Launchpad
>Affects Versions: Launchpad Builder 8
>Reporter: David Bosschaert
>Assignee: Robert Munteanu
> Fix For: Launchpad Builder 9
>
> Attachments: SLING-5165.diff
>
>
> To make OSGi subsystems work at runtime, the Sling Launchpad needs to provide 
> subsystem support. This can be achieved by including the following bundles:
> Felix Coordinator
> Subsystem API and Core
> Equinox Region bundle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

RE: [VOTE] Release Apache Sling IDE Tooling version 1.0.10

[Stefan Seifert]

+1

stefan

[jira] [Commented] (SLING-5134) Donation of sling pipes

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993397#comment-14993397
 ] 

Robert Munteanu commented on SLING-5134:


[~npeltier] - not need for futher communication, we got the acknowledgment that 
we needed

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-5165) Add subsystem support to the launchpad

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5165:
--

Assignee: Robert Munteanu

> Add subsystem support to the launchpad
> --
>
> Key: SLING-5165
> URL: https://issues.apache.org/jira/browse/SLING-5165
> Project: Sling
>  Issue Type: New Feature
>  Components: Launchpad
>Affects Versions: Launchpad Builder 8
>Reporter: David Bosschaert
>Assignee: Robert Munteanu
> Attachments: SLING-5165.diff
>
>
> To make OSGi subsystems work at runtime, the Sling Launchpad needs to provide 
> subsystem support. This can be achieved by including the following bundles:
> Felix Coordinator
> Subsystem API and Core
> Equinox Region bundle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5269) Sling Pipes IP clearance

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993486#comment-14993486
 ] 

Bertrand Delacretaz commented on SLING-5269:


[~olli] would you want to handle this yourself? I think all PMC members can 
edit the required Incubator site files at 
https://svn.apache.org/repos/asf/incubator/public/trunk/ and it's good if more 
people know how this works.

> Sling Pipes IP clearance
> 
>
> Key: SLING-5269
> URL: https://issues.apache.org/jira/browse/SLING-5269
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Bertrand Delacretaz
>
> This issue tracks the IP clearance for the donation of Sling Pipes 
> (SLING-5134).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5269) Sling Pipes IP clearance

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993499#comment-14993499
 ] 

Oliver Lietz commented on SLING-5269:
-

[~bdelacretaz] if it's possible, yes. I was under the impression that IP 
clearance/incubation can only be handled by members and officers.

> Sling Pipes IP clearance
> 
>
> Key: SLING-5269
> URL: https://issues.apache.org/jira/browse/SLING-5269
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Bertrand Delacretaz
>
> This issue tracks the IP clearance for the donation of Sling Pipes 
> (SLING-5134).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-5269) Sling Pipes IP clearance

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reassigned SLING-5269:
---

Assignee: Oliver Lietz  (was: Bertrand Delacretaz)

> Sling Pipes IP clearance
> 
>
> Key: SLING-5269
> URL: https://issues.apache.org/jira/browse/SLING-5269
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> This issue tracks the IP clearance for the donation of Sling Pipes 
> (SLING-5134).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5269) Sling Pipes IP clearance

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993507#comment-14993507
 ] 

Bertrand Delacretaz commented on SLING-5269:


Ah yes you're right, "members and officers". So much for me trying to get some 
free time ;-)

So the next step is for [~npeltier] to provide a software grant as per 
https://www.apache.org/licenses/software-grant.txt 

Best is to include the sha1 or other digest of the code attached to SLING-5134 
in the grant, so it's clearly linked to that code.

As per http://people.apache.org/committer-index.html Nicolas already has an 
iCLA on file.

> Sling Pipes IP clearance
> 
>
> Key: SLING-5269
> URL: https://issues.apache.org/jira/browse/SLING-5269
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> This issue tracks the IP clearance for the donation of Sling Pipes 
> (SLING-5134).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5270) comons.json: JSON Validator does not fail on too many closing brackets

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-5270:
--
Attachment: SLING-5270-ValidatorTest.java.patch

> comons.json: JSON Validator does not fail on too many closing brackets
> --
>
> Key: SLING-5270
> URL: https://issues.apache.org/jira/browse/SLING-5270
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons JSON 2.0.12
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Commons JSON 2.0.14
>
> Attachments: SLING-5270-ValidatorTest.java.patch
>
>
> the JSON validator (which is also used by the maven-sling-plugin) does not 
> fail when the JSON contains too many closing brackets, esp.:
> * too many "}" at the end of file
> * too many "]" at the end of file
> * too many "}" within the file
> attached is a patch file with unit tests, three of them do not fail although 
> the json is invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5270) comons.json: JSON Validator does not fail on too many closing brackets

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-5270:
-

 Summary: comons.json: JSON Validator does not fail on too many 
closing brackets
 Key: SLING-5270
 URL: https://issues.apache.org/jira/browse/SLING-5270
 Project: Sling
  Issue Type: Bug
  Components: Commons
Affects Versions: Commons JSON 2.0.12
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
 Fix For: Commons JSON 2.0.14


the JSON validator (which is also used by the maven-sling-plugin) does not fail 
when the JSON contains too many closing brackets, esp.:
* too many "}" at the end of file
* too many "]" at the end of file
* too many "}" within the file

attached is a patch file with unit tests, three of them do not fail although 
the json is invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5272) maven-sling-plugin: Potential resource leak in JAR file handling

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-5272:
-

 Summary: maven-sling-plugin: Potential resource leak in JAR file 
handling
 Key: SLING-5272
 URL: https://issues.apache.org/jira/browse/SLING-5272
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: Maven Sling Plugin 2.1.2
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Trivial
 Fix For: Maven Sling Plugin 2.1.4


eclipse complains about a resource leak in the 
AbstractBundleDeployMojo.changeVersion method - a "JarFile" instance is not 
closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling IDE Tooling version 1.0.10

[Daniel Klco]

+1

On Fri, Nov 6, 2015 at 4:08 AM, Stefan Seifert 
wrote:

> +1
>
> stefan
>
>

Re: [VOTE] Release Apache Sling Testing OSGi Mock 1.7.0

[Daniel Klco]

+1

On Thu, Nov 5, 2015 at 4:08 AM, Stefan Egli  wrote:

> +1
>
> Cheers,
> Stefan
>
> On 04/11/15 22:43, "Stefan Seifert"  wrote:
>
> >Hi,
> >
> >We solved 2 issues in this release:
> >https://issues.apache.org/jira/browse/SLING/fixforversion/12333758
> >
> >Staging repository:
> >https://repository.apache.org/content/repositories/orgapachesling-1363/
> >
> >You can use this UNIX script to download the release and verify the
> >signatures:
> >http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> >
> >Usage:
> >sh check_staged_release.sh 1363 /tmp/sling-staging
> >
> >Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> >This majority vote is open for at least 72 hours.
> >
> >
> >stefan
> >
>
>
>

[jira] [Created] (SLING-5273) Content-Disposition attachment filter: improve the description of the properties

[Jean-Christophe Kautzmann (JIRA)]

Jean-Christophe Kautzmann created SLING-5273:


 Summary: Content-Disposition attachment filter: improve the 
description of the properties
 Key: SLING-5273
 URL: https://issues.apache.org/jira/browse/SLING-5273
 Project: Sling
  Issue Type: Improvement
Reporter: Jean-Christophe Kautzmann
Assignee: Antonio Sanso


I find the descriptions of the OSGI properties of the Content-Disposition 
attachment filter [0] a bit unclear.

Here are some suggestions (and questions):

1. “Content Disposition Paths"
I would suggest the description:
{{Paths for which the Content Disposition is applied}}

It seems that adding a content type makes the filter to not apply the Content 
Disposition, which contradicts the former sentence. Could you please clarify?

2. “Content Disposition Excluded Paths"
I would suggest the description:
{{Paths for which the Content Disposition is not applied}}

3. "Enable Content Disposition for all paths” flag.
I would suggest the description:
{{Check to apply the Content Disposition for all paths, except for the excluded 
paths defined by sling.content.disposition.excluded.paths}}

[0] 
https://github.com/apache/sling/blob/trunk/contrib/extensions/security/src/main/java/org/apache/sling/security/impl/ContentDispositionFilter.java




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: what happend to maven-sling-plugin 2.1.2?

[Bertrand Delacretaz]

Hi,

On Fri, Nov 6, 2015 at 12:25 PM, Stefan Seifert  wrote:
> in the svn logs a release of maven-sling-plugin 2.1.2 was done on oct 12th, 
> 2015 [1]...

The vote thread is here AFAICS:

http://mail-archives.apache.org/mod_mbox/sling-dev/201510.mbox/%3c1444661956.3108.26.ca...@apache.org%3E

I didn't find the VOTE RESULT message but that vote did get 3 PMC members +1s.

And http://sling.apache.org/downloads.cgi does list it, and

svn log 
https://dist.apache.org/repos/dist/release/sling/maven-sling-plugin-2.1.2-source-release.zip

r10824 | rombert | 2015-10-15 17:00:51 +0200 (Thu, 15 Oct 2015) | 1 line

So maybe it's just missing on Maven Central?

-Bertrand

[jira] [Resolved] (SLING-5272) maven-sling-plugin: Potential resource leak in JAR file handling

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-5272.
---
Resolution: Fixed

Completed: At revision: 1712958  


> maven-sling-plugin: Potential resource leak in JAR file handling
> 
>
> Key: SLING-5272
> URL: https://issues.apache.org/jira/browse/SLING-5272
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Trivial
> Fix For: Maven Sling Plugin 2.1.4
>
>
> eclipse complains about a resource leak in the 
> AbstractBundleDeployMojo.changeVersion method - a "JarFile" instance is not 
> closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4117) 'mountByFS=true' doesn't work a second time

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-4117.
-

> 'mountByFS=true' doesn't work a second time
> ---
>
> Key: SLING-4117
> URL: https://issues.apache.org/jira/browse/SLING-4117
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.0
>Reporter: Sandro Boehme
>Assignee: Stefan Seifert
> Fix For: Maven Sling Plugin 2.1.2
>
> Attachments: SLING-4117-patch.txt
>
>
> When calling 2.1.1-SNAPSHOT of the maven-sling-plugin with 'mountByFS=true' a 
> second time the following exception is thrown and the build fails:
> {code}
> org.apache.sling.commons.json.JSONException: JSONObject["provider.file"] not 
> found.
>   at org.apache.sling.commons.json.JSONObject.get(JSONObject.java:372)
>   at 
> org.apache.sling.commons.json.JSONObject.getJSONObject(JSONObject.java:466)
>   at 
> org.apache.sling.maven.bundlesupport.AbstractBundleInstallMojo.getCurrentFileProviderConfigs(AbstractBundleInstallMojo.java:544)
>   at 
> org.apache.sling.maven.bundlesupport.AbstractBundleInstallMojo.configure(AbstractBundleInstallMojo.java:367)
>   at 
> org.apache.sling.maven.bundlesupport.AbstractBundleInstallMojo.execute(AbstractBundleInstallMojo.java:222)
>   at 
> org.apache.sling.maven.bundlesupport.BundleInstallMojo.execute(BundleInstallMojo.java:58)
>   
> [ERROR] Failed to execute goal 
> org.apache.sling:maven-sling-plugin:2.1.1-SNAPSHOT:install (install-bundle) 
> on project resource-editor: Reading configuration from 
> http://localhost:8080/system/console/configMgr/(service.factoryPid=org.apache.sling.fsprovider.internal.FsResourceProvider).json
>  failed, cause: JSONObject["provider.file"] not found.
> {code}
> As the error message suggest in 
> org.apache.sling.maven.bundlesupport.AbstractBundleInstallMojo.getCurrentFileProviderConfigs()
>  line 544 the call to the 'provider.file' key of the JSON structure fails 
> because it is not directly accessible but nested in a 'properties' element. 
> The patch first reads the 'properties' element and only then the 
> 'provider.file' and the 'provider.roots' elements to fix the error.
> As the method name says this code is for loading the current file provider 
> configs. This is why it is not called when the maven-sling-plugin is called 
> with the 'mountByFS=true' parameter the first time when there is no config / 
> JSON result yet.
> Looking at the history of the AbstractBundleInstallMojo and 
> org.apache.felix.webconsole.internal.configuration.MetaTypeServiceSupport 
> (generates the "properties" part of the JSON at the server side) the nesting 
> in the "properties" element seem to have always been that way. Thats why I'm 
> wondering why this seem to have never worked. Either people didn't care 
> enough to get the mount call working a second time or I do something wrong 
> and miss some basic information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-2607) Maven sling:install goal provides wrong jar file status when the file is missing

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-2607.
-

> Maven sling:install goal provides wrong jar file status when the file is 
> missing
> 
>
> Key: SLING-2607
> URL: https://issues.apache.org/jira/browse/SLING-2607
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.0
>Reporter: Alexandre COLLIGNON
>Assignee: Justin Edelson
>Priority: Minor
>  Labels: patch
> Fix For: Maven Sling Plugin 2.1.2
>
> Attachments: 
> 0001-Fix-SLING-2607-confusing-log-when-jar-file-doesn-t-e.patch
>
>
> When running {{mvn sling:install}} on a clean project (no target folder or 
> without a jar package), the sling plugin warns {{[bundleName].jar is not an 
> OSGi Bundle, not uploading}}.
> This statement is actually wrong and quite confusing. It would be better to 
> inform that the file doesn't exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5271) maven-sling-plugin: Update commons.json dependency for latest JSON Validator improvements

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-5271:
-

 Summary: maven-sling-plugin: Update commons.json dependency for 
latest JSON Validator improvements
 Key: SLING-5271
 URL: https://issues.apache.org/jira/browse/SLING-5271
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Affects Versions: Maven Sling Plugin 2.1.2
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
 Fix For: Maven Sling Plugin 2.1.4


we should update to Commons JSON 2.0.14 to get the latest json validation 
improvments from SLING-5270.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

what happend to maven-sling-plugin 2.1.2?

[Stefan Seifert]

in the svn logs a release of maven-sling-plugin 2.1.2 was done on oct 12th, 
2015 [1].

what happened to this release?
it's not on maven central [2], i did not found a vote for it on the mailing 
list, i did not found an unpublished staging repo on the apache nexus either.

should i start a re-release including voting processs?

stefan

[1] http://svn.apache.org/viewvc?view=revision=1708136
[2] http://repo1.maven.org/maven2/org/apache/sling/maven-sling-plugin/

Re: what happend to maven-sling-plugin 2.1.2?

[Robert Munteanu]

On Fri, Nov 6, 2015 at 12:38 PM, Bertrand Delacretaz
 wrote:
> I didn't find the VOTE RESULT message but that vote did get 3 PMC members +1s.

The result is at [1] , I guess it's easy to overlook since I used the
project named as defined in the pom.xml file.

> So maybe it's just missing on Maven Central?

I found a 'Promotion Completed' message from Nexus [2] so that would
point to something going wrong after that.

Filed INFRA-10729  [3] asking for help finding out the root cause.

Thanks,

Robert



[1]: http://markmail.org/message/t7bk5rrnzywmnwjw
[2]: http://markmail.org/message/t3rbtsxtzu73hjkt
[3]: https://issues.apache.org/jira/browse/INFRA-10729

[jira] [Resolved] (SLING-5271) maven-sling-plugin: Update commons.json dependency for latest JSON Validator improvements

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-5271.
---
Resolution: Fixed

Completed: At revision: 1712954  

Updated to 2.0.13-SNAPSHOT until 2.0.14 is released.

> maven-sling-plugin: Update commons.json dependency for latest JSON Validator 
> improvements
> -
>
> Key: SLING-5271
> URL: https://issues.apache.org/jira/browse/SLING-5271
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Maven Sling Plugin 2.1.4
>
>
> we should update to Commons JSON 2.0.14 to get the latest json validation 
> improvments from SLING-5270.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-5212) Webconsole of FSClassloader does not display Sightly components

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco reassigned SLING-5212:
---

Assignee: Dan Klco

> Webconsole of FSClassloader does not display Sightly components
> ---
>
> Key: SLING-5212
> URL: https://issues.apache.org/jira/browse/SLING-5212
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.2
>Reporter: Jörg Hoh
>Assignee: Dan Klco
> Attachments: Apache Sling Scripting Sightly Engine Configuration.png
>
>
> When I add sightly components to my application, they are not displayed in 
> the Webconsole of the Filesystem Classloader.
> When I do a 'find' in the directory of the fsclassloader bundle, JSPs show up 
> like this:
> {noformat}
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.class
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.deps
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.java
> {noformat}
> but Sightly components like this:
> {noformat}
> data/classes/apps/geometrixx/components/page/SightlyJava_initsightly.class
> {noformat}
> Especially there is no .java or .deps file.
> The Webconsole should be able to display Sightly scripts and offer operations 
> like "download .class file" or "download .java file" (if available).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5212) Webconsole of FSClassloader does not display Sightly components

[Dan Klco (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994058#comment-14994058
 ] 

Dan Klco commented on SLING-5212:
-

[~radu.cotescu] I've checked with Sightly Engine 1.0.2 and it looks like even 
with Development mode enabled it doesn't seem to be generating .java or .dep 
files.  Is this fixed in 1.0.6?

It looks like the issue regarding the Sightly components not appearing is that 
the console is exclusively looking under the relative path org/apache/jsp which 
is where all of the JSP files are stored.  I'll look into refactoring it a bit 
so it just looks under the root and strips out the org/apache/jsp from the 
script path for the JSPs.

> Webconsole of FSClassloader does not display Sightly components
> ---
>
> Key: SLING-5212
> URL: https://issues.apache.org/jira/browse/SLING-5212
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.2
>Reporter: Jörg Hoh
>Assignee: Dan Klco
> Attachments: Apache Sling Scripting Sightly Engine Configuration.png
>
>
> When I add sightly components to my application, they are not displayed in 
> the Webconsole of the Filesystem Classloader.
> When I do a 'find' in the directory of the fsclassloader bundle, JSPs show up 
> like this:
> {noformat}
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.class
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.deps
> data/classes/org/apache/jsp/apps/geometrixx/components/page/init_jsp.java
> {noformat}
> but Sightly components like this:
> {noformat}
> data/classes/apps/geometrixx/components/page/SightlyJava_initsightly.class
> {noformat}
> Especially there is no .java or .deps file.
> The Webconsole should be able to display Sightly scripts and offer operations 
> like "download .class file" or "download .java file" (if available).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4565) Override equals/hashcode for JSON entities

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-4565:
--
Fix Version/s: (was: Commons JSON 2.0.14)

comparing full json object/array content (including all children) can be quite 
expensive. does this really makes sense?
do other json implementations provide this in the normal equals method? 

the (perhaps a bit outdated) reference implementation
https://github.com/douglascrockford/JSON-java
does not either.

> Override equals/hashcode for JSON entities
> --
>
> Key: SLING-4565
> URL: https://issues.apache.org/jira/browse/SLING-4565
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons JSON 2.0.10
>Reporter: Timothee Maret
>
> JSON entities in the package 
> {code}
> org.apache.sling.commons.json
> {code}
> do not yet override the equals and hashCode methods, leaving the equals to 
> compare references rather than the actual content of the entity.
> This issue is about implementing equals/hashCode on those entities in order 
> to allow meaningful comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5152) JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of def.isMultiple()

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-5152:
--
Fix Version/s: Commons JSON 2.0.14

> JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of 
> def.isMultiple()
> ---
>
> Key: SLING-5152
> URL: https://issues.apache.org/jira/browse/SLING-5152
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons JSON 2.0.12
>Reporter: Joel Richard
>Assignee: Robert Munteanu
>Priority: Minor
>  Labels: json, performance
> Fix For: Commons JSON 2.0.14
>
>
> In Oak, node.getDefinition().isMultiple() is is around 35 times slower than 
> prop.isMultiple(). In addition to this, MockProperty.isMultiple has to be 
> implemented because otherwise the tests fail (for which I will open another 
> issue shortly).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Build failed in Jenkins: sling-trunk-1.7 #2672

[Andreas Schaefer Sr.]

Hi Robert

I ran into an issue with RAT because I use GIT and when I used the Sling 
Tooling branch the IntelliJ project files (*.iml) did trip it off because 
regular Sling folders like (bundles, launchpad etc) remain in the file system 
even if the branch does not use them.

Adding an exclusion of **/*.iml did fix the issue.

- Andy

> On Nov 6, 2015, at 12:09 AM, Robert Munteanu  wrote:
> 
> On Fri, 2015-11-06 at 02:26 +, Apache Jenkins Server wrote:
>> [ERROR] Failed to execute goal org.apache.rat:apache-rat-
>> plugin:0.11:check (default) on project
>> org.apache.sling.installer.factory.subsystems-base: Too many files
>> with unapproved license: 1 See RAT report in: > org/job/sling-trunk-
>> 1.7/ws/trunk/installer/factories/subsystem_base/target/rat.txt> ->
>> [Help 1]
>> [ERROR]
> 
> This seems to fail at due to the test1.subsystem-base file placed in
> the source tree. However, locally it is correctly detected as a binary
> file ( it's a Jar ).
> 
> I'll add a rat plugin exclusion anyway.
> 
> Robert

[jira] [Updated] (SLING-4681) HttpTestBase: default content type for readiness test should be selectable

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-4681:
--
Fix Version/s: Commons Testing 2.0.20

> HttpTestBase: default content type for readiness test should be selectable
> --
>
> Key: SLING-4681
> URL: https://issues.apache.org/jira/browse/SLING-4681
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Commons Testing 2.0.18
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Commons Testing 2.0.20
>
>
> HttpTestBase uses hardcoded .txt / text/plain values to for its GET requests 
> used to check readiness. This should be settable to make the readiness 
> algorithm more reusable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-4979) commons.testing.util.RepositoryUtil should allow to instantiate a SlingRepository where loginService is supported

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-4979:
--
Fix Version/s: (was: Commons Testing 2.0.20)
   Commons Testing 2.0.22

> commons.testing.util.RepositoryUtil should allow to instantiate a 
> SlingRepository where loginService is supported
> -
>
> Key: SLING-4979
> URL: https://issues.apache.org/jira/browse/SLING-4979
> Project: Sling
>  Issue Type: Wish
>  Components: Commons
>Affects Versions: Commons Testing 2.0.18
>Reporter: Tommaso Teofili
> Fix For: Commons Testing 2.0.22
>
>
> When using _org.apache.sling.commons.testing_ (2.0.18) and trying to call 
> loginService on the returned {{SlingRepository}} results in an exception as 
> the API has not been updated to support such kind of calls, while it'd be 
> nice to be able also to test a class (e.g. a service) using _loginService_ to 
> authenticate.
> However I understand that it might be complicated to inject which services 
> can do what, or at least it may be not too useful as the candidate test 
> classes wanting to use such a repository would use services according to how 
> mappings have been defined... Maybe we could offer 1 or 2 services that are 
> enabled (admin / anonymous like).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-3180) Failed deployment should fail the build by default

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-3180.
-

> Failed deployment should fail the build by default
> --
>
> Key: SLING-3180
> URL: https://issues.apache.org/jira/browse/SLING-3180
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Maven Sling Plugin 2.1.2
>
>
> Even though we have added a failOnError attribute to the maven-sling-plugin 
> in SLING-2075, it defaults to false, for backwards compatibility reasons.
> However, this still leaves a lot of first-time setups silently broken by 
> default, and I see no real reason for which to leave this parameter by 
> default to false by default. As a matter of fact, I'd favour removing it 
> altogether and failing all the time, but that's a larger discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-3540) maven-sling-plugin with usePut = true does not create intermediary folders

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-3540.
-

> maven-sling-plugin with usePut = true does not create intermediary folders
> --
>
> Key: SLING-3540
> URL: https://issues.apache.org/jira/browse/SLING-3540
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.1.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Maven Sling Plugin 2.1.2
>
>
> {code}[INFO] Installing Bundle 
> com.example.jcrbundle(/home/rmuntean/tmp/jcrbundle/target/jcrbundle-1.0-SNAPSHOT.jar)
>  to http://localhost:8080/libs/sling/install via PUT
> [ERROR] Installation failed, cause: Conflict{code}
> The reason is that the default Sling launchpad does not have a 
> /libs/sling/install directory structure out of the box. The workaround is to 
> create it, e.g. with curl
> {code}
> curl -u admin:admin -X MKCOL http://localhost:8080/libs
> curl -u admin:admin -X MKCOL http://localhost:8080/libs/sling
> curl -u admin:admin -X MKCOL http://localhost:8080/libs/sling/install
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5270) comons.json: JSON Validator does not fail on too many closing brackets

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-5270.
---
Resolution: Fixed

Completed: At revision: 1712953  


> comons.json: JSON Validator does not fail on too many closing brackets
> --
>
> Key: SLING-5270
> URL: https://issues.apache.org/jira/browse/SLING-5270
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons JSON 2.0.12
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Commons JSON 2.0.14
>
> Attachments: SLING-5270-ValidatorTest.java.patch
>
>
> the JSON validator (which is also used by the maven-sling-plugin) does not 
> fail when the JSON contains too many closing brackets, esp.:
> * too many "}" at the end of file
> * too many "]" at the end of file
> * too many "}" within the file
> attached is a patch file with unit tests, three of them do not fail although 
> the json is invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE] Release Apache Sling Commons Testing 2.0.20, Commons JSON 2.0.14, Maven Sling Plugin 2.1.4

[Stefan Seifert]

Hi,

Apache Sling Commons Testing 2.0.20  - 4 Issues
https://issues.apache.org/jira/browse/SLING/fixforversion/12331987

Apache Sling Commons JSON 2.0.14  - 3 Issues
https://issues.apache.org/jira/browse/SLING/fixforversion/12333769

Apache Sling Maven Sling Plugin 2.1.4  - 2 Issues
https://issues.apache.org/jira/browse/SLING/fixforversion/12334045

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1364/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1364 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


stefan