Re: [VOTE] Release Apache Sling API 2.15.0 and Resource Resolver 1.5.0

[Carsten Ziegeler]

The vote passed with four binding +1 votes

Thanks
Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Comment Edited] (SLING-5277) Performance: per thread script resolver (admin session) is always created even if cache is hit

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603702#comment-15603702
 ] 

Alexander Klimetschek edited comment on SLING-5277 at 10/25/16 12:53 AM:
-

Attached new patch [^SLING-5277-new.patch] which solves the above discussed 
issue.

The patch is against revision 1730513 though, right after the 
org.apache.sling.servlets.resolver 2.4.2 release, as afterwards a lot of sling 
changes happened that requires many bundles to update (which I couldn't easily 
do in my environment).

I haven't got good test numbers yet (only tested this issue together with other 
changes), but independent tests would be great! /cc [~joerghoh]


was (Author: alexander.klimetschek):
Attached new patch [^SLING-5277-new.patch] which solves the above discussed 
issue.

I haven't got good test numbers yet (only tested this issue together with other 
changes), but independent tests would be great! /cc [~joerghoh]

> Performance: per thread script resolver (admin session) is always created 
> even if cache is hit
> --
>
> Key: SLING-5277
> URL: https://issues.apache.org/jira/browse/SLING-5277
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Alexander Klimetschek
> Attachments: SLING-5277-new.patch, SLING-5277.patch
>
>
> Since SLING-3441, for every request, a new admin / privileged session is 
> [created in the 
> SlingServletResolver|https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L532].
>  It is created before the script/servlet cache is checked, so in most cases 
> when the cache is hit it is never used, but the cost of creating an extra 
> session (which can vary, especially with concurrent traffic) is incurred.
> The per thread script resolver can be created lazily instead of directly in 
> the event to avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5277) Performance: per thread script resolver (admin session) is always created even if cache is hit

[Alexander Klimetschek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Klimetschek updated SLING-5277:
-
Attachment: SLING-5277-new.patch

Attached new patch [^SLING-5277-new.patch] which solves the above discussed 
issue.

I haven't got good test numbers yet (only tested this issue together with other 
changes), but independent tests would be great! /cc [~joerghoh]

> Performance: per thread script resolver (admin session) is always created 
> even if cache is hit
> --
>
> Key: SLING-5277
> URL: https://issues.apache.org/jira/browse/SLING-5277
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Alexander Klimetschek
> Attachments: SLING-5277-new.patch, SLING-5277.patch
>
>
> Since SLING-3441, for every request, a new admin / privileged session is 
> [created in the 
> SlingServletResolver|https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L532].
>  It is created before the script/servlet cache is checked, so in most cases 
> when the cache is hit it is never used, but the cost of creating an extra 
> session (which can vary, especially with concurrent traffic) is incurred.
> The per thread script resolver can be created lazily instead of directly in 
> the event to avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6180) Show slowest filters sorted by total time in filter status webconsole

[Alexander Klimetschek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Klimetschek updated SLING-6180:
-
Summary: Show slowest filters sorted by total time in filter status 
webconsole  (was: Show slowest filters sorted by time per request in filter 
status webconsole)

> Show slowest filters sorted by total time in filter status webconsole
> -
>
> Key: SLING-6180
> URL: https://issues.apache.org/jira/browse/SLING-6180
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Alexander Klimetschek
> Attachments: SLING-6180.patch
>
>
> Current output of /system/console/status-slingfilter includes time 
> measurements, including time per call. However, to analyze performance of 
> component & include filters a time per request would be helpful, as these are 
> called multiple times per request.
> Also, with a longer list of filters it would be nice to have this information 
> sorted by their time per request, so that the "worst" offenders show up at 
> the top.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling API 2.15.0 and Resource Resolver 1.5.0

[Daniel Klco]

+1

On Mon, Oct 24, 2016 at 4:22 AM, Radu Cotescu  wrote:

> +1
>
> On Fri, 21 Oct 2016 at 08:02 Carsten Ziegeler 
> wrote:
>
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
>

[jira] [Assigned] (SLING-5867) SlingRequestStatusHealthCheck should add timeout support

[Georg Henzler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler reassigned SLING-5867:


Assignee: Georg Henzler

> SlingRequestStatusHealthCheck should add timeout support
> 
>
> Key: SLING-5867
> URL: https://issues.apache.org/jira/browse/SLING-5867
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Support 1.0.4
>Reporter: Konrad Windszus
>Assignee: Georg Henzler
>
> Currently {{o.a.s.hc.support.impl.SlingRequestStatusHealthCheck}} just 
> synchronously calls {{SlingRequestProcessor.processResponse}}.
> That means in case of a non-returning response (e.g. caused by a deadlock 
> like SLING-5847) the health check will just timeout but never actually really 
> fail (even after a very long time).
> In this case it is good to create a dedicated timeout handling within the 
> {{SlingRequestStatusHealthCheck}} (separate from the timeout in 
> {{HealthCheckExecutorImpl}}) because for each individual request health check 
> configuration you might want to set different timeouts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4031) Missing MANIFEST.MF should be a validation error

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602373#comment-15602373
 ] 

Konrad Windszus commented on SLING-4031:


Although not explicitly checked, there are some implicit checks for the m2e 
project importers for bundles which should assure that the pom.xml is properly 
configured (committed with SLING-6112).
The question is whether we need something in addition to support non-Maven 
projects and whether there should be an explicit check for the MANIFEST.MF. For 
the latter we need to leverage the right trigger for that (after the build was 
successful). This is not supported through the WST Validation framework AFAIK, 
because this is only triggered when an individual file has been touched (not 
necessarily after the build finished).

> Missing MANIFEST.MF should be a validation error
> 
>
> Key: SLING-4031
> URL: https://issues.apache.org/jira/browse/SLING-4031
> Project: Sling
>  Issue Type: Test
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.2
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.1.2
>
>
> I just noticed a warning on the Sling console when a bundle was rebuilt
> {quote}[October 11, 2014 2:09:53 AM EEST] InstallBundle -> 
> /home/ADOBENET/rmuntean/Downloads/import/myproject/components/target/classes 
> : Project P/myproject.components does not have a META-INF/MANIFEST.MF (yet) - 
> not publishing this time (0 ms)
> {quote}
> This should be a validation error and block publishing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4003) Investigate compatibility with m2eclipse-tycho 0.7.0 or newer

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602351#comment-15602351
 ] 

Konrad Windszus commented on SLING-4003:


I think with SLING-6112 being resolved and m-b-p supporting incremental builds 
(FELIX-4009) this is not longer relevant and we should rather recommend to not 
install m2e-tycho at all.

> Investigate compatibility with m2eclipse-tycho 0.7.0 or newer
> -
>
> Key: SLING-4003
> URL: https://issues.apache.org/jira/browse/SLING-4003
> Project: Sling
>  Issue Type: Task
>  Components: IDE
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.1.2
>
>
> With commit 
> [85cd048f|https://github.com/tesla/m2eclipse-tycho/commit/85cd048ffcd47020992bdec2cd44f1a4945173bf]
>  m2eclipse-tycho will no longer regenerate the bundle's manifest on each 
> change. This will result in improved performance. 
> However, it might also mean that when a new SCR component is added the 
> manifest's Service-Component will not get updated with the location of the 
> newly generated descriptor files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-3629) Provide an XML formatter for content.xml files

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602343#comment-15602343
 ] 

Konrad Windszus commented on SLING-3629:


The only things which cannot be achieved with the XML formatter to be 
completely in sync with the vault formatting are
#  Different indentation levels for attributes and subelements (see 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=499369) are not supported by the 
Eclipse XML formatter (but used within vault)
# The XML prolog is slightly differently formatted, i.e. all attributes of that 
sections are in one line with Filevault but in multiple lines with the Eclipse 
formatter.

> Provide an XML formatter for content.xml files
> --
>
> Key: SLING-3629
> URL: https://issues.apache.org/jira/browse/SLING-3629
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.1.2
>
>
> When editing resource properties through the JCR properties view, we format 
> the corresponding XML according to the vault canonical format. At the same 
> time, there is no such provision for working with content.xml files directly 
> in the editor.
> While I don't think that we should format them automatically, it would be 
> useful to have a formatter which can be manually invoked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-4641) Content navigator does not decorate resources with warning/error markers

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601828#comment-15601828
 ] 

Konrad Windszus edited comment on SLING-4641 at 10/24/16 3:31 PM:
--

This can be achieved with an {{org.eclipse.jdt.ui.ProblemsLabelDecorator}} 
(https://github.com/eclipse/webtools.javaee/blob/7c9fc5163a8c85bcefa8fff320f75ceddde9dc14/plugins/org.eclipse.jst.servlet.ui/servlet_ui/org/eclipse/jst/servlet/ui/internal/navigator/WebJavaLabelProvider.java)


was (Author: kwin):
This can be achieved with an {{ILabelDecorator}} 
(http://www.eclipse.org/articles/Article-Decorators/decorators.html)

> Content navigator does not decorate resources with warning/error markers
> 
>
> Key: SLING-4641
> URL: https://issues.apache.org/jira/browse/SLING-4641
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.6
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: content-navigator-missing-errors.png
>
>
> See attached screenshot ; the top area is the content navigator, the bottom 
> one is the regular eclipse folder/file view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-3014) [build] Generate SCR descriptors using the maven-scr-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602332#comment-15602332
 ] 

Konrad Windszus commented on SLING-3014:


Now rather Bnd should be used to generate service descriptors, as Bnd supports 
OSGi 6 annotations.

> [build] Generate SCR descriptors using the maven-scr-plugin
> ---
>
> Key: SLING-3014
> URL: https://issues.apache.org/jira/browse/SLING-3014
> Project: Sling
>  Issue Type: Task
>  Components: IDE
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-3014-1.patch
>
>
> Since we're starting to use SCR descriptors when building the Sling IDE tools 
> it would be nice to generate them using the maven-scr-plugin. I have the 
> build working in the CLI, but not yet in the IDE ( see 
> http://dev.eclipse.org/mhonarc/lists/tycho-user/msg04764.html ). Once that is 
> done I'll commit my changes to trunk.
> Note that plain Maven projects work just fine, this is about Tycho-driven 
> builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-4641) Content navigator does not decorate resources with warning/error markers

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601828#comment-15601828
 ] 

Konrad Windszus edited comment on SLING-4641 at 10/24/16 3:31 PM:
--

This can be achieved with a {{org.eclipse.jdt.ui.ProblemsLabelDecorator}} 
(https://github.com/eclipse/webtools.javaee/blob/7c9fc5163a8c85bcefa8fff320f75ceddde9dc14/plugins/org.eclipse.jst.servlet.ui/servlet_ui/org/eclipse/jst/servlet/ui/internal/navigator/WebJavaLabelProvider.java)


was (Author: kwin):
This can be achieved with an {{org.eclipse.jdt.ui.ProblemsLabelDecorator}} 
(https://github.com/eclipse/webtools.javaee/blob/7c9fc5163a8c85bcefa8fff320f75ceddde9dc14/plugins/org.eclipse.jst.servlet.ui/servlet_ui/org/eclipse/jst/servlet/ui/internal/navigator/WebJavaLabelProvider.java)

> Content navigator does not decorate resources with warning/error markers
> 
>
> Key: SLING-4641
> URL: https://issues.apache.org/jira/browse/SLING-4641
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.6
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: content-navigator-missing-errors.png
>
>
> See attached screenshot ; the top area is the content navigator, the bottom 
> one is the regular eclipse folder/file view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-4641) Content navigator does not decorate resources with warning/error markers

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-4641.

Resolution: Fixed

Fixed with [r1766420|https://svn.apache.org/r1766420].

> Content navigator does not decorate resources with warning/error markers
> 
>
> Key: SLING-4641
> URL: https://issues.apache.org/jira/browse/SLING-4641
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.6
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: content-navigator-missing-errors.png
>
>
> See attached screenshot ; the top area is the content navigator, the bottom 
> one is the regular eclipse folder/file view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-4641) Content navigator does not decorate resources with warning/error markers

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-4641:
--

Assignee: Konrad Windszus

> Content navigator does not decorate resources with warning/error markers
> 
>
> Key: SLING-4641
> URL: https://issues.apache.org/jira/browse/SLING-4641
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.6
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: content-navigator-missing-errors.png
>
>
> See attached screenshot ; the top area is the content navigator, the bottom 
> one is the regular eclipse folder/file view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[Radu Cotescu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601963#comment-15601963
 ] 

Radu Cotescu commented on SLING-6165:
-

I've removed the resolver from thread local on 
{{SlingRequestEvent.EventType.EVENT_DESTROY}} in commit 
[r1766404|https://svn.apache.org/r1766404] and I've also added some unit tests.

> Expose a service for Sling Scripting that provides request-scoped Resource 
> Resolvers for scripting dependencies
> ---
>
> Key: SLING-6165
> URL: https://issues.apache.org/jira/browse/SLING-6165
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Scripting Core 2.0.42, Scripting API 2.1.10
>
>
> A new Sling Scripting service ({{ScriptingResourceResolverFactory}}) should 
> be implemented in order to provide access to request-based 
> {{ResourceResolvers}} for solving script dependencies.
> The following two methods should be available:
> {noformat}
> /**
>  * Provides a request-scoped {@link ResourceResolver} with only read access 
> to the search paths. This resolver should be used for script 
>  * resolution in the context of the same request rendering process. The 
> {@code ResourceResolver} should not be closed by consumers (calling
>  * {@link ResourceResolver#close} doesn't do anything), since this service 
> will handle the closing operation automatically. The 
>  * {@code ResourceResolver} will be shared between scripting dependencies 
> that render parts of the response for the same request.
>  */
> ResourceResolver getRequestScopedResourceResolver()
> /**
>  * Provides a {@link ResourceResolver} with only read access to the search 
> paths. Once you're done processing {@link Resource}s with this 
>  * {@code ResourceResolver} make sure to close it.
>  */
> ResourceResolver getResourceResolver()
> {noformat}
> [sling-dev email 
> thread|https://lists.apache.org/thread.html/db2a78249baf2d6234a4549a5aff8b5474256add9829f86ac78d1c56@%3Cdev.sling.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4641) Content navigator does not decorate resources with warning/error markers

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601828#comment-15601828
 ] 

Konrad Windszus commented on SLING-4641:


This can be achieved with an {{ILabelDecorator}} 
(http://www.eclipse.org/articles/Article-Decorators/decorators.html)

> Content navigator does not decorate resources with warning/error markers
> 
>
> Key: SLING-4641
> URL: https://issues.apache.org/jira/browse/SLING-4641
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.6
>Reporter: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: content-navigator-missing-errors.png
>
>
> See attached screenshot ; the top area is the content navigator, the bottom 
> one is the regular eclipse folder/file view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6177) Document the web tail and grep feature

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6177.

Resolution: Done

> Document the web tail and grep feature
> --
>
> Key: SLING-6177
> URL: https://issues.apache.org/jira/browse/SLING-6177
> Project: Sling
>  Issue Type: Task
>  Components: Documentation
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>
> We should document the log grep (SLING-6142) and tail feature at [1]
> [1] https://sling.apache.org/documentation/development/logging.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6142) Add grep like support in Log Tailer

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-6142:
---
Labels:   (was: docs-impacting)

> Add grep like support in Log Tailer
> ---
>
> Key: SLING-6142
> URL: https://issues.apache.org/jira/browse/SLING-6142
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0
>
>
> Sling Commons Log webconsole plugin has a basic tail support. I would like to 
> add basic grep support to allow tailing lines matching certain pattern



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6177) Document the web tail and grep feature

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601711#comment-15601711
 ] 

Chetan Mehrotra commented on SLING-6177:


Updated document - 
http://sling.apache.org/documentation/development/logging.html#webtail



> Document the web tail and grep feature
> --
>
> Key: SLING-6177
> URL: https://issues.apache.org/jira/browse/SLING-6177
> Project: Sling
>  Issue Type: Task
>  Components: Documentation
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>
> We should document the log grep (SLING-6142) and tail feature at [1]
> [1] https://sling.apache.org/documentation/development/logging.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6112) Make Sling IDE independent of m2e-tycho

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-6112.

Resolution: Fixed

> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, 
> SLING-6112-v03.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being 
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the 
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get 
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin 
> conflict with that extension 
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at 
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601706#comment-15601706
 ] 

Konrad Windszus commented on SLING-6112:


Since there is no solution available from m2e, we must make sure that our 
project configurators call the build action. For that I restricted the project 
configurator for the {{maven-bundle-plugin}} to goal {{bundle}} only (and 
always leaving the goal {{manifest}}) to the lifecycle mapping of the plugin 
itself. For the {{bnd-maven-plugin}} I made sure that our project configurator 
always calls the underlying action for incremental builds.

> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, 
> SLING-6112-v03.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being 
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the 
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get 
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin 
> conflict with that extension 
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at 
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-6112) Make Sling IDE independent of m2e-tycho

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601706#comment-15601706
 ] 

Konrad Windszus edited comment on SLING-6112 at 10/24/16 11:30 AM:
---

Since there is no solution available from m2e, we must make sure that our 
project configurators call the build action. For that I restricted the project 
configurator for the {{maven-bundle-plugin}} to goal {{bundle}} only (and 
always leaving the goal {{manifest}}) to the lifecycle mapping of the plugin 
itself. For the {{bnd-maven-plugin}} I made sure that our project configurator 
always calls the underlying action for incremental builds. Fixed in 
[r1766384|https://svn.apache.org/r1766384].


was (Author: kwin):
Since there is no solution available from m2e, we must make sure that our 
project configurators call the build action. For that I restricted the project 
configurator for the {{maven-bundle-plugin}} to goal {{bundle}} only (and 
always leaving the goal {{manifest}}) to the lifecycle mapping of the plugin 
itself. For the {{bnd-maven-plugin}} I made sure that our project configurator 
always calls the underlying action for incremental builds.

> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, 
> SLING-6112-v03.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being 
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the 
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get 
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin 
> conflict with that extension 
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at 
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6145) Update slf4j related jars to 1.7.21

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6145.

Resolution: Fixed

Done with r1764624

> Update slf4j related jars to 1.7.21
> ---
>
> Key: SLING-6145
> URL: https://issues.apache.org/jira/browse/SLING-6145
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Launchpad Builder 9
>
>
> With SLING-6144 Sling Commons Log would be embedding Logback 1.1.7. It 
> requires Slf4j 1..7.15+. For this we should update slf4j dependencies to 
> latest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6118) Handle empty tracer config header gracefully

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6118.
--

> Handle empty tracer config header gracefully
> 
>
> Key: SLING-6118
> URL: https://issues.apache.org/jira/browse/SLING-6118
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> In case tracer config header is null request fails with following exception
> {noformat}
> 08.10.2016 14:47:43.920 *WARN* [qtp840310891-62] 
> org.eclipse.jetty.servlet.ServletHandler 
> /content/geometrixx-outdoors/en/women.html
> java.lang.IllegalArgumentException: A header cannot be an empty string.
>   at 
> org.apache.sling.commons.osgi.ManifestHeader.parse(ManifestHeader.java:116)
>   at 
> org.apache.sling.tracer.internal.TracerSet.parseTracerConfigs(TracerSet.java:71)
>   at org.apache.sling.tracer.internal.TracerSet.(TracerSet.java:50)
>   at 
> org.apache.sling.tracer.internal.LogTracer.getTracerContext(LogTracer.java:250)
>   at 
> org.apache.sling.tracer.internal.LogTracer$TracerFilter.doFilter(LogTracer.java:356)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6119) Log parameters not captured correctly in few cases

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6119.
--

> Log parameters not captured correctly in few cases
> --
>
> Key: SLING-6119
> URL: https://issues.apache.org/jira/browse/SLING-6119
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> Tracer also captures the log message parameters separately and provides 
> string representation in recording. In some cases where params are bound to 
> say JCR session there evaluation fails if done outside of session. This 
> causes message like
> {noformat}
> {
> timestamp: 1475920906003,
> level: "TRACE",
> logger: "org.apache.jackrabbit.oak.jcr.operations.writes",
> message: "[session-1987] Setting property 
> [/content/dam/summer_collection/jcr:content/jcr:title]",
> params: [
> "session-1987",
> "[FAILED toString()]"
> ]
> }
> {noformat}
> As a fix the param should be converted to string at time of logging itself



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6120) Collect logger names which get hit for a given request thread

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6120.
--

> Collect logger names which get hit for a given request thread
> -
>
> Key: SLING-6120
> URL: https://issues.apache.org/jira/browse/SLING-6120
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Log Tracer 1.0.2
>
>
> To allow better discovery to determine logger names to enabled it would be 
> good to collect name of loggers which get invoked as part of given request 
> processing. 
> These loggers need not log but they might be just check if given logging 
> level is enabled or not. We can collect such logger names and report back as 
> part of recording to allow end user an option to enable "interesting ones"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-5762) Relax Sling Log Tracer package imports

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-5762.
--

> Relax Sling Log Tracer package imports 
> ---
>
> Key: SLING-5762
> URL: https://issues.apache.org/jira/browse/SLING-5762
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Log Tracer 1.0.0
>Reporter: David Gonzalez
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
> Attachments: org.apache.sling.tracer-1.0.1-SNAPSHOT.jar
>
>
> Sling Log Tracer 1.0.0 has tight package import requirements limiting its use 
> across Sling-based applications.
> It would be nice to relax the imports to maximize Log Tracer compatibility 
> with older Sling-based stacks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6089) Log Tracer does not work with system having new HTTP whiteboard implementation

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6089.
--

> Log Tracer does not work with system having new HTTP whiteboard implementation
> --
>
> Key: SLING-6089
> URL: https://issues.apache.org/jira/browse/SLING-6089
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Log Tracer 1.0.2
>
>
> Log Tracer does not work with Sling setups which have newer HTTP Whiteboard 
> implementation (org.apache.felix.http.whiteboard:3.0.0). Currently the filter 
> is registered with service property
> {noformat}
> pattern=/.*
> {noformat}
> The filter does gets used for calls to /system/console but does not get 
> invoked for any calls which are handled by SlingMainServlet (as reported by 
> [~bdelacretaz] 
> [here|http://mail-archives.apache.org/mod_mbox/sling-dev/201609.mbox/%3CCAEWfVJ%3DWUVaoD9GOTD3WpL7PSEh9_Jk3maP2WPEWWTc7dbCftw%40mail.gmail.com%3E])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-5879) StatementCache interceptor configured by default causes ResultSets to remain open

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-5879.
--

> StatementCache interceptor configured by default causes ResultSets to remain 
> open
> -
>
> Key: SLING-5879
> URL: https://issues.apache.org/jira/browse/SLING-5879
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Andrei Dulceanu
>Assignee: Chetan Mehrotra
> Fix For: DataSource Provider 1.0.2
>
> Attachments: SLING-5879.diff
>
>
> Configuring {{StatementCache}} interceptor in 
> {{org.apache.sling.datasource}}, prevents the RDBDocumentStore to correctly 
> start up due to a bug in the StatementCache interceptor (see 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59850). 
> Recommended solution is to update the tomcat pool to a fixed version (7.0.71) 
> once it's out. Until that is the case we can
> * recommend not to turn on the StatementCache, or
> * use a recent Oak version which works around the bug 
> ([OAK-4559|https://issues.apache.org/jira/browse/OAK-4583]).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6144) Update logback dependency to 1.1.7

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6144.
--

> Update logback dependency to 1.1.7
> --
>
> Key: SLING-6144
> URL: https://issues.apache.org/jira/browse/SLING-6144
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0
>
>
> Current latest release of Logback is 1.1.7. Sling Commons Log is embedding 
> 1.1.2. This should be updated
> Note that with this the slf4j-api version would need to be updated to 1.7.15+ 
>  as per [1]
> [1] http://logback.qos.ch/dependencies.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-5756) Async appender is not started upon reattach in case of log config change

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-5756.
--

> Async appender is not started upon reattach in case of log config change
> 
>
> Key: SLING-5756
> URL: https://issues.apache.org/jira/browse/SLING-5756
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Log 4.0.2
>Reporter: Piyush Goyal
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: Commons Log 5.0.0
>
>
> Link to discussion on the mailing list:
> http://mail-archives.apache.org/mod_mbox/sling-users/201606.mbox/browser
> While appending an appender to Async appender and doing a change in the 
> logger level of any of the loggers, LogbackManager.java resets the complete 
> logger context. After the reset, for any async appenders, it detaches any 
> appenders attached to them.
> Thanks and Regards
> Piyush Goyal



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6142) Add grep like support in Log Tailer

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-6142.
--

> Add grep like support in Log Tailer
> ---
>
> Key: SLING-6142
> URL: https://issues.apache.org/jira/browse/SLING-6142
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
>  Labels: docs-impacting
> Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0
>
>
> Sling Commons Log webconsole plugin has a basic tail support. I would like to 
> add basic grep support to allow tailing lines matching certain pattern



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-5092) Missing Content type for system/console/slinglog/tailer.txt

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-5092.
--

> Missing Content type for system/console/slinglog/tailer.txt
> ---
>
> Key: SLING-5092
> URL: https://issues.apache.org/jira/browse/SLING-5092
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Antonio Sanso
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Commons Log 5.0.0
>
>
> {{system/console/slinglog/tailer.txt}} Felix Console plugin is missing 
> response content type
> {code}
> HTTP/1.1 200 OK
> Date: Tue, 06 Oct 2015 10:27:07 GMT
> Set-Cookie: felix-webconsole-locale=en;Path=/system/console;Expires=Mon, 
> 01-Oct-2035 10:27:07 GMT
> Expires: Thu, 01 Jan 1970 00:00:00 GMT
> Content-Length: 51
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-5932) Move Web Console Plugin to separate bundle

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra closed SLING-5932.
--

> Move Web Console Plugin to separate bundle
> --
>
> Key: SLING-5932
> URL: https://issues.apache.org/jira/browse/SLING-5932
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 4.0.6
>Reporter: Carsten Ziegeler
>Assignee: Chetan Mehrotra
> Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0
>
>
> The log implementation currently contains a web console plugin which uses a 
> dynamic package import. Once the log impl is wired to a bundle providing the 
> servlet api and that bundle is updated/removed, it causes the log 
> implementation to refresh, which usually means a complete restart of the 
> system (as every bunde uses logging).
> We should reduce this coupling and remove any dependency to the servlet api 
> from the logging implementation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6130) Restrict access for principal everyone and move configuration to repoinit

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601556#comment-15601556
 ] 

Oliver Lietz commented on SLING-6130:
-

Sure, just a timeout (no failures in {{error.log}}, Sling starts and stops 
properly):

{noformat}
Running org.apache.sling.launchpad.SmokeIT
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/[...]/.m2/repository/ch/qos/logback/logback-classic/1.1.7/logback-classic-1.1.7.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/[...]/.m2/repository/org/slf4j/slf4j-simple/1.5.2/slf4j-simple-1.5.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type 
[ch.qos.logback.classic.util.ContextSelectorStaticBinder]
Attempting to load ESAPI.properties via file I/O.
Attempting to load ESAPI.properties as resource file via file I/O.
Not found in 'org.owasp.esapi.resources' directory or file not readable: 
/[...]/sling/trunk/launchpad/builder/target/_-53965/ESAPI.properties
Not found in SystemResource Directory/resourceDirectory: .esapi/ESAPI.properties
Not found in 'user.home' ([...]) directory: /[...]/esapi/ESAPI.properties
Loading ESAPI.properties via file I/O failed. Exception was: 
java.io.FileNotFoundException
Attempting to load ESAPI.properties via the classpath.
SUCCESSFULLY LOADED ESAPI.properties via the CLASSPATH from '/ (root)' using 
class loader for DefaultSecurityConfiguration class!
Attempting to load validation.properties via file I/O.
Attempting to load validation.properties as resource file via file I/O.
Not found in 'org.owasp.esapi.resources' directory or file not readable: 
/[...]/sling/trunk/launchpad/builder/target/_-53965/validation.properties
Not found in SystemResource Directory/resourceDirectory: 
.esapi/validation.properties
Not found in 'user.home' ([...]) directory: [...]/esapi/validation.properties
Loading validation.properties via file I/O failed.
Attempting to load validation.properties via the classpath.
SUCCESSFULLY LOADED validation.properties via the CLASSPATH from '/ (root)' 
using class loader for DefaultSecurityConfiguration class!
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 61.282 sec <<< 
FAILURE! - in org.apache.sling.launchpad.SmokeIT
org.apache.sling.launchpad.SmokeIT  Time elapsed: 61.281 sec  <<< ERROR!
java.lang.RuntimeException: Launchpad not ready. Failed check for URL 
http://localhost:53965/server/default/jcr:root with message 'Status code is 
HTTP/1.1 404 Not Found'
at 
org.apache.sling.launchpad.LaunchpadReadyRule.runCheck(LaunchpadReadyRule.java:96)
at 
org.apache.sling.launchpad.LaunchpadReadyRule.before(LaunchpadReadyRule.java:66)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Results :

Tests in error: 
  SmokeIT.org.apache.sling.launchpad.SmokeIT » Runtime Launchpad not ready. 
Fail...

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
{noformat}


> Restrict access for principal everyone and move configuration to repoinit
> -
>
> Key: SLING-6130
> URL: https://issues.apache.org/jira/browse/SLING-6130
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR, Oak
>Affects Versions: JCR Oak Server 1.1.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>  Labels: security
> Fix For: JCR Oak Server 1.1.2
>
>
> Currently {{everyone}} can {{read}} from {{/}} (configured in 
> {{OakSlingRepositoryManager}}).
> Access for {{everyone}} should be restricted:
> * {{read}} should be restricted to {{/content}}
> * configuration of principals and ACLs should be done with _repoinit_
> # -Change path from {{/}} to {{/content}} in {{OakSlingRepositoryManager}}- 
> (/) (-[r1764259|https://svn.apache.org/r1764259]-)
> # Fix modules (samples) relying on _unrestricted_ {{read}} access
> # Move configuration of ACLs to 

[jira] [Commented] (SLING-6130) Restrict access for principal everyone and move configuration to repoinit

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601504#comment-15601504
 ] 

Robert Munteanu commented on SLING-6130:


Do you have a sample failure stack trace?

> Restrict access for principal everyone and move configuration to repoinit
> -
>
> Key: SLING-6130
> URL: https://issues.apache.org/jira/browse/SLING-6130
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR, Oak
>Affects Versions: JCR Oak Server 1.1.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>  Labels: security
> Fix For: JCR Oak Server 1.1.2
>
>
> Currently {{everyone}} can {{read}} from {{/}} (configured in 
> {{OakSlingRepositoryManager}}).
> Access for {{everyone}} should be restricted:
> * {{read}} should be restricted to {{/content}}
> * configuration of principals and ACLs should be done with _repoinit_
> # -Change path from {{/}} to {{/content}} in {{OakSlingRepositoryManager}}- 
> (/) (-[r1764259|https://svn.apache.org/r1764259]-)
> # Fix modules (samples) relying on _unrestricted_ {{read}} access
> # Move configuration of ACLs to _repoinit_ (/)
> discussion on 
> [dev@|https://lists.apache.org/thread.html/36908ed62ac93c63cad594a897f8abceb93f08da5bcea30dbce98e58@%3Cdev.sling.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[RESULT][VOTE] Release Apache Sling Log Tracer 1.0.2

[Chetan Mehrotra]

Hi,

The release passes with 3 binding +1 votes from Carsten Ziegeler,
Daniel Klco and Chetan Mehrotra.

Thanks,
Chetan Mehrotra

[RESULT][VOTE] Release Apache Sling DataSource Provider 1.0.2

[Chetan Mehrotra]

Hi,

The release passes with 3 binding +1 votes from Carsten Ziegeler,
Daniel Klco and Chetan Mehrotra.

Thanks,
Chetan Mehrotra

[RESULT][VOTE] Release Apache Sling Commons Log 5.0.0, Log WebConsole 1.0.0

[Chetan Mehrotra]

Hi,

The release passes with 3 binding +1 votes from Carsten Ziegeler,
Daniel Klco and Chetan Mehrotra.

Thanks,
Chetan Mehrotra

[jira] [Closed] (SLING-6173) HTL compiled scripts need to set the SlingBindings as request attributes on eval

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-6173.
---

> HTL compiled scripts need to set the SlingBindings as request attributes on 
> eval
> 
>
> Key: SLING-6173
> URL: https://issues.apache.org/jira/browse/SLING-6173
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.20
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.26
>
>
> HTL compiled scripts need to set the {{SlingBindings}} as request attributes 
> on {{eval}} so that Sling Models are able to inject values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[RESULT][VOTE] Release Apache Sling Scripting HTL Engine 1.0.26

[Radu Cotescu]

Hi,

The release passes with 3 binding +1 votes from Carsten Ziegeler, Daniel
Klco and Chetan Mehrotra.

Thanks,
Radu

Re: [VOTE] Release Apache Sling API 2.15.0 and Resource Resolver 1.5.0

[Radu Cotescu]

+1

On Fri, 21 Oct 2016 at 08:02 Carsten Ziegeler  wrote:

> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

Re: [VOTE] Release Apache Sling API 2.15.0 and Resource Resolver 1.5.0

[Stefan Egli]

+1

Cheers,
Stefan

On 21/10/16 08:02, "Carsten Ziegeler"  wrote:

>Hi,
>
>We solved 7 issues for these API 2.15.0 release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12338300
>
>We solved 12 issues for the Resource Resolver 1.5.0 release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12338276
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1553
>
>You can use this UNIX script to download the releases and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1553 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Regards
>Carsten
>-- 
>Carsten Ziegeler
>Adobe Research Switzerland
>cziege...@apache.org

Re: [VOTE] Release Apache Sling DataSource Provider 1.0.2

[Chetan Mehrotra]

+1
Chetan Mehrotra


On Thu, Oct 20, 2016 at 6:19 PM, Daniel Klco  wrote:
> +1
>
> On Thu, Oct 20, 2016 at 7:38 AM, Carsten Ziegeler 
> wrote:
>
>> +1
>>
>>
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>>
>>

Re: [VOTE] Release Apache Sling Log Tracer 1.0.2

[Chetan Mehrotra]

+1
Chetan Mehrotra


On Thu, Oct 20, 2016 at 6:22 PM, Daniel Klco  wrote:
> +1
>
> On Thu, Oct 20, 2016 at 7:38 AM, Carsten Ziegeler 
> wrote:
>
>> +1
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>>
>>

Re: [VOTE] Release Apache Sling Commons Log 5.0.0, Log WebConsole 1.0.0

[Chetan Mehrotra]

+1
Chetan Mehrotra


On Thu, Oct 20, 2016 at 5:55 PM, Daniel Klco  wrote:
> +1
>
> On Thu, Oct 20, 2016 at 7:37 AM, Carsten Ziegeler 
> wrote:
>
>> +1
>>
>>
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>>
>>

Re: [VOTE] Release Apache Sling Scripting HTL Engine 1.0.26

[Chetan Mehrotra]

+1
Chetan Mehrotra


On Thu, Oct 20, 2016 at 6:03 PM, Daniel Klco  wrote:
> +1
>
> On Thu, Oct 20, 2016 at 7:38 AM, Carsten Ziegeler 
> wrote:
>
>> +1
>>
>>
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>>
>>

[jira] [Commented] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[Radu Cotescu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601197#comment-15601197
 ] 

Radu Cotescu commented on SLING-6165:
-

Thanks for the quick review! Yes, I forgot to clean {{ThreadLocal}}. I guess we 
can safely use the {{SlingRequestEvent}} for the request-bound resolvers since 
the {{SlingServletResolver}} uses the same mechanism now: 
https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L523

In fact I think we should switch the {{SlingServletResolver}} to use this new 
{{ScriptingResourceResolverFactory}} that's now exposed for other bundles. We 
could also provide a lazily instantiated resolver for services that are not 
request-bound, but for the servlet resolver and most scripting engines that we 
have in Sling we need the request-bound one.

There's no change for {{javax.scripting}} formally. Before my changes the 
package exports were defined in the {{pom.xml}} file, but I've now switched the 
bundle to {{package-info.java}} files

I have nothing against moving this "factory" somewhere else, but the service 
user that it needs should be transparent and I think that it should be the 
{{sling-scripting}} one. In retrospect I also don't see much benefit having the 
second {{#getResourceResolver()}} method, except for already having it mapped 
to the same service user.

> Expose a service for Sling Scripting that provides request-scoped Resource 
> Resolvers for scripting dependencies
> ---
>
> Key: SLING-6165
> URL: https://issues.apache.org/jira/browse/SLING-6165
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Scripting Core 2.0.42, Scripting API 2.1.10
>
>
> A new Sling Scripting service ({{ScriptingResourceResolverFactory}}) should 
> be implemented in order to provide access to request-based 
> {{ResourceResolvers}} for solving script dependencies.
> The following two methods should be available:
> {noformat}
> /**
>  * Provides a request-scoped {@link ResourceResolver} with only read access 
> to the search paths. This resolver should be used for script 
>  * resolution in the context of the same request rendering process. The 
> {@code ResourceResolver} should not be closed by consumers (calling
>  * {@link ResourceResolver#close} doesn't do anything), since this service 
> will handle the closing operation automatically. The 
>  * {@code ResourceResolver} will be shared between scripting dependencies 
> that render parts of the response for the same request.
>  */
> ResourceResolver getRequestScopedResourceResolver()
> /**
>  * Provides a {@link ResourceResolver} with only read access to the search 
> paths. Once you're done processing {@link Resource}s with this 
>  * {@code ResourceResolver} make sure to close it.
>  */
> ResourceResolver getResourceResolver()
> {noformat}
> [sling-dev email 
> thread|https://lists.apache.org/thread.html/db2a78249baf2d6234a4549a5aff8b5474256add9829f86ac78d1c56@%3Cdev.sling.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)