[jira] [Commented] (SLING-6826) i18n: Supported nested keys in JSON i18n files

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997693#comment-15997693
 ] 

Alexander Klimetschek commented on SLING-6826:
--

This means the nested structure maps to aggregated keys like 
{{application1.section1.component1.key1}} (mentioned in the description above, 
but I somehow missed it).

Is having a plain json dictionary like this instead not feasible?

{code}
{
"application1.section1.component1.key1": "value1",
"application1.section1.component1.key2": "value2"
}
{code}

I'd be a bit hesitant to add a feature that is json format specific and not 
really supported by other dictionary formats (e.g. the old sling:Message 
structure, or even other like XLIFF). It could lead to some incompatibilities 
at some point, and keeping it simple at the sling i18n side might be better.

You could build a little preprocessor that would convert the nested 
dictionaries into the plain json format for example, as part of build tooling.

{quote}whenever the english text changes (for whatever reason), the key 
contract is broken and all translations have to be touched as well{quote}
Note that this is a good thing, as when you change the original english text, 
you usually need to change the translation or at least review it. The clearly 
missing key/translation makes this detectable.

{quote}it is not possible to "namespace" i18n keys to separate different 
applications deployed by different parties on the same instance{quote}
Yes, it is possible using comments. The convention we use in AEM is {{message 
((comment))}} as key, and we have tooling around it (i.e. an API that supports 
comments and our translation tooling can handle it and generate the right json 
dictionaries in the end). Then you can have e.g.
* {{Share ((action button in main toolbar))}}
* {{Share ((link to the collaboration area))}}

Another option is to use the [basename 
support|https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names],
 where each dictionary has its own basename and you request the a specific 
ResourceBundle at runtime,

> i18n: Supported nested keys in JSON i18n files
> --
>
> Key: SLING-6826
> URL: https://issues.apache.org/jira/browse/SLING-6826
> Project: Sling
>  Issue Type: New Feature
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Stefan Seifert
>
> i18n supports resource files stored as JSON binary files in the repository:
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#json-file-based
> currently nested key structures are not really supported - from the docs 
> page: 
> {quote}
> The parser will take any "key":"value" pair in the JSON file, including those 
> in nested objects or arrays. Normally, a dictionary will be just a single 
> json object = hash map though.
> {quote}
> that means that these two JSON example will produc the same result:
> A)
> {code:javascript}
> {
>   "key1": "value1",
>   "key2": "value2",
>   "key3": "value3"
> }
> {code}
> B)
> {code:javascript}
> {
>   "level1": {
> "key1": "value1",
> "level2: {
>   "key2": "value2",
>   "level3": {
> "key3": "value3"
>   }
> }
>   }
> }
> {code}
> in both cases the keys are just
> {noformat}
> key1
> key2
> key3
> {noformat}
> the goal of this ticket is to interpret the nested JSON object structure as 
> parts of the i18n keys, so that example B would produce these keys:
> {noformat}
> level1.key1
> level1.level2.key2
> level1.level2.level3.key3
> {noformat}
> as statet in the documentation in most cases people will only use the JSON as 
> key/value map file with no hierarchies at all. in this case the result is the 
> same. but if someone used hierarchies this ticket will create a backward 
> compatibility issue. i will start a discussion on the sling-dev list about 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Release Apache Sling File System Resource Provider 2.1.0, File System Resource Provider 1.4.0, JCR Content Parser 1.1.0

[Stefan Seifert]

+1

[VOTE] Release Apache Sling File System Resource Provider 2.1.0, File System Resource Provider 1.4.0, JCR Content Parser 1.1.0

[Stefan Seifert]

Hi,

Apache Sling JCR Content Parser 1.1.0  (2 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12340238

Apache Sling File System Resource Provider 1.4.0  (1 issue)
https://issues.apache.org/jira/browse/SLING/fixforversion/12340279

Apache Sling File System Resource Provider 2.1.0  (1 issue)
https://issues.apache.org/jira/browse/SLING/fixforversion/12340280

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1702/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1702 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

RE: [VOTE] Release Apache Sling JCR ContentLoader 2.2.0, Pax Exam Utilities 1.0.4

[Stefan Seifert]

+1

[VOTE] Release Apache Sling JCR ContentLoader 2.2.0, Pax Exam Utilities 1.0.4

[Stefan Seifert]

Hi,

Apache Sling JCR ContentLoader 2.2.0  (11 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12329080
There are still some outstanding iussue moved to JCR Content Loader 2.2.2:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340508

Apache Sling Sling Pax Exam Utilities 1.0.4  (1 issue)
https://issues.apache.org/jira/browse/SLING/fixforversion/12326058

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1701/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1701 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

[jira] [Updated] (SLING-3534) separate node name and content type in content loader

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-3534:
--
Fix Version/s: (was: JCR ContentLoader 2.2.0)
   JCR ContentLoader 2.2.2

> separate node name and content type in content loader
> -
>
> Key: SLING-3534
> URL: https://issues.apache.org/jira/browse/SLING-3534
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR ContentLoader 2.2.2
>
>
> extend API (node name and content type are currently taken from file name)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-3619) Content Loader should handle input errors gracefully

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-3619:
--
Fix Version/s: (was: JCR ContentLoader 2.2.0)
   JCR ContentLoader 2.2.2

> Content Loader should handle input errors gracefully
> 
>
> Key: SLING-3619
> URL: https://issues.apache.org/jira/browse/SLING-3619
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.8
>Reporter: Yogesh Upadhyay
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: JCR ContentLoader 2.2.2
>
>
> After upgrading to latest sling jar file, content loader stopped working to 
> load content using Sling-Initial-Content. Getting following message in log
> 29.05.2014 23:20:21.504 *INFO* [Background Install 
> /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp]
>  org.apache.sling.jcr.contentloader.internal.DefaultContentCreator 
> createFile: Cannot find content type for body.jsp, using 
> application/octet-stream



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-3533) improve error handling and logging in content loader

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-3533:
--
Fix Version/s: (was: JCR ContentLoader 2.2.0)
   JCR ContentLoader 2.2.2

> improve error handling and logging in content loader
> 
>
> Key: SLING-3533
> URL: https://issues.apache.org/jira/browse/SLING-3533
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR ContentLoader 2.2.2
>
>
> handle errors more appropriate and use proper log levels



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-3535) reduce duplicated code in content loader

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-3535:
--
Fix Version/s: (was: JCR ContentLoader 2.2.0)
   JCR ContentLoader 2.2.2

> reduce duplicated code in content loader
> 
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR ContentLoader 2.2.2
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in 
> {{BaseImportLoader}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6829) FSResource: Support node descriptor files for folders and binary files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6829.
---
Resolution: Fixed

rev. 1793826 (2.x)
rev. 1793827 (1.x)


> FSResource: Support node descriptor files for folders and binary files
> --
>
> Key: SLING-6829
> URL: https://issues.apache.org/jira/browse/SLING-6829
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: File System Resource Provider 1.3.0, File System 
> Resource Provider 2.0.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: File System Resource Provider 1.3.2, File System 
> Resource Provider 2.0.2
>
>
> for binary files and folders it is possible to add additional content 
> definition files with the same name which add additional mixins or properties 
> to the imported nt:file/nt:folder resource, or change the JCR primary type.
> this has to be supported by fsresource as well.
> with this we should also add support for the XML descriptor file format (see 
> SLING-6828).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996924#comment-15996924
 ] 

Konrad Windszus commented on SLING-6830:


Yes

> Provide a custom navigator for provisioning model feature files
> ---
>
> Key: SLING-6830
> URL: https://issues.apache.org/jira/browse/SLING-6830
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> When working with slingstart projects it's often tedious to always drill down 
> to {{src/main/provisioning}} to view/edit provisioning model files.
> We can provide a custom contribution which simply pulls the 
> {{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996841#comment-15996841
 ] 

Robert Munteanu commented on SLING-6830:


So the order would be the following (duplicates being filtered):

* {{modelDirectory}} 
* {{src/main/provisioning}}
* {{src/test/provisioning}}

Is that right?

> Provide a custom navigator for provisioning model feature files
> ---
>
> Key: SLING-6830
> URL: https://issues.apache.org/jira/browse/SLING-6830
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> When working with slingstart projects it's often tedious to always drill down 
> to {{src/main/provisioning}} to view/edit provisioning model files.
> We can provide a custom contribution which simply pulls the 
> {{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-5952) Add support for configurable SO and connection timeouts

[Tommaso Teofili (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tommaso Teofili resolved SLING-5952.

Resolution: Fixed

> Add support for configurable SO and connection timeouts
> ---
>
> Key: SLING-5952
> URL: https://issues.apache.org/jira/browse/SLING-5952
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.18
>Reporter: Timothee Maret
>Assignee: Tommaso Teofili
> Fix For: Content Distribution Core 0.2.8
>
> Attachments: SLING-SLING-5952.0.patch
>
>
> Currently the SDC transport is using the default HTTP client timeouts
> 1. Connection Timeout (by default it is infinite)
> 2. SO Socket Timeout (by default it is infinite)
> Allowing to configure a bounded timeouts is needed in most deployments in 
> order to avoid leaving a resource stuck.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-5952) Add support for configurable SO and connection timeouts

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996764#comment-15996764
 ] 

Tommaso Teofili commented on SLING-5952:


I've fixed this in r1793803.

> Add support for configurable SO and connection timeouts
> ---
>
> Key: SLING-5952
> URL: https://issues.apache.org/jira/browse/SLING-5952
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.18
>Reporter: Timothee Maret
>Assignee: Tommaso Teofili
> Fix For: Content Distribution Core 0.2.8
>
> Attachments: SLING-SLING-5952.0.patch
>
>
> Currently the SDC transport is using the default HTTP client timeouts
> 1. Connection Timeout (by default it is infinite)
> 2. SO Socket Timeout (by default it is infinite)
> Allowing to configure a bounded timeouts is needed in most deployments in 
> order to avoid leaving a resource stuck.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996736#comment-15996736
 ] 

Konrad Windszus commented on SLING-6830:


no, because either {{src/test/provisiong}} or {{src/main/provisioning}} is 
being used as default when {{modelDirectory}} is not being set (compare with 
https://github.com/apache/sling/blob/trunk/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L116).

> Provide a custom navigator for provisioning model feature files
> ---
>
> Key: SLING-6830
> URL: https://issues.apache.org/jira/browse/SLING-6830
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> When working with slingstart projects it's often tedious to always drill down 
> to {{src/main/provisioning}} to view/edit provisioning model files.
> We can provide a custom contribution which simply pulls the 
> {{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6828) JCR Content Parser: Support XML Descriptor Files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6828.
---
Resolution: Fixed

Completed: At revision: 1793800  


> JCR Content Parser: Support XML Descriptor Files
> 
>
> Key: SLING-6828
> URL: https://issues.apache.org/jira/browse/SLING-6828
> Project: Sling
>  Issue Type: New Feature
>  Components: JCR
>Affects Versions: JCR Content Parser 1.0.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: JCR Content Parser 1.1.0
>
>
> we should also support the XML descriptor file format supported by the JCR 
> content loader:
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#xml-descriptor-files
> this is in some special usecases useful, e.g. when adding an descriptor for 
> binary files with additional properties - e.g. additional mixin and language 
> property for i18n json binary file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996715#comment-15996715
 ] 

Robert Munteanu commented on SLING-6830:


Is it enough to look at the {{modelDirectory}} value from the Maven Mojo?

> Provide a custom navigator for provisioning model feature files
> ---
>
> Key: SLING-6830
> URL: https://issues.apache.org/jira/browse/SLING-6830
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> When working with slingstart projects it's often tedious to always drill down 
> to {{src/main/provisioning}} to view/edit provisioning model files.
> We can provide a custom contribution which simply pulls the 
> {{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Release Apache Sling Slingstart Maven Plugin 1.7.6 and Provisioning Model 1.8.2

[Daniel Klco]

+1

On Tue, May 2, 2017 at 12:49 PM, Stefan Seifert 
wrote:

> +1
>
>

[jira] [Updated] (SLING-6831) ConcurrentModificationException in OSGi Installer

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-6831:

Attachment: SLING-6831.patch

The attached patch should fix this issue.

> ConcurrentModificationException in OSGi Installer
> -
>
> Key: SLING-6831
> URL: https://issues.apache.org/jira/browse/SLING-6831
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.6
>Reporter: David Bosschaert
> Fix For: Installer Core 3.8.8
>
> Attachments: SLING-6831.patch
>
>
> Under certain scenarios I'm getting: 
> {code}java.util.ConcurrentModificationException: null
>   at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
>   at java.util.HashMap$KeyIterator.next(HashMap.java:1461)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getInstallationState(OsgiInstallerImpl.java:1390)
> ...{code}
> To me this seems caused by the fact that the Map datastructure in the 
> PersistentResourceList is non-concurrent.
> PersistentResourceList.getEntityIds() returns the map's values directly. This 
> is what is used in OsgiInstallerImpl line 1390:
> {code}
> public Collection getEntityIds() {
> return this.data.keySet();
> }{code}
> And the client code iterates over that, causing the exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6831) ConcurrentModificationException in OSGi Installer

[David Bosschaert (JIRA)]

David Bosschaert created SLING-6831:
---

 Summary: ConcurrentModificationException in OSGi Installer
 Key: SLING-6831
 URL: https://issues.apache.org/jira/browse/SLING-6831
 Project: Sling
  Issue Type: Bug
  Components: Installer
Affects Versions: Installer Core 3.8.6
Reporter: David Bosschaert
 Fix For: Installer Core 3.8.8


Under certain scenarios I'm getting: 
{code}java.util.ConcurrentModificationException: null
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
at java.util.HashMap$KeyIterator.next(HashMap.java:1461)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.getInstallationState(OsgiInstallerImpl.java:1390)
...{code}
To me this seems caused by the fact that the Map datastructure in the 
PersistentResourceList is non-concurrent.

PersistentResourceList.getEntityIds() returns the map's values directly. This 
is what is used in OsgiInstallerImpl line 1390:
{code}
public Collection getEntityIds() {
return this.data.keySet();
}{code}
And the client code iterates over that, causing the exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Sling Context-Aware Configuration Impl 1.4.0, Context-Aware Configuration Mock Plugin 1.2.0

[Daniel Klco]

+1

On Tue, May 2, 2017 at 12:44 PM, Carsten Ziegeler 
wrote:

> +1
>
>
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[jira] [Commented] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996622#comment-15996622
 ] 

Konrad Windszus commented on SLING-6830:


The same for folder {{src/test/provisioning}} (SLING-6068)

> Provide a custom navigator for provisioning model feature files
> ---
>
> Key: SLING-6830
> URL: https://issues.apache.org/jira/browse/SLING-6830
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> When working with slingstart projects it's often tedious to always drill down 
> to {{src/main/provisioning}} to view/edit provisioning model files.
> We can provide a custom contribution which simply pulls the 
> {{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6830) Provide a custom navigator for provisioning model feature files

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-6830:
--

 Summary: Provide a custom navigator for provisioning model feature 
files
 Key: SLING-6830
 URL: https://issues.apache.org/jira/browse/SLING-6830
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Minor
 Fix For: Sling Eclipse IDE 1.2.0


When working with slingstart projects it's often tedious to always drill down 
to {{src/main/provisioning}} to view/edit provisioning model files.

We can provide a custom contribution which simply pulls the 
{{src/main/provisioning}} folder to the top level.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Redirect to /index.html no longer working in latest Launchpad

[Konrad Windszus]

Works for me now. Thanks for the fix.
Konrad
> On 28. Apr 2017, at 09:10, Stefan Seifert  wrote:
> 
> the launchpad did not run at all due to missing hc api bundle, and another 
> dependency problem in the get servlet - both are fixed now.
> do you still observe the problem?
> 
> stefan
> 
>> -Original Message-
>> From: Konrad Windszus [mailto:konra...@gmx.de]
>> Sent: Thursday, April 27, 2017 11:21 AM
>> To: dev@sling.apache.org
>> Subject: Redirect to /index.html no longer working in latest Launchpad
>> 
>> Since recently there is no longer a redirect from "/" to "/index.html",
>> leading to a directory listing being exposed at "/" instead of the nice
>> welcome page in "/index.html".
>> Does anyone know what might have caused this? Might be related to Oak,
>> since it seems that directory listing comes from Oak.
>> Thanks
>> Konrad
> 

Release of Servlets Resolver 2.4.12

[Konrad Windszus]

I am planning to cut a release of the servlets resolver soon 
(https://issues.apache.org/jira/browse/SLING/fixforversion/12338894). Should I 
wait for any other fixes?
Konrad

[jira] [Assigned] (SLING-6782) Sling Job implementation should avoid unnecessary writes to the repository

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-6782:
---

Assignee: Carsten Ziegeler

> Sling Job implementation should avoid unnecessary writes to the repository
> --
>
> Key: SLING-6782
> URL: https://issues.apache.org/jira/browse/SLING-6782
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.2
>Reporter: Jörg Hoh
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.4
>
> Attachments: SLING-6782-jobs-commit-to-often-2.patch, 
> SLING-6782-jobs-commit-to-often.patch
>
>
> I found in a number of occurences in the Sling Event code this pattern:
> {code}
> ResourceHelper.getOrCreateResource(resolver, newPath, 
> props);
> resolver.delete(jobResource);
> resolver.commit();
> {code}
> and the getOrCreateResource is internally doing a commit on the resolver 
> (autoCommit = true). So in the end there are 2 commits while only a single 
> commit would be sufficient.
> Removing these "double" commits could avoid a few write operations on the 
> repository.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6823) Use Timer instead of scheduler for delayed execution

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6823.
-
Resolution: Fixed
  Assignee: Carsten Ziegeler

Adjusted in rev 1793757

> Use Timer instead of scheduler for delayed execution
> 
>
> Key: SLING-6823
> URL: https://issues.apache.org/jira/browse/SLING-6823
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.4
>
>
> Currently, the scheduler is used in some places to delay some execution. As 
> this execution is intended to be run at the delayed time, it is not optimal 
> to rely on the scheduler, especially as the scheduler is resource constraint 
> (by its pool).
> We could simply use java's Timer for this. Affected classes are:
> JobManagerConfiguration (2 occurences)
> JobQueueImpl (1 occurence)
> We can then also remove the scheduler from QueueServices



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6824) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6824.
-
Resolution: Fixed

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6824
> URL: https://issues.apache.org/jira/browse/SLING-6824
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.4
>
>
> We should check the dependencies and move to the R6 OSGi annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6824) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996326#comment-15996326
 ] 

Carsten Ziegeler commented on SLING-6824:
-

Updated the code in rev 1793745

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6824
> URL: https://issues.apache.org/jira/browse/SLING-6824
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.4
>
>
> We should check the dependencies and move to the R6 OSGi annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6824) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-6824:
---

Assignee: Carsten Ziegeler

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6824
> URL: https://issues.apache.org/jira/browse/SLING-6824
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.4
>
>
> We should check the dependencies and move to the R6 OSGi annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6826) i18n: Supported nested keys in JSON i18n files

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996309#comment-15996309
 ] 

Stefan Seifert commented on SLING-6826:
---

my use case:
* sling and some downstream applications use the english text as i18n key for 
translations. in this case nor hierarchy is required or useful.
* but we always have avoided this pattern in our application because:
** whenever the english text changes (for whatever reason), the key contract is 
broken and all translations have to be touched as well
** it is not possible to "namespace" i18n keys to separate different 
applications deployed by different parties on the same instance
* so we use a more traditional  approach for our i18n keys like 
"...".
* the master files we create with the original english texts (and sometimes 
also the translations if the file is not too big) are maintained "by hand" by 
the developer. in this case it is very helpful to use nested hierarchies to 
avoid redundancy in the keys and cluster keys that belong to each other 
together.

example:
{code:javascript}
{
  "application1": {
"section1": {
  "component1": {
"key1": "value1",
"key2": "value2"
  }
}
  }
}
{code}

> i18n: Supported nested keys in JSON i18n files
> --
>
> Key: SLING-6826
> URL: https://issues.apache.org/jira/browse/SLING-6826
> Project: Sling
>  Issue Type: New Feature
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Stefan Seifert
>
> i18n supports resource files stored as JSON binary files in the repository:
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#json-file-based
> currently nested key structures are not really supported - from the docs 
> page: 
> {quote}
> The parser will take any "key":"value" pair in the JSON file, including those 
> in nested objects or arrays. Normally, a dictionary will be just a single 
> json object = hash map though.
> {quote}
> that means that these two JSON example will produc the same result:
> A)
> {code:javascript}
> {
>   "key1": "value1",
>   "key2": "value2",
>   "key3": "value3"
> }
> {code}
> B)
> {code:javascript}
> {
>   "level1": {
> "key1": "value1",
> "level2: {
>   "key2": "value2",
>   "level3": {
> "key3": "value3"
>   }
> }
>   }
> }
> {code}
> in both cases the keys are just
> {noformat}
> key1
> key2
> key3
> {noformat}
> the goal of this ticket is to interpret the nested JSON object structure as 
> parts of the i18n keys, so that example B would produce these keys:
> {noformat}
> level1.key1
> level1.level2.key2
> level1.level2.level3.key3
> {noformat}
> as statet in the documentation in most cases people will only use the JSON as 
> key/value map file with no hierarchies at all. in this case the result is the 
> same. but if someone used hierarchies this ticket will create a backward 
> compatibility issue. i will start a discussion on the sling-dev list about 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)