[jira] [Commented] (SLING-6826) i18n: Supported nested keys in JSON i18n files

2017-05-05 Thread Alexander Klimetschek (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998790#comment-15998790
 ] 

Alexander Klimetschek commented on SLING-6826:
--

{quote}this "((comment))" concept seems to be an AEM-only concept, not part of 
sling{quote}
It doesn't have to, it just needs to use this convention in the dictionary, and 
thus frees the Sling i18n layer from this complexity and allows different apps 
to use different approaches, if they want.

{quote}the maven tool produced the flat json file in the target folder, not in 
the source folder{quote}
This seems like something easy to change in the tool, no?

I just have the feeling that someone else might have different ideas on how 
their json should look like in their development process and then this should 
be added to sling i18n as well. Or your development flow and desired json 
source format changes in the future.

IMO there should be a clear distinction between what the source translation 
files are (such as your nested json, or in AEM we extract XLIFF from the source 
code) and the _delivery_ dictionary files that sling i18n can pick up. The 
latter should be kept as simple as possible in a key value format, as that's 
also how java ResourceBundles "think" as well (we also explicitly designed the 
((comment)) feature so that it does not impact sling i18n).

This way we keep these more fluctuating things (source file formats) out of 
sling i18n and don't have to adopt it constantly.

> i18n: Supported nested keys in JSON i18n files
> --
>
> Key: SLING-6826
> URL: https://issues.apache.org/jira/browse/SLING-6826
> Project: Sling
>  Issue Type: New Feature
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Stefan Seifert
>
> i18n supports resource files stored as JSON binary files in the repository:
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#json-file-based
> currently nested key structures are not really supported - from the docs 
> page: 
> {quote}
> The parser will take any "key":"value" pair in the JSON file, including those 
> in nested objects or arrays. Normally, a dictionary will be just a single 
> json object = hash map though.
> {quote}
> that means that these two JSON example will produc the same result:
> A)
> {code:javascript}
> {
>   "key1": "value1",
>   "key2": "value2",
>   "key3": "value3"
> }
> {code}
> B)
> {code:javascript}
> {
>   "level1": {
> "key1": "value1",
> "level2: {
>   "key2": "value2",
>   "level3": {
> "key3": "value3"
>   }
> }
>   }
> }
> {code}
> in both cases the keys are just
> {noformat}
> key1
> key2
> key3
> {noformat}
> the goal of this ticket is to interpret the nested JSON object structure as 
> parts of the i18n keys, so that example B would produce these keys:
> {noformat}
> level1.key1
> level1.level2.key2
> level1.level2.level3.key3
> {noformat}
> as statet in the documentation in most cases people will only use the JSON as 
> key/value map file with no hierarchies at all. in this case the result is the 
> same. but if someone used hierarchies this ticket will create a backward 
> compatibility issue. i will start a discussion on the sling-dev list about 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998718#comment-15998718
 ] 

Robert Munteanu commented on SLING-6800:


I don't see a huge problem as it probably does not block anyone. However, we 
won't be able to perform a release. If you prefer, I can revert the patch and 
perform a release without switching to the OSGi R6 annotations.

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6826) i18n: Supported nested keys in JSON i18n files

2017-05-05 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998577#comment-15998577
 ] 

Stefan Seifert commented on SLING-6826:
---

thanks for the feedback. the general concept of using natural text for i18n 
keys has several pros and cons, let's not discuss it here further.
basename support is afaik not supported everywhere, e.g. in htl/sightly i18n 
and AEM dialogs it's not supported.
this "((comment))" concept seems to be an AEM-only concept, not part of sling 
(also htl/sightly supports it with "hint").

coming back to the ticket itself:

bq. Is having a plain json dictionary like this instead not feasible?
using a flat list of keys with "." as separator is semantically identically to 
the JSON hierarchy with nested objects. tools that generate the json can always 
decide to generate only the flat list, with the same result. but yes, the tools 
need to be able to parse the nested hierarchy if we introduce it. it would be 
nice to have the hierarchy support to keep the manual maintained i18n files 
compact and easy editable.

bq. You could build a little preprocessor that would convert the nested 
dictionaries into the plain json format for example, as part of build tooling.
this does already exist: http://wcm.io/tooling/maven/plugins/i18n-maven-plugin/
although this currently only produces the "old i18n format" with one node per 
i18n key, it would be easy to add output for the flat json format.
but the problem is that this does not work together with mounting the 
application source directory with Sling-Initial-Content with the file system 
resource provider - the maven tool produced the flat json file in the target 
folder, not in the source folder. but the file system resource provider mounts 
the source folder, so there it finds only the nested json file.

> i18n: Supported nested keys in JSON i18n files
> --
>
> Key: SLING-6826
> URL: https://issues.apache.org/jira/browse/SLING-6826
> Project: Sling
>  Issue Type: New Feature
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Stefan Seifert
>
> i18n supports resource files stored as JSON binary files in the repository:
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#json-file-based
> currently nested key structures are not really supported - from the docs 
> page: 
> {quote}
> The parser will take any "key":"value" pair in the JSON file, including those 
> in nested objects or arrays. Normally, a dictionary will be just a single 
> json object = hash map though.
> {quote}
> that means that these two JSON example will produc the same result:
> A)
> {code:javascript}
> {
>   "key1": "value1",
>   "key2": "value2",
>   "key3": "value3"
> }
> {code}
> B)
> {code:javascript}
> {
>   "level1": {
> "key1": "value1",
> "level2: {
>   "key2": "value2",
>   "level3": {
> "key3": "value3"
>   }
> }
>   }
> }
> {code}
> in both cases the keys are just
> {noformat}
> key1
> key2
> key3
> {noformat}
> the goal of this ticket is to interpret the nested JSON object structure as 
> parts of the i18n keys, so that example B would produce these keys:
> {noformat}
> level1.key1
> level1.level2.key2
> level1.level2.level3.key3
> {noformat}
> as statet in the documentation in most cases people will only use the JSON as 
> key/value map file with no hierarchies at all. in this case the result is the 
> same. but if someone used hierarchies this ticket will create a backward 
> compatibility issue. i will start a discussion on the sling-dev list about 
> this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6817) jcr-mock: Minimal support for JCR Session attributes

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6817.
-

> jcr-mock: Minimal support for JCR Session attributes
> 
>
> Key: SLING-6817
> URL: https://issues.apache.org/jira/browse/SLING-6817
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.2.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: mocks
> Fix For: Testing JCR Mock 1.3.0
>
>
> we should add minimal support for JCR session attribute methods:
> * getAttribute
> * getAttributeNames
> they never return any attributes, but should not throw an 
> UnsupportedOperationException.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6811) osgi-mock: Support ServiceFactory and System Bundle

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6811.
-

> osgi-mock: Support ServiceFactory and System Bundle
> ---
>
> Key: SLING-6811
> URL: https://issues.apache.org/jira/browse/SLING-6811
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: mocks
> Fix For: Testing OSGi Mock 2.3.0
>
>
> * when registering OSGi services it is possible to provide ServiceFactory 
> instances instead of the service instance directly.
> * the system bundle can be obtained from the bundleContext via 
> getBundle(SYSTEM_BUNDLE_ID) or getBundle(SYSTEM_BUNDLE_LOCATION)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6812) sling-mock: Lazy initialization of ResourceResolverFactory

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6812.
-

> sling-mock: Lazy initialization of ResourceResolverFactory
> --
>
> Key: SLING-6812
> URL: https://issues.apache.org/jira/browse/SLING-6812
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 2.2.6
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: mocks
> Fix For: Testing Sling Mock 2.2.8
>
>
> latest version of sling resource resolver implementation do not register the 
> ResourceResolverFactory unless at least one ResourceProvider instance is 
> registered.
> when using ResourceResolverType.NONE this did not work because the 
> ResourceResolverFactory was tried to initialize before starting the unit 
> test. doing this lazily on first acccess solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6813) sling-mock: Make compatible with org.apache.sling.jcr.resource 3.0.0

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6813.
-

> sling-mock: Make compatible with org.apache.sling.jcr.resource 3.0.0
> 
>
> Key: SLING-6813
> URL: https://issues.apache.org/jira/browse/SLING-6813
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 2.2.6
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: mocks
> Fix For: Testing Sling Mock 2.2.8
>
>
> the deprecated JCR resource API and PathMapper service was removed in 
> org.apache.sling.jcr.resource 3.0.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6814) jcr-mock: Implement JackrabbitObservationManager

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6814.
-

> jcr-mock: Implement JackrabbitObservationManager
> 
>
> Key: SLING-6814
> URL: https://issues.apache.org/jira/browse/SLING-6814
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.2.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Testing JCR Mock 1.3.0
>
>
> the MockObservationManager should also implement 
> JackrabbitObservationManager, becaus otherwise the latest JCR resource 
> implementation complains about it.
> (it still just ignores all listeners that are registered)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6821) Context-Aware Config: Management API - Default value for sling:configCollectionInherit for implicit inheritance

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6821.
-

> Context-Aware Config: Management API - Default value for 
> sling:configCollectionInherit for implicit inheritance
> ---
>
> Key: SLING-6821
> URL: https://issues.apache.org/jira/browse/SLING-6821
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.3.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.4.0
>
>
> the property "sling:configCollectionInherit" for a configuration collection 
> should also be set to "true" in the Management API when the resource 
> collection is inherited implicitly, that means is inherited because no 
> configuration collection resource exists for the configuration path assigned 
> to the current configuration resource.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6789) Support CAConfig Impl 1.4.0

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6789.
-

> Support CAConfig Impl 1.4.0
> ---
>
> Key: SLING-6789
> URL: https://issues.apache.org/jira/browse/SLING-6789
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Context-Aware Configuration Mock Plugin 1.1.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Context-Aware Configuration Mock Plugin 1.2.0
>
>
> the mock plugin should support the latest implementation details of CAConfig 
> Impl 1.4.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6688) Replace commons.json usage in org.apache.sling.caconfig.impl

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6688.
-

> Replace commons.json usage in org.apache.sling.caconfig.impl
> 
>
> Key: SLING-6688
> URL: https://issues.apache.org/jira/browse/SLING-6688
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.2.0
>Reporter: Karl Pauls
>Assignee: Stefan Seifert
> Fix For: Context-Aware Configuration Impl 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6788) Context-Aware Config: Make filtered property names for configuration persistence configurable

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6788.
-

> Context-Aware Config: Make filtered property names for configuration 
> persistence configurable
> -
>
> Key: SLING-6788
> URL: https://issues.apache.org/jira/browse/SLING-6788
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.3.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.4.0
>
>
> currently, a hard-coded list of filtered property names is applied in the 
> configuration manager implementation and the default configuration 
> persistence implementation:
> {noformat}
> jcr:primaryType
> jcr:mixinTypes
> jcr:created
> jcr:createdBy
> jcr:lastModified
> jcr:lastModifiedBy
> jcr:uuid
> {noformat}
> this list should be made configurable because in upstream applications more 
> properties might need to be filtered e.g. to track replication status.
> the possibility to filter a list of property names by name or regex should be 
> made accessible in the ConfigurationManager API that is part of the 
> Management API so other configuration persistence applications may use it as 
> well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6820) Context-Aware Config: Management API - Provide ConfigurationData.isInherited

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-6820.
-

> Context-Aware Config: Management API - Provide ConfigurationData.isInherited
> 
>
> Key: SLING-6820
> URL: https://issues.apache.org/jira/browse/SLING-6820
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.3.2
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.4.0
>
>
> the ConfigurationData interface of the Management API should provide an 
> "isInherited" method to inform whether the whole configuration singleton 
> resource or configuration collection item was inherited or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[RESULT] [VOTE] Release Apache Sling Testing JCR Mock 1.3.0, OSGi Mock 2.3.0, Sling Mock 2.2.8

2017-05-05 Thread Stefan Seifert
Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

stefan



[RESULT] [VOTE] Release Apache Sling Context-Aware Configuration Impl 1.4.0, Context-Aware Configuration Mock Plugin 1.2.0

2017-05-05 Thread Stefan Seifert
Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Daniel Klco, Robert Munteanu

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

stefan



[jira] [Updated] (SLING-6835) Switch HealthChecks to OSGi R6 annotations and get rid of maven-scr-plugin

2017-05-05 Thread Konrad Windszus (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-6835:
---
Fix Version/s: Health Check Support 1.0.6

> Switch HealthChecks to OSGi R6 annotations and get rid of maven-scr-plugin
> --
>
> Key: SLING-6835
> URL: https://issues.apache.org/jira/browse/SLING-6835
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Affects Versions: Health Check Support 1.0.4, Health Check samples 1.0.6, 
> Health Check Core 1.2.6
>Reporter: Konrad Windszus
> Fix For: Health Check Support 1.0.6
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6835) Switch HealthChecks to OSGi R6 annotations and get rid of maven-scr-plugin

2017-05-05 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-6835:
--

 Summary: Switch HealthChecks to OSGi R6 annotations and get rid of 
maven-scr-plugin
 Key: SLING-6835
 URL: https://issues.apache.org/jira/browse/SLING-6835
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Affects Versions: Health Check Core 1.2.6, Health Check samples 1.0.6, 
Health Check Support 1.0.4
Reporter: Konrad Windszus






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998419#comment-15998419
 ] 

Justin Edelson commented on SLING-6804:
---

[~henzlerg] I have several concerns with your design and the implementation 
resulting from it.

1. It does not differentiate between names and tags. There is nothing currently 
documented that I can find discouraging the use of conflicting names between 
tags and names so the wrong checks may be selected, i.e. I want a HC named 
"foo" but I actually get the HC with that name and all of the HCs tagged "foo".
2. It misses the key point that names should always be ORd whereas tags can be 
ORd or ANDd. Requesting names "foo" and "bar" should return both whereas tags 
"foo" and "bar" can either be the intersection or the union, depending upon the 
user requests. Unless we want tags to always be ORd, but that is a 
non-backwards compatible behavioral change.
3. Changing the behavior of the implementation in this way violates the 
contract expressed by the interface. The interface says "Executes all health 
checks with the supplied list of tags.". Now that isn't the case. If we change 
the contract, we still need to increment the API version. The advantage of 
doing this in the manner I provided is that the change is backwards compatible 
to consumers.

FWIW, I disagree with the analogy to Google. Google's operators are explicitly 
named (e.g. {{site: mysite.com}}) or determined based on a prefix (e.g. 
{{$500}}).

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, 
> SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6816) Model validation should handle :remove sections correctly

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6816.
---

> Model validation should handle :remove sections correctly
> -
>
> Key: SLING-6816
> URL: https://issues.apache.org/jira/browse/SLING-6816
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Sling Provisioning Model 1.8.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Sling Provisioning Model 1.8.2
>
>
> If a model is validated and contains a :remove section (which is valid) and 
> this section removes configurations, then validation fails as the removed 
> configurations do not have properties.
> As such a section is valid, it should be accordingly handled in validate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6819) Includes are removed from attached model

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6819.
---

> Includes are removed from attached model
> 
>
> Key: SLING-6819
> URL: https://issues.apache.org/jira/browse/SLING-6819
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.7.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Slingstart Maven Plugin 1.7.6
>
>
> In 1.7.4 the references to included models are unfortunately removed from the 
> attached artifact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[VOTE RESULT] Release Apache Sling Slingstart Maven Plugin 1.7.6 and Provisioning Model 1.8.2

2017-05-05 Thread Carsten Ziegeler
The vote passes with three binding +1 votes

Thanks

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Servlets Resolver version 2.4.12

2017-05-05 Thread Carsten Ziegeler
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Servlets Resolver version 2.4.12

2017-05-05 Thread Stefan Egli
+1

Cheers,
Stefan

On 05/05/17 16:27, "Konrad Windszus"  wrote:

>Hi, 
>We solved 8 issues in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12338894
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1705/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>Usage:
>sh check_staged_release.sh 1705 /tmp/sling-staging
>  
>Please vote to approve this release:
>[ ] +1 Approve the release
>[ ] 0 Don't care 
>[ ] -1 Don't release, because ...
>This majority vote is open for at least 72 hours.
>Thanks,
>Konrad




[VOTE] Release Apache Sling Servlets Resolver version 2.4.12

2017-05-05 Thread Konrad Windszus
Hi, 
We solved 8 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338894

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1705/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh 
Usage:
sh check_staged_release.sh 1705 /tmp/sling-staging 
  
Please vote to approve this release: 
[ ] +1 Approve the release
[ ] 0 Don't care 
[ ] -1 Don't release, because ... 
This majority vote is open for at least 72 hours.
Thanks,
Konrad

Re: [VOTE] Release Apache Sling Scripting HTL Java Compiler 1.0.10, Apache Sling Scripting HTL Engine 1.0.34, Apache Sling Scripting HTL JS Use Provider 1.0.22

2017-05-05 Thread Karl Pauls
+1

regards,

Karl

On Fri, May 5, 2017 at 3:36 PM, Stefan Egli  wrote:
> +1
>
> Cheers,
> Stefan
>
> On 05/05/17 15:19, "Radu Cotescu"  wrote:
>
>>Hi,
>>
>>We solved 12 issues in these releases:
>>https://issues.apache.org/jira/browse/SLING/fixforversion/12340045
>>https://issues.apache.org/jira/browse/SLING/fixforversion/12340044
>>https://issues.apache.org/jira/browse/SLING/fixforversion/12339952
>>
>>Staging repository:
>>https://repository.apache.org/content/repositories/orgapachesling-1704/
>>
>>You can use this UNIX script to download the release and verify the
>>signatures:
>>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>>
>>Usage:
>>sh check_staged_release.sh 1704 /tmp/sling-staging
>>
>>Please vote to approve this release:
>>
>>  [ ] +1 Approve the release
>>  [ ]  0 Don't care
>>  [ ] -1 Don't release, because ...
>>
>>This majority vote is open for at least 72 hours.
>>
>>Cheers,
>>Radu
>
>



-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Comment Edited] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998336#comment-15998336
 ] 

Nicolas Peltier edited comment on SLING-6800 at 5/5/17 1:42 PM:


thx [~rombert], had a quick look and it's not trivial (at least to me :-D), 
will have a longer look on it this week end. Is it ok to have a contrib 
extension not building?


was (Author: npeltier):
thx [~rombert], had a quick look and it's not trivial (at least to me :-D), 
will have a longer look on it this week end. Is it ok to have a contrib 
extension not working?

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998336#comment-15998336
 ] 

Nicolas Peltier commented on SLING-6800:


thx [~rombert], had a quick look and it's not trivial (at least to me :-D), 
will have a longer look on it this week end. Is it ok to have a contrib 
extension not working?

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Georg Henzler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-6834:
-
Description: 
For both Jenkins pipelines and Docker container setups it would be nice to have 
a simple text based response format that can be printed to the log (to have 
them include more verbose information). 

The existing formats html and json are not very readable in a log file, the 
existing format txt is only printing OK, WARN or CRITICAL (minimised response 
entity optimised for load balancer usage). 

I would propose to add a new format {{.verbose.txt}} (was intially {{exttxt}}). 

  was:
For both Jenkins pipelines and Docker container setups it would be nice to have 
a simple text based response format that can be printed to the log (to have 
them include more verbose information). 

The existing formats html and json are not very readable in a log file, the 
existing format txt is only printing OK, WARN or CRITICAL (minimised response 
entity optimised for load balancer usage). 

I would propose to add a new extension {{exttxt}}. 


> Introduce a new, verbose and text-based output format that can be used for 
> console based applications
> -
>
> Key: SLING-6834
> URL: https://issues.apache.org/jira/browse/SLING-6834
> Project: Sling
>  Issue Type: New Feature
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.6
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>
> For both Jenkins pipelines and Docker container setups it would be nice to 
> have a simple text based response format that can be printed to the log (to 
> have them include more verbose information). 
> The existing formats html and json are not very readable in a log file, the 
> existing format txt is only printing OK, WARN or CRITICAL (minimised response 
> entity optimised for load balancer usage). 
> I would propose to add a new format {{.verbose.txt}} (was intially 
> {{exttxt}}). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998333#comment-15998333
 ] 

Georg Henzler commented on SLING-6834:
--

[~kwin] Good suggestion, although the servlet is not a sling servlet but a 
whiteboard servlet (that's why I didn't suggest it in the first place) it is 
easy enough to mimick the selector behaviour. Will move forward implementing 
the {{.verbose.txt}} suffix. 

> Introduce a new, verbose and text-based output format that can be used for 
> console based applications
> -
>
> Key: SLING-6834
> URL: https://issues.apache.org/jira/browse/SLING-6834
> Project: Sling
>  Issue Type: New Feature
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.6
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>
> For both Jenkins pipelines and Docker container setups it would be nice to 
> have a simple text based response format that can be printed to the log (to 
> have them include more verbose information). 
> The existing formats html and json are not very readable in a log file, the 
> existing format txt is only printing OK, WARN or CRITICAL (minimised response 
> entity optimised for load balancer usage). 
> I would propose to add a new extension {{exttxt}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Release Apache Sling Scripting HTL Java Compiler 1.0.10, Apache Sling Scripting HTL Engine 1.0.34, Apache Sling Scripting HTL JS Use Provider 1.0.22

2017-05-05 Thread Stefan Egli
+1

Cheers,
Stefan

On 05/05/17 15:19, "Radu Cotescu"  wrote:

>Hi,
>
>We solved 12 issues in these releases:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340045
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340044
>https://issues.apache.org/jira/browse/SLING/fixforversion/12339952
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1704/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1704 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Cheers,
>Radu




Re: [VOTE] Release Apache Sling Scripting HTL Java Compiler 1.0.10, Apache Sling Scripting HTL Engine 1.0.34, Apache Sling Scripting HTL JS Use Provider 1.0.22

2017-05-05 Thread Carsten Ziegeler
+1


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[VOTE] Release Apache Sling Scripting HTL Java Compiler 1.0.10, Apache Sling Scripting HTL Engine 1.0.34, Apache Sling Scripting HTL JS Use Provider 1.0.22

2017-05-05 Thread Radu Cotescu
Hi,

We solved 12 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340045
https://issues.apache.org/jira/browse/SLING/fixforversion/12340044
https://issues.apache.org/jira/browse/SLING/fixforversion/12339952

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1704/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1704 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Radu


Re: Heads-up: Releases for org.json removal (i.e., SLING-6679)

2017-05-05 Thread Stefan Egli
Hi Karl,

On 05/05/17 13:31, "Karl Pauls"  wrote:

>i would like to release the following list of 13 bundles in order to
>finish SLING-6679:
>
>...
>org.apache.sling.discovery.oak
>org.apache.sling.discovery.impl
>org.apache.sling.discovery.commons
>org.apache.sling.discovery.base
>...

I've fixed one open issue that I wanted to have included in the next
discovery release and move the others to future versions. So +1 from my
side for the discovery bundles.

Cheers,
Stefan




[jira] [Closed] (SLING-6689) Replace commons.json usage in org.apache.sling.discovery.base

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-6689.
--

> Replace commons.json usage in org.apache.sling.discovery.base
> -
>
> Key: SLING-6689
> URL: https://issues.apache.org/jira/browse/SLING-6689
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Discovery Base 1.1.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>  Labels: patch-available
> Fix For: Discovery Base 1.1.4
>
> Attachments: SLING-6689.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-5732) [discovery] Avoid empty save in AnnouncementRegistry

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-5732.
--

> [discovery] Avoid empty save in AnnouncementRegistry
> 
>
> Key: SLING-5732
> URL: https://issues.apache.org/jira/browse/SLING-5732
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Base 1.1.2
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Base 1.1.6
>
>
> [AnnouncementRegistryImpl.checkExpiredAnnouncements|https://github.com/apache/sling/blob/c9e59667d8f9cd698bc33a51f3e6a22e85d4a952/bundles/extensions/discovery/base/src/main/java/org/apache/sling/discovery/base/connectors/announcement/AnnouncementRegistryImpl.java#L523]
>  always does a {{resourceResolver.commit()}} - even if nothing has really 
> changed. This empty save doesn't do any harm but could probably be avoided.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-5918) org.apache.sling.discovery.impl.cluster.voting.VotingHandlerTest.testFastConcurrentVotesFiveNodes fails with NPE

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-5918.
--

> org.apache.sling.discovery.impl.cluster.voting.VotingHandlerTest.testFastConcurrentVotesFiveNodes
>  fails with NPE
> 
>
> Key: SLING-5918
> URL: https://issues.apache.org/jira/browse/SLING-5918
> Project: Sling
>  Issue Type: Bug
>Reporter: Ian Boston
>Assignee: Stefan Egli
>  Labels: sling-IT
> Fix For: Discovery Impl 1.2.10
>
> Attachments: 
> org.apache.sling.discovery.impl.cluster.voting.VotingHandlerTest.txt, 
> TEST-org.apache.sling.discovery.impl.cluster.voting.VotingHandlerTest.xml
>
>
> testFastConcurrentVotesFiveNodes fails on JDK8 build. see attached text XML 
> output.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6020) Reduce log error 'No Descriptor value available' down to warn

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-6020.
--

> Reduce log error 'No Descriptor value available' down to warn
> -
>
> Key: SLING-6020
> URL: https://issues.apache.org/jira/browse/SLING-6020
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Oak 1.2.8
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Oak 1.2.10
>
>
> During OSGi service re-registration it can happen that the following 
> exception occurrs: 
> {noformat}java.lang.Exception: No Descriptor value available
>   at 
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:45)
>   at 
> org.apache.sling.discovery.oak.cluster.OakClusterViewService.getLocalClusterView(OakClusterViewService.java:111)
>   at 
> org.apache.sling.discovery.base.commons.BaseDiscoveryService.getTopology(BaseDiscoveryService.java:77)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.checkForTopologyChange(OakDiscoveryService.java:657)
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker.discoveryLiteCheck(OakViewChecker.java:232)
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker.access$000(OakViewChecker.java:64)
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker$1.run(OakViewChecker.java:208)
>   at 
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.safelyRun(PeriodicBackgroundJob.java:86)
>   at 
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.run(PeriodicBackgroundJob.java:77)
>   at java.lang.Thread.run(Unknown Source){noformat}
> {noformat}
> In this case a log ERROR is perhaps a bit loud. 
> Reduce that to log WARN (without the exception)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-5231) Remove getAdministrativeResourceResolver() usage from Discovery components

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-5231.
--

> Remove getAdministrativeResourceResolver() usage from Discovery components
> --
>
> Key: SLING-5231
> URL: https://issues.apache.org/jira/browse/SLING-5231
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Impl 1.2.0, Discovery Commons 1.0.2, Discovery 
> Base 1.0.2, Discovery Oak 1.0.2
>Reporter: Antonio Sanso
>Assignee: Stefan Egli
> Fix For: Discovery Base 1.1.6, Discovery Impl 1.2.10, Discovery 
> Commons 1.0.18, Discovery Oak 1.2.16
>
> Attachments: base-patch.txt, commons-patch.txt, impl-patch.txt, 
> oak-patch.txt
>
>
> * {{org.apache.sling.discovery.base}}: 6
> * {{org.apache.sling.discovery.commons}}: 3
> * {{org.apache.sling.discovery.oak}}: 4
> total of 13 occurrences 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-4135) Make discovery implementation independent from JCR

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4135:
---
Fix Version/s: (was: Discovery Impl 1.2.12)
   Discovery Impl 1.2.14

> Make discovery implementation independent from JCR
> --
>
> Key: SLING-4135
> URL: https://issues.apache.org/jira/browse/SLING-4135
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Carsten Ziegeler
> Fix For: Discovery Impl 1.2.14
>
>
> There are only a few calls to the JCR api - in order to make it completely 
> use just the Sling API these places should be changed to the Sling API as 
> well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-5060) use virtual clock for discovery tests

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-5060:
---
Fix Version/s: (was: Discovery Impl 1.2.12)
   Discovery Impl 1.2.14

> use virtual clock for discovery tests
> -
>
> Key: SLING-5060
> URL: https://issues.apache.org/jira/browse/SLING-5060
> Project: Sling
>  Issue Type: Test
>  Components: Extensions
>Affects Versions: Discovery Impl 1.1.6
>Reporter: Stefan Egli
> Fix For: Discovery Impl 1.2.14
>
>
> Currently there are test failures on different CI instances due to the fact 
> that they sometimes run rather slow vs what is expected during tests. This 
> badly affects test stability.
> An alternative to always increase the timing further and further whenever a 
> test failure is encountered, is to use a virtual clock instead. This would 
> allow to make very precise tests in a very fast manner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-4380) Use sling mocks for the discovery impl tests

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4380:
---
Fix Version/s: (was: Discovery Impl 1.2.12)
   Discovery Impl 1.2.14

> Use sling mocks for the discovery impl tests
> 
>
> Key: SLING-4380
> URL: https://issues.apache.org/jira/browse/SLING-4380
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Testing
>Affects Versions: Discovery Impl 1.0.12
>Reporter: Robert Munteanu
> Fix For: Discovery Impl 1.2.14
>
>
> The org.apache.sling.discovery.impl has its own utility mocks in 
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/discovery/impl/src/test/java/org/apache/sling/discovery/impl/setup/
>  . Most of these can be replaced by the new Sling mocks.
> The benefits would be:
> - less maintenance for the discovery impl project
> - more exposure/coverage for the Sling mocks



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-5598) Exclude slow tests by default with assume(sling.slow.tests.enabled)

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-5598:
---
Fix Version/s: (was: Discovery Oak 1.2.18)
   (was: Discovery Impl 1.2.12)
   (was: Discovery Base 1.1.8)
   (was: Discovery Commons 1.0.20)
   Discovery Oak 1.2.20
   Discovery Impl 1.2.14
   Discovery Base 1.1.10
   Discovery Commons 1.0.22

> Exclude slow tests by default with assume(sling.slow.tests.enabled) 
> 
>
> Key: SLING-5598
> URL: https://issues.apache.org/jira/browse/SLING-5598
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Affects Versions: Discovery Impl 1.2.6, Discovery Base 1.1.2, Discovery 
> Commons 1.0.10, Discovery Oak 1.2.6
>Reporter: Stefan Egli
> Fix For: Discovery Commons 1.0.22, Discovery Base 1.1.10, 
> Discovery Impl 1.2.14, Discovery Oak 1.2.20
>
> Attachments: SLING-5598-commons-testing.patch, 
> SLING-5598-discovery.patch
>
>
> As suggested by [~bdelacretaz] on [the 
> list|http://markmail.org/message/yad5awqg53epk3ck] we should improve test 
> duration (ideally 1-2min per bundle max, 10-15min overall). While they are 
> not yet improved however, slow tests should be excluded by default and run 
> only if enabled explicitly. Here's an example {{@Before}} method to achieve 
> that:
> {noformat}
> @Before
> public void checkSlowTests() {
> assumeNotNull(System.getProperty("sling.slow.tests.enabled"));
> }
> {noformat}
> and to enable the slow tests you do: {{mvn -Dsling.slow.tests.enabled=true 
> clean test}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6489) discovery.oak: log less frequent when slingId is not (yet) mapped

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-6489.

Resolution: Won't Fix

I'm hesitant to implement this as it might hide useful information in an error 
case. Hence closing as wont fix for now.

> discovery.oak: log less frequent when slingId is not (yet) mapped
> -
>
> Key: SLING-6489
> URL: https://issues.apache.org/jira/browse/SLING-6489
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Oak 1.2.16
>Reporter: Stefan Egli
> Fix For: Discovery Oak 1.2.18
>
>
> When connecting an oak-run in read-write mode to a documentMk based cluster, 
> discovery.oak complains with the following info messages repeatedly:
> {noformat}
> 2017-01-27 17:32:09,970 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
> NO_ESTABLISHED_VIEW] 
> org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
> slingId mapped for clusterNodeId=2 
> 2017-01-27 17:32:11,971 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
> clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
> 2017-01-27 17:32:11,971 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
> NO_ESTABLISHED_VIEW] 
> org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
> slingId mapped for clusterNodeId=2 
> 2017-01-27 17:32:13,972 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
> clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
> 2017-01-27 17:32:13,972 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
> NO_ESTABLISHED_VIEW] 
> org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
> slingId mapped for clusterNodeId=2 
> 2017-01-27 17:32:15,973 INFO NA 
> [discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
>  o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
> clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
> {noformat}
> while this is 'by design' (being that oak-run represents only half of the 
> expected discovery.oak/discovery-lite stack) we could lower the frequency of 
> these messages to keep the log file cleaner. Perhaps log only every 5-10min.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6809) improve discovery's TopologyView toString

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-6809.

Resolution: Fixed

> improve discovery's TopologyView toString
> -
>
> Key: SLING-6809
> URL: https://issues.apache.org/jira/browse/SLING-6809
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Base 1.1.6
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Base 1.1.8
>
>
> Consider the following log message:
> {noformat}... 
> org.apache.sling.discovery.commons.providers.base.ViewStateManagerImpl 
> enqueueForAll: sending topologyEvent TopologyEvent [type=PROPERTIES_CHANGED, 
> oldView=DefaultTopologyView[current=false, num=5, 
> instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]],
>  newView=DefaultTopologyView[current=true, num=5, 
> instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]]],
>  ...{noformat}
> This output is misleading as it does not show which instance belongs to which 
> cluster. That output (coming from {{DefaultTopologyView.toString()}}) should 
> instead group the instances by clusterId to make this clear.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6809) improve discovery's TopologyView toString

2017-05-05 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-6809:
---
Affects Version/s: Discovery Base 1.1.6
Fix Version/s: Discovery Base 1.1.8

toString improved in http://svn.apache.org/viewvc?rev=1794027=rev

> improve discovery's TopologyView toString
> -
>
> Key: SLING-6809
> URL: https://issues.apache.org/jira/browse/SLING-6809
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Discovery Base 1.1.6
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Base 1.1.8
>
>
> Consider the following log message:
> {noformat}... 
> org.apache.sling.discovery.commons.providers.base.ViewStateManagerImpl 
> enqueueForAll: sending topologyEvent TopologyEvent [type=PROPERTIES_CHANGED, 
> oldView=DefaultTopologyView[current=false, num=5, 
> instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]],
>  newView=DefaultTopologyView[current=true, num=5, 
> instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]]],
>  ...{noformat}
> This output is misleading as it does not show which instance belongs to which 
> cluster. That output (coming from {{DefaultTopologyView.toString()}}) should 
> instead group the instances by clusterId to make this clear.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Heads-up: Releases for org.json removal (i.e., SLING-6679)

2017-05-05 Thread Karl Pauls
On Fri, May 5, 2017 at 1:58 PM, Konrad Windszus  wrote:
> Can you please include the testing modules as well?
>
> org.apache.sling.testing.junit.core
> org.apache.sling.testing.junit.teleporter

Sure, while I'm at it, should I although release org.apache.sling.testing.tools?

regards,

Karl

> Thanks,
> Konrad
>
>> On 5. May 2017, at 13:31, Karl Pauls  wrote:
>>
>> Hi,
>>
>> i would like to release the following list of 13 bundles in order to
>> finish SLING-6679:
>>
>> org.apache.sling.hc.core
>> org.apache.sling.discovery.oak
>> org.apache.sling.discovery.impl
>> org.apache.sling.discovery.commons
>> org.apache.sling.discovery.base
>> org.apache.sling.adapter
>> org.apache.sling.jcr.jackrabbit.accessmanager
>> org.apache.sling.servlets.get
>> org.apache.sling.scripting.javascript
>> org.apache.sling.servlets.post
>> org.apache.sling.hc.api
>> org.apache.sling.discovery.commons
>> org.apache.sling.discovery.base
>>
>> All of them are either needed because of the org.json/commons.json
>> removal or because they are transitive dependencies.
>>
>> Please let me know if you think /know of reasons why the one or the
>> other can't be released atm. I'll have to wait a little bit anyways
>> because there are some dependencies on ongoing releases but if I don't
>> here anything I will go ahead and cut a release with all 13 in one go.
>>
>> regards,
>>
>> Karl
>> --
>> Karl Pauls
>> karlpa...@gmail.com
>



-- 
Karl Pauls
karlpa...@gmail.com


Re: Heads-up: Releases for org.json removal (i.e., SLING-6679)

2017-05-05 Thread Konrad Windszus
Can you please include the testing modules as well?

org.apache.sling.testing.junit.core
org.apache.sling.testing.junit.teleporter

Thanks,
Konrad

> On 5. May 2017, at 13:31, Karl Pauls  wrote:
> 
> Hi,
> 
> i would like to release the following list of 13 bundles in order to
> finish SLING-6679:
> 
> org.apache.sling.hc.core
> org.apache.sling.discovery.oak
> org.apache.sling.discovery.impl
> org.apache.sling.discovery.commons
> org.apache.sling.discovery.base
> org.apache.sling.adapter
> org.apache.sling.jcr.jackrabbit.accessmanager
> org.apache.sling.servlets.get
> org.apache.sling.scripting.javascript
> org.apache.sling.servlets.post
> org.apache.sling.hc.api
> org.apache.sling.discovery.commons
> org.apache.sling.discovery.base
> 
> All of them are either needed because of the org.json/commons.json
> removal or because they are transitive dependencies.
> 
> Please let me know if you think /know of reasons why the one or the
> other can't be released atm. I'll have to wait a little bit anyways
> because there are some dependencies on ongoing releases but if I don't
> here anything I will go ahead and cut a release with all 13 in one go.
> 
> regards,
> 
> Karl
> -- 
> Karl Pauls
> karlpa...@gmail.com



[jira] [Commented] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998225#comment-15998225
 ] 

Konrad Windszus commented on SLING-6834:


Why not using {{txt}} with an additional selector like {{verbose}}?

> Introduce a new, verbose and text-based output format that can be used for 
> console based applications
> -
>
> Key: SLING-6834
> URL: https://issues.apache.org/jira/browse/SLING-6834
> Project: Sling
>  Issue Type: New Feature
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.6
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>
> For both Jenkins pipelines and Docker container setups it would be nice to 
> have a simple text based response format that can be printed to the log (to 
> have them include more verbose information). 
> The existing formats html and json are not very readable in a log file, the 
> existing format txt is only printing OK, WARN or CRITICAL (minimised response 
> entity optimised for load balancer usage). 
> I would propose to add a new extension {{exttxt}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998203#comment-15998203
 ] 

Georg Henzler commented on SLING-6834:
--

Not sure about the extension {{exttxt}}, I'm happy for better suggestions 
({{txt}} is taken already as mentioned).

> Introduce a new, verbose and text-based output format that can be used for 
> console based applications
> -
>
> Key: SLING-6834
> URL: https://issues.apache.org/jira/browse/SLING-6834
> Project: Sling
>  Issue Type: New Feature
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.6
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>
> For both Jenkins pipelines and Docker container setups it would be nice to 
> have a simple text based response format that can be printed to the log (to 
> have them include more verbose information). 
> The existing formats html and json are not very readable in a log file, the 
> existing format txt is only printing OK, WARN or CRITICAL (minimised response 
> entity optimised for load balancer usage). 
> I would propose to add a new extension {{exttxt}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Georg Henzler (JIRA)
Georg Henzler created SLING-6834:


 Summary: Introduce a new, verbose and text-based output format 
that can be used for console based applications
 Key: SLING-6834
 URL: https://issues.apache.org/jira/browse/SLING-6834
 Project: Sling
  Issue Type: New Feature
  Components: Health Check
Affects Versions: Health Check Core 1.2.6
Reporter: Georg Henzler
Assignee: Georg Henzler


For both Jenkins pipelines and Docker container setups it would be nice to have 
a simply text based response format that can be printed to the log (to have 
them include more verbose information). 

The existing formats html and json are not very readable in a log file, the 
existing format txt is only printing OK, WARN or CRITICAL (minimised response 
entity optimised for load balancer usage). 

I would propose to add a new extension {{exttxt}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-05 Thread Georg Henzler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-6834:
-
Description: 
For both Jenkins pipelines and Docker container setups it would be nice to have 
a simple text based response format that can be printed to the log (to have 
them include more verbose information). 

The existing formats html and json are not very readable in a log file, the 
existing format txt is only printing OK, WARN or CRITICAL (minimised response 
entity optimised for load balancer usage). 

I would propose to add a new extension {{exttxt}}. 

  was:
For both Jenkins pipelines and Docker container setups it would be nice to have 
a simply text based response format that can be printed to the log (to have 
them include more verbose information). 

The existing formats html and json are not very readable in a log file, the 
existing format txt is only printing OK, WARN or CRITICAL (minimised response 
entity optimised for load balancer usage). 

I would propose to add a new extension {{exttxt}}. 


> Introduce a new, verbose and text-based output format that can be used for 
> console based applications
> -
>
> Key: SLING-6834
> URL: https://issues.apache.org/jira/browse/SLING-6834
> Project: Sling
>  Issue Type: New Feature
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.6
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>
> For both Jenkins pipelines and Docker container setups it would be nice to 
> have a simple text based response format that can be printed to the log (to 
> have them include more verbose information). 
> The existing formats html and json are not very readable in a log file, the 
> existing format txt is only printing OK, WARN or CRITICAL (minimised response 
> entity optimised for load balancer usage). 
> I would propose to add a new extension {{exttxt}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6805) Request for negative tag and negative name filtering from health check servlet

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998194#comment-15998194
 ] 

Georg Henzler commented on SLING-6805:
--

[~cgoudie] With the change as proposed in 
https://issues.apache.org/jira/browse/SLING-6804?focusedCommentId=15998028=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15998028
 you would be able to mix and match tags and hc names in both positive and 
negative way in a very flexible way. For instance you can use 
{{/system/health/Name1,Name2,Name3,-ButNeverThisTag.html}}. Is that what you 
were looking for?

> Request for negative tag and negative name filtering from health check servlet
> --
>
> Key: SLING-6805
> URL: https://issues.apache.org/jira/browse/SLING-6805
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>
> AMS has a request to be able to query the health check servlet with a list of 
> named health checks, and a list of tags to remove from the returned list.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Heads-up: Releases for org.json removal (i.e., SLING-6679)

2017-05-05 Thread Karl Pauls
Hi,

i would like to release the following list of 13 bundles in order to
finish SLING-6679:

org.apache.sling.hc.core
org.apache.sling.discovery.oak
org.apache.sling.discovery.impl
org.apache.sling.discovery.commons
org.apache.sling.discovery.base
org.apache.sling.adapter
org.apache.sling.jcr.jackrabbit.accessmanager
org.apache.sling.servlets.get
org.apache.sling.scripting.javascript
org.apache.sling.servlets.post
org.apache.sling.hc.api
org.apache.sling.discovery.commons
org.apache.sling.discovery.base

All of them are either needed because of the org.json/commons.json
removal or because they are transitive dependencies.

Please let me know if you think /know of reasons why the one or the
other can't be released atm. I'll have to wait a little bit anyways
because there are some dependencies on ongoing releases but if I don't
here anything I will go ahead and cut a release with all 13 in one go.

regards,

Karl
-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Georg Henzler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-6804:
-
Attachment: SLING-6804-allow-hc.name-in-hc-urls-simple.patch

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, 
> SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Georg Henzler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-6804:
-
Attachment: (was: SLING-6804-allow-hc.name-in-hc-urls-simple.patch)

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, 
> SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Release Apache Sling Installer Core 3.8.8

2017-05-05 Thread Robert Munteanu
On Fri, 2017-05-05 at 12:06 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling Installer Core 3.8.8

2017-05-05 Thread Karl Pauls
+1

regards,

Karl

On Fri, May 5, 2017 at 1:16 PM, Carsten Ziegeler  wrote:
> +1
>
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Updated] (SLING-6227) Disable versioning for chunk nodes

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6227:

Fix Version/s: (was: Servlets Post 2.3.16)

> Disable versioning for chunk nodes
> --
>
> Key: SLING-6227
> URL: https://issues.apache.org/jira/browse/SLING-6227
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>
> While analyzing some customer setup it was found that {{sling:chunk}} nodes 
> are getting stored in version store and thus preventing the temporary files 
> created from getting garbage collection.
> {noformat}
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_7500_7999
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_6000_6499
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_4500_4999
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_2000_2499
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_10500_10999
> /jcr:system/jcr:versionStorage/13/6a/9c/136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/1.3/jcr:frozenNode/jcr:content/chunk_11000_11499>
>  pn
> { jcr:primaryType = nt:frozenNode, jcr:createdBy = admin, 
> jcr:frozenPrimaryType = sling:chunk, sling:offset = 11000, jcr:created = 
> 2015-12-10T22:23:13.409-05:00, jcr:frozenUuid = 
> 136a9c8d-4dd8-42e5-bced-67eec6ad8a3e/jcr:content/chunk_11000_11499, 
> jcr:data = {-1 bytes}, jcr:uuid = a98d131c-4892-42d4-aa15-4bb0402b176d }
> {noformat}
> This can be fixed by tweaking the nodetype definition for sling:chunks to 
> disable versioning for sling:chunk nodes



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6090) Avoid using nt:resource while creating file nodes via SlingPostServlet

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6090:

Fix Version/s: (was: Servlets Post 2.3.16)

> Avoid using nt:resource while creating file nodes via SlingPostServlet
> --
>
> Key: SLING-6090
> URL: https://issues.apache.org/jira/browse/SLING-6090
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>
> Currently Sling uses {{nt:resource}} nodetype while creating file nodes in 
> {{SlingFileUploadHandler}} and {{StreamedChunk}}. 
> As discussed in OAK-4567 and also in best practices at [1] it would be better 
> to avoid using a referenceable nodetype and instead use another nodetype like 
> {{oak:Resource}} 
> Mail thread on DL
> [1] 
> https://adapt.to/2016/en/schedule/let_s-run-the-whole-web-on-apache-sling-and-oak-.html
> [2] http://markmail.org/thread/77xvjxtx42euhss4
> [3] http://markmail.org/thread/tnqbcegadnyaflw4



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Release Apache Sling Installer Core 3.8.8

2017-05-05 Thread Carsten Ziegeler
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Comment Edited] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998028#comment-15998028
 ] 

Georg Henzler edited comment on SLING-6804 at 5/5/17 10:54 AM:
---

Spaces in {{hc.name}} have to be URL-encoded which is not that nice to look at, 
however thinking about it more using {{hc.name}} has a big advantage: It can be 
changed by configuration and for the case it is a service factory HC, the name 
is usually still unique (while the class name is not). 

Regarding the patch: I would not like to change the interface of the HC 
executor, it is a lot easier to just have one "search field" (=one parameter in 
the URL, more modern like google :) ). Also the patch does not include the 
change for the webconsole yet. 

So I would propose to just implicitly add the HC name to the tags and use URLs 
like the following:
{{/system/health/myTagForAllChecks,-Name%20of%20the%20one%20HC%20to%20exclude}}

Also this makes the implementation a lot easier, see 
[^SLING-6804-allow-hc.name-in-hc-urls-simple.patch] (javadoc and executor 
servlet help would have to be updated as well, would do that after this patch 
is applied)


was (Author: henzlerg):
Spaces in {{hc.name}} have to be URL-encoded which is not that nice to look at, 
however thinking about it more using {{hc.name}} has a big advantage: It can be 
changed by configuration and for the case it is a service factory HC, the name 
is usually still unique (while the class name is not). 

Regarding the patch: I would not like to change the interface of the HC 
executor, it is a lot easier to just have one "search field" (=one parameter in 
the URL, more modern like google :) ). Also the patch does not include the 
change for the webconsole yet. 

So I would propose to just implicitly add the HC name to the tags and use URLs 
like the following:
{{/system/health/myTagForAllChecks,-Name%20of%20the%20one%20HC%20to%20exclude}}

Also this makes the implementation a lot easier, preparing a simple patch for 
it.

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, 
> SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Georg Henzler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-6804:
-
Attachment: SLING-6804-allow-hc.name-in-hc-urls-simple.patch

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804-allow-hc.name-in-hc-urls-simple.patch, 
> SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [RESULT] [VOTE] Release Apache Sling XSS Protection Compat Bundle version 1.0.0

2017-05-05 Thread Karl Pauls
Time to call the vote on theApache Sling XSS Protection Compat Bundle
version 1.0.0 release.

* +1 votes from Carsten Ziegeler, Radu Cotescu, Daniel Klco, Stefan
Seifert, and Karl Pauls.

* No other votes.

The vote is successful. I will make the release artifacts available as
soon as possible.


Re: [RESULT] [VOTE] Release Apache Sling XSS Protection Bundle version 2.0.0

2017-05-05 Thread Karl Pauls
Time to call the vote on theApache Sling XSS Protection Bundle version
2.0.0 release.

* +1 votes from Carsten Ziegeler, Radu Cotescu, Daniel Klco, Stefan
Seifert, and Karl Pauls.

* No other votes.

The vote is successful. I will make the release artifacts available as
soon as possible.


Re: [VOTE] Release Apache Sling XSS Protection Compat Bundle version 1.0.0

2017-05-05 Thread Karl Pauls
+1

regards,

Karl

On Tue, May 2, 2017 at 5:27 PM, Stefan Seifert  wrote:
> +1
>



-- 
Karl Pauls
karlpa...@gmail.com


Re: [VOTE] Release Apache Sling XSS Protection Bundle version 2.0.0

2017-05-05 Thread Karl Pauls
+1

regards,

Karl

On Tue, May 2, 2017 at 5:26 PM, Stefan Seifert  wrote:
> +1
>



-- 
Karl Pauls
karlpa...@gmail.com


Re: Sling pipes release

2017-05-05 Thread Robert Munteanu
On Fri, 2017-04-28 at 09:37 +, Nicolas Peltier wrote:
> Hi,
> 
> gentle bump
> 
> In the meanwhile, SLING-6538 and SLING-6801 can be added too :-)

All patches applied. We still need to do some tweaking for SLING-6800.
Once that's done I will start the release process.

Robert
> 
> > On 27 Apr 2017, at 15:42, Nicolas Peltier 
> > wrote:
> > 
> > It’s done :-) 
> > 
> > > On 27 Apr 2017, at 15:39, Robert Munteanu 
> > > wrote:
> > > 
> > > Hi Nicolas,
> > > 
> > > (moving to dev@)
> > > 
> > > On Thu, 2017-04-27 at 12:16 +, Nicolas Peltier wrote:
> > > > Hi,
> > > > 
> > > > Is it possible to fix SLING-6800 and create a 0.0.12 release
> > > > for
> > > > sling pipes?
> > > > 
> > > > Thanks,
> > > > Nicolas
> > > 
> > > I see there's already a discussion going on in the pull request
> > > for
> > > SLING-6800 . Once that's done we can start the release vote.
> > > 
> > > Robert
> 
> 



[jira] [Commented] (SLING-6538) Sling Pipes size parameter returns incorrect number of items

2017-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998065#comment-15998065
 ] 

ASF GitHub Bot commented on SLING-6538:
---

Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/200


> Sling Pipes size parameter returns incorrect number of items
> 
>
> Key: SLING-6538
> URL: https://issues.apache.org/jira/browse/SLING-6538
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nate Yolles
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Pipes 0.0.12
>
>
> Setting the parameter "size" for Sling Pipes returns one less item than 
> requested.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] sling pull request #200: SLING-6538: Fix Sling Pipes size parameter

2017-05-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (SLING-6538) Sling Pipes size parameter returns incorrect number of items

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-6538.

Resolution: Fixed

Applied in https://svn.apache.org/r1794006, thanks [~nateyolles] for the patch!

> Sling Pipes size parameter returns incorrect number of items
> 
>
> Key: SLING-6538
> URL: https://issues.apache.org/jira/browse/SLING-6538
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nate Yolles
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Pipes 0.0.12
>
>
> Setting the parameter "size" for Sling Pipes returns one less item than 
> requested.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (SLING-6538) Sling Pipes size parameter returns incorrect number of items

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-6538:
--

Assignee: Robert Munteanu

> Sling Pipes size parameter returns incorrect number of items
> 
>
> Key: SLING-6538
> URL: https://issues.apache.org/jira/browse/SLING-6538
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nate Yolles
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Pipes 0.0.12
>
>
> Setting the parameter "size" for Sling Pipes returns one less item than 
> requested.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6538) Sling Pipes size parameter returns incorrect number of items

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6538:
---
Fix Version/s: Pipes 0.0.12

> Sling Pipes size parameter returns incorrect number of items
> 
>
> Key: SLING-6538
> URL: https://issues.apache.org/jira/browse/SLING-6538
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nate Yolles
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Pipes 0.0.12
>
>
> Setting the parameter "size" for Sling Pipes returns one less item than 
> requested.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998060#comment-15998060
 ] 

Robert Munteanu edited comment on SLING-6800 at 5/5/17 10:39 AM:
-

[~npeltier] - with the current trunk I get build failures ( see below ) which 
are solved after reverting r1794003 . Can you please double-check what is going 
on?

{noformat}[INFO] testRemoveNode(org.apache.sling.pipes.internal.RemovePipeTest) 
 Time elapsed: 0.022 sec  <<< ERROR!
[INFO] java.lang.AbstractMethodError: 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getParent(Lorg/apache/sling/api/resource/Resource;)Lorg/apache/sling/api/resource/Resource;
[INFO]  at 
org.apache.sling.api.resource.AbstractResource.getParent(AbstractResource.java:62)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.removeTree(RemovePipe.java:113)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.getOutput(RemovePipe.java:63)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipeTest.testRemoveNode(RemovePipeTest.java:49)
[INFO] 
[INFO] testComplexRemove(org.apache.sling.pipes.internal.RemovePipeTest)  Time 
elapsed: 0.006 sec  <<< ERROR!
[INFO] java.lang.AbstractMethodError: 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getParent(Lorg/apache/sling/api/resource/Resource;)Lorg/apache/sling/api/resource/Resource;
[INFO]  at 
org.apache.sling.api.resource.AbstractResource.getParent(AbstractResource.java:62)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.removeTree(RemovePipe.java:113)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.removeTree(RemovePipe.java:122)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.removeTree(RemovePipe.java:122)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipe.getOutput(RemovePipe.java:63)
[INFO]  at 
org.apache.sling.pipes.internal.RemovePipeTest.testComplexRemove(RemovePipeTest.java:79){noformat}


was (Author: rombert):
[~npeltier] - with the current trunk I get build failures ( see below ) which 
are solved after reverting r1794003 . Can you please double-check what is going 
on?

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Reopened] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-6800:


[~npeltier] - with the current trunk I get build failures ( see below ) which 
are solved after reverting r1794003 . Can you please double-check what is going 
on?

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6833) Sling Pipes should explicitly set exported package versions

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-6833.

Resolution: Fixed

Fixed in https://svn.apache.org/r1794005 

> Sling Pipes should explicitly set exported package versions
> ---
>
> Key: SLING-6833
> URL: https://issues.apache.org/jira/browse/SLING-6833
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> When building Sling Pipes 0.0.11-SNAPSHOT the basline plugin reports an 
> unwarranted version increase of the {{org.apache.sling.pipes}} package from 
> 0.0.10 to 0.0.11 . Since there is no {{package-info.java}} file for that 
> package the picked up version is the one from the bundle, which is not 
> desirable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6801) JsonPipeTest fails from time to time

2017-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998053#comment-15998053
 ] 

ASF GitHub Bot commented on SLING-6801:
---

Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/221


> JsonPipeTest fails from time to time
> 
>
> Key: SLING-6801
> URL: https://issues.apache.org/jira/browse/SLING-6801
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> depends on yahoo weather api, it shouldn't. Will first ignore test, and then 
> fix it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] sling pull request #221: SLING-6801 change remote to local json test

2017-05-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] sling pull request #220: SLING-6800 switch to R6 annotations

2017-05-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (SLING-6801) JsonPipeTest fails from time to time

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-6801.

Resolution: Fixed

Fixed in https://svn.apache.org/r1794004, thanks to [~npeltier] for the patch!

> JsonPipeTest fails from time to time
> 
>
> Key: SLING-6801
> URL: https://issues.apache.org/jira/browse/SLING-6801
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> depends on yahoo weather api, it shouldn't. Will first ignore test, and then 
> fix it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-6800.

Resolution: Fixed

Fixed in https://svn.apache.org/r1794003, thanks to [~npeltier] for the patch!

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998047#comment-15998047
 ] 

ASF GitHub Bot commented on SLING-6800:
---

Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/220


> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6800:
---
Fix Version/s: Pipes 0.0.12

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (SLING-6800) switch pipes to osgi R6 annotations

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-6800:
--

Assignee: Robert Munteanu

> switch pipes to osgi R6 annotations
> ---
>
> Key: SLING-6800
> URL: https://issues.apache.org/jira/browse/SLING-6800
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> switching to R6 annotations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6833) Sling Pipes should explicitly set exported package versions

2017-05-05 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-6833:
--

 Summary: Sling Pipes should explicitly set exported package 
versions
 Key: SLING-6833
 URL: https://issues.apache.org/jira/browse/SLING-6833
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Pipes 0.0.12


When building Sling Pipes 0.0.11-SNAPSHOT the basline plugin reports an 
unwarranted version increase of the {{org.apache.sling.pipes}} package from 
0.0.10 to 0.0.11 . Since there is no {{package-info.java}} file for that 
package the picked up version is the one from the bundle, which is not 
desirable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6801) JsonPipeTest fails from time to time

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6801:
---
Fix Version/s: Pipes 0.0.12

> JsonPipeTest fails from time to time
> 
>
> Key: SLING-6801
> URL: https://issues.apache.org/jira/browse/SLING-6801
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> depends on yahoo weather api, it shouldn't. Will first ignore test, and then 
> fix it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (SLING-6801) JsonPipeTest fails from time to time

2017-05-05 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-6801:
--

Assignee: Robert Munteanu

> JsonPipeTest fails from time to time
> 
>
> Key: SLING-6801
> URL: https://issues.apache.org/jira/browse/SLING-6801
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 0.0.12
>
>
> depends on yahoo weather api, it shouldn't. Will first ignore test, and then 
> fix it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6806) Health Check servlet does not show associated tags in the html or json

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998041#comment-15998041
 ] 

Georg Henzler commented on SLING-6806:
--

Had a look at the table again sightly optimised it (using grey for the tags as 
for the debug messages and making sure the table header will not be split in 
two lines) [r1794000|http://svn.apache.org/r1794000] 

> Health Check servlet does not show associated tags in the html or json
> --
>
> Key: SLING-6806
> URL: https://issues.apache.org/jira/browse/SLING-6806
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Fix For: Health Check Core 1.2.8
>
>
> From the health check servlet, you cannot determine what tags are associated 
> with a given health check. You can visit the system console itself, but it 
> seems this information should be presented here.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6723) Make dependency to javax.jcr, jcr.contentloader and jcr.api optional

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6723.
-
Resolution: Fixed

> Make dependency to javax.jcr, jcr.contentloader and jcr.api optional
> 
>
> Key: SLING-6723
> URL: https://issues.apache.org/jira/browse/SLING-6723
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.16
>
>
> In order to be able to run Sling in a very minimal version, the dependencies 
> to javax.jcr, jcr.api and jcr.contentloader should be optional. Otherwise a 
> whole set of modules needs to be dragged in just to make the servlets post 
> module provide the basic functionality (which is usually sufficient for most 
> applications)
> It seems with minimizing the dependency to JCR we can also clean up the code 
> as it is quiet of often adapting to JCR objects for no real reason and in 
> some cases mixing resource and node handling, where just sticking with one or 
> the other would do less operations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Release Apache Sling Installer Core 3.8.8

2017-05-05 Thread David Bosschaert
+1 (non-binding) - Thanks Carsten!

David

On 5 May 2017 at 11:06, Carsten Ziegeler  wrote:

> Hi,
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12339619
>
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1703/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1703 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ..
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>


[VOTE] Release Apache Sling Installer Core 3.8.8

2017-05-05 Thread Carsten Ziegeler
Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12339619



Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1703/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1703 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ..

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998028#comment-15998028
 ] 

Georg Henzler commented on SLING-6804:
--

Spaces in {{hc.name}} have to be URL-encoded which is not that nice to look at, 
however thinking about it more using {{hc.name}} has a big advantage: It can be 
changed by configuration and for the case it is a service factory HC, the name 
is usually still unique (while the class name is not). 

Regarding the patch: I would not like to change the interface of the HC 
executor, it is a lot easier to just have one "search field" (=one parameter in 
the URL, more modern like google :) ). Also the patch does not include the 
change for the webconsole yet. 

So I would propose to just implicitly add the HC name to the tags and use URLs 
like the following:
{{/system/health/myTagForAllChecks,-Name%20of%20the%20one%20HC%20to%20exclude}}

Also this makes the implementation a lot easier, preparing a simple patch for 
it.

> Request to allow the health check servlet to directly query a single health 
> check by name
> -
>
> Key: SLING-6804
> URL: https://issues.apache.org/jira/browse/SLING-6804
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Reporter: Clinton H Goudie-Nice
>Assignee: Justin Edelson
>Priority: Minor
> Attachments: SLING-6804.diff
>
>
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Release Apache Sling JCR ContentLoader 2.2.0, Pax Exam Utilities 1.0.4

2017-05-05 Thread Carsten Ziegeler
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling File System Resource Provider 2.1.0, File System Resource Provider 1.4.0, JCR Content Parser 1.1.0

2017-05-05 Thread Carsten Ziegeler
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Resolved] (SLING-6831) ConcurrentModificationException in OSGi Installer

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6831.
-
Resolution: Fixed

> ConcurrentModificationException in OSGi Installer
> -
>
> Key: SLING-6831
> URL: https://issues.apache.org/jira/browse/SLING-6831
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.6
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.8.8
>
> Attachments: SLING-6831.patch
>
>
> Under certain scenarios I'm getting: 
> {code}java.util.ConcurrentModificationException: null
>   at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
>   at java.util.HashMap$KeyIterator.next(HashMap.java:1461)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getInstallationState(OsgiInstallerImpl.java:1390)
> ...{code}
> To me this seems caused by the fact that the Map datastructure in the 
> PersistentResourceList is non-concurrent.
> PersistentResourceList.getEntityIds() returns the map's values directly. This 
> is what is used in OsgiInstallerImpl line 1390:
> {code}
> public Collection getEntityIds() {
> return this.data.keySet();
> }{code}
> And the client code iterates over that, causing the exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

2017-05-05 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998018#comment-15998018
 ] 

Carsten Ziegeler commented on SLING-6313:
-

I don't think that's possible as you would need a way to bypass the pid 
generation for factory pids 

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

2017-05-05 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6313:

Fix Version/s: (was: Installer Core 3.8.8)

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6832) osgi-mock: Support parsing SCR metadata when multiple definition XML files exists with the same name

2017-05-05 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6832.
---
Resolution: Fixed

Completed: At revision: 1793994  (2.x)
Completed: At revision: 1793995  (1.x)


> osgi-mock: Support parsing SCR metadata when multiple definition XML files 
> exists with the same name
> 
>
> Key: SLING-6832
> URL: https://issues.apache.org/jira/browse/SLING-6832
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing OSGi Mock 1.9.4, Testing OSGi Mock 2.3.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: mocks
> Fix For: Testing OSGi Mock 1.9.6, Testing OSGi Mock 2.3.2
>
>
> under certain circumstances it may happen that in a test classpath multiple 
> JAR files are loaded, and they contain the SCR metadata XML files with the 
> same name.
> the metadata parsing logic of osgi-mock should still find all instances and 
> parse them individually - they may contain different information.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6832) osgi-mock: Support parsing SCR metadata when multiple definition XML files exists with the same name

2017-05-05 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6832:
-

 Summary: osgi-mock: Support parsing SCR metadata when multiple 
definition XML files exists with the same name
 Key: SLING-6832
 URL: https://issues.apache.org/jira/browse/SLING-6832
 Project: Sling
  Issue Type: Bug
  Components: Testing
Affects Versions: Testing OSGi Mock 2.3.0, Testing OSGi Mock 1.9.4
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Testing OSGi Mock 1.9.6, Testing OSGi Mock 2.3.2


under certain circumstances it may happen that in a test classpath multiple JAR 
files are loaded, and they contain the SCR metadata XML files with the same 
name.

the metadata parsing logic of osgi-mock should still find all instances and 
parse them individually - they may contain different information.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [VOTE] Apache Sling Context-Aware Configuration Impl 1.4.0, Context-Aware Configuration Mock Plugin 1.2.0

2017-05-05 Thread Robert Munteanu
On Tue, 2017-05-02 at 15:52 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling File System Resource Provider 2.1.0, File System Resource Provider 1.4.0, JCR Content Parser 1.1.0

2017-05-05 Thread Robert Munteanu
On Thu, 2017-05-04 at 20:24 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


  1   2   >