[jira] [Commented] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Nitin Nizhawan (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137720#comment-16137720
 ] 

Nitin Nizhawan commented on SLING-6423:
---

[~cziegeler] This is only partially implemented. The parsing logic was 
committed but actual merging is not in place.

CC: [~bdelacretaz]

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.1.2
>
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-7069.
---
Resolution: Fixed

fixed in r1805830

there's now an option {{filter.combineTagsWithOr}}

if there is interest in a broader expression language, that should be a 
separate issue :)

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>Assignee: Justin Edelson
> Fix For: Health Check Core 1.2.10
>
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson reassigned SLING-7069:
-

 Assignee: Justin Edelson
Fix Version/s: Health Check Core 1.2.10
   Issue Type: Improvement  (was: Bug)

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Improvement
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>Assignee: Justin Edelson
> Fix For: Health Check Core 1.2.10
>
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7074) RRD4J NPE on removing all "Data sources" from config

[Alex Deparvu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136988#comment-16136988
 ] 

Alex Deparvu commented on SLING-7074:
-

I think I've corrupted the rrd db by setting the {{step}} to {{-1}}. the UI 
does not show it, but the logs do, I cannot change the value anymore and not 
even a restart brings it back:

{noformat}
22.08.2017 17:57:20.614 *INFO* [FelixStartLevel] 
org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter Starting 
RRD4J Metrics reporter
22.08.2017 17:57:20.659 *ERROR* [FelixStartLevel] 
org.apache.sling.commons.metrics-rrd4j 
[org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3095)] The 
activate method has thrown an exception (java.lang.IllegalArgumentException: 
Invalid RRD step specified: -1)
java.lang.IllegalArgumentException: Invalid RRD step specified: -1
at org.rrd4j.core.RrdDef.(RrdDef.java:83)
at org.rrd4j.core.RrdDef.(RrdDef.java:97)
at org.rrd4j.core.RrdDef.(RrdDef.java:114)
at org.rrd4j.core.RrdDb.getRrdDef(RrdDb.java:833)
at 
org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter.createDB(RRD4JReporter.java:310)
at 
org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter.(RRD4JReporter.java:158)
at 
org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.build(RRD4JReporter.java:127)
at 
org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:146)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
{noformat}

> RRD4J NPE on removing all "Data sources" from config
> 
>
> Key: SLING-7074
> URL: https://issues.apache.org/jira/browse/SLING-7074
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Alex Deparvu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
>
> Opened the config manager and deleted all entries
> {noformat}
>   *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
> pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] 
> org.apache.sling.commons.metrics-rrd4j 
> [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] 
> The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
> at 
> org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
> at 
> org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7074) RRD4J NPE on removing all "Data sources" from config

[Alex Deparvu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136963#comment-16136963
 ] 

Alex Deparvu commented on SLING-7074:
-

In general I think the {{withDatasources}} should handle error case more 
gracefully. even the illegal values should be logged and ignored, now they are 
still kept in the config screen even though the RRD4JReporter class is in a 
weird state following the failed init (not sure what that is actually).

> RRD4J NPE on removing all "Data sources" from config
> 
>
> Key: SLING-7074
> URL: https://issues.apache.org/jira/browse/SLING-7074
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Alex Deparvu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
>
> Opened the config manager and deleted all entries
> {noformat}
>   *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
> pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] 
> org.apache.sling.commons.metrics-rrd4j 
> [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] 
> The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
> at 
> org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
> at 
> org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7074) RRD4J NPE on removing all "Data sources" from config

[Alex Deparvu (JIRA)]

Alex Deparvu created SLING-7074:
---

 Summary: RRD4J NPE on removing all "Data sources" from config
 Key: SLING-7074
 URL: https://issues.apache.org/jira/browse/SLING-7074
 Project: Sling
  Issue Type: Bug
  Components: Commons
Reporter: Alex Deparvu
Priority: Minor
 Fix For: Commons Metrics RRD4J 1.0.0


Opened the config manager and deleted all entries
{noformat}
  *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] 
org.apache.sling.commons.metrics-rrd4j 
[org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] The 
activate method has thrown an exception (java.lang.NullPointerException)
java.lang.NullPointerException: null
at 
org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
at 
org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{noformat}

fyi [~mreutegg]




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136859#comment-16136859
 ] 

Bertrand Delacretaz edited comment on SLING-7069 at 8/22/17 2:28 PM:
-

I kinda vaguely knew that I had already seen this somewhere ;-)

So it looks like a simple way to implement this all over would be to have the 
{{HealthCheckFilter.getServiceFilter()}} method build its filter differently if 
the {{HealthCheckSelector}} provides a single "tag" that starts with a bracket. 

And either implement a simple mini language (which can be minimal to start 
with) or reuse OSGi LDAP code.

(I'm not volunteering right now, ENOTIME)



was (Author: bdelacretaz):
I kinda vaguely knew that I had already seen this somewhere ;-)

So it looks like a simple way to implement this all over would be to have the 
{{HealthCheckFilter.getServiceFilter()}} method build its filter differently if 
the {{HealthCheckSelector}} provides a single "tag" that starts with a bracket. 

And either implement a simple mini language (which can be minimal to start 
with) or reuse OSGi LDAP code.



> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136859#comment-16136859
 ] 

Bertrand Delacretaz commented on SLING-7069:


I kinda vaguely knew that I had already seen this somewhere ;-)

So it looks like a simple way to implement this all over would be to have the 
{{HealthCheckFilter.getServiceFilter()}} method build its filter differently if 
the {{HealthCheckSelector}} provides a single "tag" that starts with a bracket. 

And either implement a simple mini language (which can be minimal to start 
with) or reuse OSGi LDAP code.



> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136841#comment-16136841
 ] 

Carsten Ziegeler commented on SLING-7069:
-

right and then you end up with the familiar LDAP filter syntax used in various 
places :)

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136812#comment-16136812
 ] 

Bertrand Delacretaz commented on SLING-7069:


I agree that a mini language for combining tags would be useful, but the 
CompositeHealthCheck is not the only place where this logic is used - so if we 
change that it has to be done consistently throughout.

A simple way to differentiate a single tag entry from an expression is to 
required expressions to be in parentheses like {{((security or repository) and 
performance)}} .And expressions like {{(+security -performance)}} come to mind 
as well.

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136799#comment-16136799
 ] 

Carsten Ziegeler commented on SLING-7069:
-

Can we make this user friendly?

For example a single entry in filter tags could be an or'ed string, like 
tag1|tag2|tag3
So if filter.tags is [ "tag1|tag2|tag3" , "tag4|tag5"] this means (tag1 or tag2 
or tag3) AND (tag4 or tag5)
Or forget about filter.tags and have a filter.expression property

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136780#comment-16136780
 ] 

Jörg Hoh commented on SLING-7069:
-

(I would wonder if someone has ever used the CompositeHealthchecks with this 
strange semantic ...)

I agree. I assume that adding a new property "useOrSemantic" (default: false) 
would be a backward-compatible change.

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136775#comment-16136775
 ] 

Bertrand Delacretaz commented on SLING-7069:


AND might not have been the best choice but I don't think we can change that 
default, as we have to stay compatible with existing configurations - so IMO a 
new OR option is the only way.

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136762#comment-16136762
 ] 

Jörg Hoh commented on SLING-7069:
-

I think that AND in the CompositeHealthcheck doesn't make sense. Because it 
would allow you only to execute healthchecks which do have all tags "tag1", 
"tag2" and "tag3". 
All I want is to execute a number of HCs under a single name. 


> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Commons Scheduler 2.7.0

[Tommaso Teofili]

+1

Tommaso

Il giorno mar 22 ago 2017 alle ore 12:08 Robert Munteanu 
ha scritto:

> On Tue, 2017-08-22 at 11:35 +0200, Carsten Ziegeler wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert

[jira] [Commented] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136747#comment-16136747
 ] 

Bertrand Delacretaz commented on SLING-7069:


The {{CompositeHealthCheck}} calls 
{{healthCheckExecutor.execute(HealthCheckSelector.tags(filterTags))}} which 
uses the default selection method of ANDing the tags, so this is by design.

SLING-3501 has the history of those and/or options, which didn't exist when 
{{CompositeHealthCheck}} was created.

If we want to change this we need a new option for {{CompositeHealthCheck}} 
telling it to use OR instead, and pass that to the executor.

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7069) CompositeHealthcheck combines subchecks with AND instead of OR

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-7069:
---
Summary: CompositeHealthcheck combines subchecks with AND instead of OR  
(was: CompositeHealthcheck combines subchecks with AND)

> CompositeHealthcheck combines subchecks with AND instead of OR
> --
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Commons Scheduler 2.7.0

[Robert Munteanu]

On Tue, 2017-08-22 at 11:35 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Updated] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7055:

Component/s: (was: Extensions)
 Commons

Changed 'Component/s' back to Commons.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7055.patch, SLING-7055.patch, SLING-7055.patch, 
> SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Commons Scheduler 2.7.0

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Commons Scheduler 2.7.0

[Carsten Ziegeler]

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340577

´
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1772/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1772 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-5965) Metrics and a Health-Check for Scheduler to detect long-running Quartz-Jobs

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5965.
-
Resolution: Fixed

Agreed, setting dependency back to 3.1

> Metrics and a Health-Check for Scheduler to detect long-running Quartz-Jobs
> ---
>
> Key: SLING-5965
> URL: https://issues.apache.org/jira/browse/SLING-5965
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Affects Versions: Commons Scheduler 2.5.0
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: numRunningJobs.jpg, oldestRunningJob.jpg, patch.txt, 
> SchedulerHealthCheck.jpg, SLING-5965.patch, SLING-5965.v2.patch.txt, 
> SLING-5965.v3.patch.txt, SLING-5965.v4.patch.txt, SLING-5965.v5.patch.txt, 
> timers.jpg
>
>
> Sling Scheduler jobs (aka Quartz-Jobs) should typically be fast running jobs. 
> They are served from a thread-pool and should occupy that thread only for a 
> short amount of time.
> If there are 'misbehaving' quartz-jobs that run for a very long time, they 
> start to occupy threads from that thread-pool, thus have an influence on the 
> performance of other scheduled/quartz-jobs.
> We should have metrics (using 
> [sling.commons.metrics|https://sling.apache.org/documentation/bundles/metrics.html])
>  that provide information about internas of Sling Scheduler, such as average, 
> max etc duration of scheduled jobs, as well as how many jobs are currently 
> running and since when was the oldest job running.
> Based on this, a Health-Check can monitor the 'oldest job running' metric and 
> flag {{critical}} when eg the oldest job is older than {{60'000ms}} 
> (configurable, default).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Release Sling 10?

[Robert Munteanu]

On Mon, 2017-08-14 at 18:31 +0200, Karl Pauls wrote:
> I was thinking about doing another framework release soon-ish (eta
> next
> week). Maybe we could include that one as well (it might bring some
> performance benefit and fixes some lifecycle bugs).

Ack, will definitely wait for that - the Java 9 story seems to be a bit
more involved - see dependency chain of SLING-7046 [1] for details.

Robert

[1]: https://issues.apache.org/jira/browse/SLING-7046

Re: Release Sling 10?

[Robert Munteanu]

On Mon, 2017-08-14 at 15:55 +0200, Carsten Ziegeler wrote:
> Robert Munteanu wrote
> > Hi,
> > 
> > I'd like to do a "small" launchpad release for Java 9 support.
> > Sling
> > starts up and seems to be working fine with Java 9. I'd like to
> > also
> > set up Jenkins to run the ITs with Java 9, and then we can start a
> > release vote.
> > 
> > Does anyone have any comments on this or maybe any inclusions we
> > should
> > wait for with Sling 10?
> > 
> 
> I think we should make sure that we include the latest versions of
> our
> own bundles.
> And maybe we can also update some of the other bundles (like some
> Apache
> Felix  modules) to the latest version.
> 
> But other than that, big +1 for Sling 10

Good point, added a sub-task to https://issues.apache.org/jira/browse/S
LING-6952 .

Robert

[jira] [Created] (SLING-7073) Update bundle versions

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7073:
--

 Summary: Update bundle versions
 Key: SLING-7073
 URL: https://issues.apache.org/jira/browse/SLING-7073
 Project: Sling
  Issue Type: Sub-task
  Components: Launchpad
Reporter: Robert Munteanu
 Fix For: Launchpad Builder 10


Before the launchpad release, include the latest versions of external bundles 
and also check that our own bundles are at the latest versions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7063) Inventory printer for metrics RRD4J reporter

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7063.

Resolution: Fixed

Applied in [r1805733|https://svn.apache.org/r1805733], thanks for the patch 
[~mreutegg]

> Inventory printer for metrics RRD4J reporter
> 
>
> Key: SLING-7063
> URL: https://issues.apache.org/jira/browse/SLING-7063
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7063.patch
>
>
> The metrics reporter introduce with SLING-7055 should implement an inventory 
> printer and include the metrics in the configuration status zip file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7071) Rename metrics file on configuration change

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7071.

Resolution: Fixed

Applied in [r1805734|https://svn.apache.org/r1805734], thanks for the patch 
[~mreutegg]

> Rename metrics file on configuration change
> ---
>
> Key: SLING-7071
> URL: https://issues.apache.org/jira/browse/SLING-7071
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7071.patch
>
>
> The metrics reporter introduced in SLING-7055 overwrites an existing metrics 
> file when the configuration is changed. It would be more useful to keep an 
> existing file by renaming it. Otherwise valuable metrics data gathered so far 
> is lost. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7071) Rename metrics file on configuration change

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7071:
--

Assignee: Robert Munteanu

> Rename metrics file on configuration change
> ---
>
> Key: SLING-7071
> URL: https://issues.apache.org/jira/browse/SLING-7071
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7071.patch
>
>
> The metrics reporter introduced in SLING-7055 overwrites an existing metrics 
> file when the configuration is changed. It would be more useful to keep an 
> existing file by renaming it. Otherwise valuable metrics data gathered so far 
> is lost. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7063) Inventory printer for metrics RRD4J reporter

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7063:
--

Assignee: Robert Munteanu

> Inventory printer for metrics RRD4J reporter
> 
>
> Key: SLING-7063
> URL: https://issues.apache.org/jira/browse/SLING-7063
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7063.patch
>
>
> The metrics reporter introduce with SLING-7055 should implement an inventory 
> printer and include the metrics in the configuration status zip file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7069) CompositeHealthcheck combines subchecks with AND

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörg Hoh updated SLING-7069:

Description: 
I have a CompositeHealthcheck like this

{code}
http://sling.apache.org/jcr/sling/1.0; 
xmlns:cq="http://www.day.com/jcr/cq/1.0; xmlns:jcr="http://www.jcp.org/jcr/1.0; 
xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
jcr:primaryType="sling:OsgiConfig"
hc.name="Health Checks (Runtime)"
hc.mbean.name="runtime-monitoring"
filter.tags="[tag1,tag2,tag3]"
hc.tags="[runtime-monitoring]"
hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
{code}
whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
tagged with "tag1", "tag2" and "tage3" should be executed.
But whenever I run the healthceck on "runtime-monitoring", noone is executed at 
all.

I tracked it down to the fact, that only these healthchecks are executed which 
have all tags (tag1,tag2 and tag3) configured. Which of course none of my tags 
are.

{code}
21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
getTaggedHealthCheckServiceReferences(): 
(&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
{code}

It seems to me that instead of the AND it should be an OR:
{code}
(&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
{code}



  was:
I have a CompositeHealthcheck like this

{code}
http://sling.apache.org/jcr/sling/1.0; 
xmlns:cq="http://www.day.com/jcr/cq/1.0; xmlns:jcr="http://www.jcp.org/jcr/1.0; 
xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
jcr:primaryType="sling:OsgiConfig"
hc.name="Health Checks (Runtime)"
hc.mbean.name="runtime-monitoring"
filter.tags="[tag1,tag2,tag3]"
hc.tags="[runtime-monitoring]"
hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
{code}
whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
tagged with "tag1", "tag2" and "tage3" should be executed.
But whenever I run the healthceck on "runtime-monitoring", noone is executed at 
all.

I tracked it down to the fact, that only these healthchecks are executed which 
have all tags (tag1,tag2 and tag3) configured. Which of course none of my tags 
are.

{code}
21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
getTaggedHealthCheckServiceReferences(): 
(&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
{code}

It seems to me that instead of the AND it should be an OR.




> CompositeHealthcheck combines subchecks with AND
> 
>
> Key: SLING-7069
> URL: https://issues.apache.org/jira/browse/SLING-7069
> Project: Sling
>  Issue Type: Bug
>  Components: Health Check
>Affects Versions: Health Check Core 1.2.8
>Reporter: Jörg Hoh
>
> I have a CompositeHealthcheck like this
> {code}
> http://sling.apache.org/jcr/sling/1.0; 
> xmlns:cq="http://www.day.com/jcr/cq/1.0; 
> xmlns:jcr="http://www.jcp.org/jcr/1.0; 
> xmlns:nt="http://www.jcp.org/jcr/nt/1.0;
> jcr:primaryType="sling:OsgiConfig"
> hc.name="Health Checks (Runtime)"
> hc.mbean.name="runtime-monitoring"
> filter.tags="[tag1,tag2,tag3]"
> hc.tags="[runtime-monitoring]"
> hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>
> {code}
> whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks 
> tagged with "tag1", "tag2" and "tage3" should be executed.
> But whenever I run the healthceck on "runtime-monitoring", noone is executed 
> at all.
> I tracked it down to the fact, that only these healthchecks are executed 
> which have all tags (tag1,tag2 and tag3) configured. Which of course none of 
> my tags are.
> {code}
> 21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] 
> org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in 
> getTaggedHealthCheckServiceReferences(): 
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))
> {code}
> It seems to me that instead of the AND it should be an OR:
> {code}
> (&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-5965) Metrics and a Health-Check for Scheduler to detect long-running Quartz-Jobs

[Stefan Egli (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136537#comment-16136537
 ] 

Stefan Egli commented on SLING-5965:


[~cziegeler]
looks good, tested, works fine. except for the new dropmetrics 3.2 dependency:
bq. updated dependency to dropmetrics 3.2.3
seen the discussion in SLING-7047 - as I understand the goal of it, we should 
rather use dropmetrics 3.2(.x) than 3.1. That dropmetrics bundle is not part of 
scheduler (nor metrics) though. Why does this justify this dependency upgrade 
though? For those running on Sun JDKs where 3.1 works fine, why would we not 
still support them? IMO we have a larger backwards compatibility if we remain 
with 3.1 (assuming it will also work with 3.2.x when the dependency is on 3.1)

> Metrics and a Health-Check for Scheduler to detect long-running Quartz-Jobs
> ---
>
> Key: SLING-5965
> URL: https://issues.apache.org/jira/browse/SLING-5965
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Affects Versions: Commons Scheduler 2.5.0
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: numRunningJobs.jpg, oldestRunningJob.jpg, patch.txt, 
> SchedulerHealthCheck.jpg, SLING-5965.patch, SLING-5965.v2.patch.txt, 
> SLING-5965.v3.patch.txt, SLING-5965.v4.patch.txt, SLING-5965.v5.patch.txt, 
> timers.jpg
>
>
> Sling Scheduler jobs (aka Quartz-Jobs) should typically be fast running jobs. 
> They are served from a thread-pool and should occupy that thread only for a 
> short amount of time.
> If there are 'misbehaving' quartz-jobs that run for a very long time, they 
> start to occupy threads from that thread-pool, thus have an influence on the 
> performance of other scheduled/quartz-jobs.
> We should have metrics (using 
> [sling.commons.metrics|https://sling.apache.org/documentation/bundles/metrics.html])
>  that provide information about internas of Sling Scheduler, such as average, 
> max etc duration of scheduled jobs, as well as how many jobs are currently 
> running and since when was the oldest job running.
> Based on this, a Health-Check can monitor the 'oldest job running' metric and 
> flag {{critical}} when eg the oldest job is older than {{60'000ms}} 
> (configurable, default).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7072) Build failure with Java 9 - unable to create javax script engine for javascript

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136525#comment-16136525
 ] 

Robert Munteanu commented on SLING-7072:


Another possibility is to skip the antrun execution altogether and write a 
small custom mojo to set the properties. I think we use the antrun plugin in 
other areas too, and a fix should be coming for MANTRUN-200

> Build failure with Java 9 - unable to create javax script engine for 
> javascript
> ---
>
> Key: SLING-7072
> URL: https://issues.apache.org/jira/browse/SLING-7072
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Robert Munteanu
> Fix For: Parent 32
>
>
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run 
> (set-bundle-required-execution-environment) on project 
> org.apache.sling.engine: An Ant BuildException has occured: Unable to create 
> javax script engine for javascript
> [ERROR] around Ant part 

[jira] [Updated] (SLING-7071) Rename metrics file on configuration change

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7071:

Attachment: SLING-7071.patch

Proposed changed attached in [^SLING-7071.patch].

> Rename metrics file on configuration change
> ---
>
> Key: SLING-7071
> URL: https://issues.apache.org/jira/browse/SLING-7071
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7071.patch
>
>
> The metrics reporter introduced in SLING-7055 overwrites an existing metrics 
> file when the configuration is changed. It would be more useful to keep an 
> existing file by renaming it. Otherwise valuable metrics data gathered so far 
> is lost. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Slingstart Maven Plugin 1.7.8

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Created] (SLING-7072) Build failure with Java 9 - unable to create javax script engine for javascript

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7072:
--

 Summary: Build failure with Java 9 - unable to create javax script 
engine for javascript
 Key: SLING-7072
 URL: https://issues.apache.org/jira/browse/SLING-7072
 Project: Sling
  Issue Type: Bug
  Components: General
Reporter: Robert Munteanu
 Fix For: Parent 32


{noformat}[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-antrun-plugin:1.8:run 
(set-bundle-required-execution-environment) on project org.apache.sling.engine: 
An Ant BuildException has occured: Unable to create javax script engine for 
javascript
[ERROR] around Ant part 

[jira] [Resolved] (SLING-7070) Build failure with Java 9 in maven-enforcer-plugin

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7070.

Resolution: Fixed

Fixed in [r1805732|https://svn.apache.org/r1805732]

> Build failure with Java 9 in maven-enforcer-plugin
> --
>
> Key: SLING-7070
> URL: https://issues.apache.org/jira/browse/SLING-7070
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 32
>
>
> When building a module project with Java 9 the following error appears:
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-java) 
> on project org.apache.sling.engine: Execution enforce-java of goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed: An API 
> incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: 
> java.lang.ExceptionInInitializerError: null
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/home/robert/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
> [ERROR] urls[1] = 
> file:/home/robert/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
> [ERROR] urls[2] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
> [ERROR] urls[3] = 
> file:/home/robert/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
> [ERROR] urls[4] = 
> file:/home/robert/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
> [ERROR] urls[5] = 
> file:/home/robert/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
> [ERROR] urls[6] = 
> file:/home/robert/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
> [ERROR] urls[7] = 
> file:/home/robert/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
> [ERROR] urls[8] = 
> file:/home/robert/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
> [ERROR] urls[9] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
> [ERROR] urls[10] = 
> file:/home/robert/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> [ERROR] urls[11] = 
> file:/home/robert/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> [ERROR] urls[12] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
> [ERROR] urls[13] = 
> file:/home/robert/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
> [ERROR] urls[14] = 
> file:/home/robert/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4.1/enforcer-api-1.4.1.jar
> [ERROR] urls[15] = 
> file:/home/robert/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4.1/enforcer-rules-1.4.1.jar
> [ERROR] urls[16] = 
> file:/home/robert/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
> [ERROR] urls[17] = 
> file:/home/robert/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
> [ERROR] urls[18] = 
> file:/home/robert/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
> [ERROR] urls[19] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [ERROR] urls[20] = 
> file:/home/robert/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> [ERROR] urls[21] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
> [ERROR] urls[22] = 
> file:/home/robert/.m2/repository/org/apache/maven/plugin-testing/maven-plugin-testing-harness/1.3/maven-plugin-testing-harness-1.3.jar
> [ERROR] urls[23] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-archiver/2.2/plexus-archiver-2.2.jar
> [ERROR] urls[24] = 
> file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.jar
> [ERROR] urls[25] = 
> file:/home/robert/.m2/repository/junit/junit/4.11/junit-4.11.jar
> [ERROR] urls[26] = 
> file:/home/robert/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import  from realm 
> ClassRealm[project>org.apache.sling:org.apache.sling.engine:2.6.9-SNAPSHOT, 
> parent: 

[jira] [Updated] (SLING-7063) Inventory printer for metrics RRD4J reporter

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7063:

Fix Version/s: Commons Metrics RRD4J 1.0.0

> Inventory printer for metrics RRD4J reporter
> 
>
> Key: SLING-7063
> URL: https://issues.apache.org/jira/browse/SLING-7063
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: Commons Metrics RRD4J 1.0.0
>
> Attachments: SLING-7063.patch
>
>
> The metrics reporter introduce with SLING-7055 should implement an inventory 
> printer and include the metrics in the configuration status zip file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7071) Rename metrics file on configuration change

[Marcel Reutegger (JIRA)]

Marcel Reutegger created SLING-7071:
---

 Summary: Rename metrics file on configuration change
 Key: SLING-7071
 URL: https://issues.apache.org/jira/browse/SLING-7071
 Project: Sling
  Issue Type: Improvement
  Components: Commons
Reporter: Marcel Reutegger
Priority: Minor
 Fix For: Commons Metrics RRD4J 1.0.0


The metrics reporter introduced in SLING-7055 overwrites an existing metrics 
file when the configuration is changed. It would be more useful to keep an 
existing file by renaming it. Otherwise valuable metrics data gathered so far 
is lost. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Slingstart Maven Plugin 1.7.8

[Stefan Egli]

+1

Cheers,
Stefan

On 22/08/17 09:45, "Tomek Rekawek"  wrote:

>Hi,
>
>We solved 1 issue in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340487
>
>There are still some outstanding issues:
>https://issues.apache.org/jira/browse/SLING/component/12327304
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1771/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1771 /tmp/sling-staging
>
>Please vote to approve this release:
>  
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Regards,
>Tomek
>
>-- 
>Tomek Rękawek | Adobe Research | www.adobe.com
>reka...@adobe.com
>

[jira] [Created] (SLING-7070) Build failure with Java 9 in maven-enforcer-plugin

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7070:
--

 Summary: Build failure with Java 9 in maven-enforcer-plugin
 Key: SLING-7070
 URL: https://issues.apache.org/jira/browse/SLING-7070
 Project: Sling
  Issue Type: Bug
  Components: General
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Parent 32


When building a module project with Java 9 the following error appears:

{noformat}[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-java) on 
project org.apache.sling.engine: Execution enforce-java of goal 
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed: An API 
incompatibility was encountered while executing 
org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: 
java.lang.ExceptionInInitializerError: null
[ERROR] -
[ERROR] realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = 
file:/home/robert/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
[ERROR] urls[1] = 
file:/home/robert/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
[ERROR] urls[2] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
[ERROR] urls[3] = 
file:/home/robert/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
[ERROR] urls[4] = 
file:/home/robert/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
[ERROR] urls[5] = 
file:/home/robert/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
[ERROR] urls[6] = 
file:/home/robert/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
[ERROR] urls[7] = 
file:/home/robert/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
[ERROR] urls[8] = 
file:/home/robert/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
[ERROR] urls[9] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
[ERROR] urls[10] = 
file:/home/robert/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
[ERROR] urls[11] = 
file:/home/robert/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[12] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
[ERROR] urls[13] = 
file:/home/robert/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
[ERROR] urls[14] = 
file:/home/robert/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4.1/enforcer-api-1.4.1.jar
[ERROR] urls[15] = 
file:/home/robert/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4.1/enforcer-rules-1.4.1.jar
[ERROR] urls[16] = 
file:/home/robert/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
[ERROR] urls[17] = 
file:/home/robert/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
[ERROR] urls[18] = 
file:/home/robert/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
[ERROR] urls[19] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
[ERROR] urls[20] = 
file:/home/robert/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
[ERROR] urls[21] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
[ERROR] urls[22] = 
file:/home/robert/.m2/repository/org/apache/maven/plugin-testing/maven-plugin-testing-harness/1.3/maven-plugin-testing-harness-1.3.jar
[ERROR] urls[23] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-archiver/2.2/plexus-archiver-2.2.jar
[ERROR] urls[24] = 
file:/home/robert/.m2/repository/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.jar
[ERROR] urls[25] = 
file:/home/robert/.m2/repository/junit/junit/4.11/junit-4.11.jar
[ERROR] urls[26] = 
file:/home/robert/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm 
ClassRealm[project>org.apache.sling:org.apache.sling.engine:2.6.9-SNAPSHOT, 
parent: ClassRealm[maven.api, parent: null]]]{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [RESULT] [VOTE] Release Apache Sling Provisioning Model 1.8.4

[Robert Munteanu]

On Tue, 2017-08-22 at 10:04 +0200, Robert Munteanu wrote:
> On Tue, 2017-08-22 at 07:20 +, Tomek Rekawek wrote:
> > Hi,
> > 
> > The vote has passed with the following result :
> > 
> > +1 (binding): Robert Munteanu, Carsten Ziegeler, Justin Edelson
> > 
> > I will promote the artifacts to the central Maven repository.
> > 
> > May I ask a PMC member to copy this release to the Sling dist
> > directory?
> 
> Done in r21255.

Actually in r21258, previous commit was a mix-up.

Robert

Re: [RESULT] [VOTE] Release Apache Sling Provisioning Model 1.8.4

[Robert Munteanu]

On Tue, 2017-08-22 at 07:20 +, Tomek Rekawek wrote:
> Hi,
> 
> The vote has passed with the following result :
> 
> +1 (binding): Robert Munteanu, Carsten Ziegeler, Justin Edelson
> 
> I will promote the artifacts to the central Maven repository.
> 
> May I ask a PMC member to copy this release to the Sling dist
> directory?

Done in r21255.

Robert

Re: [VOTE] Release Apache Sling Slingstart Maven Plugin 1.7.8

[Robert Munteanu]

On Tue, 2017-08-22 at 07:45 +, Tomek Rekawek wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Slingstart Maven Plugin 1.7.8

[Tomek Rekawek]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340487

There are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING/component/12327304

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1771/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1771 /tmp/sling-staging

Please vote to approve this release:
  
[ ] +1 Approve the release  
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Tomek

-- 
Tomek Rękawek | Adobe Research | www.adobe.com
reka...@adobe.com

[jira] [Updated] (SLING-6332) Configurations with same PID but different features/run modes in provisioning model are ignored

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-6332:
-
Fix Version/s: (was: Sling Provisioning Model 1.8.4)
   Sling Provisioning Model 1.8.6

> Configurations with same PID but different features/run modes in provisioning 
> model are ignored 
> 
>
> Key: SLING-6332
> URL: https://issues.apache.org/jira/browse/SLING-6332
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Robert Munteanu
> Fix For: Sling Provisioning Model 1.8.6
>
>
> I have the following scenario:
> # {{launchpad/builder}} defines an OSGi config for 
> {{org.apache.sling.jcr.base.internal.LoginAdminWhitelist}}, setting the 
> {{whitelist.bundles.additional}} property
> # {{launchpad/testing}} depends on {{launchpad/builder}} and defines an the 
> same config with {{[mode=merge]}} and sets the {{whitelist.bundles.regexp}} 
> property
> When building {{launchpad/testing}}, the configuration from this project is 
> ignored completely and the one from {{launchpad/builder}} is picked up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7054) Slingstart artifacts with parametrized version not removed from the effective slingstart model

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek closed SLING-7054.


> Slingstart artifacts with parametrized version not removed from the effective 
> slingstart model
> --
>
> Key: SLING-7054
> URL: https://issues.apache.org/jira/browse/SLING-7054
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: Sling Provisioning Model 1.8.4, Slingstart Maven Plugin 
> 1.7.8
>
> Attachments: SLING-7054.patch
>
>
> Adding a following entry to the provisioning model:
> {noformat}
> [artifacts]
>   com.acme/my-model/1.0.0/slingstart
> {noformat}
> results in including the my-model to the current one. The slingfeature file 
> will be downloaded and merged. However, if we replace the version with a 
> variable:
> {noformat}
> [artifacts]
>   com.acme/my-model/${my.model.version}/slingstart
> {noformat}
> the slingstart will also download and include the my-model.jar file, not 
> useful here.
> It's a result of the lines 
> [345-356|https://github.com/apache/sling/blob/7e8a3a110a29b743d49ef799a7c7dec50a90bd96/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L345-L357]
>  in the {{ModelPreprocessor}}:
> {code}
> for(final org.apache.sling.provisioning.model.Artifact r 
> : removeList) {
> group.remove(r);
> final Feature localModelFeature = 
> rawModel.getFeature(feature.getName());
> if ( localModelFeature != null ) {
> final RunMode localRunMode = 
> localModelFeature.getRunMode(runMode.getNames());
> if ( localRunMode != null ) {
> final ArtifactGroup localAG = 
> localRunMode.getArtifactGroup(group.getStartLevel());
> if ( localAG != null ) {
> localAG.remove(r);
> }
> }
> }
> }
> {code}
> If the artifact is parametrized, it won't be removed from the localAG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-5914) Provisioning model does not correctly handle floating-point configuration values

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-5914:
-
Fix Version/s: (was: Sling Provisioning Model 1.8.4)
   Sling Provisioning Model 1.8.6

> Provisioning model does not correctly handle floating-point configuration 
> values
> 
>
> Key: SLING-5914
> URL: https://issues.apache.org/jira/browse/SLING-5914
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Robert Munteanu
> Fix For: Sling Provisioning Model 1.8.6
>
>
> The provisioning model specifies that floating-point values are encoded in 
> the following format:
> - {{D"1.0"}} for doubles
> - {{F"1.0"}} for floats
> However, the ConfigAdmin has a different idea about how these values should 
> be stored:
> {code:java}
> case TOKEN_SIMPLE_FLOAT:
> case TOKEN_PRIMITIVE_FLOAT:
> int fBits = Integer.parseInt( readQuoted( pr ) );
> return new Float( Float.intBitsToFloat( fBits ) );
> case TOKEN_SIMPLE_DOUBLE:
> case TOKEN_PRIMITIVE_DOUBLE:
> long dBits = Long.parseLong( readQuoted( pr ) );
> return new Double( Double.longBitsToDouble( dBits ) );
> {code}
> I assume that this is done to preserve precision when reading/writing values.
> The provisioning model should be updated to mediate between the user-supplied 
> values and the configuration admin format.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[RESULT] [VOTE] Release Apache Sling Provisioning Model 1.8.4

[Tomek Rekawek]

Hi,

The vote has passed with the following result :

+1 (binding): Robert Munteanu, Carsten Ziegeler, Justin Edelson

I will promote the artifacts to the central Maven repository.

May I ask a PMC member to copy this release to the Sling dist directory?

Regards,
Tomek

-- 
Tomek Rękawek | Adobe Research | www.adobe.com
reka...@adobe.com