[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642406#comment-16642406 ] ASF GitHub Bot commented on SLING-7990: --- simonetripodi opened a new pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6 initial version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema
simonetripodi opened a new pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6 initial version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7990) Define an initial version of the Feature Model JSON Shema
Simone Tripodi created SLING-7990: - Summary: Define an initial version of the Feature Model JSON Shema Key: SLING-7990 URL: https://issues.apache.org/jira/browse/SLING-7990 Project: Sling Issue Type: Improvement Components: Feature Model Affects Versions: Feature Model 0.1.2 Reporter: Simone Tripodi Assignee: David Bosschaert Fix For: Feature Model 0.1.4 As discussed in dev@ ML, there are multiple advantage of adopting such schema: * to have a formal and standard way to describe the Feature data structure in JSON model; * to provide an easy way to assist users on editing Feature json files in the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; * to separate the input validation - it can be delegated by the Feature Analyzer - and the parser phases (which should just take care of transforming the JSON data to the Feature model) PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7989) Sling Resource Provider implementation
Jason E Bailey created SLING-7989: - Summary: Sling Resource Provider implementation Key: SLING-7989 URL: https://issues.apache.org/jira/browse/SLING-7989 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey Create a new resource provider implementation that is self contained. I.e. does not require an external data store. Resource Provider must # Implement all Resource Provider interfaces. # Requires minimal configuration # Support a Query Language -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-3270: - Assignee: Jason E Bailey > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7927) JSON Content Loading errors out import on malformed json
[ https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7927: - Assignee: Jason E Bailey > JSON Content Loading errors out import on malformed json > > > Key: SLING-7927 > URL: https://issues.apache.org/jira/browse/SLING-7927 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Current Behaviour: > During the importing of json content from a bundle. If one of the files > contains malformed json the load process is discontinued and exits. This > stops the loading of any other, correctly formatted, data. > > Expected Behaviour: > If a single file contains malformed content, that specific file should > discontinue, the error logged and then the process continues to import the > rest of the provided content. > As it is right now, it's possible to load the bundle and have the application > in an unworkable state. preventing the ability to trouble shoot and > investigate the root cause. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7760) Contextual Additional Response Headers
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7760: - Assignee: Jason E Bailey > Contextual Additional Response Headers > -- > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > Currently, for us to set the global response headers we need to add these to > the Sling Main Servlet. > The problem with this is > * Any changes to the Sling Main Servlet ends up with the service restarting. > This has a negative overall effect to the environment > * We run multiple domains out of a single instance. For a > Content-Security-Header we end up putting in exemptions that should apply to > one site for all sites. This is problematic from a security perspective > Ideally we would be able to configure headers based on the domain that's > being requested -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7926) JSON Content Loading should support namespace mangling
[ https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7926: - Assignee: Jason E Bailey > JSON Content Loading should support namespace mangling > -- > > Key: SLING-7926 > URL: https://issues.apache.org/jira/browse/SLING-7926 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Currently it's possible to define a json file with a name that matches a > mangled namespace. Which then makes the file unable to be accessed from the > ResourceResolver > i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` > which cannot then be resolved as the resource resolver will attempt to > convert `_jcr_content` to `jcr:content` supporting namespace mangling will > additionally provide a cleaner `colon` support then the current > recommendation of a url mangled colon of `%3A` > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7934: - Assignee: Jason E Bailey > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642282#comment-16642282 ] Jason E Bailey commented on SLING-7934: --- [~karlpauls] I'm honestly fine with either of those suggestions, however I'm not sure of the validity of that argument since it would be valid with any use of adaptTo which is used throughout the framework > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7986: -- Affects Version/s: (was: App CMS 0.10.2) > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7986: -- Fix Version/s: App CMS 0.10.2 > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7986: - Assignee: Jason E Bailey > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 0.10.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642270#comment-16642270
]
ASF GitHub Bot commented on SLING-7988:
---
simonetripodi commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223456625
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
My pleasure, always glad to cooperate! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on a change in pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223456625
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
My pleasure, always glad to cooperate! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642128#comment-16642128
]
ASF GitHub Bot commented on SLING-7988:
---
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223431109
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
Ah, sorry, missed that.
Thanks for clarifying, @simonetripodi !
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert commented on a change in pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223431109
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
Ah, sorry, missed that.
Thanks for clarifying, @simonetripodi !
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (SLING-7708) Update pipes documentation
[ https://issues.apache.org/jira/browse/SLING-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7708. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: pipes 3.0.2 also added adaptTo last 2 videos > Update pipes documentation > -- > > Key: SLING-7708 > URL: https://issues.apache.org/jira/browse/SLING-7708 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.2 > > > - there are new pipes / features in release 3.0.0 that should be documented, > - size=0 to get all the element is wrong, it should be size=-1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7708) Update pipes documentation
[ https://issues.apache.org/jira/browse/SLING-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7708. -- > Update pipes documentation > -- > > Key: SLING-7708 > URL: https://issues.apache.org/jira/browse/SLING-7708 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.2 > > > - there are new pipes / features in release 3.0.0 that should be documented, > - size=0 to get all the element is wrong, it should be size=-1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641992#comment-16641992
]
ASF GitHub Bot commented on SLING-7988:
---
simonetripodi commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223399015
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
Uhm I implemented the provider under the `.task` package (where the
`AnalyserTask` is defined), that means methods would not be visible to the
`Analyzer` class...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on a change in pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223399015
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
Uhm I implemented the provider under the `.task` package (where the
`AnalyserTask` is defined), that means methods would not be visible to the
`Analyzer` class...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641954#comment-16641954
]
ASF GitHub Bot commented on SLING-7988:
---
simonetripodi opened a new pull request #4: SLING-7988 - Allow Analyzer
include/exclude tasks by id, in order to enable specific Tasks in the Maven
plugin
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4
allow the users configure the Analyzer tasks by conventional include/exclude
pattern
In that way, users can configure the plugin:
```
org.apache.sling
slingfeature-maven-plugin
${slingfeature-maven-plugin.version}
analyze
validate
analyse-features
api-regions
[...]
```
please, before merging it,
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 is
required to be applied first!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641949#comment-16641949
]
ASF GitHub Bot commented on SLING-7988:
---
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223394780
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
Review comment:
Does this new class need to be public? If it's only used from within the
same package then 'package' protected should also be possible, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641953#comment-16641953
]
ASF GitHub Bot commented on SLING-7988:
---
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223394972
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
The methods don't need to be public either, I guess?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi opened a new pull request #4: SLING-7988 - Allow Analyzer
include/exclude tasks by id, in order to enable specific Tasks in the Maven
plugin
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4
allow the users configure the Analyzer tasks by conventional include/exclude
pattern
In that way, users can configure the plugin:
```
org.apache.sling
slingfeature-maven-plugin
${slingfeature-maven-plugin.version}
analyze
validate
analyse-features
api-regions
[...]
```
please, before merging it,
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 is
required to be applied first!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bosschaert commented on a change in pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223394972
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
+
+private AnalyzerTaskProvider() {
+// this class must not be instantiated directly
+}
+
+public static AnalyserTask[] getTasks() {
Review comment:
The methods don't need to be public either, I guess?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bosschaert commented on a change in pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223394780
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
Review comment:
Does this new class need to be public? If it's only used from within the
same package then 'package' protected should also be possible, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641919#comment-16641919 ] ASF GitHub Bot commented on SLING-7988: --- simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 Hi there @bosschaert, please have a look at the initial implementation of my proposal. I moved few utility static methods from Analyzer class to a proper dedicated Task provider implementation, in order to have separation of concerns and better unit testing. I also implemented a new unit test, all old tests still pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 Hi there @bosschaert, please have a look at the initial implementation of my proposal. I moved few utility static methods from Analyzer class to a proper dedicated Task provider implementation, in order to have separation of concerns and better unit testing. I also implemented a new unit test, all old tests still pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
Simone Tripodi created SLING-7988: - Summary: Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin Key: SLING-7988 URL: https://issues.apache.org/jira/browse/SLING-7988 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: Simone Tripodi Assignee: David Bosschaert Current Maven Feature Plugin Analyze MOJO executes all tasks in the classpath, it should be possible to select them via the typical include/exclude plugin configuration pattern. A first initial modification is needed in the Analyzer component, I am going to submit a PR about it - once applied, the Maven plugin can be modified in order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
[
https://issues.apache.org/jira/browse/SLING-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-7987.
-
Resolution: Fixed
> AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
> ---
>
> Key: SLING-7987
> URL: https://issues.apache.org/jira/browse/SLING-7987
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
> LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
> LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
> order to be run before any other {{slingfeature-maven-plugin}} goal.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
[
https://issues.apache.org/jira/browse/SLING-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641852#comment-16641852
]
ASF GitHub Bot commented on SLING-7987:
---
simonetripodi commented on issue #3: SLING-7987 - AnalyseFeaturesMojo
accidentally bound to the wrong Maven phase
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/3#issuecomment-427837008
thanks a lot @bosschaert for taking care of it, very appreciated! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
> ---
>
> Key: SLING-7987
> URL: https://issues.apache.org/jira/browse/SLING-7987
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
> LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
> LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
> order to be run before any other {{slingfeature-maven-plugin}} goal.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on issue #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
simonetripodi commented on issue #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3#issuecomment-427837008 thanks a lot @bosschaert for taking care of it, very appreciated! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
[
https://issues.apache.org/jira/browse/SLING-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641841#comment-16641841
]
ASF GitHub Bot commented on SLING-7987:
---
bosschaert closed pull request #3: SLING-7987 - AnalyseFeaturesMojo
accidentally bound to the wrong Maven phase
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
> ---
>
> Key: SLING-7987
> URL: https://issues.apache.org/jira/browse/SLING-7987
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
> LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
> LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
> order to be run before any other {{slingfeature-maven-plugin}} goal.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert commented on issue #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
bosschaert commented on issue #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3#issuecomment-427835021 Thanks for your pull request, @simonetripodi - it's merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
[
https://issues.apache.org/jira/browse/SLING-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641843#comment-16641843
]
ASF GitHub Bot commented on SLING-7987:
---
bosschaert commented on issue #3: SLING-7987 - AnalyseFeaturesMojo accidentally
bound to the wrong Maven phase
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/3#issuecomment-427835021
Thanks for your pull request, @simonetripodi - it's merged!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
> ---
>
> Key: SLING-7987
> URL: https://issues.apache.org/jira/browse/SLING-7987
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
> LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
> LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
> order to be run before any other {{slingfeature-maven-plugin}} goal.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert closed pull request #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
bosschaert closed pull request #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
[
https://issues.apache.org/jira/browse/SLING-7987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641821#comment-16641821
]
ASF GitHub Bot commented on SLING-7987:
---
simonetripodi opened a new pull request #3: SLING-7987 - AnalyseFeaturesMojo
accidentally bound to the wrong Maven phase
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3
from LifecyclePhase.VERIFY to LifecyclePhase.VALIDATE
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
> ---
>
> Key: SLING-7987
> URL: https://issues.apache.org/jira/browse/SLING-7987
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
> LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
> LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
> order to be run before any other {{slingfeature-maven-plugin}} goal.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
simonetripodi opened a new pull request #3: SLING-7987 - AnalyseFeaturesMojo accidentally bound to the wrong Maven phase URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/3 from LifecyclePhase.VERIFY to LifecyclePhase.VALIDATE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7987) AnalyseFeaturesMojo accidentally bound to the wrong Maven phase
Simone Tripodi created SLING-7987:
-
Summary: AnalyseFeaturesMojo accidentally bound to the wrong Maven
phase
Key: SLING-7987
URL: https://issues.apache.org/jira/browse/SLING-7987
Project: Sling
Issue Type: Bug
Components: Feature Model, Maven Plugins and Archetypes
Reporter: Simone Tripodi
Assignee: David Bosschaert
Actually, {{AnalyseFeaturesMojo}} is bound to the {{defaultPhase =
LifecyclePhase.VERIFY}}, but it should be {{defaultPhase =
LifecyclePhase.VALIDATE}} since the {{analyse-features}} has been designed in
order to be run before any other {{slingfeature-maven-plugin}} goal.
PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Introducing the Feature json schema validation
Hi Simo, I think it would already be helpful to have just the schema, although I would like to know if we can still somehow use it as part of the build/test run for some validation because otherwise it might get out of sync. As for the location, how about a 'schema' subdirectory in https://github.com/apache/sling-org-apache-sling-feature ? Best regards, David On Sat, 6 Oct 2018 at 08:49, Simone Tripodi wrote: > Thanks for the kind feedback David, very appreciated! > I found a bug [1] in the Johnzon Schema implementation that would prevent > patternProperties proper validation, I'll try to submit a patch during the > WE :) > > I think that started providing just the schema, as a first step, is still > helpful, WDYT? What is the more appropriate location to contribute the > schema? > > Many thanks in advance, all the best! > ~Simo > > [1] https://issues.apache.org/jira/browse/JOHNZON-191 > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > > > On Fri, Oct 5, 2018 at 11:23 AM David Bosschaert < > david.bosscha...@gmail.com> > wrote: > > > Hi Simo, > > > > It would be great if we had a JSON Schema definition for the feature > files > > and if we could use that for validation. > > The schema itself can already be useful for documentation purposes! > > > > +1 from me. > > > > David > > > > On Fri, 5 Oct 2018 at 10:06, Simone Tripodi > > wrote: > > > > > Hi all, > > > I did an experiment yesterday in the night with the Apache Johnzon JSON > > > Schema implementation [1], but it doesn't fails where it is expect to > be. > > > I'll do some other tries during the WE :P > > > ~Simo > > > > > > [1] https://johnzon.apache.org/ > > > > > > http://people.apache.org/~simonetripodi/ > > > http://twitter.com/simonetripodi > > > > > > > > > On Thu, Oct 4, 2018 at 5:02 PM Simone Tripodi < > simonetrip...@apache.org> > > > wrote: > > > > > > > Hi all mates, > > > > > > > > while working on an idea of a JSON streaming parser for the Feature > > > model, > > > > I noticed that the parser has the delegation of validating the input, > > > other > > > > than transforming the json structure the the Feature model. > > > > > > > > Given my experience of (many, sigh) years ago I when contributed to > the > > > > Plexus Modello the JSON schema generator, I wrote an initial > prototype > > of > > > > the Apache Sling Feature JSON schema[2] compliant with the latest #7 > > > draft, > > > > and playing around with tests model with an online schema > validator[2]. > > > > The proposed schema supports extensions handling, validating the > object > > > > value type (JSON/TEXT/ARTIFACTS). > > > > > > > > I see the advantages below of adopting such schema: > > > > > > > > * to have a formal and standard way to describe the Feature data > > > > structure in JSON model; > > > > > > > > * provide an easy way to assist users on editing Feature json files > in > > > > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > > > > > > > > * separate the input validation - it can be delegated by the Feature > > > > Analyzer - and the parser phases (which should just take care of > > > > transforming the JSON data to the Feature model): unfortunately there > > are > > > > no up-to-date Java implementations, the most well-known [5] works on > > > > org.json implementation and the other one [6] is "still" at the draft > > #4 > > > > (aside that relies on too many dependencies). > > > > An alternative could be writing a simple validator for our use case, > > > based > > > > on the proposed schema. > > > > > > > > WDYT? > > > > I would like to contribute the schema [1] to one of the feature > > modules, > > > > maybe the -io is the more appropriate. > > > > > > > > I hope that could be interesting, have a nice day and all the best! > > > > ~Simo > > > > > > > > [1] > > > https://gist.github.com/simonetripodi/c69d2ffebdbd2c4b1355df60568f1ab5 > > > > [2] https://www.jsonschemavalidator.net/ > > > > [3] > > > > > > > > > > https://stackoverflow.com/questions/50011837/how-to-do-json-schema-validation-in-eclipse > > > > [4] > > > > > > https://www.jetbrains.com/help/idea/settings-languages-json-schema.html > > > > [5] https://github.com/everit-org/json-schema > > > > [6] https://github.com/java-json-tools/json-schema-validator > > > > > > > > http://people.apache.org/~simonetripodi/ > > > > http://twitter.com/simonetripodi > > > > > > > > > >
Re: [sling:resourceType] protected execution
My understanding of this thread is that it is about "controlling execution of servlets/scripts pertaining to individual resource-types". Carsten's point that we may want more fine-grained control, i.e. differentiate between "view" and "execute" (which may often be GET and POST), sounds sensible. Therefore it makes sense to me to include this requirement in the discussion. So far I am not convinced that any new API is needed to achieve this. And am therefore opposed to any solution that proposes/requires a new API. I see two existing APIs, which could help: - ResourceAccessGate - which I feel that some in this discussion don't understand how it could relate to resource-types and so far I seem to have failed to explain it properly - ResourceDecorator - we could "decorate-away" resource types that a user is not allowed to see, or even substitute them to render an error message instead. Via resource.getResourceResolver().getUserID() we have access to the current user. For any of these mechanisms to work, the script-user may be a hindrance. But I believe it would be worthwhile exploring if we cannot change this in a way that allows the approach to work. Regards Julian On Sun, Oct 7, 2018 at 8:17 AM Carsten Ziegeler wrote: > > I agree with Eric here, independent of the how we protect the execution, > we should also tackle the initial problem that everyone with write > access can set any resource type. It seems strange that we invite > everyone with weapons into our house and then try to prevent them from > using it. We should keep them out in the first place. > > I also think that a mechanism purely working resource types is not > exactly what we need. Think about you have a "view" and an "execute" > script for a resource type (potentially attached to selectors). Users > may be able to use the "view" script but "execute" is more protected. > > Then we have the resource type hierarchy, so if I'm able to set a > resource type I can also set a resource super type. We need to make sure > that this does not open something we wanted to close. I think the > current proposals cover this, but it should be verified. > > So all in all, I think this problem is more complex than just adding a > service with a single method and pretend that everything else are > implementation details. > > Regards > > Carsten > > > Eric Norman wrote > >> > >> 1. Users can freely define sling:resourceType properties > > > > > > Is there some reason why this must be so? In JCR land, the > > jcr:nodeTypeManagement privilege must be granted for the user to have > > permission to add and remove mixin node types and change the primary node > > type of a node. I would expect that a similar elevated privilege could > > protect against unwanted modifications of the sling:resourceType values by > > the wrong users. > > > > > > For #2 and #3, perhaps what you are really describing is a mechanism for > > defining and checking what I would call "functional privileges"? In other > > words, not the same as permissions on the data, but permissions on the > > action. Would it be necessary to associate those "functional privileges" > > to a resource type? I can imagine you may want to define a "functional > > privilege" that could be checked by some > > servlet/filter/component/osgi_service/model/other that works for many > > different resource types or no specific resource type at all. > > > > For example, > > 1. Imagine a resource defined at > > "/etc/functional_privileges/yourapp/usage_report" whose "jcr:read" > > permissions determines if the user can perform the "usage_report" servlet > > action. > > 2. Then the "usage_report" servlet simply has to has to check if the > > "yourapp/usage_report" resource at #1 exists for the current user (or some > > higher level API that does the same) to know if the servlet should proceed > > or return an error code. > > 3. For scripts, perhaps a sling:functionalPrivilege property on the > > resource could define what is required and block the script processing > > generically when those conditions are not satisfied. > > > > That's my 2 cents.. > > > > Regards, > > -Eric > > > > > > On Fri, Oct 5, 2018 at 2:40 AM Radu Cotescu wrote: > > > >> Hi, > >> > >> Since this thread exploded so quickly it’s going to be difficult to > >> respond to all of your questions / concerns individually. We eagerly > >> started discussing implementation details (of which I’m to blame too) and I > >> think we didn’t read between the lines of this thread or the previous [0] > >> to check what the perceived problems are. > >> > >> Both threads identified several issues: > >> 1. Users can freely define sling:resourceType properties > >> 2. Through 1, users can therefore trigger code execution which is not > >> always appropriate (depends on how Servlets / scripts are written and the > >> potential they have to DoS a system or to expose sensible information to > >> users which shouldn’t have the ability to perform those
[jira] [Resolved] (SLING-7984) Make dependency to web console optional
[ https://issues.apache.org/jira/browse/SLING-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-7984. - Resolution: Fixed Assignee: Carsten Ziegeler Fixed in r 8626afd > Make dependency to web console optional > --- > > Key: SLING-7984 > URL: https://issues.apache.org/jira/browse/SLING-7984 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.0.56 > > > The scripting core bundle currently requires the web console to be installed > for the web console plugin. However this bundle should work without the web > console being present -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7983) Make dependency to web console optional
[ https://issues.apache.org/jira/browse/SLING-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-7983. - Resolution: Fixed Assignee: Carsten Ziegeler Fixed in r 8a7073d > Make dependency to web console optional > --- > > Key: SLING-7983 > URL: https://issues.apache.org/jira/browse/SLING-7983 > Project: Sling > Issue Type: Improvement > Components: Discovery >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Discovery Oak 1.2.30 > > > The discovery oak bundle currently requires the web console to be installed > for the web console plugin. However the bundle should work without the web > console being present -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7982) Make dependency to web console optional
[ https://issues.apache.org/jira/browse/SLING-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-7982. - Resolution: Fixed Assignee: Carsten Ziegeler Fixed in r bf6a09b > Make dependency to web console optional > --- > > Key: SLING-7982 > URL: https://issues.apache.org/jira/browse/SLING-7982 > Project: Sling > Issue Type: Improvement >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Context-Aware Configuration Impl 1.4.16 > > > The ca config impl currently requires the web console to be installed for the > web console plugin. However this bundle should work without the web console > being present -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7981) Make dependency to web console optional
[ https://issues.apache.org/jira/browse/SLING-7981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-7981. - Fixed in r d8ca2f5 > Make dependency to web console optional > --- > > Key: SLING-7981 > URL: https://issues.apache.org/jira/browse/SLING-7981 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: File System ClassLoader 1.0.10 > > > The file system class loader currently requires the web console to be > installed for the web console plugin. However the class loader should work > without the web console being present -- This message was sent by Atlassian JIRA (v7.6.3#76005)
