[jira] [Closed] (SLING-8088) CMS - UI - Clicking Background Doesn't Close Component Dialogs

2018-11-28 Thread Dan Klco (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8088.
---

> CMS - UI - Clicking Background Doesn't Close Component Dialogs 
> ---
>
> Key: SLING-8088
> URL: https://issues.apache.org/jira/browse/SLING-8088
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 0.11.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: App CMS 0.11.2
>
>
> Not sure why this is happening, but when you are editing a component, 
> clicking on the background or the close x on the top-right doesn't close the 
> dialog. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8089) Readability Configuration not Registered on Install

2018-11-28 Thread Dan Klco (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8089.
---

> Readability Configuration not Registered on Install
> ---
>
> Key: SLING-8089
> URL: https://issues.apache.org/jira/browse/SLING-8089
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 0.11.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 0.11.2
>
>
> The readability configuration is not being picked up and has to be re-entered.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8074) CMS - References Show Incorrect Paths

2018-11-28 Thread Dan Klco (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8074.
---

> CMS - References Show Incorrect Paths
> -
>
> Key: SLING-8074
> URL: https://issues.apache.org/jira/browse/SLING-8074
> Project: Sling
>  Issue Type: Bug
>Affects Versions: App CMS 0.10.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: App CMS 0.11.2
>
>
> Currently, the references component shows references to a path under 
> /jcr:system/jcr:versionStorage and does not remove duplicate path / ids.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8087) CMS - UI - Cannot Create Pages

2018-11-28 Thread Dan Klco (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8087.
---

> CMS - UI - Cannot Create Pages
> --
>
> Key: SLING-8087
> URL: https://issues.apache.org/jira/browse/SLING-8087
> Project: Sling
>  Issue Type: Bug
>Affects Versions: App CMS 0.11.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Critical
> Fix For: App CMS 0.11.2
>
>
> Currently the create page function does not work correctly, instead it is 
> creating a folder because handlebars is missing.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8140) The descriptor file generated for the RepositoryPrinterProvider component is empty

2018-11-28 Thread Eric Norman (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-8140.

Resolution: Fixed

Fixed at: 
https://github.com/apache/sling-org-apache-sling-jcr-base/commit/de884b669836aacb2666da1e7bae1a6735de3bdb

> The descriptor file generated for the RepositoryPrinterProvider component is 
> empty
> --
>
> Key: SLING-8140
> URL: https://issues.apache.org/jira/browse/SLING-8140
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Switch to the official OSGi annotations
>  
> During the build this exception is logged:
> {quote}Running org.apache.sling.jcr.base.RepositoryInitializersTest
> [Fatal Error] :1:1: Premature end of file.
> [main] WARN org.apache.sling.testing.mock.osgi.OsgiMetadataUtil - Error 
> reading SCR metadata XML document from 
> OSGI-INF/org.apache.sling.jcr.base.internal.RepositoryPrinterProvider.xml
> java.lang.RuntimeException: Unable to read classpath resource: 
> OSGI-INF/org.apache.sling.jcr.base.internal.RepositoryPrinterProvider.xml
>  at 
> org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.toXmlDocument(OsgiMetadataUtil.java:230)
>  at 
> org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.parseMetadataDocument(OsgiMetadataUtil.java:194)
>  at 
> org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.parseMetadataDocuments(OsgiMetadataUtil.java:183)
>  at 
> org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.initMetadataDocumentCache(OsgiMetadataUtil.java:171)
>  at 
> org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.(OsgiMetadataUtil.java:114)
>  at 
> org.apache.sling.testing.mock.osgi.MapMergeUtil.propertiesMergeWithOsgiMetadata(MapMergeUtil.java:73)
>  at 
> org.apache.sling.testing.mock.osgi.MapMergeUtil.propertiesMergeWithOsgiMetadata(MapMergeUtil.java:55)
>  at 
> org.apache.sling.testing.mock.osgi.MockBundleContext.registerService(MockBundleContext.java:119)
>  at 
> org.apache.sling.testing.mock.osgi.MockBundleContext.registerService(MockBundleContext.java:107)
>  at 
> org.apache.sling.testing.mock.osgi.MockBundleContext.(MockBundleContext.java:80)
>  at 
> org.apache.sling.testing.mock.osgi.MockOsgi.newBundleContext(MockOsgi.java:50)
>  at 
> org.apache.sling.testing.mock.osgi.ComponentContextBuilder.build(ComponentContextBuilder.java:69)
>  at 
> org.apache.sling.testing.mock.osgi.MockOsgi.newComponentContext(MockOsgi.java:67)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.componentContext(OsgiContextImpl.java:74)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.bundleContext(OsgiContextImpl.java:83)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerInjectActivateService(OsgiContextImpl.java:153)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerInjectActivateService(OsgiContextImpl.java:141)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerDefaultServices(OsgiContextImpl.java:66)
>  at 
> org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.setUp(OsgiContextImpl.java:47)
>  at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:96)
>  at 
> org.apache.sling.testing.mock.sling.junit.SlingContext.access$000(SlingContext.java:32)
>  at 
> org.apache.sling.testing.mock.sling.junit.SlingContext$1.before(SlingContext.java:113)
>  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
>  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>  at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
>  at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
>  at 
> 

[RESULT] [VOTE] Release Apache Sling App CMS version 0.11.2

2018-11-28 Thread Daniel Klco
Hi,

The vote has passed with the following result :

+1 (binding): Robert Munteanu, Dan Klco, Nicolas Peltier
+1 (non binding): Jason Bailey

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.


[jira] [Updated] (SLING-8140) The descriptor file generated for the RepositoryPrinterProvider component is empty

2018-11-28 Thread Eric Norman (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8140:
---
Description: 
Switch to the official OSGi annotations

 

During the build this exception is logged:
{quote}Running org.apache.sling.jcr.base.RepositoryInitializersTest
[Fatal Error] :1:1: Premature end of file.
[main] WARN org.apache.sling.testing.mock.osgi.OsgiMetadataUtil - Error reading 
SCR metadata XML document from 
OSGI-INF/org.apache.sling.jcr.base.internal.RepositoryPrinterProvider.xml
java.lang.RuntimeException: Unable to read classpath resource: 
OSGI-INF/org.apache.sling.jcr.base.internal.RepositoryPrinterProvider.xml
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.toXmlDocument(OsgiMetadataUtil.java:230)
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.parseMetadataDocument(OsgiMetadataUtil.java:194)
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.parseMetadataDocuments(OsgiMetadataUtil.java:183)
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.initMetadataDocumentCache(OsgiMetadataUtil.java:171)
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.(OsgiMetadataUtil.java:114)
 at 
org.apache.sling.testing.mock.osgi.MapMergeUtil.propertiesMergeWithOsgiMetadata(MapMergeUtil.java:73)
 at 
org.apache.sling.testing.mock.osgi.MapMergeUtil.propertiesMergeWithOsgiMetadata(MapMergeUtil.java:55)
 at 
org.apache.sling.testing.mock.osgi.MockBundleContext.registerService(MockBundleContext.java:119)
 at 
org.apache.sling.testing.mock.osgi.MockBundleContext.registerService(MockBundleContext.java:107)
 at 
org.apache.sling.testing.mock.osgi.MockBundleContext.(MockBundleContext.java:80)
 at 
org.apache.sling.testing.mock.osgi.MockOsgi.newBundleContext(MockOsgi.java:50)
 at 
org.apache.sling.testing.mock.osgi.ComponentContextBuilder.build(ComponentContextBuilder.java:69)
 at 
org.apache.sling.testing.mock.osgi.MockOsgi.newComponentContext(MockOsgi.java:67)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.componentContext(OsgiContextImpl.java:74)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.bundleContext(OsgiContextImpl.java:83)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerInjectActivateService(OsgiContextImpl.java:153)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerInjectActivateService(OsgiContextImpl.java:141)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.registerDefaultServices(OsgiContextImpl.java:66)
 at 
org.apache.sling.testing.mock.osgi.context.OsgiContextImpl.setUp(OsgiContextImpl.java:47)
 at 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:96)
 at 
org.apache.sling.testing.mock.sling.junit.SlingContext.access$000(SlingContext.java:32)
 at 
org.apache.sling.testing.mock.sling.junit.SlingContext$1.before(SlingContext.java:113)
 at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
 at org.junit.rules.RunRules.evaluate(RunRules.java:20)
 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
 at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
 at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
 at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Caused by: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 1; 
Premature end of file.
 at 
com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:257)
 at 
com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339)
 at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:121)
 at 
org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.toXmlDocument(OsgiMetadataUtil.java:226)
 ... 39 more
{quote}

  was:Switch to the official OSGi annotations


> The descriptor file generated for the RepositoryPrinterProvider component is 
> empty
> 

[jira] [Created] (SLING-8140) The descriptor file generated for the RepositoryPrinterProvider component is empty

2018-11-28 Thread Eric Norman (JIRA)
Eric Norman created SLING-8140:
--

 Summary: The descriptor file generated for the 
RepositoryPrinterProvider component is empty
 Key: SLING-8140
 URL: https://issues.apache.org/jira/browse/SLING-8140
 Project: Sling
  Issue Type: Bug
Affects Versions: JCR Base 3.0.4
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: JCR Base 3.0.6


Switch to the official OSGi annotations



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Failed Pipeline: sling-ide-tooling » master #56

2018-11-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-ide-tooling/job/master/56/

[jira] [Updated] (SLING-8116) ValueMap - implement default methods using OSGI Converter

2018-11-28 Thread Jason E Bailey (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-8116:
--
Fix Version/s: API 2.18.6

> ValueMap - implement default methods using OSGI Converter
> -
>
> Key: SLING-8116
> URL: https://issues.apache.org/jira/browse/SLING-8116
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: API 2.18.6
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Implement default methods in the ValueMap interface that leverages the OSGi 
> Converter
> see
>  [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html]
> Once this is implemented, custom implementations of the ValueMap interface 
> can start being removed, where appropriate, so that a consistent and 
> comprehensive conversion of properties occur.  We can then add new Rules to 
> the Converter to allow features to be populated to all ValueMap 
> implementations.
>  
> To implement this, the following will also need to happen
>  * The Converter bundle will need to be added as a required bundle
>  ** Various scripts that define the minimum needed set of bundles will need 
> to be updated
>  * Communication on the difference in behaviour between the current ValueMap 
> and the ValueMap with Converter
>  * Although not within the Maven definition. org.osgi.util.Function needs to 
> be available as well for the Converter to initiate correctly.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-8116) ValueMap - implement default methods using OSGI Converter

2018-11-28 Thread Jason E Bailey (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey reassigned SLING-8116:
-

Assignee: Jason E Bailey

> ValueMap - implement default methods using OSGI Converter
> -
>
> Key: SLING-8116
> URL: https://issues.apache.org/jira/browse/SLING-8116
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Implement default methods in the ValueMap interface that leverages the OSGi 
> Converter
> see
>  [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html]
> Once this is implemented, custom implementations of the ValueMap interface 
> can start being removed, where appropriate, so that a consistent and 
> comprehensive conversion of properties occur.  We can then add new Rules to 
> the Converter to allow features to be populated to all ValueMap 
> implementations.
>  
> To implement this, the following will also need to happen
>  * The Converter bundle will need to be added as a required bundle
>  ** Various scripts that define the minimum needed set of bundles will need 
> to be updated
>  * Communication on the difference in behaviour between the current ValueMap 
> and the ValueMap with Converter
>  * Although not within the Maven definition. org.osgi.util.Function needs to 
> be available as well for the Converter to initiate correctly.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling App CMS version 0.11.2

2018-11-28 Thread Nicolas Peltier
+1 (sorry for the delay)

Le mer. 28 nov. 2018 à 14:02, Daniel Klco  a écrit :

> Any more PMC votes? Otherwise I will cancel the release.
>
> On Mon, Nov 26, 2018 at 11:02 AM Daniel Klco  wrote:
>
> > Any other votes?
> >
> > On Mon, Nov 26, 2018, 10:42 AM Jason E Bailey  >
> >> +1 non-binding
> >>
> >> - Jason
> >>
> >> On Thu, Nov 22, 2018, at 2:36 AM, Robert Munteanu wrote:
> >> > On Wed, 2018-11-21 at 14:30 -0500, Daniel Klco wrote:
> >> > > Please vote to approve this release:
> >> >
> >> > +1
> >> >
> >> > Robert
> >> > Email had 1 attachment:
> >> > + signature.asc
> >> >   1k (application/pgp-signature)
> >>
> >
>


[jira] [Resolved] (SLING-8137) Create an analyser that checks the order of API Regions

2018-11-28 Thread David Bosschaert (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-8137.
-
   Resolution: Fixed
Fix Version/s: Feature Model Analyser 0.8.2

Fixed in 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-feature-analyser.git;a=commitdiff;h=8b24c5d0431f8288f982e16ff94a838fe6a14e72

> Create an analyser that checks the order of API Regions
> ---
>
> Key: SLING-8137
> URL: https://issues.apache.org/jira/browse/SLING-8137
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model
>Affects Versions: Feature Model Analyser 0.8.0
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> The order in which API Regions are specified is important since later API 
> Regions inherit from earlier API Regions. It should be possible to validate 
> that API Regions are specified in the correct order. An analyser can perform 
> this check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling App CMS version 0.11.2

2018-11-28 Thread Daniel Klco
Any more PMC votes? Otherwise I will cancel the release.

On Mon, Nov 26, 2018 at 11:02 AM Daniel Klco  wrote:

> Any other votes?
>
> On Mon, Nov 26, 2018, 10:42 AM Jason E Bailey 
>> +1 non-binding
>>
>> - Jason
>>
>> On Thu, Nov 22, 2018, at 2:36 AM, Robert Munteanu wrote:
>> > On Wed, 2018-11-21 at 14:30 -0500, Daniel Klco wrote:
>> > > Please vote to approve this release:
>> >
>> > +1
>> >
>> > Robert
>> > Email had 1 attachment:
>> > + signature.asc
>> >   1k (application/pgp-signature)
>>
>


[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread Karl Pauls (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701813#comment-16701813
 ] 

Karl Pauls commented on SLING-8136:
---

[~rombert], yes.

> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [HEADS-UP] New repository for org.apache.sling.launchpad.startupmanager

2018-11-28 Thread Karl Pauls
On Wed, Nov 28, 2018 at 4:57 AM Oliver Lietz  wrote:
>
> On Tuesday 27 November 2018 10:01:37 Bertrand Delacretaz wrote:
> > Hi,
> >
> > On Tue, Nov 27, 2018 at 9:34 AM Karl Pauls  wrote:
> > > ...I think I'll call it:
> > > sling-org-apache-sling-launchpad-startupmanager ..
> >
> > That works for me and maybe at the same time you can add some info to
> > the README about what that module does ;-)
>
> AFAIR we agreed to drop the Launchpad API and removed all usage from Sling's
> bundles. It was only implemented fully in Launchpad Base and not in any other
> launcher. So I wonder why we bring it back now and add support in Feature
> Launcher (?).

Exactly. The idea of the startupmanager is to move out what is needed
to make other systems work until they stop requiring the
launchpad.api. It for the most part is just a couple of stubbed
services (or with minimal implementations). We can use them in other
launchers if there is a need for it because of old stuff requiring it
but I would advice against it where possible.

In other words, it is the other way around in regard to the Feature
Launcher. It used to implement some of the launchpad.api to make old
stuff work but it now stopped doing that. Instead, one can now just
install the startupmanager as a bundle as part of a feature (if ones
bundles require it).

regards,

Karl

> Regards,
> O.
>
> > -Bertrand
>


-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701816#comment-16701816
 ] 

ASF GitHub Bot commented on SLING-8136:
---

rombert closed pull request #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701815#comment-16701815
 ] 

ASF GitHub Bot commented on SLING-8136:
---

rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442429819
 
 
   @karlpauls provided a proper fix in 
https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/591bfb9,
 closing


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] rombert closed pull request #11: SLING-8136 - Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread GitBox
rombert closed pull request #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread GitBox
rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442429819
 
 
   @karlpauls provided a proper fix in 
https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/591bfb9,
 closing


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8136.

Resolution: Fixed
  Assignee: Karl Pauls

Marking fixed then and assigning to you. Thanks!

> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

2018-11-28 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701594#comment-16701594
 ] 

Robert Munteanu commented on SLING-8136:


[~kpauls] - I think you basically solved this with 
[sling-org-apache-sling-feature-analyser commit 
591bfb9|https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/591bfb9],
 right?

> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)