[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

2018-12-17 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723511#comment-16723511
 ] 

Robert Munteanu commented on SLING-7245:


Work is underway with

- https://github.com/apache/sling-tooling-jenkins/tree/feature/SLING-7245 
(implementation)
- https://github.com/apache/sling-whiteboard/pull/23 (testing)

Rough plan:

* ensure feature parity with current Job DSL approach
* validate that we will cover all module types
* (dev@sling) decide on how to generate Jobs for all modules - GitHub org 
folder vs existing seed job
* (dev@sling) decide on whether to keep data in .sling-module.xml or move to 
Jenkinsfile parameters
* (optional) use a different account so my avatar does not appear for all checks

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] rombert opened a new pull request #23: SLING-7245 - Validate pull requests using Jenkins

2018-12-17 Thread GitBox
rombert opened a new pull request #23: SLING-7245 - Validate pull requests 
using Jenkins
URL: https://github.com/apache/sling-whiteboard/pull/23
 
 
   This PR is a test bed for a scalable Jenkinsfile implementation for Apache 
Sling using shared libraries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Failed Pipeline: sling-ide-tooling » master #62

2018-12-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-ide-tooling/job/master/62/

[jira] [Assigned] (SLING-7245) Validate pull requests using Jenkins

2018-12-17 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7245:
--

Assignee: Robert Munteanu

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Best practices
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7245) Validate pull requests using Jenkins

2018-12-17 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7245:
---
Component/s: (was: Best practices)
 Build and Source Control

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling Capabilities 0.1.2 and Apache Sling Capabilities JCR 0.1.2

2018-12-17 Thread Robert Munteanu
On Mon, 2018-12-17 at 15:32 +0100, Bertrand Delacretaz wrote:
> Hi Robert,
> 
> On Fri, Dec 14, 2018 at 2:04 PM Robert Munteanu 
> wrote:
> > ...Also, as a personal curiosity - we don't typically use the
> > bundle names
> > as release versions, was there a particular reason to do so?...
> 
> It was just me being inconsistent...I've fixed that now!

Ah ok :-)

Thanks,

Robert



[jira] [Created] (SLING-8183) Update Pax Exam to 4.13.1

2018-12-17 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-8183:
---

 Summary: Update Pax Exam to 4.13.1
 Key: SLING-8183
 URL: https://issues.apache.org/jira/browse/SLING-8183
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Integration Tests 0.2.0, Karaf Launchpad 
Integration Tests (Oak Tar) 0.0.2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7180) Set up a Jenkins job for automatically publishing the Sling site

2018-12-17 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7180.

Resolution: Fixed

Fixed via https://github.com/apache/sling-site/pull/33 and verified that commit 
https://github.com/apache/sling-site/commit/8aa9d739a894cb1613d5bfffdc23a4058e2b4ad6
 was generated by Jenkins and the website was deployed correctly.

Note that [~kwin] raised a comment in the PR that may require changes but for 
now this is "done".

> Set up a Jenkins job for automatically publishing the Sling site
> 
>
> Key: SLING-7180
> URL: https://issues.apache.org/jira/browse/SLING-7180
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Once we move to gitbox we should also automatically build + push the site 
> from a Jenkins job so that all we need to do is {{git push}} from the master 
> branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Sling site now automatically built and deployed after each push

2018-12-17 Thread Robert Munteanu
Hi,

I enabled the automatic publication of all changes pushed to the master
branch of the sling-site repository. Therefore there is no more need to
publish the site manually. 

More details at https://issues.apache.org/jira/browse/SLING-7180 .

Thanks,

Robert



[jira] [Assigned] (SLING-7180) Set up a Jenkins job for automatically publishing the Sling site

2018-12-17 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7180:
--

Assignee: Robert Munteanu

> Set up a Jenkins job for automatically publishing the Sling site
> 
>
> Key: SLING-7180
> URL: https://issues.apache.org/jira/browse/SLING-7180
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
>
> Once we move to gitbox we should also automatically build + push the site 
> from a Jenkins job so that all we need to do is {{git push}} from the master 
> branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723153#comment-16723153
 ] 

Konrad Windszus commented on SLING-8182:


[~cziegeler] Would you mind checking the attached PR: 
https://github.com/apache/sling-site/pull/32

> Add documentation about servlet resolution order
> 
>
> Key: SLING-8182
> URL: https://issues.apache.org/jira/browse/SLING-8182
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The documentation at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
>  should include a paragraph about the order in which potential matching 
> servlets/scripts are considered.
> Aspects to be covered:
> * Consideration of property {{service.ranking}}
> * Amount of matching selectors and extension
> * Location of the matching resource type in the inheritance tree
> * OptingServlet vs. regular servlet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-8182:
--

Assignee: Konrad Windszus

> Add documentation about servlet resolution order
> 
>
> Key: SLING-8182
> URL: https://issues.apache.org/jira/browse/SLING-8182
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The documentation at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
>  should include a paragraph about the order in which potential matching 
> servlets/scripts are considered.
> Aspects to be covered:
> * Consideration of property {{service.ranking}}
> * Amount of matching selectors and extension
> * Location of the matching resource type in the inheritance tree
> * OptingServlet vs. regular servlet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling API 2.20.0, Apache Sling Servlets Resolver 2.5.2, Apache Sling Servlets Annotations 1.2.4

2018-12-17 Thread Daniel Klco
+1

On Mon, Dec 17, 2018 at 6:29 AM Karl Pauls  wrote:

> +1
>
> regards,
>
> Karl
> On Mon, Dec 17, 2018 at 11:04 AM Robert Munteanu 
> wrote:
> >
> > On Fri, 2018-12-14 at 18:49 +0100, Radu Cotescu wrote:
> > > Please vote to approve this release:
> >
> > +1
> >
> > Robert
>
>
>
> --
> Karl Pauls
> karlpa...@gmail.com
>


Re: [DISCUSS] Deprecate query part of Sling Event API

2018-12-17 Thread Stefan Egli

One more thought, which has been discussed offline earlier:

While it might take a while to agree on the deprecation and on how we 
recommend them to be replaced, there is a short-term option that would 
already help lower load on systems:


We could introduce a config option which would allow a job queue to 
opt-out of job queries voluntarily. That would allow the implementation 
to treat those jobs differently (cheaper, without indexing them).


I guess such a new opt-out of queries mechanism could be less 
controversial and provide at least some short-term gain. It doesn't 
answer the question how job queries should be replaced though..


Cheers,
Stefan


On 17.12.18 14:02, Stefan Egli wrote:

Hi Roy,

I think removal of the job API hasn't been discussed much yet, so 
that'll probably first have to happen separately.


Re deprecating the job queries: I think we should better understand the 
use cases for doing these queries. Why is it not possible to fire a job 
and forget, and why are queries needed/used. Ideally there would be an 
alternative data structure (eg the data the job operates on) which would 
be queried instead of the job itself.


Cheers,
Stefan

On 15.12.18 18:39, Roy Teeuwen wrote:

Hey guys,

Seeing as you are all talking about deprecating or even removing the 
entire Sling Job API in the future, what would you propose as 
alternative / migration path? We have a lot JobConsumers in our 
projects, what would be a reason to stop using them?


Greets,
Roy


On 30 Oct 2018, at 11:27, Stefan Egli  wrote:

On 30.10.18 10:22, Bertrand Delacretaz wrote:

Hi,
I agree, and we might use the following trick to avoid that with
minimal disruption:
-Consider the current interface "Legacy" that needs half of its
methods deprecated
-Move the non-deprecated methods to a new "Modern" interface
-Legacy inherits from Modern
Existing clients can then use Legacy with no change.
New clients move to Modern, to make it clear that they don't want to
use legacy stuff.
Mark the whole Legacy interface as deprecated, recommend moving to 
Modern

Existing services are explicitly registered as both Modern and Legacy.
No need to redesign things, just move them around.
WDYT?


+1, which would bring us to naming.. one suggestion would be

/** @deprecated */
public interface JobManager extends JobManager2 /* Modern */ {
..
}

Cheers,
Stefan




[jira] [Commented] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723049#comment-16723049
 ] 

Bertrand Delacretaz commented on SLING-8175:


Oh - of course, I should have checked that. All looks good after clearing local 
caches.

Sorry for the noise and thanks for these changes!

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Jason E Bailey (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723040#comment-16723040
 ] 

Jason E Bailey commented on SLING-8175:
---

[~bdelacretaz] could you look again? I checked locally and saw the same 
problem. However I changed the css to fix this when I did the initial release, 
it then appeared to have reverted for some reason.. github had my correct 
settings but there was a different set of CSS being pulled to the site.

Now, without me appearing to do anything, it looks correct again.

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723038#comment-16723038
 ] 

Bertrand Delacretaz commented on SLING-8175:


bq. I'll try to determine why that is showing up differently then expected...

Good thing that I included a screenshot then ;-)

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Jason E Bailey (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723031#comment-16723031
 ] 

Jason E Bailey commented on SLING-8175:
---

Fascinating. Thanks for pointing this out. I'll try to determine why that is 
showing up differently then expected and fix that.

 

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723021#comment-16723021
 ] 

Bertrand Delacretaz commented on SLING-8175:


Thanks for this! 

However on Firefox/macosx (screenshot attached) these changes create a lot of 
"wasted" space in the menu, do you think it would make sense to make it more 
compact? I'd suggest smaller left margins for both menu titles and items, and 
especially smaller vertical margins after the menu section titles.

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8175) Site - Modify side bar navigation

2018-12-17 Thread Bertrand Delacretaz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-8175:
---
Attachment: firefox-macosx.jpg

> Site - Modify side bar navigation
> -
>
> Key: SLING-8175
> URL: https://issues.apache.org/jira/browse/SLING-8175
> Project: Sling
>  Issue Type: Improvement
>  Components: Site
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Attachments: firefox-macosx.jpg
>
>
> Current navigation bar does not provide visual guidance as to what is a link 
> and what is a title of a series of links. This creates confusion and hinders 
> navigation. Additional navigation bar should be using the nav element to 
> provide context for navigation with electronic assistance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling Capabilities 0.1.2 and Apache Sling Capabilities JCR 0.1.2

2018-12-17 Thread Bertrand Delacretaz
Hi Robert,

On Fri, Dec 14, 2018 at 2:04 PM Robert Munteanu  wrote:
> ...Also, as a personal curiosity - we don't typically use the bundle names
> as release versions, was there a particular reason to do so?...

It was just me being inconsistent...I've fixed that now!

-Bertrand


[RESULT][VOTE] Release Apache Sling Capabilities 0.1.2 and Apache Sling Capabilities JCR 0.1.2

2018-12-17 Thread Bertrand Delacretaz
Hi,

On Thu, Dec 13, 2018 at 11:31 AM Bertrand Delacretaz
 wrote:
...
> https://repository.apache.org/content/repositories/orgapachesling-2026/
...

The vote passes with 4 binding +1s and no other votes.

I'll take care of the remaining steps.

-Bertrand


[jira] [Comment Edited] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722939#comment-16722939
 ] 

Konrad Windszus edited comment on SLING-8182 at 12/17/18 1:59 PM:
--

Basically each servlet (but not the script) is registered via its own 
{{ServletResourceProvider}}. The service.ranking is inherited from the 
underlying servlet service (compare with 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/e12a403c994f7899f4978a9b6e26a9a07f39e348/src/main/java/org/apache/sling/servlets/resolver/internal/resource/ServletMounter.java#L248).
 Each potential servlet is then looked up from the resource tree via the 
{{LocationIterator}}


was (Author: kwin):
Basically each servlet is registered via its own {{ServletResourceProvider}}. 
The service.ranking is inherited from the underlying servlet service (compare 
with 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/e12a403c994f7899f4978a9b6e26a9a07f39e348/src/main/java/org/apache/sling/servlets/resolver/internal/resource/ServletMounter.java#L248).
 Each potential servlet is then looked up from the resource tree via the 
{{LocationIterator}}

> Add documentation about servlet resolution order
> 
>
> Key: SLING-8182
> URL: https://issues.apache.org/jira/browse/SLING-8182
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Priority: Major
>
> The documentation at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
>  should include a paragraph about the order in which potential matching 
> servlets/scripts are considered.
> Aspects to be covered:
> * Consideration of property {{service.ranking}}
> * Amount of matching selectors and extension
> * Location of the matching resource type in the inheritance tree
> * OptingServlet vs. regular servlet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager 3.0.4, Apache Sling JCR ContentLoader 2.3.0

2018-12-17 Thread Radu Cotescu
+1

> On 17 Dec 2018, at 04:53, Eric Norman  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...



Re: [VOTE] Release Apache Sling Capabilities 0.1.2 and Apache Sling Capabilities JCR 0.1.2

2018-12-17 Thread Radu Cotescu
+1

> On 13 Dec 2018, at 11:31, Bertrand Delacretaz  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.



Re: [DISCUSS] Deprecate query part of Sling Event API

2018-12-17 Thread Stefan Egli

Hi Roy,

I think removal of the job API hasn't been discussed much yet, so 
that'll probably first have to happen separately.


Re deprecating the job queries: I think we should better understand the 
use cases for doing these queries. Why is it not possible to fire a job 
and forget, and why are queries needed/used. Ideally there would be an 
alternative data structure (eg the data the job operates on) which would 
be queried instead of the job itself.


Cheers,
Stefan

On 15.12.18 18:39, Roy Teeuwen wrote:

Hey guys,

Seeing as you are all talking about deprecating or even removing the entire 
Sling Job API in the future, what would you propose as alternative / migration 
path? We have a lot JobConsumers in our projects, what would be a reason to 
stop using them?

Greets,
Roy


On 30 Oct 2018, at 11:27, Stefan Egli  wrote:

On 30.10.18 10:22, Bertrand Delacretaz wrote:

Hi,
I agree, and we might use the following trick to avoid that with
minimal disruption:
-Consider the current interface "Legacy" that needs half of its
methods deprecated
-Move the non-deprecated methods to a new "Modern" interface
-Legacy inherits from Modern
Existing clients can then use Legacy with no change.
New clients move to Modern, to make it clear that they don't want to
use legacy stuff.
Mark the whole Legacy interface as deprecated, recommend moving to Modern
Existing services are explicitly registered as both Modern and Legacy.
No need to redesign things, just move them around.
WDYT?


+1, which would bring us to naming.. one suggestion would be

/** @deprecated */
public interface JobManager extends JobManager2 /* Modern */ {
..
}

Cheers,
Stefan




[jira] [Commented] (SLING-3821) Run launchpad integration tests against Sling on Karaf

2018-12-17 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722948#comment-16722948
 ] 

Robert Munteanu commented on SLING-3821:


[~olli] - I am not sure why we have mixed dependencies. I've checked the status 
for jackrabbit-jcr2dav and they seem consistent:

{noformat}[INFO] org.apache.jackrabbit:jackrabbit-jcr2dav:jar:2.16.4-SNAPSHOT
[INFO] +- javax.jcr:jcr:jar:2.0:provided
[INFO] +- org.apache.jackrabbit:jackrabbit-jcr2spi:jar:2.16.4-SNAPSHOT:compile
[INFO] |  +- org.apache.jackrabbit:jackrabbit-api:jar:2.16.4-SNAPSHOT:compile
[INFO] |  |  \- org.jetbrains:annotations:jar:16.0.3:compile
[INFO] |  +- org.apache.jackrabbit:jackrabbit-spi:jar:2.16.4-SNAPSHOT:compile
[INFO] |  +- 
org.apache.jackrabbit:jackrabbit-spi-commons:jar:2.16.4-SNAPSHOT:compile
[INFO] |  +- 
org.apache.jackrabbit:jackrabbit-jcr-commons:jar:2.16.4-SNAPSHOT:compile
[INFO] |  +- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] |  +- commons-collections:commons-collections:jar:3.2.2:compile
[INFO] |  \- commons-io:commons-io:jar:2.6:compile
[INFO] +- org.apache.jackrabbit:jackrabbit-spi2dav:jar:2.16.4-SNAPSHOT:compile
[INFO] |  +- org.apache.jackrabbit:jackrabbit-webdav:jar:2.16.4-SNAPSHOT:compile
[INFO] |  |  \- org.apache.httpcomponents:httpclient:jar:4.5.6:compile
[INFO] |  | +- org.apache.httpcomponents:httpcore:jar:4.4.10:compile
[INFO] |  | +- commons-logging:commons-logging:jar:1.2:compile
[INFO] |  | \- commons-codec:commons-codec:jar:1.10:compile
[INFO] |  \- org.apache.httpcomponents:httpmime:jar:4.5.6:compile
[INFO] +- org.apache.jackrabbit:jackrabbit-jcr-tests:jar:2.16.4-SNAPSHOT:test
[INFO] |  +- junit:junit:jar:4.12:test
[INFO] |  |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] |  \- concurrent:concurrent:jar:1.3.4:test
[INFO] +- 
org.apache.jackrabbit:jackrabbit-jcr2spi:jar:tests:2.16.4-SNAPSHOT:test
[INFO] +- org.apache.jackrabbit:jackrabbit-core:jar:2.16.4-SNAPSHOT:test
[INFO] |  +- commons-dbcp:commons-dbcp:jar:1.4:test
[INFO] |  |  \- commons-pool:commons-pool:jar:1.5.4:test
[INFO] |  +- org.apache.jackrabbit:jackrabbit-data:jar:2.16.4-SNAPSHOT:test
[INFO] |  +- org.apache.tika:tika-core:jar:1.19.1:test
[INFO] |  +- org.apache.lucene:lucene-core:jar:3.6.0:test
[INFO] |  +- org.apache.derby:derby:jar:10.14.2.0:test
[INFO] |  \- org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[INFO] +- org.apache.jackrabbit:jackrabbit-jcr-server:jar:2.16.4-SNAPSHOT:test
[INFO] |  \- commons-fileupload:commons-fileupload:jar:1.3.3:test
[INFO] +- org.eclipse.jetty:jetty-server:jar:9.2.24.v20180105:test
[INFO] |  +- javax.servlet:javax.servlet-api:jar:3.1.0:test
[INFO] |  +- org.eclipse.jetty:jetty-http:jar:9.2.24.v20180105:test
[INFO] |  |  \- org.eclipse.jetty:jetty-util:jar:9.2.24.v20180105:test
[INFO] |  \- org.eclipse.jetty:jetty-io:jar:9.2.24.v20180105:test
[INFO] +- org.eclipse.jetty:jetty-servlet:jar:9.2.24.v20180105:test
[INFO] |  \- org.eclipse.jetty:jetty-security:jar:9.2.24.v20180105:test
[INFO] \- ch.qos.logback:logback-classic:jar:1.2.3:test
[INFO]\- ch.qos.logback:logback-core:jar:1.2.3:test
{noformat}

> Run launchpad integration tests against Sling on Karaf
> --
>
> Key: SLING-3821
> URL: https://issues.apache.org/jira/browse/SLING-3821
> Project: Sling
>  Issue Type: Test
>  Components: Launchpad
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722939#comment-16722939
 ] 

Konrad Windszus commented on SLING-8182:


Basically each servlet is registered via its own {{ServletResourceProvider}}. 
The service.ranking is inherited from the underlying servlet service (compare 
with 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/e12a403c994f7899f4978a9b6e26a9a07f39e348/src/main/java/org/apache/sling/servlets/resolver/internal/resource/ServletMounter.java#L248).
 Each potential servlet is then looked up from the resource tree via the 
{{LocationIterator}}

> Add documentation about servlet resolution order
> 
>
> Key: SLING-8182
> URL: https://issues.apache.org/jira/browse/SLING-8182
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Priority: Major
>
> The documentation at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
>  should include a paragraph about the order in which potential matching 
> servlets/scripts are considered.
> Aspects to be covered:
> * Consideration of property {{service.ranking}}
> * Amount of matching selectors and extension
> * Location of the matching resource type in the inheritance tree
> * OptingServlet vs. regular servlet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8182:
---
Description: 
The documentation at 
https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
 should include a paragraph about the order in which potential matching 
servlets/scripts are considered.
Aspects to be covered:
* Consideration of property {{service.ranking}}
* Amount of matching selectors and extension
* Location of the matching resource type in the inheritance tree
* OptingServlet vs. regular servlet

  was:
The documentation at 
https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
 should include a paragraph about the order in which potential matching 
servlets/scripts are found.
Aspects to be covered:
* Consideration of property {{service.ranking}}
* Amount of matching selectors and extension
* Location of the matching resource type in the inheritance tree


> Add documentation about servlet resolution order
> 
>
> Key: SLING-8182
> URL: https://issues.apache.org/jira/browse/SLING-8182
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Priority: Major
>
> The documentation at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
>  should include a paragraph about the order in which potential matching 
> servlets/scripts are considered.
> Aspects to be covered:
> * Consideration of property {{service.ranking}}
> * Amount of matching selectors and extension
> * Location of the matching resource type in the inheritance tree
> * OptingServlet vs. regular servlet



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager 3.0.4, Apache Sling JCR ContentLoader 2.3.0

2018-12-17 Thread Karl Pauls
+1

regards,

Karl
On Mon, Dec 17, 2018 at 11:01 AM Robert Munteanu  wrote:
>
> On Sun, 2018-12-16 at 19:53 -0800, Eric Norman wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert



-- 
Karl Pauls
karlpa...@gmail.com


Re: [VOTE] Release Apache Sling API 2.20.0, Apache Sling Servlets Resolver 2.5.2, Apache Sling Servlets Annotations 1.2.4

2018-12-17 Thread Karl Pauls
+1

regards,

Karl
On Mon, Dec 17, 2018 at 11:04 AM Robert Munteanu  wrote:
>
> On Fri, 2018-12-14 at 18:49 +0100, Radu Cotescu wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert



-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Created] (SLING-8182) Add documentation about servlet resolution order

2018-12-17 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-8182:
--

 Summary: Add documentation about servlet resolution order
 Key: SLING-8182
 URL: https://issues.apache.org/jira/browse/SLING-8182
 Project: Sling
  Issue Type: Improvement
  Components: Documentation
Reporter: Konrad Windszus


The documentation at 
https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration
 should include a paragraph about the order in which potential matching 
servlets/scripts are found.
Aspects to be covered:
* Consideration of property {{service.ranking}}
* Amount of matching selectors and extension
* Location of the matching resource type in the inheritance tree



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7923) Simplify integration tests

2018-12-17 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-7923:

Fix Version/s: (was: JCR ContentLoader 2.2.8)
   JCR ContentLoader 2.3.2

> Simplify integration tests
> --
>
> Key: SLING-7923
> URL: https://issues.apache.org/jira/browse/SLING-7923
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.3.2
>
>
> * remove boilerplate code and use Testing PaxExam instead
> * use Sling Parent 34 and bnd Maven plugins



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8179) Remove feature sling-auth-selector

2018-12-17 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-8179.
-
Resolution: Done

> Remove feature sling-auth-selector
> --
>
> Key: SLING-8179
> URL: https://issues.apache.org/jira/browse/SLING-8179
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
> Karaf Distribution 0.2.0, Karaf Launchpad Integration Tests (Oak Tar) 0.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8180) Remove feature sling-auth-openid

2018-12-17 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-8180.
-
Resolution: Done

> Remove feature sling-auth-openid
> 
>
> Key: SLING-8180
> URL: https://issues.apache.org/jira/browse/SLING-8180
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
> Karaf Distribution 0.2.0, Karaf Launchpad Integration Tests (Oak Tar) 0.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling API 2.20.0, Apache Sling Servlets Resolver 2.5.2, Apache Sling Servlets Annotations 1.2.4

2018-12-17 Thread Robert Munteanu
On Fri, 2018-12-14 at 18:49 +0100, Radu Cotescu wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager 3.0.4, Apache Sling JCR ContentLoader 2.3.0

2018-12-17 Thread Robert Munteanu
On Sun, 2018-12-16 at 19:53 -0800, Eric Norman wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part