Failed Pipeline: sling-ide-tooling » master #70
See https://builds.apache.org/job/sling-ide-tooling/job/master/70/
[GitHub] JEBailey commented on a change in pull request #1: Sling 3270
JEBailey commented on a change in pull request #1: Sling 3270 URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r246820297 ## File path: pom.xml ## @@ -37,25 +37,36 @@ 8 -4.11.0 +4.12.0 +UTF-8 + UTF-8 scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git - HEAD - +HEAD + -biz.aQute.bnd -bnd-maven-plugin Review comment: @kwin the baselining still looks different. I've gone ahead and created a new accessible branch based off of this one where I have it configured for bnd. It's still giving me the same message. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kwin commented on a change in pull request #1: Sling 3270
kwin commented on a change in pull request #1: Sling 3270 URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r246815801 ## File path: pom.xml ## @@ -37,25 +37,36 @@ 8 -4.11.0 +4.12.0 +UTF-8 + UTF-8 scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git - HEAD - +HEAD + -biz.aQute.bnd -bnd-maven-plugin Review comment: bnd-maven-plugin uses bnd under the hood as well. Please use the newest version (4.1.0) and compare those result against the ones from the latest maven-bundle-plugin. They should look very similar! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JEBailey commented on a change in pull request #1: Sling 3270
JEBailey commented on a change in pull request #1: Sling 3270 URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r246815074 ## File path: pom.xml ## @@ -37,25 +37,36 @@ 8 -4.11.0 +4.12.0 +UTF-8 + UTF-8 scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git - HEAD - +HEAD + -biz.aQute.bnd -bnd-maven-plugin Review comment: @kwin I misunderstood, from my experience between the two it feels like the bnd-maven-plugin is the step back. However to answer your question. Of the multiple concerns that I encountered, the specific problem is that the baselining is ignoring the package-info.java when I use bnd-maven-plugin I get the following ``` [INFO] --- bnd-baseline-maven-plugin:3.5.0:baseline (default) @ org.apache.sling.commons.html --- [INFO] Automatically determining the baseline version for org.apache.sling:org.apache.sling.commons.html:jar:1.0.3-SNAPSHOT using repositories [apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots, default, releases+snapshots), central (https://artifact.unx.sas.com:443/artifactory/es-maven-libs-release, default, releases), snapshots (https://artifact.unx.sas.com:443/artifactory/es-maven-libs-snapshot, default, releases+snapshots), apache.snapshots (https://repository.apache.org/snapshots, default, snapshots)] [INFO] The baseline version was found to be 1.0.2 [ERROR] The bundle version change (1.0.2 to 1.0.3) is too low, the new version must be at least 1.1.0 ``` It's obtaining the versioning information from the bundle instead of the package-info. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kwin commented on a change in pull request #1: Sling 3270
kwin commented on a change in pull request #1: Sling 3270 URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r246785434 ## File path: pom.xml ## @@ -37,25 +37,36 @@ 8 -4.11.0 +4.12.0 +UTF-8 + UTF-8 scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git - HEAD - +HEAD + -biz.aQute.bnd -bnd-maven-plugin Review comment: @JEBailey Actually SLING-7351 suggests to move to bnd-maven-plugin and not to stick to maven-bundle-plugin. What exactly was not working with bnd-maven-plugin. Basically we try to slowly move away from the old maven-bundle-plugin and only use the bnd-maven-plugin. Going back to the maven-bundle-plugin just feels plain wrong to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Sling Type System: started a wiki page for concepts, ideas, motivation
On Thu, Jan 10, 2019 at 3:36 PM Carsten Ziegeler wrote: > This seems to have a lot in common what we already tried with the > validator api/module. > > https://github.com/apache/sling-org-apache-sling-validation-api ... Indeed, thanks for pointing this out. I was planning to merge ideas once we progress - for now I think Christanto's types know about "multiple" and "required" attributes, we probably need to add a more opaque Validator interface that might use this existing module underneath. But that can happen once we have at least an embryo of the Types API which I think should start as small as possible. -Bertrand
Re: Sling Type System: started a wiki page for concepts, ideas, motivation
This seems to have a lot in common what we already tried with the validator api/module. https://github.com/apache/sling-org-apache-sling-validation-api Carsten Bertrand Delacretaz wrote On Thu, Jan 10, 2019 at 4:33 AM Christanto Leonardo wrote: ...BTW I rename things to use "type" instead of "model"... Great! Would it be ok for you to extract the key interfaces into a separate module? I'm thinking of Types, DataType, AttributeDefinition and maybe a few others - just a minimal core that can be used to use the types, without considering how they are actually defined and with ideally no implementation details. My angle is to try to reduce the amount of things on which we need to agree on at this point - I'd then be able to recreate my minimal resource-schemas example based on these APIs, to verify that they provide what I need there, and you could pursue explorations independently on your side. -Bertrand -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Resolved] (SLING-8207) slingfeature-maven-plugin should mark 'analyse-features' goal as ignored for m2e
[ https://issues.apache.org/jira/browse/SLING-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8207. Resolution: Fixed Fixed with * [sling-slingfeature-maven-plugin commit 9e77c8b|https://github.com/apache/sling-slingfeature-maven-plugin/commit/9e77c8b] * [sling-slingfeature-maven-plugin commit dd04042|https://github.com/apache/sling-slingfeature-maven-plugin/commit/dd04042] > slingfeature-maven-plugin should mark 'analyse-features' goal as ignored for > m2e > > > Key: SLING-8207 > URL: https://issues.apache.org/jira/browse/SLING-8207 > Project: Sling > Issue Type: Bug > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: slingfeature-maven-plugin 0.8.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8207) slingfeature-maven-plugin should mark 'analyse-features' goal as ignored for m2e
Robert Munteanu created SLING-8207: -- Summary: slingfeature-maven-plugin should mark 'analyse-features' goal as ignored for m2e Key: SLING-8207 URL: https://issues.apache.org/jira/browse/SLING-8207 Project: Sling Issue Type: Bug Components: Feature Model, Maven Plugins and Archetypes Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: slingfeature-maven-plugin 0.8.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Sling Engine 2.6.18
+1 On Mon, Jan 7, 2019 at 11:11 AM Karl Pauls wrote: > +1 > > regards, > > Karl > > On Mon, Jan 7, 2019 at 5:03 PM Carsten Ziegeler > wrote: > > > > +1 > > > > > > Carsten > > > > > > Julian Sedding wrote > > > Hi, > > > > > > We solved 1 issues in the Apache Sling Engine 2.6.18 release: > > > https://issues.apache.org/jira/projects/SLING/versions/12344372 > > > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachesling-2032/ > > > > > > You can use this UNIX script to download the release and verify the > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: sh check_staged_release.sh 2032 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > > [ ]0 Don't care > > > [ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Julian > > > > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > > > > -- > Karl Pauls > karlpa...@gmail.com >
Re: [VOTE] Release Apache Sling Servlets Post 2.3.28
+1 On Wed, Jan 9, 2019 at 6:57 AM Radu Cotescu wrote: > +1 > > > On 9 Jan 2019, at 11:30, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > >
[jira] [Resolved] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-3270. --- Resolution: Fixed > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.0.4 > > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] JEBailey closed pull request #1: Sling 3270
JEBailey closed pull request #1: Sling 3270 URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Sling Type System: started a wiki page for concepts, ideas, motivation
On Thu, Jan 10, 2019 at 4:33 AM Christanto Leonardo wrote: > ...BTW I rename things to use "type" instead of "model"... Great! Would it be ok for you to extract the key interfaces into a separate module? I'm thinking of Types, DataType, AttributeDefinition and maybe a few others - just a minimal core that can be used to use the types, without considering how they are actually defined and with ideally no implementation details. My angle is to try to reduce the amount of things on which we need to agree on at this point - I'd then be able to recreate my minimal resource-schemas example based on these APIs, to verify that they provide what I need there, and you could pursue explorations independently on your side. -Bertrand
missing steps after creating new sling git repo
i've created a new sling git repo [1] for the first time following the steps from [2]. what is missing from this list or does not work yet: 1. although part of the sling-aggregator XML file no jenkins job is created for 'org-apache-sling-models-caconfig' - is there an additional configuration file? 2. the script 'generate-aggregator-table.sh' seems to generate the module lists in the docs subdir - i cannot execute this script on a windows machine. 3. the list contains the recommendation to add the project to the kibble demo instance (which is not even using SSL - which leaves a bad feeling creating an account there). i created a new account but was not able to add the new source. stefan [1] https://github.com/apache/sling-org-apache-sling-models-caconfig [2] https://cwiki.apache.org/confluence/x/TwWHB
[jira] [Resolved] (SLING-8113) Set statusfilepath of package-init to registryHome via content-extension
[ https://issues.apache.org/jira/browse/SLING-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß resolved SLING-8113. Resolution: Fixed > Set statusfilepath of package-init to registryHome via content-extension > > > Key: SLING-8113 > URL: https://issues.apache.org/jira/browse/SLING-8113 > Project: Sling > Issue Type: Improvement >Reporter: Dominik Süß >Assignee: Dominik Süß >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The statusfile of packageinit by default is persisted in the bundledata > repository to be by default agnostic of the filesystem structures. Anyhow in > case of usage along with content-extension the registry home is already > declared and is in contrast to the framework not supposed to be rebuilt and > therfore a more reliable location to store. As the content-extension already > generates the configuration for this service this is an easy addition to > persist the statusfile in the packageregistries home directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
