[GitHub] [sling-whiteboard] cziegeler merged pull request #40: Renaming to Sling Model Persist, fixed test error with JDK 11
cziegeler merged pull request #40: Renaming to Sling Model Persist, fixed test error with JDK 11 URL: https://github.com/apache/sling-whiteboard/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
RE: [VOTE] Release Apache Sling JCR Repoinit 1.1.12
+1
Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.4
+1 On Wed, Jun 26, 2019 at 11:48 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Jun 24, 2019, at 4:46 AM, Carsten Ziegeler > wrote: > > > > Hi, > > > > We solved 1 issue in this release > > > > https://issues.apache.org/jira/browse/SLING-8523 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2099 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2099 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > >
Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.4
+1 (non-binding) - Andy > On Jun 24, 2019, at 4:46 AM, Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > > https://issues.apache.org/jira/browse/SLING-8523 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2099 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2099 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
Re: [VOTE] Release Apache Sling Installer Factory Configuration 1.2.4
On Mon, 2019-06-24 at 13:46 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Resolved] (SLING-8243) Content Loader - support merge of properties and child nodes
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8243. --- Resolution: Fixed > Content Loader - support merge of properties and child nodes > > > Key: SLING-8243 > URL: https://issues.apache.org/jira/browse/SLING-8243 > Project: Sling > Issue Type: New Feature >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.3.2 > > > Currently the Content Loader doesn't support a merge feature, a merge feature > would provide the ability for the an import to update existing properties and > nodes, and additionally delete the specific properties and nodes that aren't > imported. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-jcr-contentloader] JEBailey merged pull request #1: Sling 8243 - support merge options
JEBailey merged pull request #1: Sling 8243 - support merge options URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Sling JCR Repoinit 1.1.12
+1 (non-binding) - Andy Schaefer > On Jun 26, 2019, at 2:58 AM, Karl Pauls wrote: > > I would like to call a vote on the Apache Sling JCR Repoinit 1.1.12 release. > > We solved 1 issue in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12345438 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2101/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2101 /tmp/sling-staging > > Please vote to approve these release: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling JCR Repoinit 1.1.12
On Wed, 2019-06-26 at 11:58 +0200, Karl Pauls wrote: > Please vote to approve these release: +1 Robert signature.asc Description: This is a digitally signed message part
[RESULT] [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Carsten Ziegeler, Stefan Seifert +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10
On Mon, 2019-06-17 at 13:12 +, Robert Munteanu wrote: > This majority vote is open for at least 72 hours. +1 Robert signature.asc Description: This is a digitally signed message part
[GitHub] [sling-org-apache-sling-models-api] kwin opened a new pull request #1: SLING-8452 migrate to OSGi annotations
kwin opened a new pull request #1: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-api/pull/1 upgrade to newest parent which forces us to require Java 8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [RESULT][VOTE] promote the feature-diff and r2f outside the whiteboard
Thanks a lot Robert, very appreciated! All the best, ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 3:39 PM Robert Munteanu wrote: > > Hi Simo, > > On Wed, 2019-06-26 at 14:15 +0200, Simone Tripodi wrote: > > Hi all, > > > > not being a PMC member I need someone's assistance who has enough > > karma to create the git repositories, I was thinking: > > > > * https://github.com/apache/sling-org-apache-sling-feature-diff > > * https://github.com/apache/sling-org-apache-sling-feature-r2f > > This looks good to me and I can help with the creation. Perhaps wait > until tomorrow in case anyone has any objections to the repository > names, as this is a decision that is "hard" to undo (i.e. requires > talking to INFRA). > > Robert
Re: [RESULT][VOTE] promote the feature-diff and r2f outside the whiteboard
Hi Simo, On Wed, 2019-06-26 at 14:15 +0200, Simone Tripodi wrote: > Hi all, > > not being a PMC member I need someone's assistance who has enough > karma to create the git repositories, I was thinking: > > * https://github.com/apache/sling-org-apache-sling-feature-diff > * https://github.com/apache/sling-org-apache-sling-feature-r2f This looks good to me and I can help with the creation. Perhaps wait until tomorrow in case anyone has any objections to the repository names, as this is a decision that is "hard" to undo (i.e. requires talking to INFRA). Robert
[jira] [Commented] (SLING-8537) Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL header
[
https://issues.apache.org/jira/browse/SLING-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873301#comment-16873301
]
Konrad Windszus commented on SLING-8537:
I temporarily disabled the header {{Bundle-DocURL}} in SLING-8538 to prevent
the wrong default values. We should reevaluate this, once the feature from
Maven 3.6.1 is more widely supported/adopted.
> Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL
> header
>
>
> Key: SLING-8537
> URL: https://issues.apache.org/jira/browse/SLING-8537
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> As the {{project->url}} element is also used to generate the
> {{Bundle-DocUrl}}
> (https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
> it would be nice to disable the unexpected Maven inheritance rules for that
> element: By default the value will be combined out of the {{parent value [+
> path adjustment] + artifactId}}
> (https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
> and
> http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
> Since Maven 3.6.0 this can be adjusted
> (https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
> option as the default inheritance rule for URLs does not make any sense for
> Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-8537) Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL header
[
https://issues.apache.org/jira/browse/SLING-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873238#comment-16873238
]
Konrad Windszus edited comment on SLING-8537 at 6/26/19 12:37 PM:
--
We should not yet implement this, as the feature from MNG-5951 is not supported
yet by Maven Central and Nexus 2
(https://issues.sonatype.org/browse/NEXUS-19912). Also it seems that m2e does
not yet support it in version 1.10. m2e 1.12 works fine though.
was (Author: kwin):
We should not yet implement this, as the feature from MNG-5951 is not supported
yet by Maven Central and Nexus 2
(https://issues.sonatype.org/browse/NEXUS-19912). Also it seems that m2e does
not yet support it...
> Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL
> header
>
>
> Key: SLING-8537
> URL: https://issues.apache.org/jira/browse/SLING-8537
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> As the {{project->url}} element is also used to generate the
> {{Bundle-DocUrl}}
> (https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
> it would be nice to disable the unexpected Maven inheritance rules for that
> element: By default the value will be combined out of the {{parent value [+
> path adjustment] + artifactId}}
> (https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
> and
> http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
> Since Maven 3.6.0 this can be adjusted
> (https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
> option as the default inheritance rule for URLs does not make any sense for
> Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8537) Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL header
[
https://issues.apache.org/jira/browse/SLING-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8537:
---
Summary: Avoid weird url inheritance rules in Maven leading to incorrect
Bundle-DocURL header (was: Avoid weird url inheritance rules in Maven)
> Avoid weird url inheritance rules in Maven leading to incorrect Bundle-DocURL
> header
>
>
> Key: SLING-8537
> URL: https://issues.apache.org/jira/browse/SLING-8537
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> As the {{project->url}} element is also used to generate the
> {{Bundle-DocUrl}}
> (https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
> it would be nice to disable the unexpected Maven inheritance rules for that
> element: By default the value will be combined out of the {{parent value [+
> path adjustment] + artifactId}}
> (https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
> and
> http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
> Since Maven 3.6.0 this can be adjusted
> (https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
> option as the default inheritance rule for URLs does not make any sense for
> Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8538) Temporarily disable creation of the Bundle-DocURL header
[
https://issues.apache.org/jira/browse/SLING-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-8538.
Resolution: Fixed
Fixed in
https://github.com/apache/sling-parent/commit/06c0931a7b97ce81e0261217c464b29f92bef207
> Temporarily disable creation of the Bundle-DocURL header
>
>
> Key: SLING-8538
> URL: https://issues.apache.org/jira/browse/SLING-8538
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Bundle Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 36
>
>
> Due to the issue outlined at SLING-8537 (which cannot easily be resolved)
> currently the Bundle-DocURL header has a wrong value. We should at least
> temporarily prevent that wrong {{Bundle-DocURL}} value from being emitted as
> long as we cannot fix the underlying issue.
> That can be achieved by placing an empty Bundle-DocURL in the inline bnd
> instructions. Each derived Maven module can still overwrite that header with
> its own value (which takes precedence).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8538) Temporarily disable creation of the Bundle-DocURL header
Konrad Windszus created SLING-8538:
--
Summary: Temporarily disable creation of the Bundle-DocURL header
Key: SLING-8538
URL: https://issues.apache.org/jira/browse/SLING-8538
Project: Sling
Issue Type: Improvement
Components: General
Affects Versions: Bundle Parent 35
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Bundle Parent 36
Due to the issue outlined at SLING-8537 (which cannot easily be resolved)
currently the Bundle-DocURL header has a wrong value. We should at least
temporarily prevent that wrong {{Bundle-DocURL}} value from being emitted as
long as we cannot fix the underlying issue.
That can be achieved by placing an empty Bundle-DocURL in the inline bnd
instructions. Each derived Maven module can still overwrite that header with
its own value (which takes precedence).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [RESULT][VOTE] promote the feature-diff and r2f outside the whiteboard
Hi all, not being a PMC member I need someone's assistance who has enough karma to create the git repositories, I was thinking: * https://github.com/apache/sling-org-apache-sling-feature-diff * https://github.com/apache/sling-org-apache-sling-feature-r2f Is there anybody available, please? Many thanks in advance! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 10:52 AM Simone Tripodi wrote: > > Hi all, > > more than 72h have passed and the current vote can be considered > closed and passes with following resolution: > > 4 binding votes from PMC members: > * Carsten Ziegeler > * Stefan Seifert > * Andrei Dulvac > * Timothee Maret > > 3 non-binding votes > * Simone Tripodi > * Daniel Klco > * Andreas Schaefer > > No other votes were casted. > > Thank you all who took part to the revision process, I'll go ahead on > submitting the repository creation. > > All the best, > ~Simo > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > > On Sun, Jun 23, 2019 at 10:06 AM Simone Tripodi > wrote: > > > > Hi all, > > after a while of staging, this email to submit my feature-diff [1] and > > runtime2feature [2] proposals to be promoted as regular Apache Sling > > modules. > > > > They are both valid OSGi bundles with simple Service APIs described in > > the README. > > > > feature-diff module is already part of the SLING-8468 [3] proposal, > > runtime2feature, which depends by feature-diff, is used to implements > > new Sling Feature InventoryPrinter [4] instances. > > > > Please cast your votes > > > > [ ] +1 Approve the promotion > > [ ] 0 Don't care > > [ ] -1 Don't promote, because ... > > > > Vote will be open for at least 72h and will close on ~2019-06-26T10:15:00 +1 > > > > Many thanks in advance! > > ~Simo > > > > [1] https://github.com/apache/sling-whiteboard/tree/master/feature-diff > > [2] https://github.com/apache/sling-whiteboard/tree/master/runtime2feature > > [3] https://issues.apache.org/jira/browse/SLING-8468 > > [4] > > https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/tree/r2f > > > > http://people.apache.org/~simonetripodi/ > > http://twitter.com/simonetripodi
Re: [VOTE] Release Apache Sling JCR Repoinit 1.1.12
+1 (non binding) http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 11:59 AM Karl Pauls wrote: > > I would like to call a vote on the Apache Sling JCR Repoinit 1.1.12 release. > > We solved 1 issue in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12345438 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2101/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2101 /tmp/sling-staging > > Please vote to approve these release: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[jira] [Reopened] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reopened SLING-8452: Still outstanding: Models API and Exporter > Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations > --- > > Key: SLING-8452 > URL: https://issues.apache.org/jira/browse/SLING-8452 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Sling Models API 1.3.8, Sling Models Validation Impl > 1.0.0, Sling Models Jackson Exporter 1.0.8, Sling Models Impl 1.4.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Even the R6 metatype annotations should work in this case as currently we > don't have any attributes with hyphens in the name (which are only supported > since R7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8452) Migrate from Felix SCR annotations to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8452: --- Affects Version/s: Sling Models Validation Impl 1.0.0 Sling Models API 1.3.8 Sling Models Jackson Exporter 1.0.8 > Migrate from Felix SCR annotations to OSGi R6 annotations > - > > Key: SLING-8452 > URL: https://issues.apache.org/jira/browse/SLING-8452 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Sling Models API 1.3.8, Sling Models Validation Impl > 1.0.0, Sling Models Jackson Exporter 1.0.8, Sling Models Impl 1.4.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Even the R6 metatype annotations should work in this case as currently we > don't have any attributes with hyphens in the name (which are only supported > since R7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8452) Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8452: --- Summary: Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations (was: Migrate from Felix SCR annotations to OSGi R6 annotations) > Sling Models: Migrate from Felix SCR annotations to OSGi R6 annotations > --- > > Key: SLING-8452 > URL: https://issues.apache.org/jira/browse/SLING-8452 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Sling Models API 1.3.8, Sling Models Validation Impl > 1.0.0, Sling Models Jackson Exporter 1.0.8, Sling Models Impl 1.4.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Even the R6 metatype annotations should work in this case as currently we > don't have any attributes with hyphens in the name (which are only supported > since R7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS] proposing first apiregions-model release
Hi Carsten, I didn't know the sling-bundle-parent - once plugged, it works like a charm!!! :O Thanks a lot! ~Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Jun 26, 2019 at 1:27 PM Carsten Ziegeler wrote: > > Hi Simo, > > > are you using "sling-bundle-parent" as the artifact id for the parent, > it should automatically create the bundle > > > Carsten > > > Simone Tripodi wrote > > Hi again Carsten > > > > once parent is updated to v35, how to enable the build in order to > > automatically produce a valid OSGi bundle? > > TIA! > > ~Simo > > > > http://people.apache.org/~simonetripodi/ > > http://twitter.com/simonetripodi > > > > On Wed, Jun 26, 2019 at 1:01 PM Carsten Ziegeler > > wrote: > >> > >> Hi Simo, > >> > >> > >> I did a quick review, two comments: > >> > >> https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java > >> is missing a package version > >> > >> and you could use the latest sling-bundle parent pom which already > >> contains the required configuration to build bundles, making your pom > >> smaller > >> > >> > >> Regards > >> > >> Carsten > >> > >> > >> Simone Tripodi wrote > >>> Hi all, > >>> > >>> is anybody available to do a quick review, please? Just to make sure > >>> the new bundle satisfies all the requirements... > >>> > >>> TIA! > >>> ~Simo > >>> > >>> http://people.apache.org/~simonetripodi/ > >>> http://twitter.com/simonetripodi > >>> > >>> On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi > >>> wrote: > > Hi all, > I would like to start working towards the first apiregions-model [1] > bundle release, I would like so to kindly ask if anyone is available > for a review before submitting a new [VOTE]. > > Any feedback/suggestion will be more than appreciated, many thanks in > advance! > ~Simo > > [1] > https://github.com/apache/sling-org-apache-sling-feature-apiregions-model > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > >> -- > >> Carsten Ziegeler > >> Adobe Research Switzerland > >> cziege...@apache.org > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
Re: [DISCUSS] proposing first apiregions-model release
Hi Simo, are you using "sling-bundle-parent" as the artifact id for the parent, it should automatically create the bundle Carsten Simone Tripodi wrote Hi again Carsten once parent is updated to v35, how to enable the build in order to automatically produce a valid OSGi bundle? TIA! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 1:01 PM Carsten Ziegeler wrote: Hi Simo, I did a quick review, two comments: https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java is missing a package version and you could use the latest sling-bundle parent pom which already contains the required configuration to build bundles, making your pom smaller Regards Carsten Simone Tripodi wrote Hi all, is anybody available to do a quick review, please? Just to make sure the new bundle satisfies all the requirements... TIA! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi wrote: Hi all, I would like to start working towards the first apiregions-model [1] bundle release, I would like so to kindly ask if anyone is available for a review before submitting a new [VOTE]. Any feedback/suggestion will be more than appreciated, many thanks in advance! ~Simo [1] https://github.com/apache/sling-org-apache-sling-feature-apiregions-model http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [DISCUSS] proposing first apiregions-model release
Hi again Carsten once parent is updated to v35, how to enable the build in order to automatically produce a valid OSGi bundle? TIA! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 1:01 PM Carsten Ziegeler wrote: > > Hi Simo, > > > I did a quick review, two comments: > > https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java > is missing a package version > > and you could use the latest sling-bundle parent pom which already > contains the required configuration to build bundles, making your pom > smaller > > > Regards > > Carsten > > > Simone Tripodi wrote > > Hi all, > > > > is anybody available to do a quick review, please? Just to make sure > > the new bundle satisfies all the requirements... > > > > TIA! > > ~Simo > > > > http://people.apache.org/~simonetripodi/ > > http://twitter.com/simonetripodi > > > > On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi > > wrote: > >> > >> Hi all, > >> I would like to start working towards the first apiregions-model [1] > >> bundle release, I would like so to kindly ask if anyone is available > >> for a review before submitting a new [VOTE]. > >> > >> Any feedback/suggestion will be more than appreciated, many thanks in > >> advance! > >> ~Simo > >> > >> [1] > >> https://github.com/apache/sling-org-apache-sling-feature-apiregions-model > >> > >> http://people.apache.org/~simonetripodi/ > >> http://twitter.com/simonetripodi > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
[jira] [Commented] (SLING-8537) Avoid weird url inheritance rules in Maven
[
https://issues.apache.org/jira/browse/SLING-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873238#comment-16873238
]
Konrad Windszus commented on SLING-8537:
We should not yet implement this, as the feature from MNG-5951 is not supported
yet by Maven Central and Nexus 2
(https://issues.sonatype.org/browse/NEXUS-19912). Also it seems that m2e does
not yet support it...
> Avoid weird url inheritance rules in Maven
> --
>
> Key: SLING-8537
> URL: https://issues.apache.org/jira/browse/SLING-8537
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> As the {{project->url}} element is also used to generate the
> {{Bundle-DocUrl}}
> (https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
> it would be nice to disable the unexpected Maven inheritance rules for that
> element: By default the value will be combined out of the {{parent value [+
> path adjustment] + artifactId}}
> (https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
> and
> http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
> Since Maven 3.6.0 this can be adjusted
> (https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
> option as the default inheritance rule for URLs does not make any sense for
> Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] proposing first apiregions-model release
Thanks a lot for your help Carsten, very appreciated! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Wed, Jun 26, 2019 at 1:01 PM Carsten Ziegeler wrote: > > Hi Simo, > > > I did a quick review, two comments: > > https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java > is missing a package version > > and you could use the latest sling-bundle parent pom which already > contains the required configuration to build bundles, making your pom > smaller > > > Regards > > Carsten > > > Simone Tripodi wrote > > Hi all, > > > > is anybody available to do a quick review, please? Just to make sure > > the new bundle satisfies all the requirements... > > > > TIA! > > ~Simo > > > > http://people.apache.org/~simonetripodi/ > > http://twitter.com/simonetripodi > > > > On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi > > wrote: > >> > >> Hi all, > >> I would like to start working towards the first apiregions-model [1] > >> bundle release, I would like so to kindly ask if anyone is available > >> for a review before submitting a new [VOTE]. > >> > >> Any feedback/suggestion will be more than appreciated, many thanks in > >> advance! > >> ~Simo > >> > >> [1] > >> https://github.com/apache/sling-org-apache-sling-feature-apiregions-model > >> > >> http://people.apache.org/~simonetripodi/ > >> http://twitter.com/simonetripodi > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
[jira] [Created] (SLING-8537) Avoid weird url inheritance rules in Maven
Konrad Windszus created SLING-8537:
--
Summary: Avoid weird url inheritance rules in Maven
Key: SLING-8537
URL: https://issues.apache.org/jira/browse/SLING-8537
Project: Sling
Issue Type: Improvement
Components: General
Affects Versions: Parent 35
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Parent 36
As the {{project->url}} element is also used to generate the {{Bundle-DocUrl}}
(https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
it would be nice to disable the unexpected Maven inheritance rules for that
element: By default the value will be combined out of the {{parent value [+
path adjustment] + artifactId}}
(https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186).
Since Maven 3.6.0 this can be adjusted
(https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
option as the default inheritance rule for URLs does not make any sense for
Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8537) Avoid weird url inheritance rules in Maven
[
https://issues.apache.org/jira/browse/SLING-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8537:
---
Description:
As the {{project->url}} element is also used to generate the {{Bundle-DocUrl}}
(https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
it would be nice to disable the unexpected Maven inheritance rules for that
element: By default the value will be combined out of the {{parent value [+
path adjustment] + artifactId}}
(https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
and
http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
Since Maven 3.6.0 this can be adjusted
(https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
option as the default inheritance rule for URLs does not make any sense for
Sling.
was:
As the {{project->url}} element is also used to generate the {{Bundle-DocUrl}}
(https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
it would be nice to disable the unexpected Maven inheritance rules for that
element: By default the value will be combined out of the {{parent value [+
path adjustment] + artifactId}}
(https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186).
Since Maven 3.6.0 this can be adjusted
(https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
option as the default inheritance rule for URLs does not make any sense for
Sling.
> Avoid weird url inheritance rules in Maven
> --
>
> Key: SLING-8537
> URL: https://issues.apache.org/jira/browse/SLING-8537
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> As the {{project->url}} element is also used to generate the
> {{Bundle-DocUrl}}
> (https://github.com/bndtools/bnd/blob/master/maven/bnd-maven-plugin/README.md#default-bundle-headers)
> it would be nice to disable the unexpected Maven inheritance rules for that
> element: By default the value will be combined out of the {{parent value [+
> path adjustment] + artifactId}}
> (https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/maven.mdo#L186
> and
> http://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly).
> Since Maven 3.6.0 this can be adjusted
> (https://issues.apache.org/jira/browse/MNG-5951). We should leverage that
> option as the default inheritance rule for URLs does not make any sense for
> Sling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] proposing first apiregions-model release
Hi Simo, I did a quick review, two comments: https://github.com/apache/sling-org-apache-sling-feature-apiregions-model/blob/master/src/main/java/org/apache/sling/feature/apiregions/model/io/json/package-info.java is missing a package version and you could use the latest sling-bundle parent pom which already contains the required configuration to build bundles, making your pom smaller Regards Carsten Simone Tripodi wrote Hi all, is anybody available to do a quick review, please? Just to make sure the new bundle satisfies all the requirements... TIA! ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Mon, Jun 24, 2019 at 4:29 PM Simone Tripodi wrote: Hi all, I would like to start working towards the first apiregions-model [1] bundle release, I would like so to kindly ask if anyone is available for a review before submitting a new [VOTE]. Any feedback/suggestion will be more than appreciated, many thanks in advance! ~Simo [1] https://github.com/apache/sling-org-apache-sling-feature-apiregions-model http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Assigned] (SLING-8536) /jcr_root/rep:policy node is not being processed by the CP- FM converter
[ https://issues.apache.org/jira/browse/SLING-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8536: - Assignee: Simone Tripodi > /jcr_root/rep:policy node is not being processed by the CP- FM converter > > > Key: SLING-8536 > URL: https://issues.apache.org/jira/browse/SLING-8536 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > h3. Problem > /jcr_root/rep:policy nodes is not processed due to the filter regex. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8536) /jcr_root/rep:policy node is not being processed by the CP- FM converter
[ https://issues.apache.org/jira/browse/SLING-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8536. --- Resolution: Fixed PR merged, thanks a lot Andrei! > /jcr_root/rep:policy node is not being processed by the CP- FM converter > > > Key: SLING-8536 > URL: https://issues.apache.org/jira/browse/SLING-8536 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Andrei Tuicu >Assignee: Simone Tripodi >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > h3. Problem > /jcr_root/rep:policy nodes is not processed due to the filter regex. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] simonetripodi merged pull request #6: SLING-8536 - /jcr_root/rep:policy node is not being processed by the CP- FM converter
simonetripodi merged pull request #6: SLING-8536 - /jcr_root/rep:policy node is not being processed by the CP- FM converter URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature-cpconverter] andreituicu opened a new pull request #6: SLING-8536 - /jcr_root/rep:policy node is not being processed by the CP- FM converter
andreituicu opened a new pull request #6: SLING-8536 - /jcr_root/rep:policy node is not being processed by the CP- FM converter URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-8536) /jcr_root/rep:policy node is not being processed by the CP- FM converter
Andrei Tuicu created SLING-8536: --- Summary: /jcr_root/rep:policy node is not being processed by the CP- FM converter Key: SLING-8536 URL: https://issues.apache.org/jira/browse/SLING-8536 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Reporter: Andrei Tuicu h3. Problem /jcr_root/rep:policy nodes is not processed due to the filter regex. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8452) Migrate from Felix SCR annotations to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8452: --- Fix Version/s: Sling Models Impl 1.4.12 > Migrate from Felix SCR annotations to OSGi R6 annotations > - > > Key: SLING-8452 > URL: https://issues.apache.org/jira/browse/SLING-8452 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Sling Models Impl 1.4.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Even the R6 metatype annotations should work in this case as currently we > don't have any attributes with hyphens in the name (which are only supported > since R7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8452) Migrate from Felix SCR annotations to OSGi R6 annotations
[ https://issues.apache.org/jira/browse/SLING-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-8452. Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-models-impl/commit/398a382724154eb6bd80bd9d4142f100fee2532c. > Migrate from Felix SCR annotations to OSGi R6 annotations > - > > Key: SLING-8452 > URL: https://issues.apache.org/jira/browse/SLING-8452 > Project: Sling > Issue Type: Improvement > Components: Sling Models >Affects Versions: Sling Models Impl 1.4.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Models Impl 1.4.12 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Even the R6 metatype annotations should work in this case as currently we > don't have any attributes with hyphens in the name (which are only supported > since R7). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-models-impl] kwin merged pull request #13: SLING-8452 migrate to OSGi annotations
kwin merged pull request #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Sling JCR Repoinit 1.1.12
+1 Carsten Karl Pauls wrote I would like to call a vote on the Apache Sling JCR Repoinit 1.1.12 release. We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12345438 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2101/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2101 /tmp/sling-staging Please vote to approve these release: [ ] +1 Approve the releases [ ] 0 Don't care [ ] -1 Don't release, because ... -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE] Release Apache Sling JCR Repoinit 1.1.12
I would like to call a vote on the Apache Sling JCR Repoinit 1.1.12 release. We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12345438 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2101/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2101 /tmp/sling-staging Please vote to approve these release: [ ] +1 Approve the releases [ ] 0 Don't care [ ] -1 Don't release, because ...
[jira] [Resolved] (SLING-8535) RepoInit register privilege fails if privilege already exists
[ https://issues.apache.org/jira/browse/SLING-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-8535. --- Resolution: Fixed Fixed in 417aa89..62e255f. > RepoInit register privilege fails if privilege already exists > - > > Key: SLING-8535 > URL: https://issues.apache.org/jira/browse/SLING-8535 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Repoinit JCR 1.1.12 > > > The PrivilegeVisitor does assume that a registerPriv does work if the priv is > already defined. That is wrong as at least currently, it throws an > implementation specific exception. We need to check if the priv exists first > as a consequence as repoinit needs to be idempotent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-models-impl] kwin edited a comment on issue #13: SLING-8452 migrate to OSGi annotations
kwin edited a comment on issue #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#issuecomment-505790055 > when compiling the models.impl with the branch, the sling-org-apache-sling-models-integration-tests project fails (probably only because the launchpad used for the project is outdated - the impl bundle cannot be deployed). this would be a good additional test for this branch. Thanks for that hint, this was due to a missing service implementation. The diff tool at https://github.com/jsedding/osgi-ds-metatype-diff was unfortunately not exposing those differences (https://github.com/jsedding/osgi-ds-metatype-diff/issues/11). I fixed this in https://github.com/apache/sling-org-apache-sling-models-impl/pull/13/commits/761bd9c91a66dcd61b14b156496ff3b1514fbd92 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit
[ https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6423: -- Fix Version/s: (was: Repoinit JCR 1.1.12) Repoinit JCR 1.1.14 > Allow for specifying ACL merge mode (ACHandling) in repoinit > > > Key: SLING-6423 > URL: https://issues.apache.org/jira/browse/SLING-6423 > Project: Sling > Issue Type: New Feature > Components: Repoinit >Reporter: Nitin Nizhawan >Assignee: Timothee Maret >Priority: Major > Fix For: Repoinit JCR 1.1.14 > > Attachments: SLING-6423_parser_changes.patch, > SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch > > > Repoinit by default just add new ACLs if they are not already present. > By contract package manager provides various strategies for ACL merging > Extend repoinit to allow specifying these strategies > https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7147) Support ACL remove * statement
[
https://issues.apache.org/jira/browse/SLING-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-7147:
--
Fix Version/s: (was: Repoinit JCR 1.1.12)
Repoinit JCR 1.1.14
> Support ACL remove * statement
> --
>
> Key: SLING-7147
> URL: https://issues.apache.org/jira/browse/SLING-7147
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Repoinit JCR 1.1.14
>
>
> The repoinit parser supports removing all ACLs with the syntax
> {code}
> set ACL on
> remove * for
> end
> {code}
> and
> {code}
> set ACL for
> remove * on
> end
> {code}
> However, the JCR implementation does not seem to support it.
> This issue is about implementing the {{remove *}} statements for ACLs in the
> JCR repoinit implementation.
> cc [~bdelacretaz]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [sling-org-apache-sling-models-impl] kwin edited a comment on issue #13: SLING-8452 migrate to OSGi annotations
kwin edited a comment on issue #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#issuecomment-505790055 > when compiling the models.impl with the branch, the sling-org-apache-sling-models-integration-tests project fails (probably only because the launchpad used for the project is outdated - the impl bundle cannot be deployed). this would be a good additional test for this branch. Thanks for that, this was due to a missing service implementation. The diff tool at https://github.com/jsedding/osgi-ds-metatype-diff was unfortunately not exposing those differences (https://github.com/jsedding/osgi-ds-metatype-diff/issues/11). I fixed this in https://github.com/apache/sling-org-apache-sling-models-impl/pull/13/commits/761bd9c91a66dcd61b14b156496ff3b1514fbd92 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-models-impl] kwin commented on issue #13: SLING-8452 migrate to OSGi annotations
kwin commented on issue #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#issuecomment-505790055 > i'm very unsure about all those diffs on the ModelAdapterFactory. > > when compiling the models.impl with the branch, the sling-org-apache-sling-models-integration-tests project fails (probably only because the launchpad used for the project is outdated - the impl bundle cannot be deployed). this would be a good additional test for this branch. Thanks for that, this was due to a missing service implementation. The diff tool at https://github.com/jsedding/osgi-ds-metatype-diff was unfortunately not exposing those differences (https://github.com/jsedding/osgi-ds-metatype-diff/issues/11). I fixed this in https://github.com/apache/sling-org-apache-sling-models-impl/pull/13/commits/761bd9c91a66dcd61b14b156496ff3b1514fbd92 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[RESULT][VOTE] promote the feature-diff and r2f outside the whiteboard
Hi all, more than 72h have passed and the current vote can be considered closed and passes with following resolution: 4 binding votes from PMC members: * Carsten Ziegeler * Stefan Seifert * Andrei Dulvac * Timothee Maret 3 non-binding votes * Simone Tripodi * Daniel Klco * Andreas Schaefer No other votes were casted. Thank you all who took part to the revision process, I'll go ahead on submitting the repository creation. All the best, ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Sun, Jun 23, 2019 at 10:06 AM Simone Tripodi wrote: > > Hi all, > after a while of staging, this email to submit my feature-diff [1] and > runtime2feature [2] proposals to be promoted as regular Apache Sling > modules. > > They are both valid OSGi bundles with simple Service APIs described in > the README. > > feature-diff module is already part of the SLING-8468 [3] proposal, > runtime2feature, which depends by feature-diff, is used to implements > new Sling Feature InventoryPrinter [4] instances. > > Please cast your votes > > [ ] +1 Approve the promotion > [ ] 0 Don't care > [ ] -1 Don't promote, because ... > > Vote will be open for at least 72h and will close on ~2019-06-26T10:15:00 +1 > > Many thanks in advance! > ~Simo > > [1] https://github.com/apache/sling-whiteboard/tree/master/feature-diff > [2] https://github.com/apache/sling-whiteboard/tree/master/runtime2feature > [3] https://issues.apache.org/jira/browse/SLING-8468 > [4] > https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/tree/r2f > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi
[jira] [Created] (SLING-8535) RepoInit register privilege fails if privilege already exists
Karl Pauls created SLING-8535: - Summary: RepoInit register privilege fails if privilege already exists Key: SLING-8535 URL: https://issues.apache.org/jira/browse/SLING-8535 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit JCR 1.1.10 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Repoinit JCR 1.1.12 The PrivilegeVisitor does assume that a registerPriv does work if the priv is already defined. That is wrong as at least currently, it throws an implementation specific exception. We need to check if the priv exists first as a consequence as repoinit needs to be idempotent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
