Re: Feature Launcher / Starter Mojo

2020-01-14 Thread Andreas Schaefer 
Hi

The sling-org-apache-sling-feature-starter which is creating an executable JAR 
file is also using the sling-slingstart-feature-maven-plugin to later test the 
JAR file (for now it is starting it in a separate profile).

To build 'sling-org-apache-sling-feature-starter’ first the maven plugin must 
be built: 'sling-slingstart-feature-maven-plugin’ with:

mvn clean install

Afterwards the 'sling-org-apache-sling-feature-starter’ can be built and the 
maven plugin can be test with:

mvn clean install -P launch

To make the launch also stop the instance just comment out this line: 
'true’

Let me know if you run into any issues or want to suggest changes.

My next steps are to incorporate the logging from the instance back to starter 
and to clean up the migration.

- Andy

> On Jan 14, 2020, at 11:33 AM, Andreas Schaefer  
> wrote:
> 
> Hi
> 
> I ran into a little snag with the Feature Starter Maven Plugin. Even though 
> the Sling Starter has a Control Listener to check the status and to stop it 
> after the launch from another process the Sling Launchpad Base creates a 
> MBean / MBean Startup Handler to check if the the service is up and running.
> 
> As the Feature Launcher has no MBean Server integration I am going to change 
> the logic so that a Control Listener is created even w/o a Control Action so 
> that the it can be used to check if the server is up and running (status == 
> OK).
> 
> Let me know if you think that the MBean Server integration (see Launchpad 
> Base DefaultStartupHandler) should be added and then I assume into the 
> Feature Launcher.
> 
> - Andy

Feature Launcher / Starter Mojo

2020-01-14 Thread Andreas Schaefer 
Hi

I ran into a little snag with the Feature Starter Maven Plugin. Even though the 
Sling Starter has a Control Listener to check the status and to stop it after 
the launch from another process the Sling Launchpad Base creates a MBean / 
MBean Startup Handler to check if the the service is up and running.

As the Feature Launcher has no MBean Server integration I am going to change 
the logic so that a Control Listener is created even w/o a Control Action so 
that the it can be used to check if the server is up and running (status == OK).

Let me know if you think that the MBean Server integration (see Launchpad Base 
DefaultStartupHandler) should be added and then I assume into the Feature 
Launcher.

- Andy

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

2020-01-14 Thread Carsten Ziegeler (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015212#comment-17015212
 ] 

Carsten Ziegeler commented on SLING-7760:
-

I see, thanks - so how do you envision to make the decision which configuration 
to use?
In the main servlet, we only have what the request provides, the headers are 
atm set before resource resolution

> Sling Main Servlet - Change header configuration to a service
> -
>
> Key: SLING-7760
> URL: https://issues.apache.org/jira/browse/SLING-7760
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
>
> The ability to set headers must be done prior to any writing that occurs the 
> output stream. This is the reason why the headers are set to be configured in 
> the Sling Main Servlet.
> With Sling being used to maintain multiple sites, having a single set of 
> response headers creates problems where the header provides a non tailored 
> response. One site may have a conflicting set of requirements then another 
> site.
> If the setting of headers was moved from being a configuration to being a 
> service used by the Main Servlet, this would allow the following:
>  * Headers set on a per site basis
>  * Headers based on selected resource
>  * Ability to modify the headers without causing the restart of the Sling 
> Main Servlet
>  ** Which if you're dealing with CSP headers can be a constant pain
>  * Ability to create a CSP configuration Service that eases the use of CSP 
> creation
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

2020-01-14 Thread Jason E Bailey (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015169#comment-17015169
 ] 

Jason E Bailey commented on SLING-7760:
---

[~cziegeler] Here's a some of the headers that we currently have. Note that the 
Content-Security-Policy is huge because we have 5 separate domains that we 
serve out of our instances. So any one domain has permissions to source data 
from a domain it doesn't actually interact with because another one of our 
domains requires it.

X-Content-Type-Options: nosniff
X-XSS-Protection: 1;mode=block
X-Frame-Options: sameorigin
Content-Security-Policy: default-src * 'self' data: 'unsafe-inline' 
blob:;script-src * 'self' blob: data: 'unsafe-inline' 'unsafe-eval' 
*.trustarc.com *.doubleclick.net *.liveperson.net *.sas.com assets.adobedtm.com 
ssl.google-analytics.com accdn.lpsnmedia.net www.googletagmanager.com 
www.google-analytics.com bat.bing.com benchtag.co front.facetz.net 
*.facebook.net *.facebook.com www.googleadservices.com tb.juiceadv.com 
*.linkedin.com pixel.mathtag.com pixel.quantserve.com *.quora.com 
analytics.twitter.com tagmanager.google.com mc.yandex.ru static.ads-twitter.com 
snap.licdn.com *.bizographics.com dev.visualwebsiteoptimizer.com 
scripts.demandbase.com consent.truste.com s.yimg.com ssl.gstatic.com 
api.company-target.com script.crazyegg.com platform.twitter.com 
sp.analytics.yahoo.com x.bidswitch.net s7.addthis.com ad4.adfarm1.adition.com 
livestream.co *.brightcove.net track.adform.net insight.adsrvr.org 
www.vintom.com b92.yahoo.co.jp cdn.appdynamics.com 
execution-dscvrtraffic.cidev.sas.us *.brightcove.com *.mrpfd.com d3js.org 
*.d3.org;img-src * 'self' data: *.google-analytics.com *.doubleclick.net 
www.google.com *.sas.com front.facetz.net *.facebook.com 
www.googleadservices.com tb.juiceadv.com ext.ligatus.com bcp.crwdcntrl.net 
pixel.mathtag.com *.quora.com cdn.taboola.com analytics.twitter.com 
d.company-target.com mc.yandex.ru t.co px.ads.linkedin.com *.bizographics.com 
insight.adsrvr.org assets.adobedtm.com *.brightcove.com;font-src * 'self' data: 
*.sas.com fast.fonts.net;connect-src * 'self' *.sas.com *.brightcove.com 
ma156-r.analytics.edgekey.net api.company-target.com livestream.com 
www.vintom.com *.doubleclick.net assets.adobedtm.com;frame-src 'self' 
assets.adobedtm.com lpcdn.lpsnmedia.net *.liveperson.net www.youtube.com 
s7.addthis.com *.twitter.com *.sas.com pixel.mathtag.com livestream.com 
ad4.adfarm1.adition.com www.vintom.com *.doubleclick.net *.facebook.net 
*.twitter.com *.trustarc.com *.facebook.com *.linkedin.com;frame-ancestors 
*.ci360.sas.com *.gatheriq.analytics *.curriculumpathways.com
Cache-Control: max-age=3600

As you can see the Content-Security-Policy is the problem child and could do 
with some sort of tool to assist in it's creation in it's own right.

 

 

> Sling Main Servlet - Change header configuration to a service
> -
>
> Key: SLING-7760
> URL: https://issues.apache.org/jira/browse/SLING-7760
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
>
> The ability to set headers must be done prior to any writing that occurs the 
> output stream. This is the reason why the headers are set to be configured in 
> the Sling Main Servlet.
> With Sling being used to maintain multiple sites, having a single set of 
> response headers creates problems where the header provides a non tailored 
> response. One site may have a conflicting set of requirements then another 
> site.
> If the setting of headers was moved from being a configuration to being a 
> service used by the Main Servlet, this would allow the following:
>  * Headers set on a per site basis
>  * Headers based on selected resource
>  * Ability to modify the headers without causing the restart of the Sling 
> Main Servlet
>  ** Which if you're dealing with CSP headers can be a constant pain
>  * Ability to create a CSP configuration Service that eases the use of CSP 
> creation
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #518 is FIXED

2020-01-14 Thread Apache Jenkins Server 
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/518/
 for details.

No further emails will be sent until the status of the build is changed.

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #517 is BROKEN

2020-01-14 Thread Apache Jenkins Server 
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/517/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

[...truncated 4131 lines...]
[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLogoutTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLogoutTest
[ERROR] 
testRedirectToResourceAfterLogout(org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLogoutTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLogoutTest.testRedirectToResourceAfterLogout(RedirectOnLogoutTest.java:59)

[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest
[ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0 s <<< 
FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest
[ERROR] 
testEarthResource(org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.assertStrings(PlanetsResourceProviderTest.java:27)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.testEarthResource(PlanetsResourceProviderTest.java:50)

[ERROR] 
testMoonResource(org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.assertStrings(PlanetsResourceProviderTest.java:27)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.testMoonResource(PlanetsResourceProviderTest.java:63)

[ERROR] 
testMoonHtml(org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.testMoonHtml(PlanetsResourceProviderTest.java:76)

[ERROR] 
testRootResource(org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.assertStrings(PlanetsResourceProviderTest.java:27)
at 
org.apache.sling.launchpad.webapp.integrationtest.resourceprovider.PlanetsResourceProviderTest.testRootResource(PlanetsResourceProviderTest.java:38)

[INFO] Running 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest
[ERROR] Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.001 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest
[ERROR] 
testEspHtml(org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest.setUp(NodetypeRenderingTest.java:45)

[ERROR] 
testWithoutScriptHtml(org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest.setUp(NodetypeRenderingTest.java:45)

[ERROR] 
testEspPlain(org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest.setUp(NodetypeRenderingTest.java:45)

[ERROR] 
testPrint(org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest.setUp(NodetypeRenderingTest.java:45)

[ERROR] 
testEspXml(org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest)
  Time elapsed: 0 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)
at

[jira] [Closed] (SLING-8971) Update to parent 35

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8971.
--

> Update to parent 35
> ---
>
> Key: SLING-8971
> URL: https://issues.apache.org/jira/browse/SLING-8971
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Feature Model IO 1.2.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8935) Support serializing primitive arrays and Collections from Feature Model Configurations

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8935.
--

> Support serializing primitive arrays and Collections from Feature Model 
> Configurations
> --
>
> Key: SLING-8935
> URL: https://issues.apache.org/jira/browse/SLING-8935
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model IO 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: Feature Model IO 1.2.0
>
>
> Currently the serialization of feature models only supports Arrays of 
> objects. But the OSGi spec at  
> https://osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html#d0e131765
>  as well as the configuration admin allow also 
> * Collections and
> * arrays of primitive types
> IMHO Reading/Deserializing those is already supported via 
> https://github.com/apache/felix/blob/trunk/configurator/src/main/java/org/apache/felix/configurator/impl/json/JSONUtil.java.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8904) Stop waiting for 10 seconds before tagging a release

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8904.
--

> Stop waiting for 10 seconds before tagging a release
> 
>
> Key: SLING-8904
> URL: https://issues.apache.org/jira/browse/SLING-8904
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> Each time we perform a release the {{maven-release-plugin}} waits for 10 
> seconds before tagging. IIRC this was done due to the specific Subversion 
> setup we have at the ASF, where we have two masters ( EU and US ).
> Nowadays it should no longer be needed with the GitBox setup and should be 
> removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8369) Download plugins via https only

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8369.
--

> Download plugins via https only
> ---
>
> Key: SLING-8369
> URL: https://issues.apache.org/jira/browse/SLING-8369
> Project: Sling
>  Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Parent 36
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8960) Update Maven Plugins

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8960.
--

> Update Maven Plugins
> 
>
> Key: SLING-8960
> URL: https://issues.apache.org/jira/browse/SLING-8960
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36
>
>
> The following plugins should be updated
> {code}
> [INFO] The following plugin updates are available:
> [INFO]   maven-compiler-plugin .. 3.8.0 -> 3.8.1
> [INFO]   maven-enforcer-plugin . 3.0.0-M2 -> 3.0.0-M3
> [INFO]   maven-failsafe-plugin  3.0.0-M3 -> 3.0.0-M4
> [INFO]   maven-jar-plugin ... 3.1.1 -> 3.2.0
> [INFO]   maven-javadoc-plugin ... 3.0.1 -> 3.1.1
> [INFO]   maven-source-plugin  3.0.1 -> 3.2.0
> [INFO]   maven-surefire-plugin . 3.0.0-M3 -> 3.0.0-M4
> [INFO]   maven-surefire-report-plugin .. 3.0.0-M3 -> 3.0.0-M4
> [INFO]   org.codehaus.mojo:animal-sniffer-maven-plugin  1.17 -> 1.18
> [INFO]   maven-release-plugin .. 2.5.4 -> 3.0.0-M1
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8898) Switch URLs to website and JIRA to https

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8898.
--

> Switch URLs to website and JIRA to https
> 
>
> Key: SLING-8898
> URL: https://issues.apache.org/jira/browse/SLING-8898
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Parent 36
>
>
> The URLs to the project's website and issue tracker still use {{http}} 
> instead of {{https}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8832) sling-bundle-parent: Update to bnd maven plugins 4.3.0

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8832.
--

> sling-bundle-parent: Update to bnd maven plugins 4.3.0
> --
>
> Key: SLING-8832
> URL: https://issues.apache.org/jira/browse/SLING-8832
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Bundle Parent 35
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Bundle Parent 36
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8959) Update to bnd-maven-plugin 4.3.1

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8959.
--

> Update to bnd-maven-plugin 4.3.1
> 
>
> Key: SLING-8959
> URL: https://issues.apache.org/jira/browse/SLING-8959
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 36
>
>
> https://github.com/bndtools/bnd/wiki/Changes-in-4.3.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8951) Enable reproducible builds by default

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8951.
--

> Enable reproducible builds by default
> -
>
> Key: SLING-8951
> URL: https://issues.apache.org/jira/browse/SLING-8951
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 36, Bundle Parent 36
>
>
> Recently all relevant Maven plugins have been updated to support reproducible 
> builds (https://maven.apache.org/guides/mini/guide-reproducible-builds.html). 
> The new ASF parent 22 will manage those versions 
> (https://github.com/apache/maven-apache-parent/blob/master/pom.xml).
> Also there is a flag for bnd for this 
> (https://github.com/bndtools/bnd/issues/3521).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8538) Temporarily disable creation of the Bundle-DocURL header

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8538.
--

> Temporarily disable creation of the Bundle-DocURL header
> 
>
> Key: SLING-8538
> URL: https://issues.apache.org/jira/browse/SLING-8538
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Bundle Parent 35
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 36
>
>
> Due to the issue outlined at SLING-8537 (which cannot easily be resolved) 
> currently the Bundle-DocURL header has a wrong value. We should at least 
> temporarily prevent that wrong {{Bundle-DocURL}} value from being emitted as 
> long as we cannot fix the underlying issue.
> That can be achieved by placing an empty Bundle-DocURL in the inline bnd 
> instructions. Each  derived Maven module can still overwrite that header with 
> its own value (which takes precedence).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8833) sling-bundle-parent: Disable includeDistributionManagement for bnd-baseline-maven-plugin

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8833.
--

> sling-bundle-parent: Disable includeDistributionManagement for 
> bnd-baseline-maven-plugin
> 
>
> Key: SLING-8833
> URL: https://issues.apache.org/jira/browse/SLING-8833
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Bundle Parent 35
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Bundle Parent 36
>
>
> the bnd-baseline-maven-plugin has a strange feature enabled by default: when 
> resolving the latest release versions it does not only check in the maven 
> repository configured in the maven environment (e.g. maven central), but 
> tries also to download them form the URLs configured as distribution 
> management.
> this is normally nothing you want to to - and in our case leads to warnings 
> in the build like
> {noformat}
> [INFO] --- bnd-baseline-maven-plugin:4.2.0:baseline (bnd-baseline) @ 
> org.apache.sling.servlet-helpers ---
> [INFO] Determining the baseline version for 
> org.apache.sling:org.apache.sling.servlet-helpers:jar:(,1.3.1-SNAPSHOT) using 
> repositories [apache.releases.https 
> (https://repository.apache.org/service/local/staging/deploy/maven2, default, 
> releases+snapshots), central 
> (https://nexus.pvtool.org/content/groups/default, default, 
> releases+snapshots)]
> Downloading from apache.releases.https: 
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.servlet-helpers/maven-metadata.xml
> [WARNING] Could not transfer metadata 
> org.apache.sling:org.apache.sling.servlet-helpers/maven-metadata.xml from/to 
> apache.releases.https 
> (https://repository.apache.org/service/local/staging/deploy/maven2): Failed 
> to transfer file: 
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.servlet-helpers/maven-metadata.xml.
>  Return code is: 400 , ReasonPhrase:Bad Request.
> {noformat}
> we should just disable this feature (luckily there is a switch for it).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8834) sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin

2020-01-14 Thread Konrad Windszus (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-8834.
--

> sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin
> 
>
> Key: SLING-8834
> URL: https://issues.apache.org/jira/browse/SLING-8834
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Bundle Parent 35
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Bundle Parent 36
>
>
> the default command line output of the bnd-baseline-maven-plugin is much less 
> usable than that of the baseline goal in the maven-bundle-plugin, i've also 
> opened an issue on bnd:
> https://github.com/bndtools/bnd/issues/3545
> whatever the outcome of this issue is, for the time being we should enable 
> the "fullReport" flag which in case of a version validation outputs some more 
> relevant information which change in the API lead to the validation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-8936) Improve test coverage for path-mounted servlets

2020-01-14 Thread Bertrand Delacretaz (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014969#comment-17014969
 ] 

Bertrand Delacretaz edited comment on SLING-8936 at 1/14/20 12:06 PM:
--

Thank you [~olli] for your comments - I haven't found a reliable set of 
services to wait for to avoid the {{waitForSling()}} method so I'll leave it in 
for now, it's not elegant but works reliably. The module uses an older 
{{o.a.s.engine}} dependency which I don't want to change just for the tests and 
that complicates this a bit.

The ITs are now ready but I'll leave this ticket open as there are two SNAPSHOT 
dependencies to remove once the {{sling.api}} and {{scripting.core}} modules 
are released: in {{pom.xml}} and in {{ServletResolverTestSupport.java}}.


was (Author: bdelacretaz):
Thank you [~olli] for your comments - I haven't found a reliable set of 
services to wait for to avoid the {{waitForSling()}} method so I'll leave it in 
for now, it's not elegant but works reliably. The module uses an older 
{{o.a.s.engine}} dependency which I don't want to change just for the tests and 
that complicates this a bit.

The ITs are now ready but I'll leave this ticket open as there are two SNAPSHOT 
dependencies to remove once the {{sling.api}} and {{scripting.core}} modules 
are released.

> Improve test coverage for path-mounted servlets
> ---
>
> Key: SLING-8936
> URL: https://issues.apache.org/jira/browse/SLING-8936
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.5.8
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlets Resolver 2.5.10
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The code that I need to modify for SLING-8110 is not covered by this module's 
> tests, I need to improve test coverage before making those changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Dealing with the Sling Dist folder

2020-01-14 Thread Bertrand Delacretaz 
Hi,

On Tue, Jan 14, 2020 at 12:51 PM Konrad Windszus  wrote:
> ...does someone have a (bash) script handy for cleaning up old artifacts from 
> dist
> (and maybe also for importing the new artifacts)?..

I don't have a script but usually do things like this, example
releasing V2.6.22 and removing V2.6.20:

  cd 
  svn import -m "Release org.apache.sling.engine-2.6.22" .
https://dist.apache.org/repos/dist/release/sling

  svn delete -m "Release org.apache.sling.engine-2.6.22" $(ls | sed
's/22/20/' | while read line; do echo
"https://dist.apache.org/repos/dist/release/sling/$line;; done)

With this you don't have to checkout the large dist folder, and you
get just one svn transaction for the import and one for the delete.

And for dry runs just add echo in the right places before actually
running the commands.

-Bertrand

[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] commented on issue #32: SLING-8994 Optimize session saves for Single Queue Dispatching Strategy

2020-01-14 Thread GitBox 
sonarcloud[bot] commented on issue #32: SLING-8994 Optimize session saves for 
Single Queue Dispatching Strategy
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/32#issuecomment-574140327
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=32=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=32=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Dealing with the Sling Dist folder

2020-01-14 Thread Konrad Windszus 
Hi,
the release management is a bit painful due to the huge amount of files in 
https://dist.apache.org/repos/dist/release/sling/.
Would it be possible to split this up a bit, that we reduce the amount of 
sibling files?
All UI tools I tried for cleaning up the old release artifacts simply screw up 
when trying to show the content of this folder.

Otherwise, does someone have a (bash) script handy for cleaning up old 
artifacts from dist (and maybe also for importing the new artifacts)?

Thanks in advance,
Konrad

[RESULT][VOTE] Release Apache Sling Feature Model IO 1.2.0

2020-01-14 Thread Konrad Windszus 
Hi,

The vote has passed with the following result :

+ 1 (binding): Carsten, Robert, Stefan, Dan
+1 (non binding): Andy

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Konrad

[RESULT][VOTE] Release Apache Sling Parent and Apache Sling Bundle Parent 36

2020-01-14 Thread Konrad Windszus 
Hi, The vote has passed with the following result : 
 +1 (binding): Robert, Carsten, David, Stefan
+1 (non binding): Andy

 I will copy this release to the Sling dist directory and promote the artifacts 
to the central Maven repository.

Konrad

[jira] [Commented] (SLING-8936) Improve test coverage for path-mounted servlets

2020-01-14 Thread Bertrand Delacretaz (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014969#comment-17014969
 ] 

Bertrand Delacretaz commented on SLING-8936:


Thank you [~olli] for your comments - I haven't found a reliable set of 
services to wait for to avoid the {{waitForSling()}} method so I'll leave it in 
for now, it's not elegant but works reliably. The module uses an older 
{{o.a.s.engine}} dependency which I don't want to change just for the tests and 
that complicates this a bit.

The ITs are now ready but I'll leave this ticket open as there are two SNAPSHOT 
dependencies to remove once the {{sling.api}} and {{scripting.core}} modules 
are released.

> Improve test coverage for path-mounted servlets
> ---
>
> Key: SLING-8936
> URL: https://issues.apache.org/jira/browse/SLING-8936
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.5.8
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlets Resolver 2.5.10
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The code that I need to modify for SLING-8110 is not covered by this module's 
> tests, I need to improve test coverage before making those changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8936) Improve test coverage for path-mounted servlets

2020-01-14 Thread Bertrand Delacretaz (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-8936:
---
Fix Version/s: Servlets Resolver 2.5.10

> Improve test coverage for path-mounted servlets
> ---
>
> Key: SLING-8936
> URL: https://issues.apache.org/jira/browse/SLING-8936
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.5.8
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlets Resolver 2.5.10
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The code that I need to modify for SLING-8110 is not covered by this module's 
> tests, I need to improve test coverage before making those changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-8995) Code coverage no longer picked up by SonarCloud

2020-01-14 Thread Robert Munteanu (Jira) 
Robert Munteanu created SLING-8995:
--

 Summary: Code coverage no longer picked up by SonarCloud
 Key: SLING-8995
 URL: https://issues.apache.org/jira/browse/SLING-8995
 Project: Sling
  Issue Type: Improvement
  Components: Build and Source Control
Reporter: Robert Munteanu


The following warnings is issued during analysis: {{Property 
'sonar.jacoco.reportPaths' is no longer supported. Use JaCoCo's xml report and 
sonar-jacoco plugin.}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-security] rombert commented on issue #1: SLING-8838 - Add HEAD support to ContentDispositionFilter

2020-01-14 Thread GitBox 
rombert commented on issue #1: SLING-8838 - Add HEAD support to 
ContentDispositionFilter
URL: 
https://github.com/apache/sling-org-apache-sling-security/pull/1#issuecomment-574063780
 
 
   @yesil  - it seems SonarCloud complains about the way you initialise the 
supported methods set - 
https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-security=AW-f0hzpmTF_JQrYQPXS=1=false=BUG
 . Can you please update the code to use something else?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services