date:20200302

Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Carsten Ziegeler


+1

Carsten

On 02.03.2020 17:52, dav...@apache.org wrote:

Hi all,

I would like to call the release on the following Sling Apache components:

slingfeature-maven-plugin 1.1.18
https://issues.apache.org/jira/projects/SLING/versions/12347340

Feature Model API Regions Extension 1.1.4
https://issues.apache.org/jira/projects/SLING/versions/12346855

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2213

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2213 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

cziegeler commented on a change in pull request #49: Replacement PR for #41 
with a clean set of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r386827555
 
 

 ##
 File path: 
src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
 ##
 @@ -85,14 +129,28 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 found = new Feature(new ArtifactId(this.project.getGroupId(), 
this.project.getArtifactId(),
 this.project.getVersion(), includeArtifactClassifier, 
FeatureConstants.PACKAGING_FEATURE));
 
-file = new File(this.getTmpDir(), "feature-" + 
this.includeArtifactClassifier + ".json");
+file = new File(
+this.getTmpDir(),
+"feature" + (includeArtifactClassifier == null ? "" : "-" + 
includeArtifactClassifier) + ".json");
 key = file.getAbsolutePath();
 ProjectHelper.getFeatures(this.project).put(key, found);
 ProjectHelper.getAssembledFeatures(this.project).put(key, found);
 }
+getLog().debug("Found Feature: " + found + ", artifact: " + art);
 includeArtifact(found, includeArtifactExtension, art);
+getLog().debug("Feature Key: " + key + ", feature from key: " + 
ProjectHelper.getAssembledFeatures(this.project).get(key));
 
includeArtifact(ProjectHelper.getAssembledFeatures(this.project).get(key), 
includeArtifactExtension,
 art.copy(art.getId()));
+
+addDependencies(found);
+
+// Obtain any features from Source folder and add any Extensions to 
the target feature
 
 Review comment:
   I think this is not needed as you can do the aggregation separate


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Karl Pauls

+1

regards,

Karl

On Mon, Mar 2, 2020 at 11:07 PM Andreas Schaefer
 wrote:
>
> +1 (non-binding)
>
> - Andy
>
> > On Mar 2, 2020, at 8:52 AM, dav...@apache.org wrote:
> >
> > Hi all,
> >
> > I would like to call the release on the following Sling Apache components:
> >
> > slingfeature-maven-plugin 1.1.18
> > https://issues.apache.org/jira/projects/SLING/versions/12347340
> >
> > Feature Model API Regions Extension 1.1.4
> > https://issues.apache.org/jira/projects/SLING/versions/12346855
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2213
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2213 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Best regards,
> >
> > David
>


-- 
Karl Pauls
karlpa...@gmail.com

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a 
clean set of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593651971
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set 
of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593663635
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

sonarcloud[bot] commented on issue #49: Replacement PR for #41 with a clean set 
of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-593651971
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

sonarcloud[bot] removed a comment on issue #49: Replacement PR for #41 with a 
clean set of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#issuecomment-586042006
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=49=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=49=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread Andreas Schaefer

+1 (non-binding)

- Andy

> On Mar 2, 2020, at 8:52 AM, dav...@apache.org wrote:
> 
> Hi all,
> 
> I would like to call the release on the following Sling Apache components:
> 
> slingfeature-maven-plugin 1.1.18
> https://issues.apache.org/jira/projects/SLING/versions/12347340
> 
> Feature Model API Regions Extension 1.1.4
> https://issues.apache.org/jira/projects/SLING/versions/12346855
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2213
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2213 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Best regards,
> 
> David

[GitHub] [sling-slingfeature-maven-plugin] schaefa commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes

2020-03-02 Thread GitBox

schaefa commented on a change in pull request #49: Replacement PR for #41 with 
a clean set of changes
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r386677176
 
 

 ##
 File path: 
src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
 ##
 @@ -119,4 +186,61 @@ private void includeArtifact(final Feature f, final 
String extensionName, final
 }
 container.add(art);
 }
+
+private void installFMDescriptor(File file, Feature feature) {
+Collection artifacts = 
Collections.synchronizedCollection(new ArrayList<>());
+if(file.exists() && file.canRead()) {
+getLog().debug("FM File to be installed: " + 
file.getAbsolutePath());
+// Need to create a new Artifact Handler for the different 
extension and an Artifact to not
+// change the module artifact
+DefaultArtifactHandler fmArtifactHandler = new 
DefaultArtifactHandler("slingosgifeature");
+ArtifactId artifactId = feature.getId();
+DefaultArtifact fmArtifact = new DefaultArtifact(
+artifactId.getGroupId(), artifactId.getArtifactId(), 
artifactId.getVersion(),
+null, "slingosgifeature", artifactId.getClassifier(), 
fmArtifactHandler
+);
+fmArtifact.setFile(file);
+artifacts.add(fmArtifact);
+project.addAttachedArtifact(fmArtifact);
+} else {
+getLog().error("Could not find FM Descriptor File: " + file);
+}
+}
+
+private void addDependencies(Feature feature) {
+// Add Dependencies if configured so
+for(String includeDependencyScope: includeDependenciesWithScope) {
+List dependencies = project.getDependencies();
+getLog().info("Project Dependencies: " + dependencies);
+for(Dependency dependency: dependencies) {
+if(includeDependencyScope.equals(dependency.getScope())) {
+getLog().info("Include Artifact: " + dependencies);
+ArtifactId id = new ArtifactId(
+dependency.getGroupId(), dependency.getArtifactId(), 
dependency.getVersion(), dependency.getClassifier(), dependency.getType()
+);
+Artifact artifact = new Artifact(id);
+if(bundlesStartOrder >= 0) {
+artifact.setStartOrder(bundlesStartOrder);
+}
+feature.getBundles().add(artifact);
+}
+}
+}
+}
+
+private void includeFeatures(Map selection, Feature 
feature) {
 
 Review comment:
   Got it working. Removed the method and updated the IT tests and 
documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Jason E Bailey (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049550#comment-17049550
 ] 

Jason E Bailey edited comment on SLING-8243 at 3/2/20 6:50 PM:
---

[~sseifert] yes, I'll take care of that. I just need to refresh my memory. It's 
been a while.


was (Author: jebailey):
[~sseifert] yes, I'll take care of that.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Jason E Bailey (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049550#comment-17049550
 ] 

Jason E Bailey commented on SLING-8243:
---

[~sseifert] yes, I'll take care of that.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9092) Remove unused export-packages analyser

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9092.
-

> Remove unused export-packages analyser
> --
>
> Key: SLING-9092
> URL: https://issues.apache.org/jira/browse/SLING-9092
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model Analyser
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.2.6
>
>
> The readme lists an export-packages analyser which will write a file with the 
> exported packages of a feature.
> However, this analyser has never been registered in the service loader file, 
> so it was never usable.
> As we don't want to write files with information from an analyser, the best 
> thing is to simply remove this one - as no one could use it, there is no 
> problem with this.
> We should probably provide a mojo for the maven plugin for this functionality



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9080) Support ArtifactProvider and FeatureProvider through ArtifactManager

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9080.
-

> Support ArtifactProvider and FeatureProvider through ArtifactManager
> 
>
> Key: SLING-9080
> URL: https://issues.apache.org/jira/browse/SLING-9080
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model IO 1.3.0
>
>
> The feature module defines ArtifactProvider and FeatureProvider - two simple 
> interfaces to provide artifacts for the feature processing.
> The feature IO module defines ArtifactManager - a general pluggable mechanism 
> to find artifacts in configured locations. Usually applications use an 
> ArtifactManager and then need to implement ArtifactProvider and 
> FeatureProvider based on this manager. To avoid this, ArtifactManager should 
> direct implement/provide these, reducing the additional code to be written by 
> each application



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9098) Provide support for directly downloading artifacts through mvn

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9098.
-

> Provide support for directly downloading artifacts through mvn
> --
>
> Key: SLING-9098
> URL: https://issues.apache.org/jira/browse/SLING-9098
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model IO 1.3.0
>
>
> The artifact manager allows to be configured with a set of repository urls, 
> this can be a local mvn cache, remote repositories or any server supporting 
> the maven structure.
> In some cases it is useful to leverage mvn to download artifacts: this can be 
> done by first looking into the local mvn cache and then using mvn to download 
> an artifact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9087) Support creation of feature archives

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9087.
-

> Support creation of feature archives
> 
>
> Key: SLING-9087
> URL: https://issues.apache.org/jira/browse/SLING-9087
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model IO 1.3.0
>
>
> Similar to what we have for the provisioning model, we should support feature 
> archives. An archive contains the feature model and the mentioned artifacts 
> (in the bundles section and in the extensions).
> This way, a feature together with its artifacts can be easily distributed in 
> a single file.
> As discussed in the mailing list, we recommend to use the extension "far" for 
> such feature archives.
> We also might want to add an option to compress the archive on creation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-8676) Prototype does not allow to remove requirements and capabilities

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-8676.
-

> Prototype does not allow to remove requirements and capabilities
> 
>
> Key: SLING-8676
> URL: https://issues.apache.org/jira/browse/SLING-8676
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.4, Feature Model IO 1.3.0
>
>
> Prototype does not allow to remove requirements and capabilities
> (Code has a todo)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9097) Mark ArtifactProvider and FeatureProvider as FunctionalInterface

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9097.
-

> Mark ArtifactProvider and FeatureProvider as FunctionalInterface
> 
>
> Key: SLING-9097
> URL: https://issues.apache.org/jira/browse/SLING-9097
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9096) Provide methods to create a new id by just changing version, type or classifier

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9096.
-

> Provide methods to create a new id by just changing version, type or 
> classifier
> ---
>
> Key: SLING-9096
> URL: https://issues.apache.org/jira/browse/SLING-9096
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.4
>
>
> If you want to create a new ArtifactId based on an existing one where just 
> the version, classifier or type is different, this is currently a little bit 
> of boilerplate code. As these are very common use cases we should provide 
> some convenience methods for it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9137) Add method to ArtifactId to create an id based on the mvn path

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9137.
-

> Add method to ArtifactId to create an id based on the mvn path
> --
>
> Key: SLING-9137
> URL: https://issues.apache.org/jira/browse/SLING-9137
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.4
>
>
> In some cases, only a maven path is available (a mvn path is the structure of 
> a mvn repository).
> In this cases getting the coordinates from that path is complicated, 
> therefore we should provide a method to do this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] slingfeature-maven-plugin 1.1.18, Feature Model API Regions Extension 1.1.4

2020-03-02 Thread davidb

Hi all,

I would like to call the release on the following Sling Apache components:

slingfeature-maven-plugin 1.1.18
https://issues.apache.org/jira/projects/SLING/versions/12347340

Feature Model API Regions Extension 1.1.4
https://issues.apache.org/jira/projects/SLING/versions/12346855

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2213

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2213 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David

[jira] [Resolved] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-9136.
-
Resolution: Fixed

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.1.2
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> If a feature model that doesn't opt-in to the api-regions exports packages 
> that overlap with packages exported from the api regions, this can have 
> problematic results.
> We need an analyzer that can report on this. The analyser should generally be 
> used on aggregate feature models. It can identify in those aggregates:
>  * The exported packages from various API Regions
>  * Bundles that originate from feature models that don't participate in the 
> api-regions and obtain the exported packages from those bundles.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] removed a comment on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox

sonarcloud[bot] removed a comment on issue #6: SLING-9136 Check if a feature 
model exports overlapping packages with an API Region
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593480602
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
 [97.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox

sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model 
exports overlapping packages with an API Region
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593486632
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
 [97.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox

sonarcloud[bot] commented on issue #6: SLING-9136 Check if a feature model 
exports overlapping packages with an API Region
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6#issuecomment-593480602
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
 [97.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-apiregions=6=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] bosschaert opened a new pull request #6: SLING-9136 Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread GitBox

bosschaert opened a new pull request #6: SLING-9136 Check if a feature model 
exports overlapping packages with an API Region
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/6
 
 
   Checks if a feature model that does not participate in the API Regions
   exports packages that are exported by an API Region


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Stefan Seifert (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049314#comment-17049314
 ] 

Stefan Seifert edited comment on SLING-8243 at 3/2/20 3:22 PM:
---

[~jebailey] can you update the documentation as well?
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html

from the code i took that two new directives {{mergeProperties}} and {{merge}} 
were introduced.


was (Author: sseif...@pro-vision.de):
[~jebailey] can you update the documentation as well?
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html

from the code i took that two new directives {{mergeProperties}} and {{merge}} 
where introduced.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.3.2
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes

2020-03-02 Thread Stefan Seifert (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049314#comment-17049314
 ] 

Stefan Seifert commented on SLING-8243:
---

[~jebailey] can you update the documentation as well?
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html

from the code i took that two new directives {{mergeProperties}} and {{merge}} 
where introduced.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.3.2
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049273#comment-17049273
 ] 

Angela Schreiber commented on SLING-9090:
-

[~bdelacretaz], just had a quick look at the {{AclLine.Action.REMOVE_ALL}} and 
{{AclLine.Action.REMOVE}}. while {{AclLine.Action.REMOVE_ALL}} seems straight 
forward (remove all access control entries for a given list of principals at a 
given list of paths or for a given list of paths at a given principal based 
policy), I have a hard time understanding what was your intention behind 
{{AclLine.Action.REMOVE}}... would it remove entries that have a matching set 
of privileges? irrespective of allow/deny status? what about restrictions? 
could those be ignored? what about entries that in fact do contain the given 
privileges but not exclusively? 

[~mohiaror], as long as we don't have answers to these questions I would not 
use the remove statements depending on what was the original intention 
behind the remove, it might be that it's not even possible to provide a 
compatible solution.

> AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr 
> implementation
> -
>
> Key: SLING-9090
> URL: https://issues.apache.org/jira/browse/SLING-9090
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], while the documentation and the parser code provides the 
> ability to remove an individual or all access control entries, it seems the 
> JCR implementation doesn't actually support it.
> using it may lead to odd side effects or failures so, i think either the 
> parser should remove the support for Action.REMOVE and Action.REMOVE_ALL or 
> the jcr implementation part should respect it... at the very minimum it 
> should spot any usage of it and fail the repo-init if there is no way to 
> implement it properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049217#comment-17049217
 ] 

Angela Schreiber commented on SLING-9090:
-

[~mohiaror], IMHO the remove should remove all matching entries and should also 
fix the deny-entries that have been created wrongfully. I just noticed that in 
case of the principal-based setup remove-entries even result in allows because 
the current code just checks for AclLine.Action.DENY and fails if it was a deny 
:(. So, a fix is anyway needed asap.

> AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr 
> implementation
> -
>
> Key: SLING-9090
> URL: https://issues.apache.org/jira/browse/SLING-9090
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], while the documentation and the parser code provides the 
> ability to remove an individual or all access control entries, it seems the 
> JCR implementation doesn't actually support it.
> using it may lead to odd side effects or failures so, i think either the 
> parser should remove the support for Action.REMOVE and Action.REMOVE_ALL or 
> the jcr implementation part should respect it... at the very minimum it 
> should spot any usage of it and fail the repo-init if there is no way to 
> implement it properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Issue Comment Deleted] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Angela Schreiber (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-9090:

Comment: was deleted

(was: Hi Mohit

I don't think you have to worry about the extra with-path statement for the 
service user.
The reason why I came across this is in the first place, that I am working on 
defining principal-based permission setup for service users (see announcement 
on dl-dev)... so, for new AEM installations that would mean that service-users 
get installed below a new subtree (i.e. 
/home/users/system/cq:services/internal/*), which allows for principal-based 
permission setup.

So, for new installations your service user will once this completed anyway 
have an intermediate path specified
Unless we see that it's mandatory we won't move around service users in 
existing installations and as you noticed, repo-init is a bit limited and 
doesn't touch existing service users even if the rel-path specified does not 
match.

The effective permissions must stay the same for built-in service users but 
obviously the remove-ace will really be needed and will be needed in a 
non-breaking way... also the prinipal-based permission setup doesn't allow for 
deny-entries, since we always claimed that service users never should have 
denies. So, either way I will keep an eye on the Sling issue.

Thanks and kind regards
Angela
)

> AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr 
> implementation
> -
>
> Key: SLING-9090
> URL: https://issues.apache.org/jira/browse/SLING-9090
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], while the documentation and the parser code provides the 
> ability to remove an individual or all access control entries, it seems the 
> JCR implementation doesn't actually support it.
> using it may lead to odd side effects or failures so, i think either the 
> parser should remove the support for Action.REMOVE and Action.REMOVE_ALL or 
> the jcr implementation part should respect it... at the very minimum it 
> should spot any usage of it and fail the repo-init if there is no way to 
> implement it properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread angela (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049212#comment-17049212
 ] 

angela commented on SLING-9090:
---

Hi Mohit

I don't think you have to worry about the extra with-path statement for the 
service user.
The reason why I came across this is in the first place, that I am working on 
defining principal-based permission setup for service users (see announcement 
on dl-dev)... so, for new AEM installations that would mean that service-users 
get installed below a new subtree (i.e. 
/home/users/system/cq:services/internal/*), which allows for principal-based 
permission setup.

So, for new installations your service user will once this completed anyway 
have an intermediate path specified
Unless we see that it's mandatory we won't move around service users in 
existing installations and as you noticed, repo-init is a bit limited and 
doesn't touch existing service users even if the rel-path specified does not 
match.

The effective permissions must stay the same for built-in service users but 
obviously the remove-ace will really be needed and will be needed in a 
non-breaking way... also the prinipal-based permission setup doesn't allow for 
deny-entries, since we always claimed that service users never should have 
denies. So, either way I will keep an eye on the Sling issue.

Thanks and kind regards
Angela


> AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr 
> implementation
> -
>
> Key: SLING-9090
> URL: https://issues.apache.org/jira/browse/SLING-9090
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], while the documentation and the parser code provides the 
> ability to remove an individual or all access control entries, it seems the 
> JCR implementation doesn't actually support it.
> using it may lead to odd side effects or failures so, i think either the 
> parser should remove the support for Action.REMOVE and Action.REMOVE_ALL or 
> the jcr implementation part should respect it... at the very minimum it 
> should spot any usage of it and fail the repo-init if there is no way to 
> implement it properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT][VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16

2020-03-02 Thread davidb

Hi all,

We received the following +1 votes:
Binding +1s: Carsten Ziegeler, Stefan Seifert, David Bosschaert
Non-binding +1s: Andreas Schaefer

-1s: A -1 vote was received for the slingfeature-maven-plugin part only
from me (David) as explained in the accompanying email. I have removed the
slingfeature-maven-plugin proposed release from the staging area.

For Feature Model 1.1.4, Feature Model IO 1.3.0 and Feature Model Analyser
1.2.6 this release is successful. I have promoted those artifacts.

I plan to do a new release of slingfeature-maven-plugin some day soon.

Best regards,

David

On Thu, 27 Feb 2020 at 13:41,  wrote:

> Hi all,
>
> I would like to call the release on the following Sling Apache components:
>
> Feature Model 1.1.4
> https://issues.apache.org/jira/projects/SLING/versions/12346848
>
> Feature Model IO 1.3.0
> https://issues.apache.org/jira/projects/SLING/versions/12346849
>
> Feature Model Analyser 1.2.6
> https://issues.apache.org/jira/projects/SLING/versions/12346850
>
> slingfeature-maven-plugin 1.1.16
> https://issues.apache.org/jira/projects/SLING/versions/12346858
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2212
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2212 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>

[jira] [Updated] (SLING-9093) Add info mojo to generate a file with exported packages

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9093:
--
Fix Version/s: (was: slingfeature-maven-plugin 1.1.16)
   slingfeature-maven-plugin 1.1.18

> Add info mojo to generate a file with exported packages
> ---
>
> Key: SLING-9093
> URL: https://issues.apache.org/jira/browse/SLING-9093
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.18
>
>
> To cover the functionality mentioned in SLING-9092, we should provide a mojo 
> which allows to list information about a feature, we can start with the 
> exported packages



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9095) Create a mojo that is able to create a feature archive

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9095:
--
Fix Version/s: (was: slingfeature-maven-plugin 1.1.16)
   slingfeature-maven-plugin 1.1.18

> Create a mojo that is able to create a feature archive
> --
>
> Key: SLING-9095
> URL: https://issues.apache.org/jira/browse/SLING-9095
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.18
>
>
> With the new support to create feature archives in feature.io, we should 
> provide a mojo which creates feature archives out of the feature model



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Fix Version/s: Feature Model API Regions Extension 1.1.4

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.1.2
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If a feature model that doesn't opt-in to the api-regions exports packages 
> that overlap with packages exported from the api regions, this can have 
> problematic results.
> We need an analyzer that can report on this. The analyser should generally be 
> used on aggregate feature models. It can identify in those aggregates:
>  * The exported packages from various API Regions
>  * Bundles that originate from feature models that don't participate in the 
> api-regions and obtain the exported packages from those bundles.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Component/s: Feature Model Analyser

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Feature Model Analyser
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If a feature model that doesn't opt-in to the api-regions exports packages 
> that overlap with packages exported from the api regions, this can have 
> problematic results.
> We need an analyzer that can report on this. The analyser should generally be 
> used on aggregate feature models. It can identify in those aggregates:
>  * The exported packages from various API Regions
>  * Bundles that originate from feature models that don't participate in the 
> api-regions and obtain the exported packages from those bundles.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Affects Version/s: Feature Model API Regions Extension 1.1.2

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.1.2
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If a feature model that doesn't opt-in to the api-regions exports packages 
> that overlap with packages exported from the api regions, this can have 
> problematic results.
> We need an analyzer that can report on this. The analyser should generally be 
> used on aggregate feature models. It can identify in those aggregates:
>  * The exported packages from various API Regions
>  * Bundles that originate from feature models that don't participate in the 
> api-regions and obtain the exported packages from those bundles.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Description: 
If a feature model that doesn't opt-in to the api-regions exports packages that 
overlap with packages exported from the api regions, this can have problematic 
results.

We need an analyzer that can report on this. The analyser should generally be 
used on aggregate feature models. It can identify in those aggregates:
 * The exported packages from various API Regions
 * Bundles that originate from feature models that don't participate in the 
api-regions and obtain the exported packages from those bundles.

Then it will produce an error if there is any package in the intersection of 
the exported package lists.

We need to add additional configuration that lists packages
 * to be ignored completely
 * to produce a warning instead of an error if it appears in the intersection

  was:
Create a new Mojo that takes 2 (or more) feature models as input. For each 
feature model it will construct a list of exported packages for all regions 
requested. If the feature model does not opt-in to the API Regions mechanism, 
all exported packages from all bundles in that feature will be added to the 
global region.

Then it will produce an error if there is any package in the intersection of 
the exported package lists.

We need to add additional configuration that lists packages
 * to be ignored completely
 * to produce a warning instead of an error if it appears in the intersection


> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If a feature model that doesn't opt-in to the api-regions exports packages 
> that overlap with packages exported from the api regions, this can have 
> problematic results.
> We need an analyzer that can report on this. The analyser should generally be 
> used on aggregate feature models. It can identify in those aggregates:
>  * The exported packages from various API Regions
>  * Bundles that originate from feature models that don't participate in the 
> api-regions and obtain the exported packages from those bundles.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Affects Version/s: (was: slingfeature-maven-plugin 1.1.14)

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Create a new Mojo that takes 2 (or more) feature models as input. For each 
> feature model it will construct a list of exported packages for all regions 
> requested. If the feature model does not opt-in to the API Regions mechanism, 
> all exported packages from all bundles in that feature will be added to the 
> global region.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Component/s: (was: Maven Plugins and Archetypes)

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Create a new Mojo that takes 2 (or more) feature models as input. For each 
> feature model it will construct a list of exported packages for all regions 
> requested. If the feature model does not opt-in to the API Regions mechanism, 
> all exported packages from all bundles in that feature will be added to the 
> global region.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9136) Check if a feature model exports overlapping packages with an API Region

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9136:
--
Summary: Check if a feature model exports overlapping packages with an API 
Region  (was: Provide a Mojo that can check if there is overlap between exports 
from different feature models)

> Check if a feature model exports overlapping packages with an API Region
> 
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.1.14
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.16
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Create a new Mojo that takes 2 (or more) feature models as input. For each 
> feature model it will construct a list of exported packages for all regions 
> requested. If the feature model does not opt-in to the API Regions mechanism, 
> all exported packages from all bundles in that feature will be added to the 
> global region.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (SLING-9136) Provide a Mojo that can check if there is overlap between exports from different feature models

2020-03-02 Thread A. J. David Bosschaert (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert reopened SLING-9136:
---

> Provide a Mojo that can check if there is overlap between exports from 
> different feature models
> ---
>
> Key: SLING-9136
> URL: https://issues.apache.org/jira/browse/SLING-9136
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.1.14
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.16
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Create a new Mojo that takes 2 (or more) feature models as input. For each 
> feature model it will construct a list of exported packages for all regions 
> requested. If the feature model does not opt-in to the API Regions mechanism, 
> all exported packages from all bundles in that feature will be added to the 
> global region.
> Then it will produce an error if there is any package in the intersection of 
> the exported package lists.
> We need to add additional configuration that lists packages
>  * to be ignored completely
>  * to produce a warning instead of an error if it appears in the intersection



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [Starter] Startup detection not working reliable anymore

2020-03-02 Thread Carsten Ziegeler


Thanks Konrad,

I'm struggling a little bit here as this worked with the initial version 
we had - that was not a sophisticated implementation but did the trick 
and most importantly did not present exceptions on startup to 
potentially new users.


It seems we now have switched to a general approach which doesn't solve 
the simple use case anymore but instead requires changes to other parts 
as well.


I'm not saying that the general approach is wrong or the additional work 
is wrong, but the simple use case for the starter could be achieved with 
a much simpler solution without annoying users.


Regards
Carsten

On 02.03.2020 09:12, Konrad Windszus wrote:

This has been adjusted in the context of 
https://issues.apache.org/jira/browse/SLING-8418 
.
I think the exceptions are related to the order: 
https://issues.apache.org/jira/browse/SLING-8355 
.
Maybe Georg can explain the exceptions a bit better...

Konrad


On 2. Mar 2020, at 09:06, Carsten Ziegeler  wrote:

Hi,

some time back we added a mechanism that - on startup of the starter 
application - display a screen telling the user that the server is starting up.

Over time this mechanism got changed - I don't know what exactly it is using 
today - but it is not working reliable anymore. If you hit refresh you are 
presented with different exceptions. Eventually, after pressing refresh some 
more times, the startup page is there.

This means, depending on when you open the browser, you either get the startup 
notice or an exception - clearly not a great user experience.

It would be great if this could be fixed.


Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org





--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Sling Feature Model 1.1.4, Feature Model IO 1.3.0, Feature Model Analyser 1.2.6, slingfeature-maven-plugin 1.1.16

2020-03-02 Thread davidb

Hi all,

It turns out that there is a better way to implement the functionality from
the api-regions-crossfeature-duplicates Mojo in the apiregions
extension component. This would mean that
the api-regions-crossfeature-duplicates Mojo becomes obsolete really soon.
Rather than releasing something that we want to remove again soon, I'm
going to change my vote to -1 for the slingfeature-maven-plugin component
only.

For the other components (Feature Model, Feature IO and Feature Analyser)
my +1 vote still stands.

If nobody objects, I'll remove the slingfeature-maven-plugin from the
release staging area and will complete the release for the other components.

Best regards,

David

On Fri, 28 Feb 2020 at 23:34, Andreas Schaefer  wrote:

> Hi David
>
> For a while now I am trying to get the include-artifact enhanced and I had
> many issues trying to figure out why some configurations do not work.
>
> From my experience IT tests do not only show how it is done but also allow
> devs to debug them. Also an IT project has the advantage that it is easy to
> make sure it is still up to date whereas documentation tends to get out of
> date pretty easily.
>
> If speed is an issue for having many ITs then why not create a separate
> folder (extended-it) and then have the execution into a profile.
>
> Finally I am not concerned that much about coverage even though this is an
> important part but more about showcasing how goals are used.
>
> - Andy
>
> > On Feb 28, 2020, at 12:41 AM, dav...@apache.org wrote:
> >
> > Hi Andreas,
> >
> > At least for the new api-regions-crossfeature-duplicates mojo,
> > documentation is here:
> >
> https://github.com/apache/sling-slingfeature-maven-plugin#api-regions-crossfeature-duplicates
> >
> > This Mojo is well covered with unit tests (> 90% coverage). While IT
> tests
> > have their use and can also be handy to learn from how a feature is used,
> > they are generally a lot slower than unit tests. Adding them to the
> default
> > test set doesn't scale IMHO, as over time it slows down the build a lot.
> We
> > can already see this with the Maven invoker based tests today. For just a
> > handful of tests they take up most of the time of the slingfeature maven
> > plugin build.
> >
> > So my 2c would be that good documentation and unit tests are sometimes
> good
> > enough. If we go the route of having many IT tests I think we should
> > separate them out in a separate component so that they are no run for
> every
> > normal build.
> >
> > Best regards,
> >
> > David
> >
> > On Thu, 27 Feb 2020 at 19:20, Andreas Schaefer  >
> > wrote:
> >
> >> +1 (non-binding)
> >>
> >> I would ask that new features in Slingfeature Maven Plugin have at least
> >> one corresponding IT test. The documentation is not in-depth and so an
> IT
> >> test would help users to understand how the plugin is used.
> >>
> >> - Andy
> >>
> >>> On Feb 27, 2020, at 5:41 AM, dav...@apache.org wrote:
> >>>
> >>> Hi all,
> >>>
> >>> I would like to call the release on the following Sling Apache
> >> components:
> >>>
> >>> Feature Model 1.1.4
> >>> https://issues.apache.org/jira/projects/SLING/versions/12346848
> >>>
> >>> Feature Model IO 1.3.0
> >>> https://issues.apache.org/jira/projects/SLING/versions/12346849
> >>>
> >>> Feature Model Analyser 1.2.6
> >>> https://issues.apache.org/jira/projects/SLING/versions/12346850
> >>>
> >>> slingfeature-maven-plugin 1.1.16
> >>> https://issues.apache.org/jira/projects/SLING/versions/12346858
> >>>
> >>> Staging repository:
> >>> https://repository.apache.org/content/repositories/orgapachesling-2212
> >>>
> >>> You can use this UNIX script to download the release and verify the
> >>> signatures:
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>>
> >>> Usage:
> >>> sh check_staged_release.sh 2212 /tmp/sling-staging
> >>>
> >>> Please vote to approve this release:
> >>>
> >>>  [ ] +1 Approve the release
> >>>  [ ] -1 Don't release, because ...
> >>>
> >>> This majority vote is open for at least 72 hours.
> >>>
> >>> Best regards,
> >>>
> >>> David
> >>
> >>
>
>

Re: [Starter] Startup detection not working reliable anymore

2020-03-02 Thread Konrad Windszus

This has been adjusted in the context of 
https://issues.apache.org/jira/browse/SLING-8418 
.
I think the exceptions are related to the order: 
https://issues.apache.org/jira/browse/SLING-8355 
.
Maybe Georg can explain the exceptions a bit better...

Konrad

> On 2. Mar 2020, at 09:06, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> some time back we added a mechanism that - on startup of the starter 
> application - display a screen telling the user that the server is starting 
> up.
> 
> Over time this mechanism got changed - I don't know what exactly it is using 
> today - but it is not working reliable anymore. If you hit refresh you are 
> presented with different exceptions. Eventually, after pressing refresh some 
> more times, the startup page is there.
> 
> This means, depending on when you open the browser, you either get the 
> startup notice or an exception - clearly not a great user experience.
> 
> It would be great if this could be fixed.
> 
> 
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

[Starter] Startup detection not working reliable anymore

2020-03-02 Thread Carsten Ziegeler


Hi,

some time back we added a mechanism that - on startup of the starter 
application - display a screen telling the user that the server is 
starting up.


Over time this mechanism got changed - I don't know what exactly it is 
using today - but it is not working reliable anymore. If you hit refresh 
you are presented with different exceptions. Eventually, after pressing 
refresh some more times, the startup page is there.


This means, depending on when you open the browser, you either get the 
startup notice or an exception - clearly not a great user experience.


It would be great if this could be fixed.


Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-02 Thread Mohit Arora (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048856#comment-17048856
 ] 

Mohit Arora commented on SLING-9090:


[~bdelacretaz], [~angela] We do have a usecase for remove functionality. Right 
now, it silently converts the {{remove}} action into {{deny}} which is not 
something one would expect while using the feature. Although I do see SLING 
documentation [0] mentioning {{remove is currently not supported by the 
jcr.repoinit module}}, it does not mention that {{remove}} is being converted 
to {{deny}} under the hood.

We have a deadline for a feature release and to avoid a security issue we are 
currently using {{remove ACL}} in our feature model which is adding {{deny}} 
for the service user on specified path. We would not want it to fail with an 
error as it is currently supported (albeit performing wrongly, but supported, 
nevertheless). It would indeed be beneficial to have proper implementation of 
{{remove}} such that existing usages do not need any change. For existing 
implementation, they would continue adding deny ACE and for new implementation, 
they will simply remove the ACE from specified path if present. If not present, 
it should silently abort.

cc - [~shgupta], [~ashishc]

[0] 
https://sling.apache.org/documentation/bundles/repository-initialization.html

> AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr 
> implementation
> -
>
> Key: SLING-9090
> URL: https://issues.apache.org/jira/browse/SLING-9090
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], while the documentation and the parser code provides the 
> ability to remove an individual or all access control entries, it seems the 
> JCR implementation doesn't actually support it.
> using it may lead to odd side effects or failures so, i think either the 
> parser should remove the support for Action.REMOVE and Action.REMOVE_ALL or 
> the jcr implementation part should respect it... at the very minimum it 
> should spot any usage of it and fail the repo-init if there is no way to 
> implement it properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

47 matches

Mail list logo