Re: Maven Archetypes

[Ruben Reusser]

it would be great if it gets the same bells and whistles as the 
archetype AEM has at the moment and maybe starts aligning with the split 
code and content structure a bit more as well.


Ruben

On 10/8/2021 12:34 PM, Andreas Schaefer wrote:

Hi

I did not work on the Project Archetype for a while but I am going to have a 
look into it with respect to FMs.
There were some suggestions on how to improve it a while back and I will try to 
find them again.

Cheers - Andy


On Oct 8, 2021, at 8:01 AM, Robert Munteanu  wrote:

On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:

Hi


Shall we mark those archetypes as deprecated for now?

Yes. I can make that update to the site (if no one objects). It makes
sense to deprecate broken archetypes, at least temporarily. These
provide an initial starting point for developers looking to try the
framework, so I think they should not only work properly but also
have good documentation if possible. I also understand resource
constraints.

+1 from me.



I would be in favour of just maintaing the sling-project-archetype
and
making sure that a) it works and b) is a reasonable starting point
for
Sling-based apps.

FYI. I used sling-project-archetype two days ago. It worked well for
me. It provided a reasonable starting basis for my new project.

Good to know, thanks.
Robert

[jira] [Created] (SLING-10863) CMS - RSS & Sitemap Publish Query Incorrect

[Dan Klco (Jira)]

Dan Klco created SLING-10863:


 Summary: CMS - RSS & Sitemap Publish Query Incorrect
 Key: SLING-10863
 URL: https://issues.apache.org/jira/browse/SLING-10863
 Project: Sling
  Issue Type: Improvement
Affects Versions: App CMS 1.0.4
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: App CMS 1.0.8


The query for generating the sitemap and RSS feed for the reference components 
only includes the check for published=true not [sling:published]=true and 
therefore does not find files that have been published through the new 
publication API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Maven Archetypes

[Andreas Schaefer]

Hi team

Looking at the Project Archetype I see that I did not add support for FMs. So I 
was wondering if that would be something you might be interested.
I was thinking to keep the current code / layout around with Bundle and Content 
Package(s) but add support for FMs and FARs.

This would require:

- Add a ‘far’ module that creates a FM and FAR like the All does
- Migrate the rest to be able to generate FMs and convert if needed
- Added a Bundle Content Module for the traditional and FM version
- Use the post processing to remove unwanted modules or parts of them
- Use kickstart to test the deployment of the FM / FAR module

Cheers - Andy

> On Oct 8, 2021, at 12:34 PM, Andreas Schaefer  
> wrote:
> 
> Hi
> 
> I did not work on the Project Archetype for a while but I am going to have a 
> look into it with respect to FMs.
> There were some suggestions on how to improve it a while back and I will try 
> to find them again.
> 
> Cheers - Andy
> 
>> On Oct 8, 2021, at 8:01 AM, Robert Munteanu  wrote:
>> 
>> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
>>> Hi
>>> 
 Shall we mark those archetypes as deprecated for now?
>>> Yes. I can make that update to the site (if no one objects). It makes
>>> sense to deprecate broken archetypes, at least temporarily. These
>>> provide an initial starting point for developers looking to try the
>>> framework, so I think they should not only work properly but also
>>> have good documentation if possible. I also understand resource
>>> constraints.
>> 
>> +1 from me.
>>> 
>>> 
 I would be in favour of just maintaing the sling-project-archetype
 and
 making sure that a) it works and b) is a reasonable starting point
 for
 Sling-based apps.
>>> 
>>> FYI. I used sling-project-archetype two days ago. It worked well for
>>> me. It provided a reasonable starting basis for my new project.
>> 
>> Good to know, thanks.
>> Robert
> 

Re: Maven Archetypes

[Andreas Schaefer]

Hi

I did not work on the Project Archetype for a while but I am going to have a 
look into it with respect to FMs.
There were some suggestions on how to improve it a while back and I will try to 
find them again.

Cheers - Andy

> On Oct 8, 2021, at 8:01 AM, Robert Munteanu  wrote:
> 
> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
>> Hi
>> 
>>> Shall we mark those archetypes as deprecated for now?
>> Yes. I can make that update to the site (if no one objects). It makes
>> sense to deprecate broken archetypes, at least temporarily. These
>> provide an initial starting point for developers looking to try the
>> framework, so I think they should not only work properly but also
>> have good documentation if possible. I also understand resource
>> constraints.
> 
> +1 from me.
>> 
>> 
>>> I would be in favour of just maintaing the sling-project-archetype
>>> and
>>> making sure that a) it works and b) is a reasonable starting point
>>> for
>>> Sling-based apps.
>> 
>> FYI. I used sling-project-archetype two days ago. It worked well for
>> me. It provided a reasonable starting basis for my new project.
> 
> Good to know, thanks.
> Robert

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #20: SLING-10862 expose more details on servlet candidates in web console

[GitBox]

sonarcloud[bot] commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/20#issuecomment-939044060


   SonarCloud Quality Gate failed.  ![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate failed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=20=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=20=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=20=false=CODE_SMELL)
   
   
[![59.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50-16px.png
 
'59.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=20=new_coverage=list)
 [59.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=20=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=20=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-resolver] kwin opened a new pull request #20: SLING-10862 expose more details on servlet candidates in web console

[GitBox]

kwin opened a new pull request #20:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/20


   plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10862) Expose mode details on servlet candidates in Servlet Resolver Web Console Plugin

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10862:

Summary: Expose mode details on servlet candidates in Servlet Resolver Web 
Console Plugin  (was: Expose candidate types in Serlet Resolver Web Console 
Plugin)

> Expose mode details on servlet candidates in Servlet Resolver Web Console 
> Plugin
> 
>
> Key: SLING-10862
> URL: https://issues.apache.org/jira/browse/SLING-10862
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Servlets Resolver 2.8.4
>
>
> Currently the list of servlet candidates exposed via 
> {{system/console/servletresolver}} look like this
> {code}
> /apps/.../base/components/page/page.html
> org.apache.sling.servlets.get.impl.DefaultGetServlet
> org.apache.sling.jcr.webdav.impl.servlets.SlingWebDavServlet
> {code}
> It would be nice to explicitly expose whether it is a script, bundled script 
> of servlet. For the latter two it would be nice to expose the underlying 
> bundles as well (via {{Bundle b = FrameworkUtil.getBundle( servlet );}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10862) Expose candidate types in Serlet Resolver Web Console Plugin

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10862:

Description: 
Currently the list of servlet candidates exposed via 
{{system/console/servletresolver}} look like this

{code}
/apps/.../base/components/page/page.html
org.apache.sling.servlets.get.impl.DefaultGetServlet
org.apache.sling.jcr.webdav.impl.servlets.SlingWebDavServlet
{code}

It would be nice to explicitly expose whether it is a script, bundled script of 
servlet. For the latter two it would be nice to expose the underlying bundles 
as well (via {{Bundle b = FrameworkUtil.getBundle( servlet );}}.

  was:
Currently the list of servlet candidates exposed via 
{{system/console/servletresolver}} look like this

{code}
/apps/.../base/components/page/page.html
org.apache.sling.servlets.get.impl.DefaultGetServlet
org.apache.sling.jcr.webdav.impl.servlets.SlingWebDavServlet
{code}

It would be nice to explicitly expose whether it is a script, bundled script of 
servlet. For the latter two it would be nice to expose the underlying bundles 
as well.


> Expose candidate types in Serlet Resolver Web Console Plugin
> 
>
> Key: SLING-10862
> URL: https://issues.apache.org/jira/browse/SLING-10862
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Servlets Resolver 2.8.4
>
>
> Currently the list of servlet candidates exposed via 
> {{system/console/servletresolver}} look like this
> {code}
> /apps/.../base/components/page/page.html
> org.apache.sling.servlets.get.impl.DefaultGetServlet
> org.apache.sling.jcr.webdav.impl.servlets.SlingWebDavServlet
> {code}
> It would be nice to explicitly expose whether it is a script, bundled script 
> of servlet. For the latter two it would be nice to expose the underlying 
> bundles as well (via {{Bundle b = FrameworkUtil.getBundle( servlet );}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10862) Expose candidate types in Serlet Resolver Web Console Plugin

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10862:
---

 Summary: Expose candidate types in Serlet Resolver Web Console 
Plugin
 Key: SLING-10862
 URL: https://issues.apache.org/jira/browse/SLING-10862
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Servlets Resolver 2.8.4


Currently the list of servlet candidates exposed via 
{{system/console/servletresolver}} look like this

{code}
/apps/.../base/components/page/page.html
org.apache.sling.servlets.get.impl.DefaultGetServlet
org.apache.sling.jcr.webdav.impl.servlets.SlingWebDavServlet
{code}

It would be nice to explicitly expose whether it is a script, bundled script of 
servlet. For the latter two it would be nice to expose the underlying bundles 
as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Maven Archetypes

[Robert Munteanu]

On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
> Hi
>  
> > Shall we mark those archetypes as deprecated for now?
> Yes. I can make that update to the site (if no one objects). It makes
> sense to deprecate broken archetypes, at least temporarily. These
> provide an initial starting point for developers looking to try the
> framework, so I think they should not only work properly but also
> have good documentation if possible. I also understand resource
> constraints.

+1 from me.
> 
> 
> > I would be in favour of just maintaing the sling-project-archetype
> > and
> > making sure that a) it works and b) is a reasonable starting point
> > for
> > Sling-based apps.
> 
> FYI. I used sling-project-archetype two days ago. It worked well for
> me. It provided a reasonable starting basis for my new project.

Good to know, thanks.
Robert

[jira] [Updated] (SLING-10859) runmode.mapping file does not contain all needed values

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10859:
---
Affects Version/s: (was: Content-Package to Feature Model Converter 
1.1.10)
   Content-Package to Feature Model Converter 1.1.6

> runmode.mapping file does not contain all needed values
> ---
>
> Key: SLING-10859
> URL: https://issues.apache.org/jira/browse/SLING-10859
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the {{runmode.mapping}} file generated by the cpconverter does 
> not contain all the required file (feature model) references.
> This can happen when certain filenames that need to be referenced are a 
> substring of other file names.
> It centers around this code: 
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
> Assume that {{properties}} contains an entry 
> {{(default)=>my-webapp-all.json}}. Then next a feature file named 
> {{all.json}} is processed. As the name of it is a substring of the 
> pre-existing value it will not append. In fact it will replace the previous 
> value with the new value and as such remove it.
> The logic there should be fixed to not use substrings, but rather compare 
> entire names. Possibly a better idea would be to keep a Set 
> internally and convert that to a comma-separated list only once the 
> Properties are persisted in the {{save(()}} call.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10858:
---
Affects Version/s: (was: Content-Package to Feature Model Converter 
1.1.10)
   Content-Package to Feature Model Converter 1.1.6

> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the cpconverter generates an {{api-regions}} section with 
> {{global}} exports for packages, where the bundles providing those packages 
> are not actually listed in the feature. I have seen features with _no_ 
> bundles (just some configuration) and an {{api-regions}} section with lots of 
> exports, which clearly couldn't be satisfied by the feature as it did not 
> have any bundles at all.
> I believe that this might be caused by the fact that the 
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the 
> api-regions exports are bleeding between generated features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Maven Archetypes

[Cris Rockwell]

Hi
 
> Shall we mark those archetypes as deprecated for now?
Yes. I can make that update to the site (if no one objects). It makes sense to 
deprecate broken archetypes, at least temporarily. These provide an initial 
starting point for developers looking to try the framework, so I think they 
should not only work properly but also have good documentation if possible. I 
also understand resource constraints.


> I would be in favour of just maintaing the sling-project-archetype and
> making sure that a) it works and b) is a reasonable starting point for
> Sling-based apps.

FYI. I used sling-project-archetype two days ago. It worked well for me. It 
provided a reasonable starting basis for my new project.

- Cris


> On Oct 8, 2021, at 4:53 AM, Bertrand Delacretaz  
> wrote:
> 
> Hi,
> 
> On Fri, Oct 8, 2021 at 10:35 AM Robert Munteanu  wrote:
>> ...Thanks for looking into this. We do have lots of archetypes, and
>> technically all of them are supported, even the launchpad one...
> 
> Technically yes, but in practice not really, until someone is willing
> to spend time maintaining them.
> 
> Shall we mark those archetypes as deprecated for now?
> 
> It would make the situation clearer, that doesn't prevent people from
> using them, and that status can be reverted if someone wants to work
> on them later.
> 
> -Bertrand

[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10858:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.12

> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the cpconverter generates an {{api-regions}} section with 
> {{global}} exports for packages, where the bundles providing those packages 
> are not actually listed in the feature. I have seen features with _no_ 
> bundles (just some configuration) and an {{api-regions}} section with lots of 
> exports, which clearly couldn't be satisfied by the feature as it did not 
> have any bundles at all.
> I believe that this might be caused by the fact that the 
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the 
> api-regions exports are bleeding between generated features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10858) Incorrect API Regions generated in features

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10858:
---
Affects Version/s: (was: Content-Package to Feature Model Converter 
1.1.6)
   Content-Package to Feature Model Converter 1.1.10

> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the cpconverter generates an {{api-regions}} section with 
> {{global}} exports for packages, where the bundles providing those packages 
> are not actually listed in the feature. I have seen features with _no_ 
> bundles (just some configuration) and an {{api-regions}} section with lots of 
> exports, which clearly couldn't be satisfied by the feature as it did not 
> have any bundles at all.
> I believe that this might be caused by the fact that the 
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the 
> api-regions exports are bleeding between generated features.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10859) runmode.mapping file does not contain all needed values

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10859:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.12

> runmode.mapping file does not contain all needed values
> ---
>
> Key: SLING-10859
> URL: https://issues.apache.org/jira/browse/SLING-10859
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the {{runmode.mapping}} file generated by the cpconverter does 
> not contain all the required file (feature model) references.
> This can happen when certain filenames that need to be referenced are a 
> substring of other file names.
> It centers around this code: 
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
> Assume that {{properties}} contains an entry 
> {{(default)=>my-webapp-all.json}}. Then next a feature file named 
> {{all.json}} is processed. As the name of it is a substring of the 
> pre-existing value it will not append. In fact it will replace the previous 
> value with the new value and as such remove it.
> The logic there should be fixed to not use substrings, but rather compare 
> entire names. Possibly a better idea would be to keep a Set 
> internally and convert that to a comma-separated list only once the 
> Properties are persisted in the {{save(()}} call.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10859) runmode.mapping file does not contain all needed values

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10859:
---
Affects Version/s: (was: Content-Package to Feature Model Converter 
1.1.6)
   Content-Package to Feature Model Converter 1.1.10

> runmode.mapping file does not contain all needed values
> ---
>
> Key: SLING-10859
> URL: https://issues.apache.org/jira/browse/SLING-10859
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: A. J. David Bosschaert
>Priority: Major
>
> In some cases the {{runmode.mapping}} file generated by the cpconverter does 
> not contain all the required file (feature model) references.
> This can happen when certain filenames that need to be referenced are a 
> substring of other file names.
> It centers around this code: 
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
> Assume that {{properties}} contains an entry 
> {{(default)=>my-webapp-all.json}}. Then next a feature file named 
> {{all.json}} is processed. As the name of it is a substring of the 
> pre-existing value it will not append. In fact it will replace the previous 
> value with the new value and as such remove it.
> The logic there should be fixed to not use substrings, but rather compare 
> entire names. Possibly a better idea would be to keep a Set 
> internally and convert that to a comma-separated list only once the 
> Properties are persisted in the {{save(()}} call.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10861) Subpackages are missing dependency on their container

[Karl Pauls (Jira)]

Karl Pauls created SLING-10861:
--

 Summary: Subpackages are missing dependency on their container
 Key: SLING-10861
 URL: https://issues.apache.org/jira/browse/SLING-10861
 Project: Sling
  Issue Type: Bug
  Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.10
Reporter: Karl Pauls
 Fix For: Content-Package to Feature Model Converter 1.1.12


When the converter is extracting sub packages it is not adding a dependency to 
their containing package to them. It does for embedded packages but not for 
subpackages. It should add a dependency in both cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9653) HTL Maven Plugin: Include GitHub ribbon and edit button

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-9653.
--

> HTL Maven Plugin: Include GitHub ribbon and edit button
> ---
>
> Key: SLING-9653
> URL: https://issues.apache.org/jira/browse/SLING-9653
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: HTL Maven Plugin 2.0.4-1.4.0
>
>
> We should include a GitHub ribbon in the header (like outlined 
> https://maven.apache.org/skins/maven-fluido-skin/#GitHub_ribbons) to ease 
> contributing PRs. Also an edit button should be enabled on all Doxia 
> generated documentation pages via 
> https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html
>  (edit element in the site.xml)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10850) Update HTL dependencies

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-10850.
---

> Update HTL dependencies
> ---
>
> Key: SLING-10850
> URL: https://issues.apache.org/jira/browse/SLING-10850
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes, Scripting
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: HTL Maven Plugin 2.0.4-1.4.0
>
>
> The following dependencies in Dependencies have newer versions:
> org.apache.sling:org.apache.sling.scripting.sightly.compiler ...
>1.2.9-1.4.0-SNAPSHOT -> 1.2.14-1.4.0
> org.apache.sling:org.apache.sling.scripting.sightly.runtime ...
>1.2.5-1.4.0-SNAPSHOT -> 1.2.6-1.4.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10696) HTL Maven Plugin: Switch default phase to something prior compile

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-10696.
---

> HTL Maven Plugin: Switch default phase to something prior compile
> -
>
> Key: SLING-10696
> URL: https://issues.apache.org/jira/browse/SLING-10696
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: HTL Maven Plugin 2.0.2-1.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: HTL Maven Plugin 2.0.4-1.4.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The mojo validate is used to optionally precompile HTL scripts into Java 
> sources. As that steps requires a subsequent compilation via 
> maven-compiler-plugin which is bound to phase "compile" as well, the default 
> phase of "validate" should rather be a phase prior "compile"  to make sure 
> that the m-c-p:compile is always executed afterwards.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT][VOTE] Release Apache Sling HTL Maven Plugin 2.0.4-1.4.0

[Konrad Windszus]

The vote passed with 3 binding votes from Radu, Karl and Nicolas.

I will copy this release to the Sling dist directory and promote the artifacts 
to the central Maven repository.

Thanks for voting,
Konrad

> On 5. Oct 2021, at 11:36, Konrad Windszus  wrote:
> 
> Hi,
> 
> We solved 3 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348837
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2536/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2536 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ]  0 Don't care  
> [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Thanks,
> Konrad

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #23: SLING-10860 ignore server retries if response status code is in the expected status

[GitBox]

sonarcloud[bot] commented on pull request #23:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/23#issuecomment-938478935


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=23=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=23=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=23=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=23=false=CODE_SMELL)
   
   
[![89.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'89.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=23=new_coverage=list)
 [89.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=23=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=23=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=23=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10860) ServerErrorRetryStrategy should not retry if the code is expected

[Jira]

[ 
https://issues.apache.org/jira/browse/SLING-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426053#comment-17426053
 ] 

Thierry Ygé commented on SLING-10860:
-

Note I have prepared a PR on 
[https://github.com/apache/sling-org-apache-sling-testing-clients/pull/23]

I have added a test, and fixed 2, which I believe was actually originally 
pointing the issue or at least didn't test I believe the expectation, meaning 
that it would do number of tries and throw actually an exception.

 

> ServerErrorRetryStrategy should not retry if the code is expected
> -
>
> Key: SLING-10860
> URL: https://issues.apache.org/jira/browse/SLING-10860
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.10
>Reporter: Thierry Ygé
>Priority: Major
>
> Currently the ServerErrorRetryStrategy would retry for the list of error 
> codes or if not defined default for 500 and above.
> Let say you have a a test that expect a 500 or any other code define in the 
> list of error codes.
> client.doGet("someurl", 500);
> That will then retry a number of time, while in fact this code is expected to 
> happen, so in that case it should not retry.
> Since we have control on the "http" context parameter, the expected status 
> codes could be passed in that object , and so used to decide or not if we 
> need a retry too.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Maven Archetypes

[Bertrand Delacretaz]

Hi,

On Fri, Oct 8, 2021 at 10:35 AM Robert Munteanu  wrote:
> ...Thanks for looking into this. We do have lots of archetypes, and
> technically all of them are supported, even the launchpad one...

Technically yes, but in practice not really, until someone is willing
to spend time maintaining them.

Shall we mark those archetypes as deprecated for now?

It would make the situation clearer, that doesn't prevent people from
using them, and that status can be reverted if someone wants to work
on them later.

-Bertrand

Re: Maven Archetypes

[Robert Munteanu]

Hi,

On Thu, 2021-10-07 at 16:18 -0400, Cris Rockwell wrote:
> Hi all
> 
> For SLING-10857  
> I took an inventory of the Sling Maven archetypes in an attempt to
> improve the docs. and grouped the GitHub links below with
> failing/passing tests. Are they all still supported? I recently tried
> starting sling-launchpad-standalone-archetype but it failed to
> complete.

Thanks for looking into this. We do have lots of archetypes, and
technically all of them are supported, even the launchpad one.

In practice, we don't have the resources to maintain all of them. I
would be in favour of just maintaing the sling-project-archetype and
making sure that a) it works and b) is a reasonable starting point for
Sling-based apps.

Thanks,
Robert

> 
> Failing
> https://github.com/apache/sling-launchpad-standalone-archetype <
> https://github.com/apache/sling-launchpad-standalone-archetype>
> https://github.com/apache/sling-launchpad-webapp-archetype <
> https://github.com/apache/sling-launchpad-webapp-archetype>
> https://github.com/apache/sling-servlet-archetype <
> https://github.com/apache/sling-servlet-archetype>
> https://github.com/apache/sling-bundle-archetype <
> https://github.com/apache/sling-bundle-archetype>
> https://github.com/apache/sling-jcrinstall-bundle-archetype <
> https://github.com/apache/sling-jcrinstall-bundle-archetype>
> 
> Passing
> https://github.com/apache/sling-initial-content-archetype <
> https://github.com/apache/sling-initial-content-archetype>
> https://github.com/apache/sling-content-package-archetype <
> https://github.com/apache/sling-content-package-archetype>
> https://github.com/apache/sling-project-archetype <
> https://github.com/apache/sling-project-archetype>
> 
> Cris 
> 

[jira] [Created] (SLING-10860) ServerErrorRetryStrategy should not retry if the code is expected

[Jira]

Thierry Ygé created SLING-10860:
---

 Summary: ServerErrorRetryStrategy should not retry if the code is 
expected
 Key: SLING-10860
 URL: https://issues.apache.org/jira/browse/SLING-10860
 Project: Sling
  Issue Type: Bug
  Components: Apache Sling Testing Clients
Affects Versions: Apache Sling Testing Clients 2.0.10
Reporter: Thierry Ygé


Currently the ServerErrorRetryStrategy would retry for the list of error codes 
or if not defined default for 500 and above.

Let say you have a a test that expect a 500 or any other code define in the 
list of error codes.

client.doGet("someurl", 500);

That will then retry a number of time, while in fact this code is expected to 
happen, so in that case it should not retry.

Since we have control on the "http" context parameter, the expected status 
codes could be passed in that object , and so used to decide or not if we need 
a retry too.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)