[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1036841034 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] removed a comment on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] removed a comment on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1036178248 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #35: SLING-11133: cache models by picked implementation type
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/35#issuecomment-1036767815 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] removed a comment on pull request #35: SLING-11133: cache models by picked implementation type
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/35#issuecomment-1036010284 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #34: SLING-11132 - Exception handling while clearing OSGiServiceReferences
sonarcloud[bot] commented on pull request #34: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1036764007 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] removed a comment on pull request #34: SLING-11132 - Exception handling while clearing OSGiServiceReferences
sonarcloud[bot] removed a comment on pull request #34: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1034919380 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=34=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=34=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=34=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-4856) Resource resolution fails when mapped path is not normalised
[
https://issues.apache.org/jira/browse/SLING-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph resolved SLING-4856.
-
Resolution: Cannot Reproduce
I cannot reproduce that anymore, it seems to work now.
I tried this with the following mapping entry instead
{code}
/etc/map/http/my-site
sling:math="domaing.\\d+"
sling:internalRedirect="[/,/content/domain]"
{code}
If I try to resolve an existing resource everything works as expected.
If I try to resolve a non-existing resource with that I get
{{//non-existing-resource.selector1.selector2.html}}, which is properly parsed
into
{code}
selectors = [selector1, selector2]
extension = html
{code}
The resourcePath however remains
{{//non-existing-resource.selector1.selector2.html}}
> Resource resolution fails when mapped path is not normalised
>
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.1.14
>Reporter: Dirk Rudolph
>Priority: Major
>
> *Description*
> During resource resolution the resource metadata are populated with values
> used for the initialisation of the {{SlingHttpServletRequest}} in the
> {{{}SlingRequestProcessorImpl{}}}. The problem is that those metadata may be
> broken when there is a misconfigured mapping applied to the request path info.
> *How to reproduce*
> 1. Configure the {{ResourceResolverFactory}} to have a mapping
> {{{}/>/prefix{}}}.
> 2. Create a {{Resource}} /content/path/to/resource
> 3. Access the {{Resource}}
> 3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
> 3 b) using
> /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
> _Expected result_
> - The path can be resolved to the {{Resource}} (/)
> - The selector string is selector1.selector2 (x)
> - The suffix is /suffix.html (/)
> _Actual result_
> In the second case (b) the selector string has a leading ".". Which causes
> the {{RequestPathInfo}} to return a {{{}String[3]{}}}, where the first entry
> is an empty {{{}String{}}}.
> *Details*
> This is caused by the following code in {{resolveInternal}}
> {code:java}
> final String path = resolutionPath.toString();
> final String pathInfo = absPath.substring(path.length());
> resource.getResourceMetadata().setResolutionPath(path);
> resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
> {code}
> The problem is that in this special case the resolved path starts with a "//"
> and is therefor not properly normalised. As the resolution is working
> properly and the returned resource has its path normalised the length of
> resource path part in the absPath and resoultionPath differ by one. This
> causes resoultion path info to contain the last char of the resource path
> part of the absPath, which then causes wrong interpretation and extraction of
> the selector string from the resolution path info in the {{ResourceMetaData}}
> *Use case*
> In our current project based on AEM6 we use such a path prefix to use
> separated dispatcher farms for caching. We were able to fix the internal
> issue by properly configuring the prefix but as a user i would expect Sling
> to handle this misconfigured scenario either properly or at least log a
> warning that the mapped path is not normalised because debugging it was a
> little bit tricky.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] (SLING-4856) Resource resolution fails when mapped path is not normalised
[ https://issues.apache.org/jira/browse/SLING-4856 ]
Dirk Rudolph deleted comment on SLING-4856:
-
was (Author: diru):
Another area where this happens is with /etc/map entries that use
{{sling:match}}, for example:
{code}
/etc/map/http/my-site
+ sling:math = "domain.\\d.+"
+ sling:internalRedirect="[/,/content/domain]"
{code}
In this case the map entry is "partially" correct, meaning it resolves well for
paths in /content/domain but not for paths in /, for example:
{code}
http://domain/us/en.html => /content/domain/us/en.html (if
/content/domain/us/en exists)
http://domain/etc.ext/suffix.js => //etc.ext/suffix.js (if neither /etc nor
/contnet/domain/etc exist)
{code}
> Resource resolution fails when mapped path is not normalised
>
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.1.14
>Reporter: Dirk Rudolph
>Priority: Major
>
> *Description*
> During resource resolution the resource metadata are populated with values
> used for the initialisation of the {{SlingHttpServletRequest}} in the
> {{{}SlingRequestProcessorImpl{}}}. The problem is that those metadata may be
> broken when there is a misconfigured mapping applied to the request path info.
> *How to reproduce*
> 1. Configure the {{ResourceResolverFactory}} to have a mapping
> {{{}/>/prefix{}}}.
> 2. Create a {{Resource}} /content/path/to/resource
> 3. Access the {{Resource}}
> 3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
> 3 b) using
> /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
> _Expected result_
> - The path can be resolved to the {{Resource}} (/)
> - The selector string is selector1.selector2 (x)
> - The suffix is /suffix.html (/)
> _Actual result_
> In the second case (b) the selector string has a leading ".". Which causes
> the {{RequestPathInfo}} to return a {{{}String[3]{}}}, where the first entry
> is an empty {{{}String{}}}.
> *Details*
> This is caused by the following code in {{resolveInternal}}
> {code:java}
> final String path = resolutionPath.toString();
> final String pathInfo = absPath.substring(path.length());
> resource.getResourceMetadata().setResolutionPath(path);
> resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
> {code}
> The problem is that in this special case the resolved path starts with a "//"
> and is therefor not properly normalised. As the resolution is working
> properly and the returned resource has its path normalised the length of
> resource path part in the absPath and resoultionPath differ by one. This
> causes resoultion path info to contain the last char of the resource path
> part of the absPath, which then causes wrong interpretation and extraction of
> the selector string from the resolution path info in the {{ResourceMetaData}}
> *Use case*
> In our current project based on AEM6 we use such a path prefix to use
> separated dispatcher farms for caching. We were able to fix the internal
> issue by properly configuring the prefix but as a user i would expect Sling
> to handle this misconfigured scenario either properly or at least log a
> warning that the mapped path is not normalised because debugging it was a
> little bit tricky.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-event-dea] sonarcloud[bot] commented on pull request #3: SLING-11139 maintain metrics for the DEA
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-event-dea/pull/3#issuecomment-1036456158 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event-dea] sonarcloud[bot] removed a comment on pull request #3: SLING-11139 maintain metrics for the DEA
sonarcloud[bot] removed a comment on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-event-dea/pull/3#issuecomment-1036442582 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11139) DEA should expose the number of events it dealt with
[ https://issues.apache.org/jira/browse/SLING-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11139: -- Fix Version/s: Distributed Event Admin 1.1.6 > DEA should expose the number of events it dealt with > > > Key: SLING-11139 > URL: https://issues.apache.org/jira/browse/SLING-11139 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Distributed Event Admin 1.1.4 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Distributed Event Admin 1.1.6 > > Time Spent: 10m > Remaining Estimate: 0h > > The DEA should expose these metrics: > * The number of events succesfully distributed to other nodes > * The number of events it failed to distribute to other nodes > * The number of events received from other nodes and posted locally to the > eventAdmin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10351) update sling api to 2.23.4
[ https://issues.apache.org/jira/browse/SLING-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-10351. - > update sling api to 2.23.4 > -- > > Key: SLING-10351 > URL: https://issues.apache.org/jira/browse/SLING-10351 > Project: Sling > Issue Type: Task > Components: Servlets >Reporter: Joerg Hoh >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-event-dea] sonarcloud[bot] commented on pull request #3: SLING-11139 maintain metrics for the DEA
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-event-dea/pull/3#issuecomment-1036442582 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-dea=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-dea=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-dea=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-7613) Remove deprecation of SlingRepository.loginAdministrative()
[ https://issues.apache.org/jira/browse/SLING-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-7613. > Remove deprecation of SlingRepository.loginAdministrative() > --- > > Key: SLING-7613 > URL: https://issues.apache.org/jira/browse/SLING-7613 > Project: Sling > Issue Type: New Feature > Components: API >Affects Versions: JCR API 2.4.0 >Reporter: Joerg Hoh >Assignee: Robert Munteanu >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > There was a discussion on the Sling user list [1] about usecases which can > only be solved using the deprecated loginAdministrative() call. In the > context of Sling and Oak there are indeed a few cases which can be solved > best with a true admin session: > * locking and unlocking nodes which have been locked by a different user. > * at deployments resources/nodes are deployed at many locations inside the > repo, so you can either use an admin session or a system-user with an > equivalent set of permissions. > * the discussions leaves it open if the impersonation feature internally > relies on an admin session or can be achieved without it. > System users should be the preferred, but I would like to have an offical and > non-deprecated way to get an admin session in the API. It's ok if I need to > configure the explicit whitelisting as it is in place right now. But it > should be there. > Plus there should be proper documentation when to use which approach. > [1] > http://apache-sling.73963.n3.nabble.com/Deprecation-of-SlingRepository-loginAdministrative-td4081024.html -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11139) DEA should expose the number of events it dealt with
[ https://issues.apache.org/jira/browse/SLING-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491061#comment-17491061 ] Joerg Hoh commented on SLING-11139: --- PR https://github.com/apache/sling-org-apache-sling-event-dea/pull/3 > DEA should expose the number of events it dealt with > > > Key: SLING-11139 > URL: https://issues.apache.org/jira/browse/SLING-11139 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Distributed Event Admin 1.1.4 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The DEA should expose these metrics: > * The number of events succesfully distributed to other nodes > * The number of events it failed to distribute to other nodes > * The number of events received from other nodes and posted locally to the > eventAdmin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SLING-11139) DEA should expose the number of events it dealt with
[ https://issues.apache.org/jira/browse/SLING-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-11139: - Assignee: Joerg Hoh > DEA should expose the number of events it dealt with > > > Key: SLING-11139 > URL: https://issues.apache.org/jira/browse/SLING-11139 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Distributed Event Admin 1.1.4 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The DEA should expose these metrics: > * The number of events succesfully distributed to other nodes > * The number of events it failed to distribute to other nodes > * The number of events received from other nodes and posted locally to the > eventAdmin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11139) DEA should expose the number of events it dealt with
Joerg Hoh created SLING-11139: - Summary: DEA should expose the number of events it dealt with Key: SLING-11139 URL: https://issues.apache.org/jira/browse/SLING-11139 Project: Sling Issue Type: Improvement Components: Event Affects Versions: Distributed Event Admin 1.1.4 Reporter: Joerg Hoh The DEA should expose these metrics: * The number of events succesfully distributed to other nodes * The number of events it failed to distribute to other nodes * The number of events received from other nodes and posted locally to the eventAdmin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-4856) Resource resolution fails when mapped path is not normalised
[
https://issues.apache.org/jira/browse/SLING-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491060#comment-17491060
]
Dirk Rudolph commented on SLING-4856:
-
Another area where this happens is with /etc/map entries that use
{{sling:match}}, for example:
{code}
/etc/map/http/my-site
+ sling:math = "domain.\\d.+"
+ sling:internalRedirect="[/,/content/domain]"
{code}
In this case the map entry is "partially" correct, meaning it resolves well for
paths in /content/domain but not for paths in /, for example:
{code}
http://domain/us/en.html => /content/domain/us/en.html (if
/content/domain/us/en exists)
http://domain/etc.ext/suffix.js => //etc.ext/suffix.js (if neither /etc nor
/contnet/domain/etc exist)
{code}
> Resource resolution fails when mapped path is not normalised
>
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.1.14
>Reporter: Dirk Rudolph
>Priority: Major
>
> *Description*
> During resource resolution the resource metadata are populated with values
> used for the initialisation of the {{SlingHttpServletRequest}} in the
> {{{}SlingRequestProcessorImpl{}}}. The problem is that those metadata may be
> broken when there is a misconfigured mapping applied to the request path info.
> *How to reproduce*
> 1. Configure the {{ResourceResolverFactory}} to have a mapping
> {{{}/>/prefix{}}}.
> 2. Create a {{Resource}} /content/path/to/resource
> 3. Access the {{Resource}}
> 3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
> 3 b) using
> /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
> _Expected result_
> - The path can be resolved to the {{Resource}} (/)
> - The selector string is selector1.selector2 (x)
> - The suffix is /suffix.html (/)
> _Actual result_
> In the second case (b) the selector string has a leading ".". Which causes
> the {{RequestPathInfo}} to return a {{{}String[3]{}}}, where the first entry
> is an empty {{{}String{}}}.
> *Details*
> This is caused by the following code in {{resolveInternal}}
> {code:java}
> final String path = resolutionPath.toString();
> final String pathInfo = absPath.substring(path.length());
> resource.getResourceMetadata().setResolutionPath(path);
> resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
> {code}
> The problem is that in this special case the resolved path starts with a "//"
> and is therefor not properly normalised. As the resolution is working
> properly and the returned resource has its path normalised the length of
> resource path part in the absPath and resoultionPath differ by one. This
> causes resoultion path info to contain the last char of the resource path
> part of the absPath, which then causes wrong interpretation and extraction of
> the selector string from the resolution path info in the {{ResourceMetaData}}
> *Use case*
> In our current project based on AEM6 we use such a path prefix to use
> separated dispatcher farms for caching. We were able to fix the internal
> issue by properly configuring the prefix but as a user i would expect Sling
> to handle this misconfigured scenario either properly or at least log a
> warning that the mapped path is not normalised because debugging it was a
> little bit tricky.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-9642) Note on provisioning model docs that Sling Starter 12 switched to the feature model
[ https://issues.apache.org/jira/browse/SLING-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9642. Resolution: Fixed Fixed with https://github.com/apache/sling-site/pull/82 > Note on provisioning model docs that Sling Starter 12 switched to the feature > model > --- > > Key: SLING-9642 > URL: https://issues.apache.org/jira/browse/SLING-9642 > Project: Sling > Issue Type: Sub-task > Components: Documentation >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The provisioning model is still supported but people landing on that page > should be made aware that for Sling 12 we have moved to something else. A > single note mentioning the feature model should be enough. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-site] rombert merged pull request #82: SLING-9642 - Note on provisioning model docs that Sling Starter 12 switched to the feature model
rombert merged pull request #82: URL: https://github.com/apache/sling-site/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Releasing Sling Starter 12
Hi, tl;dr - I propose we release Sling Starter 12 at the end of February. Sling Starter 11 was released on October 23rd, 2018. We've accumulated a lot of improvements, and with the DockerHub image being switched to the main repository, I think we can start preparing the Starter 12 release. I propose that we reserve the next week for testing and discussions, and potentially kick off the release process on the week of 21st of February. Regarding the preparation, we should make sure the Starter is good shape. If you know of a bug ( in the Starter or a module that is included in the Starter ) please let me know so that we won't ship annoying bugs. Non-annoying bugs may get a free pass :-) It would also be useful to have some manual testing going on. It is also important to communicate how we have improved, so if you think an issue should be noted in the release notes please label it with 'Sling-12-ReleaseNotes'. The current list can be viewed at [1]. We did not finish everything we planned for Sling 12 [2], but that's OK IMO as we'll have lucky Sling 13. In terms of the feature model migration [3], there a couple of issues not yet handled: 1. Kickstart Launcher. I think it's OK to defer to Starter 13, as we already have settled on the way to launch [4] and we can always extend that 2. Archetype upgrades. These will come in after the Sling Starter 12 is released. 3. Documentation fixes. I think we can do this on an ongoing basis in the following weeks. So everyone - please give the Sling Starter a little attention and we can discuss in the week of February the 21st a concrete timeline for releasing it. Thanks! Robert [1]: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20labels%20%20%3D%20Sling-12-ReleaseNotes%20%20%20ORDER%20BY%20updated%20DESC [2]: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Starter%2012%22%20AND%20resolution%20IS%20EMPTY [3]: https://cwiki.apache.org/confluence/display/SLING/Migrating+the+Sling+Starter+to+the+Feature+Model [4]: https://cwiki.apache.org/confluence/display/SLING/Recommend+mechanism+for+launching+the+feature-model+based+Starter
[jira] [Closed] (SLING-11136) Fix Sonar Issue
[ https://issues.apache.org/jira/browse/SLING-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11136. - > Fix Sonar Issue > > > Key: SLING-11136 > URL: https://issues.apache.org/jira/browse/SLING-11136 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.8 >Reporter: Joerg Hoh >Priority: Major > > We have a sonar issue [1] in the DistributionPackageExporterServlet (write > unsafe content to the log). > https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=AX7oakIRZI5MX726deGg=44=false=true=VULNERABILITY -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11136) Fix Sonar Issue
[ https://issues.apache.org/jira/browse/SLING-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11136. --- Resolution: Duplicate (not sure why this was created twice ...) > Fix Sonar Issue > > > Key: SLING-11136 > URL: https://issues.apache.org/jira/browse/SLING-11136 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.8 >Reporter: Joerg Hoh >Priority: Major > > We have a sonar issue [1] in the DistributionPackageExporterServlet (write > unsafe content to the log). > https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=AX7oakIRZI5MX726deGg=44=false=true=VULNERABILITY -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-9635) Create a kickstart jar during the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491016#comment-17491016 ] Robert Munteanu commented on SLING-9635: Moved to feature as it does not technically block the feature model migration. > Create a kickstart jar during the Sling Starter build > - > > Key: SLING-9635 > URL: https://issues.apache.org/jira/browse/SLING-9635 > Project: Sling > Issue Type: New Feature > Components: Starter >Reporter: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > > Separate from SLING-9595, see > https://issues.apache.org/jira/browse/SLING-9595?focusedCommentId=17161943=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17161943 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-9635) Create a kickstart jar during the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-9635: --- Parent: (was: SLING-8350) Issue Type: New Feature (was: Sub-task) > Create a kickstart jar during the Sling Starter build > - > > Key: SLING-9635 > URL: https://issues.apache.org/jira/browse/SLING-9635 > Project: Sling > Issue Type: New Feature > Components: Starter >Reporter: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > > Separate from SLING-9595, see > https://issues.apache.org/jira/browse/SLING-9595?focusedCommentId=17161943=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17161943 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-4856) Resource resolution fails when mapped path is not normalised
[
https://issues.apache.org/jira/browse/SLING-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-4856:
Description:
*Description*
During resource resolution the resource metadata are populated with values used
for the initialisation of the {{SlingHttpServletRequest}} in the
{{{}SlingRequestProcessorImpl{}}}. The problem is that those metadata may be
broken when there is a misconfigured mapping applied to the request path info.
*How to reproduce*
1. Configure the {{ResourceResolverFactory}} to have a mapping
{{{}/>/prefix{}}}.
2. Create a {{Resource}} /content/path/to/resource
3. Access the {{Resource}}
3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
3 b) using /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
_Expected result_
- The path can be resolved to the {{Resource}} (/)
- The selector string is selector1.selector2 (x)
- The suffix is /suffix.html (/)
_Actual result_
In the second case (b) the selector string has a leading ".". Which causes the
{{RequestPathInfo}} to return a {{{}String[3]{}}}, where the first entry is an
empty {{{}String{}}}.
*Details*
This is caused by the following code in {{resolveInternal}}
{code:java}
final String path = resolutionPath.toString();
final String pathInfo = absPath.substring(path.length());
resource.getResourceMetadata().setResolutionPath(path);
resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
{code}
The problem is that in this special case the resolved path starts with a "//"
and is therefor not properly normalised. As the resolution is working properly
and the returned resource has its path normalised the length of resource path
part in the absPath and resoultionPath differ by one. This causes resoultion
path info to contain the last char of the resource path part of the absPath,
which then causes wrong interpretation and extraction of the selector string
from the resolution path info in the {{ResourceMetaData}}
*Use case*
In our current project based on AEM6 we use such a path prefix to use separated
dispatcher farms for caching. We were able to fix the internal issue by
properly configuring the prefix but as a user i would expect Sling to handle
this misconfigured scenario either properly or at least log a warning that the
mapped path is not normalised because debugging it was a little bit tricky.
was:
*Description*
During resource resolution the resource metadata are populated with values used
for the initialisation of the {{SlingHttpServletRequest}} in the
{{SlingRequestProcessorImpl}}. The problem is that those metadata may be broken
when there is a misconfigured mapping applied to the request path info.
*How to reproduce*
1. Configure the {{ResourceResolverFactory}} to have a mapping {{/>/prefix}}.
2. Create a {{Resource}} /content/path/to/resource
3. Access the {{Resource}}
3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
3 b) using /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
_Expected result_
- The path can be resolved to the {{Resource}} (/)
- The selector string is selector1.selector2 (x)
- The suffix is /suffix.html (/)
_Actual result_
In the second case (b) the selector string has a leading ".". Which causes the
{{RequestPathInfo}} to return a {{String\[3\]}}, where the first entry is an
empty {{String}}.
*Details*
This is caused by the following code in {{resolveInternal}}
{code}
final String path = resolutionPath.toString();
final String pathInfo = absPath.substring(path.length());
resource.getResourceMetadata().setResolutionPath(path);
resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
{code}
The problem is that in this special case the resolved path starts with a "//"
and is therefor not properly normalised. As the resolution is working properly
and returned resource has its path normalised the length of resource path part
in the absPath and resoultionPath differ by one. This causes resoultion path
info to contain the last char of the resource path part of the absPath, which
then causes wrong interpretation and extraction of the selector string from the
resolution path info in the {{ResourceMetaData}}
*Use case*
In our current project based on AEM6 we use such a path prefix to use separated
dispatcher farms for caching. We were able to fix the internal issue by
properly configuring the prefix but as a user i would expect Sling to handle
this misconfigured scenario either properly or at least log a warning that the
mapped path is not normalised because debugging it was a little bit tricky.
> Resource resolution fails when mapped path is not normalised
>
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue
[jira] [Assigned] (SLING-9642) Note on provisioning model docs that Sling Starter 12 switched to the feature model
[ https://issues.apache.org/jira/browse/SLING-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-9642: -- Assignee: Robert Munteanu > Note on provisioning model docs that Sling Starter 12 switched to the feature > model > --- > > Key: SLING-9642 > URL: https://issues.apache.org/jira/browse/SLING-9642 > Project: Sling > Issue Type: Sub-task > Components: Documentation >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > The provisioning model is still supported but people landing on that page > should be made aware that for Sling 12 we have moved to something else. A > single note mentioning the feature model should be enough. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] Buuhuu edited a comment on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
Buuhuu edited a comment on pull request #61:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036353203
The `null` was just returned all the way to the caller causing [the
following
test](https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/MockedResourceResolverImplTest.java#L555-L557)
to fail
```
testMapping() {
...
path = resourceResolver.map("/content.html");
Assert.assertEquals("/content.html", path);
...
}
MockedResourceResolverImplTest.testMapping:574 expected: but
was:
```
Looks like a regression to me that was hidden by the fact that
`testMapping()` did not test with the `MapEntries` initialised. But I cannot
reason about the behaviour being tested here.
`ResourceResolver#map()` however must not return `null` according to it's
contract.
Anyway, as all the tests pass now this change should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #910 is BROKEN
O] Checking legal files in:
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in:
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO]
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @
org.apache.sling.launchpad.testing ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 75 implicit excludes (use -debug for more details).
[INFO] 13 explicit excludes (use -debug for more details).
[INFO] 4 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated:
0, approved: 3 licenses.
[INFO]
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @
org.apache.sling.launchpad.testing ---
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 04:07 min
[INFO] Finished at: 2022-02-11T16:03:06Z
[INFO]
[INFO] [jenkins-event-spy] Generated
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven1028c5f3/maven-spy-20220211-155859-134845155113696436492.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated
by maven-failsafe-plugin:integration-test (default):
target/failsafe-reports/*.xml
Recording test results
[withMaven] Jenkins Task Scanner Plugin not found, don't display results of
source code scanning for 'TODO' and 'FIXME' in pipeline screen.
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 1 ms, Generated Artifacts
Publisher: 531 ms, Junit Publisher: 140010 ms, Dependencies Fingerprint
Publisher: 1237 ms, Open Task Scanner Publisher: 11 ms, CloudBees DevOptics
Gate Artifact Publisher: 64412 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext
[jira] [Updated] (SLING-4856) Resource resolution fails when mapped path is not normalised
[
https://issues.apache.org/jira/browse/SLING-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-4856:
Summary: Resource resolution fails when mapped path is not normalised
(was: Resource resolution breaks selector string when mapped path is not
normalised)
> Resource resolution fails when mapped path is not normalised
>
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.1.14
>Reporter: Dirk Rudolph
>Priority: Major
>
> *Description*
> During resource resolution the resource metadata are populated with values
> used for the initialisation of the {{SlingHttpServletRequest}} in the
> {{SlingRequestProcessorImpl}}. The problem is that those metadata may be
> broken when there is a misconfigured mapping applied to the request path info.
> *How to reproduce*
> 1. Configure the {{ResourceResolverFactory}} to have a mapping {{/>/prefix}}.
> 2. Create a {{Resource}} /content/path/to/resource
> 3. Access the {{Resource}}
> 3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
> 3 b) using
> /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
> _Expected result_
> - The path can be resolved to the {{Resource}} (/)
> - The selector string is selector1.selector2 (x)
> - The suffix is /suffix.html (/)
> _Actual result_
> In the second case (b) the selector string has a leading ".". Which causes
> the {{RequestPathInfo}} to return a {{String\[3\]}}, where the first entry is
> an empty {{String}}.
> *Details*
> This is caused by the following code in {{resolveInternal}}
> {code}
> final String path = resolutionPath.toString();
> final String pathInfo = absPath.substring(path.length());
> resource.getResourceMetadata().setResolutionPath(path);
> resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
> {code}
> The problem is that in this special case the resolved path starts with a "//"
> and is therefor not properly normalised. As the resolution is working
> properly and returned resource has its path normalised the length of resource
> path part in the absPath and resoultionPath differ by one. This causes
> resoultion path info to contain the last char of the resource path part of
> the absPath, which then causes wrong interpretation and extraction of the
> selector string from the resolution path info in the {{ResourceMetaData}}
> *Use case*
> In our current project based on AEM6 we use such a path prefix to use
> separated dispatcher farms for caching. We were able to fix the internal
> issue by properly configuring the prefix but as a user i would expect Sling
> to handle this misconfigured scenario either properly or at least log a
> warning that the mapped path is not normalised because debugging it was a
> little bit tricky.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] Buuhuu edited a comment on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
Buuhuu edited a comment on pull request #61:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036353203
The `null` was just returned all the way to the caller causing [the
following
test](https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/MockedResourceResolverImplTest.java#L555-L557)
to fail
```
testMapping() {
...
path = resourceResolver.map("/content.html");
Assert.assertEquals("/content.html", path);
...
}
MockedResourceResolverImplTest.testMapping:574 expected: but
was:
```
Looks like a regression to me that was hidden by the fact that
`testMapping()` did not test with the `MapEntries` initialised. But I cannot
reason about the behaviour being tested here. `ResourceResolver#map()` however
must not return `null` according to it's contract.
Anyway, as all the tests pass now this change should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (SLING-9638) Update Starter Docker image to be based on the feature model
[ https://issues.apache.org/jira/browse/SLING-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9638. Resolution: Fixed Final tweaks in - https://github.com/apache/sling-org-apache-sling-starter/pull/47 - https://github.com/apache/sling-org-apache-sling-starter/pull/48 The DockerHub build process is now automated, updated the documentation at https://cwiki.apache.org/confluence/display/SLING/Releasing+a+new+version+of+the+Sling+Starter#ReleasinganewversionoftheSlingStarter-DeploythedockerimageonDockerHub . > Update Starter Docker image to be based on the feature model > > > Key: SLING-9638 > URL: https://issues.apache.org/jira/browse/SLING-9638 > Project: Sling > Issue Type: Sub-task >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > The Sling Docker image is currently built from > https://github.com/apache/sling-org-apache-sling-starter-docker/ and is based > on the provisioning model. With the feature model we have a more > container-friendly approach where we can ship the feature files and select at > runtime what we are going to launch. > We should also take the opportunity and check if we can generate the Docker > image from the starter build itself, which makes it much simpler to develop > and evolve it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-resourceresolver] Buuhuu commented on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
Buuhuu commented on pull request #61:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036353203
The `null` was just returned all the way to the caller causing [the
following
test](https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/MockedResourceResolverImplTest.java#L555-L557)
to fail
```
testMapping() {
...
path = resourceResolver.map("/content.html");
Assert.assertEquals("/content.html", path);
...
}
MockedResourceResolverImplTest.testMapping:574 expected: but
was:
```
Looks like a regression to me that was hidden by the fact that
`testMapping()` did not test with the `MapEntries` initialised. But I cannot
reason about the behaviour being tested here.
Anyway, as all the tests pass now this change should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
sonarcloud[bot] commented on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036352662 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [90.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
sonarcloud[bot] removed a comment on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036328852 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #48: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert merged pull request #48: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #48: SLING-9638 - Update Starter Docker image to be based on the feature model
sonarcloud[bot] commented on pull request #48: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/48#issuecomment-1036351049 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=48=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=48=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=48=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=48=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=48) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=48=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #49: SLING-9638 - Update Starter Docker image to be based on the feature model
sonarcloud[bot] commented on pull request #49: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/49#issuecomment-1036343960 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=49=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=49=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=49=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=49=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=49) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=49=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
cziegeler commented on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036338006 I don't remember the details - but if previously [null] was returned, then I would check the code that is calling this method and how it handles this case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert closed pull request #49: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert closed pull request #49: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #49: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert commented on pull request #49: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/49#issuecomment-1036336051 Filed by mistake, closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #48: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert opened a new pull request #48: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/48 Final DockerHub tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #49: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert opened a new pull request #49: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/49 Add post_push hook to push release tags as latest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
sonarcloud[bot] removed a comment on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036321891 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
sonarcloud[bot] commented on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036328852 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
sonarcloud[bot] commented on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036321891 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=61=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=61=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] Buuhuu opened a new pull request #61: SLING-11138: run MockedResourceResolverImplTest with MapEntries populated
Buuhuu opened a new pull request #61:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61
In this change we make sure that the `MapEntries` are properly populated
when constructing the unit under test. This caused the `testMapping()` test to
fail in `MapEntries#replace()` for
```
// applied MapEntry: /content.html-/$
resourceResolver.map("/content.html");
```
This is because the regular expression substitution runs in an IAE with the
substitution pattern `/$` which has a "wrong" group reference.
@cziegeler I am not sure what the expected outcome of the mapping rule
should be `/content.html-/$` but that may be something you remember?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SLING-11138) Fix MockedResourceResolverImplTest#testMapping tests
Dirk Rudolph created SLING-11138:
Summary: Fix MockedResourceResolverImplTest#testMapping tests
Key: SLING-11138
URL: https://issues.apache.org/jira/browse/SLING-11138
Project: Sling
Issue Type: Improvement
Components: ResourceResolver
Affects Versions: Resource Resolver 1.8.2
Reporter: Dirk Rudolph
Currently the MockedResourceResolverImplTest tests do not initialise the
MapEntries correctly because this fails due to a missing service user mapping.
With this the {{testMapping()}} results may be wrong.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #47: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert merged pull request #47: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #47: SLING-9638 - Update Starter Docker image to be based on the feature model
sonarcloud[bot] commented on pull request #47: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/47#issuecomment-1036286180 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=47=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=47=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=47=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=47=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=47) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=47=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #47: SLING-9638 - Update Starter Docker image to be based on the feature model
rombert opened a new pull request #47: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/47 Update README to clarify some aspects of the Docker image usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #21: SLING-10625 convert RuntimeExceptions into RepositoryExceptions
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1036255289 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=21=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=21=new_coverage=list) [40.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=21=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=21=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=21=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490941#comment-17490941 ] Joerg Hoh commented on SLING-10625: --- created https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21 > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-4856) Resource resolution breaks selector string when mapped path is not normalised
[
https://issues.apache.org/jira/browse/SLING-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-4856:
Priority: Major (was: Minor)
> Resource resolution breaks selector string when mapped path is not normalised
> -
>
> Key: SLING-4856
> URL: https://issues.apache.org/jira/browse/SLING-4856
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.1.14
>Reporter: Dirk Rudolph
>Priority: Major
>
> *Description*
> During resource resolution the resource metadata are populated with values
> used for the initialisation of the {{SlingHttpServletRequest}} in the
> {{SlingRequestProcessorImpl}}. The problem is that those metadata may be
> broken when there is a misconfigured mapping applied to the request path info.
> *How to reproduce*
> 1. Configure the {{ResourceResolverFactory}} to have a mapping {{/>/prefix}}.
> 2. Create a {{Resource}} /content/path/to/resource
> 3. Access the {{Resource}}
> 3 a) using /content/path/to/resource.selector1.selector2.html/suffix.html
> 3 b) using
> /prefix/content/path/to/resource.selector1.selector2.html/suffix.html
> _Expected result_
> - The path can be resolved to the {{Resource}} (/)
> - The selector string is selector1.selector2 (x)
> - The suffix is /suffix.html (/)
> _Actual result_
> In the second case (b) the selector string has a leading ".". Which causes
> the {{RequestPathInfo}} to return a {{String\[3\]}}, where the first entry is
> an empty {{String}}.
> *Details*
> This is caused by the following code in {{resolveInternal}}
> {code}
> final String path = resolutionPath.toString();
> final String pathInfo = absPath.substring(path.length());
> resource.getResourceMetadata().setResolutionPath(path);
> resource.getResourceMetadata().setResolutionPathInfo(pathInfo);
> {code}
> The problem is that in this special case the resolved path starts with a "//"
> and is therefor not properly normalised. As the resolution is working
> properly and returned resource has its path normalised the length of resource
> path part in the absPath and resoultionPath differ by one. This causes
> resoultion path info to contain the last char of the resource path part of
> the absPath, which then causes wrong interpretation and extraction of the
> selector string from the resolution path info in the {{ResourceMetaData}}
> *Use case*
> In our current project based on AEM6 we use such a path prefix to use
> separated dispatcher farms for caching. We were able to fix the internal
> issue by properly configuring the prefix but as a user i would expect Sling
> to handle this misconfigured scenario either properly or at least log a
> warning that the mapped path is not normalised because debugging it was a
> little bit tricky.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-10625: - Assignee: Joerg Hoh > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1036178248 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11114) Use LazySupplier in ConfigurationBindingsValueProvider
[
https://issues.apache.org/jira/browse/SLING-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-4:
--
Fix Version/s: Context-Aware Configuration Impl 1.6.2
> Use LazySupplier in ConfigurationBindingsValueProvider
> --
>
> Key: SLING-4
> URL: https://issues.apache.org/jira/browse/SLING-4
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.6.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Context-Aware Configuration Impl 1.6.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When adding the bindings some logic is executed independent if the caconfig
> binding is used or not. In case the provided Bindings object is of type
> {{LazyBindings}}, a {{LazyBindings.Supplier}} can be used, which will only be
> resolved if the binding is actually used.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SLING-11114) Use LazySupplier in ConfigurationBindingsValueProvider
[
https://issues.apache.org/jira/browse/SLING-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486877#comment-17486877
]
Joerg Hoh edited comment on SLING-4 at 2/11/22, 12:44 PM:
--
Raised PR:
https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/5 and
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1
was (Author: joerghoh):
Raised PR: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/5
> Use LazySupplier in ConfigurationBindingsValueProvider
> --
>
> Key: SLING-4
> URL: https://issues.apache.org/jira/browse/SLING-4
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.6.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When adding the bindings some logic is executed independent if the caconfig
> binding is used or not. In case the provided Bindings object is of type
> {{LazyBindings}}, a {{LazyBindings.Supplier}} can be used, which will only be
> resolved if the binding is actually used.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] joerghoh opened a new pull request #1: SLING-11114 update SLING API to 2.21.0
joerghoh opened a new pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1 (as indicated in https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11137) Fix Sonar Issue
Joerg Hoh created SLING-11137: - Summary: Fix Sonar Issue Key: SLING-11137 URL: https://issues.apache.org/jira/browse/SLING-11137 Project: Sling Issue Type: Bug Components: Content Distribution Affects Versions: Content Distribution Core 0.4.8 Reporter: Joerg Hoh We have a sonar issue [1] in the DistributionPackageExporterServlet (write unsafe content to the log). https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=AX7oakIRZI5MX726deGg=44=false=true=VULNERABILITY -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-distribution-core] joerghoh commented on pull request #44: SLING-8595 update to bundle-parent 40
joerghoh commented on pull request #44: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#issuecomment-1036170056 I raised https://issues.apache.org/jira/browse/SLING-11137 to handle the sonar issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11136) Fix Sonar Issue
Joerg Hoh created SLING-11136: - Summary: Fix Sonar Issue Key: SLING-11136 URL: https://issues.apache.org/jira/browse/SLING-11136 Project: Sling Issue Type: Bug Components: Content Distribution Affects Versions: Content Distribution Core 0.4.8 Reporter: Joerg Hoh We have a sonar issue [1] in the DistributionPackageExporterServlet (write unsafe content to the log). https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=AX7oakIRZI5MX726deGg=44=false=true=VULNERABILITY -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-distribution-core] rombert commented on pull request #44: SLING-8595 update to bundle-parent 40
rombert commented on pull request #44: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#issuecomment-1036152508 Sounds good to me. I think @cschneider needs to find the time to review this, not sure if someone else can help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Scripting Core 2.4.4
+1 Le ven. 11 févr. 2022 à 12:48, Jörg Hoh a écrit : > +1 (non-binding) > > Am Mi., 9. Feb. 2022 um 15:17 Uhr schrieb Radu Cotescu : > > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12351310 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2598/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2598 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards, > > Radu Cotescu > > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh >
Re: [VOTE] Release Apache Sling Scripting Core 2.4.4
+1 (non-binding) Am Mi., 9. Feb. 2022 um 15:17 Uhr schrieb Radu Cotescu : > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351310 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2598/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2598 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [Scripting] Bindings returning null
Hi Radu, Right now some BVPs are build in a way, that the binding is just added if their value is not null, and this prevents often to make good use of the lazy evaluation; instead the checks are done when adding the binding. I would then adjust the existing BVPs to always use the features of the LazyBindings, even if that means that the binding is done with a null value. Jörg Am Mi., 9. Feb. 2022 um 11:46 Uhr schrieb Radu Cotescu : > Hi Jörg, > > > On 4 Feb 2022, at 12:00, Jörg Hoh > wrote: > > > > In my opinion we should adjust these BindingsValuesProviders and require > > the consumers of these bindings to make sure that they do the null-check > as > > required by the spec. > > What do you specifically mean by adjusting the BVPs? Do you have a small > example? > > Thanks, > Radu -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[GitHub] [sling-org-apache-sling-distribution-core] joerghoh commented on pull request #44: SLING-8595 update to bundle-parent 40
joerghoh commented on pull request #44: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#issuecomment-1036117932 Let's try to get this merged, and then we will do an update to the most recent version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #907 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/907/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Resolved] (SLING-11103) Improvements in synchronization and additional logging for TransformerFactoryServiceTracker in sling rewriter
[ https://issues.apache.org/jira/browse/SLING-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11103. -- Fix Version/s: Version Rewriter 1.3.2 Resolution: Fixed > Improvements in synchronization and additional logging for > TransformerFactoryServiceTracker in sling rewriter > - > > Key: SLING-11103 > URL: https://issues.apache.org/jira/browse/SLING-11103 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.3.0 >Reporter: Sagar Miglani >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Version Rewriter 1.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Variable "isCacheValid" at > [TransformerFactoryServiceTracker:49|https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/TransformerFactoryServiceTracker.java#L49] > doesn't seem to be properly synchronized. Also additional logging is > required in TransformerFactoryServiceTracker for debugging purpose. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] removed a comment on pull request #44: SLING-8595 update to bundle-parent 40
sonarcloud[bot] removed a comment on pull request #44: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#issuecomment-770038007 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [87 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_coverage=list) [11.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_duplicated_lines_density=list) [12.9% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] sonarcloud[bot] commented on pull request #44: SLING-8595 update to bundle-parent 40
sonarcloud[bot] commented on pull request #44: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#issuecomment-1036080793 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-core=44=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [88 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core=44=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_coverage=list) [11.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_duplicated_lines_density=list) [12.9% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-core=44=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Feature Model Unpack Extension 0.3.0
+1 regards, Karl On Fri, Feb 11, 2022 at 11:26 AM Stefan Seifert wrote: > > +1 -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Scripting Core 2.4.4
+1 regards, Karl On Fri, Feb 11, 2022 at 11:30 AM Stefan Seifert wrote: > > +1 -- Karl Pauls karlpa...@gmail.com
RE: [VOTE] Release Apache Sling Scripting Core 2.4.4
+1
RE: [VOTE] Release Apache Sling Feature Model Unpack Extension 0.3.0
+1
RE: [VOTE] Release Apache Sling Testing Clients version 3.0.12
+1
[jira] [Closed] (SLING-10313) Deprecate ResourceResolver.map in favor of ResourceMapper.getMapping()
[
https://issues.apache.org/jira/browse/SLING-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10313.
-
> Deprecate ResourceResolver.map in favor of ResourceMapper.getMapping()
> --
>
> Key: SLING-10313
> URL: https://issues.apache.org/jira/browse/SLING-10313
> Project: Sling
> Issue Type: Improvement
> Components: API
>Affects Versions: API 2.23.0
>Reporter: Joerg Hoh
>Priority: Major
>
> For some time we have the RessourceMapper interface, which claims to replace
> and improve the {{resourceResolver.map()}} methods.
> We should deprecate both methods in the ResourceResolver and recommend to use
> the ResourceMapper instead.
> (The iResourceResolverImpl is already using the ResourceMapper.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #35: SLING-11133: cache models by picked implementation type
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/35#issuecomment-1036010284 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl=35=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=35=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl=35=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11133) Cache model for its implementation type
[
https://issues.apache.org/jira/browse/SLING-11133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-11133:
-
Description:
Currently the ModelAdapterFactory caches a cacheable model for the requested
type only
[https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L430-L432]
{code:java}
if (result.wasSuccessful() && modelAnnotation.cache() && adaptableCache !=
null) {
adaptableCache.put(requestedType, new
SoftReference(result.getValue()));
}
{code}
However, if a model is an adapter of multiple types an instance of it can also
be returned for more than just the requested type.
{code:java}
interface AdapterType1 {}
interface AdapterType2 {}
@Model(adaptables = Resource.class, adapterType={AdapterType1.class,
AdapterType2.class}, cache = true)
class Model implements AdapterType1, AdapterType2 {}
assertSame(resource.adaptTo(Model.class), resouce.adaptTo(AdapterType1.class));
assertSame(resource.adaptTo(AdapterType1.class),
resouce.adaptTo(AdapterType2.class));
{code}
While it is not save to cache the model for all of its adapter types (see
SLING-11074), it is certainly save to cache the Model for its implementation
type.
In fact, when caching the Model for the implementation type, caching it for the
requested type is redundant. This is based on the assumption that the
{{org.apache.sling.models.impl.AdapterImplementations#lookup()}} always returns
the same implementation for given adapterType and adaptable.
was:
Currently the ModelAdapterFactory caches a cacheable model for the requested
type only
https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L430-L432
{code}
if (result.wasSuccessful() && modelAnnotation.cache() && adaptableCache !=
null) {
adaptableCache.put(requestedType, new
SoftReference(result.getValue()));
}
{code}
However, if a model is an adapter of multiple types an instance of it can also
be returned for more than just the requested type.
While it is not save to cache the model for all of its adapter types (see
SLING-11074), it is certainly save to cache the Model for its implementation
type additionally to the requested type.
In fact, when caching the Model for the implementation type, caching it for the
requested type is redundant. This is based on the assumption that the
{{org.apache.sling.models.impl.AdapterImplementations#lookup()}} always returns
the same implementation for given adapterType and adaptable (considering no
newly registered ImplementationPickers interfere with it)
> Cache model for its implementation type
> ---
>
> Key: SLING-11133
> URL: https://issues.apache.org/jira/browse/SLING-11133
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Reporter: Dirk Rudolph
>Assignee: Dirk Rudolph
>Priority: Major
> Fix For: Models Implementation 1.5.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the ModelAdapterFactory caches a cacheable model for the requested
> type only
> [https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L430-L432]
> {code:java}
> if (result.wasSuccessful() && modelAnnotation.cache() && adaptableCache !=
> null) {
> adaptableCache.put(requestedType, new
> SoftReference(result.getValue()));
> }
> {code}
> However, if a model is an adapter of multiple types an instance of it can
> also be returned for more than just the requested type.
> {code:java}
> interface AdapterType1 {}
> interface AdapterType2 {}
> @Model(adaptables = Resource.class, adapterType={AdapterType1.class,
> AdapterType2.class}, cache = true)
> class Model implements AdapterType1, AdapterType2 {}
> assertSame(resource.adaptTo(Model.class),
> resouce.adaptTo(AdapterType1.class));
> assertSame(resource.adaptTo(AdapterType1.class),
> resouce.adaptTo(AdapterType2.class));
> {code}
> While it is not save to cache the model for all of its adapter types (see
> SLING-11074), it is certainly save to cache the Model for its implementation
> type.
> In fact, when caching the Model for the implementation type, caching it for
> the requested type is redundant. This is based on the assumption that the
> {{org.apache.sling.models.impl.AdapterImplementations#lookup()}} always
> returns the same implementation for given adapterType and adaptable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-models-integration-tests] Buuhuu opened a new pull request #3: SLING-11133: add IT coverage for caching multiple adapter types
Buuhuu opened a new pull request #3: URL: https://github.com/apache/sling-org-apache-sling-models-integration-tests/pull/3 For details of the implementation see https://github.com/apache/sling-org-apache-sling-models-impl/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-models-impl] Buuhuu opened a new pull request #35: SLING-11133: cache models by picked implementation type
Buuhuu opened a new pull request #35:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/35
Currently the model caching works with the requested type. This does not
support models that are registered with multiple adapter types. For example a
model `ModelA` that is registered with `AdapterType1` and `AdapterType2` should
be cached after being adapted using `AdapterType1` and can be returned from
cache if adapted using `AdapterType2`.
```
interface AdapterType1 {}
interface AdapterType2 {}
@Model(adaptables = Resource.class, adapterType={AdapterType1.class,
AdapterType2.class}, cache = true)
class Model implements AdapterType1, AdapterType2 {}
assertSame(resource.adaptTo(AdapterType1), resouce.adaptTo(AdapterType2));
```
With this change the models are cached with their implementation type as
key, which preserves the existing behaviour but also supports the one described
above. It should also behave as expected, when the implementation type for a
given adapter type and adaptable changes during the lifetime of the cache, for
example when a new implementation picker gets registered.
@raducotescu any thoughts? I saw you reviewing a previous PR in this area.
@kwin maybe any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (SLING-11129) FSClassLoader shows Copyright of Adobe
[ https://issues.apache.org/jira/browse/SLING-11129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-11129: - Assignee: Dan Klco > FSClassLoader shows Copyright of Adobe > -- > > Key: SLING-11129 > URL: https://issues.apache.org/jira/browse/SLING-11129 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: File System ClassLoader 1.0.14 >Reporter: Joerg Hoh >Assignee: Dan Klco >Priority: Major > > The FSClassLoaderMBean java file still shows copyright by Adobe and also > refers to "ACS AEM Commons Bundle": > https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/f60524e668a8e31c0697df418c2aef8b519c30f9/src/main/java/org/apache/sling/commons/fsclassloader/FSClassLoaderMBean.java#L5 -- This message was sent by Atlassian Jira (v8.20.1#820001)
