[jira] [Comment Edited] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493236#comment-17493236
]
Oliver Lietz edited comment on SLING-11143 at 2/16/22, 7:58 PM:
By adding a single line ({{\-jpms-module-info:}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for -failsafe- surefire will also make the tests working on Java
17 ({{\--add-opens java.base/java.lang=org.apache.sling.commons.threads}}).
was (Author: olli):
By adding a single line ({{{}-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for -failsafe- surefire will also make the tests working on Java
17 ({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493236#comment-17493236
]
Oliver Lietz edited comment on SLING-11143 at 2/16/22, 7:57 PM:
By adding a single line ({{{}-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for -failsafe- surefire will also make the tests working on Java
17 ({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
was (Author: olli):
By adding a single line ({{\-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for failsafe will also make the tests working on Java 17
({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-11147:
-
Description:
* building with JDK 11 and 17 (JDK 8 does not support JPMS)
* opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT Failsafe,
keeping issue title to match commit)
was:
* building with JDK 11 and 17 (JDK 8 does not support JPMS)
* opening java.base/java.lang to Commons Threads
> Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
> ---
>
> Key: SLING-11147
> URL: https://issues.apache.org/jira/browse/SLING-11147
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * building with JDK 11 and 17 (JDK 8 does not support JPMS)
> * opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT
> Failsafe, keeping issue title to match commit)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-10831) o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493466#comment-17493466
]
Oliver Lietz commented on SLING-10831:
--
[~rombert], Fine so far. But we should have a strategy how to support JPMS in
the future.
> o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
>
>
> Key: SLING-10831
> URL: https://issues.apache.org/jira/browse/SLING-10831
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> When running the Sling Starter with Java 17, the following messages come up:
> {noformat}21.09.2021 11:13:54.247 *WARN* [sling-default-1]
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals
> Could not set up thread local cleaner (most probably not a compliant JRE): {}
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> 21.09.2021 11:13:54.248 *ERROR* [sling-default-1]
> org.apache.sling.extensions.threaddump.internal.Activator Uncaught exception
> in Thread Thread[sling-default-1,5,main]
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11146) Add initial JPMS support
[
https://issues.apache.org/jira/browse/SLING-11146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493463#comment-17493463
]
Oliver Lietz commented on SLING-11146:
--
[~rombert], I did some quick checks with Starter (Smoke ITs) and Karaf. Can you
cross-check and confirm everything is still working as expected with
{{{}3.2.23-SNAPSHOT{}}}?
> Add initial JPMS support
>
>
> Key: SLING-11146
> URL: https://issues.apache.org/jira/browse/SLING-11146
> Project: Sling
> Issue Type: New Feature
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * adding module info
> * narrowing dependency down to OSGi Configuration Admin
> * updating slf4j to use new module name
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[ https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11147. -- Resolution: Done > Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS) > --- > > Key: SLING-11147 > URL: https://issues.apache.org/jira/browse/SLING-11147 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Threads 3.3.0 > > > * building with JDK 11 and 17 (JDK 8 does not support JPMS) > * opening java.base/java.lang to Commons Threads -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[ https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-11147: - Description: * building with JDK 11 and 17 (JDK 8 does not support JPMS) * opening java.base/java.lang to Commons Threads > Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS) > --- > > Key: SLING-11147 > URL: https://issues.apache.org/jira/browse/SLING-11147 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Threads 3.3.0 > > > * building with JDK 11 and 17 (JDK 8 does not support JPMS) > * opening java.base/java.lang to Commons Threads -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-10831) o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493354#comment-17493354
]
Robert Munteanu commented on SLING-10831:
-
[~cziegeler] - I filed SLING-11149 for the logging part.
[~olli] - I see you filed issues for the improvements that you propose, so I
guess nothing left to clarify here.
> o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
>
>
> Key: SLING-10831
> URL: https://issues.apache.org/jira/browse/SLING-10831
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> When running the Sling Starter with Java 17, the following messages come up:
> {noformat}21.09.2021 11:13:54.247 *WARN* [sling-default-1]
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals
> Could not set up thread local cleaner (most probably not a compliant JRE): {}
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> 21.09.2021 11:13:54.248 *ERROR* [sling-default-1]
> org.apache.sling.extensions.threaddump.internal.Activator Uncaught exception
> in Thread Thread[sling-default-1,5,main]
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SLING-11149) Expose information about cleaned up leftover ThreadLocal values
Robert Munteanu created SLING-11149:
---
Summary: Expose information about cleaned up leftover ThreadLocal
values
Key: SLING-11149
URL: https://issues.apache.org/jira/browse/SLING-11149
Project: Sling
Issue Type: New Feature
Components: Commons
Reporter: Robert Munteanu
Fix For: Commons Threads 3.3.0
As discussed in SLING-10831, the ThreadLocal cleanup feature is valuable as a
safeguard for code that might lead to hard-to-diagnose memory leaks.
At the same time, it does not let developers know when a leak has been
prevented. We should improve this. The following improvements can be made:
# log with a {{WARN}} level any cleanup operation. Care must be taken to not
overflow the logs, so maybe a way of only reporting a cleanup for a certain key
once can be used (memory-bound)
# expose a counter that reports how many cleanup operations have been performed
by a given thread pool
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11146) Add initial JPMS support
[ https://issues.apache.org/jira/browse/SLING-11146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-11146: - Description: * adding module info * narrowing dependency down to OSGi Configuration Admin * updating slf4j to use new module name > Add initial JPMS support > > > Key: SLING-11146 > URL: https://issues.apache.org/jira/browse/SLING-11146 > Project: Sling > Issue Type: New Feature > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Threads 3.3.0 > > > * adding module info > * narrowing dependency down to OSGi Configuration Admin > * updating slf4j to use new module name -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11146) Add initial JPMS support
[ https://issues.apache.org/jira/browse/SLING-11146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11146. -- Resolution: Done > Add initial JPMS support > > > Key: SLING-11146 > URL: https://issues.apache.org/jira/browse/SLING-11146 > Project: Sling > Issue Type: New Feature > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Threads 3.3.0 > > > * adding module info > * narrowing dependency down to OSGi Configuration Admin > * updating slf4j to use new module name -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11148) Feature launcher should look up configadmin service with all service lookup
[ https://issues.apache.org/jira/browse/SLING-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11148. Resolution: Fixed Done in https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/38 > Feature launcher should look up configadmin service with all service lookup > --- > > Key: SLING-11148 > URL: https://issues.apache.org/jira/browse/SLING-11148 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.2.0 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model Launcher 1.2.2 > > > The feature model launcher looks up config admins inside the launched > features using a service tracker without setting the all services boolean to > true. That can cause it to miss config admins if the config admin interface > is available on the outside. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls merged pull request #38: SLING-11148: lookup the config admin with all services
karlpauls merged pull request #38: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11148) Feature launcher should look up configadmin service with all service lookup
Karl Pauls created SLING-11148: -- Summary: Feature launcher should look up configadmin service with all service lookup Key: SLING-11148 URL: https://issues.apache.org/jira/browse/SLING-11148 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model Launcher 1.2.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Feature Model Launcher 1.2.2 The feature model launcher looks up config admins inside the launched features using a service tracker without setting the all services boolean to true. That can cause it to miss config admins if the config admin interface is available on the outside. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11145) Update to Sling Bundle Parent 47
[ https://issues.apache.org/jira/browse/SLING-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11145. -- Resolution: Done > Update to Sling Bundle Parent 47 > > > Key: SLING-11145 > URL: https://issues.apache.org/jira/browse/SLING-11145 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Threads 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
Oliver Lietz created SLING-11147: Summary: Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS) Key: SLING-11147 URL: https://issues.apache.org/jira/browse/SLING-11147 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Threads 3.3.0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11146) Add initial JPMS support
Oliver Lietz created SLING-11146: Summary: Add initial JPMS support Key: SLING-11146 URL: https://issues.apache.org/jira/browse/SLING-11146 Project: Sling Issue Type: New Feature Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Threads 3.3.0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11145) Update to Sling Bundle Parent 47
Oliver Lietz created SLING-11145: Summary: Update to Sling Bundle Parent 47 Key: SLING-11145 URL: https://issues.apache.org/jira/browse/SLING-11145 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Threads 3.3.0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-10831) o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493240#comment-17493240
]
Carsten Ziegeler commented on SLING-10831:
--
I agree that this is a last resort for bad code; however if developers really
rely on it, not having this clean up will cause trouble.
Can we add a error log message each time this code does actually a clean up, so
clients are aware of it and eventually fix their code?
> o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
>
>
> Key: SLING-10831
> URL: https://issues.apache.org/jira/browse/SLING-10831
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> When running the Sling Starter with Java 17, the following messages come up:
> {noformat}21.09.2021 11:13:54.247 *WARN* [sling-default-1]
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals
> Could not set up thread local cleaner (most probably not a compliant JRE): {}
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> 21.09.2021 11:13:54.248 *ERROR* [sling-default-1]
> org.apache.sling.extensions.threaddump.internal.Activator Uncaught exception
> in Thread Thread[sling-default-1,5,main]
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-10831) o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493239#comment-17493239
]
Oliver Lietz commented on SLING-10831:
--
[~rombert], I checked the code again, everything is already in place. We just
have to fix the tests for Java 17.
> o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17
>
>
> Key: SLING-10831
> URL: https://issues.apache.org/jira/browse/SLING-10831
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> When running the Sling Starter with Java 17, the following messages come up:
> {noformat}21.09.2021 11:13:54.247 *WARN* [sling-default-1]
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals
> Could not set up thread local cleaner (most probably not a compliant JRE): {}
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> 21.09.2021 11:13:54.248 *ERROR* [sling-default-1]
> org.apache.sling.extensions.threaddump.internal.Activator Uncaught exception
> in Thread Thread[sling-default-1,5,main]
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:58)
> [org.apache.sling.commons.threads:3.2.20]
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make
> field java.lang.ThreadLocal$ThreadLocalMap java.lang.Thread.threadLocals
> accessible: module java.base does not "opens java.lang" to unnamed module
> @6e04bc96
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.field(ThreadLocalCleaner.java:77)
> [org.apache.sling.commons.threads:3.2.20]
> at
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.(ThreadLocalCleaner.java:54)
> [org.apache.sling.commons.threads:3.2.20]
> ... 4 common frames omitted
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493236#comment-17493236
]
Oliver Lietz edited comment on SLING-11143 at 2/16/22, 1:27 PM:
By adding a single line ({{\-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for failsafe will also make the tests working on Java 17
({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
was (Author: olli):
By adding a single line ({{{}-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for failsafe will also make the tests working on Java 17
({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493236#comment-17493236
]
Oliver Lietz commented on SLING-11143:
--
By adding a single line ({{{}-jpms-module-info:{}}}) to {{bnd.bnd}} for Commons
Threads we create a {{module-info.class}} with proper module name. Adding a
configuration for failsafe will also make the tests working on Java 17
({{{}--add-opens java.base/java.lang=org.apache.sling.commons.threads{}}}).
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493228#comment-17493228
]
Robert Munteanu commented on SLING-11143:
-
[~olli] - how can we do that? {{add-opens}} takes module as arguments, and we
are not running on the module layer (
https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-12F945EB-71D6-46AF-8C3D-D354FD0B1781
).
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11143) Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
[
https://issues.apache.org/jira/browse/SLING-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493221#comment-17493221
]
Oliver Lietz commented on SLING-11143:
--
[~rombert], Can we be more precise and limit add opens to
{{{}org.apache.sling.commons.threads{}}}?
> Work around SLING-10831 by adding an add-opens flag to the Starter entrypoint
> -
>
> Key: SLING-11143
> URL: https://issues.apache.org/jira/browse/SLING-11143
> Project: Sling
> Issue Type: Sub-task
> Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Until we get SLING-10831 properly fixed we should ensure that the Docker
> image does not print the error by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #920 is BROKEN
servlet.init.createAbsoluteURI=true, servlet.init.csrf-protection=disabled,
servlet.init.protectedhandlers-config=org.apache.jackrabbit.server.remoting.davex.AclRemoveHandler,
servlet.init.resource-path-prefix=/server, sling.auth.requirements=-/server}]
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 756 from bundle
ref=[javax.servlet.Servlet] properties={objectClass=[javax.servlet.Servlet],
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=DavExAuthHttpContext),
osgi.http.whiteboard.servlet.pattern=/server/*, service.bundleid=117,
service.description=Sling JcrRemoting Servlet, service.id=756,
service.scope=singleton, service.vendor=The Apache Software Foundation,
servlet.init.createAbsoluteURI=true, servlet.init.csrf-protection=disabled,
servlet.init.protectedhandlers-config=org.apache.jackrabbit.server.remoting.davex.AclRemoveHandler,
servlet.init.resource-path-prefix=/server, sling.auth.requirements=-/server}]
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 459 from bundle 133 : org.apache.sling.engine:2.8.0
ref=[javax.servlet.Servlet] properties={objectClass=[javax.servlet.Servlet],
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
osgi.http.whiteboard.servlet.name=ApacheSling/2.8,
osgi.http.whiteboard.servlet.pattern=/, service.bundleid=133,
service.description=Apache Sling Engine Main Servlet, service.id=459,
service.scope=singleton, service.vendor=The Apache Software Foundation}]
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 475 from bundle 133 : org.apache.sling.engine:2.8.0
ref=[javax.servlet.Filter] properties={component.id=225,
component.name=org.apache.sling.engine.impl.log.RequestLoggerFilter,
objectClass=[javax.servlet.Filter],
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
osgi.http.whiteboard.filter.pattern=[/], service.bundleid=133,
service.description=Request Logger Filter, service.id=475,
service.ranking=32768, service.scope=bundle, service.vendor=The Apache Software
Foundation}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 478 from bundle 133 : org.apache.sling.engine:2.8.0
ref=[javax.servlet.Filter] properties={component.id=226,
component.name=org.apache.sling.engine.parameters, file.max=-1,
file.threshold=256000, objectClass=[javax.servlet.Filter],
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
osgi.http.whiteboard.filter.pattern=[/], request.max=-1, service.bundleid=133,
service.description=Filter for request parameter support, service.id=478,
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache
Software Foundation, sling.default.max.parameters=1,
sling.default.parameter.checkForAdditionalContainerParameters=false,
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 96 from bundle 39 :
org.apache.sling.launchpad.test-services:12.0.0.SNAPSHOT
ref=[javax.servlet.Servlet] properties={component.id=64,
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
objectClass=[javax.servlet.Servlet],
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=39,
service.id=96, service.scope=bundle}] Ignoring unmatching Servlet service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO]
[INFO] --- tools-maven-plugin:1.4:verify-legal-files (verify-legal-files) @
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in:
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in:
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO]
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @
org.apache.sling.launchpad.testing ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from
/home/jenkins/workspace/e-sling-launchpad-testing_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 75 implicit excludes (use -debug for more details).
[INFO] 13 explicit excludes (use -debug for more details).
[INFO] 4 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated:
0, approved: 3 licenses.
[INFO]
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @
org.apache.sling.launchpad.testing ---
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 04:01 min
[INFO] Finished at: 2022-02-16T11:39:53Z
[INFO]
[INFO] [jenkins-event-spy] Generated
/home/jenkins/workspace/e-sling-launchpad-testing_ma
