[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[ https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503909#comment-17503909 ] Eric Norman commented on SLING-11189: - FYI: I created [PR #13|https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13] with an alternative solution for your consideration. Basically, you declare with configuration a default set of file extensions that are expected to have a registered ContentReader. Alternatively, the author can declare what extensions are required for a specific PathEntry with a directive in the manifest instruction if you prefer that. When processing the bundle, if it does not find a ContentReader and we detect that we were expecting to find one, then we throw an exception and the bundle goes into the delayedBundles list to be retried later when a new ContentReader component arrives. I think this should be backward compatible and seems to preserve the flexibility for any customization people may do. I assume this should fix the original problem, but I was not ever able to reproduce that problem locally to confirm. > Content Loader: Race condition registering readers vs. loading content > -- > > Key: SLING-11189 > URL: https://issues.apache.org/jira/browse/SLING-11189 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: JCR ContentLoader 2.5.2 > > Time Spent: 3h > Remaining Estimate: 0h > > in SLING-11168 we detected a specific problem with Composum in Sling Starter > 12, which only occured on Windows 10 environments (and even there not > consistently in every scenario). > it seems that it may happen that Sling-Initial-Content is loaded from the > bundles when the ContentReader implementations are not yet registered on the > ContentReaderWhiteboard. > when this happens, the content is loaded into the repository, but files like > *.json are not transformed to nodes and properties, but is stored as binary > json files in the repository. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063495469 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [91.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] removed a comment on pull request #13: SLING-11189 Race condition registering readers vs. loading content
sonarcloud[bot] removed a comment on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063486883 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [91.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063486883 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [91.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman opened a new pull request #13: SLING-11189 Race condition registering readers vs. loading content
enapps-enorman opened a new pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13 A declared requireImportProvider directive or configured defaultRequireImportProviders list so the author can ensure that the files are processed as intended This is an attempt an implementation of what I proposed at https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062982927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Discovery Commons 1.0.26 and Discovery Base 2.0.12
+1 Regards Timothee Le mer. 9 mars 2022 à 14:51, Stefan Egli a écrit : > Hi, > > > We solved 2 issues completely and 1 issue partially in both of these > release: > https://issues.apache.org/jira/projects/SLING/versions/12350269 > https://issues.apache.org/jira/projects/SLING/versions/12350270 > > The main issue still open is SLING-10489, which will be fixed with > upcoming discovery.oak release > (which coincidentally, not, is dependent on Discovery Commons 1.0.26) > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2610 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > Usage: > sh check_staged_release.sh 2610 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > Cheers, > Stefan >
[GitHub] [sling-org-apache-sling-scripting-core] raducotescu merged pull request #14: SLING-11182 - Correct potential errors introduced by BVP logging
raducotescu merged pull request #14: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] raducotescu commented on a change in pull request #14: SLING-11182 - Correct potential errors introduced by BVP logging
raducotescu commented on a change in pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14#discussion_r822891215
##
File path:
src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java
##
@@ -742,13 +746,20 @@ Bindings verifySlingBindings(final SlingBindings
slingBindings) throws IOExcepti
LOGGER.trace("Invoking addBindings() of {} took {}
nanoseconds",
provider.getClass().getName(), stop-start);
if (stop-start > WARN_LIMIT_FOR_BVP_NANOS) {
-LOGGER.info("Adding the bindings of {} took {}
microseconds which is above the harcoded limit of {} microseconds;"
-+ " if this message appears often it indicates
that this BindingsValuesProvider has an impact on general page rendering
performance",
-new Object[]{provider.getClass().getName(),
(stop-start)/1000, WARN_LIMIT_FOR_BVP_NANOS/1000});
+// SLING-11182 - make this work with older implementations
of the Sling API
+if (request != null && request.getRequestProgressTracker()
!= null) {
+
request.getRequestProgressTracker().log(String.format(BINDINGS_THRESHOLD_MESSAGE,
provider.getClass().getName(), (stop-start)/1000,
WARN_LIMIT_FOR_BVP_NANOS/1000));
Review comment:
I know, but it was a conscious decision - I'd like this logging to be
consistent. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] kwin commented on pull request #56: SLING-9624 rely on Felix defaults for system packages exports
kwin commented on pull request #56: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/56#issuecomment-1063154079 If I don't hear any objections I would merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] stefanseifert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
stefanseifert commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822798054
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
i do not like the approach with "minimum=4" (wherever it is defined) -
this is too subtle and will likely be forgotten if someone adds a 5th content
reader implementation in the future - and then it may produce unreliable
results again when it may happen that one random of the 5 readers is not ready.
it may also be unreliable when there are custom content readers in the system
from other bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822796241
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
I still prefer the fix from
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12/files
as it requires the 4 relevant content readers (not only 4 arbitrary ones).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822784062
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
Can't we make the cardinality minimum the default in the
ContentReaderWhiteboard? This should work via
http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#org.osgi.service.component.annotations.Component.property--
set in
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/7b42e0e0f390e8cd29a9ba235e4e19808f011e7e/src/main/java/org/apache/sling/jcr/contentloader/internal/ContentReaderWhiteboard.java#L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
sonarcloud[bot] commented on pull request #59: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/59#issuecomment-1063051381 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=59=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=59=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=59=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=59=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=59) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=59=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822784062
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
Can't we make the cardinality minimum the default in the
ContentReaderWhiteboard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503662#comment-17503662
]
Julian Sedding commented on SLING-11189:
[~sseifert] in case you had tried my suggestion: sorry, I had gotten the
property name of {{\*.cardinality.minimum}} wrong (edited now in my comment to
avoid misleading anyone).
> Content Loader: Race condition registering readers vs. loading content
> --
>
> Key: SLING-11189
> URL: https://issues.apache.org/jira/browse/SLING-11189
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: JCR ContentLoader 2.5.2
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> in SLING-11168 we detected a specific problem with Composum in Sling Starter
> 12, which only occured on Windows 10 environments (and even there not
> consistently in every scenario).
> it seems that it may happen that Sling-Initial-Content is loaded from the
> bundles when the ContentReader implementations are not yet registered on the
> ContentReaderWhiteboard.
> when this happens, the content is loaded into the repository, but files like
> *.json are not transformed to nodes and properties, but is stored as binary
> json files in the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11168) Sling Starter 12: Unable to launch Composum
[
https://issues.apache.org/jira/browse/SLING-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503659#comment-17503659
]
Julian Sedding commented on SLING-11168:
I created [PR
#59|https://github.com/apache/sling-org-apache-sling-starter/pull/59] with a
trimmed down version of my [suggestion in
SLING-11189|https://issues.apache.org/jira/browse/SLING-11189?focusedCommentId=17502951=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17502951].
I only set the minimum cardinality to 4 instead of also enforcing
"component.name" properties to match the ootb readers. Enforcing the
"component.name" properties would prevent any external {{ContentReader}}
services from binding. That should be "good enough" for now.
> Sling Starter 12: Unable to launch Composum
> ---
>
> Key: SLING-11168
> URL: https://issues.apache.org/jira/browse/SLING-11168
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Starter 12
>
> Attachments: error.log, image-2022-03-01-17-47-08-965.png,
> screenshot-1.png, starter-12-windows.log
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> environment:
> * Windows 10
> * java 11.0.13 2021-10-19 LTS
> * Sling Starter: https://github.com/apache/sling-org-apache-sling-starter
> started sling starter 12 (or actually 13-SNAPSHOT from current master branch)
> with:
> {noformat}
> mvn clean install
> java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> {noformat}
> when trying to access composum via http://localhost:8080/bin/browser.html i
> get the normal sling login (if not logged in already) and login as
> admin/admin.
> directly after this i see a blink of composum, which is replaced immediately
> with another composum login dialog:
> [^image-2022-03-01-17-47-08-965.png]
> [^error.log] from the instance
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822777481
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
I am in favour of a fix which doesn't require additional OSGi
configuration (like
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12) in
order for other distributions to also benefit from it automatically (without
having to configure anything explicitly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822777481
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard":
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4
Review comment:
I am in favour of a fix which doesn't require additional OSGi
configuration (like
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12) in
order for other distributions also benefit from it automatically (without
having to configure anything explicitly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] jsedding opened a new pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum
jsedding opened a new pull request #59: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/59 - set minimum cardinality for contentloader readers to 4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502951#comment-17502951
]
Julian Sedding edited comment on SLING-11189 at 3/9/22, 3:17 PM:
-
Purely with DS and OSGi R7, I think it could be done with a combination of the
{{\*.target}} and the {{\*.cardinality.minimum}} [reference
properties|http://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-reference.properties].
The {{contentReader.target}} reference property would need to OR together a
list of {{component.name}} properties, i.e.
{{{}(|(component.name=org.apache.sling.jcr.contentloader.internal.readers.JsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.OrderedJsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.XmlReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.ZipReader)){}}}.
And the {{contentReader.cardinality.minimum}} property would need to be set to
the number of readers, i.e. 4 in this case.
Unless I am missing something, this should work. WDYT?
was (Author: jsedding):
Purely with DS and OSGi R7, I think it could be done with a combination of the
{{\*.target}} and the {{\*.minimum.cardinality}} [reference
properties|http://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-reference.properties].
The {{contentReader.target}} reference property would need to OR together a
list of {{component.name}} properties, i.e.
{{{}(|(component.name=org.apache.sling.jcr.contentloader.internal.readers.JsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.OrderedJsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.XmlReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.ZipReader)){}}}.
And the {{contentReader.minimum.cardinality}} property would need to be set to
the number of readers, i.e. 4 in this case.
Unless I am missing something, this should work. WDYT?
> Content Loader: Race condition registering readers vs. loading content
> --
>
> Key: SLING-11189
> URL: https://issues.apache.org/jira/browse/SLING-11189
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: JCR ContentLoader 2.5.2
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> in SLING-11168 we detected a specific problem with Composum in Sling Starter
> 12, which only occured on Windows 10 environments (and even there not
> consistently in every scenario).
> it seems that it may happen that Sling-Initial-Content is loaded from the
> bundles when the ContentReader implementations are not yet registered on the
> ContentReaderWhiteboard.
> when this happens, the content is loaded into the repository, but files like
> *.json are not transformed to nodes and properties, but is stored as binary
> json files in the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063020726 > The PR as is fixes the issue (with the hardcoded list). I meant a use case for requiring other content readers! Perhaps, but this PR is not backward compatible. We could fix it quickly, or fix it correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this listener
kwin commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063017110 The PR as is fixes the issue (with the hardcoded list). I meant a use case for requiring other content readers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063013204 > Let us only make it configurable (i.e. more complex) when someone requests it. Currently I also fail to see a use case. The bug this is fixing *is* the use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert edited a comment on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in t
stefanseifert edited a comment on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200 this would probably have been a better design decision initially, but for backward compatibility we have to handle all the existing bundles that expect the built-in providers to be always available. i vote to go with the approach of this PR, but make the list of readers configurable. introducing a new directive for this now makes the always quite complex list of parameters for content loading even more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502951#comment-17502951
]
Julian Sedding edited comment on SLING-11189 at 3/9/22, 3:01 PM:
-
Purely with DS and OSGi R7, I think it could be done with a combination of the
{{\*.target}} and the {{\*.minimum.cardinality}} [reference
properties|http://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-reference.properties].
The {{contentReader.target}} reference property would need to OR together a
list of {{component.name}} properties, i.e.
{{{}(|(component.name=org.apache.sling.jcr.contentloader.internal.readers.JsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.OrderedJsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.XmlReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.ZipReader)){}}}.
And the {{contentReader.minimum.cardinality}} property would need to be set to
the number of readers, i.e. 4 in this case.
Unless I am missing something, this should work. WDYT?
was (Author: jsedding):
Purely with DS and OSGi R7, I think it could be done with a combination of the
{{*.target*}} *and the {{}}*{{.minimum.cardinality}} [reference
properties|http://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-reference.properties].
The {{contentReader.target}} reference property would need to OR together a
list of {{component.name}} properties, i.e.
{{{}(|(component.name=org.apache.sling.jcr.contentloader.internal.readers.JsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.OrderedJsonReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.XmlReader)(component.name=org.apache.sling.jcr.contentloader.internal.readers.ZipReader)){}}}.
And the {{contentReader.minimum.cardinality}} property would need to be set to
the number of readers, i.e. 4 in this case.
Unless I am missing something, this should work. WDYT?
> Content Loader: Race condition registering readers vs. loading content
> --
>
> Key: SLING-11189
> URL: https://issues.apache.org/jira/browse/SLING-11189
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: JCR ContentLoader 2.5.2
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> in SLING-11168 we detected a specific problem with Composum in Sling Starter
> 12, which only occured on Windows 10 environments (and even there not
> consistently in every scenario).
> it seems that it may happen that Sling-Initial-Content is loaded from the
> bundles when the ContentReader implementations are not yet registered on the
> ContentReaderWhiteboard.
> when this happens, the content is loaded into the repository, but files like
> *.json are not transformed to nodes and properties, but is stored as binary
> json files in the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this listener
kwin commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063011209 Let us only make it configurable (i.e. more complex) when someone requests it. Currently I also fail to see a use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063010894 Sorry, I accidentally edited your comment. I'll undo that. I guess what I was hinting at was that the implied behavior when no requireImportProvider directive was provided could be backward compatible. Meaning that if the file extension matches one of the configured "reader" file extensions (and no ignoreImportProvider value conflict), then the "requireImportProvider" value could default to that file extension and processing would be deferred until the expected reader arrived. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert edited a comment on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in t
stefanseifert edited a comment on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200 I guess what I was hinting at was that the implied behavior when no requireImportProvider directive was provided could be backward compatible. Meaning that if the file extension matches one of the configured "reader" file extensions (and no ignoreImportProvider value conflict), then the "requireImportProvider" value could default to that file extension and processing would be deferred until the expected reader arrived. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200 this would probably have been a better design decision initially, but for backward compatibility we have to handle all the existing bundles that expect the built-in providers to be always available. i vote to go with the approach of this PR, but make the list of readers configurable. introducing a new directive for this now makes the always quite complex list of parameters for content loading even more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10921) Converter creates dependencies for extracted content that are wrong when the provider is around in more than one run mode
[ https://issues.apache.org/jira/browse/SLING-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-10921. Resolution: Fixed > Converter creates dependencies for extracted content that are wrong when the > provider is around in more than one run mode > - > > Key: SLING-10921 > URL: https://issues.apache.org/jira/browse/SLING-10921 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter extracts content from bundles it does that again every > time it hits the bundle (assuming it is present in different > locations/runmodes/packages). That is a problem as this way, only the last > location will be added as a dependency to the package - causing it to fail to > install if it was used from one of the other locations. > We should just not generate a dependency, like we do with contain packages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062982927 Perhaps what is really needed here is the inverse of the ignoreImportProvider directive. Perhaps a new declared (or implied when missing?) requireImportProvider directive so the author can dictate how the files are intended to be processed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062978854 making it configurable would have the benefit that it also supports custom content readers, they could be added to the check via configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #4: SLING-10489 : introducing partial startup detector
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1062967546 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL) [50 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list) [85.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062964221 > i currently do not see a use case to disable some of the built-in content readers via OSGi - we already have support to disable readers in the bundle metadata (ignoreImportProviders). I don't think that is your call to make. You can't say for certain what other use cases people may need now or in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062960567 we've discussed this in https://issues.apache.org/jira/browse/SLING-11189 and at least for that ticket decided to keep this fix to the built-in content readers. i currently do not see a use case to disable some of the built-in content readers via OSGi - we already have support to disable readers in the bundle metadata (ignoreImportProviders). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this li
enapps-enorman commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062957455 Shouldn't the required readers be configurable? What if I want other readers to be required or want one of those built in readers to be disabled or not required for some reason? I don't have that requirement at the moment, but this seems to be making assumptions about the intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10489) Ignore partially started, newly joining instances to avoid disturbing discovery (for a while)
[ https://issues.apache.org/jira/browse/SLING-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503598#comment-17503598 ] Stefan Egli commented on SLING-10489: - * started release vote for discovery.commons 1.0.26 and discovery.base 2.0.12 > Ignore partially started, newly joining instances to avoid disturbing > discovery (for a while) > - > > Key: SLING-10489 > URL: https://issues.apache.org/jira/browse/SLING-10489 > Project: Sling > Issue Type: Improvement > Components: Discovery >Affects Versions: Discovery Commons 1.0.24, Discovery Base 2.0.10, > Discovery Oak 1.2.34 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Fix For: Discovery Base 2.0.12, Discovery Commons 1.0.26, > Discovery Oak 1.2.36 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Discovery.oak requires that both Oak and Sling are operating normally in > order to declare victory and announce a new topology. > The startup phase is especially tricky in this regard, since there are > multiple elements that need to get updated (some are in the Oak layer, some > in Sling) : > * lease & clusterNodeId : this is maintained by Oak > * idMap : this is maintained by IdMapService (Sling) > * leaderElectionId : this is maintained by OakViewChecker (Sling) > * syncToken : this is maintained by SyncTokenService (Sling) > Situations have been seen where Oak starts up fine, but higher level (eg > Sling) bundles were not activated within a reasonable amount of time. This > lead to discovery staying in TOPOLOGY_CHANGING state for longer than expected. > There should be a mechanism that ignores (suppresses) newly joining instances > if they start up only partially. However, after a certain timeout this > mechanism should give up. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[VOTE] Release Apache Sling Discovery Commons 1.0.26 and Discovery Base 2.0.12
Hi, We solved 2 issues completely and 1 issue partially in both of these release: https://issues.apache.org/jira/projects/SLING/versions/12350269 https://issues.apache.org/jira/projects/SLING/versions/12350270 The main issue still open is SLING-10489, which will be fixed with upcoming discovery.oak release (which coincidentally, not, is dependent on Discovery Commons 1.0.26) Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2610 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2610 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
RE: [VOTE] Release Apache Sling Event Support 4.3.0
+1 stefan
[jira] [Updated] (SLING-5598) Exclude slow tests by default with assume(sling.slow.tests.enabled)
[
https://issues.apache.org/jira/browse/SLING-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-5598:
---
Fix Version/s: Discovery Commons 1.0.28
Discovery Base 2.0.14
(was: Discovery Base 2.0.12)
(was: Discovery Commons 1.0.26)
> Exclude slow tests by default with assume(sling.slow.tests.enabled)
>
>
> Key: SLING-5598
> URL: https://issues.apache.org/jira/browse/SLING-5598
> Project: Sling
> Issue Type: Task
> Components: Extensions
>Affects Versions: Discovery Impl 1.2.6, Discovery Base 1.1.2, Discovery
> Commons 1.0.10, Discovery Oak 1.2.6
>Reporter: Stefan Egli
>Priority: Major
> Fix For: Discovery Impl 1.2.14, Discovery Oak 1.2.36, Discovery
> Commons 1.0.28, Discovery Base 2.0.14
>
> Attachments: SLING-5598-commons-testing.patch,
> SLING-5598-discovery.patch
>
>
> As suggested by [~bdelacretaz] on [the
> list|http://markmail.org/message/yad5awqg53epk3ck] we should improve test
> duration (ideally 1-2min per bundle max, 10-15min overall). While they are
> not yet improved however, slow tests should be excluded by default and run
> only if enabled explicitly. Here's an example {{@Before}} method to achieve
> that:
> {noformat}
> @Before
> public void checkSlowTests() {
> assumeNotNull(System.getProperty("sling.slow.tests.enabled"));
> }
> {noformat}
> and to enable the slow tests you do: {{mvn -Dsling.slow.tests.enabled=true
> clean test}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
RE: [VOTE] Release Apache Sling Starter Content 1.0.12
+1 stefan
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this l
sonarcloud[bot] commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062914620 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=12=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=12=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=12=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=12=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11168) Sling Starter 12: Unable to launch Composum
[
https://issues.apache.org/jira/browse/SLING-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503585#comment-17503585
]
Stefan Seifert commented on SLING-11168:
updating to JCR ContentLoader 2.5.2 fixes this issue (when the PR for
SLING-11189 is merged)
> Sling Starter 12: Unable to launch Composum
> ---
>
> Key: SLING-11168
> URL: https://issues.apache.org/jira/browse/SLING-11168
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Starter 12
>
> Attachments: error.log, image-2022-03-01-17-47-08-965.png,
> screenshot-1.png, starter-12-windows.log
>
>
> environment:
> * Windows 10
> * java 11.0.13 2021-10-19 LTS
> * Sling Starter: https://github.com/apache/sling-org-apache-sling-starter
> started sling starter 12 (or actually 13-SNAPSHOT from current master branch)
> with:
> {noformat}
> mvn clean install
> java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> {noformat}
> when trying to access composum via http://localhost:8080/bin/browser.html i
> get the normal sling login (if not logged in already) and login as
> admin/admin.
> directly after this i see a blink of composum, which is replaced immediately
> with another composum login dialog:
> [^image-2022-03-01-17-47-08-965.png]
> [^error.log] from the instance
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SLING-11168) Sling Starter 12: Unable to launch Composum
[
https://issues.apache.org/jira/browse/SLING-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert reassigned SLING-11168:
--
Assignee: Stefan Seifert
> Sling Starter 12: Unable to launch Composum
> ---
>
> Key: SLING-11168
> URL: https://issues.apache.org/jira/browse/SLING-11168
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Starter 12
>
> Attachments: error.log, image-2022-03-01-17-47-08-965.png,
> screenshot-1.png, starter-12-windows.log
>
>
> environment:
> * Windows 10
> * java 11.0.13 2021-10-19 LTS
> * Sling Starter: https://github.com/apache/sling-org-apache-sling-starter
> started sling starter 12 (or actually 13-SNAPSHOT from current master branch)
> with:
> {noformat}
> mvn clean install
> java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> {noformat}
> when trying to access composum via http://localhost:8080/bin/browser.html i
> get the normal sling login (if not logged in already) and login as
> admin/admin.
> directly after this i see a blink of composum, which is replaced immediately
> with another composum login dialog:
> [^image-2022-03-01-17-47-08-965.png]
> [^error.log] from the instance
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[ https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11189: --- Fix Version/s: JCR ContentLoader 2.5.2 > Content Loader: Race condition registering readers vs. loading content > -- > > Key: SLING-11189 > URL: https://issues.apache.org/jira/browse/SLING-11189 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: JCR ContentLoader 2.5.2 > > > in SLING-11168 we detected a specific problem with Composum in Sling Starter > 12, which only occured on Windows 10 environments (and even there not > consistently in every scenario). > it seems that it may happen that Sling-Initial-Content is loaded from the > bundles when the ContentReader implementations are not yet registered on the > ContentReaderWhiteboard. > when this happens, the content is loaded into the repository, but files like > *.json are not transformed to nodes and properties, but is stored as binary > json files in the repository. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[ https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503582#comment-17503582 ] Stefan Seifert commented on SLING-11189: i've prepared a PR which actually fixed the problem on my environment: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12 it's using 4 separate defined references for the for content loaders because at least when using the DS annotations it's not possible to define a minimum cardinality of 4 - but the result is the same. > Content Loader: Race condition registering readers vs. loading content > -- > > Key: SLING-11189 > URL: https://issues.apache.org/jira/browse/SLING-11189 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > > in SLING-11168 we detected a specific problem with Composum in Sling Starter > 12, which only occured on Windows 10 environments (and even there not > consistently in every scenario). > it seems that it may happen that Sling-Initial-Content is loaded from the > bundles when the ContentReader implementations are not yet registered on the > ContentReaderWhiteboard. > when this happens, the content is loaded into the repository, but files like > *.json are not transformed to nodes and properties, but is stored as binary > json files in the repository. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-scripting-core] joerghoh commented on pull request #14: SLING-11182 - Correct potential errors introduced by BVP logging
joerghoh commented on pull request #14: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14#issuecomment-1062833322 +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] joerghoh commented on a change in pull request #14: SLING-11182 - Correct potential errors introduced by BVP logging
joerghoh commented on a change in pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14#discussion_r822560148
##
File path:
src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java
##
@@ -742,13 +746,20 @@ Bindings verifySlingBindings(final SlingBindings
slingBindings) throws IOExcepti
LOGGER.trace("Invoking addBindings() of {} took {}
nanoseconds",
provider.getClass().getName(), stop-start);
if (stop-start > WARN_LIMIT_FOR_BVP_NANOS) {
-LOGGER.info("Adding the bindings of {} took {}
microseconds which is above the harcoded limit of {} microseconds;"
-+ " if this message appears often it indicates
that this BindingsValuesProvider has an impact on general page rendering
performance",
-new Object[]{provider.getClass().getName(),
(stop-start)/1000, WARN_LIMIT_FOR_BVP_NANOS/1000});
+// SLING-11182 - make this work with older implementations
of the Sling API
+if (request != null && request.getRequestProgressTracker()
!= null) {
+
request.getRequestProgressTracker().log(String.format(BINDINGS_THRESHOLD_MESSAGE,
provider.getClass().getName(), (stop-start)/1000,
WARN_LIMIT_FOR_BVP_NANOS/1000));
Review comment:
in case a progressTracker is available it just writes the message into
the RPT, but not anymore into the logs (as before).
Technically that would count as regression, but I was never really confident
with this way of reporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (SLING-11191) Update repo-init parser dependency to 1.6.14
[ https://issues.apache.org/jira/browse/SLING-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11191. -- Resolution: Fixed > Update repo-init parser dependency to 1.6.14 > > > Key: SLING-11191 > URL: https://issues.apache.org/jira/browse/SLING-11191 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > [~kpauls], as discussed we also need to update the cp-2-fm-converter to use > the latest repoinit parser 1.6.14. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11191) Update repo-init parser dependency to 1.6.14
[ https://issues.apache.org/jira/browse/SLING-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11191: - Affects Version/s: Content-Package to Feature Model Converter 1.1.10 > Update repo-init parser dependency to 1.6.14 > > > Key: SLING-11191 > URL: https://issues.apache.org/jira/browse/SLING-11191 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > [~kpauls], as discussed we also need to update the cp-2-fm-converter to use > the latest repoinit parser 1.6.14. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #129: SLING-11191 : Update repo-init parser dependency to 1.6.14
anchela merged pull request #129: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] raducotescu commented on pull request #14: SLING-11182 - Correct potential errors introduced by BVP logging
raducotescu commented on pull request #14: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14#issuecomment-1062798590 @karlpauls, @joerghoh, are you ok with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #129: SLING-11191 : Update repo-init parser dependency to 1.6.14
sonarcloud[bot] commented on pull request #129: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/129#issuecomment-1062797810 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=129=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=129=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=129=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=129=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request #129: SLING-11191 : Update repo-init parser dependency to 1.6.14
anchela opened a new pull request #129: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/129 @karlpauls , just in case you want to take a quick look. otherwise i am going to merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11191) Update repo-init parser dependency to 1.6.14
Angela Schreiber created SLING-11191: Summary: Update repo-init parser dependency to 1.6.14 Key: SLING-11191 URL: https://issues.apache.org/jira/browse/SLING-11191 Project: Sling Issue Type: Task Components: Content-Package to Feature Model Converter Reporter: Angela Schreiber Assignee: Angela Schreiber Fix For: Content-Package to Feature Model Converter 1.1.12 [~kpauls], as discussed we also need to update the cp-2-fm-converter to use the latest repoinit parser 1.6.14. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [VOTE] Release Release Apache Sling Content Distribution Core 0.5.0 and Content Distribution Journal 0.1.24
+1 Timothee Le mar. 8 mars 2022 à 16:39, Christian Schneider a écrit : > We solved these issues in this releases: > > https://issues.apache.org/jira/projects/SLING/versions/12351110 > https://issues.apache.org/jira/projects/SLING/versions/12351109 > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachesling-2608/ > https://repository.apache.org/content/repositories/orgapachesling-2609/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh [YOUR REPOSITORY ID] /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.-- > > > > Here is my +1 (non binding) > > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com >
[jira] [Commented] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503462#comment-17503462
]
Sagar Miglani commented on SLING-7969:
--
Thank you [~marett] [~stefanegli]
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Fix For: Discovery Commons 1.0.26
>
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-7969:
--
Fix Version/s: Discovery Commons 1.0.26
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Fix For: Discovery Commons 1.0.26
>
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-7969.
---
Resolution: Fixed
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Fix For: Discovery Commons 1.0.26
>
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503461#comment-17503461
]
Timothee Maret commented on SLING-7969:
---
Thanks for the review [~stefanegli] . I have merged the PR.
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-discovery-commons] tmaret merged pull request #5: SLING-7969 - Memory leak in DiscoveryLiteDescriptor
tmaret merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503436#comment-17503436
]
Stefan Egli commented on SLING-7969:
Indeed, thx [~sagarmiglani] for the analysis! [~marett], the PR looks good, thx!
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [VOTE] Release Release Apache Sling Content Distribution Core 0.5.0 and Content Distribution Journal 0.1.24
+1, Cheers, Stefan On 08.03.22 16:38, Christian Schneider wrote: We solved these issues in this releases: https://issues.apache.org/jira/projects/SLING/versions/12351110 https://issues.apache.org/jira/projects/SLING/versions/12351109 Staging repositories: https://repository.apache.org/content/repositories/orgapachesling-2608/ https://repository.apache.org/content/repositories/orgapachesling-2609/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh [YOUR REPOSITORY ID] /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.-- Here is my +1 (non binding)
Re: [VOTE] Release Apache Sling Event Support 4.3.0
+1, Cheers, Stefan On 07.03.22 15:34, Nicolas Peltier wrote: +1 Le ven. 4 mars 2022 à 16:30, Robert Munteanu a écrit : Hi, We solved 8 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12350505 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2607 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2607 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
