[jira] [Closed] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10858.
--
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _no_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the
> api-regions exports are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10921) Converter creates dependencies for extracted content that are wrong when the provider is around in more than one run mode
[ https://issues.apache.org/jira/browse/SLING-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10921. -- > Converter creates dependencies for extracted content that are wrong when the > provider is around in more than one run mode > - > > Key: SLING-10921 > URL: https://issues.apache.org/jira/browse/SLING-10921 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter extracts content from bundles it does that again every > time it hits the bundle (assuming it is present in different > locations/runmodes/packages). That is a problem as this way, only the last > location will be added as a dependency to the package - causing it to fail to > install if it was used from one of the other locations. > We should just not generate a dependency, like we do with contain packages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10920) Converter doesn't reset the aclManager after first pass and rejects too much after resets
[ https://issues.apache.org/jira/browse/SLING-10920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10920. -- > Converter doesn't reset the aclManager after first pass and rejects too much > after resets > - > > Key: SLING-10920 > URL: https://issues.apache.org/jira/browse/SLING-10920 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The converter doesn't reset the acl manager after the first pass. That makes > it so that the service users are collected and put into the all feature. > Furthermore, if it resets, it is loosing the acls that have matching service > users but that come too later in the contenpackage. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10929) CPConverter - error messages can be obfuscated
[ https://issues.apache.org/jira/browse/SLING-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10929. -- > CPConverter - error messages can be obfuscated > -- > > Key: SLING-10929 > URL: https://issues.apache.org/jira/browse/SLING-10929 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > Currently, when performing a CPConversion, if the customer has wrong code, > sometimes the exception can be very obfuscated. > This gives the customer no chance to fix their error easily: > In this example a xml file is empty: > [ERROR] Unable to convert content-package > [/tmp/packages/???.ui.content-1.28.0-SNAPSHOT.zip, > /tmp/packages/???.ui.apps-1.28.0-SNAPSHOT.zip]: Premature end of file. > We would like a path to be provided in the exception so the customer can take > a look there. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10933) Content package converter should use QUOTE_TICK option when parsing json
[ https://issues.apache.org/jira/browse/SLING-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10933. -- > Content package converter should use QUOTE_TICK option when parsing json > > > Key: SLING-10933 > URL: https://issues.apache.org/jira/browse/SLING-10933 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The converter should use the QUOTE_TICK options when parsing json to force > UTF-8 charset and allow for slightly malformed json files (where quote ticks > are used instead of string quotes). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11152) Use official OSGi Converter Implementation
[ https://issues.apache.org/jira/browse/SLING-11152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11152. -- > Use official OSGi Converter Implementation > -- > > Key: SLING-11152 > URL: https://issues.apache.org/jira/browse/SLING-11152 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content Distribution Journal Core 0.1.24, Feature Model > Converter 1.0.16, Slingstart Maven Plugin 1.9.14, Settings 1.4.2, > Content-Package to Feature Model Converter 1.1.12, Models Implementation > 1.5.2, Feature Model Launcher 1.2.2, Feature Model Analyser 1.6.2, Adapter > 2.2.2, Feature Model 1.3.0, slingfeature-maven-plugin 1.6.2 > > > The Apache Felix implementation of the OSGi Converter has been retired in > favour of the one provided by OSGi. We should update to the latest version -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11058) CPConverter - sling initial content - check illegal xml chars
[ https://issues.apache.org/jira/browse/SLING-11058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11058. -- > CPConverter - sling initial content - check illegal xml chars > - > > Key: SLING-11058 > URL: https://issues.apache.org/jira/browse/SLING-11058 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > We have to make sure that in the case of XML illegal characters being used in > JSON descriptor files for sling initial contrent, such as <, >, " and ', > these do not break the build in the cpconverter. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11059) CPConverter - sling initial content - XSLT support
[ https://issues.apache.org/jira/browse/SLING-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11059. -- > CPConverter - sling initial content - XSLT support > -- > > Key: SLING-11059 > URL: https://issues.apache.org/jira/browse/SLING-11059 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > In the sling initial content specs, XLST is supported: > [https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#using-a-custom-xml-format] > Currently in the CPConverter, this is not supported yet, so we need to > implement this. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10822) Avoid duplicate parsing of configuration pid
[ https://issues.apache.org/jira/browse/SLING-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10822. -- > Avoid duplicate parsing of configuration pid > > > Key: SLING-10822 > URL: https://issues.apache.org/jira/browse/SLING-10822 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > There is some duplicated logic to detect whether a configuration pid is a > factory pid. This can be reduced to a single place -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10823) Pass in repoinit as a single text
[ https://issues.apache.org/jira/browse/SLING-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10823. -- > Pass in repoinit as a single text > - > > Key: SLING-10823 > URL: https://issues.apache.org/jira/browse/SLING-10823 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When an OSGi configuration contains repoinit, each value of the scripts array > is handled separated. However sometimes a whole script is not passed in as a > single value in the array but as an array of strings. > So it is better to first append all values from the string array and handle > them as a single script -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10917) Exclude filters in converted content packages can have a trailing slash
[ https://issues.apache.org/jira/browse/SLING-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10917. -- > Exclude filters in converted content packages can have a trailing slash > --- > > Key: SLING-10917 > URL: https://issues.apache.org/jira/browse/SLING-10917 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The filter excludes we generate can have an extra slash at the end that is > not correct. This is effectively just and off by one in case a content.xml > has been removed and should be excluded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11191) Update repo-init parser dependency to 1.6.14
[ https://issues.apache.org/jira/browse/SLING-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11191. -- > Update repo-init parser dependency to 1.6.14 > > > Key: SLING-11191 > URL: https://issues.apache.org/jira/browse/SLING-11191 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > [~kpauls], as discussed we also need to update the cp-2-fm-converter to use > the latest repoinit parser 1.6.14. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11075) Maven id for bundles that don't have a GAV can end up not being well formed
[ https://issues.apache.org/jira/browse/SLING-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11075. -- > Maven id for bundles that don't have a GAV can end up not being well formed > --- > > Key: SLING-11075 > URL: https://issues.apache.org/jira/browse/SLING-11075 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter finds a bundle, it tries to determine the maven > coordinates for it by looking at the embedded maven info. If there is none, > it tries to guess it from the maven info path. If that fails, it takes the > bsn and derives the info from it. > That works, however, in the case of a bsn, it doesn't strip attributes which > can cause an invalid mvn id in the end (e.g., if the bsn has a > ;singelton:=true) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10770) JcrNamespaceRegistry.registerCnd throws NPE
[
https://issues.apache.org/jira/browse/SLING-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10770.
--
> JcrNamespaceRegistry.registerCnd throws NPE
> ---
>
> Key: SLING-10770
> URL: https://issues.apache.org/jira/browse/SLING-10770
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Niek Raaijmakers
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> [~karlpauls], while trying to fix some sonar findings in the converter I came
> across a warning about a null {{NodeTypeManager}} being passed to
> {{CndImporter.registerNodeTypes}} in the following new method introduced with
> SLING-10243:
> {code}
> public void registerCnd(Reader reader, String systemId) throws
> ParseException, RepositoryException, IOException {
> NodeTypeManager ntManager = null;
> ValueFactory valueFactory = null;
> CndImporter.registerNodeTypes(reader, systemId, ntManager, this,
> valueFactory, false);
> registeredCndSystemIds.add(systemId);
> }
> {code}
> a simple test shows that the method always fails with NPE.
> so, unless i am missing something that code calling this method doesn't work
> at all. according to
> https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=uncovered_conditions=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fvltpkg%2FJcrNamespaceRegistry.java=list
> the method isn't covered with any tests either so that might explain why
> it has not been spotted before.
> what would be the best approach to get this fixed? should we revert changes
> made with SLING-10243? There is most probably no instance of JCR
> {{NodeTypeManager}} available if there is no JCR repository available at the
> stage the converter is being executed and I don't think mocking it at this
> stage is sensible.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-11072) Introduce command line argument for CPConverter to toggle the use of source package type for package type calculation.
[ https://issues.apache.org/jira/browse/SLING-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11072. -- > Introduce command line argument for CPConverter to toggle the use of source > package type for package type calculation. > -- > > Key: SLING-11072 > URL: https://issues.apache.org/jira/browse/SLING-11072 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > We need to introduce a command line argument in the CPConverter. > The toggle should enables us to use the source package type when determining > package types of generated content packages. It should be on by default. > > We can then disable / overrule this by passing in false from the command line. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10931) CPConverter - Sling initial content - json files should be converted to folders with a content xml in any case to avoid conflicts
[ https://issues.apache.org/jira/browse/SLING-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10931. -- > CPConverter - Sling initial content - json files should be converted to > folders with a content xml in any case to avoid conflicts > - > > Key: SLING-10931 > URL: https://issues.apache.org/jira/browse/SLING-10931 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > In case of converting sling initial content containing JSON files over to > xml, currently the cpconverter simply creates a xml file in the same level. > The problem is when there are other files in a directory with the same name > to go along the resourceType. > For example we have: > > * page.json > * page/body.html > * page/footer.html > > The result will be: > * page.xml > * page/body.html > * page/footer.html > > Vault doesn't like this approach so much, resulting in stuff like: > * page.dir > * page.xml > * page/.content.xml (with resourceType nt:folder) > * page/body.html > * page/footer.html > The solution lies in simply redirecting the output to .content.xml in a new > folder: > * page/.content.xml > * page/body.html > * page/footer.html > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10818) Add origin information to repoinit
[ https://issues.apache.org/jira/browse/SLING-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10818. -- > Add origin information to repoinit > -- > > Key: SLING-10818 > URL: https://issues.apache.org/jira/browse/SLING-10818 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > OSGi configurations are converted to repoinit instructions, resulting in a > single long repoinit text - if there is any error in those instructions like > a syntax error, later on it is hard to find the origin of that faulty > repoinit. > The converter could add a comment above every repoinit it appends containing > the origin information (package id and config id) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10859) runmode.mapping file does not contain all needed values
[
https://issues.apache.org/jira/browse/SLING-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10859.
--
> runmode.mapping file does not contain all needed values
> ---
>
> Key: SLING-10859
> URL: https://issues.apache.org/jira/browse/SLING-10859
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the {{runmode.mapping}} file generated by the cpconverter does
> not contain all the required file (feature model) references.
> This can happen when certain filenames that need to be referenced are a
> substring of other file names.
> It centers around this code:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
> Assume that {{properties}} contains an entry
> {{(default)=>my-webapp-all.json}}. Then next a feature file named
> {{all.json}} is processed. As the name of it is a substring of the
> pre-existing value it will not append. In fact it will replace the previous
> value with the new value and as such remove it.
> The logic there should be fixed to not use substrings, but rather compare
> entire names. Possibly a better idea would be to keep a Set
> internally and convert that to a comma-separated list only once the
> Properties are persisted in the {{save(()}} call.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [RESULT][VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12
Time to call the vote on the Content-Package to Feature Model Converter 1.1.12 release. * +1 votes from David Bosschaert, Robert Munteanu, Carsten Ziegeler, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12
+1 regards, Karl On Sun, Mar 13, 2022 at 9:22 AM Carsten Ziegeler wrote: > > +1 > > > Carsten > > Am 10.03.2022 um 22:26 schrieb Karl Pauls: > > I'd like to call the release on the following component: > > > > Content-Package to Feature Model Converter 1.1.12: > > https://issues.apache.org/jira/projects/SLING/versions/12350576 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2613 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2613 /tmp/sling-staging > > > > Please vote to approve these releases: > > > >[ ] +1 Approve the releases > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[GitHub] [sling-org-apache-sling-starter] enapps-enorman commented on a change in pull request #63: SLING-11158 use feature launcher assembly to launch the starter
enapps-enorman commented on a change in pull request #63: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63#discussion_r826182103 ## File path: pom.xml ## @@ -156,14 +156,11 @@ prepare-feature-launcher -get -copy +unpack package - - org.apache.sling:org.apache.sling.feature.launcher:1.1.26 -true + org.apache.sling:org.apache.sling.feature.launcher:1.2.0:tar.gz Review comment: > Why did you remove the `stripVersion` config? Mainly because the stripVersion config doesn't appear to be supported by the unpack goal. That config was for renaming the artifact. The version number you are seeing is the folder name from inside the .tar.gz file that was unpacked. I'll try to use the fileMappers config to rewrite the target path of that folder to achieve the same result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #63: SLING-11158 use feature launcher assembly to launch the starter
sonarcloud[bot] removed a comment on pull request #63: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63#issuecomment-1065990529 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #63: SLING-11158 use feature launcher assembly to launch the starter
sonarcloud[bot] commented on pull request #63: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63#issuecomment-1067184226 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=63=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=63=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=63=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] dulvac merged pull request #29: SLING-11205 Make SlingHttpResponse.getSlingLocation and other get methods resilient to customisations
dulvac merged pull request #29: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later
[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506438#comment-17506438
]
Eric Norman edited comment on SLING-11158 at 3/14/22, 6:43 PM:
---
[~rombert] Thanks for the review. I've made some changes that I think address
your concerns. I also would like to hear any other opinions about if this is
the best path.
I see that the
[readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is
still describing the old single jar technique, so that may need some updates
too based on what is decided here.
Also, I don't have a windows environment handy at the moment, so if anyone can
verify that it works on windows I would appreciate that.
was (Author: enorman):
[~rombert] Thanks for the review. I've made some changes that I think address
your concerns. I also would like to hear any other opinions about if this is
the best path.
I see that the
[readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is
still describing the old single jar technique, so that may need some updates
too based on what is decided here.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later
[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506438#comment-17506438
]
Eric Norman edited comment on SLING-11158 at 3/14/22, 6:39 PM:
---
[~rombert] Thanks for the review. I've made some changes that I think address
your concerns. I also would like to hear any other opinions about if this is
the best path.
I see that the
[readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is
still describing the old single jar technique, so that may need some updates
too based on what is decided here.
was (Author: enorman):
[~rombert] Thanks for the review. I've made some changes that I think address
your concerns. I am would like to hear any other opinions about if this is the
best path.
I see that the
[readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is
still describing the old single jar technique, so that may need some updates
too based on what is decided here.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later
[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506438#comment-17506438
]
Eric Norman commented on SLING-11158:
-
[~rombert] Thanks for the review. I've made some changes that I think address
your concerns. I am would like to hear any other opinions about if this is the
best path.
I see that the
[readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is
still describing the old single jar technique, so that may need some updates
too based on what is decided here.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #29: SLING-11205 Make SlingHttpResponse.getSlingLocation and other get methods resilient to customisations
sonarcloud[bot] commented on pull request #29: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/29#issuecomment-1067115328 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=29=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=29=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=29=new_coverage=list) [14.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=29=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=29=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=29=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] enapps-enorman commented on a change in pull request #63: SLING-11158 use feature launcher assembly to launch the starter
enapps-enorman commented on a change in pull request #63: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63#discussion_r826182103 ## File path: pom.xml ## @@ -156,14 +156,11 @@ prepare-feature-launcher -get -copy +unpack package - - org.apache.sling:org.apache.sling.feature.launcher:1.1.26 -true + org.apache.sling:org.apache.sling.feature.launcher:1.2.0:tar.gz Review comment: > Why did you remove the `stripVersion` config? Mainly because the stripVersion config doesn't appear to be supported by the unpack goal. That config was for renaming the artifact. The version number you are seeing is the folder name from inside the .tar.gz file that was unpacked. I'll try to use the config to rewrite the target path of that folder to achieve the same result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] absarasw commented on pull request #29: SLING-11205 Make SlingHttpResponse.getSlingLocation and other get methods resilient to customisations
absarasw commented on pull request #29: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/29#issuecomment-1067064811 @volteanu , @dulvac Please review the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on a change in pull request #128: SLING-11134 - Extract Oak index definitions and package them as an additional file
rombert commented on a change in pull request #128:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/128#discussion_r826171461
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.sling.feature.cpconverter.handlers;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Optional;
+
+import javax.jcr.RepositoryException;
+
+import org.apache.jackrabbit.util.Text;
+import org.apache.jackrabbit.vault.fs.api.WorkspaceFilter;
+import org.apache.jackrabbit.vault.fs.io.Archive;
+import org.apache.jackrabbit.vault.fs.io.Archive.Entry;
+import org.apache.jackrabbit.vault.fs.io.DocViewParser;
+import org.apache.jackrabbit.vault.fs.io.DocViewParser.XmlParseException;
+import org.apache.jackrabbit.vault.fs.io.DocViewParserHandler;
+import org.apache.jackrabbit.vault.util.DocViewNode2;
+import org.apache.jackrabbit.vault.util.PlatformNameFormat;
+import
org.apache.sling.feature.cpconverter.ContentPackage2FeatureModelConverter;
+import org.apache.sling.feature.cpconverter.ConverterException;
+import org.apache.sling.feature.cpconverter.index.IndexDefinitions;
+import org.apache.sling.feature.cpconverter.index.IndexManager;
+import org.jetbrains.annotations.NotNull;
+import org.xml.sax.InputSource;
+
+/**
+ * Handler for Jackrabbit Oak index definitions
+ *
+ * This implementation scans content packages for entries stored under
/oak:index
+ * and exposes them to the {@link IndexManager} for further processing.
+ *
+ */
+public class IndexDefinitionsEntryHandler extends AbstractRegexEntryHandler {
+
+private final class IndexDefinitionsParserHandler implements
DocViewParserHandler {
+private final WorkspaceFilter filter;
+private IndexDefinitions definitions;
+
+public IndexDefinitionsParserHandler(WorkspaceFilter filter,
IndexDefinitions definitions) {
+this.filter = filter;
+this.definitions = definitions;
+}
+
+@Override
+public void startDocViewNode(@NotNull String nodePath, @NotNull
DocViewNode2 docViewNode,
+@NotNull Optional parentDocViewNode, int line,
int column)
+throws IOException, RepositoryException {
+
+if ( nodePath.startsWith(IndexDefinitions.OAK_INDEX_PATH) &&
filter.contains(nodePath) ) {
Review comment:
Fixed in the latest push, we know support oak index definitions in the
whole repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (SLING-7969) Memory leak in DiscoveryLiteDescriptor
[
https://issues.apache.org/jira/browse/SLING-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli closed SLING-7969.
--
> Memory leak in DiscoveryLiteDescriptor
> --
>
> Key: SLING-7969
> URL: https://issues.apache.org/jira/browse/SLING-7969
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Labels: discovery
> Fix For: Discovery Commons 1.0.26
>
> Attachments: Screenshot 2022-03-07 at 1.05.33 PM.png, Screenshot
> 2022-03-07 at 1.14.57 PM-1.png, Screenshot 2022-03-07 at 1.14.57 PM.png,
> Screenshot 2022-03-07 at 1.18.07 PM.png, Screenshot 2022-03-07 at 1.18.16
> PM.png, Screenshot 2022-03-07 at 12.26.11 PM.png,
> org.apache.sling.commons.johnzon-1.1.11-SLING-7969.jar,
> org.apache.sling.discovery.commons-1.0.23-SLING-7969.jar
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As identified in [~volteanu]'s adaptTo
> [presentation|https://adapt.to/2018/en/schedule/sling-memory-deep-dive.html],
> it seems that Sling Discovery on Oak is consuming 42MB of RAM on a standard
> instance.
> Sling discovery deals with transient states (the views, leases, etc.) and is
> not caching significant amount of data. The 42MB figure for the discovery
> feature seems like a symptom of a memory leak.
> [~volteanu] shared in his presentation that the 42MB worth of RAM was mainly
> consumed by a Json Factory reference. There is one static JsonReaderFactory
> in the discovery commons module, in the
> [DiscoveryLiteDescriptor|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java].
> Looking at the code, it seems that each invocation of the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> method creates a JSON reader but never close it. This may may leave
> resources behind as hinted by the description of the
> [close|https://docs.oracle.com/javaee/7/api/javax/json/JsonReader.html#close--]
> method in the API. AFAIK, the
> [getDescriptorFrom|https://github.com/apache/sling-org-apache-sling-discovery-commons/blob/master/src/main/java/org/apache/sling/discovery/commons/providers/spi/base/DiscoveryLiteDescriptor.java#L51]
> is invoked periodically on a relatively high frequency (< seconds) which may
> be the trigger for the leak on all instances.
> This is only a supposition for now, it should be investigated further, simply
> by running a patched version of \{{org.apache.sling.discovery.commons}} that
> make sure each JSON reader is properly closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10700) Improve TopologyRequestValidator code
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli closed SLING-10700. --- > Improve TopologyRequestValidator code > - > > Key: SLING-10700 > URL: https://issues.apache.org/jira/browse/SLING-10700 > Project: Sling > Issue Type: Improvement > Components: Discovery >Affects Versions: Discovery Base 2.0.10 >Reporter: Artem Smotrakov >Assignee: Stefan Egli >Priority: Major > Labels: security > Fix For: Discovery Base 2.0.12 > > Attachments: TopologyRequestValidator.patch > > Time Spent: 1h > Remaining Estimate: 0h > > (agreed to open a Jira issue after discussing this on secur...@apache.org) > > I noticed several security problems in TopologyRequestValidator > > > [https://github.com/apache/sling-org-apache-sling-discovery-base/blob/df08b0dfa40feaed4f0fd1575d688691a7a0d946/src/main/java/org/apache/sling/discovery/base/connectors/ping/TopologyRequestValidator.java] > > They don't look severe but it may be worth addressing them. > > 1. The class uses String.equals() for validating a MAC. This method doesn't > implement a constant-time algorithm for comparing inputs. As a result, it may > allow an attacker to run a timing attack that can uncover a valid MAC. > Instead, it would be better to use MessageDigest.isEquals() > > > [https://github.com/apache/sling-org-apache-sling-discovery-base/blob/df08b0dfa40feaed4f0fd1575d688691a7a0d946/src/main/java/org/apache/sling/discovery/base/connectors/ping/TopologyRequestValidator.java#L367] > > 2. The method getCipherKey() uses PBKDF2 for generating a key for MAC. NIST > recommends to use a higher iteration count > > [https://pages.nist.gov/800-63-3/sp800-63b.html#sec5] > > Furthermore, it might be better to use SHA-256 (or even better SHA-512). > That would increase the cost of an attack. > > 3. It might be better to close GZIPInputStream in a try-finally block to > avoid unreleased streams in case an exception occurs. Unclosed streams may > help to run a DoS attack. I didn't look into the implementation of > GZIPInputStream though. > > At first I thought the the class uses a static IV for a cipher > > > [https://github.com/apache/sling-org-apache-sling-discovery-base/blob/df08b0dfa40feaed4f0fd1575d688691a7a0d946/src/main/java/org/apache/sling/discovery/base/connectors/ping/TopologyRequestValidator.java#L466] > > but debugging TopologyRequestValidatorTest showed that the IV is actually > random. Well, at least when you use the latest JDK 8. To be on the safer > side, it may be better to set a random IV explicitly. > > I am attaching a draft patch that addresses most of the points above (except > moving to SHA-512 and setting an explicit IV). > > Please feel free to use this patch, or I can open a pull request if it is > fine. You can also create a private branch and a security advisory on GitHub, > then I can open a pull request against that branch. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10489) Ignore partially started, newly joining instances to avoid disturbing discovery (for a while)
[ https://issues.apache.org/jira/browse/SLING-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli closed SLING-10489. --- > Ignore partially started, newly joining instances to avoid disturbing > discovery (for a while) > - > > Key: SLING-10489 > URL: https://issues.apache.org/jira/browse/SLING-10489 > Project: Sling > Issue Type: Improvement > Components: Discovery >Affects Versions: Discovery Commons 1.0.24, Discovery Base 2.0.10, > Discovery Oak 1.2.34 >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Fix For: Discovery Base 2.0.12, Discovery Commons 1.0.26, > Discovery Oak 1.2.36 > > Time Spent: 8h 10m > Remaining Estimate: 0h > > Discovery.oak requires that both Oak and Sling are operating normally in > order to declare victory and announce a new topology. > The startup phase is especially tricky in this regard, since there are > multiple elements that need to get updated (some are in the Oak layer, some > in Sling) : > * lease & clusterNodeId : this is maintained by Oak > * idMap : this is maintained by IdMapService (Sling) > * leaderElectionId : this is maintained by OakViewChecker (Sling) > * syncToken : this is maintained by SyncTokenService (Sling) > Situations have been seen where Oak starts up fine, but higher level (eg > Sling) bundles were not activated within a reasonable amount of time. This > lead to discovery staying in TOPOLOGY_CHANGING state for longer than expected. > There should be a mechanism that ignores (suppresses) newly joining instances > if they start up only partially. However, after a certain timeout this > mechanism should give up. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11205) Make SlingHttpResponse.getSlingLocation resilient to customizations
Abhinav Saraswat created SLING-11205: Summary: Make SlingHttpResponse.getSlingLocation resilient to customizations Key: SLING-11205 URL: https://issues.apache.org/jira/browse/SLING-11205 Project: Sling Issue Type: Improvement Components: Apache Sling Testing Clients Affects Versions: Apache Sling Testing Clients 3.0.12 Reporter: Abhinav Saraswat SlingHttpResponse.getSlingLocation and other get methods should work when the HTML response is customised by adding things like class="" in order to test my customised application. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11205) Make SlingHttpResponse.getSlingLocation resilient to customizations
[ https://issues.apache.org/jira/browse/SLING-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Saraswat updated SLING-11205: - Description: SlingHttpResponse.getSlingLocation and other get methods should work when the HTML response is customised by adding things like class="" in order to test the customised application. (was: SlingHttpResponse.getSlingLocation and other get methods should work when the HTML response is customised by adding things like class="" in order to test my customised application.) > Make SlingHttpResponse.getSlingLocation resilient to customizations > --- > > Key: SLING-11205 > URL: https://issues.apache.org/jira/browse/SLING-11205 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.12 >Reporter: Abhinav Saraswat >Priority: Major > > SlingHttpResponse.getSlingLocation and other get methods should work when the > HTML response is customised by adding things like class="" in order to test > the customised application. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[RESULT][VOTE] Release Apache Sling Discovery Oak 1.2.36
Hi, The vote has passed with the following result : +1 (binding): Timothee Maret, Carsten Ziegeler, myself +1 (non binding): nemmeno I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, Stefan On 14.03.22 16:05, Stefan Egli wrote: Hi, The vote has passed with the following result : +1 (binding): Timothee Maret, Carsten Ziegeler, myself +1 (non binding): nemmeno I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, Stefan On 13.03.22 09:47, Carsten Ziegeler wrote: +1 Carsten Am 10.03.2022 um 19:10 schrieb Stefan Egli: Hi, We solved 1 issue in theis release: https://issues.apache.org/jira/projects/SLING/versions/12350271 Note that this release requires Discovery Commons 1.0.26, which is also currently in release voting. Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2612 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2612 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
Re: [VOTE] Release Apache Sling Discovery Oak 1.2.36
Hi, The vote has passed with the following result : +1 (binding): Timothee Maret, Carsten Ziegeler, myself +1 (non binding): nemmeno I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, Stefan On 13.03.22 09:47, Carsten Ziegeler wrote: +1 Carsten Am 10.03.2022 um 19:10 schrieb Stefan Egli: Hi, We solved 1 issue in theis release: https://issues.apache.org/jira/projects/SLING/versions/12350271 Note that this release requires Discovery Commons 1.0.26, which is also currently in release voting. Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2612 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2612 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
[RESULT][VOTE] Release Apache Sling Discovery Commons 1.0.26 and Discovery Base 2.0.12
Hi, The vote has passed with the following result : +1 (binding): Timothee Maret, Carsten Ziegeler, myself +1 (non binding): nessuno I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, Stefan On 13.03.22 09:48, Carsten Ziegeler wrote: +1 Carsten Am 09.03.2022 um 14:51 schrieb Stefan Egli: Hi, We solved 2 issues completely and 1 issue partially in both of these release: https://issues.apache.org/jira/projects/SLING/versions/12350269 https://issues.apache.org/jira/projects/SLING/versions/12350270 The main issue still open is SLING-10489, which will be fixed with upcoming discovery.oak release (which coincidentally, not, is dependent on Discovery Commons 1.0.26) Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2610 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2610 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers, Stefan
[GitHub] [sling-site] rombert commented on pull request #88: SLING-11204 enable web analytics with ASF Matomo
rombert commented on pull request #88: URL: https://github.com/apache/sling-site/pull/88#issuecomment-1066904060 LGTM on a local test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] rombert commented on pull request #88: SLING-11204 enable web analytics with ASF Matomo
rombert commented on pull request #88: URL: https://github.com/apache/sling-site/pull/88#issuecomment-1066871152 FWIW the build fails locally for me as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] kwin commented on pull request #88: SLING-11204 enable web analytics with ASF Matomo
kwin commented on pull request #88: URL: https://github.com/apache/sling-site/pull/88#issuecomment-1066859920 Unfortunately I cannot try it out locally due to https://github.com/jbake-org/jbake/issues/709. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling Starter 12, Apache Sling JCR ContentLoader 2.5.2, Apache Sling Project Archetype 1.0.8
+1
Re: [Content Loader] Decide on approach to unblock Sling 12
On Mon, 2022-03-14 at 10:46 +, Stefan Seifert wrote: > hello robert. > > as intermediate solution i've merged a) and closed SLING-11189, so > from my point of view we can continue sling 12 release together with > a release of JCR ContentLoader 2.5.2 with the two fixed issues [6]. > the remaining issues from 2.5.2 can be moved to a next version imho. > Sounds good, thanks Stefan! I kicked off a second release vote, hopefully this time it goes smoother :-) Thanks, Robert > stefan > > [6] > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22JCR%20ContentLoader%202.5.2%22 > > > -Original Message- > > From: Robert Munteanu > > Sent: Thursday, March 10, 2022 6:08 PM > > To: dev@sling.apache.org > > Subject: Re: [Content Loader] Decide on approach to unblock Sling > > 12 > > > > Hi Stefan, > > > > Thanks for setting this up, very helpful. > > > > On Thu, 2022-03-10 at 16:33 +, Stefan Seifert wrote: > > > during release process of Sling 12 we discovered SLING-11189 [1] > > > which happens only on certain windows environments, but is there > > > a > > > blocker as Sling-Initial-Content from bundles like composum (may > > > affect other apps as well) are corrupted during extraction, > > > actually > > > breaking the application. the root cause is a race condition on > > > sling > > > startup where the content reader implementations are registered > > > after > > > the whiteboard for handling them is registered, and after the > > > first > > > bundles are actually processed. > > > > > > to solve this we have multiple approaches, i want to do a quick > > > vote > > > on these options to unblock the release: > > > > Any of a-z would actually work for me. I would prefer we don't lose > > the > > benefit of declarative services, if at all possible. > > > > One constraint I would like us to keep is to not log additional > > WARN/ERROR entries, so b) would likely need to be combined with a) > > into > > c), or be adjusted. > > > > FWIW, this is how this is how a similar problem is approached in > > Oak > > [5]. > > > > Thanks, > > Robert > > > > > > a) apply only PR #12 [2] which simply defines a mandatory > > > dependency > > > between the whiteboard and the 4 built-in readers via DS. the > > > list of > > > mandatory readers is hardcoded in the code. > > > > > > b) apply only PR #13 [3] which introduces a new directive > > > "requireImportProviders" allowing bundles to actually define > > > which > > > import providers they depend on, and if those are not there the > > > importing of the initial content is delayed until they become > > > available. if the directive is missing a default list is assumed > > > which is configurable via OSGi (and defaults to the 4 built-in > > > readers). the current implementation has the small drawback that > > > it > > > prints out some error messages in case the bundle processing is > > > delayed, even if it's only for a few milliseconds due to sling > > > startup. > > > > > > c) combine PR #12 [2] and PR #13 [3] to avoid the error messages > > > for > > > the built-in readers. > > > > > > d) look for other solutions, e.g. implementing a) "the other way > > > around" by having the whiteboard register the reader > > > implementations > > > itself, which probably means moving away from DS for those reader > > > service implementations. > > > > > > z) take more time for discussing the options a)-d) and go with > > > workaround from [4] for Sling 12 which fixes this issue via > > > configuration only for Sling Starter, not in the content loader > > > bundle itself. > > > > > > please cast your votes on this options. > > > > > > stefan > > > > > > [1] https://issues.apache.org/jira/browse/SLING-11189 > > > [2] > > > https://github.com/apache/sling-org-apache-sling-jcr- > > contentloader/pull/12 > > > [3] > > > https://github.com/apache/sling-org-apache-sling-jcr- > > contentloader/pull/13 > > > [4] > > > https://github.com/apache/sling-org-apache-sling-starter/pull/59 > > > > [5]: > > https://github.com/apache/jackrabbit-oak/blob/trunk/oak- > > core/src/main/java/org/apache/jackrabbit/oak/security/internal/Secu > > rityProv > > iderRegistration.java
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #976 is BROKEN
---
[INFO] [jenkins-event-spy] Generated
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavenb9c00933/maven-spy-20220314-133732-7139619248327765950052.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/jenkins/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[DevOpticsMavenPublisher] dependencies consumed: 0, artifacts produced: 0
[withMaven] Publishers: CloudBees DevOptics Gate Artifact Publisher: 43099 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext
[VOTE] Release Apache Sling Starter 12, Apache Sling JCR ContentLoader 2.5.2, Apache Sling Project Archetype 1.0.8
Hi, This is the second attempt to release the Starter 12. It includes the Starter itself, the fixed JCR ContentLoader, and the project archetype that builds on top of Sling Starter 12. We fixed 74 issues in these releases https://issues.apache.org/jira/projects/SLING/versions/12351392 https://issues.apache.org/jira/projects/SLING/versions/12344080 https://issues.apache.org/jira/projects/SLING/versions/12350938 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2614 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2614 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Updated] (SLING-10318) Content Loader - Fix merge and overwrite options
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10318:
Fix Version/s: JCR ContentLoader 2.5.4
(was: JCR ContentLoader 2.5.2)
> Content Loader - Fix merge and overwrite options
>
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.5.4
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the behaviour
> differs between JSON and XML Import and also from the Javadoc
> the differences between {{overwrite}} and {{merge}} are not really clear
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates
> this will replace all old content (nodes and properties or only nodes).
> Usually when you refer to a merge you also keep some part of the existing
> content. It seems that {{merge}} should rather be named something like
> {{replace}}. WDYT?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11112) Regression in content loader : Diffent behaviour when initial content is missing
[ https://issues.apache.org/jira/browse/SLING-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-2: Fix Version/s: JCR ContentLoader 2.5.4 (was: JCR ContentLoader 2.5.2) > Regression in content loader : Diffent behaviour when initial content is > missing > > > Key: SLING-2 > URL: https://issues.apache.org/jira/browse/SLING-2 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: JCR ContentLoader 2.5.4 > > > With a bundle that does not have SLING-INF and the following initial content > instruction: > SLING-INF/content;path:=/libs/foo/bar;overwrite:=true; > it seems that prior versions handled this case differently and did not touch > /libs/foo/bar while the new behaviour removes all child nodes of /libs/foo/bar -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11168) Sling Starter 12: Unable to launch Composum
[
https://issues.apache.org/jira/browse/SLING-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11168.
-
Resolution: Fixed
Fixed for the Starter 12 release by including the under-vote JCR ContentLoader
2.5.2 bundle.
> Sling Starter 12: Unable to launch Composum
> ---
>
> Key: SLING-11168
> URL: https://issues.apache.org/jira/browse/SLING-11168
> Project: Sling
> Issue Type: Bug
> Components: Starter
>Affects Versions: Starter 12
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Starter 12
>
> Attachments: error.log, image-2022-03-01-17-47-08-965.png,
> screenshot-1.png, starter-12-windows.log
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> environment:
> * Windows 10
> * java 11.0.13 2021-10-19 LTS
> * Sling Starter: https://github.com/apache/sling-org-apache-sling-starter
> started sling starter 12 (or actually 13-SNAPSHOT from current master branch)
> with:
> {noformat}
> mvn clean install
> java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> {noformat}
> when trying to access composum via http://localhost:8080/bin/browser.html i
> get the normal sling login (if not logged in already) and login as
> admin/admin.
> directly after this i see a blink of composum, which is replaced immediately
> with another composum login dialog:
> [^image-2022-03-01-17-47-08-965.png]
> [^error.log] from the instance
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10865) Improve resource resolution mappings in the project archetype
[
https://issues.apache.org/jira/browse/SLING-10865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10865:
Fix Version/s: Project Archetype 1.0.10
(was: Project Archetype 1.0.8)
> Improve resource resolution mappings in the project archetype
> -
>
> Key: SLING-10865
> URL: https://issues.apache.org/jira/browse/SLING-10865
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Project Archetype 1.0.10
>
>
> We should:
> - enable the {{localhost_any}} entry in the filter.xml by default and give it
> a different name to prevent clashes
> - add a second (nested) entry under /etc/map/http/localhost_any to showcase
> how this could work
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #235 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/235/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Updated] (SLING-10605) Add a custom login page to the generated project
[ https://issues.apache.org/jira/browse/SLING-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10605: Fix Version/s: Project Archetype 1.0.10 (was: Project Archetype 1.0.8) > Add a custom login page to the generated project > > > Key: SLING-10605 > URL: https://issues.apache.org/jira/browse/SLING-10605 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Priority: Major > Fix For: Project Archetype 1.0.10 > > > The default o.a.s.auth.form page references resources from the > o.a.s.starter.content module and it does not look nice if that bundle is not > deployed ( missing CSS, images ). > We should add a custom login form for this module, taking advantage of the > improvements from SLING-10604. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #232 is BROKEN
AVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven73a50e2a/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven73a50e2a"
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_291, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-291/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-112-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven73a50e2a/maven-spy-20220314-130451-3795610809804024413041.log.tmp
...
[INFO] Scanning for projects...
[INFO]
[INFO] -< org.apache.sling:org.apache.sling.starter >--
[INFO] Building Apache Sling Starter Application 13-SNAPSHOT
[INFO] [ jar ]-
[INFO] Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.scr/2.2.0/org.apache.felix.scr-2.2.0.pom
[INFO] Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.scr/2.2.0/org.apache.felix.scr-2.2.0.pom
(15 kB at 45 kB/s)
[INFO] Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.contentloader/2.5.2/org.apache.sling.jcr.contentloader-2.5.2.pom
[WARNING] The POM for
org.apache.sling:org.apache.sling.jcr.contentloader:jar:2.5.2 is missing, no
dependency information available
[INFO] Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.scr/2.2.0/org.apache.felix.scr-2.2.0.jar
[INFO] Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.contentloader/2.5.2/org.apache.sling.jcr.contentloader-2.5.2.jar
[INFO] Downloaded from central:
https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.scr/2.2.0/org.apache.felix.scr-2.2.0.jar
(411 kB at 3.3 MB/s)
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 11.350 s
[INFO] Finished at: 2022-03-14T13:05:02Z
[INFO] ----
[INFO] [jenkins-event-spy] Generated
/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven73a50e2a/maven-spy-20220314-130451-3795610809804024413041.log
[ERROR] Failed to execute goal on project org.apache.sling.starter: Could not
resolve dependencies for project
org.apache.sling:org.apache.sling.starter:jar:13-SNAPSHOT: Could not find
artifact org.apache.sling:org.apache.sling.jcr.contentloader:jar:2.5.2 in
central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[Pipeline] }
[withMaven] Jenkins Task Scanner Plugin not found, don't display results of
source code scanning for 'TODO' and 'FIXME' in pipeline screen.
[DevOpticsMavenPublisher] dependencies consumed: 0, artifacts produced: 0
[withMaven] Publishers: Generated Artifacts Publisher: 907 ms, Open Task
Scanner Publisher: 1 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext
[jira] [Resolved] (SLING-11188) Update Sling Launchpad integration test dependencies to 12
[
https://issues.apache.org/jira/browse/SLING-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-11188.
--
Resolution: Done
> Update Sling Launchpad integration test dependencies to 12
> --
>
> Key: SLING-11188
> URL: https://issues.apache.org/jira/browse/SLING-11188
> Project: Sling
> Issue Type: Task
> Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12
>
>
> * {{org.apache.sling.launchpad.integration-tests}}
> * {{org.apache.sling.launchpad.test-services}}
> * {{org.apache.sling.launchpad.test-fragment}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: Site ID for Apache Sling
Hi Konrad,
Thanks for reaching out. Happy to help. I've created Apache Sling in
Matomo. The tracking code you'll need to implement (it's recommend to place
the code just before the tag) is as follows:
var _paq = window._paq = window._paq || [];
/* tracker methods like "setCustomDimension" should be called before
"trackPageView" */
/* We explicitly disable cookie tracking to avoid privacy issues */
_paq.push(['disableCookies']);
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
(function() {
var u="https://matomo.privacy.apache.org/";;
_paq.push(['setTrackerUrl', u+'matomo.php']);
_paq.push(['setSiteId', '6']);
var d=document, g=d.createElement('script'),
s=d.getElementsByTagName('script')[0];
g.async=true; g.src=u+'matomo.js'; s.parentNode.insertBefore(g,s);
})();
You can access the user interface and your results at
https://matomo.privacy.apache.org/
If you need any help with the implementation, feel free to reach out.
Best regards,
Martijn Visser
https://twitter.com/MartijnVisser82
On Mon, 14 Mar 2022 at 11:55, Konrad Windszus wrote:
> Hi,
> I would like to request a Matomo Site ID for Apache Sling.
>
> Thanks in advance,
> Konrad (on behalf of the Apache Sling PMC)
>
> -
> To unsubscribe, e-mail: privacy-unsubscr...@apache.org
> For additional commands, e-mail: privacy-h...@apache.org
>
>
[jira] [Comment Edited] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506186#comment-17506186
]
Oliver Lietz edited comment on SLING-11147 at 3/14/22, 11:51 AM:
-
-There seems to be any issue on CI, works locally as expected with Java 8 and
Java 17 (ci/non-ci build).- Build fixed by using {{activeByDefault}} for
profile {{non-ci}}.
was (Author: olli):
There seems to be any issue on CI, works locally as expected with Java 8 and
Java 17 (ci/non-ci build).
> Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
> ---
>
> Key: SLING-11147
> URL: https://issues.apache.org/jira/browse/SLING-11147
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * building with JDK 11 and 17 (JDK 8 does not support JPMS)
> * opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT
> Failsafe, keeping issue title to match commit)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506186#comment-17506186
]
Oliver Lietz commented on SLING-11147:
--
There seems to be any issue on CI, works locally as expected with Java 8 and
Java 17 (ci/non-ci build).
> Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
> ---
>
> Key: SLING-11147
> URL: https://issues.apache.org/jira/browse/SLING-11147
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * building with JDK 11 and 17 (JDK 8 does not support JPMS)
> * opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT
> Failsafe, keeping issue title to match commit)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10074) Add integration tests to verify the various error output formats
[ https://issues.apache.org/jira/browse/SLING-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10074. --- > Add integration tests to verify the various error output formats > > > Key: SLING-10074 > URL: https://issues.apache.org/jira/browse/SLING-10074 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Launchpad Integration Tests 12 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506177#comment-17506177
]
Oliver Lietz commented on SLING-11147:
--
Thanks, [~kwin]. I have moved toolchains to profile {{{}ci{}}}. A single Java
version (minimal 9) is used in non-ci/local builds which will be enforced
({{{}minimalJavaBuildVersion{}}}).
> Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
> ---
>
> Key: SLING-11147
> URL: https://issues.apache.org/jira/browse/SLING-11147
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * building with JDK 11 and 17 (JDK 8 does not support JPMS)
> * opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT
> Failsafe, keeping issue title to match commit)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10443) Remove duplicate tests from org-apache-sling-launchpad-integration-tests
[ https://issues.apache.org/jira/browse/SLING-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10443. --- > Remove duplicate tests from org-apache-sling-launchpad-integration-tests > > > Key: SLING-10443 > URL: https://issues.apache.org/jira/browse/SLING-10443 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Launchpad Integration Tests 12 > > > After the next o.a.sling.jcr.jackrabbit.accessmanager bundle is released and > integrated into the starter, the now duplicate tests should be removed from: > org-apache-sling-launchpad-integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/accessManager/* -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10075) Add integration tests to verify the various error output formats
[ https://issues.apache.org/jira/browse/SLING-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10075. --- > Add integration tests to verify the various error output formats > > > Key: SLING-10075 > URL: https://issues.apache.org/jira/browse/SLING-10075 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Launchpad Integration Tests 12 > > > PostSendErrorTest#testNotSuccessfulWithJsonResponseAndSendError is commented > out until the new servlets resolver that contains the fix is released and the > starter is updated to use that new release. > Uncomment that code and verify to resolve this subtask. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10366) Adjust HTTP status codes for SlingPostServlet integration tests
[
https://issues.apache.org/jira/browse/SLING-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-10366.
---
> Adjust HTTP status codes for SlingPostServlet integration tests
> ---
>
> Key: SLING-10366
> URL: https://issues.apache.org/jira/browse/SLING-10366
> Project: Sling
> Issue Type: Task
> Components: Karaf, Servlets, Starter, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Launchpad Integration Tests 12
>
>
> Failures caused by {{org.apache.sling.servlets.post}} {{2.4.3-SNAPSHOT}}:
> {noformat}
> [ERROR] Failures:
> [ERROR]
> PostServletAtCopyTest.testCopyAncestor:232->HttpTestBase.assertPostStatus:412
> Expecting status 500 expected:<500> but was:<409>
> [ERROR]
> PostServletCopyTest.testCopyAncestor:619->HttpTestBase.assertPostStatus:412
> Expecting status 500 expected:<500> but was:<409>
> [ERROR]
> PostServletCreateTest.testCreateNodeWithInvalidExactName:196->HttpTestBase.assertPostStatus:410
> expected:<500> but was:<409>
> [ERROR]
> PostServletCreateTest.testCreatingNodeUnderFile:255->HttpTestBase.assertPostStatus:412
> Response to creating a child under nt:file should fail. expected:<500> but
> was:<409>
> [ERROR]
> PostServletImportTest.testImportAutoCheckoutNodes:326->HttpTestBase.assertPostStatus:412
> Expected error from VersionException expected:<500> but was:<409>
> [ERROR]
> PostServletImportTest.testImportNodeWithInvalidExactName:765->HttpTestBase.assertPostStatus:410
> expected:<500> but was:<409>
> [INFO]
> [ERROR] Tests run: 665, Failures: 6, Errors: 0, Skipped: 1
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-9549) Pin dependencies in o.a.s.launchpad.integration-tests
[ https://issues.apache.org/jira/browse/SLING-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9549. -- > Pin dependencies in o.a.s.launchpad.integration-tests > - > > Key: SLING-9549 > URL: https://issues.apache.org/jira/browse/SLING-9549 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Integration Tests 12 > > > The current integration-tests module contains a mixture of dependencies that > are conflicting. Maven resolves them mostly fine, but fails with: > - jackrabbit versions > - httpclient 4.x versions > This has no impact when running with a classpath that is enriched via the > provisioning model, but fails running with the feature model. > The key dependencies should be pinned instead. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10444) Remove duplicate tests from org-apache-sling-launchpad-integration-tests
[ https://issues.apache.org/jira/browse/SLING-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10444. --- > Remove duplicate tests from org-apache-sling-launchpad-integration-tests > > > Key: SLING-10444 > URL: https://issues.apache.org/jira/browse/SLING-10444 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: Launchpad Integration Tests 12 > > > After the next o.a.sling.jcr.jackrabbit.usermanager bundle is released and > integrated into the starter, the now duplicate tests should be removed from: > org-apache-sling-launchpad-integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/userManager/* -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10073) ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet fails after SLING-10006
[
https://issues.apache.org/jira/browse/SLING-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-10073.
---
> ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet fails
> after SLING-10006
>
>
> Key: SLING-10073
> URL: https://issues.apache.org/jira/browse/SLING-10073
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets POST 2.4.2
>Reporter: Robert Munteanu
>Assignee: Eric Norman
>Priority: Critical
> Fix For: Launchpad Integration Tests 12
>
>
> After SLING-10006 the Sling ITs fail with
> {noformat}[ERROR] Failures:
> [ERROR]
> ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet:177->assertWithRetries:97->RenderingTestBase.assertContains:36
> Content does not contain 'Exception thrown - custom error page' (content=
>
>
>
>
> 500 Internal Server Error
>
>
> Internal Server Error (500) - custom error page
>
> ){noformat}
> Looks like the error handling behaviour has changed in an incompatible manner.
> To reproduce, update to the latest servlets.post in the Sling Starter:
> {code}
> diff --git a/src/main/features/base.json b/src/main/features/base.json
> index 754bf13..f2eb6cf 100644
> --- a/src/main/features/base.json
> +++ b/src/main/features/base.json
> @@ -110,7 +110,7 @@
> "start-order":"20"
> },
> {
> -"id":"org.apache.sling:org.apache.sling.servlets.post:2.3.36",
> +"id":"org.apache.sling:org.apache.sling.servlets.post:2.4.2",
> "start-order":"20"
> },
> {
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-9548) Remove support for o.a.s.jcr.jackrabbit.server from o.a.s.launchpad-test-services
[ https://issues.apache.org/jira/browse/SLING-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9548. -- > Remove support for o.a.s.jcr.jackrabbit.server from > o.a.s.launchpad-test-services > - > > Key: SLING-9548 > URL: https://issues.apache.org/jira/browse/SLING-9548 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Test Services 12 > > > The test services have not been used in the plain Jackrabbit context since we > migrated to Oak. Since the test services are also used as dependencies to > test projects, this messes up the classpath. The effect is visible when > switching to the feature model, as the dependencies from the feature model > files are no longer automatically imported to the current project. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10911) Update to Parent 46
[ https://issues.apache.org/jira/browse/SLING-10911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10911. --- > Update to Parent 46 > --- > > Key: SLING-10911 > URL: https://issues.apache.org/jira/browse/SLING-10911 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: Launchpad Test Services 12 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Update to the latest parent so the module can be built with java 11 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10910) Make the Sling Launchpad Test Services compatible with API 2.24.0
[
https://issues.apache.org/jira/browse/SLING-10910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-10910.
---
> Make the Sling Launchpad Test Services compatible with API 2.24.0
> -
>
> Key: SLING-10910
> URL: https://issues.apache.org/jira/browse/SLING-10910
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Launchpad Test Services 12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SLING-7975 increased the API version for {{o.a.s.api.resource}} to 2.13.0.
> Since the o.a.s.launchpad.test-services bundle implements an interface from
> that package, the module has to be recompiled so that it can work with
> version 2.24.0.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11161) Support testing with different JDKs
[
https://issues.apache.org/jira/browse/SLING-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-11161:
-
Description:
-WIP:-
[https://github.com/apache/sling-org-apache-sling-commons-threads/tree/SLING-11161]
Using
[toolchains|https://maven.apache.org/guides/mini/guide-using-toolchains.html]
in profile {{ci}} to support Java 8, 11 and 17 in tests with Surefire.
See comments in SLING-11147.
was:
-WIP:-
https://github.com/apache/sling-org-apache-sling-commons-threads/tree/SLING-11161
See comments in SLING-11147.
> Support testing with different JDKs
> ---
>
> Key: SLING-11161
> URL: https://issues.apache.org/jira/browse/SLING-11161
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
> Attachments: effective-pom.txt, toolchains.xml
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> -WIP:-
> [https://github.com/apache/sling-org-apache-sling-commons-threads/tree/SLING-11161]
> Using
> [toolchains|https://maven.apache.org/guides/mini/guide-using-toolchains.html]
> in profile {{ci}} to support Java 8, 11 and 17 in tests with Surefire.
> See comments in SLING-11147.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-9596) Switch launchpad-testing to the feature model
[ https://issues.apache.org/jira/browse/SLING-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9596. -- > Switch launchpad-testing to the feature model > - > > Key: SLING-9596 > URL: https://issues.apache.org/jira/browse/SLING-9596 > Project: Sling > Issue Type: Sub-task > Components: Launchpad, Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Testing 12 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch launchpad testing to provisioning model: > - provisioning files switched to feature files > - run against the starter using feature model -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9830) Fix stale debugging instructions in launchpad-testing module
[ https://issues.apache.org/jira/browse/SLING-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9830. -- > Fix stale debugging instructions in launchpad-testing module > > > Key: SLING-9830 > URL: https://issues.apache.org/jira/browse/SLING-9830 > Project: Sling > Issue Type: Task > Components: Launchpad, Testing >Affects Versions: Launchpad Testing 11 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Launchpad Testing 12 > > > The README's tests debugging instructions need to be adapted now that the > tests are started with the feature launcher plugin. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11052) Increase starter timeout during integration tests
[ https://issues.apache.org/jira/browse/SLING-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11052. --- > Increase starter timeout during integration tests > - > > Key: SLING-11052 > URL: https://issues.apache.org/jira/browse/SLING-11052 > Project: Sling > Issue Type: Task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12, Launchpad Testing 12 > > Time Spent: 50m > Remaining Estimate: 0h > > We see that the Sling Starter ITs sporadically fail on Jenkins because the > instance fails to start in 30 seconds. We should increase the default timeout > to increase the chances of success. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11013) Upgrade launchpad-testing to logback 1.2.8
[ https://issues.apache.org/jira/browse/SLING-11013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-11013. --- > Upgrade launchpad-testing to logback 1.2.8 > -- > > Key: SLING-11013 > URL: https://issues.apache.org/jira/browse/SLING-11013 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Testing 12 > > Time Spent: 10m > Remaining Estimate: 0h > > We should upgrade to a more recent version of this library. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9499) Launchpad-Testing: branch which runs ITs against oak_tar feature model aggregate
[ https://issues.apache.org/jira/browse/SLING-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9499. -- > Launchpad-Testing: branch which runs ITs against oak_tar feature model > aggregate > > > Key: SLING-9499 > URL: https://issues.apache.org/jira/browse/SLING-9499 > Project: Sling > Issue Type: Sub-task > Components: Starter, Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Testing 12 > > > Create branch running ITs against the oak_tar aggregate created in the > previous step -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10830) Run Sling ITs with Java 17 as well
[
https://issues.apache.org/jira/browse/SLING-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu closed SLING-10830.
---
> Run Sling ITs with Java 17 as well
> --
>
> Key: SLING-10830
> URL: https://issues.apache.org/jira/browse/SLING-10830
> Project: Sling
> Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Launchpad Testing 12
>
> Attachments: failsafe-java17.zip
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> New test failures compared to Java 11:
> {noformat}[ERROR] Tests run: 566, Failures: 16, Errors: 0, Skipped:
> 1{noformat}
> As far as I can tell, we have problems with:
> - ESP scripts
> - Indexing
> - JAXB
> See issues blocking SLING-10827 for a full list.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[RESULT] [VOTE] Release Apache Sling Starter 12 testing modules
Hi, The vote has passed with the following result : +1 (binding): Robert Munteanu, Stefan Egli, Stefan Seifert. I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.
Site ID for Apache Sling
Hi, I would like to request a Matomo Site ID for Apache Sling. Thanks in advance, Konrad (on behalf of the Apache Sling PMC)
[jira] [Updated] (SLING-11204) Enable Matomo Web Analytics
[ https://issues.apache.org/jira/browse/SLING-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11204: Description: As discussed in https://lists.apache.org/thread/5g5n1xlbo5kxncm0n9jhch5k6nv9r449 enabling ASF Matomo would be beneficial to gain more insights on our website users. (was: As discussed in https://lists.apache.org/thread/1t7tbb94yzbswxtfjqnkbfohorr5mfh4 enabling ASF Matomo would be beneficial to gain more insights on our website users.) > Enable Matomo Web Analytics > --- > > Key: SLING-11204 > URL: https://issues.apache.org/jira/browse/SLING-11204 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > As discussed in > https://lists.apache.org/thread/5g5n1xlbo5kxncm0n9jhch5k6nv9r449 enabling ASF > Matomo would be beneficial to gain more insights on our website users. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Moved] (SLING-11204) Enable Matomo Web Analytics
[ https://issues.apache.org/jira/browse/SLING-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus moved JCRVLT-613 to SLING-11204: Key: SLING-11204 (was: JCRVLT-613) Workflow: no-reopen-closed,doc-test-required (was: no-reopen-closed, patch-avail) Project: Sling (was: Jackrabbit FileVault) > Enable Matomo Web Analytics > --- > > Key: SLING-11204 > URL: https://issues.apache.org/jira/browse/SLING-11204 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > As discussed in > https://lists.apache.org/thread/1t7tbb94yzbswxtfjqnkbfohorr5mfh4 enabling ASF > Matomo would be beneficial to gain more insights on our website users. -- This message was sent by Atlassian Jira (v8.20.1#820001)
RE: [VOTE] Release Apache Sling Starter 12 testing modules ( was: [VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype 1.0.6 and associated testing modules)
+1 >-Original Message- >From: Robert Munteanu >Sent: Thursday, March 10, 2022 3:16 PM >To: dev@sling.apache.org >Subject: [VOTE] Release Apache Sling Starter 12 testing modules ( was: >[VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype >1.0.6 and associated testing modules) > >Hi, > >I have amended the staging repository to drop the >org.apache.sling.starter and sling-project-archetype artifacts. > >The vote will continue with only the testing artifacts included. > >The repository and check instructions remain the same, see below. > >Thanks, >Robert
RE: [Content Loader] Decide on approach to unblock Sling 12
hello robert. as intermediate solution i've merged a) and closed SLING-11189, so from my point of view we can continue sling 12 release together with a release of JCR ContentLoader 2.5.2 with the two fixed issues [6]. the remaining issues from 2.5.2 can be moved to a next version imho. stefan [6] https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22JCR%20ContentLoader%202.5.2%22 >-Original Message- >From: Robert Munteanu >Sent: Thursday, March 10, 2022 6:08 PM >To: dev@sling.apache.org >Subject: Re: [Content Loader] Decide on approach to unblock Sling 12 > >Hi Stefan, > >Thanks for setting this up, very helpful. > >On Thu, 2022-03-10 at 16:33 +, Stefan Seifert wrote: >> during release process of Sling 12 we discovered SLING-11189 [1] >> which happens only on certain windows environments, but is there a >> blocker as Sling-Initial-Content from bundles like composum (may >> affect other apps as well) are corrupted during extraction, actually >> breaking the application. the root cause is a race condition on sling >> startup where the content reader implementations are registered after >> the whiteboard for handling them is registered, and after the first >> bundles are actually processed. >> >> to solve this we have multiple approaches, i want to do a quick vote >> on these options to unblock the release: > >Any of a-z would actually work for me. I would prefer we don't lose the >benefit of declarative services, if at all possible. > >One constraint I would like us to keep is to not log additional >WARN/ERROR entries, so b) would likely need to be combined with a) into >c), or be adjusted. > >FWIW, this is how this is how a similar problem is approached in Oak >[5]. > >Thanks, >Robert >> >> a) apply only PR #12 [2] which simply defines a mandatory dependency >> between the whiteboard and the 4 built-in readers via DS. the list of >> mandatory readers is hardcoded in the code. >> >> b) apply only PR #13 [3] which introduces a new directive >> "requireImportProviders" allowing bundles to actually define which >> import providers they depend on, and if those are not there the >> importing of the initial content is delayed until they become >> available. if the directive is missing a default list is assumed >> which is configurable via OSGi (and defaults to the 4 built-in >> readers). the current implementation has the small drawback that it >> prints out some error messages in case the bundle processing is >> delayed, even if it's only for a few milliseconds due to sling >> startup. >> >> c) combine PR #12 [2] and PR #13 [3] to avoid the error messages for >> the built-in readers. >> >> d) look for other solutions, e.g. implementing a) "the other way >> around" by having the whiteboard register the reader implementations >> itself, which probably means moving away from DS for those reader >> service implementations. >> >> z) take more time for discussing the options a)-d) and go with >> workaround from [4] for Sling 12 which fixes this issue via >> configuration only for Sling Starter, not in the content loader >> bundle itself. >> >> please cast your votes on this options. >> >> stefan >> >> [1] https://issues.apache.org/jira/browse/SLING-11189 >> [2] >> https://github.com/apache/sling-org-apache-sling-jcr- >contentloader/pull/12 >> [3] >> https://github.com/apache/sling-org-apache-sling-jcr- >contentloader/pull/13 >> [4] https://github.com/apache/sling-org-apache-sling-starter/pull/59 > >[5]: >https://github.com/apache/jackrabbit-oak/blob/trunk/oak- >core/src/main/java/org/apache/jackrabbit/oak/security/internal/SecurityProv >iderRegistration.java
[jira] [Resolved] (SLING-11194) Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lock node at /var/sling/bundle-content
[
https://issues.apache.org/jira/browse/SLING-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-11194.
Fix Version/s: JCR ContentLoader 2.5.2
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/49cbcfba3b8873fe08e32202921fc2964fd75ac7
> Content Loader: Add log message if Sling-Initial-Content is not processed due
> to stale lock node at /var/sling/bundle-content
> -
>
> Key: SLING-11194
> URL: https://issues.apache.org/jira/browse/SLING-11194
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: JCR ContentLoader 2.5.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> we had one occurrence of a very difficult to debug issue that on only one out
> of many instances a given bundle with Sling-Initial-Content was not processed
> properly when the bundle was registered by ContentLoader without any
> indication about the reason in the log files, even at DEBUG level.
> only the message {{Registering bundle XYZ for content loading.}} was logged
> but nothing more, the Sling-Initial-Content was completely ignored.
> we found out that the root cause was a stale "locking node" at
> {{/var/sling/bundle-content/XYZ}} which was probably left there after and
> unexpected instance shutdown or other failure. the problem was solved by
> deleting this locking node, but the error log did not help. we should add
> some more DEBUG log messages in this error to help diagnosing rare problems
> like this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert merged pull request #14: SLING-11194 Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lock node
stefanseifert merged pull request #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[ https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11189. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/bc3f2d747c6083446233e6d4183896adf40f2dac > Content Loader: Race condition registering readers vs. loading content > -- > > Key: SLING-11189 > URL: https://issues.apache.org/jira/browse/SLING-11189 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: JCR ContentLoader 2.5.2 > > Time Spent: 6h 50m > Remaining Estimate: 0h > > in SLING-11168 we detected a specific problem with Composum in Sling Starter > 12, which only occured on Windows 10 environments (and even there not > consistently in every scenario). > it seems that it may happen that Sling-Initial-Content is loaded from the > bundles when the ContentReader implementations are not yet registered on the > ContentReaderWhiteboard. > when this happens, the content is loaded into the repository, but files like > *.json are not transformed to nodes and properties, but is stored as binary > json files in the repository. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis
stefanseifert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1066617287 merging this PR as quick solution for Sling 12 release. discussion about more sustainable solution will continue in https://issues.apache.org/jira/browse/SLING-11203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert merged pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this listener
stefanseifert merged pull request #12: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content
[ https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506137#comment-17506137 ] Stefan Seifert commented on SLING-11189: as in the mailing list thread there was a slight tendency towards the simple fix from https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12 we will merge this PR to unblock the Sling 12 release, and can continue the discussion about a more sustainable solution in SLING-11203. > Content Loader: Race condition registering readers vs. loading content > -- > > Key: SLING-11189 > URL: https://issues.apache.org/jira/browse/SLING-11189 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: JCR ContentLoader 2.5.2 > > Time Spent: 6.5h > Remaining Estimate: 0h > > in SLING-11168 we detected a specific problem with Composum in Sling Starter > 12, which only occured on Windows 10 environments (and even there not > consistently in every scenario). > it seems that it may happen that Sling-Initial-Content is loaded from the > bundles when the ContentReader implementations are not yet registered on the > ContentReaderWhiteboard. > when this happens, the content is loaded into the repository, but files like > *.json are not transformed to nodes and properties, but is stored as binary > json files in the repository. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11203) Content Loader: Introduce requireImportProvider directive
[
https://issues.apache.org/jira/browse/SLING-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506136#comment-17506136
]
Stefan Seifert commented on SLING-11203:
PR from [~enorman]:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
> Content Loader: Introduce requireImportProvider directive
> -
>
> Key: SLING-11203
> URL: https://issues.apache.org/jira/browse/SLING-11203
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Stefan Seifert
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> in context of SLING-11189 [~enorman] proposed the introduction of a
> {{requireImportProvider}} directive which allows bundles to declare on which
> import provider implementations they actually depend. with this, it can be
> ensured a bundle's content is not imported in an inconsistent state when one
> of the required providers is not (yet) available.
> for backward compatibility this paired with a configurable list of default
> import providers which is used for bundles which do not declare their own
> list of via {{requireImportProvider}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [VOTE] Release Apache Sling Starter 12 testing modules ( was: [VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype 1.0.6 and associated testing modules)
On Thu, 2022-03-10 at 15:26 +0100, Robert Munteanu wrote: > On Thu, 2022-03-10 at 15:15 +0100, Robert Munteanu wrote: > > Hi, > > > > I have amended the staging repository to drop the > > org.apache.sling.starter and sling-project-archetype artifacts. > > > > The vote will continue with only the testing artifacts included. > > > > The repository and check instructions remain the same, see below. > > Anyone else? Still missing a +1 binding vote.
[jira] [Created] (SLING-11203) Content Loader: Introduce requireImportProvider directive
Stefan Seifert created SLING-11203:
--
Summary: Content Loader: Introduce requireImportProvider directive
Key: SLING-11203
URL: https://issues.apache.org/jira/browse/SLING-11203
Project: Sling
Issue Type: New Feature
Components: Extensions
Reporter: Stefan Seifert
in context of SLING-11189 [~enorman] proposed the introduction of a
{{requireImportProvider}} directive which allows bundles to declare on which
import provider implementations they actually depend. with this, it can be
ensured a bundle's content is not imported in an inconsistent state when one of
the required providers is not (yet) available.
for backward compatibility this paired with a configurable list of default
import providers which is used for bundles which do not declare their own list
of via {{requireImportProvider}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #13: SLING-11203: Introduce requireImportProvider directive
stefanseifert commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1066613956 i've created a new ticket for this proposal: https://issues.apache.org/jira/browse/SLING-11203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] rombert commented on pull request #16: Replace commons-io version 2.6 with 2.11.0
rombert commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/16#issuecomment-1066609112 Thanks for the PR @namigupt . As mentioned at https://issues.apache.org/jira/browse/SLING-11202?focusedCommentId=17506131=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17506131 , this fix is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] rombert closed pull request #16: Replace commons-io version 2.6 with 2.11.0
rombert closed pull request #16: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11202) Replace commons-io version - version 2.6
[ https://issues.apache.org/jira/browse/SLING-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11202. - Resolution: Won't Fix Thanks for the report [~namigupt]. We only use commons-io at compile time, so there is no need for us to update. Applications deploying the bundle should make sure they use updated versions of the commons-io bundle. Also, your second CVE link points to a JUnit issue, not a commons-io one. > Replace commons-io version - version 2.6 > - > > Key: SLING-11202 > URL: https://issues.apache.org/jira/browse/SLING-11202 > Project: Sling > Issue Type: Improvement > Components: XSS Protection API >Reporter: Namit Gupta >Priority: Major > > Replace commons-io version 2.6 with version 2.11 to overcome the security > vulnerabilities: > # [CVE - CVE-2021-29425 > (mitre.org)|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-29425] > # [CVE - CVE-2020-15250 > (mitre.org)|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later
[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506126#comment-17506126
]
Robert Munteanu commented on SLING-11158:
-
Thank [~enorman], the proposed changes LGTM. I think [~karlpauls] may have a
better idea about which path to take with the launcher.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #16: Replace commons-io version 2.6 with 2.11.0
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/16#issuecomment-1066600847 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=16=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] namigupt opened a new pull request #16: Replace commons-io version 2.6 with 2.11.0
namigupt opened a new pull request #16: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/16 Replace commons-io version 2.6 with version 2.11 to mitigate the following security vulnerabilities: [CVE - CVE-2021-29425 (mitre.org)](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-29425) [CVE - CVE-2020-15250 (mitre.org)](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250) JIRA : [SLING-11202](https://issues.apache.org/jira/browse/SLING-11202) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [RESULT] [VOTE] Release Release Apache Sling Content Distribution Core 0.5.0 and Content Distribution Journal 0.1.24
>I will need help from a PMC member to copy the artifacts to apache dist. >Any volunteers? done with rev. 53060 stefan
[jira] [Commented] (SLING-11147) Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506120#comment-17506120
]
Konrad Windszus commented on SLING-11147:
-
[~olli] You can use an approach like
https://github.com/apache/sling-org-apache-sling-starter/blob/cf0d880293512cba24abbf75c73d017c23bb360e/pom.xml#L417-L428.
Property {{ci}} is set on our Jenkins build.
Regarding
bq. As you are currently looking into ci profile
Actually not, all changes have been applied already, I am not working on that
are currently.
> Configure Maven Failsafe Plugin to run build successfully on Java 17 (JPMS)
> ---
>
> Key: SLING-11147
> URL: https://issues.apache.org/jira/browse/SLING-11147
> Project: Sling
> Issue Type: Task
> Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.3.0
>
>
> * building with JDK 11 and 17 (JDK 8 does not support JPMS)
> * opening java.base/java.lang to Commons Threads ({*}Surefire{*} NOT
> Failsafe, keeping issue title to match commit)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #63: SLING-11158 use feature launcher assembly to launch the starter
rombert commented on a change in pull request #63: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/63#discussion_r825776776 ## File path: pom.xml ## @@ -156,14 +156,11 @@ prepare-feature-launcher -get -copy +unpack package - - org.apache.sling:org.apache.sling.feature.launcher:1.1.26 -true + org.apache.sling:org.apache.sling.feature.launcher:1.2.0:tar.gz Review comment: Why did you remove the `stripVersion` config? With it configured we don't have to update the documentation every time we update the feature launcher version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
