[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman edited a comment on pull request #23: SLING-8843 repoinit developer mode
enapps-enorman edited a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075516860 > I consider this as an emergency setting Then don't call it "developer mode", call it something else. Perhaps something more descriptive like "org.apache.sling.jcr.repoinit.keepRunningOnError". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman commented on pull request #23: SLING-8843 repoinit developer mode
enapps-enorman commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075516860 > I consider this as an emergency setting Then don't call it "developer mode", call it something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on a change in pull request #15: SLING-11203 Introduce requireImportProvider directive
enapps-enorman commented on a change in pull request #15:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/15#discussion_r832513399
##
File path: src/main/java/org/apache/sling/jcr/contentloader/PathEntry.java
##
@@ -392,6 +414,28 @@ public boolean isIgnoredImportProvider(String extension) {
return new HashSet<>(ignoreContentReaders);
}
+@Override
+public boolean isImportProviderRequired(@NotNull String name) {
+boolean required = false;
+
+if (!this.requireContentReaders.isEmpty()) {
+// a directive was supplied, so use a filter to check if the
+// name ends with the suffix and is not listed in the ignored
+// import provider set
+required = this.requireContentReaders.stream()
+.anyMatch(ext ->
Review comment:
See
[e58b835](https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/15/commits/e58b835b26e2acc4936d270c4a2ecc1ad19c575a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #15: SLING-11203 Introduce requireImportProvider directive
sonarcloud[bot] commented on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/15#issuecomment-1075505495 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_coverage=list) [83.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] removed a comment on pull request #15: SLING-11203 Introduce requireImportProvider directive
sonarcloud[bot] removed a comment on pull request #15: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/15#issuecomment-1072859128 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=15=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_coverage=list) [85.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=15=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh edited a comment on pull request #23: SLING-8843 repoinit developer mode
joerghoh edited a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075464081 I would then change it to use OSGI configuration, and not introducing a new abstraction for it. With runmodes we have the same capabilities, when it comes to support different settings. @enapps-enorman I consider this as an emergency setting, so developers do not have to rebuild their local environment, when they made a mistake with repoinit scripts. If this is a system property they can fix their environment even if it's not coming up anymore because of an incorrect repoinit script. With OSGI settings this gets a bit more complex; and not every developer starts its application with a feature launcher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075480719 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [61.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] removed a comment on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075444889 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [37.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh edited a comment on pull request #23: SLING-8843 repoinit developer mode
joerghoh edited a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075464081 I would then change it to use OSGI configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075464081 I would then change it to use OSGI configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman commented on pull request #23: SLING-8843 repoinit developer mode
enapps-enorman commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075452435 > If there's real demand for it, Is my demand for it not real? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075444889 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [37.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075432882 @enapps-enorman For the environment-specific settings we have runmodes, I don't see the real need or value to introduce a new concept here. For the moment I want to leave this setting as a system property. If there's real demand for it, we still can convert it into an OSGI setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] removed a comment on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1074829955 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [45.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on a change in pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#discussion_r832447935
##
File path:
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java
##
@@ -177,5 +194,13 @@ protected void applyOperations(Session session,
List ops, String logM
}
}
+
+protected static boolean isDeveloperModeEnabled() {
Review comment:
That would leave this method untested. Sure, it's trivial, but testing
it does not make the test code much more complicated.
I will leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman edited a comment on pull request #23: SLING-8843 repoinit developer mode
enapps-enorman edited a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075423395 > Makes it harder to misuse. @joerghoh To me the distinction you have made seems to be purely semantics. If the ProjectStage configuration defaults to "Production" then your code would only do the "Development" stuff when enabled manually. For example, if the user starts the feature launcher with a command line property variable that changes the default value or the admin manually changes the value using the ConfigurationAdmin. I think I would still prefer a generalized solution since the same decision could be useful to improve the sling DefaultErrorHandler to not return stacktrace or request progress details when in production. Exposing those implementation details of the server to the end users is a potential information disclosure vulnerability. Another example is perhaps you want to send minimized js files in production and non-minimized during development. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on a change in pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#discussion_r832443406
##
File path:
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java
##
@@ -177,5 +194,13 @@ protected void applyOperations(Session session,
List ops, String logM
}
}
+
+protected static boolean isDeveloperModeEnabled() {
+String dm = System.getProperty(PROPERTY_DEVELOPER_MODE);
Review comment:
good one, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on a change in pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#discussion_r832443105
##
File path:
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java
##
@@ -99,43 +105,54 @@ public String toString() {
@Override
public void processRepository(final SlingRepository repo) throws Exception
{
-if ( (config.references() != null && config.references().length > 0)
- || (config.scripts() != null && config.scripts().length > 0 )) {
+// loginAdministrative is ok here, definitely an admin operation
+final Session s = repo.loginAdministrative(null);
+try {
+executeScripts(s, config);
+} catch (Exception e) {
+if (isDeveloperModeEnabled()) {
+log.error("Eror in the repoinit scripts, which is ignored
because the developer mode is active. "
Review comment:
thanks, changed the wording and also added the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman commented on pull request #23: SLING-8843 repoinit developer mode
enapps-enorman commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075423395 > Makes it harder to misuse. @joerghoh To me the distinction you have made seems to be purely semantics. If the ProjectStage configuration defaults to "Production" then your code would only do the "Development" stuff when enabled manually. For example, if the user starts the feature launcher with a command line property variable that changes the default value or the admin manually changes the value using the ConfigurationAdmin. I think I would still prefer a generalized solution since the same decision could be useful to improve the sling DefaultErrorHandler to not return stacktrace or request progress details when in production. Exposing those implementation details of the server to the end users is a potential information disclosure vulnerability. Another example is perhaps you want to send minimized js files in production and non-minimized during development. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] cziegeler merged pull request #16: SLING-11210 : Use SlingUriBuilder
cziegeler merged pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu merged pull request #8: SLING-11210 - Use SlingUriBuilder
raducotescu merged pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] joerghoh commented on pull request #23: SLING-8843 repoinit developer mode
joerghoh commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1075391065 @enapps-enorman For a more generalized behavior we do have the runmodes. I decided against using OSGI configuration (and thus the ability to configure it per runmode) because this should be development only setting. If it is OSGI it would be a default setting in every project, which might end up in production. OSGI configuration is normally deployed along code, but system properties are not. Makes it harder to misuse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11210) Use SlingUriBuilder
[ https://issues.apache.org/jira/browse/SLING-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11210. -- Resolution: Fixed > Use SlingUriBuilder > --- > > Key: SLING-11210 > URL: https://issues.apache.org/jira/browse/SLING-11210 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting HTL Engine 1.4.18-1.4.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The bundle is currently implementing a ProviderType from the API, > RequestPathInfo. We should switch to the SlingUriBuilder to avoid > implementing ProviderType interfaces from the API. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[starter] Tentative JBang starter script
Hi, I've written a tentative script to start the Sling Starter 12 with jbang, at [1], To try it, install https://www.jbang.dev and run jbang start@apache/sling-whiteboard Optionally with Feature Launcher options at the end ( try -h ) If we think this is useful we might create a dedicated GitHub repository for such JBang scripts, to avoid having "whiteboard" in the command line. Feedback is welcome! -Bertrand [1] https://github.com/apache/sling-whiteboard/blob/master/jbang/SlingStarter.java
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14
+1 Carsten Am 22.03.2022 um 16:11 schrieb Robert Munteanu: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351440 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2617/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2617 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14
+1 regards, Karl On Tue, Mar 22, 2022 at 4:27 PM Angela Schreiber wrote: > > [x] +1 Approve the release > > kind regards > angela > > From: Robert Munteanu > Sent: Tuesday, March 22, 2022 4:11 PM > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Content-Package to Feature Model > Converter 1.1.14 > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351440 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2617/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2617 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14
[x] +1 Approve the release kind regards angela From: Robert Munteanu Sent: Tuesday, March 22, 2022 4:11 PM To: Sling Developers List Subject: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14 Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351440 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2617/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2617 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Updated] (SLING-10774) Fix sonar findings in content-package to feature model converter
[ https://issues.apache.org/jira/browse/SLING-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10774: Fix Version/s: Content-Package to Feature Model Converter 1.1.16 (was: Content-Package to Feature Model Converter 1.1.14) > Fix sonar findings in content-package to feature model converter > > > Key: SLING-10774 > URL: https://issues.apache.org/jira/browse/SLING-10774 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.16 > > > sonar reports quite some findings for the content-package to feature model > converter bundle that are easy to fix preventing broken window syndrome i > would suggest to keep fixing as much as possible. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10760) Converter ignores access control content and users/groups in .content.xml files
[
https://issues.apache.org/jira/browse/SLING-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10760:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> Converter ignores access control content and users/groups in .content.xml
> files
> ---
>
> Key: SLING-10760
> URL: https://issues.apache.org/jira/browse/SLING-10760
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
> Attachments: subtree_in_contentxml_policy.png,
> subtree_in_contentxml_sibling.png
>
>
> [~kpauls], while trying to find more edge cases that could cause SLING-10754,
> i noticed that not only sibling nodes but also access control content (like
> e.g. _rep:policy_ nodes) contained in a _.content.xml_ get installed by
> Jackrabbit Filevault even if those nodes are not covered by the corresponding
> {{WorkspaceFilter}}.
> It also seems that these package 'entries' are not spotted by the converter
> and thus the dedicated {{EntryHandler}} implementations that are intended to
> analyze and convert special content like e.g. access control (but probably
> not limited to that) are not triggered.
> In other words: content hidden in _.content.xml_ will not be properly
> converted but will be installed even if not covered by _filter.xml_
> associated with the content package. I don't know if that actually intended
> behavior of Jackrabbit FileVault (the documentation clearly stating that
> everything should be covered by filter rules [0], section 'Usage for
> Import/Installation'), but if it is correct it might in the worse case
> require the converter to parse all _.content.xml_ files and delegate to the
> proper handler implementations.
> [~kwin], I would appreciate your input on the FileVault related question of
> this ticket. In particular: is it correct and intended that subnodes defined
> in _.content.xml_ get installed even if not covered by any filter rule?
> [0] https://jackrabbit.apache.org/filevault/filter.html
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351440 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2617/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2617 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Updated] (SLING-10787) BundleEntryHandler.extractArtifactId prone to IllegalArgumentException
[
https://issues.apache.org/jira/browse/SLING-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10787:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> BundleEntryHandler.extractArtifactId prone to IllegalArgumentException
> --
>
> Key: SLING-10787
> URL: https://issues.apache.org/jira/browse/SLING-10787
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> trying to address sonar findings for {{BundleEntryHandler}} (see SLING-10784)
> i noticed that there is no guarantee that 'artifactId' and 'version' are not
> left null after all the processing completed. if any of the two is null
> constructing a new {{ArtifactId}} object from the given strings will fail
> will {{IllegalArgumentException}}.
> it might be as simple as extracting the following statements out of the
> previous block that handles the {{groupId == null}} case:
> {code}
> if (artifactId == null || artifactId.isEmpty()) {
> artifactId = groupId;
> }
>
> if (version == null) {
> Version osgiVersion =
> Version.parseVersion(getCheckedProperty(jarFile.getManifest(),
> Constants.BUNDLE_VERSION));
> version = osgiVersion.getMajor() + "." + osgiVersion.getMinor() +
> "." + osgiVersion.getMicro() + (osgiVersion.getQualifier().isEmpty() ? "" :
> "-" + osgiVersion.getQualifier());
> }
> {code}
> but i am not totally sure there is a reason the method
> {{BundleEntryHandler.extractArtifactId}} gets called out by sonar :)
> note: on line 472 of the same method {{IllegalArgumentException}} is
> caught so i assume the code doesn't expect this method to fail upon
> building the {{ArtifactId}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10779) ContentPackage2FeatureModelConverter.getAclManager should never return null
[
https://issues.apache.org/jira/browse/SLING-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10779:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> ContentPackage2FeatureModelConverter.getAclManager should never return null
> ---
>
> Key: SLING-10779
> URL: https://issues.apache.org/jira/browse/SLING-10779
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> {{ContentPackage2FeatureModelConverter.getAclManager}} is used across the
> converter code base and always expected to be not-null. so, instead of
> defining it as 'nullable' we should find ways to make sure it is always
> present on the converter. this would allow to get rid of
> Objects.requireNotNull and the warnings about potential NPE where the check
> is missing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10571) Hardcoded application paths in VaultPackageUtils.detectPackageType
[
https://issues.apache.org/jira/browse/SLING-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10571:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> Hardcoded application paths in VaultPackageUtils.detectPackageType
> --
>
> Key: SLING-10571
> URL: https://issues.apache.org/jira/browse/SLING-10571
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> while investigating SLING-10467 i noticed hardcoded paths for what should be
> considered application content in {{VaultPackageUtils.detectPackageType}}.
> the method looks as follows:
> {code}
> public static @NotNull PackageType detectPackageType(String path) {
> if ("/apps".equals(path)
> || path.startsWith("/apps/")
> || "/libs".equals(path)
> || path.startsWith("/libs/")) {
> return PackageType.APPLICATION;
> } else {
> return PackageType.CONTENT;
> }
> }
> {code}
> instead of hardcoding /apps and /libs which are details of Adobe AEM, these
> paths should be configured with the converter-launcher. in particular since
> the list looks a bit arbitrary as there are other paths that IMHO should be
> considered application content like nodetype registry, namespace registry,
> privilege registry, service users etc.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10768) AbstractJcrNodeParser and subclasses ignore namespace mappings
[
https://issues.apache.org/jira/browse/SLING-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10768:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> AbstractJcrNodeParser and subclasses ignore namespace mappings
> --
>
> Key: SLING-10768
> URL: https://issues.apache.org/jira/browse/SLING-10768
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> The {{AbstractJcrNodeParser}} has a constant defined for "jcr:root". It would
> be better if it (and subclasses) would not rely on the default namespace
> mappings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10781) ContentPackage2FeatureModelConverterLauncher - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10781: Fix Version/s: Content-Package to Feature Model Converter 1.1.16 (was: Content-Package to Feature Model Converter 1.1.14) > ContentPackage2FeatureModelConverterLauncher - sonar findings > - > > Key: SLING-10781 > URL: https://issues.apache.org/jira/browse/SLING-10781 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.16 > > > see > https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fcli%2FContentPackage2FeatureModelConverterLauncher.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10861) Subpackages are missing dependency on their container
[ https://issues.apache.org/jira/browse/SLING-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10861: Fix Version/s: Content-Package to Feature Model Converter 1.1.16 (was: Content-Package to Feature Model Converter 1.1.14) > Subpackages are missing dependency on their container > - > > Key: SLING-10861 > URL: https://issues.apache.org/jira/browse/SLING-10861 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.16 > > > When the converter is extracting sub packages it is not adding a dependency > to their containing package to them. It does for embedded packages but not > for subpackages. It should add a dependency in both cases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10784) BundleEntryHandler - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10784: Fix Version/s: Content-Package to Feature Model Converter 1.1.16 (was: Content-Package to Feature Model Converter 1.1.14) > BundleEntryHandler - sonar findings > --- > > Key: SLING-10784 > URL: https://issues.apache.org/jira/browse/SLING-10784 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.16 > > > https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fhandlers%2FBundleEntryHandler.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10914) CpConverter - package type calculation should take filters into account
[ https://issues.apache.org/jira/browse/SLING-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10914: Fix Version/s: Content-Package to Feature Model Converter 1.1.16 (was: Content-Package to Feature Model Converter 1.1.14) > CpConverter - package type calculation should take filters into account > --- > > Key: SLING-10914 > URL: https://issues.apache.org/jira/browse/SLING-10914 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.16 > > > The converter does attempt to (re-)calculate the package type (application, > content, mixed) as part of creating the converted packages. However, it > doesn't take the targets of the filters into account when determining the > type. As such, it is possible that e.g. a package containing a filter > targeting apps would end up being classified as being of type content. > Furthermore, it when looking into the content, it doesn't take into account > if the content is covered by filters - ie., it doesn't really check if the > content would be ignored by vault. > Given that it is hard to know what vault will install or not, it might not be > possible to fix the second issue - however, it should be possible to at least > look at the filters and take their targets into account (as pathes) when > (re-)calculating the package type. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11060) CPConverter - sling initial content - ACL support
[
https://issues.apache.org/jira/browse/SLING-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11060:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> CPConverter - sling initial content - ACL support
> -
>
> Key: SLING-11060
> URL: https://issues.apache.org/jira/browse/SLING-11060
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: Niek Raaijmakers
>Assignee: Niek Raaijmakers
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> Currently, we do not implement the ACL support for Sling Initial Content as
> specified :
> [https://sling.apache.org/documentation/bundles/repository-initialization.html]
> We need the following methods
> (org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.VaultContentXMLContentCreator)
> implemented or another workaround found:
>
> {code:java}
> @Override
> public boolean switchCurrentNode(String subPath, String newNodeType) throws
> RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createUser(String name, String password, Map
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createGroup(String name, String[] members, Map
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principal, String[] grantedPrivileges, String[]
> deniedPrivileges, String order) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principalId, String[] grantedPrivilegeNames,
> String[] deniedPrivilegeNames,
> String order, Map restrictions, Map
> mvRestrictions,
> Set removedRestrictionNames) throws RepositoryException {
> throw new UnsupportedOperationException();
> }{code}
>
> Stashed code is on branch: SLING-10931
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10790) BundleEntryHandler.extractArtifactId may use wrong GAV
[
https://issues.apache.org/jira/browse/SLING-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10790:
Fix Version/s: Content-Package to Feature Model Converter 1.1.16
(was: Content-Package to Feature Model Converter 1.1.14)
> BundleEntryHandler.extractArtifactId may use wrong GAV
> --
>
> Key: SLING-10790
> URL: https://issues.apache.org/jira/browse/SLING-10790
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> [~kpauls], if my reading of {{BundleEntryHandler.extractArtifactId}} is
> correct it the method might be ending up using the wrong
> groupId/artifactId/version.
> the code will loop over jar-entries and stop if the extracted GAV matches the
> bundle name. however, groupId/artifactId/version are not reset to {{null}} in
> case they were successfully extracted but didn't end up matching the bundle
> name i.e. {quote}it was the pom.properties we were looking for{quote}.
> i can't tell how big of an issue that is (and how likely). but given the fact
> that there is some extra effort to verify that the parsed pom is actually the
> right one, it might actually be relevant. the relies on a compliant content
> package that does contain a matching pom, which may or may not be the case...
> logging a warning or throwing a ConverterException in case of violation might
> help spotting troublesome content packages instead of getting some sort of
> side effect if another pom was spotted.
> a heavily simplified copy of the method:
> {code}
> String artifactId = null;
> String version = null;
> String groupId = null;
> String classifier = null;
> for (Enumeration e = jarFile.entries();
> e.hasMoreElements();) {
> [...]
> // extract groupId/artifactId/version
> [...]
>
> if (groupId != null && artifactId != null && version != null) {
> // bundleName is now the bare name without extension
> String synthesized = artifactId + "-" + version;
> // it was the pom.properties we were looking for
> if (bundleName.startsWith(synthesized) ||
> bundleName.equals(artifactId)) {
> [...]
>
> // no need to iterate further
> break;
> }
> }
> }
>
> if (groupId == null) {
> [...]
> }
> return new ArtifactId(groupId, artifactId, version, classifier,
> JAR_TYPE);
> {code}
> feel free to resolve as not a problem in case my reading of the code is all
> wrong.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-scripting-sightly] cziegeler commented on pull request #16: SLING-11210 : Use SlingUriBuilder
cziegeler commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075214862 @raducotescu All TCK tests now pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Sling Feature Analyser 1.6.4
+1 Carsten Am 22.03.2022 um 14:31 schrieb Christian Schneider: Hi all, this is a vote to release org.apache.sling.feature.analyser 1.6.4 Fixed issues: https://issues.apache.org/jira/projects/SLING/versions/12351476 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2616/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 2616 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Here is my +1 (non binding) - Best regards, Christian -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com -- Carsten Ziegeler Adobe cziege...@apache.org
[VOTE] Release Sling Feature Analyser 1.6.4
Hi all, this is a vote to release org.apache.sling.feature.analyser 1.6.4 Fixed issues: https://issues.apache.org/jira/projects/SLING/versions/12351476 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2616/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 2616 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. - Here is my +1 (non binding) - Best regards, Christian -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] removed a comment on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] removed a comment on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075072609 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [85.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075120909 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [75.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11192) Calculating metrics takes too long
[
https://issues.apache.org/jira/browse/SLING-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-11192.
--
Resolution: Fixed
> Calculating metrics takes too long
> --
>
> Key: SLING-11192
> URL: https://issues.apache.org/jira/browse/SLING-11192
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Joerg Hoh
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Event 4.3.2
>
>
> we use the prometheus exporter to export Sling Metrics / Dropwizard metrics,
> and we often see messages like this:
> {noformat}
> 10.03.2022 08:50:15.333 [...] *WARN* [qtp568481508-1779]
> io.prometheus.client.dropwizard.DropwizardExports Gauge has been blacklisted
> for 30 ms due timeout: Generated from Dropwizard metric import
> (metric=sling_event.jobs.cancelled.count,
> type=org.apache.sling.event.impl.jobs.stats.GaugeSupport$2)
> {noformat}
> This means that calculating the metric took too long. We should make sure
> that the calculation is done asnychronously and just pre-computed values are
> returned.
> For at least these values the handling needs to be improved:
> * sling_event.jobs.active.count
> * sling_event.jobs.averageProcessingTime
> * sling_event.jobs.averageWaitingTime
> * sling_event.jobs.cancelled.count
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on a change in pull request #15: SLING-11203 Introduce requireImportProvider directive
stefanseifert commented on a change in pull request #15:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/15#discussion_r832083347
##
File path: src/main/java/org/apache/sling/jcr/contentloader/PathEntry.java
##
@@ -392,6 +414,28 @@ public boolean isIgnoredImportProvider(String extension) {
return new HashSet<>(ignoreContentReaders);
}
+@Override
+public boolean isImportProviderRequired(@NotNull String name) {
+boolean required = false;
+
+if (!this.requireContentReaders.isEmpty()) {
+// a directive was supplied, so use a filter to check if the
+// name ends with the suffix and is not listed in the ignored
+// import provider set
+required = this.requireContentReaders.stream()
+.anyMatch(ext ->
Review comment:
imho this part of the code is unnecessary hard to read for that simple
thing it does - probably move this extension extraction code to a separate
method with proper name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075072609 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [85.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] removed a comment on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] removed a comment on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075016763 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11208) Allow to select enabled instead of disabled content package validators
[ https://issues.apache.org/jira/browse/SLING-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-11208. - Resolution: Fixed > Allow to select enabled instead of disabled content package validators > -- > > Key: SLING-11208 > URL: https://issues.apache.org/jira/browse/SLING-11208 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Feature Model Analyser 1.6.4 > > > We get too many warnings with the default set of validators. So validators > should be disabled by default and enabled by name. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11208) Allow to select enabled instead of disabled content package validators
[ https://issues.apache.org/jira/browse/SLING-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-11208: Fix Version/s: Feature Model Analyser 1.6.4 > Allow to select enabled instead of disabled content package validators > -- > > Key: SLING-11208 > URL: https://issues.apache.org/jira/browse/SLING-11208 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Feature Model Analyser 1.6.4 > > > We get too many warnings with the default set of validators. So validators > should be disabled by default and enabled by name. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #989 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/989/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Commented] (SLING-11192) Calculating metrics takes too long
[
https://issues.apache.org/jira/browse/SLING-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510411#comment-17510411
]
Joerg Hoh commented on SLING-11192:
---
I think that we do not need to have strong guarantees here, because it is
"just statistics".
> Calculating metrics takes too long
> --
>
> Key: SLING-11192
> URL: https://issues.apache.org/jira/browse/SLING-11192
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Joerg Hoh
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Event 4.3.2
>
>
> we use the prometheus exporter to export Sling Metrics / Dropwizard metrics,
> and we often see messages like this:
> {noformat}
> 10.03.2022 08:50:15.333 [...] *WARN* [qtp568481508-1779]
> io.prometheus.client.dropwizard.DropwizardExports Gauge has been blacklisted
> for 30 ms due timeout: Generated from Dropwizard metric import
> (metric=sling_event.jobs.cancelled.count,
> type=org.apache.sling.event.impl.jobs.stats.GaugeSupport$2)
> {noformat}
> This means that calculating the metric took too long. We should make sure
> that the calculation is done asnychronously and just pre-computed values are
> returned.
> For at least these values the handling needs to be improved:
> * sling_event.jobs.active.count
> * sling_event.jobs.averageProcessingTime
> * sling_event.jobs.averageWaitingTime
> * sling_event.jobs.cancelled.count
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11192) Calculating metrics takes too long
[
https://issues.apache.org/jira/browse/SLING-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510403#comment-17510403
]
Stefan Egli commented on SLING-11192:
-
Thx, agree.
> Calculating metrics takes too long
> --
>
> Key: SLING-11192
> URL: https://issues.apache.org/jira/browse/SLING-11192
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Joerg Hoh
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Event 4.3.2
>
>
> we use the prometheus exporter to export Sling Metrics / Dropwizard metrics,
> and we often see messages like this:
> {noformat}
> 10.03.2022 08:50:15.333 [...] *WARN* [qtp568481508-1779]
> io.prometheus.client.dropwizard.DropwizardExports Gauge has been blacklisted
> for 30 ms due timeout: Generated from Dropwizard metric import
> (metric=sling_event.jobs.cancelled.count,
> type=org.apache.sling.event.impl.jobs.stats.GaugeSupport$2)
> {noformat}
> This means that calculating the metric took too long. We should make sure
> that the calculation is done asnychronously and just pre-computed values are
> returned.
> For at least these values the handling needs to be improved:
> * sling_event.jobs.active.count
> * sling_event.jobs.averageProcessingTime
> * sling_event.jobs.averageWaitingTime
> * sling_event.jobs.cancelled.count
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1075016763 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] removed a comment on pull request #16: SLING-11210 : Use SlingUriBuilder
sonarcloud[bot] removed a comment on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/16#issuecomment-1072068217 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=16=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=16=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=16=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu commented on pull request #8: SLING-11210 - Use SlingUriBuilder
raducotescu commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/8#issuecomment-1074994017 @cziegeler, I've prepared the IT setup for your update. We'll need to ignore the `jackrabbit.usermanager` module for now, but at least you can run the IT to test your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu opened a new pull request #8: SLING-11210 - Use SlingUriBuilder
raducotescu opened a new pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/8 * updated IT setup to allow test execution; the jackrabbit.usermanager does not currently start -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11192) Calculating metrics takes too long
[
https://issues.apache.org/jira/browse/SLING-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510323#comment-17510323
]
Carsten Ziegeler commented on SLING-11192:
--
[~stefanegli] Thanks, yes, the contract for getNumberOfProcessedJobs is now a
little bit weaker - but I don't think that this is a problem as Statistics is
not immutable and therefore calling two methods in it have no consistency
guarantees. And yes, that mutability is the underlying problem. The state might
change between any two method calls,
I was wondering if we should fix this - which would mean deprecating the
current approach and providing a way to get an immutable state object. On the
other hand, we have this inconsistency from the beginning and it doesn't seem
to be a real world problem.
> Calculating metrics takes too long
> --
>
> Key: SLING-11192
> URL: https://issues.apache.org/jira/browse/SLING-11192
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Joerg Hoh
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Event 4.3.2
>
>
> we use the prometheus exporter to export Sling Metrics / Dropwizard metrics,
> and we often see messages like this:
> {noformat}
> 10.03.2022 08:50:15.333 [...] *WARN* [qtp568481508-1779]
> io.prometheus.client.dropwizard.DropwizardExports Gauge has been blacklisted
> for 30 ms due timeout: Generated from Dropwizard metric import
> (metric=sling_event.jobs.cancelled.count,
> type=org.apache.sling.event.impl.jobs.stats.GaugeSupport$2)
> {noformat}
> This means that calculating the metric took too long. We should make sure
> that the calculation is done asnychronously and just pre-computed values are
> returned.
> For at least these values the handling needs to be improved:
> * sling_event.jobs.active.count
> * sling_event.jobs.averageProcessingTime
> * sling_event.jobs.averageWaitingTime
> * sling_event.jobs.cancelled.count
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] removed a comment on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1073254753 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [45.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #23: SLING-8843 repoinit developer mode
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#issuecomment-1074829955 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [45.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
