Re: [VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
+1 (small minor typo on usage instruction : " sh check_staged_release.sh 2634/tmp/sling-staging" misses a space between revision # and tmp folder) Le mer. 11 mai 2022 à 06:56, Carsten Ziegeler a écrit : > +1 > > Carsten > > Am 10.05.2022 um 17:24 schrieb Carsten Ziegeler: > > Hi, > > > > we solved 5 issues for scripting jsp 2.6.0 > > > https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 > > > > > > we solved one issue for servlets resolver 2.9.6 > > > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 > > > > > > we solved two issues for scripting core 2.4.8 > > > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2634/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > sh check_staged_release.sh 2634/tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
+1 Carsten Am 10.05.2022 um 17:24 schrieb Carsten Ziegeler: Hi, we solved 5 issues for scripting jsp 2.6.0 https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 we solved one issue for servlets resolver 2.9.6 https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 we solved two issues for scripting core 2.4.8 https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2634/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2634/tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
+1 Regards, Eric On Tue, May 10, 2022 at 8:24 AM Carsten Ziegeler wrote: > Hi, > > we solved 5 issues for scripting jsp 2.6.0 > > https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 > > we solved one issue for servlets resolver 2.9.6 > > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 > > we solved two issues for scripting core 2.4.8 > > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2634/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2634/tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
+1 regards, Karl On Tue, May 10, 2022 at 5:24 PM Carsten Ziegeler wrote: > > Hi, > > we solved 5 issues for scripting jsp 2.6.0 > https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 > > we solved one issue for servlets resolver 2.9.6 > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 > > we solved two issues for scripting core 2.4.8 > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2634/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2634/tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[jira] [Updated] (SLING-11213) Concurrency problem on shutdown
[
https://issues.apache.org/jira/browse/SLING-11213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-11213:
-
Fix Version/s: Scripting Core 2.4.8
> Concurrency problem on shutdown
> ---
>
> Key: SLING-11213
> URL: https://issues.apache.org/jira/browse/SLING-11213
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.3.6, Scripting Core 2.4.4
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Scripting Core 2.4.8
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> During shutdown you can get this exception:
> {noformat}
> 13.03.2022 03:08:06.754 *ERROR* [FelixDispatchQueue] ERROR: Bundle '492'
> EventDispatcher: Error during dispatch.
> (java.util.ConcurrentModificationException)
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
> at java.util.HashMap$KeyIterator.next(HashMap.java:1461)
> at
> org.apache.sling.scripting.core.impl.jsr223.SlingScriptEngineManager.updateFactories(SlingScriptEngineManager.java:307)
> at
> org.apache.sling.scripting.core.impl.jsr223.SlingScriptEngineManager.bundleChanged(SlingScriptEngineManager.java:225)
> at
> org.apache.felix.framework.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:915)
> at
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:834)
> at
> org.apache.felix.framework.EventDispatcher.run(EventDispatcher.java:1147)
> at
> org.apache.felix.framework.EventDispatcher.access$000(EventDispatcher.java:54)
> at
> org.apache.felix.framework.EventDispatcher$1.run(EventDispatcher.java:102)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
Hi, we solved 5 issues for scripting jsp 2.6.0 https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 we solved one issue for servlets resolver 2.9.6 https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 we solved two issues for scripting core 2.4.8 https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2634/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2634/tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #17: Bump commons-io from 2.6 to 2.7
sonarcloud[bot] commented on PR #17: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/17#issuecomment-1122529069 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-core=17) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core=17=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core=17=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core=17=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core=17=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core=17=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core=17=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core=17=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9905) Provide option to include sling instance id nodes in cleanup
[ https://issues.apache.org/jira/browse/SLING-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534395#comment-17534395 ] Stefan Egli commented on SLING-9905: Ah, all good, the unassigned folder is actually starting with topicName thereafter.. so no worries > Provide option to include sling instance id nodes in cleanup > > > Key: SLING-9905 > URL: https://issues.apache.org/jira/browse/SLING-9905 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Event 4.3.2 > > > Currently, empty nodes for Sling job handling are removed, up to the JCR node > specific to a Sling instance id. That node is kept in place to avoid > unnecessary removal and recreation. > This assumes that the instances are stable and do not frequently change. > However, in volatile installations where new instances are constantly created > (and old ones stopped), this leads to a growing number of nodes for each id > ever started. > One way would be to provide a "idle timeout" configuration - for an instance > id it is recorded when it was first not seen anymore and if it is not seen > for the configured time, these nodes get removed. For example, if the timeout > is set to one day, such nodes are removed approximately one day after the > instance was stopped. > There are probably other ways to fix this -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9905) Provide option to include sling instance id nodes in cleanup
[
https://issues.apache.org/jira/browse/SLING-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534387#comment-17534387
]
Stefan Egli commented on SLING-9905:
[~cziegeler], question before I dig into writing a test: IIUC then
* configuration.getLocalJobPath() is {{/var/eventing/jobs/assigned/}}
* configuration.getUnassignedJobsPath() is {{/var/eventing/jobs/unassigned}}
So they are not at the same level.
However, the
[code|https://github.com/apache/sling-org-apache-sling-event/blob/86a672566f43704f3fa05f2e83c24f6775ef08c3/src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java#L264]
doesn't seem to distinguish whether it is invoked
* with the
[localJobPath|https://github.com/apache/sling-org-apache-sling-event/blob/master/src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java#L100]
* or with the
[unassignedJobPath|https://github.com/apache/sling-org-apache-sling-event/blob/master/src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java#L102]
So I was wondering if that distinction was missing in fullEmptyFolderCleanup or
if this is by design and I'm overlooking something
> Provide option to include sling instance id nodes in cleanup
>
>
> Key: SLING-9905
> URL: https://issues.apache.org/jira/browse/SLING-9905
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Event 4.3.2
>
>
> Currently, empty nodes for Sling job handling are removed, up to the JCR node
> specific to a Sling instance id. That node is kept in place to avoid
> unnecessary removal and recreation.
> This assumes that the instances are stable and do not frequently change.
> However, in volatile installations where new instances are constantly created
> (and old ones stopped), this leads to a growing number of nodes for each id
> ever started.
> One way would be to provide a "idle timeout" configuration - for an instance
> id it is recorded when it was first not seen anymore and if it is not seen
> for the configured time, these nodes get removed. For example, if the timeout
> is set to one day, such nodes are removed approximately one day after the
> instance was stopped.
> There are probably other ways to fix this
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [sling-org-apache-sling-scripting-core] dependabot[bot] opened a new pull request, #17: Bump commons-io from 2.6 to 2.7
dependabot[bot] opened a new pull request, #17: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/17 Bumps commons-io from 2.6 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-org-apache-sling-scripting-core/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] dependabot[bot] opened a new pull request, #16: Bump jsoup from 1.11.3 to 1.14.2
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/16 Bumps [jsoup](https://github.com/jhy/jsoup) from 1.11.3 to 1.14.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>jsoup's releases. jsoup 1.14.2 Caught by the fuzz! jsoup 1.14.2 is out now, and includes a set of parser bug fixes and improvements for handling rough HTML and XML, as identified by the Jazzer JVM fuzzer. This release also includes other fixes and improvements. See the https://jsoup.org/news/release-1.14.2;>release announcement for the full changelog. jsoup 1.14.1 jsoup 1.14.1 is out now, with simple request session management, increased parse robustness, and a ton of other improvements, speed-ups, and bug fixes. See the full https://jsoup.org/news/release-1.14.1;>announcement for all the details on what's changed. jsoup 1.13.1 See the https://jsoup.org/news/release-1.13.1;>release notes. dependency !-- jsoup HTML parser library @ https://jsoup.org/ -- groupIdorg.jsoup/groupId artifactIdjsoup/artifactId version1.13.1/version /dependency jsoup-1.12.2 No release notes provided. Changelog Sourced from https://github.com/jhy/jsoup/blob/master/CHANGES;>jsoup's changelog. jsoup changelog *** Release 1.15.1 [PENDING] Change: removed previously deprecated methods and classes (including org.jsoup.safety.Whitelist; use org.jsoup.safety.Safelist instead). Improvement: when converting jsoup Documents to W3C Documents in W3CDom, preserve HTML valid attribute names if the input document is using the HTML syntax. (Previously, would always coerce using the more restrictive XML syntax.) https://github-redirect.dependabot.com/jhy/jsoup/pull/1648;>jhy/jsoup#1648 Improvement: added the :containsWholeText(text) selector, to match against non-normalized Element text. That can be useful when elements can only be distinguished by e.g. specific case, or leading whitespace, etc. https://github-redirect.dependabot.com/jhy/jsoup/issues/1636;>jhy/jsoup#1636 Improvement: added Element#wholeOwnText() to retrieve the original (non-normalized) ownText of an Element. Also added the :containsWholeOwnText(text) selector, to match against that. BR elements are now treated as newlines in the wholeText methods. https://github-redirect.dependabot.com/jhy/jsoup/issues/1636;>jhy/jsoup#1636 Improvement: added the :matchesWholeText(regex) and :matchesWholeOwnText(regex) selectors, to match against whole (non-normalized, case sensitive element text and own text, respectively. https://github-redirect.dependabot.com/jhy/jsoup/issues/1636;>jhy/jsoup#1636 Improvement: when evaluating an XPath query against a context element, the complete document is now visible to the query, vs only the context element's sub-tree. This enables support for queries outside (parent or sibling) the element, e.g. ancestor-or-self::*. https://github-redirect.dependabot.com/jhy/jsoup/issues/1652;>jhy/jsoup#1652 Improvement: allow a maxPaddingWidth on the indent level in OutputSettings when pretty printing. This defaults to 30 to limit the indent level for very deeply nested elements, and may be disabled by setting to -1. https://github-redirect.dependabot.com/jhy/jsoup/pull/1655;>jhy/jsoup#1655 Improvement: when cloning a Node or an Element, the clone gets a cloned OwnerDocument containing only that clone, so as to preserve applicable settings, such as the Pretty Print settings. https://github-redirect.dependabot.com/jhy/jsoup/issues/763;>jhy/jsoup#763 Improvement: added a convenience method Jsoup.parse(File). https://github-redirect.dependabot.com/jhy/jsoup/issues/1693;>jhy/jsoup#1693 Improvement: in the NodeTraversor, added default implementations for NodeVisitor.tail() and NodeFilter.tail(), so that code using only head() methods can be written as lambdas. Improvement: in NodeTraversor, added support for removing nodes via Node.remove() during NodeVisitor.head(). https://github-redirect.dependabot.com/jhy/jsoup/issues/1699;>jhy/jsoup#1699 Improvement: added Node.forEachNode(Consumer) and Element.forEach(ConsumerElement) methods, to efficiently traverse the DOM with a functional interface. https://github-redirect.dependabot.com/jhy/jsoup/issues/1700;>jhy/jsoup#1700 Bugfix: boolean attribute names should be case-insensitive, but were not when the parser was configured to preserve ... (truncated) Commits https://github.com/jhy/jsoup/commit/19c77325c9abb6f8b8b65034470e15faad6ce822;>19c7732 [maven-release-plugin] prepare release jsoup-1.14.2 https://github.com/jhy/jsoup/commit/acde180f094e2749d22034916cb35914289e521a;>acde180 Compress harder
[GitHub] [sling-org-apache-sling-datasource] sonarcloud[bot] commented on pull request #2: SLING-11310: update to parent 47
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-datasource/pull/2#issuecomment-1122393636 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-datasource=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-datasource=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-datasource=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-datasource=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-datasource=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-datasource=2=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-datasource=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-datasource=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-datasource=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11310) update sling-datasource to parent 47
Ashok Pelluru created SLING-11310: - Summary: update sling-datasource to parent 47 Key: SLING-11310 URL: https://issues.apache.org/jira/browse/SLING-11310 Project: Sling Issue Type: Sub-task Reporter: Ashok Pelluru Fix For: DataSource Provider 1.1.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [sling-org-apache-sling-jcr-resource] cziegeler commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getPar
cziegeler commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122348095 I think we shouldn't worry too much about updating older versions, that can be handled in various ways. Of course a 1.2.2 would make that story much easier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] reschke commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParen
reschke commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122344612 > @reschke , the problem with back-porting API extensions is usually that we need to be extra careful with the semantic versioning that's why i usually try to avoid it. Understood, but in this case I believe it's possible; at least for 1.22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParen
anchela commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122342557 @joerghoh , yes. that's what i meant with my initial comment, when i said we might need some extra check. i remember having seen something like that in sling code, but i don't recall where that was. @reschke , the problem with back-porting API extensions is usually that we need to be extra careful with the semantic versioning that's why i usually try to avoid it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] reschke commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParen
reschke commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122326192 Well, we could backport to Oak 1.22.*. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getPare
joerghoh commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122315295 The only problem I could see is the updated dependency to Oak 1.42 (which can cause problems on downstream applications, which still use an older version, e.g. AEM 6.5). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122293954 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-resource=23) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [52.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122284867 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-resource=23) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [52.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvide
anchela commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869136143
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrItemResourceFactory.java:
##
@@ -197,4 +201,21 @@ else if (session.itemExists(path)) {
return item;
}
+@Nullable Node getParentOrNull(@NotNull Item child, @NotNull String
parentPath) {
+Node parent = null;
+try {
+// Use fast getParentOrNull if session is a JackrabbitSession
+if (this.isJackrabbit) {
+parent = ((JackrabbitSession) session).getParentOrNull(child);
+} else if (session.nodeExists(parentPath)) {
+// Fallback to slower nodeExists & getNode pattern
+parent = session.getNode(parentPath);
+}
+} catch (RepositoryException e) {
+log.debug("Unable to access node at " + parentPath + ", possibly
invalid path", e);
Review Comment:
hopefully better now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvide
anchela commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869134097
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrItemResourceFactory.java:
##
@@ -197,4 +201,21 @@ else if (session.itemExists(path)) {
return item;
}
+@Nullable Node getParentOrNull(@NotNull Item child, @NotNull String
parentPath) {
+Node parent = null;
+try {
+// Use fast getParentOrNull if session is a JackrabbitSession
+if (this.isJackrabbit) {
+parent = ((JackrabbitSession) session).getParentOrNull(child);
+} else if (session.nodeExists(parentPath)) {
+// Fallback to slower nodeExists & getNode pattern
+parent = session.getNode(parentPath);
+}
+} catch (RepositoryException e) {
+log.debug("Unable to access node at " + parentPath + ", possibly
invalid path", e);
Review Comment:
see also line 198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvide
anchela commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869131696
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java:
##
@@ -358,28 +358,21 @@ public Iterator
listChildren(ResolveContext ctx, Res
@Override
public @Nullable Resource getParent(final @NotNull
ResolveContext ctx, final @NotNull Resource child) {
if (child instanceof JcrItemResource) {
-try {
-String version = null;
-if (child.getResourceMetadata().getParameterMap() != null) {
-version =
child.getResourceMetadata().getParameterMap().get("v");
-}
-if (version == null) {
-String parentPath =
ResourceUtil.getParent(child.getPath());
-if (parentPath != null) {
-Item parentItem =
ctx.getProviderState().getResourceFactory()
-.getItemOrNull(parentPath);
-if (parentItem != null && parentItem.isNode()) {
-return new
JcrNodeResource(ctx.getResourceResolver(),
-parentPath, null, (Node)parentItem,
-ctx.getProviderState().getHelperData());
-}
+String version = null;
+if (child.getResourceMetadata().getParameterMap() != null) {
+version =
child.getResourceMetadata().getParameterMap().get("v");
+}
+if (version == null) {
+String parentPath = ResourceUtil.getParent(child.getPath());
Review Comment:
not quite but i fell into the same trap. but looking at
ResourceUtil.getParent it does some extra magic like returning null if the item
is the root node.
also the calculated parent path is used for the fallback when no
JackrabbitSession is available.
so, i decided to leave the code instead of having it duplicated with all the
logic involved but maybe there is a way to simplify it but
ResourceUtil.getParent looks quite complex and i didn't want to introduce nasty
side effects by replacing it by PathUtil.getParent or some other utility i am
familiar with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvide
anchela commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869128425
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrItemResourceFactory.java:
##
@@ -197,4 +201,21 @@ else if (session.itemExists(path)) {
return item;
}
+@Nullable Node getParentOrNull(@NotNull Item child, @NotNull String
parentPath) {
+Node parent = null;
+try {
+// Use fast getParentOrNull if session is a JackrabbitSession
+if (this.isJackrabbit) {
+parent = ((JackrabbitSession) session).getParentOrNull(child);
+} else if (session.nodeExists(parentPath)) {
+// Fallback to slower nodeExists & getNode pattern
+parent = session.getNode(parentPath);
+}
+} catch (RepositoryException e) {
+log.debug("Unable to access node at " + parentPath + ", possibly
invalid path", e);
Review Comment:
most likely it is due to lack of permission it's the original message
and i didn't alter that one. i would leave out any confusing attempt to explain
what could potentially be wrong but that's my take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvid
joerghoh commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869092430
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java:
##
@@ -358,28 +358,21 @@ public Iterator
listChildren(ResolveContext ctx, Res
@Override
public @Nullable Resource getParent(final @NotNull
ResolveContext ctx, final @NotNull Resource child) {
if (child instanceof JcrItemResource) {
-try {
-String version = null;
-if (child.getResourceMetadata().getParameterMap() != null) {
-version =
child.getResourceMetadata().getParameterMap().get("v");
-}
-if (version == null) {
-String parentPath =
ResourceUtil.getParent(child.getPath());
-if (parentPath != null) {
-Item parentItem =
ctx.getProviderState().getResourceFactory()
-.getItemOrNull(parentPath);
-if (parentItem != null && parentItem.isNode()) {
-return new
JcrNodeResource(ctx.getResourceResolver(),
-parentPath, null, (Node)parentItem,
-ctx.getProviderState().getHelperData());
-}
+String version = null;
+if (child.getResourceMetadata().getParameterMap() != null) {
+version =
child.getResourceMetadata().getParameterMap().get("v");
+}
+if (version == null) {
+String parentPath = ResourceUtil.getParent(child.getPath());
Review Comment:
If we knew here that it is already a Jackrabbit-Repo, we would not need to
calculate the parentPath for this codepath. This would be only necessary when
line 371 is reached.
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java:
##
@@ -358,28 +358,21 @@ public Iterator
listChildren(ResolveContext ctx, Res
@Override
public @Nullable Resource getParent(final @NotNull
ResolveContext ctx, final @NotNull Resource child) {
if (child instanceof JcrItemResource) {
-try {
-String version = null;
-if (child.getResourceMetadata().getParameterMap() != null) {
-version =
child.getResourceMetadata().getParameterMap().get("v");
-}
-if (version == null) {
-String parentPath =
ResourceUtil.getParent(child.getPath());
-if (parentPath != null) {
-Item parentItem =
ctx.getProviderState().getResourceFactory()
-.getItemOrNull(parentPath);
-if (parentItem != null && parentItem.isNode()) {
-return new
JcrNodeResource(ctx.getResourceResolver(),
-parentPath, null, (Node)parentItem,
-ctx.getProviderState().getHelperData());
-}
+String version = null;
+if (child.getResourceMetadata().getParameterMap() != null) {
+version =
child.getResourceMetadata().getParameterMap().get("v");
+}
+if (version == null) {
+String parentPath = ResourceUtil.getParent(child.getPath());
Review Comment:
If we knew here that it is already a Jackrabbit-Repo, we would not need to
calculate the parentPath for this codepath. This would be only necessary when
line 371 is reached.
Just food for thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on a diff in pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvid
joerghoh commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#discussion_r869084037
##
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrItemResourceFactory.java:
##
@@ -197,4 +201,21 @@ else if (session.itemExists(path)) {
return item;
}
+@Nullable Node getParentOrNull(@NotNull Item child, @NotNull String
parentPath) {
+Node parent = null;
+try {
+// Use fast getParentOrNull if session is a JackrabbitSession
+if (this.isJackrabbit) {
+parent = ((JackrabbitSession) session).getParentOrNull(child);
+} else if (session.nodeExists(parentPath)) {
+// Fallback to slower nodeExists & getNode pattern
+parent = session.getNode(parentPath);
+}
+} catch (RepositoryException e) {
+log.debug("Unable to access node at " + parentPath + ", possibly
invalid path", e);
Review Comment:
could this also be because of access control? Would it make sense to mention
it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122207658 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-resource=23) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-resource=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [52.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-resource=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-10011) Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532899#comment-17532899
]
Angela Schreiber edited comment on SLING-10011 at 5/10/22 10:25 AM:
[~joerghoh], [~cziegeler], since Oak 1.42.0 has been released in the mean time
i think we should pick up this improvement in Sling again.
i just looked at a thread dump provided by [~rma61...@adobe.com] and spotted
the getParent call which ended up in loading permission entries.
initial draft at
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23
was (Author: anchela):
[~joerghoh], [~cziegeler], since Oak 1.42.0 has been released in the mean time
i think we should pick up this improvement in Sling again.
i just looked at a thread dump provided by [~rma61...@adobe.com] and spotted
the getParent call which ended up in loading permission entries.
> Use JackrabbitSession.getParentOrNull when resolving parent JCR node in
> JcrResourceProvider#getParent
> -
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #23: SLING-10011 : Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParen
anchela commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1122205888 @cziegeler , @joerghoh , picking up SLING-10011 since the oak improvement is now officially released. we might need to add some extra checks if _JackrabbitSession.getParentOrNull_ is available though... i didn't add that in a first step. but i am aware that this kind of checks is done in other parts of Sling. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10011) Use JackrabbitSession.getParentOrNull when resolving parent JCR node in JcrResourceProvider#getParent
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10011:
-
Summary: Use JackrabbitSession.getParentOrNull when resolving parent JCR
node in JcrResourceProvider#getParent (was: Use javax.jcr.Item.getParent()
when resolving parent JCR node in JcrResourceProvider#getParent)
> Use JackrabbitSession.getParentOrNull when resolving parent JCR node in
> JcrResourceProvider#getParent
> -
>
> Key: SLING-10011
> URL: https://issues.apache.org/jira/browse/SLING-10011
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Miroslav Smiljanic
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently
> [JcrResourceProvider.getParent|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/org.apache.sling.jcr.resource-3.0.22/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java#L361]
> is using JcrItemResourceFactory.getItemOrNull(String path), which eventually
> is using JCR session to retrieve parent node using absolute path.
> I propose using javax.jcr.Item.getParent() instead.
> Reasoning wold be to utilise potential improvements in JCR implementation
> that would for a given node retrieve the whole subtree. That can be
> configured for example by using particular node type or node path.
> {noformat}
> root
> |
> a
>/ \
> b c
> {noformat}
> If node 'a' in picture above, is matching desired configuration, then code
> below would return the whole subtree.
> {code:java}
> Node a = jcrSession.getNode("a");
> {code}
> That further means retrieved subtree can be traversed in memory, without the
> need to communicate with the JCR repository storage.
> (!)That is particularly important when remote (cloud) storage is used for
> repository in JCR implementation, and tree traversal can be done without
> doing additional network roundtrips.
> {code:java}
> //JCR tree traversal happens in memory
> Node b = a.getNode("b");
> Node c = a.getNode("c");
> {code}
> Also going from child to parent, is resolved in memory as well (proposal
> relates to this fact)
> {code:java}
> //JCR tree traversal happens in memory
> assert b.getParent() == c.getParent();
> {code}
> Jackrabbit Oak, for document node store is supporting node bundling for
> configured node type
> [http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html]
> Currently I am also doing some experiments to support node
> bundling/aggregation for arbitrary node store
> ([NodeDelegateFullyLoaded|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/NodeDelegateFullyLoaded.java],
>
> [FullyLoadedTree|https://github.com/smiroslav/jackrabbit-oak/blob/ppnextgen_newstore/oak-core/src/main/java/org/apache/jackrabbit/oak/core/FullyLoadedTree.java]).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #26: SLING-11293 improve handling of autocreated properties
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/26#issuecomment-1122032051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=26) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=26=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_coverage=list) [89.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=26=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-11181) Emit metrics that distinguish transient and permanent distribution failures
[
https://issues.apache.org/jira/browse/SLING-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret closed SLING-11181.
--
> Emit metrics that distinguish transient and permanent distribution failures
> ---
>
> Key: SLING-11181
> URL: https://issues.apache.org/jira/browse/SLING-11181
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
>Reporter: José Correia
>Assignee: José Correia
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.26
>
>
> h3. Context
> Currently, our error metrics don't distinguish between distribution failures
> that are permanent and will fail even if retried, or failures that succeed
> after being retried.
> We want to improve this in order to be able to differentiate both scenarios.
> h3. Solution
> Failure metric should be labeled by:
> * {{Transient failure}}
> * {{Permanent failure}}
> h3. Proposed approach
> We can distinguish both these scenarios by using the following rationale:
> * Transient failures happen whenever a package is distributed successfully
> but had more than 1 attempt at being distributed: {{retries > 0}}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SLING-11157) Emit content distribution metrics per action type
[
https://issues.apache.org/jira/browse/SLING-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret closed SLING-11157.
--
> Emit content distribution metrics per action type
> -
>
> Key: SLING-11157
> URL: https://issues.apache.org/jira/browse/SLING-11157
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
>Reporter: José Correia
>Assignee: José Correia
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.26
>
>
> This change is related to the addition of the new {{INVALIDATE}} action to
> create cache invalidation distribution requests, as described in:
> * https://issues.apache.org/jira/browse/SLING-10585
>
> We want to improve the observability of the content distribution requests by
> emitting metrics per action type, which can have the following values:
> * {{ADD}}
> * {{DELETE}}
> * {{INVALIDATE}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
