date:20220512

[jira] [Commented] (SLING-11317) Rewriter configuration gets "lost" in ProcessorManagerImpl when package with another configuration gets deployed

2022-05-12 Thread Martin Schulze (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536434#comment-17536434
 ] 

Martin Schulze commented on SLING-11317:


[~kwin] I will provide a PR.

> Rewriter configuration gets "lost" in ProcessorManagerImpl when package with 
> another configuration gets deployed
> 
>
> Key: SLING-11317
> URL: https://issues.apache.org/jira/browse/SLING-11317
> Project: Sling
>  Issue Type: Bug
>Reporter: Martin Schulze
>Priority: Major
>
> On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
> happened with this class since this version) we have multiple rewriter 
> configurations and sometimes after a deployment of another package with a 
> rewriter configuration, a configurations is not triggered anymore and the 
> instance has to be restarted to get it working again.
> I've tracked the issue down and found the issue lies in the 
> {{ProcessorManagerImpl}} [0]. There are two fields, {{processors}} and 
> {{orderedProcessor}}, which are supposed to be mostly (inactive configs are 
> not in the {{orderedProcessors}}) "in sync", which is important because later 
> on there is an {{updateProcessor}} method [2], where the updated config has 
> to be found in the {{processors}} field, but they diverge from the start, in 
> the addProcessor [1] method, the added config never reaches the 
> {{processors}} field, because the newConfigs local variable never gets added 
> to the processors field. This lead to the issue, that in the updateProcessor 
> method, which gets triggered through the ResourceChangeListener, a 
> configuration gets wrongfully deleted [3].
> [0] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
> [1] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L240
> [2] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L299
> [3] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L378



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Re: [VOTE] Release Apache Sling JCR Oak Server 1.3.0

2022-05-12 Thread Carsten Ziegeler


+1

Carsten

Am 12.05.2022 um 23:01 schrieb Oliver Lietz:

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12349308

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2637

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2637 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.






--
Carsten Ziegeler
Adobe
cziege...@apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #256 is FIXED

2022-05-12 Thread Apache Jenkins Server

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/256/
 for details.

No further emails will be sent until the status of the build is changed.

[VOTE] Release Apache Sling JCR Oak Server 1.3.0

2022-05-12 Thread Oliver Lietz

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12349308

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2637

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2637 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2022-05-12 Thread Oliver Lietz (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536305#comment-17536305
 ] 

Oliver Lietz commented on SLING-8309:
-

No activity for quite a while, closing soon.

> Allow adding CommitHooks and EditorProviders dynamically from bundles
> -
>
> Key: SLING-8309
> URL: https://issues.apache.org/jira/browse/SLING-8309
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Sergiu Dumitriu
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, {{OakSlingRepositoryManager}} uses a hard-coded list of 
> {{CommitHook}} and {{EditorProvider}} to be used by the Oak repository. This 
> means that other than building a patched version of 
> {{OakSlingRepositoryManager}} there's no way to include a new commit 
> observer. Ideally, a single pseudo-\{{CommitHook}} and 
> pseudo-\{{EditorProvider}} should be handled to Oak, and these should just 
> dynamically aggregate all the {{CommitHook}} and {{EditorProvider}} instances 
> registered in the {{Whiteboard}}.
> All the currently hardcoded components are already available in the 
> whiteboard, so no functionality will be lost, but this change will 
> automatically enable support for {{mix:atomicCounter}} via the 
> {{AtomicCounterEditorProvider}} that's not used at the moment.
> The old behavior should still be available via a new configuration, 
> {{OakSlingRepositoryManagerConfiguration#dynamic_components}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Re: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.0

2022-05-12 Thread Nicolas Peltier

+1

Le jeu. 12 mai 2022 à 14:22,  a écrit :

> +1
>
> David
>
> On Thu, 12 May 2022 at 13:15, Stefan Seifert
>  wrote:
>
> > +1
> >
>

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1125260828

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-event-api] rombert merged pull request #2: SLING-11316: Update to parent 47

2022-05-12 Thread GitBox



rombert merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-event-api/pull/2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-11316) Update sling.event.api to parent 47

2022-05-12 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-11316.
-
Resolution: Fixed

Thanks for the contribution [~ashokmc...@gmail.com]!

> Update sling.event.api to parent 47
> ---
>
> Key: SLING-11316
> URL: https://issues.apache.org/jira/browse/SLING-11316
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Event API 1.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Assigned] (SLING-11316) Update sling.event.api to parent 47

2022-05-12 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-11316:
---

Assignee: Robert Munteanu

> Update sling.event.api to parent 47
> ---
>
> Key: SLING-11316
> URL: https://issues.apache.org/jira/browse/SLING-11316
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Event API 1.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Assigned] (SLING-11306) Update Sling JCR WebDAV to parent 47

2022-05-12 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-11306:
---

Assignee: Robert Munteanu

> Update Sling JCR WebDAV to parent 47
> 
>
> Key: SLING-11306
> URL: https://issues.apache.org/jira/browse/SLING-11306
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Webdav 2.3.10
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Assigned] (SLING-11304) update sling-extensions-slf4j-mdc to parent 47

2022-05-12 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-11304:
---

Assignee: Robert Munteanu

> update sling-extensions-slf4j-mdc to parent 47
> --
>
> Key: SLING-11304
> URL: https://issues.apache.org/jira/browse/SLING-11304
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: SLF4J MDC Filter 1.0.2
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Resolved] (SLING-11304) update sling-extensions-slf4j-mdc to parent 47

2022-05-12 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-11304.
-
Resolution: Fixed

PR merged, thanks a lot [~ashokmc...@gmail.com]!

> update sling-extensions-slf4j-mdc to parent 47
> --
>
> Key: SLING-11304
> URL: https://issues.apache.org/jira/browse/SLING-11304
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: SLF4J MDC Filter 1.0.2
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] rombert merged pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



rombert merged PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] rombert commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



rombert commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871477161


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   > Why would we want to support people in using an ancient Tika version with 
known security vulnerabilities?
   
   As I've said before, this is not our call. We should not dictate what 
versions customers use, they should be able to make informed decisions. This is 
more or less a rehash of the arguments we had for dependabot - 
https://cwiki.apache.org/confluence/display/SLING/Dependabot . We don't make 
blanket updates to the latest versions, we let our users decide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] kwin commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



kwin commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871475316


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   Because people may want to run with an ancient Tika.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871442033


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   Why would we want to support people in using an ancient Tika version with 
known security vulnerabilities?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] rombert commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



rombert commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871438723


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   I would say that in this case updating the JCR WebDAV bundle is feasible 
precisely because it frictionless - no new requirements. And I think the 
example is the right one to give - OSGi allows decoupling build-time from 
run-time dependencies. Let's not throw that away because we think we may get 
people who copy-paste and don't check in trouble.
   
   At the same time, here is the list of changes to the manifest, generated 
using `bnd diff`
   
   ```
   bnd diff --manifest org.apache.sling.jcr.webdav-2.3.9-SNAPSHOT.jar 
target/org.apache.sling.jcr.webdav-2.3.9-SNAPSHOT.jar
   CHANGEDMANIFEST   
CHANGEDHEADER Export-Package
 ADDED  CLAUSE org.apache.jackrabbit.server
 CHANGEDCLAUSE org.apache.jackrabbit.server.io
  REMOVEDPARAMETER  version:2.14.3
  ADDED  PARAMETER  version:2.20.4
CHANGEDHEADER Import-Package
 ADDED  CLAUSE java.time.format
 ADDED  CLAUSE org.apache.jackrabbit.server
 CHANGEDCLAUSE org.apache.jackrabbit.util
  REMOVEDPARAMETER  version:[2.4,3)
  ADDED  PARAMETER  version:[2.5,3)
 CHANGEDCLAUSE org.apache.jackrabbit.webdav
  REMOVEDPARAMETER  version:[1.1,2)
  ADDED  PARAMETER  version:[1.4,2)
 CHANGEDCLAUSE org.apache.jackrabbit.webdav.server
  REMOVEDPARAMETER  version:[1.0,2)
  ADDED  PARAMETER  version:[1.2,2)
 CHANGEDCLAUSE org.apache.jackrabbit.webdav.util
  REMOVEDPARAMETER  version:[1.0,2)
  ADDED  PARAMETER  version:[1.1,2)
 CHANGEDCLAUSE org.apache.jackrabbit.webdav.version.report
  REMOVEDPARAMETER  version:[1.0,2)
  ADDED  PARAMETER  version:[1.1,2)
 CHANGEDCLAUSE org.apache.jackrabbit.webdav.xml
  REMOVEDPARAMETER  version:[1.1,2)
  ADDED  PARAMETER  version:[1.2,2)
 CHANGEDCLAUSE org.apache.tika.detect
  REMOVEDPARAMETER  version:[1.0,2)
  ADDED  PARAMETER  version:[1.27,2)
 CHANGEDCLAUSE org.apache.tika.metadata
  REMOVEDPARAMETER  version:[1.0,2)
  ADDED  PARAMETER  version:[1.27,2)
 CHANGEDCLAUSE org.apache.tika.mime
  REMOVEDPARAMETER  version:[1.2,2)
  ADDED  PARAMETER  version:[1.27,2)
REMOVEDHEADER 
Private-Package:org.apache.jackrabbit.server,org.apache.jackrabbit.webdav.simple,org.apache.sling.jcr.webdav.impl.handler,org.apache.sling.jcr.webdav.impl.helper,org.apache.sling.jcr.webdav.impl.servlets,org.apache.jackrabbit.webdav.jcr,org.apache.jackrabbit.webdav.jcr.lock
ADDED  HEADER 
Private-Package:org.apache.jackrabbit.webdav.simple,org.apache.sling.jcr.webdav.impl.handler,org.apache.sling.jcr.webdav.impl.helper,org.apache.sling.jcr.webdav.impl.servlets,org.apache.jackrabbit.webdav.jcr,org.apache.jackrabbit.webdav.jcr.lock
   ```
   
   I find it misleading to say, for instance, "we require Tika 1.27 or newer", 
when we know that we can work with Tika 1.0 or newer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] ashokmca07 commented on a diff in pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



ashokmca07 commented on code in PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#discussion_r871401212


##
src/test/java/org/apache/sling/extensions/mdc/integration/ServerConfiguration.java:
##
@@ -1,129 +0,0 @@
-/*

Review Comment:
   @rombert I just added 
[description](https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#issue-1226664932)
 
   
   `ServerConfiguration.java` was removed since its manual options to setup pax 
exam IT and its no longer required (because `org.apache.sling.testing.paxexam` 
comes with default options)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871391188


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   And in this case updating the SLING JCR WebDAV bundle *is* feasible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Should Sling refuse to register multiple servlets with the same mount parameters?

2022-05-12 Thread Carsten Ziegeler

Thanks and no worries :)

Carsten

Am 12.05.2022 um 15:29 schrieb Konrad Windszus:

Sorry for the confusion, my reply was referring to Bertrands mail
(https://lists.apache.org/thread/45pm1vdokrdgdcdghxrfosfv516xs7f9)

"I'd like us to reject cases where it's the Service ID that defines behavior,
or at least log a warning if they happen.”

Konrad

On 11. May 2022, at 19:10, Carsten Ziegeler wrote:

? not sure what you mean. I agreed to use service ranking, and service ranking
is the whole mechanism including what happens if that property is not
specified. ServiceReference has a compareTo method that does all of that.

Carsten

Am 11.05.2022 um 17:37 schrieb Konrad Windszus:

Why doing it differently than for any other OSGi service?
Although the service ID is not predictable in general older services beat newer
services, which is IMHO good enough.
I am fine with issuing a warn (if easy to implement) but I am against rejecting
for consistency reasons.
Konrad

On 11. May 2022, at 17:22, Carsten Ziegeler wrote:

+1 to what Konrad said.

Service ranking is more predictable than just using the "first"

Regards
Carsten

Am 11.05.2022 um 17:18 schrieb Konrad Windszus:

IMHO the regular OSGi semantics should apply here as well, i.e. higher service
ranking wins (if tie lower bundle id wins). That is also documented at
https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-resolution-order

In any case this should only be the last criteria if selectors, extensions and
method are the same for more then one servlet resolution candidate.
Throwing an exception/refusing to register the servlet is wrong and would be a
regression.
Konrad

On 11. May 2022, at 17:14, Bertrand Delacretaz wrote:

Hi,

I forgot if we discussed this already, if that's the case pointers are welcome.

Adrian Kozma created SLING-11315 about this, and I tentatively added a
new test [1] to explore the current behavior.

It looks like the first registered servlet wins, but that might be
just by chance.

Do people agree that Sling should refuse to register servlets that
have the same set of mount parameters as existing ones?

I think that would help avoid difficult to troubleshoot situations.

-Bertrand

[1]
https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/1603a0ecb2ab8b4395560c0d53d9e5569b68a568

--
Carsten Ziegeler
Adobe
cziege...@apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] kwin commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



kwin commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871386369


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   > IMHO there's absolutely no benefit in being relaxed here
   
   There is a benefit for users not wanting to update to a newer (less 
vulnerable) JR version but want to use a newer SLING JCR WebDAV bundle (for 
whatever reason). Think about EOL products where upgrading the JCR 
implementation is not feasible ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Should Sling refuse to register multiple servlets with the same mount parameters?

2022-05-12 Thread Konrad Windszus

Sorry for the confusion, my reply was referring to Bertrands mail 
(https://lists.apache.org/thread/45pm1vdokrdgdcdghxrfosfv516xs7f9)

"I'd like us to reject cases where it's the Service ID that defines behavior, 
or at least log a warning if they happen.”

Konrad

> On 11. May 2022, at 19:10, Carsten Ziegeler  wrote:
> 
> ? not sure what you mean. I agreed to use service ranking, and service 
> ranking is the whole mechanism including what happens if that property is not 
> specified. ServiceReference has a compareTo method that does all of that.
> 
> Carsten
> 
> Am 11.05.2022 um 17:37 schrieb Konrad Windszus:
>> Why doing it differently than for any other OSGi service?
>> Although the service ID is not predictable in general older services beat 
>> newer services, which is IMHO good enough.
>> I am fine with issuing a warn (if easy to implement) but I am against 
>> rejecting for consistency reasons.
>> Konrad
>>> On 11. May 2022, at 17:22, Carsten Ziegeler  wrote:
>>> 
>>> +1 to what Konrad said.
>>> 
>>> Service ranking is more predictable than just using the "first"
>>> 
>>> Regards
>>> Carsten
>>> 
>>> Am 11.05.2022 um 17:18 schrieb Konrad Windszus:
 IMHO the regular OSGi semantics should apply here as well, i.e. higher 
 service ranking wins (if tie lower bundle id wins). That is also 
 documented at 
 https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-resolution-order
  
 
 In any case this should only be the last criteria if selectors, extensions 
 and method are the same for more then one servlet resolution candidate.
 Throwing an exception/refusing to register the servlet is wrong and would 
 be a regression.
 Konrad
> On 11. May 2022, at 17:14, Bertrand Delacretaz  
> wrote:
> 
> Hi,
> 
> I forgot if we discussed this already, if that's the case pointers are 
> welcome.
> 
> Adrian Kozma created SLING-11315 about this, and I tentatively added a
> new test [1] to explore the current behavior.
> 
> It looks like the first registered servlet wins, but that might be
> just by chance.
> 
> Do people agree that Sling should refuse to register servlets that
> have the same set of mount parameters as existing ones?
> 
> I think that would help avoid difficult to troubleshoot situations.
> 
> -Bertrand
> 
> [1] 
> https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/1603a0ecb2ab8b4395560c0d53d9e5569b68a568
>>> 
>>> -- 
>>> Carsten Ziegeler
>>> Adobe
>>> cziege...@apache.org
> 
> -- 
> Carsten Ziegeler
> Adobe
> cziege...@apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871381196


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   Exactly. So this project is ignoring these informations. It may be harmless 
here, but is not harmless in general. IMHO there's absolutely no benefit in 
being relaxed here; it's just giving users a bad example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] kwin commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



kwin commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871379106


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   By documenting supported versions (like in 
https://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html) and doing 
announcements on the. mailing list. Both is properly done in this case :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871350272


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   With 2.16.9:
   
   ~~~
   One or more dependencies were identified with known vulnerabilities in 
Apache Sling JCR WebDAV:
   
   org.apache.sling.api-2.0.8.jar 
(pkg:maven/org.apache.sling/org.apache.sling.api@2.0.8, 
cpe:2.3:a:apache:sling:2.0.8:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.8:*:*:*:*:*:*:*) : CVE-2015-2944
   org.apache.sling.auth.core-1.0.0.jar 
(pkg:maven/org.apache.sling/org.apache.sling.auth.core@1.0.0, 
cpe:2.3:a:apache:sling_auth_core_component:1.0.0:*:*:*:*:*:*:*) : CVE-2013-4390
   org.apache.sling.jcr.api-2.0.6.jar 
(pkg:maven/org.apache.sling/org.apache.sling.jcr.api@2.0.6, 
cpe:2.3:a:apache:sling:2.0.6:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.6:*:*:*:*:*:*:*) : CVE-2015-2944
   ~~~
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871364346


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   > (that is obligation of Jackrabbit)
   
   How so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] kwin commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



kwin commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871362405


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   > My point being: by referencing thes obsolete versions we encourage users 
just to copy/paste the version numbers into their projects. Not good.
   
   I disagree here. Remember this is only a support bundle. IMHO no one will 
ever look into this pom to install the same JR version in his OSGi container.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871359259


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   My point being: by referencing these obsolete versions we encourage users 
just to copy/paste the version numbers into their projects. Not good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] kwin commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



kwin commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871359889


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   IMHO that doesn’t matter as long as we don’t embed the vulnerable 
dependency. Sling in general recommends using the latest/greatest but does not 
force to (that is obligation of Jackrabbit). We only depend on the oldest 
dependency providing the necessary/used API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871359259


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   My point being: by referencing thes obsolete versions we encourage users 
just to copy/paste the version numbers into their projects. Not good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] sonarcloud[bot] commented on pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#issuecomment-1124972348

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] ashokmca07 commented on a diff in pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



ashokmca07 commented on code in PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#discussion_r871356128


##
pom.xml:
##
@@ -41,116 +40,47 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-extensions-slf4j-mdc.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-extensions-slf4j-mdc.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-extensions-slf4j-mdc.git
+HEAD
   
 
 
-  3.0.0
-  
-${basedir}/target
-  
-  
-${bundle.build.name}/${project.build.finalName}.jar
-  
+  8
+  1
+  4.13.3
 
 
   
 
   
-org.apache.felix
-maven-bundle-plugin
-true
-
-  
-
-  
org.apache.sling.commons.osgi;inline=org/apache/sling/commons/osgi/PropertiesUtil.class
-
-  
-
-  
-  
-org.apache.felix
-maven-scr-plugin
-1.26.4
-  
-
-  
-
-  
-org.codehaus.mojo
-build-helper-maven-plugin
-1.8
-
-  
-reserve-network-port
-
-  reserve-network-port
-
-pre-integration-test
-
-  
-http.port
-  
-
-  
-
-  
-  
-org.codehaus.mojo
-properties-maven-plugin
-1.0-alpha-2
-
-  
-
-  set-system-properties
-
-pre-integration-test
-
-  
-
-  project.bundle.file
-  ${bundle.file.name}
-
-
-  http.port
-  ${http.port}
-
-  
-
-  
-
+biz.aQute.bnd
+bnd-maven-plugin
   
   
 org.apache.servicemix.tooling
 depends-maven-plugin
-1.2
-
-  
-generate-depends-file
-
-  generate-depends-file
-
-  
-
   
+  

Review Comment:
   My bad, yes just confirmed its inherited from parent ✅ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] ashokmca07 commented on a diff in pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



ashokmca07 commented on code in PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#discussion_r871355407


##
bnd.bnd:
##
@@ -0,0 +1,6 @@
+-includeresource:\

Review Comment:
   Just to keep the same headers like old bundle, but yes no longer required 
this header. removed ✅ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871350272


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   With 2.16.9:
   
   ~~~
   [WARNING]
   
   One or more dependencies were identified with known vulnerabilities in 
Apache Sling JCR WebDAV:
   
   org.apache.sling.api-2.0.8.jar 
(pkg:maven/org.apache.sling/org.apache.sling.api@2.0.8, 
cpe:2.3:a:apache:sling:2.0.8:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.8:*:*:*:*:*:*:*) : CVE-2015-2944
   org.apache.sling.auth.core-1.0.0.jar 
(pkg:maven/org.apache.sling/org.apache.sling.auth.core@1.0.0, 
cpe:2.3:a:apache:sling_auth_core_component:1.0.0:*:*:*:*:*:*:*) : CVE-2013-4390
   org.apache.sling.jcr.api-2.0.6.jar 
(pkg:maven/org.apache.sling/org.apache.sling.jcr.api@2.0.6, 
cpe:2.3:a:apache:sling:2.0.6:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.6:*:*:*:*:*:*:*) : CVE-2015-2944
   ~~~
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871347802


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   ~~~
   One or more dependencies were identified with known vulnerabilities in 
Apache Sling JCR WebDAV:
   
   commons-fileupload-1.2.1.jar 
(pkg:maven/commons-fileupload/commons-fileupload@1.2.1, 
cpe:2.3:a:apache:commons_fileupload:1.2.1:*:*:*:*:*:*:*) : Arbitrary file 
upload via deserialization, CVE-2013-0248, CVE-2014
   -0050, CVE-2016-131, CVE-2016-3092
   commons-httpclient-3.1.jar 
(pkg:maven/commons-httpclient/commons-httpclient@3.1, 
cpe:2.3:a:apache:commons-httpclient:3.1:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:httpclient:3.1:*:*:*:*:*:*:*) : CVE-2012-5783, CVE-2020-1
   3956
   guava-15.0.jar (pkg:maven/com.google.guava/guava@15.0, 
cpe:2.3:a:google:guava:15.0:*:*:*:*:*:*:*) : CVE-2018-10237, CVE-2020-8908
   httpclient-4.5.3.jar (pkg:maven/org.apache.httpcomponents/httpclient@4.5.3, 
cpe:2.3:a:apache:httpclient:4.5.3:*:*:*:*:*:*:*) : CVE-2020-13956
   org.apache.sling.api-2.0.8.jar 
(pkg:maven/org.apache.sling/org.apache.sling.api@2.0.8, 
cpe:2.3:a:apache:sling:2.0.8:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.8:*:*:*:*:*:*:*) : CVE-2015-2944
   org.apache.sling.auth.core-1.0.0.jar 
(pkg:maven/org.apache.sling/org.apache.sling.auth.core@1.0.0, 
cpe:2.3:a:apache:sling_auth_core_component:1.0.0:*:*:*:*:*:*:*) : CVE-2013-4390
   org.apache.sling.jcr.api-2.0.6.jar 
(pkg:maven/org.apache.sling/org.apache.sling.jcr.api@2.0.6, 
cpe:2.3:a:apache:sling:2.0.6:*:*:*:*:*:*:*, 
cpe:2.3:a:apache:sling_api:2.0.6:*:*:*:*:*:*:*) : CVE-2015-2944
   tika-core-1.7.jar (pkg:maven/org.apache.tika/tika-core@1.7, 
cpe:2.3:a:apache:tika:1.7:*:*:*:*:*:*:*) : CVE-2016-6809, CVE-2018-11761, 
CVE-2018-11762, CVE-2018-11796, CVE-2018-1335, CVE-2018-1338, CVE-2018-1339,
CVE-2018-8017, CVE-2019-10088, CVE-2019-10094, CVE-2020-1950, 
CVE-2020-1951, CVE-2021-28657
   ~~~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #2: SLING-11316: Update to parent 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-event-api/pull/2#issuecomment-1124959010

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event-api=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871341109


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   But is that a reason to reference a version that has been obsolete for 
several years, and which will not see any security updates anymore?
   
   I *could* understand if the choice was the latest release from the oldest 
stable branch (which would be 2.16.9).
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] rombert commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



rombert commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871336068


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   > I just don't get what the reasoning here is
   
   The reasoning is that we should not force people deploying Sling apps to 
upgrade libraries if they don't have/want to. I went into a bit more detail in 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871292082
 .
   
   Which parts of this do you disagree with? And what negative impact do you 
see when using this particular version of the Jackrabbit libraries?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.0

2022-05-12 Thread davidb

+1

David

On Thu, 12 May 2022 at 13:15, Stefan Seifert
 wrote:

> +1
>

[GitHub] [sling-org-apache-sling-jcr-webdav] ashokmca07 commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



ashokmca07 commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871305558


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   I am fine with older versions as long as its working fine and compiles. I 
just reverted to `2.14.3` 
   
   PS: @rombert just upgraded the version from 2.14.2 to `2.14.3` because of 
the known issue  `org.apache.jackrabbit.vault.fs.api.RepositoryFactory is not 
an ImageIO SPI class` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.0

2022-05-12 Thread Stefan Seifert

+1

[GitHub] [sling-org-apache-sling-jcr-webdav] reschke commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



reschke commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871304849


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   I just don't get what the reasoning here is. *Nobody* should be referring to 
a version that had at least 7 bug fix releases since.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] sonarcloud[bot] commented on pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#issuecomment-1124913682

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-webdav=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
   
   
[![92.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'92.9%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_coverage=list)
 [92.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] rombert commented on a diff in pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



rombert commented on code in PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#discussion_r871294326


##
pom.xml:
##
@@ -41,116 +40,47 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-extensions-slf4j-mdc.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-extensions-slf4j-mdc.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-extensions-slf4j-mdc.git
+HEAD
   
 
 
-  3.0.0
-  
-${basedir}/target
-  
-  
-${bundle.build.name}/${project.build.finalName}.jar
-  
+  8
+  1
+  4.13.3
 
 
   
 
   
-org.apache.felix
-maven-bundle-plugin
-true
-
-  
-
-  
org.apache.sling.commons.osgi;inline=org/apache/sling/commons/osgi/PropertiesUtil.class
-
-  
-
-  
-  
-org.apache.felix
-maven-scr-plugin
-1.26.4
-  
-
-  
-
-  
-org.codehaus.mojo
-build-helper-maven-plugin
-1.8
-
-  
-reserve-network-port
-
-  reserve-network-port
-
-pre-integration-test
-
-  
-http.port
-  
-
-  
-
-  
-  
-org.codehaus.mojo
-properties-maven-plugin
-1.0-alpha-2
-
-  
-
-  set-system-properties
-
-pre-integration-test
-
-  
-
-  project.bundle.file
-  ${bundle.file.name}
-
-
-  http.port
-  ${http.port}
-
-  
-
-  
-
+biz.aQute.bnd
+bnd-maven-plugin
   
   
 org.apache.servicemix.tooling
 depends-maven-plugin
-1.2
-
-  
-generate-depends-file
-
-  generate-depends-file
-
-  
-
   
+  

Review Comment:
   Can this be removed? It should be inherited from the parent pom.



##
src/test/java/org/apache/sling/extensions/mdc/integration/ServerConfiguration.java:
##
@@ -1,129 +0,0 @@
-/*

Review Comment:
   Can you briefly explain why you have removed this class? I'd like to add it 
to the commit message when I merge the PR.



##
bnd.bnd:
##
@@ -0,0 +1,2 @@
+-removeheaders:\

Review Comment:
   Is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] rombert commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



rombert commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871292082


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   I was probably the one talking about using versions that are as old possible 
:-)
   
   The long-standing policy that we have is to use old versions so that OSGi 
imports are as relaxed as possible. Of course, deployers should follow good 
practices and use the latest version of libraries. This is what we do in the 
Sling Starter where we use the latest Jackrabbit and Oak artifacts.
   
   I'd suggest that we leave the jackrabbit version untouched here, since 
upgrading the parent version does require it Would that work for you @reschke 
@ashokmca07 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #255 is BROKEN

2022-05-12 Thread Apache Jenkins Server

erence 1153 from bundle 112 : 
org.apache.sling.jcr.davex:1.3.10 ref=[javax.servlet.Servlet] 
properties={objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=DavExAuthHttpContext),
 osgi.http.whiteboard.servlet.pattern=/server/*, service.bundleid=112, 
service.description=Sling JcrRemoting Servlet, service.id=1153, 
service.scope=singleton, service.vendor=The Apache Software Foundation, 
servlet.init.createAbsoluteURI=true, servlet.init.csrf-protection=disabled, 
servlet.init.protectedhandlers-config=org.apache.jackrabbit.server.remoting.davex.AclRemoveHandler,
 servlet.init.resource-path-prefix=/server, sling.auth.requirements=-/server}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 471 from bundle 129 : org.apache.sling.engine:2.9.0 
ref=[javax.servlet.Filter] properties={component.id=160, 
component.name=org.apache.sling.engine.impl.log.RequestLoggerFilter, 
objectClass=[javax.servlet.Filter], 
osgi.ds.satisfying.condition.target=(osgi.condition.id=true), 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], service.bundleid=129, 
service.description=Request Logger Filter, service.id=471, 
service.ranking=32768, service.scope=bundle, service.vendor=The Apache Software 
Foundation}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 456 from bundle 129 : org.apache.sling.engine:2.9.0 
ref=[javax.servlet.Servlet] properties={objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.name=ApacheSling/2.9, 
osgi.http.whiteboard.servlet.pattern=/, service.bundleid=129, 
service.description=Apache Sling Engine Main Servlet, service.id=456, 
service.scope=singleton, service.vendor=The Apache Software Foundation}] 
Ignoring unmatching Servlet service
[DEBUG] [ServiceReference 472 from bundle 129 : org.apache.sling.engine:2.9.0 
ref=[javax.servlet.Filter] properties={component.id=161, 
component.name=org.apache.sling.engine.parameters, file.max=-1, 
file.threshold=256000, objectClass=[javax.servlet.Filter], 
osgi.ds.satisfying.condition.target=(osgi.condition.id=true), 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], request.max=-1, service.bundleid=129, 
service.description=Filter for request parameter support, service.id=472, 
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache 
Software Foundation, sling.default.max.parameters=1, 
sling.default.parameter.checkForAdditionalContainerParameters=false, 
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO] 
[INFO] --- tools-maven-plugin:1.4:verify-legal-files (verify-legal-files) @ 
org.apache.sling.starter ---
[INFO] Checking legal files in: org.apache.sling.starter-13-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.starter-13-SNAPSHOT-oak_tar_far.far
[INFO] Checking legal files in: 
org.apache.sling.starter-13-SNAPSHOT-oak_mongo_far.far
[INFO] Checking legal files in: org.apache.sling.starter-13-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @ org.apache.sling.starter 
---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 
/home/jenkins/workspace/_org-apache-sling-starter_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 79 implicit excludes (use -debug for more details).
[INFO] 15 explicit excludes (use -debug for more details).
[INFO] 21 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 20 licenses.
[INFO] 
[INFO] --- docker-maven-plugin:0.39.0:stop (stop-mongo) @ 
org.apache.sling.starter ---
[INFO] DOCKER> [apache/sling:snapshot]: Stop and removed container 2da593ce0a84 
after 0 ms
[INFO] DOCKER> [mongo:4.4.6] "mongo": Stop and removed container a315a13787e2 
after 0 ms
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M5:verify (default) @ 
org.apache.sling.starter ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  07:06 min
[INFO] Finished at: 2022-05-12T11:38:10Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMavenff5d92aa/maven-spy-20220512-113103-5071139391147996353845.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-M5:verify (default) on 
project org.apache.sling.starter: There are test failures.
[ERR

[GitHub] [sling-org-apache-sling-event-api] ashokmca07 commented on pull request #2: SLING-11316: Update to parent 47

2022-05-12 Thread GitBox



ashokmca07 commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-event-api/pull/2#issuecomment-1124875679

   Tested successfully with [sling 
event](https://github.com/apache/sling-org-apache-sling-event/blob/343c14bb1978ccaa08c2ef5df634577f355d/bnd.bnd#L22)
 ✅ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.0

2022-05-12 Thread Karl Pauls

+1

regards,

Karl

On Thursday, May 12, 2022, Carsten Ziegeler  wrote:

> +1
>
> Carsten
>
> Am 11.05.2022 um 16:58 schrieb Carsten Ziegeler:
>
>> Hi,
>>
>> we solved 4 issues in this release:
>> https://issues.apache.org/jira/projects/SLING/versions/12351355
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2635/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.
>> git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2635 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>[ ] +1 Approve the release
>>[ ]  0 Don't care
>>[ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Regards
>> Carsten
>>
>
> --
> Carsten Ziegeler
> Adobe
> cziege...@apache.org
>


-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Updated] (SLING-11317) Rewriter configuration gets "lost" in ProcessorManagerImpl when package with another configuration gets deployed

2022-05-12 Thread Martin Schulze (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Schulze updated SLING-11317:
---
Description: 
On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
happened with this class since this version) we have multiple rewriter 
configurations and sometimes after a deployment of another package with a 
rewriter configuration, a configurations is not triggered anymore and the 
instance has to be restarted to get it working again.
I've tracked the issue down and found the issue lies in the 
{{ProcessorManagerImpl}} [0]. There are two fields, {{processors}} and 
{{orderedProcessor}}, which are supposed to be mostly (inactive configs are not 
in the {{orderedProcessors}}) "in sync", which is important because later on 
there is an {{updateProcessor}} method [2], where the updated config has to be 
found in the {{processors}} field, but they diverge from the start, in the 
addProcessor [1] method, the added config never reaches the {{processors}} 
field, because the newConfigs local variable never gets added to the processors 
field. This lead to the issue, that in the updateProcessor method, which gets 
triggered through the ResourceChangeListener, a configuration gets wrongfully 
deleted [3].

[0] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
[1] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L240
[2] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L299
[3] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L378

  was:
On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
happened with this class since this version) we have multiple rewriter 
configurations and sometimes after a deployment of another package with a 
rewriter configuration, a configurations is not triggered anymore and the 
instance has to be restarted to get it working again. I've tracked the issue 
down and found the issue lies in the {{ProcessorManagerImpl}} [0]. There are 
two fields, {{processors}} and {{orderedProcessor}}, which are supposed to be 
mostly (inactive configs are not in the {{orderedProcessors}}) "in sync", which 
is important because later on there is an {{updateProcessor}} method [2], where 
the updated config has to be found in the {{processors}} field, but they 
diverge from the start, in the addProcessor [1] method, the added config never 
reaches the {{processors}} field, because the newConfigs local variable never 
gets added to the processors field. This lead to the issue, that in the 
updateProcessor method, which gets triggered through the 
ResourceChangeListener, a configuration gets wrongfully deleted [3].

[0] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
[1] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L240
[2] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L299
[3] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L378


> Rewriter configuration gets "lost" in ProcessorManagerImpl when package with 
> another configuration gets deployed
> 
>
> Key: SLING-11317
> URL: https://issues.apache.org/jira/browse/SLING-11317
> Project: Sling
>  Issue Type: Bug
>Reporter: Martin Schulze
>Priority: Major
>
> On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
> happened with this class since this version) we have multiple rewriter 
> configurations and sometimes after a deployment of another package with a 
> rewriter configuration, a configurations is not triggered anymore and the 
> instance has to be restarted to get it working again.
> I've tracked the issue down and found the issue lies in the 
> {{ProcessorManagerImpl}} [0]. There are two fields, {{processors}} and 
> {{orderedProcessor}}, which are supposed to be mostly (inactive configs are 
> not in the {{orderedProcessors}}) "in sync", which is important because later 
> on there is an {{updateProcessor}} method [2], where the updated config has 
> to be found in the {{processors}} field, but they diverge from the start, in 
> the addProcessor [1]

[jira] [Commented] (SLING-11317) Rewriter configuration gets "lost" in ProcessorManagerImpl when package with another configuration gets deployed

2022-05-12 Thread Konrad Windszus (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536005#comment-17536005
 ] 

Konrad Windszus commented on SLING-11317:
-

[~schulm] Thanks for the report. Can you come up with a PR containing the fix 
and in the best case a test case for that behaviour?

> Rewriter configuration gets "lost" in ProcessorManagerImpl when package with 
> another configuration gets deployed
> 
>
> Key: SLING-11317
> URL: https://issues.apache.org/jira/browse/SLING-11317
> Project: Sling
>  Issue Type: Bug
>Reporter: Martin Schulze
>Priority: Major
>
> On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
> happened with this class since this version) we have multiple rewriter 
> configurations and sometimes after a deployment of another package with a 
> rewriter configuration, a configurations is not triggered anymore and the 
> instance has to be restarted to get it working again. I've tracked the issue 
> down and found the issue lies in the {{ProcessorManagerImpl}} [0]. There are 
> two fields, {{processors}} and {{orderedProcessor}}, which are supposed to be 
> mostly (inactive configs are not in the {{orderedProcessors}}) "in sync", 
> which is important because later on there is an {{updateProcessor}} method 
> [2], where the updated config has to be found in the {{processors}} field, 
> but they diverge from the start, in the addProcessor [1] method, the added 
> config never reaches the {{processors}} field, because the newConfigs local 
> variable never gets added to the processors field. This lead to the issue, 
> that in the updateProcessor method, which gets triggered through the 
> ResourceChangeListener, a configuration gets wrongfully deleted [3].
> [0] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
> [1] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L240
> [2] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L299
> [3] 
> https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L378



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Created] (SLING-11317) Rewriter configuration gets "lost" in ProcessorManagerImpl when package with another configuration gets deployed

2022-05-12 Thread Martin Schulze (Jira)

Martin Schulze created SLING-11317:
--

 Summary: Rewriter configuration gets "lost" in 
ProcessorManagerImpl when package with another configuration gets deployed
 Key: SLING-11317
 URL: https://issues.apache.org/jira/browse/SLING-11317
 Project: Sling
  Issue Type: Bug
Reporter: Martin Schulze


On our AEM 6.5 instance (org.apache.sling.rewriter-1.2.2, but nothing major 
happened with this class since this version) we have multiple rewriter 
configurations and sometimes after a deployment of another package with a 
rewriter configuration, a configurations is not triggered anymore and the 
instance has to be restarted to get it working again. I've tracked the issue 
down and found the issue lies in the {{ProcessorManagerImpl}} [0]. There are 
two fields, {{processors}} and {{orderedProcessor}}, which are supposed to be 
mostly (inactive configs are not in the {{orderedProcessors}}) "in sync", which 
is important because later on there is an {{updateProcessor}} method [2], where 
the updated config has to be found in the {{processors}} field, but they 
diverge from the start, in the addProcessor [1] method, the added config never 
reaches the {{processors}} field, because the newConfigs local variable never 
gets added to the processors field. This lead to the issue, that in the 
updateProcessor method, which gets triggered through the 
ResourceChangeListener, a configuration gets wrongfully deleted [3].

[0] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
[1] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L240
[2] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L299
[3] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/master/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L378



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [sling-org-apache-sling-event-api] sonarcloud[bot] commented on pull request #2: SLING-11316: Update to parent 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-event-api/pull/2#issuecomment-1124699802

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event-api=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event-api=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event-api=2=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event-api=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-11316) Update sling.event.api to parent 47

2022-05-12 Thread Ashok Pelluru (Jira)

Ashok Pelluru created SLING-11316:
-

 Summary: Update sling.event.api to parent 47
 Key: SLING-11316
 URL: https://issues.apache.org/jira/browse/SLING-11316
 Project: Sling
  Issue Type: Sub-task
Reporter: Ashok Pelluru
 Fix For: Event API 1.1.0






--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [sling-org-apache-sling-extensions-slf4j-mdc] sonarcloud[bot] commented on pull request #1: SLING-11304: upgrade to sling 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#issuecomment-1124616954

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-extensions-slf4j-mdc=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] ashokmca07 commented on a diff in pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



ashokmca07 commented on code in PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871010390


##
pom.xml:
##
@@ -40,46 +39,28 @@
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git
+HEAD
 
 
 
-2.14.2
+8
+1
+2.14.3

Review Comment:
   Updated to the version `2.20.4` which is same like 
`sling-org-apache-sling-starter`
   
   PS: I was thinking to use the latest version, but in past someone raised 
that we should use very least versions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-webdav] sonarcloud[bot] commented on pull request #2: SLING-11306: Update to sling 47

2022-05-12 Thread GitBox



sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#issuecomment-1124578251

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-webdav=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-webdav=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-webdav=2=false=CODE_SMELL)
   
   
[![92.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'92.9%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_coverage=list)
 [92.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-webdav=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

57 matches

Mail list logo