[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #12: SLING-10654: add support for ICU MessageFormat
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1290002463 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly=12) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=12=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly=12=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly=12=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=12=new_coverage=list) [84.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=12=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=12=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly=12=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] Buuhuu commented on pull request #12: SLING-10654: add support for ICU MessageFormat
Buuhuu commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-1289979144 Sorry for the late reply. I am +1 to going ahead and merging this. The discussion about semantic package versioning in icu did not lead to an outcome and the topic seems to be more complex than expected as they already have an established concept of maintaining their APIs. The only open question is if we should embed icu4j, provide it by another sling bundle or leave it up to the application to provide a (compatible) version. Wdyt @kwin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
[ https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623422#comment-17623422 ] Scott Yuan commented on SLING-11633: After tracing throw the source code, upgrade the maven-dependency-anlayzer to the latest version solve the issue. A single line pull request has been made in hope to help a bit. https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/2/commits/cd853a28682cf54926828153d3312b8f6035b05a > ClientSideTeleporter throwing illegal argument when target byte code is > 1.8 > - > > Key: SLING-11633 > URL: https://issues.apache.org/jira/browse/SLING-11633 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Rules > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: C:\aem-tools\utils\apache-maven-3.8.5 > Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: > C:\aem-tools\utils\jdk-11.0.15.1 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >Reporter: Scott Yuan >Priority: Trivial > Attachments: mylab.zip > > Original Estimate: 2h > Time Spent: 20m > Remaining Estimate: 1h 40m > > When attempted to use the latest 1.0.22 to build test cases using > TeleporterRule with Java 11+ code, illegal arguments error occurred. > It can be reproduce with the attached Maven project by change following > properites to 11. > * maven.compiler.source > * maven.compiler.target -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #11: SLING-11619 : safeguard backoff factors config
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1289196611 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-discovery-oak=11) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=11=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=11=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=11=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=11=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=11=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=11=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=11=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=11=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests
sonarcloud[bot] commented on PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1289184786 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss=30) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_coverage=list) [77.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11619) Restore safeguard mechanism for discovery config
[
https://issues.apache.org/jira/browse/SLING-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623237#comment-17623237
]
Stefan Egli commented on SLING-11619:
-
updated the PR and marked ready for review
> Restore safeguard mechanism for discovery config
>
>
> Key: SLING-11619
> URL: https://issues.apache.org/jira/browse/SLING-11619
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> With the [update to parent
> 47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579]
> the discovery.oak's Config "lost" the ability to gracefully deal with wrong
> values, such as empty strings. It used to silently swallow these, but now
> fails loudly with
> {noformat}
> org.osgi.service.component.ComponentException:
> java.lang.NumberFormatException: For input string: ""
> at
> org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379)
> [org.apache.felix.scr:2.2.0]
> at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source)
> at org.apache.sling.discovery.oak.Config.configure(Config.java:238)
> [org.apache.sling.discovery.oak:1.2.40]
> at org.apache.sling.discovery.oak.Config.activate(Config.java:159)
> [org.apache.sling.discovery.oak:1.2.40]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #11: SLING-11619 : safeguard backoff factors config
stefan-egli commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1289175678 Thx @ashokmca07 , I've now added a guard for all ints and long and marked the PR ready. So if you could please officially give a review that be great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Fwd: [ANNOUNCE] Changes to Jira Account Creation (issues.a.o/jira)
FYI. As a personal note, I understand where this is coming from but I think the problem is that users will just give up on creating a Jira account and Jira issues. Not sure if there is anything actionable that we can contribute, but this will definitely impact us. Thanks, Robert --- Begin Message --- Hello PMC members, As I'm sure most of you are aware, the spam issues on Jira are getting worse. We are seeing spam user creation of over 10,000 accounts per year, and receive many requests per month from project members for help addressing spam complaints. Infra is taking steps to disable public Jira signups. Infra has developed a self-service tool by which folks on a PMC can request a Jira account for non-ASF contributors: https://selfserve.apache.org/ Click "Create a Jira user account" to go to: https://selfserve.apache.org/jira-acct.html You need to enter a username for the new Jira account. We will reject the request if there is an existing account with that username. If this person may ultimately become a committer, Infra recommends that they choose a username that they can also use for their LDAP username. Next, the tool asks you to enter their Display Name. This is the "public name" which will appear on all their Jira posts and comments. Last, the tool asks you to enter the user's email address. We expect the PMC to exercise due diligence in making sure the contributor's email works. If it does not, they will not get the password reset mail. Infra knows this process change places an increasing burden on PMC members for managing contributors, and makes it harder for people to contribute bug reports. We suggest projects consider using GitHub Issues for customer-facing questions/bug reports/etc., while maintaining development issues on Jira. You can enable GitHub Issues for your repository via https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Repositoryfeatures Infra has targeted 6 November for the date we switch off public signups for issues.apache.org/jira . Please let us know if this will place any significant burden on your teams. We are following an aggressive timeline because of the serious impact spam users have on the safety and stability of our infrastructure. As always, if you have any questions or comments about this, please let us know! -Chris (fluxo) -- @fluxo Chris Lambertus ASF Infrastructure --- End Message ---
[GitHub] [sling-site] kwin commented on pull request #99: SLING-11594 update to JBake 2.7.0-rc.6
kwin commented on PR #99: URL: https://github.com/apache/sling-site/pull/99#issuecomment-1288902539 If I don't hear any concerns till end of week I am gonna merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] kwin merged pull request #98: SLING-11538 document HTL display context "jsonString"
kwin merged PR #98: URL: https://github.com/apache/sling-site/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11538) Add display context for JSON string
[
https://issues.apache.org/jira/browse/SLING-11538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623124#comment-17623124
]
Konrad Windszus commented on SLING-11538:
-
Fixed in
*
https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/d677bfad1c040aaa439fa3be2d4828d37da4d5f5
(impl)
*
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/commit/99729b8a62f86fd663e989a19a5a5f4c37162c8d
(IT test content)
*
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/commit/ff9b75c66a8557fa2e78941a46f82734009e8e58
(IT)
> Add display context for JSON string
> ---
>
> Key: SLING-11538
> URL: https://issues.apache.org/jira/browse/SLING-11538
> Project: Sling
> Issue Type: Improvement
> Components: HTL
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Scripting HTL Engine 1.4.22-1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would be useful to add an output context to HTL to be used inside JSON. As
> JSON is very complex, the most essential one which currently cannot be
> achieved with any other existing contexts is escaping for a JSON String value
> (compare with https://github.com/adobe/htl-spec/issues/5).
> I propose to introduce a new context {{jsonString}} next to {{scriptString}}
> in
> https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/192d953514e6e579428cda157a7e83fc2a05cc01/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/XSSRuntimeExtension.java#L93.
> As it is not part of the official HTL spec at
> https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#121-display-context
> it needs to be listed as Sling-specific addition in
> https://sling.apache.org/documentation/bundles/scripting/scripting-htl.html#extensions-of-the-htl-specification.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11538) Add display context for JSON string
[
https://issues.apache.org/jira/browse/SLING-11538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-11538.
-
Resolution: Fixed
> Add display context for JSON string
> ---
>
> Key: SLING-11538
> URL: https://issues.apache.org/jira/browse/SLING-11538
> Project: Sling
> Issue Type: Improvement
> Components: HTL
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Scripting HTL Engine 1.4.22-1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would be useful to add an output context to HTL to be used inside JSON. As
> JSON is very complex, the most essential one which currently cannot be
> achieved with any other existing contexts is escaping for a JSON String value
> (compare with https://github.com/adobe/htl-spec/issues/5).
> I propose to introduce a new context {{jsonString}} next to {{scriptString}}
> in
> https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/192d953514e6e579428cda157a7e83fc2a05cc01/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/XSSRuntimeExtension.java#L93.
> As it is not part of the official HTL spec at
> https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#121-display-context
> it needs to be listed as Sling-specific addition in
> https://sling.apache.org/documentation/bundles/scripting/scripting-htl.html#extensions-of-the-htl-specification.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] kwin merged pull request #9: SLING-11538 add IT for display context "jsonString"
kwin merged PR #9: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] commented on pull request #9: SLING-11538 add IT for display context "jsonString"
sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/9#issuecomment-128543 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-testing=9) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing=9=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] kwin commented on a diff in pull request #98: SLING-11538 document HTL display context "jsonString"
kwin commented on code in PR #98: URL: https://github.com/apache/sling-site/pull/98#discussion_r1003187901 ## src/main/jbake/content/documentation/bundles/scripting/scripting-htl.md: ## @@ -84,6 +84,12 @@ The Sling HTL Scripting engine fully complies with the [HTML Template Language S ## Expression Options + +### Display Context Review Comment: ```suggestion ### Display Context (supported since HTL Engine 1.4.22-1.4.0) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-testing-content] kwin merged pull request #7: SLING-11538 add test content for display context "jsonString"
kwin merged PR #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] kwin merged pull request #20: SLING-11538 add output context for JSON string
kwin merged PR #20: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests
sonarcloud[bot] commented on PR #30: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1288669823 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss=30) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=30=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [16 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=30=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_coverage=list) [77.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=30=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1003046153
##
src/main/java/org/apache/sling/xss/impl/xml/AntiSamyRules.java:
##
@@ -125,3 +126,10 @@ public Map getCommonPatternByName() {
.collect(Collectors.toMap(Regexp::getName,
Regexp::getPattern));
}
}
+
+/**
+ * Attribute, Property and Tag names use the English locale, which may differ
from the original config
+ */
+class AntiSamyConfigLocale {
Review Comment:
Resolved:
[e763eef](https://github.com/apache/sling-org-apache-sling-xss/pull/30/commits/e763eef2cab9c2b3a43de53c2747aad62e7e62d6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (SLING-11650) Update to Sling (Bundle) Parent 49
[ https://issues.apache.org/jira/browse/SLING-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11650. -- Resolution: Done > Update to Sling (Bundle) Parent 49 > -- > > Key: SLING-11650 > URL: https://issues.apache.org/jira/browse/SLING-11650 > Project: Sling > Issue Type: Task > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, > Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features > 1.0.0, Karaf Configs 1.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11650) Update to Sling (Bundle) Parent 49
Oliver Lietz created SLING-11650: Summary: Update to Sling (Bundle) Parent 49 Key: SLING-11650 URL: https://issues.apache.org/jira/browse/SLING-11650 Project: Sling Issue Type: Task Components: Karaf Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features 1.0.0, Karaf Configs 1.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
