[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1344954564 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1344946406 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11689) Onboard Commons Permissions Sling to SonarCloud
[
https://issues.apache.org/jira/browse/SLING-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-11689.
--
Assignee: Oliver Lietz (was: Fabrice Bellingard)
Resolution: Done
No worries! Thanks, [~bellingard]!
> Onboard Commons Permissions Sling to SonarCloud
> ---
>
> Key: SLING-11689
> URL: https://issues.apache.org/jira/browse/SLING-11689
> Project: Sling
> Issue Type: Task
> Components: Commons, JCR
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Permissions Sling 1.0.0
>
>
> [~bellingard], Please onboard
> {{sling-org-apache-sling-commons-permissions-sling}} to SonarCloud.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-whiteboard] dependabot[bot] opened a new pull request, #94: Bump qs from 6.5.2 to 6.5.3 in /time-to-first-request
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/sling-whiteboard/pull/94 Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's changelog. 6.5.3 [Fix] parse: ignore __proto__ keys (https://github-redirect.dependabot.com/ljharb/qs/issues/428;>#428) [Fix] utils.merge: avoid a crash with a null target and a truthy non-array source [Fix] correctly parse nested arrays [Fix] stringify: fix a crash with strictNullHandling and a custom filter/serializeDate (https://github-redirect.dependabot.com/ljharb/qs/issues/279;>#279) [Fix] utils: merge: fix crash when source is a truthy primitive no options are provided [Fix] when parseArrays is false, properly handle keys ending in [] [Fix] fix for an impossible situation: when the formatter is called with a non-string value [Fix] utils.merge: avoid a crash with a null target and an array source [Refactor] utils: reduce observable [[Get]]s [Refactor] use cached Array.isArray [Refactor] stringify: Avoid arr = arr.concat(...), push to the existing instance (https://github-redirect.dependabot.com/ljharb/qs/issues/269;>#269) [Refactor] parse: only need to reassign the var once [Robustness] stringify: avoid relying on a global undefined (https://github-redirect.dependabot.com/ljharb/qs/issues/427;>#427) [readme] remove travis badge; add github actions/codecov badges; update URLs [Docs] Clean up license text so it’s properly detected as BSD-3-Clause [Docs] Clarify the need for arrayLimit option [meta] fix README.md (https://github-redirect.dependabot.com/ljharb/qs/issues/399;>#399) [meta] add FUNDING.yml [actions] backport actions from main [Tests] always use String(x) over x.toString() [Tests] remove nonexistent tape option [Dev Deps] backport from main Commits https://github.com/ljharb/qs/commit/298bfa55d6db00ddea78dd0333509aadf9bb3077;>298bfa5 v6.5.3 https://github.com/ljharb/qs/commit/ed0f5dcbef4b168a8ae299d78b1e4a2e9b1baf1f;>ed0f5dc [Fix] parse: ignore __proto__ keys (https://github-redirect.dependabot.com/ljharb/qs/issues/428;>#428) https://github.com/ljharb/qs/commit/691e739cfa40cd42604dc05a54e6154371a429ab;>691e739 [Robustness] stringify: avoid relying on a global undefined (https://github-redirect.dependabot.com/ljharb/qs/issues/427;>#427) https://github.com/ljharb/qs/commit/1072d57d38a690e1ad7616dced44390bffedcbb2;>1072d57 [readme] remove travis badge; add github actions/codecov badges; update URLs https://github.com/ljharb/qs/commit/12ac1c403aaa04d1a34844f514ed9f9abfb76e64;>12ac1c4 [meta] fix README.md (https://github-redirect.dependabot.com/ljharb/qs/issues/399;>#399) https://github.com/ljharb/qs/commit/0338716b09fdbd4711823eeb0a14e556a2498e7a;>0338716 [actions] backport actions from main https://github.com/ljharb/qs/commit/5639c20ce0a7c1332200a3181339331483e5a3a1;>5639c20 Clean up license text so it’s properly detected as BSD-3-Clause https://github.com/ljharb/qs/commit/51b8a0b1b213596dd1702b837f5e7dec2229793d;>51b8a0b add FUNDING.yml https://github.com/ljharb/qs/commit/45f675936e742d92fac8d4dae5cfc385c576a977;>45f6759 [Fix] fix for an impossible situation: when the formatter is called with a no... https://github.com/ljharb/qs/commit/f814a7f8f2af059f8158f7e4b2bf8b46aeb62cd3;>f814a7f [Dev Deps] backport from main Additional commits viewable in https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more
[jira] [Commented] (SLING-11689) Onboard Commons Permissions Sling to SonarCloud
[
https://issues.apache.org/jira/browse/SLING-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645426#comment-17645426
]
Fabrice Bellingard commented on SLING-11689:
Really sorry about that [~olli], I indeed missed the notification. Here it is!
=>
https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-commons-permissions-sling
> Onboard Commons Permissions Sling to SonarCloud
> ---
>
> Key: SLING-11689
> URL: https://issues.apache.org/jira/browse/SLING-11689
> Project: Sling
> Issue Type: Task
> Components: Commons, JCR
>Reporter: Oliver Lietz
>Assignee: Fabrice Bellingard
>Priority: Major
> Fix For: Commons Permissions Sling 1.0.0
>
>
> [~bellingard], Please onboard
> {{sling-org-apache-sling-commons-permissions-sling}} to SonarCloud.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-site] raducotescu commented on a diff in pull request #105: SLING-11722 - The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
raducotescu commented on code in PR #105: URL: https://github.com/apache/sling-site/pull/105#discussion_r1044482745 ## src/main/jbake/content/documentation/the-sling-engine/dispatching-requests.md: ## @@ -49,14 +49,24 @@ If a servlet or script is including another resource for processing through the 1. The resource is resolved though ResourceResolver.getResource (if the RequestDispatcher has not been created with a resource already) -1. The servlet or script to handle the resource is resolved calling the `ServletResolver.resolverServlet` method. +1. The servlet or script to handle the resource is resolved calling the `ServletResolver.resolveServlet` method. Review Comment: This was just a typo, but since I was here... :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] raducotescu opened a new pull request, #105: SLING-11722 - The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
raducotescu opened a new pull request, #105: URL: https://github.com/apache/sling-site/pull/105 * documented the two new SlingMainServlet configuration options that allow the SlingRequestDispatcher to be spec-compliant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-11722:
-
Description:
The {{include}} method [0] has the following important sentence in its
documentation:
{quote}
The ServletResponse object has its path elements and parameters remain
unchanged from the caller's. The included servlet cannot change the response
status code or set headers; any attempt to make a change is ignored.
{quote}
However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
[0] -
https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
[1] -
https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
was:
The {{include}} method [0] has the following important sentence in its
documentation:
{quote}
The ServletResponse object has its path elements and parameters remain
unchanged from the caller's. The included servlet cannot change the response
status code or set headers; any attempt to make a change is ignored.
{quote}
However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
[0] -
https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 regards, Karl On Fri, Dec 9, 2022 at 12:06 PM Angela Schreiber wrote: > +1 > angela > > From: Radu Cotescu > Sent: Friday, December 9, 2022 11:15 > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Scripting JSP 2.6.2 > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2706/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2706 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 regards, Karl On Fri, Dec 9, 2022 at 12:07 PM Angela Schreiber wrote: > +1 > angela > > > From: Radu Cotescu > Sent: Friday, December 9, 2022 11:15 > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Engine 2.13.2 > > > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2705/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2705 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 angela From: Radu Cotescu Sent: Friday, December 9, 2022 11:15 To: Sling Developers List Subject: [VOTE] Release Apache Sling Engine 2.13.2 Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2705/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2705 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 angela From: Radu Cotescu Sent: Friday, December 9, 2022 11:15 To: Sling Developers List Subject: [VOTE] Release Apache Sling Scripting JSP 2.6.2 EXTERNAL: Use caution when clicking on links or opening attachments. Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2706/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2706 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 Am Fr., 9. Dez. 2022 um 11:15 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2705/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2705 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 Am Fr., 9. Dez. 2022 um 11:16 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2706/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2706 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 Carsten Am 09.12.2022 um 11:15 schrieb Radu Cotescu: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2705/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2705 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 Carsten Am 09.12.2022 um 11:15 schrieb Radu Cotescu: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2706/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2706 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 > On 9 Dec 2022, at 11:15, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 > On 9 Dec 2022, at 11:15, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
[VOTE] Release Apache Sling Scripting JSP 2.6.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2706/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2706 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
[VOTE] Release Apache Sling Engine 2.13.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2705/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2705 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645180#comment-17645180 ] Carsten Ziegeler commented on SLING-11718: -- [~kwin] Sooner or later we will have jakarta.json at runtime. As the json library is an implementation detail of the jcr content loader, I don't think it is worth the effort to maintain two versions. We should rather go with having javax.json and jakarta.json at runtime in parallel for the time being. See also my email to the dev list > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, JCR ContentLoader 2.5.4, Content-Package to > Feature Model Converter 1.1.26, Feature Model 2.0.0, Feature Model API > Regions Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [RT] Migrating the feature model tooling to Jakarta JSON
Am 29.11.2022 um 16:16 schrieb Robert Munteanu: > ... Overall sounds good to me. The only problematic area that I see is the cpconverter, as that ends up embedded in various tools. Since it's a one-off, I hope it will not be problematic. Yes, that was my hope, too. I finished updating the relevant tooling and its slightly more complicated. The cpconverter uses the JCR contentloader which in turn uses javax.json. That by itself is not a issue, however, the way the Apache johnzon library is implemented you can't run the javax and the jakarta version side by side. I tried to use a different implementation, but that broke the JSON parsing. So interestingly there seems to be a difference in the implementations... Anyhow, sooner or later we have to update our bundles as well. With the contentloader it is easy as this only affects the implementation not the api, so I went ahead and updated that bundle as well. Which then opens the question which bundle we use at runtime for jakarta.json? OOTB the johnzon implementation is too heavy as it has too many dependencies. So we could do the same as for the javax version and provide a commons.johnzon.jakarta module? Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Resolved] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-11722.
--
Resolution: Fixed
Fixed in [commit
5d8df33|https://github.com/apache/sling-org-apache-sling-engine/commit/5d8df33].
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-engine] raducotescu merged pull request #29: SLING-11722 - The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
raducotescu merged PR #29: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11718: - Fix Version/s: Content-Package to Feature Model Converter 1.1.26 > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, JCR ContentLoader 2.5.4, Content-Package to > Feature Model Converter 1.1.26, Feature Model 2.0.0, Feature Model API > Regions Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645169#comment-17645169 ] Carsten Ziegeler commented on SLING-11718: -- Migrated cp2fm converter in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/0723195531a3c5fa09ddc4ca3526ac8f8e12c00f > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, JCR ContentLoader 2.5.4, Feature Model 2.0.0, > Feature Model API Regions Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #29: SLING-11722 - The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
sonarcloud[bot] commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/29#issuecomment-1344005759 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=29) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=29=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=29=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=29=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=29=new_coverage=list) [39.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=29=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=29=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=29=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11724) Improve exception handling in generated JSPs
[
https://issues.apache.org/jira/browse/SLING-11724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-11724.
--
Resolution: Fixed
Fixed in [commit
6f14664|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/6f14664],
similarly to
https://github.com/apache/tomcat/blob/66a4bcab40ba28b8b0ead1d360575b19fc383da7/java/org/apache/jasper/compiler/Generator.java#L3242.
> Improve exception handling in generated JSPs
>
>
> Key: SLING-11724
> URL: https://issues.apache.org/jira/browse/SLING-11724
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting JSP 2.6.2
>
>
> The JSP engine generation of the {{_jspService(HttpServletRequest request,
> HttpServletResponse response)}} method should be improved, so that any
> possible thrown exception can be handled by the {{pageContext}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API
[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645152#comment-17645152 ] Konrad Windszus commented on SLING-11718: - At least the JCR Content Loader is used at application run time, so do we maintain two major versions (with/without Jakarta JSON) or do switch the Starter and the rest of the bundles to Jakarta JSON as well? > Migrate to Jakarta JSON API > --- > > Key: SLING-11718 > URL: https://issues.apache.org/jira/browse/SLING-11718 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Feature Model Analyser, Maven Plugins and > Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.0, slingfeature-maven-plugin > 1.6.10, Feature Diff 0.1.0, JCR ContentLoader 2.5.4, Feature Model 2.0.0, > Feature Model API Regions Extension 2.0.0, Feature Model Launcher 1.2.4 > > > Starting with JEE 9 the package names for the enterprise APIs changed from > javax.* to jakarta.* which means that we will benefit from updates to those > APIs only if we make the move. > For the feature model and the related tooling, it should be fairly easy to do > this move as this code is usually only used at tool time but not at > application runtime. > We can simply replace javax.json with jakarta.json and do new releases of > everything involved with a new major version. As we are currently using > javax.json in parts of the API, this will be a breaking change, therefore the > major version update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
