[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #100: Bump commons-fileupload from 1.3.3 to 1.5 in /upgrade
sonarcloud[bot] commented on PR #100: URL: https://github.com/apache/sling-whiteboard/pull/100#issuecomment-1439562916 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=100) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=100=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=100=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-whiteboard=100=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=100=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=100=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=100=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] dependabot[bot] opened a new pull request, #100: Bump commons-fileupload from 1.3.3 to 1.5 in /upgrade
dependabot[bot] opened a new pull request, #100: URL: https://github.com/apache/sling-whiteboard/pull/100 Bumps commons-fileupload from 1.3.3 to 1.5. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-whiteboard/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 Carsten On 21.02.2023 14:36, Carsten Ziegeler wrote: Hi, We solved 4 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2719 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2719 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 On Tue, Feb 21, 2023 at 1:10 PM Karl Pauls wrote: > +1 > > regards, > > Karl > > On Tuesday, February 21, 2023, Nicolas Peltier > wrote: > > > +1 > > > > Nicolas > > > > Le mar. 21 févr. 2023 à 16:23, Angela Schreiber > > > > > a écrit : > > > > > +1 > > > > > > kind regards > > > angela > > > > > > > > > From: Carsten Ziegeler > > > Sent: Tuesday, February 21, 2023 14:36 > > > To: dev@sling.apache.org > > > Subject: [VOTE] Release Apache Sling Engine 2.14.0 > > > > > > Hi, > > > > > > We solved 4 issues in this release > > > https://issues.apache.org/jira/projects/SLING/versions/12352612 > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2719 > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2719 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > >[ ] +1 Approve the release > > >[ ] 0 Don't care > > >[ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Carsten > > > -- > > > Carsten Ziegeler > > > Adobe > > > cziege...@apache.org > > > > > > > > -- > Karl Pauls > karlpa...@gmail.com >
[GitHub] [sling-org-apache-sling-commons-log-webconsole] sonarcloud[bot] commented on pull request #5: Bump commons-fileupload from 1.2.1 to 1.5
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-log-webconsole/pull/5#issuecomment-1439299498 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-log-webconsole=5) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log-webconsole=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log-webconsole=5=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log-webconsole=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log-webconsole=5=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-log-webconsole] dependabot[bot] closed pull request #4: Bump commons-fileupload from 1.2.1 to 1.3.3
dependabot[bot] closed pull request #4: Bump commons-fileupload from 1.2.1 to 1.3.3 URL: https://github.com/apache/sling-org-apache-sling-commons-log-webconsole/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-log-webconsole] dependabot[bot] commented on pull request #4: Bump commons-fileupload from 1.2.1 to 1.3.3
dependabot[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-commons-log-webconsole/pull/4#issuecomment-1439281370 Superseded by #5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-log-webconsole] dependabot[bot] opened a new pull request, #5: Bump commons-fileupload from 1.2.1 to 1.5
dependabot[bot] opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-commons-log-webconsole/pull/5 Bumps commons-fileupload from 1.2.1 to 1.5. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-org-apache-sling-commons-log-webconsole/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #10: Add implementation for addMixin method
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#issuecomment-1439206890 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock=10) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_coverage=list) [91.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691777#comment-17691777
]
Andreas Schaefer commented on SLING-10900:
--
All graphql-java version newer that 17.4 have an issue with the released JAR
file as the MANIFEST.MF entry is not the first one in the JAR file making it
not deploy when using a Feature Model.
I create a branch on Sling Graphql Core *issue/SLING-10900-201* that allows to
test it with the latest fixes in graphql-java. These are the instructions.
# Checkout my branch: **issue/manifest-mf.order** from Github:
https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order
# Go to its folder
# Change to Java 11
# Set release version with: `export RELEASE_VERSION="20.1-SNAPSHOT"`
# Build with: `./gradlew clean publishToMavenLocal -x
signGraphqlJavaPublication`
# Copy the folder **com/graphql-java/graphql-java/20.1-SNAPSHOT** from your
local .m2 repository to a folder **respository** inside the Sling Graphql Core
## Make sure all the sub folders are created or copied to there to (this is
the path to the JAR file:
`respository/com/graphql-java/graphql-java/20.1-SNAPSHOT/graphql-java-20.1-SNAPSHOT.jar`)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-jcr-mock] catalinadumitruu commented on a diff in pull request #10: Add implementation for addMixin method
catalinadumitruu commented on code in PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#discussion_r1113492026
##
src/main/java/org/apache/sling/testing/mock/jcr/MockNode.java:
##
@@ -368,8 +372,26 @@ public boolean equals(Object obj) {
@Override
public NodeType[] getMixinNodeTypes() throws RepositoryException {
-// we have no real mixin support - just assume no mixin nodetypes are
set
-return new NodeType[0];
+Value[] mixinNames =
getProperty(JcrConstants.JCR_MIXINTYPES).getValues();
+
+return Arrays.stream(mixinNames)
+.map(value -> {
+try {
+return value.getString();
+} catch (RepositoryException e) {
+return new NodeType[0];
Review Comment:
I more inclined to return an empty array because it is a mock implementation
and it is safer to not return null and cause errors, but it is your call :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] catalinadumitruu commented on a diff in pull request #10: Add implementation for addMixin method
catalinadumitruu commented on code in PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#discussion_r1113484408
##
src/main/java/org/apache/sling/testing/mock/jcr/MockNode.java:
##
@@ -368,8 +372,26 @@ public boolean equals(Object obj) {
@Override
public NodeType[] getMixinNodeTypes() throws RepositoryException {
-// we have no real mixin support - just assume no mixin nodetypes are
set
-return new NodeType[0];
+Value[] mixinNames =
getProperty(JcrConstants.JCR_MIXINTYPES).getValues();
+
+return Arrays.stream(mixinNames)
+.map(value -> {
+try {
+return value.getString();
+} catch (RepositoryException e) {
+return new NodeType[0];
+}
+})
+.filter(Objects::nonNull)
+.map(name -> {
+try {
+return
getSession().getWorkspace().getNodeTypeManager().getNodeType(name.toString());
+} catch (RepositoryException e) {
+return new NodeType[0];
Review Comment:
I more inclined to return an empty array because it is a mock implementation
and it is safer to not return null and cause errors, but it is your call :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert commented on a diff in pull request #10: Add implementation for addMixin method
stefanseifert commented on code in PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#discussion_r1113416143
##
src/main/java/org/apache/sling/testing/mock/jcr/MockNode.java:
##
@@ -368,8 +372,26 @@ public boolean equals(Object obj) {
@Override
public NodeType[] getMixinNodeTypes() throws RepositoryException {
-// we have no real mixin support - just assume no mixin nodetypes are
set
-return new NodeType[0];
+Value[] mixinNames =
getProperty(JcrConstants.JCR_MIXINTYPES).getValues();
+
+return Arrays.stream(mixinNames)
+.map(value -> {
+try {
+return value.getString();
+} catch (RepositoryException e) {
+return new NodeType[0];
Review Comment:
i assume this should return null in case of error - to be filtered out in
the next step?
##
src/main/java/org/apache/sling/testing/mock/jcr/MockNode.java:
##
@@ -368,8 +372,26 @@ public boolean equals(Object obj) {
@Override
public NodeType[] getMixinNodeTypes() throws RepositoryException {
-// we have no real mixin support - just assume no mixin nodetypes are
set
-return new NodeType[0];
+Value[] mixinNames =
getProperty(JcrConstants.JCR_MIXINTYPES).getValues();
+
+return Arrays.stream(mixinNames)
+.map(value -> {
+try {
+return value.getString();
+} catch (RepositoryException e) {
+return new NodeType[0];
+}
+})
+.filter(Objects::nonNull)
+.map(name -> {
+try {
+return
getSession().getWorkspace().getNodeTypeManager().getNodeType(name.toString());
+} catch (RepositoryException e) {
+return new NodeType[0];
Review Comment:
i assume this should return null in case of error - to be filtered out in
the next step?
##
src/test/java/org/apache/sling/testing/mock/jcr/MockNodeTest.java:
##
@@ -18,32 +18,22 @@
*/
package org.apache.sling.testing.mock.jcr;
-import static org.junit.Assert.assertArrayEquals;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
-
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
-import javax.jcr.ItemNotFoundException;
-import javax.jcr.Node;
-import javax.jcr.NodeIterator;
-import javax.jcr.Property;
-import javax.jcr.PropertyIterator;
-import javax.jcr.RepositoryException;
-import javax.jcr.Session;
+import javax.jcr.*;
import javax.jcr.nodetype.NoSuchNodeTypeException;
+import javax.jcr.nodetype.NodeType;
Review Comment:
cosmetic: please remove unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 regards, Karl On Tuesday, February 21, 2023, Nicolas Peltier wrote: > +1 > > Nicolas > > Le mar. 21 févr. 2023 à 16:23, Angela Schreiber > > a écrit : > > > +1 > > > > kind regards > > angela > > > > > > From: Carsten Ziegeler > > Sent: Tuesday, February 21, 2023 14:36 > > To: dev@sling.apache.org > > Subject: [VOTE] Release Apache Sling Engine 2.14.0 > > > > Hi, > > > > We solved 4 issues in this release > > https://issues.apache.org/jira/projects/SLING/versions/12352612 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2719 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2719 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 Nicolas Le mar. 21 févr. 2023 à 16:23, Angela Schreiber a écrit : > +1 > > kind regards > angela > > > From: Carsten Ziegeler > Sent: Tuesday, February 21, 2023 14:36 > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Engine 2.14.0 > > Hi, > > We solved 4 issues in this release > https://issues.apache.org/jira/projects/SLING/versions/12352612 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2719 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2719 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 kind regards angela From: Carsten Ziegeler Sent: Tuesday, February 21, 2023 14:36 To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Engine 2.14.0 Hi, We solved 4 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2719 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2719 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #655 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/655/ for details. No further emails will be sent until the status of the build is changed.
[VOTE] Release Apache Sling Engine 2.14.0
Hi, We solved 4 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12352612 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2719 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2719 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Commented] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691602#comment-17691602
]
Radu Cotescu commented on SLING-11722:
--
This should be good to go from the POV of the spec. When the two new configs
are enabled it might affect scripts written in JSP, since that engine sets by
default a content type. Depending on the request's rendering chain some JSP
scripts might need to be refactored.
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.4
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-11722.
--
Resolution: Fixed
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.4
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645173#comment-17645173
]
Radu Cotescu edited comment on SLING-11722 at 2/21/23 1:24 PM:
---
Fixed in [commit
5d8df33|https://github.com/apache/sling-org-apache-sling-engine/commit/5d8df33]
and commit
[ece93401|https://github.com/apache/sling-org-apache-sling-engine/commit/ece93401392f7fb3b75b02af62d392e75120d245].
was (Author: radu.cotescu):
Fixed in [commit
5d8df33|https://github.com/apache/sling-org-apache-sling-engine/commit/5d8df33].
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.4
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #654 is BROKEN
: https://repo.maven.apache.org/maven2/commons-codec/commons-codec/1.3/commons-codec-1.3.jar (47 kB at 3.9 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.6/doxia-decoration-model-1.6.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar (61 kB at 5.1 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-sink-api/1.6/doxia-sink-api-1.6.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar (173 kB at 12 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-site-renderer/1.6/doxia-site-renderer-1.6.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.6/doxia-decoration-model-1.6.jar (57 kB at 3.8 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-module-xhtml/1.6/doxia-module-xhtml-1.6.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar (293 kB at 18 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-module-fml/1.6/doxia-module-fml-1.6.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-sink-api/1.6/doxia-sink-api-1.6.jar (11 kB at 659 kB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-module-xhtml/1.6/doxia-module-xhtml-1.6.jar (16 kB at 843 kB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/xmlunit/xmlunit/1.5/xmlunit-1.5.jar (98 kB at 5.1 MB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/velocity/velocity/1.5/velocity-1.5.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar (11 kB at 525 kB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.21/plexus-utils-3.0.21.jar [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-site-renderer/1.6/doxia-site-renderer-1.6.jar (56 kB at 2.7 MB/s) [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar (7.7 kB at 307 kB/s) [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-module-fml/1.6/doxia-module-fml-1.6.jar (38 kB at 1.3 MB/s) [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.21/plexus-utils-3.0.21.jar (245 kB at 6.3 MB/s) [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/velocity/velocity/1.5/velocity-1.5.jar (392 kB at 7.1 MB/s) [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from /home/jenkins/jenkins-agent/712657a4/workspace/_org-apache-sling-starter_master/jdk_17_latest/.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 79 implicit excludes (use -debug for more details). [INFO] 15 explicit excludes (use -debug for more details). [INFO] 21 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 20 licenses. [INFO] [INFO] --- docker-maven-plugin:0.39.0:stop (stop-mongo) @ org.apache.sling.starter --- [INFO] DOCKER> [mongo:4.4.6] "mongo": Stop and removed container 2b7764e79ac7 after 0 ms [INFO] [INFO] --- maven-failsafe-plugin:3.0.0-M5:verify (default) @ org.apache.sling.starter --- [INFO] Failsafe report directory: /home/jenkins/jenkins-agent/712657a4/workspace/_org-apache-sling-starter_master/jdk_17_latest/target/failsafe-reports [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 24:53 min [INFO] Finished at: 2023-02-21T12:42:50Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/712657a4/workspace/_org-apache-sling-starter_master/jdk_17_latest@tmp/withMavene1c940ee/maven-spy-20230221-121756-49415318086206586954011.log [ERROR] Failed to execute goal org.apache.maven.
[jira] [Commented] (SLING-11783) Issue while upgrading version 6 to 7
[
https://issues.apache.org/jira/browse/SLING-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691565#comment-17691565
]
Prasad Shembekar commented on SLING-11783:
--
Hi,
We are currently using Apache Sling 6 as a war. While trying to upgrade the
version from 6 to 7,, changed the attached *pom.xml* to use
"{*}defaultBundleList=7{*}" for the
*org.apache.sling:maven-launchpad-plugin:2.3.4 (upgraded from 2.0.10 to 2.3.4).*
Updated the dependency for *org.apache.sling:org.apache.sling.launchpad.base
(from 2.3.0 to 2.5.0).*
In addition to the default bundles, we are explicitly packaging additional
bundles using the attached *list.xml.*
The war builds successfully after making the above changes.
But when, the war with the *apache sling 7* is deployed to {*}JBOSS EAP
7.4.0{*}, the war fails to deploy and exceptions related to bundle dependencies
are seen. Please see the attached *server.log* file for the errors.
{code:java}
2023-02-20 10:26:05,271 ERROR [io.undertow.servlet] (FelixStartLevel) ERROR:
Error starting
slinginstall:E:\cover-all\cms\sling\startup\0\org.apache.sling.engine-2.3.6.jar
(org.osgi.framework.BundleException: Unresolved constraint in bundle
org.apache.sling.engine [39]: Unable to resolve 39.0: missing requirement
[39.0] osgi.wiring.package;
(&(osgi.wiring.package=javax.servlet)(version>=2.3.0)(!(version>=4.0.0:
org.osgi.framework.BundleException: Unresolved constraint in bundle
org.apache.sling.engine [39]: Unable to resolve 39.0: missing requirement
[39.0] osgi.wiring.package;
(&(osgi.wiring.package=javax.servlet)(version>=2.3.0)(!(version>=4.0.0)))
at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4002)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2045)
at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1299)
at
org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:304)
at java.lang.Thread.run(Thread.java:748) {code}
The war for *apache sling 6* is successfully deployed on the same *JBOSS EAP
7.4.0* server.
We tried explicitly adding the *javax.servlet* bundle to the *list.xml* at
{*}level=0{*}, but it also didn't work. Not sure what is missing.
*Note:* We are upgrading the sling version, in order to update the Jackrabbit
version. We are seeing some Jackrabbit & database connection leak related
issues, and thus trying to upgrade the jackrabbit version to the latest. Let us
know, if Jackrabbit can be directly upgraded instead. It will be really helpful
> Issue while upgrading version 6 to 7
> -
>
> Key: SLING-11783
> URL: https://issues.apache.org/jira/browse/SLING-11783
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Reporter: Prasad Shembekar
>Priority: Major
> Attachments: list.xml, pom.xml, server.log
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11783) Issue while upgrading version 6 to 7
[ https://issues.apache.org/jira/browse/SLING-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad Shembekar updated SLING-11783: - Attachment: server.log > Issue while upgrading version 6 to 7 > - > > Key: SLING-11783 > URL: https://issues.apache.org/jira/browse/SLING-11783 > Project: Sling > Issue Type: Bug > Components: Launchpad >Reporter: Prasad Shembekar >Priority: Major > Attachments: list.xml, pom.xml, server.log > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11783) Issue while upgrading version 6 to 7
[ https://issues.apache.org/jira/browse/SLING-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad Shembekar updated SLING-11783: - Attachment: list.xml > Issue while upgrading version 6 to 7 > - > > Key: SLING-11783 > URL: https://issues.apache.org/jira/browse/SLING-11783 > Project: Sling > Issue Type: Bug > Components: Launchpad >Reporter: Prasad Shembekar >Priority: Major > Attachments: list.xml, pom.xml > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11783) Issue while upgrading version 6 to 7
[ https://issues.apache.org/jira/browse/SLING-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad Shembekar updated SLING-11783: - Attachment: pom.xml > Issue while upgrading version 6 to 7 > - > > Key: SLING-11783 > URL: https://issues.apache.org/jira/browse/SLING-11783 > Project: Sling > Issue Type: Bug > Components: Launchpad >Reporter: Prasad Shembekar >Priority: Major > Attachments: list.xml, pom.xml > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11783) Issue while upgrading version 6 to 7
Prasad Shembekar created SLING-11783: Summary: Issue while upgrading version 6 to 7 Key: SLING-11783 URL: https://issues.apache.org/jira/browse/SLING-11783 Project: Sling Issue Type: Bug Components: Launchpad Reporter: Prasad Shembekar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11782) Document Sling threat model and how to properly secure Sling
Angela Schreiber created SLING-11782: Summary: Document Sling threat model and how to properly secure Sling Key: SLING-11782 URL: https://issues.apache.org/jira/browse/SLING-11782 Project: Sling Issue Type: Improvement Components: Documentation, Site Reporter: Angela Schreiber The documentation should be more explicit about to run sling in a secure way. In particular we should provide some information about the underlying threat model. For example we should be being explicit about the fact that whoever has access to the OSGi console has file system access with the privileges of the JRE. cc: [~rombert], [~cziegeler] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11781) Update to commons fileupload 1.5
[ https://issues.apache.org/jira/browse/SLING-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11781. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-engine/commit/02bc2707e1b41f8fcf8073b285610448ae1ec53f > Update to commons fileupload 1.5 > > > Key: SLING-11781 > URL: https://issues.apache.org/jira/browse/SLING-11781 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.13.4 > > > We should update to the latest commons fileupload 1.5 and set the max file > count by default to 50 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11781) Update to commons fileupload 1.5
Carsten Ziegeler created SLING-11781: Summary: Update to commons fileupload 1.5 Key: SLING-11781 URL: https://issues.apache.org/jira/browse/SLING-11781 Project: Sling Issue Type: Improvement Components: Engine Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.13.4 We should update to the latest commons fileupload 1.5 and set the max file count by default to 50 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11740) DefaultErrorHandler should not catch Error
[ https://issues.apache.org/jira/browse/SLING-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11740. -- Assignee: Carsten Ziegeler Resolution: Fixed https://github.com/apache/sling-org-apache-sling-engine/commit/9f177240c3e991dec09c071a917ad88274c254d3 > DefaultErrorHandler should not catch Error > -- > > Key: SLING-11740 > URL: https://issues.apache.org/jira/browse/SLING-11740 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.13.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.13.4 > > > The DefaultErrorHandler is catching Error when it forwards to a delegate > error handler. As Error should not be caught by applications in general, we > should probably rather remove those two catch statements -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691516#comment-17691516
]
Carsten Ziegeler commented on SLING-11722:
--
[~radu] Is there still work required or can this be resolved?
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.13.4
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] niekraaijmakers commented on a diff in pull request #158: [Shelved] Sling 11777 2 - improve segmentprocessing
niekraaijmakers commented on code in PR #158:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/158#discussion_r1112737327
##
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java:
##
@@ -286,11 +295,9 @@ public void convert(@NotNull File... contentPackages)
throws IOException, Conver
// analyze sub-content packages in order to filter out
// possible outdated conflicting packages
recollectorVaultPackageScanner.traverse(pack);
-
logger.info("content-package '{}' successfully read!",
contentPackage);
aclManager.reset();
-bundleSlingInitialContentExtractor.reset();
Review Comment:
Basically it didn't do anything in the past ... it was added because acl
manager etc did reset something.. the paths were cleared but empty to begin
with :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a diff in pull request #158: Sling 11777 2 - improve segmentprocessing
anchela commented on code in PR #158:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/158#discussion_r1112682836
##
src/main/java/org/apache/sling/feature/cpconverter/repoinit/createpath/CreatePathSegmentProcessor.java:
##
@@ -27,52 +29,97 @@
import java.io.FileInputStream;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.LinkedHashMap;
import java.util.List;
+import java.util.Map;
import static org.apache.jackrabbit.vault.util.Constants.DOT_CONTENT_XML;
public class CreatePathSegmentProcessor {
-private CreatePathSegmentProcessor() {
+private final RepoPath path;
+private final Collection packageAssemblers;
+private final CreatePath cp;
+private boolean foundType = false;
+private String repositoryPath = "";
+
+private Map primaryTypeMap = new LinkedHashMap<>();
+private Map> mixinTypeMap = new LinkedHashMap<>();
+
+public CreatePathSegmentProcessor(@NotNull RepoPath path,
+ @NotNull
Collection packageAssemblers,
+ @NotNull CreatePath cp) {
+this.path = path;
+this.packageAssemblers = packageAssemblers;
+this.cp = cp;
}
/**
* Process segments of a repopath to createpath, checking
packageassemblers for existing primaryType definitions.
- *
- * @param path
- * @param packageAssemblers
- * @param cp
* @return
*/
-public static boolean processSegments(@NotNull RepoPath path, @NotNull
Collection packageAssemblers, @NotNull CreatePath cp) {
-String repositoryPath = "";
-boolean foundType = false;
+public boolean processSegments() {
for (final String part : path.getSegments()) {
-final String platformName =
PlatformNameFormat.getPlatformName(part);
-repositoryPath =
repositoryPath.concat(ConverterConstants.SLASH).concat(platformName);
+repositoryPath = processSegment(part);
+}
+return foundType;
+}
-boolean segmentAdded = false;
-//loop all package assemblers and check if .content.xml is defined
-for (VaultPackageAssembler packageAssembler : packageAssemblers) {
-File currentContent =
packageAssembler.getFileEntry(repositoryPath.concat(ConverterConstants.SLASH).concat(DOT_CONTENT_XML));
-if (currentContent.exists() && currentContent.isFile()) {
-//add segment if jcr:primaryType is defined.
-segmentAdded = addSegment(cp, part, currentContent);
-if (segmentAdded) {
-foundType = true;
-break;
+@NotNull
+private String processSegment(String part) {
+final String platformName = PlatformNameFormat.getPlatformName(part);
+repositoryPath =
repositoryPath.concat(ConverterConstants.SLASH).concat(platformName);
+
+//loop all package assemblers and check if .content.xml is defined
+collectTypeDataForSegment();
+addSegment(part);
+
+return repositoryPath;
+}
+
+private void addSegment(String part){
+//add segment if jcr:primaryType is defined.
+if(primaryTypeMap.containsKey(repositoryPath)){
+cp.addSegment(
+part,
+primaryTypeMap.get(repositoryPath),
+mixinTypeMap.get(repositoryPath)
+);
+}else{
+cp.addSegment(part, null);
+}
+}
+
+private void collectTypeDataForSegment() {
+for (VaultPackageAssembler packageAssembler : packageAssemblers) {
+
+if(primaryTypeMap.containsKey(repositoryPath)){
+boolean merge = true;
+for(PathFilterSet set:
packageAssembler.getFilter().getFilterSets()){
+if(set.covers(repositoryPath) && (set.getImportMode() !=
ImportMode.MERGE && set.getImportMode() != ImportMode.MERGE_PROPERTIES)){
+//found a path with a mode other than merge, proceed
to replace the type definitions
+merge = false;
+}else if(set.covers(repositoryPath)){
Review Comment:
formatting
in addition: you have twice the condition `set.covers(repositoryPath)` in
both the if and the else-if. that doesn't look good. i believe this could be
heavily improved in terms of readability if you would extract that into a
separate method e.g. 'doMerge'
also note: merge is already the default in the init of the boolean so
this looks a bit odd at a first glance and becomes only understandable in the
context of the for-loop and with the comment.
added benefit of extracting into a separate method: the complexity of the
method does down, which will avoid having sonar complaining about it
finally:
[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a diff in pull request #158: Sling 11777 2 - improve segmentprocessing
anchela commented on code in PR #158:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/158#discussion_r1112675670
##
src/main/java/org/apache/sling/feature/cpconverter/repoinit/createpath/CreatePathSegmentProcessor.java:
##
@@ -27,52 +29,97 @@
import java.io.FileInputStream;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.LinkedHashMap;
import java.util.List;
+import java.util.Map;
import static org.apache.jackrabbit.vault.util.Constants.DOT_CONTENT_XML;
public class CreatePathSegmentProcessor {
-private CreatePathSegmentProcessor() {
+private final RepoPath path;
+private final Collection packageAssemblers;
+private final CreatePath cp;
+private boolean foundType = false;
+private String repositoryPath = "";
+
+private Map primaryTypeMap = new LinkedHashMap<>();
+private Map> mixinTypeMap = new LinkedHashMap<>();
+
+public CreatePathSegmentProcessor(@NotNull RepoPath path,
+ @NotNull
Collection packageAssemblers,
+ @NotNull CreatePath cp) {
+this.path = path;
+this.packageAssemblers = packageAssemblers;
+this.cp = cp;
}
/**
* Process segments of a repopath to createpath, checking
packageassemblers for existing primaryType definitions.
- *
- * @param path
- * @param packageAssemblers
- * @param cp
* @return
*/
-public static boolean processSegments(@NotNull RepoPath path, @NotNull
Collection packageAssemblers, @NotNull CreatePath cp) {
-String repositoryPath = "";
-boolean foundType = false;
+public boolean processSegments() {
for (final String part : path.getSegments()) {
-final String platformName =
PlatformNameFormat.getPlatformName(part);
-repositoryPath =
repositoryPath.concat(ConverterConstants.SLASH).concat(platformName);
+repositoryPath = processSegment(part);
+}
+return foundType;
+}
-boolean segmentAdded = false;
-//loop all package assemblers and check if .content.xml is defined
-for (VaultPackageAssembler packageAssembler : packageAssemblers) {
-File currentContent =
packageAssembler.getFileEntry(repositoryPath.concat(ConverterConstants.SLASH).concat(DOT_CONTENT_XML));
-if (currentContent.exists() && currentContent.isFile()) {
-//add segment if jcr:primaryType is defined.
-segmentAdded = addSegment(cp, part, currentContent);
-if (segmentAdded) {
-foundType = true;
-break;
+@NotNull
+private String processSegment(String part) {
+final String platformName = PlatformNameFormat.getPlatformName(part);
+repositoryPath =
repositoryPath.concat(ConverterConstants.SLASH).concat(platformName);
+
+//loop all package assemblers and check if .content.xml is defined
+collectTypeDataForSegment();
+addSegment(part);
+
+return repositoryPath;
+}
+
+private void addSegment(String part){
+//add segment if jcr:primaryType is defined.
+if(primaryTypeMap.containsKey(repositoryPath)){
+cp.addSegment(
+part,
+primaryTypeMap.get(repositoryPath),
+mixinTypeMap.get(repositoryPath)
+);
+}else{
Review Comment:
formatting
##
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java:
##
@@ -286,11 +295,9 @@ public void convert(@NotNull File... contentPackages)
throws IOException, Conver
// analyze sub-content packages in order to filter out
// possible outdated conflicting packages
recollectorVaultPackageScanner.traverse(pack);
-
logger.info("content-package '{}' successfully read!",
contentPackage);
aclManager.reset();
-bundleSlingInitialContentExtractor.reset();
Review Comment:
@niekraaijmakers , the method '`reset`' on the
`BundleSlingInitialContentExtractor` is now no longer used anywhere. but it
is still present in the code.
please remove it
and on a second look: could it be a problem that the reset method is never
called? after all it was there for a reason, wasn't it?
##
src/main/java/org/apache/sling/feature/cpconverter/repoinit/createpath/CreatePathSegmentProcessor.java:
##
@@ -27,52 +29,97 @@
import java.io.FileInputStream;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.LinkedHashMap;
import java.util.List;
+import java.util.Map;
import static org.apache.jackrabbit.vault.util.Constants.DOT_CONTENT_XML;
public class CreatePathSegmentProcessor {
-private
[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #10: Add implementation for addMixin method
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#issuecomment-1438010172 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock=10) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock=10=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_coverage=list) [93.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock=10=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
