Re: [VOTE] Release Apache Sling Commons MIME version 2.2.4
+1 Carsten On 05.10.2023 20:28, Daniel Klco wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12346287=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2792/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2792 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [PR] Removed 1 unnecessary stubbings in ThreadPoolMetricsGaugesTest.java [sling-org-apache-sling-commons-threads]
sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/9#issuecomment-1749864013 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-threads=9) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threads=9=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threads=9=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-threads=9=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-threads=9=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-threads=9=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-threads=9=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Removed 1 unnecessary stubbings in ThreadPoolMetricsGaugesTest.java [sling-org-apache-sling-commons-threads]
ARUS2023 opened a new pull request, #9: URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/9 In our analysis of the project, we observed that 1) `ThreadPoolMetricsGaugesTest.testGaugesCreation` contains 1 unnecessary stubbing. Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html). We propose below a solution to remove the unnecessary stubbings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Servlets Get 2.2.0, Post 2.6.0, Resolver 2.10.0
+1 On Thu, Oct 5, 2023 at 7:19 AM Carsten Ziegeler wrote: > > Hi, > > We solved 3 issues for servlets resolver 2.10.0 > https://issues.apache.org/jira/projects/SLING/versions/12353474 > > We solved 4 issues for servlets get 2.2.0 > https://issues.apache.org/jira/projects/SLING/versions/12352682 > > We solved 3 issues for servlets post 2.10.0 > https://issues.apache.org/jira/projects/SLING/versions/12352478 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2791/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2791 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
Re: [PR] [SECURITY] Fix Temporary File Information Disclosure Vulnerability [sling-org-apache-sling-servlets-post]
sonarcloud[bot] commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/20#issuecomment-1749533506 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post=20) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=20=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=20=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=20=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
sonarcloud[bot] commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#issuecomment-1749529507 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post=22) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=22=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=22=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_coverage=list) [15.8% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_duplicated_lines_density=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=22=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772352#comment-17772352
]
Oliver Lietz commented on SLING-10506:
--
[~bellingard], [~rombert], I will try to complete and document the list next
week.
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[VOTE] Release Apache Sling Commons MIME version 2.2.4
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12346287=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2792/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2792 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Updated] (SLING-11651) Some EPS MimeTypes not Resolvable to Extension
[ https://issues.apache.org/jira/browse/SLING-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11651: - Fix Version/s: (was: Commons MIME 2.2.4) > Some EPS MimeTypes not Resolvable to Extension > -- > > Key: SLING-11651 > URL: https://issues.apache.org/jira/browse/SLING-11651 > Project: Sling > Issue Type: Bug >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Certain systems (such as Adobe's Dynamic Media) produce EPS documents with > the mimetype: image/x-eps which is not in the Common MIME's list of supported > mime types: > [https://github.com/apache/sling-org-apache-sling-commons-mime/tree/master/src/main/resources/META-INF] > > Thus, when attempting to retrieve the extension for a resource with the mime > type image/x-eps, null is returned instead of the expected extension. > We should update Commons MIME to support all common mime type variants for > EPS files: > https://en.wikipedia.org/wiki/Encapsulated_PostScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11651) Some EPS MimeTypes not Resolvable to Extension
[ https://issues.apache.org/jira/browse/SLING-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11651. > Some EPS MimeTypes not Resolvable to Extension > -- > > Key: SLING-11651 > URL: https://issues.apache.org/jira/browse/SLING-11651 > Project: Sling > Issue Type: Bug >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Certain systems (such as Adobe's Dynamic Media) produce EPS documents with > the mimetype: image/x-eps which is not in the Common MIME's list of supported > mime types: > [https://github.com/apache/sling-org-apache-sling-commons-mime/tree/master/src/main/resources/META-INF] > > Thus, when attempting to retrieve the extension for a resource with the mime > type image/x-eps, null is returned instead of the expected extension. > We should update Commons MIME to support all common mime type variants for > EPS files: > https://en.wikipedia.org/wiki/Encapsulated_PostScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12079) Update Commons Mime to Bundle Parent 52
[ https://issues.apache.org/jira/browse/SLING-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12079. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-commons-mime/commit/27b42feedc5551fb533f0dd0f5a4b6f7e1ae38fe > Update Commons Mime to Bundle Parent 52 > --- > > Key: SLING-12079 > URL: https://issues.apache.org/jira/browse/SLING-12079 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > > Commons Mime currently uses Bundle Parent v35 which is not compatible with > Java 17. We should update it to the latest parent version to support Java 17 > builds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11652) Update Core Mime Types
[ https://issues.apache.org/jira/browse/SLING-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11652. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-commons-mime/commit/4c82c540376b0797796447f9adf773dbd525beeb > Update Core Mime Types > -- > > Key: SLING-11652 > URL: https://issues.apache.org/jira/browse/SLING-11652 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Commons MIME has a core mime types file derived from httpd v2.4.10 which was > released in 2014. > We should update to the latest mime types file from v2.4.54 which contains > ~300 additional mime types not contained in v2.4.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11652 - Updating to the latest mime type definitions from httpd v2.4.54 [sling-org-apache-sling-commons-mime]
klcodanr merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11652 - Updating to the latest mime type definitions from httpd v2.4.54 [sling-org-apache-sling-commons-mime]
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/4#issuecomment-1749396311 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime=4) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=4=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=4=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=4=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime=4=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime=4=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12079 - Updating to Parent 52 [sling-org-apache-sling-commons-mime]
klcodanr merged PR #6: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12079 - Updating to Parent 52 [sling-org-apache-sling-commons-mime]
sonarcloud[bot] commented on PR #6: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/6#issuecomment-1749373869 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime=6) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=6=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=6=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime=6=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime=6=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime=6=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime=6=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime=6=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12079 - Updating to Parent 52 [sling-org-apache-sling-commons-mime]
klcodanr opened a new pull request, #6: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/6 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12079) Update Commons Mime to Bundle Parent 52
Dan Klco created SLING-12079: Summary: Update Commons Mime to Bundle Parent 52 Key: SLING-12079 URL: https://issues.apache.org/jira/browse/SLING-12079 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons MIME 2.2.2 Reporter: Dan Klco Assignee: Dan Klco Fix For: Commons MIME 2.2.4 Commons Mime currently uses Bundle Parent v35 which is not compatible with Java 17. We should update it to the latest parent version to support Java 17 builds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] no-jira / no-merge : only to trigger tests [sling-org-apache-sling-event]
sonarcloud[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-event/pull/33#issuecomment-1749245605 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event=33) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=33=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=33=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1749170372 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772265#comment-17772265 ] Konrad Windszus edited comment on SLING-12076 at 10/5/23 3:46 PM: -- Because there is no standardized copy notion in https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.1%20Event%20Model and my particular use case is with the JCR provider. For those use cases I have to rely on some implementation specific user data instead. was (Author: kwin): Because there is no standardized copy support in https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.1%20Event%20Model and my particular use case is with the JCR provider. > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772265#comment-17772265 ] Konrad Windszus edited comment on SLING-12076 at 10/5/23 3:46 PM: -- Because there is no standardized copy support in https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.1%20Event%20Model and my particular use case is with the JCR provider. was (Author: kwin): Because there is no standardized move support in https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.1%20Event%20Model and my particular use case is with the JCR provider. > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772265#comment-17772265 ] Konrad Windszus commented on SLING-12076: - Because there is no standardized move support in https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.1%20Event%20Model and my particular use case is with the JCR provider. > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Various improvements for the webconsole plugin [sling-org-apache-sling-resourceresolver]
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1749168200 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=78) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [2.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12054. --- Resolution: Fixed PR merged > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.11.2 > > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the configuration (as > shown in the OSGI Webconsole) should be adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-12078: Description: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo [this|https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93] and [this|https://github.com/apache/sling-org-apache-sling-event/commit/dea04990b770a92f29c2504aa33d8158d68da58f] commit was: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo [this|https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93| and [this|https://github.com/apache/sling-org-apache-sling-event/commit/dea04990b770a92f29c2504aa33d8158d68da58f] commit > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned
[jira] [Updated] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-12078: Description: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo [this|https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93| and [this|https://github.com/apache/sling-org-apache-sling-event/commit/dea04990b770a92f29c2504aa33d8158d68da58f] commit was: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93 > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned subtree, which waits until the next > TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - > which then finds the
[jira] [Commented] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772259#comment-17772259 ] Stefan Egli commented on SLING-12078: - * additional IT test affected, added [same workaround there|https://github.com/apache/sling-org-apache-sling-event/commit/dea04990b770a92f29c2504aa33d8158d68da58f] > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned subtree, which waits until the next > TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - > which then finds the unassigned job and re/assigns it accordingly. So the job > is never lost, but substantially delayed due to this. (the frequency of > TopologyEvents depends on actual cluster/property changes happening in the > topology and can thus vary). > Tasks: > * provide a test case to reproduce > * fix the race-condition > * undo > [this|https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93] > and > [this|https://github.com/apache/sling-org-apache-sling-event/commit/dea04990b770a92f29c2504aa33d8158d68da58f] > commit -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772253#comment-17772253 ] Carsten Ziegeler commented on SLING-12076: -- why not support copy/move events instead? > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-12078: Description: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93 was: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned subtree, which waits until the next > TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - > which then finds the unassigned job and re/assigns it accordingly. So the job > is never lost, but substantially delayed due to this. (the frequency of > TopologyEvents depends on actual cluster/property changes happening in the > topology and can thus
[jira] [Updated] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-12078: Description: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary). Tasks: * provide a test case to reproduce * fix the race-condition * undo was: Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary) > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned subtree, which waits until the next > TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - > which then finds the unassigned job and re/assigns it accordingly. So the job > is never lost, but substantially delayed due to this. (the frequency of > TopologyEvents depends on actual cluster/property changes happening in the > topology and can thus vary). > Tasks: > * provide a test case to reproduce > * fix the race-condition > * undo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
[ https://issues.apache.org/jira/browse/SLING-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772242#comment-17772242 ] Stefan Egli commented on SLING-12078: - * added a [workaround attempt|https://github.com/apache/sling-org-apache-sling-event/commit/d16686705908099b26d0a3233f61c4e209880f93] for 2 in/frequently failing tests - that must be reverted as part of this ticket, once the race-condition is confirmed/fixed > Suspected race condition between TOPOLOGY_INIT and JobManager.addJob > > > Key: SLING-12078 > URL: https://issues.apache.org/jira/browse/SLING-12078 > Project: Sling > Issue Type: Bug > Components: Event >Affects Versions: Event 4.3.12 >Reporter: Stefan Egli >Priority: Major > > Two regular cases where a job is stored as part of JobManager.addJob(): > * when a topology is defined, it directly gets stored to the appropriate > assigned/target slingId subtree. This is the most frequent case by far. > * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put > into the unassigned subtree. Later upon receiving TOPOLOGY_INIT > CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the > corresponding assigned subtree. > There is a suspect race condition (test case to be provided), which happens > between the thread doing JobManager.addJob() and the thread handling the > TOPOLOGY_INIT: > * JobManager.addJob determines the target slingId - which is not yet > defined, as TOPOLOGY_INIT is just being handled concurrently > * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however > does not yet find the above new job in unassigned, as the job is just being > stored concurrently. > The result is a job in the unassigned subtree, which waits until the next > TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - > which then finds the unassigned job and re/assigns it accordingly. So the job > is never lost, but substantially delayed due to this. (the frequency of > TopologyEvents depends on actual cluster/property changes happening in the > topology and can thus vary) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12078) Suspected race condition between TOPOLOGY_INIT and JobManager.addJob
Stefan Egli created SLING-12078: --- Summary: Suspected race condition between TOPOLOGY_INIT and JobManager.addJob Key: SLING-12078 URL: https://issues.apache.org/jira/browse/SLING-12078 Project: Sling Issue Type: Bug Components: Event Affects Versions: Event 4.3.12 Reporter: Stefan Egli Two regular cases where a job is stored as part of JobManager.addJob(): * when a topology is defined, it directly gets stored to the appropriate assigned/target slingId subtree. This is the most frequent case by far. * if no topology is defined (no TOPOLOGY_INIT received) yet, it gets put into the unassigned subtree. Later upon receiving TOPOLOGY_INIT CheckTopologyTask.fullRun() finds such unassigned jobs and moves them to the corresponding assigned subtree. There is a suspect race condition (test case to be provided), which happens between the thread doing JobManager.addJob() and the thread handling the TOPOLOGY_INIT: * JobManager.addJob determines the target slingId - which is not yet defined, as TOPOLOGY_INIT is just being handled concurrently * CheckTopologyTask.fullRun(), as part of TOPOLOGY_INIT handling, however does not yet find the above new job in unassigned, as the job is just being stored concurrently. The result is a job in the unassigned subtree, which waits until the next TopologyEvent happens - which then invokes CheckTopologyTask.fullRun() - which then finds the unassigned job and re/assigns it accordingly. So the job is never lost, but substantially delayed due to this. (the frequency of TopologyEvents depends on actual cluster/property changes happening in the topology and can thus vary) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772235#comment-17772235 ] Konrad Windszus commented on SLING-12076: - Currently ResourceChange doesn't natively support copy/move operations. Still some code only needs to be triggered for those instead of all add/delete operations. In JCR this is usually reflected with user data. Therefore evaluation that is crucial to support those cases. > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12076: Component/s: JCR > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]
kwin commented on PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#issuecomment-1748931451
Alternatively we could move the getter with a more JCR agnostic name
("context"?) to `org.apache.sling.api.resource.observation.ResourceChange` and
leave `JcrResourceChange` not exported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-12076: --- Assignee: Konrad Windszus > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]
kwin opened a new pull request, #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39 getUserData() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12058) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-12058: -- Description: Several of the bundles used in the Sling starter still use javax.json, only a few have migrated to jakarta.json. We should migrate all of them. This is the list from the starter: # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 # org.apache.sling:org.apache.sling.discovery.base:2.0.14 # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 # org.apache.sling:org.apache.sling.junit.remote:1.0.12 # org.apache.sling:org.apache.sling.servlets.post:2.5.0 # org.apache.sling:org.apache.sling.xss:2.3.8 # org.apache.sling:org.apache.sling.fsresource:2.2.0 # -org.apache.felix:org.apache.felix.cm.json:1.0.8- # org.apache.sling:org.apache.sling.adapter:2.2.0 # org.apache.sling:org.apache.sling.junit.core:1.1.6 # org.apache.sling:org.apache.sling.servlets.get:2.1.44 # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 was: Several of the bundles used in the Sling starter still use javax.json, only a few have migrated to jakarta.json. We should migrate all of them. This is the list from the starter: # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 # org.apache.sling:org.apache.sling.discovery.base:2.0.14 # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 # org.apache.sling:org.apache.sling.junit.remote:1.0.12 # org.apache.sling:org.apache.sling.servlets.post:2.5.0 # org.apache.sling:org.apache.sling.xss:2.3.8 # org.apache.sling:org.apache.sling.fsresource:2.2.0 # org.apache.felix:org.apache.felix.cm.json:1.0.8 # org.apache.sling:org.apache.sling.adapter:2.2.0 # org.apache.sling:org.apache.sling.junit.core:1.1.6 # org.apache.sling:org.apache.sling.servlets.get:2.1.44 # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 > Migrate to jakarta.json > --- > > Key: SLING-12058 > URL: https://issues.apache.org/jira/browse/SLING-12058 > Project: Sling > Issue Type: Improvement >Reporter: Carsten Ziegeler >Priority: Major > > Several of the bundles used in the Sling starter still use javax.json, only a > few have migrated to jakarta.json. We should migrate all of them. This is the > list from the starter: > # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 > # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 > # org.apache.sling:org.apache.sling.discovery.base:2.0.14 > # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 > # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 > # org.apache.sling:org.apache.sling.junit.remote:1.0.12 > # org.apache.sling:org.apache.sling.servlets.post:2.5.0 > # org.apache.sling:org.apache.sling.xss:2.3.8 > # org.apache.sling:org.apache.sling.fsresource:2.2.0 > # -org.apache.felix:org.apache.felix.cm.json:1.0.8- > # org.apache.sling:org.apache.sling.adapter:2.2.0 > # org.apache.sling:org.apache.sling.junit.core:1.1.6 > # org.apache.sling:org.apache.sling.servlets.get:2.1.44 > # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12058) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772225#comment-17772225 ] Ashok Pelluru commented on SLING-12058: --- (i) org.apache.felix:org.apache.felix.cm.json is already migrated to jakarta.json > Migrate to jakarta.json > --- > > Key: SLING-12058 > URL: https://issues.apache.org/jira/browse/SLING-12058 > Project: Sling > Issue Type: Improvement >Reporter: Carsten Ziegeler >Priority: Major > > Several of the bundles used in the Sling starter still use javax.json, only a > few have migrated to jakarta.json. We should migrate all of them. This is the > list from the starter: > # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 > # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 > # org.apache.sling:org.apache.sling.discovery.base:2.0.14 > # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 > # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 > # org.apache.sling:org.apache.sling.junit.remote:1.0.12 > # org.apache.sling:org.apache.sling.servlets.post:2.5.0 > # org.apache.sling:org.apache.sling.xss:2.3.8 > # org.apache.sling:org.apache.sling.fsresource:2.2.0 > # org.apache.felix:org.apache.felix.cm.json:1.0.8 > # org.apache.sling:org.apache.sling.adapter:2.2.0 > # org.apache.sling:org.apache.sling.junit.core:1.1.6 > # org.apache.sling:org.apache.sling.servlets.get:2.1.44 > # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12077: migrate to jakarta.json [sling-org-apache-sling-adapter]
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/2#issuecomment-1748912600 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-adapter=2) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter=2=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-adapter=2=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-adapter=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter=2=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-adapter=2=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12077: migrate to jakarta.json [sling-org-apache-sling-adapter]
apelluru opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/2 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12077) Migrate sling.adapter to jakarta.json
Ashok Pelluru created SLING-12077: - Summary: Migrate sling.adapter to jakarta.json Key: SLING-12077 URL: https://issues.apache.org/jira/browse/SLING-12077 Project: Sling Issue Type: Sub-task Reporter: Ashok Pelluru Assignee: Ashok Pelluru -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772220#comment-17772220 ] Carsten Ziegeler commented on SLING-12076: -- What is the use case here? I'm not entirely sure, but events might be "repackaged" in the resource resolver implementation. Carrying around a lot of baggage which is in most cases not needed is probably not a good idea > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772219#comment-17772219 ] Carsten Ziegeler commented on SLING-12076: -- I think thats done deliberately as resource providers can create these and those are defined in the spi package > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose a context
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772216#comment-17772216 ] Konrad Windszus commented on SLING-12076: - Alternatively this one can be exposed just via the subclass https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/685c50921085941f4cbb1a3ccdbf90bad0605527/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceChange.java#L26 but that class is currently not exposed to other bundles. > ResourceListener should expose a context > > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12076: Summary: ResourceListener should expose the JCR observation's user data (was: ResourceListener should expose a context) > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12058) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-12058: -- Description: Several of the bundles used in the Sling starter still use javax.json, only a few have migrated to jakarta.json. We should migrate all of them. This is the list from the starter: # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 # org.apache.sling:org.apache.sling.discovery.base:2.0.14 # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 # org.apache.sling:org.apache.sling.junit.remote:1.0.12 # org.apache.sling:org.apache.sling.servlets.post:2.5.0 # org.apache.sling:org.apache.sling.xss:2.3.8 # org.apache.sling:org.apache.sling.fsresource:2.2.0 # org.apache.felix:org.apache.felix.cm.json:1.0.8 # org.apache.sling:org.apache.sling.adapter:2.2.0 # org.apache.sling:org.apache.sling.junit.core:1.1.6 # org.apache.sling:org.apache.sling.servlets.get:2.1.44 # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 was: Several of the bundles used in the Sling starter still use javax.json, only a few have migrated to jakarta.json. We should migrate all of them. This is the list from the starter: * org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 * org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 * org.apache.sling:org.apache.sling.discovery.base:2.0.14 * org.apache.sling:org.apache.sling.discovery.commons:1.0.28 * org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 * org.apache.sling:org.apache.sling.junit.remote:1.0.12 * org.apache.sling:org.apache.sling.servlets.post:2.5.0 * org.apache.sling:org.apache.sling.xss:2.3.8 * org.apache.sling:org.apache.sling.fsresource:2.2.0 * org.apache.felix:org.apache.felix.cm.json:1.0.8 * org.apache.sling:org.apache.sling.adapter:2.2.0 * org.apache.sling:org.apache.sling.junit.core:1.1.6 * org.apache.sling:org.apache.sling.servlets.get:2.1.44 * org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 > Migrate to jakarta.json > --- > > Key: SLING-12058 > URL: https://issues.apache.org/jira/browse/SLING-12058 > Project: Sling > Issue Type: Improvement >Reporter: Carsten Ziegeler >Priority: Major > > Several of the bundles used in the Sling starter still use javax.json, only a > few have migrated to jakarta.json. We should migrate all of them. This is the > list from the starter: > # org.apache.sling:org.apache.sling.bundleresource.impl:2.3.4 > # org.apache.sling:org.apache.sling.caconfig.impl:1.6.0 > # org.apache.sling:org.apache.sling.discovery.base:2.0.14 > # org.apache.sling:org.apache.sling.discovery.commons:1.0.28 > # org.apache.sling:org.apache.sling.jcr.jackrabbit.accessmanager:3.1.0 > # org.apache.sling:org.apache.sling.junit.remote:1.0.12 > # org.apache.sling:org.apache.sling.servlets.post:2.5.0 > # org.apache.sling:org.apache.sling.xss:2.3.8 > # org.apache.sling:org.apache.sling.fsresource:2.2.0 > # org.apache.felix:org.apache.felix.cm.json:1.0.8 > # org.apache.sling:org.apache.sling.adapter:2.2.0 > # org.apache.sling:org.apache.sling.junit.core:1.1.6 > # org.apache.sling:org.apache.sling.servlets.get:2.1.44 > # org.apache.sling:org.apache.sling.servlets.resolver:2.9.14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12076) ResourceListener should expose a context
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772215#comment-17772215 ] Konrad Windszus commented on SLING-12076: - [~cziegeler] Is the class https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50 deliberately marked as ConsumerType? IMHO this should only be ever implemented by the Resource Providers (which are IMHO provider bundles for that API). > ResourceListener should expose a context > > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12076) ResourceListener should expose a context
Konrad Windszus created SLING-12076: --- Summary: ResourceListener should expose a context Key: SLING-12076 URL: https://issues.apache.org/jira/browse/SLING-12076 Project: Sling Issue Type: Improvement Reporter: Konrad Windszus The ResourceChange (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) should optionally expose a context (arbitrary String). In the case of the JCR Resource Provider this should be populated by the JCR Event's User Data (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11715) ResourceResolver.map resolves same resource twice
[
https://issues.apache.org/jira/browse/SLING-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-11715:
--
Fix Version/s: Resource Resolver 1.11.2
> ResourceResolver.map resolves same resource twice
> -
>
> Key: SLING-11715
> URL: https://issues.apache.org/jira/browse/SLING-11715
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> While investigation repository access I found that a
> {{ResourceResolver.map()}} call invokes
> {{ResourceResolver.resolveInternal()}} twice for the same resource.
> See these parts of the call stack:
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getAbsoluteResourceInternal(ResourceResolverImpl.java:901)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:727)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:145)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:384)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:256)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:220)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> In
> [ResourceResolverMapperImpl.loadAliasesIfApplicable()|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L189]
> a resolved resource is passed, and when no alias is encountered the same
> resource will be resolved again in [line
> 220|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L220].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11715) ResourceResolver.map resolves same resource twice
[
https://issues.apache.org/jira/browse/SLING-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-11715.
---
Resolution: Fixed
> ResourceResolver.map resolves same resource twice
> -
>
> Key: SLING-11715
> URL: https://issues.apache.org/jira/browse/SLING-11715
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> While investigation repository access I found that a
> {{ResourceResolver.map()}} call invokes
> {{ResourceResolver.resolveInternal()}} twice for the same resource.
> See these parts of the call stack:
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getAbsoluteResourceInternal(ResourceResolverImpl.java:901)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:727)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:145)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:384)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:256)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:220)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> In
> [ResourceResolverMapperImpl.loadAliasesIfApplicable()|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L189]
> a resolved resource is passed, and when no alias is encountered the same
> resource will be resolved again in [line
> 220|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L220].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11715) ResourceResolver.map resolves same resource twice
[
https://issues.apache.org/jira/browse/SLING-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772205#comment-17772205
]
Joerg Hoh commented on SLING-11715:
---
PR merged.
It turned out that in the code path of the optimized alias resolution no
repository access is required anymore; but it is still done because much code
was actually shared with the non-optimized case, which still requires
repository access.
So it's just a large refactoring to split the execution paths of both cases.
With the changed code just 1 {{ResourceResolver.resolveInternal()}} call is
done for mapping a path, while without it for each path segment such a call was
done. That means that the biggest improvement can be seen when the
ResourceResolver.map() is invoked on a deep path.
> ResourceResolver.map resolves same resource twice
> -
>
> Key: SLING-11715
> URL: https://issues.apache.org/jira/browse/SLING-11715
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
>
> While investigation repository access I found that a
> {{ResourceResolver.map()}} call invokes
> {{ResourceResolver.resolveInternal()}} twice for the same resource.
> See these parts of the call stack:
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getAbsoluteResourceInternal(ResourceResolverImpl.java:901)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:727)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:145)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> {noformat}
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:384)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:256)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.loadAliasesIfApplicable(ResourceMapperImpl.java:220)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:147)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> [org.apache.sling.resourceresolver:1.10.0]
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.map(ResourceResolverImpl.java:445)
> [org.apache.sling.resourceresolver:1.10.0]
> {noformat}
> In
> [ResourceResolverMapperImpl.loadAliasesIfApplicable()|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L189]
> a resolved resource is passed, and when no alias is encountered the same
> resource will be resolved again in [line
> 220|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/ac8b0ad5a75a26a00ef88c7d322b8be2b5495dfb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L220].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-11715 in the optimized code path avoid resource resolution [sling-org-apache-sling-resourceresolver]
joerghoh merged PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] no-jira / no-merge : only to trigger tests [sling-org-apache-sling-event]
sonarcloud[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-event/pull/33#issuecomment-1748812364 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event=33) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=33=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=33=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=33=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=33=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] no-jira / no-merge : only to trigger tests [sling-org-apache-sling-event]
stefan-egli opened a new pull request, #33: URL: https://github.com/apache/sling-org-apache-sling-event/pull/33 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1050 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1050/ for details. No further emails will be sent until the status of the build is changed.
[VOTE] Release Apache Sling Servlets Get 2.2.0, Post 2.6.0, Resolver 2.10.0
Hi, We solved 3 issues for servlets resolver 2.10.0 https://issues.apache.org/jira/projects/SLING/versions/12353474 We solved 4 issues for servlets get 2.2.0 https://issues.apache.org/jira/projects/SLING/versions/12352682 We solved 3 issues for servlets post 2.10.0 https://issues.apache.org/jira/projects/SLING/versions/12352478 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2791/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2791 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Closed] (SLING-11741) Provide alternative terminology for inequitable terms
[ https://issues.apache.org/jira/browse/SLING-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11741. > Provide alternative terminology for inequitable terms > - > > Key: SLING-11741 > URL: https://issues.apache.org/jira/browse/SLING-11741 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Base 3.1.12 >Reporter: Cioriia Cristian >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Base 3.2.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and > "blacklist" e.g. "whitelist.bypass", "whitelist.bundles.regexp" which is > considered inequitable terminology and some customers are prevented to use > these terms by their git commit policies. > Therefore, some more acceptable equivalents should be provided for these > terms. The proposal is to provide the "allowedlist.bypass" and > "allowedlist.bundles.regexp" alternatives for them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11819) Update to latest Sling mock dependencies
[ https://issues.apache.org/jira/browse/SLING-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11819. > Update to latest Sling mock dependencies > > > Key: SLING-11819 > URL: https://issues.apache.org/jira/browse/SLING-11819 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Base 3.2.0 > > Time Spent: 50m > Remaining Estimate: 0h > > We should update to the latest Sling mock dependencies and to the latest > parent to no longer be forced to manage the dependency scope (see discussion > in SLING-11818). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling JCR Base 3.2.0
The vote passed with four binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling JCR Base 3.2.0
+1 Carsten On 02.10.2023 07:10, Carsten Ziegeler wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12353098 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2789/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2789 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[jira] [Updated] (SLING-11979) update servlets-resolver to parent 52
[ https://issues.apache.org/jira/browse/SLING-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11979: - Fix Version/s: (was: Servlets Resolver 2.9.16) > update servlets-resolver to parent 52 > - > > Key: SLING-11979 > URL: https://issues.apache.org/jira/browse/SLING-11979 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets Resolver 2.9.12 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12075) Migrate sling.servlets.resolver to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12075. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/9e94e3ca03e7705624754788461199dc11ec5d90 > Migrate sling.servlets.resolver to jakarta.json > --- > > Key: SLING-12075 > URL: https://issues.apache.org/jira/browse/SLING-12075 > Project: Sling > Issue Type: Sub-task > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Resolver 2.9.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772155#comment-17772155
]
Robert Munteanu commented on SLING-10506:
-
[~olli] - you created the initial rule exclusion list, can you answer
[~bellingard]'s question?
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12075) Migrate sling.servlets.resolver to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12075: - Component/s: Servlets > Migrate sling.servlets.resolver to jakarta.json > --- > > Key: SLING-12075 > URL: https://issues.apache.org/jira/browse/SLING-12075 > Project: Sling > Issue Type: Sub-task > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Resolver 2.9.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12075) Migrate sling.servlets.resolver to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12075: - Fix Version/s: Servlets Resolver 2.9.16 > Migrate sling.servlets.resolver to jakarta.json > --- > > Key: SLING-12075 > URL: https://issues.apache.org/jira/browse/SLING-12075 > Project: Sling > Issue Type: Sub-task >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Resolver 2.9.16 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12075) Migrate sling.servlets.resolver to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-12075: Assignee: Carsten Ziegeler > Migrate sling.servlets.resolver to jakarta.json > --- > > Key: SLING-12075 > URL: https://issues.apache.org/jira/browse/SLING-12075 > Project: Sling > Issue Type: Sub-task >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11971) Log duration of each PostProcessor
[ https://issues.apache.org/jira/browse/SLING-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11971: - Fix Version/s: (was: Servlets POST 2.5.2) > Log duration of each PostProcessor > -- > > Key: SLING-11971 > URL: https://issues.apache.org/jira/browse/SLING-11971 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Sling Post Servlet should log the duration of each postprocessor into the > RequestProgressTracker, which allows to debug potential performance issues > easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12073) Migrate sling.servlets.get to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-12073. --- Resolution: Fixed > Migrate sling.servlets.get to jakarta.json > -- > > Key: SLING-12073 > URL: https://issues.apache.org/jira/browse/SLING-12073 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Servlets Get 2.1.46 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12073: migrate to jakarta.json [sling-org-apache-sling-servlets-get]
apelluru merged PR #13: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12069) Migrate sling.servlets.post to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-12069. --- Resolution: Fixed > Migrate sling.servlets.post to jakarta.json > --- > > Key: SLING-12069 > URL: https://issues.apache.org/jira/browse/SLING-12069 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Servlets POST 2.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12069: migrate to jakarta.json [sling-org-apache-sling-servlets-post]
apelluru merged PR #24: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12075) Migrate sling.servlets.resolver to jakarta.json
Carsten Ziegeler created SLING-12075: Summary: Migrate sling.servlets.resolver to jakarta.json Key: SLING-12075 URL: https://issues.apache.org/jira/browse/SLING-12075 Project: Sling Issue Type: Sub-task Reporter: Carsten Ziegeler -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346880573
##
src/main/java/org/apache/sling/servlets/post/impl/operations/ModifyOperation.java:
##
@@ -134,13 +163,13 @@ protected String getResourcePath(SlingHttpServletRequest
request) {
// check whether it is a create request (trailing /)
if (suffix.endsWith(SlingPostConstants.DEFAULT_CREATE_SUFFIX)) {
suffix = suffix.substring(0, suffix.length()
-- SlingPostConstants.DEFAULT_CREATE_SUFFIX.length());
+- SlingPostConstants.DEFAULT_CREATE_SUFFIX.length());
Review Comment:
From here on there are a lot of formatting changes; it would be good to
leave them out of the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346879972
##
src/main/java/org/apache/sling/servlets/post/impl/operations/AbstractPostOperation.java:
##
@@ -106,7 +108,10 @@ public void run(final SlingHttpServletRequest request,
try {
if (processors != null) {
for (SlingPostProcessor processor : processors) {
+Instant start = Instant.now();
Review Comment:
Same here, tracker provides already a timer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346879632
##
src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java:
##
@@ -108,11 +112,15 @@ public void run(final SlingHttpServletRequest request,
// invoke processors
if (processors != null) {
for (SlingPostProcessor processor : processors) {
+Instant start = Instant.now();
+request.getRequestProgressTracker().log("About to perform
processor {}", processor.getClass().getName());
Review Comment:
Why not use the timer function of the tracker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346878021
##
src/main/java/org/apache/sling/servlets/post/impl/operations/ModifyOperation.java:
##
@@ -48,6 +52,8 @@
*/
public class ModifyOperation extends AbstractCreateOperation {
+Logger logger = LoggerFactory.getLogger(this.getClass());
Review Comment:
Why introducing a logger here? It gets inherited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346875986
##
src/main/java/org/apache/sling/servlets/post/impl/operations/AbstractPostOperation.java:
##
@@ -59,7 +61,7 @@ public abstract class AbstractPostOperation implements
PostOperation {
/**
* Default logger
*/
-protected final Logger log = LoggerFactory.getLogger(getClass());
+protected final Logger log =
LoggerFactory.getLogger(AbstractPostOperation.class);
Review Comment:
Again, why change the logger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-11971 Adding additional logging for sling post processors [sling-org-apache-sling-servlets-post]
cziegeler commented on code in PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22#discussion_r1346874666
##
src/main/java/org/apache/sling/servlets/post/AbstractPostOperation.java:
##
@@ -62,7 +66,7 @@ public abstract class AbstractPostOperation implements
PostOperation {
/**
* default log
*/
-protected final Logger log = LoggerFactory.getLogger(getClass());
+protected final Logger log =
LoggerFactory.getLogger(AbstractPostOperation.class);
Review Comment:
Why this change? now all subclasses log with the same logger, instead of
using separate ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SLING-12073) Migrate sling.servlets.get to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12073: - Fix Version/s: Servlets Get 2.1.46 > Migrate sling.servlets.get to jakarta.json > -- > > Key: SLING-12073 > URL: https://issues.apache.org/jira/browse/SLING-12073 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Servlets Get 2.1.46 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12069) Migrate sling.servlets.post to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12069: - Fix Version/s: Servlets POST 2.5.2 > Migrate sling.servlets.post to jakarta.json > --- > > Key: SLING-12069 > URL: https://issues.apache.org/jira/browse/SLING-12069 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Ashok Pelluru >Priority: Minor > Fix For: Servlets POST 2.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
