Re: [PR] Make commons metrics optional [sling-org-apache-sling-xss]
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/41#issuecomment-1839945702 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss=41) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=BUG) [![B](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B-16px.png 'B')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=41=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=41=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=41=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=41=false=CODE_SMELL) [![16.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '16.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=41=new_coverage=list) [16.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=41=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=41=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=41=new_duplicated_lines_density=list) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'sonarlint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Make commons metrics optional [sling-org-apache-sling-xss]
karlpauls opened a new pull request, #41: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/41 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Make i18n dependency optional [sling-org-apache-sling-scripting-sightly]
karlpauls opened a new pull request, #24: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/24 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12177) Status poller is created once per agent but should only be created once
Christian Schneider created SLING-12177: --- Summary: Status poller is created once per agent but should only be created once Key: SLING-12177 URL: https://issues.apache.org/jira/browse/SLING-12177 Project: Sling Issue Type: Bug Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.3.0 We are creating the status poller once per distribution agent: [https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/0e38eb8dc91008f70c5ea64b4e1906afdc7dfda5/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L170] This causes a lot of stress on the system as we also read the topic from earliest. So if we have 4 agents we read all status messages 4 times which can be considerable data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12057) Replace commons.threads with Executor
[ https://issues.apache.org/jira/browse/SLING-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-12057. Resolution: Fixed > Replace commons.threads with Executor > - > > Key: SLING-12057 > URL: https://issues.apache.org/jira/browse/SLING-12057 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: Scripting Core 2.4.10 > > > In order to minimize dependencies for core Sling, we could replace usage of > the commons.threads (which is not used in any other core bundle) with > Executor api > [~radu] WDYT? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12057: Replace commons.threads with Executor and embed commons.… [sling-org-apache-sling-scripting-core]
karlpauls merged PR #27: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12057) Replace commons.threads with Executor
[ https://issues.apache.org/jira/browse/SLING-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-12057: -- Assignee: Karl Pauls > Replace commons.threads with Executor > - > > Key: SLING-12057 > URL: https://issues.apache.org/jira/browse/SLING-12057 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: Scripting Core 2.4.10 > > > In order to minimize dependencies for core Sling, we could replace usage of > the commons.threads (which is not used in any other core bundle) with > Executor api > [~radu] WDYT? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12176) Replace usage of commons.osgi with osgi converter
[ https://issues.apache.org/jira/browse/SLING-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12176. -- Resolution: Fixed Replaced in https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/6d94526f18855eec1bcda5d58d508a6b5fab81f4 This fixes also the wrong handling of the service ranking property which should only be used if the type is Integer. > Replace usage of commons.osgi with osgi converter > - > > Key: SLING-12176 > URL: https://issues.apache.org/jira/browse/SLING-12176 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting HTL Engine 1.4.24-1.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12176) Replace usage of commons.osgi with osgi converter
Carsten Ziegeler created SLING-12176: Summary: Replace usage of commons.osgi with osgi converter Key: SLING-12176 URL: https://issues.apache.org/jira/browse/SLING-12176 Project: Sling Issue Type: Improvement Components: Scripting Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Scripting HTL Engine 1.4.24-1.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12057: Replace commons.threads with Executor and embed commons.… [sling-org-apache-sling-scripting-core]
karlpauls opened a new pull request, #27: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/27 …compiler.source -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[ https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792857#comment-17792857 ] Robert Munteanu commented on SLING-12173: - Opening an older project greeted me with a javax.json error, so this does not seem related to jakarta only. {noformat}An internal error occurred during: "Building". javax.json.spi.JsonProvider: org.apache.johnzon.core.JsonProviderImpl not a subtype{noformat} > Configuration errors in Eclipse for projects using the > slingfeature-maven-plugin > > > Key: SLING-12173 > URL: https://issues.apache.org/jira/browse/SLING-12173 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > The slingfeature-maven-plugin currently uses the Jakarta JSON implementation > of the Apache Johnzon parser. > I have noticed problems in the Eclipse IDE, where projects fail to update > with hard to isolate errors (see below). > {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: > org.apache.johnzon.core.JsonProviderImpl not a subtype > at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273) > at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) > at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393) > at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69) > at jakarta.json.Json.createReader(Json.java:189) > at > org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64) > at > org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622) > at > org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110) > at > org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790) > at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318) > at > org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146) > at > org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at >
[jira] [Resolved] (SLING-12076) ResourceListener should expose the JCR observation's user data
[ https://issues.apache.org/jira/browse/SLING-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12076. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/8fb5a3d44de01f05964028debcf24531f2f65747. > ResourceListener should expose the JCR observation's user data > -- > > Key: SLING-12076 > URL: https://issues.apache.org/jira/browse/SLING-12076 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: JCR Resource 3.2.6 > > > The ResourceChange > (https://github.com/apache/sling-org-apache-sling-api/blob/f58111baf07b6ae525aec2c6792e949786df7beb/src/main/java/org/apache/sling/api/resource/observation/ResourceChange.java#L50) > should optionally expose a context (arbitrary String). In the case of the > JCR Resource Provider this should be populated by the JCR Event's User Data > (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.5%20User%20Data). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]
kwin merged PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12175) Remove PubQueueProvider cacheCallBack
Christian Schneider created SLING-12175: --- Summary: Remove PubQueueProvider cacheCallBack Key: SLING-12175 URL: https://issues.apache.org/jira/browse/SLING-12175 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.3.0 At some point I introduced the CacheCallBack as we thought about splitting the journal bundle. This change introduced a lot of indirection which complicated the code but provided no gains. So I would like to remove this separation again. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12173 - Configuration errors in Eclipse for projects using the slingfeature-maven-plugin [sling-slingfeature-maven-plugin]
rombert opened a new pull request, #82: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/82 Use version 2.1 of the Jakarta JSON APIs. Migrate to Parsson at the same time, since Johnzon does not yet support that API level ( https://issues.apache.org/jira/browse/JOHNZON-389 ). Some minor whitespace changes were made to the ITs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[ https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792762#comment-17792762 ] Robert Munteanu commented on SLING-12173: - Good point [~cziegeler]. I have made the following change to the POM {noformat} diff --git a/pom.xml b/pom.xml index 1172d97..d308a5b 100644 --- a/pom.xml +++ b/pom.xml @@ -190,14 +190,13 @@ jakarta.json jakarta.json-api -2.0.2 +2.1.3 compile -org.apache.johnzon -johnzon-core -jakarta -1.2.21 +org.eclipse.parsson +parsson +1.1.5 compile {noformat} and it seems to work fine in Eclipse now. It did not work with jakata.json-api 2.0.2 and parssson 1.0.3. I will keep working with this change locally for a while to make sure the problem does not reappear. > Configuration errors in Eclipse for projects using the > slingfeature-maven-plugin > > > Key: SLING-12173 > URL: https://issues.apache.org/jira/browse/SLING-12173 > Project: Sling > Issue Type: Bug > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: OSGi Feature Maven Plugin 1.8.2 > > > The slingfeature-maven-plugin currently uses the Jakarta JSON implementation > of the Apache Johnzon parser. > I have noticed problems in the Eclipse IDE, where projects fail to update > with hard to isolate errors (see below). > {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: > org.apache.johnzon.core.JsonProviderImpl not a subtype > at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244) > at > java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273) > at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) > at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393) > at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69) > at jakarta.json.Json.createReader(Json.java:189) > at > org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64) > at > org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622) > at > org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145) > at > org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110) > at > org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790) > at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275) > at > org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366) > at > org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318) > at >