Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060088293 Thanks @rombert. Later on, I had changed the scope to runtime as these are not needed for compile but needed at runtime for tests to run. Similar to Line#98 in the pom. If you could change it, it would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059914892 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=8=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=8=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059430499 @sufyanharoon - I added a small comment on top of your changes from #7 , hope this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert opened a new pull request, #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2059409129 Hm, why did this get closed? I don't remember deleting this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes
[
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-9327.
Resolution: Fixed
Merged
https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/6, I
think we can close this now.
> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
> at
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
> at
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
> at
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with
> missing osgi core dependency, unless I would then add it manually in the test
> module pom.
> Note from [~bdelacretaz]
> As per
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
> it looks like using {{jakarta.xml.bind}} as an additional dependency might
> fix this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert closed pull request #7: SLING-11633 - Compile with Java 11 URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-9327 - Teleporter not working with jdk11 due to missing xml bind classes [sling-org-apache-sling-junit-teleporter]
rombert merged PR #6: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12292) Improve metric support
[ https://issues.apache.org/jira/browse/SLING-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12292: Component/s: Content Distribution > Improve metric support > -- > > Key: SLING-12292 > URL: https://issues.apache.org/jira/browse/SLING-12292 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies
[ https://issues.apache.org/jira/browse/SLING-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12288: Component/s: Content Distribution > Allow configuration of SubscriberReady forceIdleMillies > --- > > Key: SLING-12288 > URL: https://issues.apache.org/jira/browse/SLING-12288 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Currently we set this to SubscriberReady.DEFAULT_FORCE_IDLE_MILLIS. > For some cases we need a longer timeout though. So this should also be > configurable via the config map. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12226) Support continuous incoming distributions in subscriber readiness
[ https://issues.apache.org/jira/browse/SLING-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12226: Component/s: Content Distribution > Support continuous incoming distributions in subscriber readiness > - > > Key: SLING-12226 > URL: https://issues.apache.org/jira/browse/SLING-12226 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Refine readiness check for subscriber to also cover case of continuous > incoming distributions. > If there are continuous incoming distributions then the readiness checks will > only report ready after the fallback time of 5 minutes. > Jörg proposed to also have a check how old distribution messages are. If they > are new enough we should report ready. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12293) Remove jcr binarystore
[ https://issues.apache.org/jira/browse/SLING-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12293: Component/s: Content Distribution > Remove jcr binarystore > -- > > Key: SLING-12293 > URL: https://issues.apache.org/jira/browse/SLING-12293 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Jcr binary store is not used for a long time. We can safely remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12289) PackageStatusWatcher should ignore additional status for the same package
[ https://issues.apache.org/jira/browse/SLING-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12289: Component/s: Content Distribution > PackageStatusWatcher should ignore additional status for the same package > - > > Key: SLING-12289 > URL: https://issues.apache.org/jira/browse/SLING-12289 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > If a second status message arrives when we already have a status stored > locally we should ignore the new status message. > This is to avoid that a restarted system after node store compaction works > with a different status than the running system. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12292) Improve metric support
[ https://issues.apache.org/jira/browse/SLING-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12292. - Resolution: Fixed > Improve metric support > -- > > Key: SLING-12292 > URL: https://issues.apache.org/jira/browse/SLING-12292 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12295) Add queue size metric
Christian Schneider created SLING-12295: --- Summary: Add queue size metric Key: SLING-12295 URL: https://issues.apache.org/jira/browse/SLING-12295 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies
[ https://issues.apache.org/jira/browse/SLING-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12288. - Resolution: Fixed > Allow configuration of SubscriberReady forceIdleMillies > --- > > Key: SLING-12288 > URL: https://issues.apache.org/jira/browse/SLING-12288 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Currently we set this to SubscriberReady.DEFAULT_FORCE_IDLE_MILLIS. > For some cases we need a longer timeout though. So this should also be > configurable via the config map. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12289) PackageStatusWatcher should ignore additional status for the same package
[ https://issues.apache.org/jira/browse/SLING-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12289. - Resolution: Fixed > PackageStatusWatcher should ignore additional status for the same package > - > > Key: SLING-12289 > URL: https://issues.apache.org/jira/browse/SLING-12289 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > If a second status message arrives when we already have a status stored > locally we should ignore the new status message. > This is to avoid that a restarted system after node store compaction works > with a different status than the running system. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12289) PackageStatusWatcher should ignore additional status for the same package
[ https://issues.apache.org/jira/browse/SLING-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12289: Description: If a second status message arrives when we already have a status stored locally we should ignore the new status message. This is to avoid that a restarted system after node store compaction works with a different status than the running system. was:If a second status message arrives when we already have a status stored locally we should ignore the new status message. > PackageStatusWatcher should ignore additional status for the same package > - > > Key: SLING-12289 > URL: https://issues.apache.org/jira/browse/SLING-12289 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > If a second status message arrives when we already have a status stored > locally we should ignore the new status message. > This is to avoid that a restarted system after node store compaction works > with a different status than the running system. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12294) Remove buffer on subscriber side
[ https://issues.apache.org/jira/browse/SLING-12294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12294: Fix Version/s: Content Distribution Journal Core 0.4.0 (was: Content Distribution Journal Core 0.3.0) > Remove buffer on subscriber side > > > Key: SLING-12294 > URL: https://issues.apache.org/jira/browse/SLING-12294 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.4.0 > > > As we now do batching on messaging side I think, there is no need for the > items buffer anymore. By removing it we can remove quite some complexity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12274) Introduce Import Pre-Processor Hook
[ https://issues.apache.org/jira/browse/SLING-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-12274. - Resolution: Fixed > Introduce Import Pre-Processor Hook > --- > > Key: SLING-12274 > URL: https://issues.apache.org/jira/browse/SLING-12274 > Project: Sling > Issue Type: New Feature > Components: Content Distribution >Reporter: Danilo Banjac >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Introduce a pre-processor hook that will be executed before the content > import process begins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2058609691 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-junit-teleporter=7=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-junit-teleporter=7=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-junit-teleporter=7) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
