sling:match and mapping
Hi, if I read [1] right, it is possible to use backreferences to matching groups in the path for creating the URL in RR.map() Does this outdate the warning regarding usage of regular expressions on [2]? It now says Since the entries in the /etc/map are also used to reverse map any resource paths to URLs, using regular expressions in the Root Level Mappings prevent the respective entries from being used for reverse mappings. Therefor, it is strongly recommended to not use regular expression matching, unless you have a strong need. Would it make sense to change the last sentence to the following or similar? Therefore, it is strongly recommended to only use regular expression matching in sling:match if you set up corresponding entries using regular expressions in sling:internalRedirect and backreferences in sling:match to allow the resolutions enabled by regex matching to be matched back when mapping content paths to URLs [1] https://issues.apache.org/jira/browse/SLING-2560 [2] http://sling.apache.org/documentation/the-sling-engine/mappings-for-resource-resolution.html Cheers Ben -- Ben Peter M: +49 151 27580088
[jira] [Resolved] (SLING-3119) Startup Filter: move to HTTP filter to prevent authentication before startup has completed
[ https://issues.apache.org/jira/browse/SLING-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Peter resolved SLING-3119. -- Resolution: Fixed Thank you, Bertrand! Startup Filter: move to HTTP filter to prevent authentication before startup has completed -- Key: SLING-3119 URL: https://issues.apache.org/jira/browse/SLING-3119 Project: Sling Issue Type: Bug Components: Extensions Reporter: Ben Peter Assignee: Bertrand Delacretaz Priority: Minor Attachments: SLING-3119.patch The current StartupFilter implementation is a Sling filter which prevents requests from being processed only after all HTTP filters have been called and authentication has been handled. Making this an HTTP filter registered with the Felix ExtHttpService would answer requests with 503 much earlier. Such a filter must still allow access to felix.webconsole.manager.root, typically /system/console -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3119) Startup Filter: move to HTTP filter to prevent authentication before startup has completed
Ben Peter created SLING-3119:
Summary: Startup Filter: move to HTTP filter to prevent
authentication before startup has completed
Key: SLING-3119
URL: https://issues.apache.org/jira/browse/SLING-3119
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Ben Peter
Priority: Minor
The current {{StartupFilter}} implementation is a Sling filter which prevents
requests from being processed only after all HTTP filters have been called and
authentication has been handled.
Making this an HTTP filter registered with the Felix {{ExtHttpService}} would
answer requests with 503 much earlier.
Such a filter must still allow access to {{felix.webconsole.manager.root}},
typically {{/system/console}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3119) Startup Filter: move to HTTP filter to prevent authentication before startup has completed
[
https://issues.apache.org/jira/browse/SLING-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Peter updated SLING-3119:
-
Description:
The current StartupFilter implementation is a Sling filter which prevents
requests from being processed only after all HTTP filters have been called and
authentication has been handled.
Making this an HTTP filter registered with the Felix ExtHttpService would
answer requests with 503 much earlier.
Such a filter must still allow access to felix.webconsole.manager.root,
typically /system/console
was:
The current {{StartupFilter}} implementation is a Sling filter which prevents
requests from being processed only after all HTTP filters have been called and
authentication has been handled.
Making this an HTTP filter registered with the Felix {{ExtHttpService}} would
answer requests with 503 much earlier.
Such a filter must still allow access to {{felix.webconsole.manager.root}},
typically {{/system/console}}
Startup Filter: move to HTTP filter to prevent authentication before startup
has completed
--
Key: SLING-3119
URL: https://issues.apache.org/jira/browse/SLING-3119
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Ben Peter
Priority: Minor
The current StartupFilter implementation is a Sling filter which prevents
requests from being processed only after all HTTP filters have been called
and authentication has been handled.
Making this an HTTP filter registered with the Felix ExtHttpService would
answer requests with 503 much earlier.
Such a filter must still allow access to felix.webconsole.manager.root,
typically /system/console
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3119) Startup Filter: move to HTTP filter to prevent authentication before startup has completed
[ https://issues.apache.org/jira/browse/SLING-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Peter updated SLING-3119: - Attachment: SLING-3119.patch attaching patch Startup Filter: move to HTTP filter to prevent authentication before startup has completed -- Key: SLING-3119 URL: https://issues.apache.org/jira/browse/SLING-3119 Project: Sling Issue Type: Bug Components: Extensions Reporter: Ben Peter Priority: Minor Attachments: SLING-3119.patch The current StartupFilter implementation is a Sling filter which prevents requests from being processed only after all HTTP filters have been called and authentication has been handled. Making this an HTTP filter registered with the Felix ExtHttpService would answer requests with 503 much earlier. Such a filter must still allow access to felix.webconsole.manager.root, typically /system/console -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2911) Wrong explanation of filter order based on service.ranking
Ben Peter created SLING-2911:
Summary: Wrong explanation of filter order based on service.ranking
Key: SLING-2911
URL: https://issues.apache.org/jira/browse/SLING-2911
Project: Sling
Issue Type: Bug
Components: Documentation
Reporter: Ben Peter
http://sling.apache.org/documentation/the-sling-engine/filters.html contains
the following as an explanation for {{service.ranking}}:
{quote}
Indication of where to place the filter in the filter chain. The higher the
number the earlier in the filter chain. This value may span the whole range of
integer values.
{quote}
It seems the opposite is true (the lower the numer, the earlier in the filter
chain).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2730) Allow JSPs to be excluded from compilation in maven-jspc-plugin
[ https://issues.apache.org/jira/browse/SLING-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Peter updated SLING-2730: - Attachment: SLING-2730-take2.patch Allow JSPs to be excluded from compilation in maven-jspc-plugin --- Key: SLING-2730 URL: https://issues.apache.org/jira/browse/SLING-2730 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Affects Versions: Maven JSPC Plugin 2.0.6 Reporter: Ben Peter Assignee: Carsten Ziegeler Priority: Minor Attachments: SLING-2730.patch, SLING-2730-take2.patch JSPs may contain symbols that are declared not in the JSP itself, but in a JSP that includes it (although that may be considered bad style). including.jsp: %String foo = bar; % %@include file=included.jsp % included.jsp: %= foo % The result is that such a JSP does not compile on its own and the goal will fail. This can be circumvented if individual JSPs can be excluded from compilation. Excluding them from the resources to start with does not help, as they are still required for the including JSPs to compile. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2730) Allow JSPs to be excluded from compilation in maven-jspc-plugin
Ben Peter created SLING-2730: Summary: Allow JSPs to be excluded from compilation in maven-jspc-plugin Key: SLING-2730 URL: https://issues.apache.org/jira/browse/SLING-2730 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Affects Versions: Maven JSPC Plugin 2.0.6 Reporter: Ben Peter Priority: Minor JSPs may contain symbols that are declared not in the JSP itself, but in a JSP that includes it (although that may be considered bad style). including.jsp: %String foo = bar; % %@include file=included.jsp % included.jsp: %= foo % The result is that such a JSP does not compile on its own and the goal will fail. This can be circumvented if individual JSPs can be excluded from compilation. Excluding them from the resources to start with does not help, as they are still required for the including JSPs to compile. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2730) Allow JSPs to be excluded from compilation in maven-jspc-plugin
[ https://issues.apache.org/jira/browse/SLING-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Peter updated SLING-2730: - Attachment: SLING-2730.patch Attaching patch Allow JSPs to be excluded from compilation in maven-jspc-plugin --- Key: SLING-2730 URL: https://issues.apache.org/jira/browse/SLING-2730 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Affects Versions: Maven JSPC Plugin 2.0.6 Reporter: Ben Peter Priority: Minor Attachments: SLING-2730.patch JSPs may contain symbols that are declared not in the JSP itself, but in a JSP that includes it (although that may be considered bad style). including.jsp: %String foo = bar; % %@include file=included.jsp % included.jsp: %= foo % The result is that such a JSP does not compile on its own and the goal will fail. This can be circumvented if individual JSPs can be excluded from compilation. Excluding them from the resources to start with does not help, as they are still required for the including JSPs to compile. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2449) background servlets: enable tracking of user, status-code, content-type, length and encoding
[
https://issues.apache.org/jira/browse/SLING-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Peter updated SLING-2449:
-
Attachment:
SLING-2449_background_servlets__enable_tracking_of_user,_status-code,_content-type,_length.patch
Taken against revision 1231138
background servlets: enable tracking of user, status-code, content-type,
length and encoding
Key: SLING-2449
URL: https://issues.apache.org/jira/browse/SLING-2449
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Ben Peter
Labels: patch
Attachments:
SLING-2449_background_servlets__enable_tracking_of_user,_status-code,_content-type,_length.patch
Enable background jobs to store the user on whose behalf the request was
backgrounded
Enable background job to store the following data from the result of the
backgrounded request:
* HTTP Status
* Status Message
* Content-Type
* Content-Length
* Character-Encoding
Change {{JobStreamServlet}} to return the stored data appropriately
Change {{JobConsolePlugin}} to display information on User, Status Code and
Message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2449) background servlets: enable tracking of user, status-code, content-type, length and encoding
[
https://issues.apache.org/jira/browse/SLING-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Peter updated SLING-2449:
-
Labels: patch (was: )
background servlets: enable tracking of user, status-code, content-type,
length and encoding
Key: SLING-2449
URL: https://issues.apache.org/jira/browse/SLING-2449
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Ben Peter
Labels: patch
Attachments:
SLING-2449_background_servlets__enable_tracking_of_user,_status-code,_content-type,_length.patch
Enable background jobs to store the user on whose behalf the request was
backgrounded
Enable background job to store the following data from the result of the
backgrounded request:
* HTTP Status
* Status Message
* Content-Type
* Content-Length
* Character-Encoding
Change {{JobStreamServlet}} to return the stored data appropriately
Change {{JobConsolePlugin}} to display information on User, Status Code and
Message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2449) background servlets: enable tracking of user, status-code, content-type, length and encoding
[
https://issues.apache.org/jira/browse/SLING-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239405#comment-13239405
]
Ben Peter commented on SLING-2449:
--
It would probably make sense to support a larger part of the
SlingHttpServletResponse interface, esp. adding headers and cookies, but this
goes towards a full JCR-based response serialization - that should perhaps not
be locked in with the background jobs but be available for other purposes as
well. From a first scan, nothing of the kind is available yet.
I briefly scanned for header and cookie serialization to JCR but didn't see
anything.
background servlets: enable tracking of user, status-code, content-type,
length and encoding
Key: SLING-2449
URL: https://issues.apache.org/jira/browse/SLING-2449
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Ben Peter
Labels: patch
Attachments:
SLING-2449_background_servlets__enable_tracking_of_user,_status-code,_content-type,_length.patch
Enable background jobs to store the user on whose behalf the request was
backgrounded
Enable background job to store the following data from the result of the
backgrounded request:
* HTTP Status
* Status Message
* Content-Type
* Content-Length
* Character-Encoding
Change {{JobStreamServlet}} to return the stored data appropriately
Change {{JobConsolePlugin}} to display information on User, Status Code and
Message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2156) Provide error handling for POST operations
[ https://issues.apache.org/jira/browse/SLING-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163579#comment-13163579 ] Ben Peter commented on SLING-2156: -- Justin, +1 for your proposed patch. ( line 242 in [1] should test for response != null, though I guess). [1] http://codereview.appspot.com/4826051/diff/1/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java Best, Ben Provide error handling for POST operations -- Key: SLING-2156 URL: https://issues.apache.org/jira/browse/SLING-2156 Project: Sling Issue Type: New Feature Components: Servlets Reporter: Antonio Sanso Attachments: SLING-2156-patch.txt, SLING-2156-patch.txt, SLING-2156-patch.txt, SLING-2156-patch.txt, post_error_handling The error handling mechanism described here [0] doesn't seem to apply also to POST operations. If an error occurs while posting a resource to repository (e.g. avax.jcr.nodetype.ConstraintViolationException: no matching property definition found for) the HtmlResponse.html template is rendered. This can also represent a security issue since information as REFERRER/technology stack are shown. IMHO this page should be at least configurable (if the mechanism in [0] doesn't suite here). [0] http://sling.apache.org/site/errorhandling.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
