[jira] [Closed] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
[ https://issues.apache.org/jira/browse/SLING-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12308. > Potential ArrayIndexOutOfBoundsException with global transformers > - > > Key: SLING-12308 > URL: https://issues.apache.org/jira/browse/SLING-12308 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.4 > > > When several global transformers are configured but one of them does not > match the current request, an ArrayIndexOutOfBoundsException might be thrown > as the code assumes all transformers match. > This only happens if there is a matching transformer *after* one that does > not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
[ https://issues.apache.org/jira/browse/SLING-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12308. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/26976e1b370ef2734428dc80ba3ae2fec3f0351b Added test case > Potential ArrayIndexOutOfBoundsException with global transformers > - > > Key: SLING-12308 > URL: https://issues.apache.org/jira/browse/SLING-12308 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.4 > > > When several global transformers are configured but one of them does not > match the current request, an ArrayIndexOutOfBoundsException might be thrown > as the code assumes all transformers match. > This only happens if there is a matching transformer *after* one that does > not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.6 (was: Rewriter 1.4.4) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.6 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12308) Potential ArrayIndexOutOfBoundsException with global transformers
Carsten Ziegeler created SLING-12308: Summary: Potential ArrayIndexOutOfBoundsException with global transformers Key: SLING-12308 URL: https://issues.apache.org/jira/browse/SLING-12308 Project: Sling Issue Type: Bug Components: General Affects Versions: Rewriter 1.4.2 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.4.4 When several global transformers are configured but one of them does not match the current request, an ArrayIndexOutOfBoundsException might be thrown as the code assumes all transformers match. This only happens if there is a matching transformer *after* one that does not match. If it is the other way round, the code works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12303) Global transformers are not sorted by service ranking
[ https://issues.apache.org/jira/browse/SLING-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12303. > Global transformers are not sorted by service ranking > - > > Key: SLING-12303 > URL: https://issues.apache.org/jira/browse/SLING-12303 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.2 > > > The service ranking of a transformer (factory) is used to determine its > position in the rewriter pipeline. However, the transformers are not ordered > according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840686#comment-17840686
]
Carsten Ziegeler commented on SLING-12173:
--
[~rombert] To be honest I prefer our wrapper over the other solutions; its much
simpler to use - it also is faster due to the hard coded factory.
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
>
[jira] [Resolved] (SLING-12303) Global transformers are not sorted by service ranking
[ https://issues.apache.org/jira/browse/SLING-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12303. -- Resolution: Fixed Added sorting and improved logging in https://github.com/apache/sling-org-apache-sling-rewriter/commit/c98017bc16ee3355dcd00fe080b9c93e387f18dd > Global transformers are not sorted by service ranking > - > > Key: SLING-12303 > URL: https://issues.apache.org/jira/browse/SLING-12303 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Rewriter 1.4.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.2 > > > The service ranking of a transformer (factory) is used to determine its > position in the rewriter pipeline. However, the transformers are not ordered > according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.4 (was: Rewriter 1.4.2) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.4 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12303) Global transformers are not sorted by service ranking
Carsten Ziegeler created SLING-12303: Summary: Global transformers are not sorted by service ranking Key: SLING-12303 URL: https://issues.apache.org/jira/browse/SLING-12303 Project: Sling Issue Type: Bug Components: General Affects Versions: Rewriter 1.4.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.4.2 The service ranking of a transformer (factory) is used to determine its position in the rewriter pipeline. However, the transformers are not ordered according to their ranking which makes the order unpredictable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12299) Support global transformers in error pipelines
[ https://issues.apache.org/jira/browse/SLING-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12299. > Support global transformers in error pipelines > -- > > Key: SLING-12299 > URL: https://issues.apache.org/jira/browse/SLING-12299 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.4.0 > > > Global transformers can currently only be added to the normal content > pipeline but not to an error pipeline. > We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839473#comment-17839473
]
Carsten Ziegeler commented on SLING-12300:
--
[~paul.bjorkstrand] Thanks for the detailed response.
I think we have a slightly misleading discussion here, the current
implementation is a *resource provider* - granted, that provider is not
explicitly mounted at "/jcr:id", but there is no huge difference, except maybe
that it would be possible to reconfigure the path to something else or disable
the provider.
I understand the ask for making an identifier a first class citizen in the
Sling API, but I'm not sure that this would really change the picture that
much. I rather think, the underlying question is whether we want to make
resources addressable through their identifier via the http API or not. An
identifier based resource API would allow that, the path based approach taken
here does not allow it.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12300) Provide a way to retrieve a JCR backed resource by its node identifier
[
https://issues.apache.org/jira/browse/SLING-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839392#comment-17839392
]
Carsten Ziegeler commented on SLING-12300:
--
I think we have two questions here:
- do we want to have a mechanism that allows to get resources (JCR resources in
this case) by identifier?
- if the answer to the first question is yes, then how does it look like?
I'm not sure if we agree to answer the first question with a yes based on the
comments here, so lets get that one out of the way first.
> Provide a way to retrieve a JCR backed resource by its node identifier
> --
>
> Key: SLING-12300
> URL: https://issues.apache.org/jira/browse/SLING-12300
> Project: Sling
> Issue Type: New Feature
> Components: JCR
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JCR Resource 3.3.0
>
>
> Since all {{javax.jcr.Nodes}} have an identifier [0], a useful feature would
> be {{Resource}} retrieval by node id, which could be its {{jcr:uuid}}
> property for referenceable nodes or the path. In systems that would like to
> use UUID addressing, this would reduce the need for executing JCR queries for
> resource retrieval and would avoid double-reads via the JCR and then Sling
> API to obtain the resource.
> In order to provide a unified behaviour, paths starting with the {{/jcr:id/}}
> prefix should use the resource retrieval by node identifier.
> [0] -
> https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Node.html#getIdentifier()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.4.2 (was: Rewriter 1.4.0) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.4.2 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12299) Support global transformers in error pipelines
[ https://issues.apache.org/jira/browse/SLING-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12299. -- Resolution: Fixed Implemented in https://github.com/apache/sling-org-apache-sling-rewriter/commit/24ee302deaee25fe87b27db5549e627b56535b3d > Support global transformers in error pipelines > -- > > Key: SLING-12299 > URL: https://issues.apache.org/jira/browse/SLING-12299 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.12 > > > Global transformers can currently only be added to the normal content > pipeline but not to an error pipeline. > We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12299) Support global transformers in error pipelines
Carsten Ziegeler created SLING-12299: Summary: Support global transformers in error pipelines Key: SLING-12299 URL: https://issues.apache.org/jira/browse/SLING-12299 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.12 Global transformers can currently only be added to the normal content pipeline but not to an error pipeline. We should support this as well via a new opt-in property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12264) check save() operations
[ https://issues.apache.org/jira/browse/SLING-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825158#comment-17825158 ] Carsten Ziegeler commented on SLING-12264: -- This sounds like a fix at the wrong place; I would expect that session.save() is actually doing exactly the same internally - in which case this extra check introduces a penality as it is then called twice. > check save() operations > --- > > Key: SLING-12264 > URL: https://issues.apache.org/jira/browse/SLING-12264 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.46 >Reporter: Joerg Hoh >Priority: Major > > Before doing a session.save() operation, it should always be checked if there > is something to save at all. > This can speed up the execution of individual repoinit statements if the > repoinit statement does not need to be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818747#comment-17818747
]
Carsten Ziegeler commented on SLING-12253:
--
It seems AbstractResourceCollector#getChildrenList is modifying the list
*after* it got put into the cache which then allows another thread to pick up
the cached result before the list is completely assembled.
A workaround is to disable caching.
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Priority: Major
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12253) ConcurrentModificationException in AbstractResourceCollector
[
https://issues.apache.org/jira/browse/SLING-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12253:
-
Affects Version/s: Servlets Resolver 2.11.0
Servlets Resolver 2.10.0
> ConcurrentModificationException in AbstractResourceCollector
>
>
> Key: SLING-12253
> URL: https://issues.apache.org/jira/browse/SLING-12253
> Project: Sling
> Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.14, Servlets Resolver 2.10.0,
> Servlets Resolver 2.11.0
>Reporter: Joerg Hoh
>Priority: Major
>
> {noformat}
> [[::1] [1705550745690] GET /content/foobar.html HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> java.util.ConcurrentModificationException: null
> at
> java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
> at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
> at
> org.apache.sling.servlets.resolver.internal.helper.ResourceCollector.getWeightedResources(ResourceCollector.java:232)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.lambda$getServlets$1(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
> at
> org.apache.sling.servlets.resolver.internal.helper.AbstractResourceCollector.getServlets(AbstractResourceCollector.java:117)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.getServletInternal(SlingServletResolver.java:528)
> [org.apache.sling.servlets.resolver:2.9.14]
> at
> org.apache.sling.servlets.resolver.internal.SlingServletResolver.resolveServletInternal(SlingServletResolver.java:489)
> [org.apache.sling.servlets.resolver:2.9.14]
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816076#comment-17816076 ] Carsten Ziegeler commented on SLING-12249: -- sounds ok to me > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815613#comment-17815613
]
Carsten Ziegeler commented on SLING-12245:
--
Sure, I see the general problem - for the rewriter the approach sounds fine to
me
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
>Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815610#comment-17815610
]
Carsten Ziegeler commented on SLING-12245:
--
I think that's what the listener has to do. And in this case it's not super hard
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
>Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815605#comment-17815605
]
Carsten Ziegeler commented on SLING-12245:
--
[~kwin] I'm not sure I fully understand the problem. You mention "When renaming
a working rewriter pipeline config from /apps/system/config/rewriter2 to
/apps/system/config/rewriter the following ResourceChange is received:..."
which is ignored in ProcessorManagerImpl.onChange(...)
So isn't the fix to not ignore the event?
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
>Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814809#comment-17814809 ] Carsten Ziegeler commented on SLING-12247: -- Looks ok to me > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814722#comment-17814722
]
Carsten Ziegeler commented on SLING-12246:
--
Sure. In theory there should be no need to handle a move event. But if there
are cases where no added/removed combo is sent, then this should probably be
fixed (best in Oak).
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814717#comment-17814717
]
Carsten Ziegeler commented on SLING-12246:
--
I read there "NODE_MOVED event, NODE_ADDED event for the root of the sub-tree
only, NODE_REMOVED event for the root of the sub-tree only"
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814714#comment-17814714
]
Carsten Ziegeler commented on SLING-12246:
--
If I remember correctly, we skipped implementing explicit support for the
"moved" event as a add/remove events were sent in addition anyway.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12238) Prevent NullPointerException if global transformer returns null
[ https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12238. > Prevent NullPointerException if global transformer returns null > --- > > Key: SLING-12238 > URL: https://issues.apache.org/jira/browse/SLING-12238 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > A TransformerFactory for a global transformer might return null for the > Transformer, similar the factory might already be gone. Both result in a null > value inserted into the array of global transformers. > Later on, when that array is processed, there is no null check anymore. > Potentially resulting in a NullPointerException > This should be guarded with a null check, as this might happen in a dynamic > system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12239) Create string representation of processing component configuration only once
[ https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12239. > Create string representation of processing component configuration only once > > > Key: SLING-12239 > URL: https://issues.apache.org/jira/browse/SLING-12239 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > With SLING-12227 the "caching" of the processing component configuration got > accidentally removed. As this one is printed out with each and every html > request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12233) Ignore resource type with invalid paths
[ https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12233. > Ignore resource type with invalid paths > --- > > Key: SLING-12233 > URL: https://issues.apache.org/jira/browse/SLING-12233 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.10.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: servlets resolver 2.11.0 > > > Most invalid resource types are already ignored as it relies on > ResourceUtil.normalize. However, path segments with more than two consecutive > dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12239) Create string representation of processing component configuration only once
[ https://issues.apache.org/jira/browse/SLING-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12239. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-rewriter/commit/7bbf8a52db191f2d59bc6c00fc86bf0a8235bf20 > Create string representation of processing component configuration only once > > > Key: SLING-12239 > URL: https://issues.apache.org/jira/browse/SLING-12239 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > With SLING-12227 the "caching" of the processing component configuration got > accidentally removed. As this one is printed out with each and every html > request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12239) Create string representation of processing component configuration only once
Carsten Ziegeler created SLING-12239: Summary: Create string representation of processing component configuration only once Key: SLING-12239 URL: https://issues.apache.org/jira/browse/SLING-12239 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.10 With SLING-12227 the "caching" of the processing component configuration got accidentally removed. As this one is printed out with each and every html request, we should only create it once. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.3.12 (was: Rewriter 1.3.10) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.3.12 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12238) Prevent NullPointerException if global transformer returns null
[ https://issues.apache.org/jira/browse/SLING-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12238. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-rewriter/commit/bd45e2145a438899c487184ce388a579270495f0 > Prevent NullPointerException if global transformer returns null > --- > > Key: SLING-12238 > URL: https://issues.apache.org/jira/browse/SLING-12238 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.10 > > > A TransformerFactory for a global transformer might return null for the > Transformer, similar the factory might already be gone. Both result in a null > value inserted into the array of global transformers. > Later on, when that array is processed, there is no null check anymore. > Potentially resulting in a NullPointerException > This should be guarded with a null check, as this might happen in a dynamic > system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12238) Prevent NullPointerException if global transformer returns null
Carsten Ziegeler created SLING-12238: Summary: Prevent NullPointerException if global transformer returns null Key: SLING-12238 URL: https://issues.apache.org/jira/browse/SLING-12238 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.10 A TransformerFactory for a global transformer might return null for the Transformer, similar the factory might already be gone. Both result in a null value inserted into the array of global transformers. Later on, when that array is processed, there is no null check anymore. Potentially resulting in a NullPointerException This should be guarded with a null check, as this might happen in a dynamic system -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12232. > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809472#comment-17809472 ] Carsten Ziegeler commented on SLING-12232: -- Applied PR which removes dependency to httpclient completely > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12232. -- Resolution: Fixed > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12231. > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12097) Installer Core build fails with Java 17
[ https://issues.apache.org/jira/browse/SLING-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12097. > Installer Core build fails with Java 17 > --- > > Key: SLING-12097 > URL: https://issues.apache.org/jira/browse/SLING-12097 > Project: Sling > Issue Type: Bug > Components: Installer >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Installer Core 3.14.0 > > > [ERROR] Failed to execute goal > biz.aQute.bnd:bnd-maven-plugin:5.0.0:bnd-process (bnd-process) on project > org.apache.sling.installer.core: bnd error: null: > ConcurrentModificationException -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11393) Escape characters in log entries
[ https://issues.apache.org/jira/browse/SLING-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11393. > Escape characters in log entries > > > Key: SLING-11393 > URL: https://issues.apache.org/jira/browse/SLING-11393 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 5.4.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Commons Log 5.4.2 > > > We should escape some characters in log messages and exception messages for a > better output. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12232: - Description: Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should remove this dependency. It seems, httpclient is only used in order to implement a retry loop, this can be done without using that dependency. was:Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should switch to httpclient4. > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should remove this dependency. > It seems, httpclient is only used in order to implement a retry loop, this > can be done without using that dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12232) Remove usage of httpclient 5
[ https://issues.apache.org/jira/browse/SLING-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12232: - Summary: Remove usage of httpclient 5 (was: Switch to Apache HttpClient 4) > Remove usage of httpclient 5 > > > Key: SLING-12232 > URL: https://issues.apache.org/jira/browse/SLING-12232 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer >Affects Versions: Feature Model Unpack Extension 0.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Unpack Extension 0.4.0 > > > Version 0.3.0 introduced a dependency on httpclient5 which is not available > as an OSGi bundle. Therefore we should switch to httpclient4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12233) Ignore resource type with invalid paths
[ https://issues.apache.org/jira/browse/SLING-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12233. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b54d4e6693e0bcd63a97a0328f4f065b8a81b75e > Ignore resource type with invalid paths > --- > > Key: SLING-12233 > URL: https://issues.apache.org/jira/browse/SLING-12233 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.10.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: servlets resolver 2.11.0 > > > Most invalid resource types are already ignored as it relies on > ResourceUtil.normalize. However, path segments with more than two consecutive > dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12233) Ignore resource type with invalid paths
Carsten Ziegeler created SLING-12233: Summary: Ignore resource type with invalid paths Key: SLING-12233 URL: https://issues.apache.org/jira/browse/SLING-12233 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Resolver 2.10.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: servlets resolver 2.11.0 Most invalid resource types are already ignored as it relies on ResourceUtil.normalize. However, path segments with more than two consecutive dots are currently not ignored, leading to unexpected results. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12232) Switch to Apache HttpClient 4
Carsten Ziegeler created SLING-12232: Summary: Switch to Apache HttpClient 4 Key: SLING-12232 URL: https://issues.apache.org/jira/browse/SLING-12232 Project: Sling Issue Type: Improvement Components: Feature Model, Installer Affects Versions: Feature Model Unpack Extension 0.3.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Unpack Extension 0.3.2 Version 0.3.0 introduced a dependency on httpclient5 which is not available as an OSGi bundle. Therefore we should switch to httpclient4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Affects Version/s: (was: Installer Factory Feature Model 0.7.0) > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Factory Feature Model 0.8.0, Installer Core > 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12231. -- Resolution: Fixed > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Fix Version/s: (was: Installer Factory Feature Model 0.8.0) > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Fix Version/s: Installer Factory Feature Model 0.8.0 > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model > 0.7.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Factory Feature Model 0.8.0, Installer Core > 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Affects Version/s: Installer Factory Feature Model 0.7.0 > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0, Installer Factory Feature Model > 0.7.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.14.0 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808283#comment-17808283 ] Carsten Ziegeler commented on SLING-12231: -- Installer Core: https://github.com/apache/sling-org-apache-sling-installer-core/commit/ab56c53b4d0a5e9cb0fb5cfb6a1af465f5d80fef > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.12.2 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12231) Replace javax.json with jakarta.json
Carsten Ziegeler created SLING-12231: Summary: Replace javax.json with jakarta.json Key: SLING-12231 URL: https://issues.apache.org/jira/browse/SLING-12231 Project: Sling Issue Type: Improvement Components: Installer Affects Versions: Installer Core 3.12.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Installer Core 3.12.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12231) Replace javax.json with jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12231: - Description: We should replace the usage of javax.json with jakarta.json > Replace javax.json with jakarta.json > > > Key: SLING-12231 > URL: https://issues.apache.org/jira/browse/SLING-12231 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: Installer Core 3.12.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Installer Core 3.12.2 > > > We should replace the usage of javax.json with jakarta.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12228) Status printer does not display global transformers
[ https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12228. > Status printer does not display global transformers > --- > > Key: SLING-12228 > URL: https://issues.apache.org/jira/browse/SLING-12228 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12227) Status printer does not properly display array values
[
https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler closed SLING-12227.
> Status printer does not properly display array values
> -
>
> Key: SLING-12227
> URL: https://issues.apache.org/jira/browse/SLING-12227
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> The status printer for the pipeline components does not properly display
> array values, for example the current output looks like this:
> {noformat}
> Pipeline :
> Generator :
> htmlparser : {includeTags=[Ljava.lang.String;@19a2db46}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
[ https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12230. > Replace usage of Sling Commons OSGi with OSGi converter > --- > > Key: SLING-12230 > URL: https://issues.apache.org/jira/browse/SLING-12230 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > We should replace the usage of Sling Commons OSGi with the OSGi converter to > remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12211) Update Parent to 52 and make build compatible with Java 17 and above
[ https://issues.apache.org/jira/browse/SLING-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12211: - Fix Version/s: Rewriter 1.3.10 (was: Rewriter 1.3.8) > Update Parent to 52 and make build compatible with Java 17 and above > > > Key: SLING-12211 > URL: https://issues.apache.org/jira/browse/SLING-12211 > Project: Sling > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Rewriter 1.3.10 > > > Updating to Parent 52 allows reproducible builds > (https://issues.apache.org/jira/browse/SLING-11907). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
[ https://issues.apache.org/jira/browse/SLING-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12230. -- Resolution: Fixed Changed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/2960e0b480f53308a7184dc63dc45b958b46e6e6 > Replace usage of Sling Commons OSGi with OSGi converter > --- > > Key: SLING-12230 > URL: https://issues.apache.org/jira/browse/SLING-12230 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > We should replace the usage of Sling Commons OSGi with the OSGi converter to > remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12230) Replace usage of Sling Commons OSGi with OSGi converter
Carsten Ziegeler created SLING-12230: Summary: Replace usage of Sling Commons OSGi with OSGi converter Key: SLING-12230 URL: https://issues.apache.org/jira/browse/SLING-12230 Project: Sling Issue Type: Improvement Components: General Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Rewriter 1.3.8 We should replace the usage of Sling Commons OSGi with the OSGi converter to remove all usage of commons osgi. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12228) Status printer does not display global transformers
[ https://issues.apache.org/jira/browse/SLING-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12228. -- Assignee: Carsten Ziegeler Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-rewriter/commit/5ef0f8e0fe857fe03a5e1770838359fb654ecb1f > Status printer does not display global transformers > --- > > Key: SLING-12228 > URL: https://issues.apache.org/jira/browse/SLING-12228 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Rewriter 1.3.6 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Rewriter 1.3.8 > > > Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12227) Status printer does not properly display array values
[
https://issues.apache.org/jira/browse/SLING-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-12227.
--
Assignee: Carsten Ziegeler
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-rewriter/commit/a557549c07324aa0ec5797aba8181ade51731888
Also fixed the toString() method which suffered from the same problem
> Status printer does not properly display array values
> -
>
> Key: SLING-12227
> URL: https://issues.apache.org/jira/browse/SLING-12227
> Project: Sling
> Issue Type: Improvement
> Components: General
>Affects Versions: Rewriter 1.3.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Rewriter 1.3.8
>
>
> The status printer for the pipeline components does not properly display
> array values, for example the current output looks like this:
> {noformat}
> Pipeline :
> Generator :
> htmlparser : {includeTags=[Ljava.lang.String;@19a2db46}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12228) Status printer does not display global transformers
Carsten Ziegeler created SLING-12228: Summary: Status printer does not display global transformers Key: SLING-12228 URL: https://issues.apache.org/jira/browse/SLING-12228 Project: Sling Issue Type: Improvement Components: General Affects Versions: Rewriter 1.3.6 Reporter: Carsten Ziegeler Fix For: Rewriter 1.3.8 Global transformers are currently not displayed at all on the status report -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12227) Status printer does not properly display array values
Carsten Ziegeler created SLING-12227:
Summary: Status printer does not properly display array values
Key: SLING-12227
URL: https://issues.apache.org/jira/browse/SLING-12227
Project: Sling
Issue Type: Improvement
Components: General
Affects Versions: Rewriter 1.3.6
Reporter: Carsten Ziegeler
Fix For: Rewriter 1.3.8
The status printer for the pipeline components does not properly display array
values, for example the current output looks like this:
{noformat}
Pipeline :
Generator :
htmlparser : {includeTags=[Ljava.lang.String;@19a2db46}
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804679#comment-17804679 ] Carsten Ziegeler edited comment on SLING-12225 at 1/9/24 10:39 AM: --- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. was (Author: cziegeler): Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise documentation and naming of system properties for query paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804679#comment-17804679 ] Carsten Ziegeler commented on SLING-12225: -- Given that this is a helper for implementation, I think there are three options: * no configurability at all * make it configurable in a special branch via whatever mechanism is appropriate * make it configurable in the main branch, but ensure to remove it before a release I would prefer one of the first two. And I agree we should use the same approach for both. > resource resolver: revise documentation and naming of system properties for > query paging > > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12225) resource resolver: revise document and naming of system properties for paging
[ https://issues.apache.org/jira/browse/SLING-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804642#comment-17804642 ] Carsten Ziegeler commented on SLING-12225: -- Reading that thread, I'm wondering why this is configurable to begin with? It seems that there is no intention to make this configurable for users. The only reason seems to be for "debugging" - but then who is debugging this? Apparently not users. Making this configurable for the implementor to find the right value doesn't sound right to me, at least not in the main branch. > resource resolver: revise document and naming of system properties for paging > - > > Key: SLING-12225 > URL: https://issues.apache.org/jira/browse/SLING-12225 > Project: Sling > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > > See > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#pullrequestreview-1792876455 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12220) Ensure that metadata properties are always written in the same order
[ https://issues.apache.org/jira/browse/SLING-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12220. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-feature/commit/b1cb1f476a8274d120c09cc6a6a7b25225c0220d > Ensure that metadata properties are always written in the same order > > > Key: SLING-12220 > URL: https://issues.apache.org/jira/browse/SLING-12220 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 2.0.2 > > > Currently a hashmap is used for artifact metadata which results in an > arbitrary order of metadata properties. It could happen that reading and > writing the same feature model results in a different order of metadata > properties. > To reduce differences, we should use an ordered map instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12220) Ensure that metadata properties are always written in the same order
Carsten Ziegeler created SLING-12220: Summary: Ensure that metadata properties are always written in the same order Key: SLING-12220 URL: https://issues.apache.org/jira/browse/SLING-12220 Project: Sling Issue Type: Improvement Components: Feature Model Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model 2.0.2 Currently a hashmap is used for artifact metadata which results in an arbitrary order of metadata properties. It could happen that reading and writing the same feature model results in a different order of metadata properties. To reduce differences, we should use an ordered map instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12219) ResourceUtil.normalize does not handle segments with multiple dots correctly
[ https://issues.apache.org/jira/browse/SLING-12219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12219. -- Resolution: Fixed Rewrote the method in https://github.com/apache/sling-org-apache-sling-api/commit/13ef4835f031a4fe5115433a42fa967f8fe560b3 for better readability. Adjusted test cases with more than two dots and added additional ones (which fail with the old implementation) > ResourceUtil.normalize does not handle segments with multiple dots correctly > > > Key: SLING-12219 > URL: https://issues.apache.org/jira/browse/SLING-12219 > Project: Sling > Issue Type: Bug > Components: API >Affects Versions: API 2.27.2 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: API 2.27.4 > > > If a path segment contains more than two dots but anything else, then > ResourceUtil.normalize does not handle these correctly. It should just return > null. Instead in some cases it is leaving the segment untouched or shortens > it for example from four dots to two dots. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12219) ResourceUtil.normalize does not handle segments with multiple dots correctly
Carsten Ziegeler created SLING-12219: Summary: ResourceUtil.normalize does not handle segments with multiple dots correctly Key: SLING-12219 URL: https://issues.apache.org/jira/browse/SLING-12219 Project: Sling Issue Type: Bug Components: API Affects Versions: API 2.27.2 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: API 2.27.4 If a path segment contains more than two dots but anything else, then ResourceUtil.normalize does not handle these correctly. It should just return null. Instead in some cases it is leaving the segment untouched or shortens it for example from four dots to two dots. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12215) javadoc of ResourceUtil.normalize does not match implementation
[ https://issues.apache.org/jira/browse/SLING-12215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12215. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-api/commit/ec0f8cf8baa2c5a12b3987d5f39e33e8278b5fa3 > javadoc of ResourceUtil.normalize does not match implementation > --- > > Key: SLING-12215 > URL: https://issues.apache.org/jira/browse/SLING-12215 > Project: Sling > Issue Type: Improvement > Components: API >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: API 2.27.4 > > > The javadoc mentions that it returns null on relative paths, but the method > actually handles them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12215) javadoc of ResourceUtil.normalize does not match implementation
Carsten Ziegeler created SLING-12215: Summary: javadoc of ResourceUtil.normalize does not match implementation Key: SLING-12215 URL: https://issues.apache.org/jira/browse/SLING-12215 Project: Sling Issue Type: Improvement Components: API Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: API 2.27.4 The javadoc mentions that it returns null on relative paths, but the method actually handles them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11836) Add Jakarta JSON support to the Sling Starter
[ https://issues.apache.org/jira/browse/SLING-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800959#comment-17800959 ] Carsten Ziegeler commented on SLING-11836: -- Switched to our wrapper bundle https://github.com/apache/sling-org-apache-sling-starter/commit/31e6d31de2ddbb740b553c9c6775e021b5b1d57b > Add Jakarta JSON support to the Sling Starter > - > > Key: SLING-11836 > URL: https://issues.apache.org/jira/browse/SLING-11836 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Labels: Sling-13-Release-Notes > Fix For: Starter 13 > > > With SLING-11718 we started requiring the Jakarta JSON API for the content > loader bundle, and more will probably follow. > We have to provide the needed APIs from the starter, otherwise the bundles > will not resolve. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12210) Remove unused startLevel from BundleDescriptorImpl
[ https://issues.apache.org/jira/browse/SLING-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12210. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/04cc3ce2407ed73b8be9d3f5cc0af1ffcf80d4c0 > Remove unused startLevel from BundleDescriptorImpl > -- > > Key: SLING-12210 > URL: https://issues.apache.org/jira/browse/SLING-12210 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12210) Remove unused startLevel from BundleDescriptorImpl
Carsten Ziegeler created SLING-12210: Summary: Remove unused startLevel from BundleDescriptorImpl Key: SLING-12210 URL: https://issues.apache.org/jira/browse/SLING-12210 Project: Sling Issue Type: Improvement Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 2.0.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12209) Improve logging output
Carsten Ziegeler created SLING-12209: Summary: Improve logging output Key: SLING-12209 URL: https://issues.apache.org/jira/browse/SLING-12209 Project: Sling Issue Type: New Feature Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 2.0.4 The logging output of the analyser could be improved, e.g. by adding the full time it took to analyse as well as providing an option to surpress task info output. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12206) Support WAR deployment within servlet 5 container
Carsten Ziegeler created SLING-12206: Summary: Support WAR deployment within servlet 5 container Key: SLING-12206 URL: https://issues.apache.org/jira/browse/SLING-12206 Project: Sling Issue Type: New Feature Components: Launchpad Reporter: Carsten Ziegeler The WAR file created by the launchpad only supports Servlet 3 (javax.servlet). We should update the support to be able to run within Servlet 5 (jakarta.servlet) application servers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12201) Regression introduced by SLING-12124
[ https://issues.apache.org/jira/browse/SLING-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12201. > Regression introduced by SLING-12124 > > > Key: SLING-12201 > URL: https://issues.apache.org/jira/browse/SLING-12201 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.10 > > > With SLING-12124 urls containing consecutive dots are regarded invalid, > however there is a lot of code out there asuming that these are valid ones. > Its also easy to mistype a url with two dots. > To avoid disruption, we should revert. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12027. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12199) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-12199: Assignee: Carsten Ziegeler > Migrate to jakarta.json > --- > > Key: SLING-12199 > URL: https://issues.apache.org/jira/browse/SLING-12199 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > We should migrate from using javax.json to jakarta.json; this includes moving > to Apache Johnzon 2.0.0 for the mapping -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12199) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12199. > Migrate to jakarta.json > --- > > Key: SLING-12199 > URL: https://issues.apache.org/jira/browse/SLING-12199 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Carsten Ziegeler >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > We should migrate from using javax.json to jakarta.json; this includes moving > to Apache Johnzon 2.0.0 for the mapping -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations
[ https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797148#comment-17797148 ] Carsten Ziegeler commented on SLING-12181: -- Very often you have a combination of provider type and consumer type implementations in your bundle - in which case you can't use the plugin without any further information. I'm not against implementing this, but I wonder how useful it is in the end. > Evaluate provider type information also directly from annotations > - > > Key: SLING-12181 > URL: https://issues.apache.org/jira/browse/SLING-12181 > Project: Sling > Issue Type: Improvement >Affects Versions: Provider Type Checker Bnd Plugin 1.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Provider Type Checker Bnd Plugin 1.1.0 > > > Currently the check implemented in SLING-12026 only retrieves the provider > type information from the META-INF/api-info.json (being generated by > SLING-12135). > As fallback there should be direct evaluation of the annotations. > The logic needs to be the same as in > https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991, > i.e. the annotation provider type needs to be evaluated both on package as > well as on type level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12201) Regression introduced by SLING-12124
[ https://issues.apache.org/jira/browse/SLING-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12201. -- Resolution: Fixed Reverted in https://github.com/apache/sling-org-apache-sling-engine/commit/7d84c3d3cde95421fe597f5977bf735e50ed55d3 > Regression introduced by SLING-12124 > > > Key: SLING-12201 > URL: https://issues.apache.org/jira/browse/SLING-12201 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.15.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.15.10 > > > With SLING-12124 urls containing consecutive dots are regarded invalid, > however there is a lot of code out there asuming that these are valid ones. > Its also easy to mistype a url with two dots. > To avoid disruption, we should revert. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12201) Regression introduced by SLING-12124
Carsten Ziegeler created SLING-12201: Summary: Regression introduced by SLING-12124 Key: SLING-12201 URL: https://issues.apache.org/jira/browse/SLING-12201 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.15.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.15.10 With SLING-12124 urls containing consecutive dots are regarded invalid, however there is a lot of code out there asuming that these are valid ones. Its also easy to mistype a url with two dots. To avoid disruption, we should revert. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations
[ https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797129#comment-17797129 ] Carsten Ziegeler commented on SLING-12181: -- How do you distinguish between allowed implementations of a ProviderType and forbidden ones? > Evaluate provider type information also directly from annotations > - > > Key: SLING-12181 > URL: https://issues.apache.org/jira/browse/SLING-12181 > Project: Sling > Issue Type: Improvement >Affects Versions: Provider Type Checker Bnd Plugin 1.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Provider Type Checker Bnd Plugin 1.1.0 > > > Currently the check implemented in SLING-12026 only retrieves the provider > type information from the META-INF/api-info.json (being generated by > SLING-12135). > As fallback there should be direct evaluation of the annotations. > The logic needs to be the same as in > https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991, > i.e. the annotation provider type needs to be evaluated both on package as > well as on type level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12199) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-12199: - Description: We should migrate from using javax.json to jakarta.json; this includes moving to Apache Johnzon 2.0.0 for the mapping > Migrate to jakarta.json > --- > > Key: SLING-12199 > URL: https://issues.apache.org/jira/browse/SLING-12199 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Carsten Ziegeler >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > We should migrate from using javax.json to jakarta.json; this includes moving > to Apache Johnzon 2.0.0 for the mapping -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.28 (was: GraphQL Core 0.0.26) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.28 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12199) Migrate to jakarta.json
[ https://issues.apache.org/jira/browse/SLING-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12199. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-graphql-core/commit/f219b0315a0476a35e4c19781ac8bce29df1a21b > Migrate to jakarta.json > --- > > Key: SLING-12199 > URL: https://issues.apache.org/jira/browse/SLING-12199 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Carsten Ziegeler >Priority: Major > Fix For: GraphQL Core 0.0.26 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12199) Migrate to jakarta.json
Carsten Ziegeler created SLING-12199: Summary: Migrate to jakarta.json Key: SLING-12199 URL: https://issues.apache.org/jira/browse/SLING-12199 Project: Sling Issue Type: Improvement Components: GraphQL Reporter: Carsten Ziegeler Fix For: GraphQL Core 0.0.26 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795599#comment-17795599
]
Carsten Ziegeler commented on SLING-12173:
--
[~rombert] But that was an older slingfeature maven plugin version? We should
not have any dependency on javax.json anymore
> Configuration errors in Eclipse for projects using the
> slingfeature-maven-plugin
>
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation
> of the Apache Johnzon parser.
> I have noticed problems in the Eclipse IDE, where projects fail to update
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider:
> org.apache.johnzon.core.JsonProviderImpl not a subtype
> at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
> at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
> at jakarta.json.Json.createReader(Json.java:189)
> at
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
> at
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
> at
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
> at
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
> at
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
> at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
> at
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
> at
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.execute(MavenBuilder.java:83)
> at
>
[jira] [Closed] (SLING-12183) Avoid exception on startup if Apache Tika is not available
[ https://issues.apache.org/jira/browse/SLING-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12183. > Avoid exception on startup if Apache Tika is not available > -- > > Key: SLING-12183 > URL: https://issues.apache.org/jira/browse/SLING-12183 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Commons MIME 2.3.0 > > > If Apache Tika is not available, a long exception stacktrace is logged as the > DS component can't be instantiated. This is due to the fact that the > component is lazy (which is good) and therefore DS registers a ServiceFactory > for it. The ServiceFactory eventually returns null which then must be logged > by the framework. Therefore there is nothing we can do in DS to prevent this > logging. > As this is a simple component with zero references, zero configuration, it is > much better to register it via a BundleActivator if Tika is available -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12182) Provide wrapper for Apache Johnzon 2.0
[ https://issues.apache.org/jira/browse/SLING-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-12182. > Provide wrapper for Apache Johnzon 2.0 > -- > > Key: SLING-12182 > URL: https://issues.apache.org/jira/browse/SLING-12182 > Project: Sling > Issue Type: New Feature > Components: Commons >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Commons Johnzon 2.0.0 > > > Similar to our 1.x wrapper for javax.json we should create a wrapper for > jakarta.json based on Apache Johnzon 2.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12194) Cycle between scripting services
[ https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795069#comment-17795069 ] Carsten Ziegeler commented on SLING-12194: -- Improve thread and cache handling and add basic test for script cache https://github.com/apache/sling-org-apache-sling-scripting-core/commit/6c1ca32ea83939a45ebb5f1ac2ac20062cd9ad90 > Cycle between scripting services > > > Key: SLING-12194 > URL: https://issues.apache.org/jira/browse/SLING-12194 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > There can be an activation cycle between the SlingScriptEngineManager , the > ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires > the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager > which then completes the cycle -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12194) Cycle between scripting services
[ https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795068#comment-17795068 ] Carsten Ziegeler commented on SLING-12194: -- Fix dependency handling by moving dependency on service user mapping to the component which is using the service user https://github.com/apache/sling-org-apache-sling-scripting-core/commit/0170d8713d26995d18cfb0b6d5bd01d4288ce7c1 > Cycle between scripting services > > > Key: SLING-12194 > URL: https://issues.apache.org/jira/browse/SLING-12194 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > There can be an activation cycle between the SlingScriptEngineManager , the > ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires > the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager > which then completes the cycle -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12194) Cycle between scripting services
[ https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794770#comment-17794770 ] Carsten Ziegeler commented on SLING-12194: -- Fix configuration handling https://github.com/apache/sling-org-apache-sling-scripting-core/commit/6be8493b45aad7c771ce3f00e5606239e76af948 > Cycle between scripting services > > > Key: SLING-12194 > URL: https://issues.apache.org/jira/browse/SLING-12194 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > There can be an activation cycle between the SlingScriptEngineManager , the > ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires > the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager > which then completes the cycle -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12194) Cycle between scripting services
[ https://issues.apache.org/jira/browse/SLING-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12194. -- Assignee: Carsten Ziegeler Resolution: Fixed I broke the cycle by moving the event based invalidation to a separate component and bending slightly the contract of the removeScript method of the cache (now able to take a prefix path) https://github.com/apache/sling-org-apache-sling-scripting-core/commit/3249d3989bd0ca7f7dc5552d4ce6f4853c577425 > Cycle between scripting services > > > Key: SLING-12194 > URL: https://issues.apache.org/jira/browse/SLING-12194 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > There can be an activation cycle between the SlingScriptEngineManager , the > ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires > the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager > which then completes the cycle -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12194) Cycle between scripting services
Carsten Ziegeler created SLING-12194: Summary: Cycle between scripting services Key: SLING-12194 URL: https://issues.apache.org/jira/browse/SLING-12194 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Core 2.4.8 Reporter: Carsten Ziegeler Fix For: Scripting Core 2.4.10 There can be an activation cycle between the SlingScriptEngineManager , the ScriptEngines and the ScriptCache if a ScriptEngine (e.g. Sightly) requires the ScriptCache. The ScriptCache also requires the SlingScriptEngineManager which then completes the cycle -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12193) Potential concurrency issue in ScriptCacheImpl
[ https://issues.apache.org/jira/browse/SLING-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12193. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-scripting-core/commit/d38ba1d5ae99d5182a88bb89d5afec4b91944bb2 In addition, the ResourceChangeListener service registration is only updated, if something changes > Potential concurrency issue in ScriptCacheImpl > -- > > Key: SLING-12193 > URL: https://issues.apache.org/jira/browse/SLING-12193 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > The field extensions is read in a write lock but might be modified in > handleEvent() without any synchronization -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12193) Potential concurrency issue in ScriptCacheImpl
[ https://issues.apache.org/jira/browse/SLING-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-12193: Assignee: Carsten Ziegeler > Potential concurrency issue in ScriptCacheImpl > -- > > Key: SLING-12193 > URL: https://issues.apache.org/jira/browse/SLING-12193 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Scripting Core 2.4.10 > > > The field extensions is read in a write lock but might be modified in > handleEvent() without any synchronization -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12193) Potential concurrency issue in ScriptCacheImpl
Carsten Ziegeler created SLING-12193: Summary: Potential concurrency issue in ScriptCacheImpl Key: SLING-12193 URL: https://issues.apache.org/jira/browse/SLING-12193 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Core 2.4.8 Reporter: Carsten Ziegeler Fix For: Scripting Core 2.4.10 The field extensions is read in a write lock but might be modified in handleEvent() without any synchronization -- This message was sent by Atlassian Jira (v8.20.10#820010)
