Re: [PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]
rombert merged PR #46: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.repoinit to v1.1.48 [sling-org-apache-sling-starter]
rombert merged PR #335: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.engine to v2.15.16 [sling-org-apache-sling-starter]
rombert merged PR #334: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency com.composum.nodes:composum-nodes-commons to v4.3.3 [sling-org-apache-sling-starter]
rombert merged PR #333: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.repoinit to v1.1.48 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #335: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/335 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.jcr.repoinit](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-jcr-repoinit)) | `1.1.46` -> `1.1.48` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency com.composum.nodes:composum-nodes-commons to v4.3.3 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #333: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/333 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.composum.nodes:composum-nodes-commons](https://togithub.com/ist-dresden/composum) | `4.3.2` -> `4.3.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes ist-dresden/composum (com.composum.nodes:composum-nodes-commons) ### [`v4.3.3`](https://togithub.com/ist-dresden/composum/compare/composum-nodes-4.3.2...composum-nodes-4.3.3) [Compare Source](https://togithub.com/ist-dresden/composum/compare/composum-nodes-4.3.2...composum-nodes-4.3.3) --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.engine to v2.15.16 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #334: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/334 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.engine](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-engine)) | `2.15.14` -> `2.15.16` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46#issuecomment-2154809596 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=46) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=46=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=46=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=46=false=true)  [90.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=46=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=46=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=46) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]
rombert opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12325 - Improve parsing of tricky expressions [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/12#issuecomment-2152892209 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12=false=true)  [94.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=12) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12350 - Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin merged PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12350 - Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2152095604 @kwin : Whoops, it didn't have a related JIRA ticket, but I have created one now. I've also rebased the code as requested. Is it good to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12350 - Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2152087287 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate failed** Failed conditions  [56.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_coverage=list) (required ≥ 80%)  [9.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2151904113 @csaboka Can you rebase to only have 3 commits (parent update, reformat, .git-blame-ignore-revs) and make sure that all commit messages have the prefix of the related JIRA ticket? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2151601607 @kwin , can you merge this? Is there anything still missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela merged PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2150393767 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [96.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on code in PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1628016847 ## pom.xml: ## @@ -173,6 +179,12 @@ 1.9.0 provided + +org.apache.sling +org.apache.sling.serviceusermapper +1.5.8 +provided + Review Comment: removed. thanks for spotting. that's awesome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on code in PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1628013962 ## pom.xml: ## @@ -173,6 +179,12 @@ 1.9.0 provided + +org.apache.sling +org.apache.sling.serviceusermapper +1.5.8 +provided + Review Comment: no i don't think so. will check and remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12347 apply spotless formatting [sling-org-apache-sling-jcr-repoinit]
joerghoh merged PR #55: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
cziegeler commented on code in PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627625668 ## pom.xml: ## @@ -173,6 +179,12 @@ 1.9.0 provided + +org.apache.sling +org.apache.sling.serviceusermapper +1.5.8 +provided + Review Comment: do you still need that dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
joerghoh merged PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
joerghoh merged PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149398028 @cziegeler , i did a few test with snapshot bundle in AEM verifying that an invalid mapping is always spotted and deprecated mapping is spotted if warn-only flag is false. i simplified the mapping parsing as the import of the utility method from o.a.s.serviceusermapper bundle cause an exception and is not needed today. let me know if there is anything else you can see with the patch. feedback is very much appreciated as i am not super familiar with the analyse code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149323620 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [96.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149095776 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [96.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149093778 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [96.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149092105 @cziegeler , thanks for the review. i refactored the code accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627157822
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task.impl;
+
+import org.apache.sling.feature.Configuration;
+import org.apache.sling.feature.Configurations;
+import org.apache.sling.feature.analyser.task.AnalyserTask;
+import org.apache.sling.feature.analyser.task.AnalyserTaskContext;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+import org.osgi.util.converter.Converters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Set;
+
+public class CheckServiceUserMapping implements AnalyserTask {
+
+static final String SERVICE_USER_MAPPING_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl";
+
+static final String FACTORY_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended";
+
+static final String USER_MAPPING = "user.mapping";
+
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS =
"warnOnlyForDeprecatedMappings";
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT =
Boolean.FALSE.toString();
+
+private static final Logger log =
LoggerFactory.getLogger(CheckServiceUserMapping.class);
+
+@Override
+public String getName() {
+return "Service User Mapping Check";
+}
+
+@Override
+public String getId() {
Review Comment:
ok thanks. i replace it with "serviceusermapping" as the task itself and the
name uses mapping in singular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627144277
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task.impl;
+
+import org.apache.sling.feature.Configuration;
+import org.apache.sling.feature.Configurations;
+import org.apache.sling.feature.analyser.task.AnalyserTask;
+import org.apache.sling.feature.analyser.task.AnalyserTaskContext;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+import org.osgi.util.converter.Converters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Set;
+
+public class CheckServiceUserMapping implements AnalyserTask {
+
+static final String SERVICE_USER_MAPPING_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl";
+
+static final String FACTORY_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended";
+
+static final String USER_MAPPING = "user.mapping";
+
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS =
"warnOnlyForDeprecatedMappings";
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT =
Boolean.FALSE.toString();
+
+private static final Logger log =
LoggerFactory.getLogger(CheckServiceUserMapping.class);
+
+@Override
+public String getName() {
+return "Service User Mapping Check";
+}
+
+@Override
+public String getId() {
+return SERVICE_USER_MAPPING_PID;
+}
+
+@Override
+public void execute(final AnalyserTaskContext ctx) {
+final boolean warnOnlyForDeprecation =
Boolean.parseBoolean(ctx.getConfiguration().getOrDefault(CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS,
CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT));
+
+// configuration
+Configurations configurations = ctx.getFeature().getConfigurations();
+final Configuration cfg =
configurations.getConfiguration(SERVICE_USER_MAPPING_PID);
+if (cfg != null) {
+check(ctx, cfg, warnOnlyForDeprecation);
+}
+for (final Configuration c :
configurations.getFactoryConfigurations(FACTORY_PID)) {
+check(ctx, c, warnOnlyForDeprecation);
+}
+}
+
+private static void check(final AnalyserTaskContext ctx, final
Configuration cfg, final boolean warnOnlyForDeprecation) {
+final Object val = cfg.getConfigurationProperties().get(USER_MAPPING);
+if (val != null) {
+final String[] mappings =
Converters.standardConverter().convert(val).to(String[].class);
+for (final String spec : mappings) {
+check(ctx, cfg, spec, warnOnlyForDeprecation);
+}
+}
+}
+
+private static void check(final @NotNull AnalyserTaskContext ctx, final
@NotNull Configuration cfg, final @Nullable String spec, final boolean
warnOnlyForDeprecation) {
+final String id = cfg.getPid();
+if (spec == null || spec.trim().isEmpty()) {
+log.warn("Ignoring empty mapping in {}", id);
Review Comment:
good point! thanks. i replaced all usages of the logger with configuration
warning. so for the invalid mappings there will be a warning elaborating why
the mapping is invalid followed by an error that the mapping statement in
configuration x for pid y is invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
cziegeler commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149040568 PR looks good to me, I added two minor comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
cziegeler commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627109054
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task.impl;
+
+import org.apache.sling.feature.Configuration;
+import org.apache.sling.feature.Configurations;
+import org.apache.sling.feature.analyser.task.AnalyserTask;
+import org.apache.sling.feature.analyser.task.AnalyserTaskContext;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+import org.osgi.util.converter.Converters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Set;
+
+public class CheckServiceUserMapping implements AnalyserTask {
+
+static final String SERVICE_USER_MAPPING_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl";
+
+static final String FACTORY_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended";
+
+static final String USER_MAPPING = "user.mapping";
+
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS =
"warnOnlyForDeprecatedMappings";
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT =
Boolean.FALSE.toString();
+
+private static final Logger log =
LoggerFactory.getLogger(CheckServiceUserMapping.class);
+
+@Override
+public String getName() {
+return "Service User Mapping Check";
+}
+
+@Override
+public String getId() {
+return SERVICE_USER_MAPPING_PID;
+}
+
+@Override
+public void execute(final AnalyserTaskContext ctx) {
+final boolean warnOnlyForDeprecation =
Boolean.parseBoolean(ctx.getConfiguration().getOrDefault(CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS,
CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT));
+
+// configuration
+Configurations configurations = ctx.getFeature().getConfigurations();
+final Configuration cfg =
configurations.getConfiguration(SERVICE_USER_MAPPING_PID);
+if (cfg != null) {
+check(ctx, cfg, warnOnlyForDeprecation);
+}
+for (final Configuration c :
configurations.getFactoryConfigurations(FACTORY_PID)) {
+check(ctx, c, warnOnlyForDeprecation);
+}
+}
+
+private static void check(final AnalyserTaskContext ctx, final
Configuration cfg, final boolean warnOnlyForDeprecation) {
+final Object val = cfg.getConfigurationProperties().get(USER_MAPPING);
+if (val != null) {
+final String[] mappings =
Converters.standardConverter().convert(val).to(String[].class);
+for (final String spec : mappings) {
+check(ctx, cfg, spec, warnOnlyForDeprecation);
+}
+}
+}
+
+private static void check(final @NotNull AnalyserTaskContext ctx, final
@NotNull Configuration cfg, final @Nullable String spec, final boolean
warnOnlyForDeprecation) {
+final String id = cfg.getPid();
+if (spec == null || spec.trim().isEmpty()) {
+log.warn("Ignoring empty mapping in {}", id);
Review Comment:
while its not wrong to use a normal logger, I suggest to log this as a
warning via the context. This gives the full information in one place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#issuecomment-2149034404 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=45=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=45=false=true)  [97.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=45=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
cziegeler commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45#discussion_r1627106283
##
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckServiceUserMapping.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task.impl;
+
+import org.apache.sling.feature.Configuration;
+import org.apache.sling.feature.Configurations;
+import org.apache.sling.feature.analyser.task.AnalyserTask;
+import org.apache.sling.feature.analyser.task.AnalyserTaskContext;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+import org.osgi.util.converter.Converters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Set;
+
+public class CheckServiceUserMapping implements AnalyserTask {
+
+static final String SERVICE_USER_MAPPING_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl";
+
+static final String FACTORY_PID =
"org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended";
+
+static final String USER_MAPPING = "user.mapping";
+
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS =
"warnOnlyForDeprecatedMappings";
+static final String CFG_WARN_ONLY_FOR_DEPRECATED_MAPPINGS_DEFAULT =
Boolean.FALSE.toString();
+
+private static final Logger log =
LoggerFactory.getLogger(CheckServiceUserMapping.class);
+
+@Override
+public String getName() {
+return "Service User Mapping Check";
+}
+
+@Override
+public String getId() {
Review Comment:
The id is usually a short name that is used to reference the analyser, e.g.
in a maven pom, e.g. "serviceusermappings"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] SLING-12346 : Create service-user-mapping analyser [sling-org-apache-sling-feature-analyser]
anchela opened a new pull request, #45: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/45 hi @cziegeler , @karlpauls , i gave it a try to implement a feature analyser for service user mapping configurations. that allows to spot invalid and deprecated mappings. for the latter the idea would be to have a configuration option to either report an error or only a warning. since i have very limited experience with the feature analysers, i would appreciate if you could take a close look and let me know if anything is missing/wrong. in particular, i didn't find where the configuration option for the deprecated mappings would be set in the context of AEM. in the feature analyser I concluded that it's through config properties on AnalyserTaskContextImpl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2148503993 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2148503219 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.freemarker:freemarker to v2.3.33 [sling-org-apache-sling-starter]
rombert commented on PR #332: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/332#issuecomment-2146710774 ``` [ERROR] [requirements-capabilities] org.freemarker:freemarker:2.3.33: Artifact org.freemarker:freemarker:2.3.33 requires [org.freemarker.freemarker/2.3.33.stable] osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=16))" in start level 20 but no artifact is providing a matching capability in this start level. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.freemarker:freemarker to v2.3.33 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #332: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/332 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.freemarker:freemarker](https://freemarker.apache.org/) ([source](https://git-wip-us.apache.org/repos/asf?p=freemarker.git)) | `2.3.32` -> `2.3.33` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update dependency org.apache.maven.plugins:maven-enforcer-plugin to v3.5.0 [sling-site]
rombert merged PR #166: URL: https://github.com/apache/sling-site/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
joerghoh commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2139338289 @kwin I checked the 2nd startup of an AEM SDK instance (with and without that patch) and found an improvement of around 10% of the total runtime of all 468 repoinit statements (in absolute numbers: 0.5 seconds). That's not huge, but I would nevertheless include the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update dependency org.apache.maven.plugins:maven-enforcer-plugin to v3.5.0 [sling-site]
renovate-bot opened a new pull request, #166: URL: https://github.com/apache/sling-site/pull/166 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-enforcer-plugin](https://maven.apache.org/enforcer/) | `3.4.1` -> `3.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-site). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12062 add LazyBindings.putOnly [sling-org-apache-sling-api]
joerghoh merged PR #52: URL: https://github.com/apache/sling-org-apache-sling-api/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.14 [sling-org-apache-sling-starter]
rombert merged PR #330: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.resource to v3.3.2 [sling-org-apache-sling-starter]
rombert merged PR #331: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty to v5.1.14 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #330: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/330 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.http.jetty](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `5.1.12` -> `5.1.14` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.resource to v3.3.2 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #331: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/331 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.jcr.resource](https://sling.apache.org) ([source](https://togithub.com/apache/sling-org-apache-sling-jcr-resource)) | `3.3.0` -> `3.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2136195077 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2136192090 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12330 fix formatting [sling-org-apache-sling-engine]
joerghoh merged PR #48: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12330 fix formatting [sling-org-apache-sling-engine]
sonarcloud[bot] commented on PR #48: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/48#issuecomment-2135211774 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=48) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=48=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=48=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=48=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=48) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12330 fix formatting [sling-org-apache-sling-engine]
joerghoh opened a new pull request, #48: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/48 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
jsedding merged PR #54: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616876096
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class JcrRepoInitOpsProcessorImpl implements JcrRepoInitOpsProcessor {
+private static final Logger log =
LoggerFactory.getLogger(JcrRepoInitOpsProcessorImpl.class);
+
/**
* Apply the supplied operations: first the namespaces and nodetypes
* registrations, then the service users, paths and ACLs.
*/
@Override
public void apply(Session session, List ops) {
-Stream.of(
-// register namespaces first
-singleton(new NamespacesVisitor(session)),
-// then create node types and privileges, both use namespaces
-asList(
+AtomicReference lastAttemptedOperation = new
AtomicReference<>();
+try {
+Stream.of(
+// register namespaces first
+singleton(new NamespacesVisitor(session)),
+// then create node types and privileges, both use
namespaces
+asList(
+new NodetypesVisitor(session),
+new PrivilegeVisitor(session)),
+// finally apply everything else
+asList(
+new UserVisitor(session),
+new NodeVisitor(session),
+new AclVisitor(session),
+new GroupMembershipVisitor(session),
+new NodePropertiesVisitor(session))
+).forEach(visitorGroup -> {
+ops.forEach(op -> {
+lastAttemptedOperation.set(op);
+visitorGroup.forEach(op::accept);
+});
+});
+} catch (RepoInitException originalFailure) {
+// support legacy statement reordering for backwards compatibility
+try {
+session.refresh(false); // drop transient changes
+
+final OperationVisitor[] visitors = {
+new NamespacesVisitor(session),
new NodetypesVisitor(session),
-new PrivilegeVisitor(session)),
-// finally apply everything else
-asList(
+new PrivilegeVisitor(session),
new UserVisitor(session),
new NodeVisitor(session),
new AclVisitor(session),
new GroupMembershipVisitor(session),
-new NodePropertiesVisitor(session))
-).forEach(visitorGroup -> {
-ops.forEach(op -> visitorGroup.forEach(op::accept));
-});
+new NodePropertiesVisitor(session)
+};
+
+for (OperationVisitor v : visitors) {
+for (Operation op : ops) {
+op.accept(v);
+}
+}
+
+log.warn("DEPRECATION - The repoinit script being executed
relies on a bug causing repoinit " +
Review Comment:
Not sure if SLING-12107 helps. That is the ticket where the "new" ordering
was introduced.
We also don't have enough context to explain what the issue is. However, it
may be worthwhile including the `originalFailure` exception, or at least its
message, in the log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616872112
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -567,7 +567,7 @@ private static String toString(JackrabbitAccessControlEntry
entry) throws Reposi
private static void checkState(boolean expression, String msgPattern,
Object... args) {
if (!expression) {
-if (args != null) {
+if (args == null) {
Review Comment:
Because it was wrong. I noticed the messages with the unsubstituted message
patterns while investigating issues caused by the re-ordering. I didn't think
this small fix was worth its own JIRA ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616872388
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class JcrRepoInitOpsProcessorImpl implements JcrRepoInitOpsProcessor {
+private static final Logger log =
LoggerFactory.getLogger(JcrRepoInitOpsProcessorImpl.class);
+
/**
* Apply the supplied operations: first the namespaces and nodetypes
* registrations, then the service users, paths and ACLs.
*/
@Override
public void apply(Session session, List ops) {
-Stream.of(
-// register namespaces first
-singleton(new NamespacesVisitor(session)),
-// then create node types and privileges, both use namespaces
-asList(
+AtomicReference lastAttemptedOperation = new
AtomicReference<>();
+try {
+Stream.of(
+// register namespaces first
+singleton(new NamespacesVisitor(session)),
+// then create node types and privileges, both use
namespaces
+asList(
+new NodetypesVisitor(session),
+new PrivilegeVisitor(session)),
+// finally apply everything else
+asList(
+new UserVisitor(session),
+new NodeVisitor(session),
+new AclVisitor(session),
+new GroupMembershipVisitor(session),
+new NodePropertiesVisitor(session))
+).forEach(visitorGroup -> {
+ops.forEach(op -> {
+lastAttemptedOperation.set(op);
+visitorGroup.forEach(op::accept);
+});
+});
+} catch (RepoInitException originalFailure) {
+// support legacy statement reordering for backwards compatibility
+try {
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
joerghoh commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616855141
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -567,7 +567,7 @@ private static String toString(JackrabbitAccessControlEntry
entry) throws Reposi
private static void checkState(boolean expression, String msgPattern,
Object... args) {
if (!expression) {
-if (args != null) {
+if (args == null) {
Review Comment:
I don't get why this is changed. Can you please explain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
joerghoh commented on code in PR #54:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54#discussion_r1616847657
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class JcrRepoInitOpsProcessorImpl implements JcrRepoInitOpsProcessor {
+private static final Logger log =
LoggerFactory.getLogger(JcrRepoInitOpsProcessorImpl.class);
+
/**
* Apply the supplied operations: first the namespaces and nodetypes
* registrations, then the service users, paths and ACLs.
*/
@Override
public void apply(Session session, List ops) {
-Stream.of(
-// register namespaces first
-singleton(new NamespacesVisitor(session)),
-// then create node types and privileges, both use namespaces
-asList(
+AtomicReference lastAttemptedOperation = new
AtomicReference<>();
+try {
+Stream.of(
+// register namespaces first
+singleton(new NamespacesVisitor(session)),
+// then create node types and privileges, both use
namespaces
+asList(
+new NodetypesVisitor(session),
+new PrivilegeVisitor(session)),
+// finally apply everything else
+asList(
+new UserVisitor(session),
+new NodeVisitor(session),
+new AclVisitor(session),
+new GroupMembershipVisitor(session),
+new NodePropertiesVisitor(session))
+).forEach(visitorGroup -> {
+ops.forEach(op -> {
+lastAttemptedOperation.set(op);
+visitorGroup.forEach(op::accept);
+});
+});
+} catch (RepoInitException originalFailure) {
+// support legacy statement reordering for backwards compatibility
+try {
Review Comment:
can you please extract this complete section into a dedicated method?
##
src/main/java/org/apache/sling/jcr/repoinit/impl/JcrRepoInitOpsProcessorImpl.java:
##
@@ -38,28 +44,70 @@
})
public class JcrRepoInitOpsProcessorImpl implements JcrRepoInitOpsProcessor {
+private static final Logger log =
LoggerFactory.getLogger(JcrRepoInitOpsProcessorImpl.class);
+
/**
* Apply the supplied operations: first the namespaces and nodetypes
* registrations, then the service users, paths and ACLs.
*/
@Override
public void apply(Session session, List ops) {
-Stream.of(
-// register namespaces first
-singleton(new NamespacesVisitor(session)),
-// then create node types and privileges, both use namespaces
-asList(
+AtomicReference lastAttemptedOperation = new
AtomicReference<>();
+try {
+Stream.of(
+// register namespaces first
+singleton(new NamespacesVisitor(session)),
+// then create node types and privileges, both use
namespaces
+asList(
+new NodetypesVisitor(session),
+new PrivilegeVisitor(session)),
+// finally apply everything else
+asList(
+new UserVisitor(session),
+new NodeVisitor(session),
+new AclVisitor(session),
+new GroupMembershipVisitor(session),
+new NodePropertiesVisitor(session))
+).forEach(visitorGroup -> {
+ops.forEach(op -> {
+lastAttemptedOperation.set(op);
+visitorGroup.forEach(op::accept);
+});
+});
+} catch (RepoInitException originalFailure) {
+// support legacy statement reordering for backwards compatibility
+try {
+session.refresh(false); // drop transient changes
+
+final OperationVisitor[] visitors = {
+new NamespacesVisitor(session),
new NodetypesVisitor(session),
-new PrivilegeVisitor(session)),
-// finally apply everything else
-asList(
+new PrivilegeVisitor(session),
new UserVisitor(session),
new NodeVisitor(session),
new AclVisitor(session),
new GroupMembershipVisitor(session),
-new NodePropertiesVisitor(session))
-).forEach(visitorGroup -> {
-ops.forEach(op ->
[PR] SLING-12329 - Backwards compatibility for legacy repoinit statement reordering [sling-org-apache-sling-jcr-repoinit]
jsedding opened a new pull request, #54: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/54 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2134102353 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2134099708 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix section title [sling-site]
rombert merged PR #165: URL: https://github.com/apache/sling-site/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix section title [sling-site]
paulochang opened a new pull request, #165: URL: https://github.com/apache/sling-site/pull/165 The "Passing parameters to Javascript Use-Objects" section had some extra # in its formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12326 remove the special handling for SocketExceptions [sling-org-apache-sling-engine]
joerghoh merged PR #47: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12321 update parent to 60 [sling-org-apache-sling-engine]
joerghoh merged PR #46: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12326 remove the special handling for SocketExceptions [sling-org-apache-sling-engine]
joerghoh opened a new pull request, #47: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/47 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.servicemix.bundles:org.apache.servicemix.bundles.rhino to v1.7.15_1 [sling-org-apache-sling-starter]
rombert merged PR #329: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]
jsedding merged PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.servicemix.bundles:org.apache.servicemix.bundles.rhino to v1.7.15_1 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #329: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/329 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.servicemix.bundles:org.apache.servicemix.bundles.rhino](http://servicemix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=servicemix-bundles.git)) | `1.7.14_2` -> `1.7.15_1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https: //docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12321 update parent to 60 [sling-org-apache-sling-engine]
sonarcloud[bot] commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46#issuecomment-2132267402 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=46) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=46=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=46=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=46=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=46=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=46) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2131554764 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2131550683 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2131547814 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=49=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131368553 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate failed** Failed conditions  [56.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_coverage=list) (required ≥ 80%)  [9.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614785674 ## pom.xml: ## @@ -41,27 +41,133 @@ Apache Sling Scripting HTL Compiler - -The Apache Sling Scripting HTL Compiler provides support for compiling HTML Template Language scripts into an Abstract -Syntax Tree. - +The Apache Sling Scripting HTL Compiler provides support for compiling HTML Template Language scripts into an Abstract +Syntax Tree. scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-sightly-compiler.git scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-sightly-compiler.git - https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler.git org.apache.sling.scripting.sightly.compiler-1.2.6-1.4.0 + https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler.git Review Comment: I would suggest setting an explicit java bytecode version (no need to upgrade > 8 for now) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131315388 Well, now I get the blame for all the code duplication and missing coverage on the code I "touched". I hope that isn't a blocker for merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131313550 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate failed** Failed conditions  [55.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_coverage=list) (required ≥ 80%)  [9.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) (required ≤ 3%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614722374 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: Oh, after reading the linked page I can see that it still targets JDK 11, but requires JDK 17+ for the build process. I'll have a try at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614720582 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: The latest parent only builds with Java 17 or later. Is that OK? Aren't there any clients that need to run on JDK 11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614687706 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review Comment: Can you update to latest? There are hints on what you need to consider in https://cwiki.apache.org/confluence/x/SI75E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131264743 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-sightly-compiler=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]
rishabhdaim commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#issuecomment-2129190028 > @rishabhdaim I think once you remove the original.pid part of the code, we could merge this PR. Done in https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9/commits/69597f866d6a5646ba334cbefb3aade499a97e1d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2128478041 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=49=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=49=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=49=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=49) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2128474929 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=52=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=52=false=true)  [55.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=52=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=52) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2128474359 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=51=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=51=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=51=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]
jsedding commented on code in PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611777912 ## src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java: ## @@ -707,6 +716,7 @@ private UpdateResult handleUpdate(final String resourceType, dataNode.setProperty(PROP_MODIFIED, Calendar.getInstance()); dataNode.setProperty(PROP_ENC, ENCODING); dataNode.setProperty(PROP_MIME, MIME_TXT); +dataNode.setProperty(ORIGINAL_PID, id); Review Comment: I suggest we drop the original.pid. Instead we go with your approach of checking for the legacy pid (https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13/files#diff-ddf6029cf7d9aa5ed2720412a7fe8de77d7f5df784c32864c6abc54393e78321R95-R97). That isn't quite as generic as I had originally intended, but it should be good enough. Unless I am missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
jsedding merged PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]
jsedding commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1611600431
##
src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java:
##
@@ -92,6 +92,9 @@ public void execute(final InstallationContext ctx) {
}
Configuration config =
ConfigUtil.getConfiguration(this.getConfigurationAdmin(), this.factoryPid,
this.configPid);
+if (config == null) {
+config =
ConfigUtil.getLegacyFactoryConfig(this.getConfigurationAdmin(),
this.factoryPid, null, this.configPid);
+}
Review Comment:
I think this change here is actually "good enough".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611598811
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session s) {
* is the same as the autocreated default value
*
* @param n the node to check
- * @param pRelPath the property relative path to check
+ * @param propertyPath the property relative path to check
* @return true or false
*/
-protected static boolean isUnchangedAutocreatedProperty(Node n, final
String pRelPath)
+protected static boolean isUnchangedAutocreatedProperty(Node n, final
String propertyPath)
throws RepositoryException {
boolean sameAsDefault = false;
// deal with the pRelPath nesting
-Path path = Paths.get(pRelPath);
-Path parentPath = path.getParent();
-String name = path.getFileName().toString();
-if (parentPath != null) {
-String relPath = parentPath.toString();
-if (n.hasNode(relPath)) {
-n = n.getNode(relPath);
-} else {
-n = null;
+final int pos = propertyPath.lastIndexOf("/");
Review Comment:
... and then finally addressed by using the JCR API instead of
reimplementing its functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611596184
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session s) {
* is the same as the autocreated default value
*
* @param n the node to check
- * @param pRelPath the property relative path to check
+ * @param propertyPath the property relative path to check
* @return true or false
*/
-protected static boolean isUnchangedAutocreatedProperty(Node n, final
String pRelPath)
+protected static boolean isUnchangedAutocreatedProperty(Node n, final
String propertyPath)
throws RepositoryException {
-boolean sameAsDefault = false;
-
-// deal with the pRelPath nesting
-Path path = Paths.get(pRelPath);
-Path parentPath = path.getParent();
-String name = path.getFileName().toString();
-if (parentPath != null) {
-String relPath = parentPath.toString();
-if (n.hasNode(relPath)) {
-n = n.getNode(relPath);
-} else {
-n = null;
-}
-}
-
-// if the property has been set by being autocreated and the value is
still
-// the same as the default values then also allow changing the value
-if (n != null && n.hasProperty(name)) {
-@Nullable
-PropertyDefinition pd = resolvePropertyDefinition(name, n);
+if (n.hasProperty(propertyPath)) {
Review Comment:
exactly. it also handles trailing slashes. so most of the code in this
method was re-implementing functionality that is already present in JCR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
joerghoh commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611590909
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session s) {
* is the same as the autocreated default value
*
* @param n the node to check
- * @param pRelPath the property relative path to check
+ * @param propertyPath the property relative path to check
* @return true or false
*/
-protected static boolean isUnchangedAutocreatedProperty(Node n, final
String pRelPath)
+protected static boolean isUnchangedAutocreatedProperty(Node n, final
String propertyPath)
throws RepositoryException {
-boolean sameAsDefault = false;
-
-// deal with the pRelPath nesting
-Path path = Paths.get(pRelPath);
-Path parentPath = path.getParent();
-String name = path.getFileName().toString();
-if (parentPath != null) {
-String relPath = parentPath.toString();
-if (n.hasNode(relPath)) {
-n = n.getNode(relPath);
-} else {
-n = null;
-}
-}
-
-// if the property has been set by being autocreated and the value is
still
-// the same as the default values then also allow changing the value
-if (n != null && n.hasProperty(name)) {
-@Nullable
-PropertyDefinition pd = resolvePropertyDefinition(name, n);
+if (n.hasProperty(propertyPath)) {
Review Comment:
so do I get that right, that you skip the handling of the relative path etc
because ``node.hasProperty`` can handle relative paths and no manual resolution
is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]
joerghoh commented on code in PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#discussion_r1599049824 ## pom.xml: ## @@ -158,6 +158,12 @@ 4.3.1 test + +org.apache.sling +org.apache.sling.commons.metrics +1.2.12 + Review Comment: fixed. ## src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java: ## @@ -78,14 +79,22 @@ public class RepositoryInitializerFactory implements SlingRepositoryInitializer private final Logger log = LoggerFactory.getLogger(getClass()); +private static final String METRIC_REPOINIT_FAILED = RepositoryInitializerFactory.class.getName() + ".failed"; @Reference private RepoInitParser parser; @Reference private JcrRepoInitOpsProcessor processor; + +@Reference +MetricsService metrics; private RepositoryInitializerFactory.Config config; + +// assume that repoinit succeeds ... and just this to true if it fails +private boolean aRepoInitStatementFailed = false; Review Comment: Agree on that. Replaced it with an AtomicBoolean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126808416 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [83.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
jsedding commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611427296
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session s) {
* is the same as the autocreated default value
*
* @param n the node to check
- * @param pRelPath the property relative path to check
+ * @param propertyPath the property relative path to check
* @return true or false
*/
-protected static boolean isUnchangedAutocreatedProperty(Node n, final
String pRelPath)
+protected static boolean isUnchangedAutocreatedProperty(Node n, final
String propertyPath)
throws RepositoryException {
boolean sameAsDefault = false;
// deal with the pRelPath nesting
-Path path = Paths.get(pRelPath);
-Path parentPath = path.getParent();
-String name = path.getFileName().toString();
-if (parentPath != null) {
-String relPath = parentPath.toString();
-if (n.hasNode(relPath)) {
-n = n.getNode(relPath);
-} else {
-n = null;
+final int pos = propertyPath.lastIndexOf("/");
Review Comment:
addressed by moving to `org.apache.jackrabbit.util.Text`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]
rishabhdaim commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611358227
##
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrUtil.java:
##
@@ -73,4 +75,21 @@ public static Node createPath(final Session session,
}
return parentNode.getNode(relativePath);
}
+
+/**
+ * Get the PID for a configuration event by using the R7 format before
saving it.
+ *
+ * @param factoryPid factory PID of the configuration
+ * @param pid PID of the configuration
+ * @return The PID in R7 format
+ */
+public static String getPid(final String factoryPid, final String pid) {
+// if factory pid is separated from pid by a period (.), we need
replace it with a ~ so that this can be installed
+// and grouped as a factory configuration
+if (pid.startsWith(factoryPid + '.')) {
+String id = pid.substring(factoryPid.length() + 1);
+return factoryPid + "~" + id;
+}
+return pid;
Review Comment:
Addressed in
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9/commits/49da45e49774d6f9b8597bbc6376c527ef5970f3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
reschke commented on code in PR #53:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611357821
##
src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java:
##
@@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session s) {
* is the same as the autocreated default value
*
* @param n the node to check
- * @param pRelPath the property relative path to check
+ * @param propertyPath the property relative path to check
* @return true or false
*/
-protected static boolean isUnchangedAutocreatedProperty(Node n, final
String pRelPath)
+protected static boolean isUnchangedAutocreatedProperty(Node n, final
String propertyPath)
throws RepositoryException {
boolean sameAsDefault = false;
// deal with the pRelPath nesting
-Path path = Paths.get(pRelPath);
-Path parentPath = path.getParent();
-String name = path.getFileName().toString();
-if (parentPath != null) {
-String relPath = parentPath.toString();
-if (n.hasNode(relPath)) {
-n = n.getNode(relPath);
-} else {
-n = null;
+final int pos = propertyPath.lastIndexOf("/");
Review Comment:
just checking: we know that there's no trailing "/" here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126642430 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [85.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126609772 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=53=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=53=false=true)  [85.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=53=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=53) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]
jsedding opened a new pull request, #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12321 update parent to 60 [sling-org-apache-sling-engine]
joerghoh opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
