Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
+1 Carsten On 06.12.2023 20:39, Carsten Ziegeler wrote: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12182 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2819/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2819 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
RE: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
+1 stefan
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
Given this input I change my vote to +1 Konrad > On 7. Dec 2023, at 16:30, Carsten Ziegeler wrote: > > Thanks Konrad, > > tbh I don't know. As there is no provide capability yet on the API, I think > we are totally fine with continuing the release. > > If there is anyone out there with such a thing in a manifest, it will not > resolve if any solution that exists out there. So that is not specific to our > wrapper. > > Once there is an agreement on what that capability should look like, we can > easily add it, do another release and are good. > > Regards > Carsten > > On 07.12.2023 16:21, Konrad Windszus wrote: >> Hi Carsten, >> I only voted -1 due to the missing provided capability, but I am unsure >> about the impact. >> The other issues are not blocking a release from my perspective. >> I would appreciate you commenting on the actual issue here. >> Is it possible that consumers of JSON-P 2.0 or JSON-P 2.1 ever end up with a >> require-capability JakartaJSONProcessing in their MANIFEST.MF automatically? >> It seems that no version of jakarta.json-api ever provided that capability… >> To me the reasoning of that is not clear though. >> Is versioned packages considered enough for JSON-P >= 2? >> I was fearing that we run into issues like >> https://issues.apache.org/jira/browse/SLING-9218. >> Looking forward to hear you commenting on this. >> Konrad >>> On 7. Dec 2023, at 15:17, Carsten Ziegeler wrote: >>> >>> I find it very strange to base a -1 on these minor issues >>> >>> >>> On 07.12.2023 10:39, Konrad Windszus wrote: Hi, -1 from my side because the manifest does not contain the necessary "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". Probably a regression in Johnzon itself. Also the readme should be clarified that this implements JSON-P 2.1.1. As Johnzon now requires Java 11 (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 11 byte code in our wrapper (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) The master branch looks incorrect now: It has version 2.0.0 instead of 2.0.1-SNAPSHOT. Did something go wrong with the release? Konrad > On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12182 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2819/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2819 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org >>> >>> -- >>> Carsten Ziegeler >>> Adobe >>> cziege...@apache.org > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
Thanks Konrad, tbh I don't know. As there is no provide capability yet on the API, I think we are totally fine with continuing the release. If there is anyone out there with such a thing in a manifest, it will not resolve if any solution that exists out there. So that is not specific to our wrapper. Once there is an agreement on what that capability should look like, we can easily add it, do another release and are good. Regards Carsten On 07.12.2023 16:21, Konrad Windszus wrote: Hi Carsten, I only voted -1 due to the missing provided capability, but I am unsure about the impact. The other issues are not blocking a release from my perspective. I would appreciate you commenting on the actual issue here. Is it possible that consumers of JSON-P 2.0 or JSON-P 2.1 ever end up with a require-capability JakartaJSONProcessing in their MANIFEST.MF automatically? It seems that no version of jakarta.json-api ever provided that capability… To me the reasoning of that is not clear though. Is versioned packages considered enough for JSON-P >= 2? I was fearing that we run into issues like https://issues.apache.org/jira/browse/SLING-9218. Looking forward to hear you commenting on this. Konrad On 7. Dec 2023, at 15:17, Carsten Ziegeler wrote: I find it very strange to base a -1 on these minor issues On 07.12.2023 10:39, Konrad Windszus wrote: Hi, -1 from my side because the manifest does not contain the necessary "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". Probably a regression in Johnzon itself. Also the readme should be clarified that this implements JSON-P 2.1.1. As Johnzon now requires Java 11 (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 11 byte code in our wrapper (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) The master branch looks incorrect now: It has version 2.0.0 instead of 2.0.1-SNAPSHOT. Did something go wrong with the release? Konrad On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12182 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2819/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2819 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org -- Carsten Ziegeler Adobe cziege...@apache.org -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
Hi Carsten, I only voted -1 due to the missing provided capability, but I am unsure about the impact. The other issues are not blocking a release from my perspective. I would appreciate you commenting on the actual issue here. Is it possible that consumers of JSON-P 2.0 or JSON-P 2.1 ever end up with a require-capability JakartaJSONProcessing in their MANIFEST.MF automatically? It seems that no version of jakarta.json-api ever provided that capability… To me the reasoning of that is not clear though. Is versioned packages considered enough for JSON-P >= 2? I was fearing that we run into issues like https://issues.apache.org/jira/browse/SLING-9218. Looking forward to hear you commenting on this. Konrad > On 7. Dec 2023, at 15:17, Carsten Ziegeler wrote: > > I find it very strange to base a -1 on these minor issues > > > On 07.12.2023 10:39, Konrad Windszus wrote: >> Hi, >> -1 from my side because the manifest does not contain the necessary >> "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". >> Probably a regression in Johnzon itself. >> Also the readme should be clarified that this implements JSON-P 2.1.1. >> As Johnzon now requires Java 11 >> (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate >> Java 11 byte code in our wrapper >> (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) >> The master branch looks incorrect now: It has version 2.0.0 instead of >> 2.0.1-SNAPSHOT. >> Did something go wrong with the release? >> Konrad >>> On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: >>> >>> Hi, >>> >>> We solved 1 issue in this release >>> https://issues.apache.org/jira/browse/SLING-12182 >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachesling-2819/ >>> >>> You can use this UNIX script to download the release and verify the >>> signatures: >>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD >>> >>> Usage: >>> sh check_staged_release.sh 2819 /tmp/sling-staging >>> >>> Please vote to approve this release: >>> >>> [ ] +1 Approve the release >>> [ ] 0 Don't care >>> [ ] -1 Don't release, because ... >>> >>> This majority vote is open for at least 72 hours. >>> >>> Regards >>> Carsten >>> -- >>> Carsten Ziegeler >>> Adobe >>> cziege...@apache.org > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
Regarding the main branch, it seems the mvn release process did not do the final push; seems to be a regression somewhere Just did it manually Carsten On 07.12.2023 10:39, Konrad Windszus wrote: Hi, -1 from my side because the manifest does not contain the necessary "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". Probably a regression in Johnzon itself. Also the readme should be clarified that this implements JSON-P 2.1.1. As Johnzon now requires Java 11 (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 11 byte code in our wrapper (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) The master branch looks incorrect now: It has version 2.0.0 instead of 2.0.1-SNAPSHOT. Did something go wrong with the release? Konrad On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12182 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2819/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2819 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
I find it very strange to base a -1 on these minor issues On 07.12.2023 10:39, Konrad Windszus wrote: Hi, -1 from my side because the manifest does not contain the necessary "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". Probably a regression in Johnzon itself. Also the readme should be clarified that this implements JSON-P 2.1.1. As Johnzon now requires Java 11 (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 11 byte code in our wrapper (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) The master branch looks incorrect now: It has version 2.0.0 instead of 2.0.1-SNAPSHOT. Did something go wrong with the release? Konrad On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12182 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2819/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2819 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
According to https://docs.osgi.org/reference/portable-java-contracts.html the new contract name is “JakartaJSONProcessing” but it isn’t contained in the Manifest of https://repo1.maven.org/maven2/jakarta/json/jakarta.json-api/2.1.1/jakarta.json-api-2.1.1.jar either. I opened https://github.com/jakartaee/jsonp-api/issues/406 to get clarification about that. > On 7. Dec 2023, at 10:39, Konrad Windszus wrote: > > Hi, > -1 from my side because the manifest does not contain the necessary > "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". > Probably a regression in Johnzon itself. > > Also the readme should be clarified that this implements JSON-P 2.1.1. > As Johnzon now requires Java 11 > (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java > 11 byte code in our wrapper > (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) > > The master branch looks incorrect now: It has version 2.0.0 instead of > 2.0.1-SNAPSHOT. > Did something go wrong with the release? > Konrad > > > >> On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: >> >> Hi, >> >> We solved 1 issue in this release >> https://issues.apache.org/jira/browse/SLING-12182 >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachesling-2819/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2819 /tmp/sling-staging >> >> Please vote to approve this release: >> >> [ ] +1 Approve the release >> [ ] 0 Don't care >> [ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours. >> >> Regards >> Carsten >> -- >> Carsten Ziegeler >> Adobe >> cziege...@apache.org >
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
Hi, -1 from my side because the manifest does not contain the necessary "Provide-Capability: osgi.contract;osgi.contract=JavaJSONP". Probably a regression in Johnzon itself. Also the readme should be clarified that this implements JSON-P 2.1.1. As Johnzon now requires Java 11 (https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 11 byte code in our wrapper (https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29) The master branch looks incorrect now: It has version 2.0.0 instead of 2.0.1-SNAPSHOT. Did something go wrong with the release? Konrad > On 6. Dec 2023, at 20:39, Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12182 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2819/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2819 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
+1 regards, Karl On Wed, Dec 6, 2023 at 8:39 PM Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12182 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2819/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2819 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[VOTE] Release Apache Sling Commons Johnzon 2.0.0
Hi, We solved 1 issue in this release https://issues.apache.org/jira/browse/SLING-12182 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2819/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2819 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
