[RESULT] [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
Hi, The vote has passed with the following result: +1 (binding): Chetan Mehrotra, Robert Munteanu, Carsten Ziegeler, Oliver Lietz I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting! O.
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
+1 A small note, not blocking the release: building with the rat profile fails due to README.md not being excluded from the license check ; filed SLING-3745 [1] . Robert [1]: https://issues.apache.org/jira/browse/SLING-3745 On Tue, Jul 8, 2014 at 8:30 AM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: Hi Oliver, On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz apa...@oliverlietz.de wrote: sh check_staged_release.sh 1076 /tmp/sling-staging +1 for the release. All checks ok One minor note - Currently quite a few classes are part of public package 'org.apache.sling.scripting.thymeleaf'. May be all are not required in Export-Package like SlingWebContext, ThymeleafScriptEngine, ThymeleafScriptEngineFactory. Chetan Mehrotra -- Sent from my (old) computer
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
Sorry, just noticed that the check_staged_release script failed to verify the signatures. I'm withdrawing my vote until I see why this happened. On Tue, Jul 8, 2014 at 12:15 PM, Robert Munteanu rob...@lmn.ro wrote: +1 A small note, not blocking the release: building with the rat profile fails due to README.md not being excluded from the license check ; filed SLING-3745 [1] . Robert [1]: https://issues.apache.org/jira/browse/SLING-3745 On Tue, Jul 8, 2014 at 8:30 AM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: Hi Oliver, On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz apa...@oliverlietz.de wrote: sh check_staged_release.sh 1076 /tmp/sling-staging +1 for the release. All checks ok One minor note - Currently quite a few classes are part of public package 'org.apache.sling.scripting.thymeleaf'. May be all are not required in Export-Package like SlingWebContext, ThymeleafScriptEngine, ThymeleafScriptEngineFactory. Chetan Mehrotra -- Sent from my (old) computer -- Sent from my (old) computer
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
Hi Robert, On Tue, Jul 8, 2014 at 2:57 PM, Robert Munteanu rob...@lmn.ro wrote: Sorry, just noticed that the check_staged_release script failed to verify the signatures. You would first need to import the Oliver keys $ gpg --keyserver pgpkeys.mit.edu --recv-key B9652429 Where is B9652429 obtained from Oliver's key id at https://people.apache.org/keys/group/sling.asc Chetan Mehrotra
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
On Tue, Jul 8, 2014 at 12:34 PM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: Hi Robert, On Tue, Jul 8, 2014 at 2:57 PM, Robert Munteanu rob...@lmn.ro wrote: Sorry, just noticed that the check_staged_release script failed to verify the signatures. You would first need to import the Oliver keys $ gpg --keyserver pgpkeys.mit.edu --recv-key B9652429 Where is B9652429 obtained from Oliver's key id at https://people.apache.org/keys/group/sling.asc Thanks, I tried that but failed due to a firewall issue gpg: requesting key B9652429 from hkp server keys.gnupg.net gpg: keyserver timed out gpg: keyserver receive failed: Keyserver error I'll try this again when I am able to retrieve the key. Robert Chetan Mehrotra -- Sent from my (old) computer
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
On Tuesday 08 July 2014 07:30:26 Chetan Mehrotra wrote: Hi Oliver, Hi Chetan, On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz apa...@oliverlietz.de wrote: sh check_staged_release.sh 1076 /tmp/sling-staging +1 for the release. All checks ok One minor note - Currently quite a few classes are part of public package 'org.apache.sling.scripting.thymeleaf'. May be all are not required in Export-Package like SlingWebContext, ThymeleafScriptEngine, ThymeleafScriptEngineFactory. thanks for having a closer look and sharing your opinion. They are indeed not required and I will move them to impl before the next release. I hadn't a strong opinion on that as some of our other scripting bundles handle it similar and some not. Regards, O. Chetan Mehrotra
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
On Monday 07 July 2014 21:40:08 Oliver Lietz wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327184/ +1 O.
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
On Tue, Jul 8, 2014 at 12:39 PM, Robert Munteanu rob...@lmn.ro wrote: I'll try this again when I am able to retrieve the key. +1 Retrieved the key, signatures check out fine at my end. Robert
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
+1 2014-07-09 1:01 GMT+02:00 Robert Munteanu romb...@apache.org: On Tue, Jul 8, 2014 at 12:39 PM, Robert Munteanu rob...@lmn.ro wrote: I'll try this again when I am able to retrieve the key. +1 Retrieved the key, signatures check out fine at my end. Robert -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327184/ Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1076/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1076 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, O.
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.2
Hi Oliver, On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz apa...@oliverlietz.de wrote: sh check_staged_release.sh 1076 /tmp/sling-staging +1 for the release. All checks ok One minor note - Currently quite a few classes are part of public package 'org.apache.sling.scripting.thymeleaf'. May be all are not required in Export-Package like SlingWebContext, ThymeleafScriptEngine, ThymeleafScriptEngineFactory. Chetan Mehrotra
