[jira] [Commented] (SLING-11099) JSPC plugin missing critical dependencies by default

2022-01-28 Thread Karl Pauls (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483984#comment-17483984
 ] 

Karl Pauls commented on SLING-11099:


Yeah, looks like a bug. I guess I missed that adding an artifactid as a 
property makes it need the classes even so it is not configured. I'll fix it.

> JSPC plugin missing critical dependencies by default
> 
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary 
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack 
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError: 
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency 
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well) 
> is marked as {_}provided{_}. Adding the following two as explicit plugin 
> dependencies is a workaround (and allows at least my builds to work). 
> However, I do not believe that ordinary Maven users should have to do such a 
> workaround.
> {{  }}
> {{      org.apache.sling}}
> {{      org.apache.sling.feature}}
> {{      1.2.30}}
> {{  }}
> {{  }}
> {{      org.osgi}}
> {{      org.osgi.framework}}
> {{      1.10.0}}
> {{  }}
> Note that 2.3.0 worked correctly.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11099) JSPC plugin missing critical dependencies by default

2022-01-28 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483871#comment-17483871
 ] 

Konrad Windszus commented on SLING-11099:
-

This seems to be a regression caused by SLING-10887. [~kpauls] Can you look 
into that? IMHO Sling Features should only be an optional dependency.

> JSPC plugin missing critical dependencies by default
> 
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary 
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack 
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError: 
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency 
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well) 
> is marked as {_}provided{_}. Adding the following two as explicit plugin 
> dependencies is a workaround (and allows at least my builds to work). 
> However, I do not believe that ordinary Maven users should have to do such a 
> workaround.
> {{  }}
> {{      org.apache.sling}}
> {{      org.apache.sling.feature}}
> {{      1.2.30}}
> {{  }}
> {{  }}
> {{      org.osgi}}
> {{      org.osgi.framework}}
> {{      1.10.0}}
> {{  }}
> Note that 2.3.0 worked correctly.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)