[jira] [Commented] (SLING-11373) The MergingServletResourceProvider does not wrap resources correctly

2022-07-14 Thread Karl Pauls (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566744#comment-17566744
 ] 

Karl Pauls commented on SLING-11373:


With the new passthrough mode from [~cziegeler] (many thanks), it seems like 
the best option to just use that one. 

I added a {{mountPathProviders}} option in [0] which overrides the 
{{mountProviders}} option if enabled. That should fix the issue the right way 
and we can eventually deprecated the {{mountProviders}} option altogether. 

[0] https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/30

> The MergingServletResourceProvider does not wrap resources correctly
> 
>
> Key: SLING-11373
> URL: https://issues.apache.org/jira/browse/SLING-11373
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.7.0
>Reporter: Radu Cotescu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Resolver 2.9.8
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The {{MergingServletResourceProvider}} does not wrap resources correctly, 
> forcing script engines that need to solve dependencies via this provider to 
> call {{ResourceResolver#resolve(String)}}. Unfortunately, there is a case 
> when the call to {{resolve}} fails:
> {noformat}
> /apps/components/a/
> a.html
> helper.something.html
> helper/ [backed by JCR]
>   partial.html
> /apps/components/b [sling:resourceSuperType=components/a]
> b.html -> tries to resolve helper.something.html
> {noformat}
> In the case above, {{b.html}} will get the {{helper}} folder when trying to 
> resolve {{helper.something.html}}.
> If the {{MergingServletResourceProvider}} would correctly wrap resources (and 
> decorate them accordingly), the script engines could switch to using 
> {{ResourceResolver#getResource(String)}}, which would not exhibit the same 
> behaviour.
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11373) The MergingServletResourceProvider does not wrap resources correctly

2022-07-11 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564922#comment-17564922
 ] 

Carsten Ziegeler commented on SLING-11373:
--

One option to implement this is by introducing a new mode for a resource 
provider as prototyped in
https://github.com/apache/sling-org-apache-sling-resourceresolver/tree/feature/resource-provider-mode

> The MergingServletResourceProvider does not wrap resources correctly
> 
>
> Key: SLING-11373
> URL: https://issues.apache.org/jira/browse/SLING-11373
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.7.0
>Reporter: Radu Cotescu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Resolver 2.9.8
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The {{MergingServletResourceProvider}} does not wrap resources correctly, 
> forcing script engines that need to solve dependencies via this provider to 
> call {{ResourceResolver#resolve(String)}}. Unfortunately, there is a case 
> when the call to {{resolve}} fails:
> {noformat}
> /apps/components/a/
> a.html
> helper.something.html
> helper/ [backed by JCR]
>   partial.html
> /apps/components/b [sling:resourceSuperType=components/a]
> b.html -> tries to resolve helper.something.html
> {noformat}
> In the case above, {{b.html}} will get the {{helper}} folder when trying to 
> resolve {{helper.something.html}}.
> If the {{MergingServletResourceProvider}} would correctly wrap resources (and 
> decorate them accordingly), the script engines could switch to using 
> {{ResourceResolver#getResource(String)}}, which would not exhibit the same 
> behaviour.
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)