[jira] [Commented] (SLING-11619) Restore safeguard mechanism for discovery config

2022-10-24 Thread Stefan Egli (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623237#comment-17623237
 ] 

Stefan Egli commented on SLING-11619:
-

updated the PR and marked ready for review

> Restore safeguard mechanism for discovery config
> 
>
> Key: SLING-11619
> URL: https://issues.apache.org/jira/browse/SLING-11619
> Project: Sling
>  Issue Type: Task
>  Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> With the [update to parent 
> 47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579]
>  the discovery.oak's Config "lost" the ability to gracefully deal with wrong 
> values, such as empty strings. It used to silently swallow these, but now 
> fails loudly with
> {noformat}
> org.osgi.service.component.ComponentException: 
> java.lang.NumberFormatException: For input string: ""
>   at 
> org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379)
>  [org.apache.felix.scr:2.2.0]
>   at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source)
>   at org.apache.sling.discovery.oak.Config.configure(Config.java:238) 
> [org.apache.sling.discovery.oak:1.2.40]
>   at org.apache.sling.discovery.oak.Config.activate(Config.java:159) 
> [org.apache.sling.discovery.oak:1.2.40]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11619) Restore safeguard mechanism for discovery config

2022-10-12 Thread Stefan Egli (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616564#comment-17616564
 ] 

Stefan Egli commented on SLING-11619:
-

Started work in a [draft 
PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11]

> Restore safeguard mechanism for discovery config
> 
>
> Key: SLING-11619
> URL: https://issues.apache.org/jira/browse/SLING-11619
> Project: Sling
>  Issue Type: Task
>  Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>
> With the [update to parent 
> 47|https://github.com/apache/sling-org-apache-sling-discovery-oak/commit/c306408f36e7636c72b71805d2bb0e3e6f0f0e73#diff-73d443e41e9bfaa5e9c77b6db0e318079f1885f5a7ed9685aae9730209adc579]
>  the discovery.oak's Config "lost" the ability to gracefully deal with wrong 
> values, such as empty strings. It used to silently swallow these, but now 
> fails loudly with
> {noformat}
> org.osgi.service.component.ComponentException: 
> java.lang.NumberFormatException: For input string: ""
>   at 
> org.apache.felix.scr.impl.inject.internal.Annotations$Handler.invoke(Annotations.java:379)
>  [org.apache.felix.scr:2.2.0]
>   at com.sun.proxy.$Proxy368.backoffStandbyFactor(Unknown Source)
>   at org.apache.sling.discovery.oak.Config.configure(Config.java:238) 
> [org.apache.sling.discovery.oak:1.2.40]
>   at org.apache.sling.discovery.oak.Config.activate(Config.java:159) 
> [org.apache.sling.discovery.oak:1.2.40]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)