[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13476009#comment-13476009 ] Antonio Sanso commented on SLING-2593: -- thanks for your patch Christian. I have applied it in revision r1398205. Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, report_level_patch.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474059#comment-13474059 ] Antonio Sanso commented on SLING-2593: -- [~vazzolla] looking at the report level patch I really thing that should be associated with the PerformanceTestSuite rather than with the PerformanceTest. Your point might be that somebody can still run a PerformanceTest without a suite. So how about injecting this report level in the PerformanceRunner? That would be a common point... WDYT? Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13468491#comment-13468491 ] Antonio Sanso commented on SLING-2593: -- Removed XML Report type since is not implemented. Changed getenv with getProperty. Removed 2 unused classes (AbstractPerformanceTest, AbstractTest) in revision 1393426 Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13467582#comment-13467582 ] Vazzolla-Popa Cristian-George commented on SLING-2593: -- Hi Justin, You were right I will use System.getProperty instead of getEnv and pass the testsuitename from the Maven command line; thanks for this. Regarding the use case, here is how I want to use the Sling performance framework for our product performance tests. - from the maven command line I set the testsuite name, I just download (not build) a specific product release (for example version 1.0.0) and run all the performance tests against it - after that I store the performance results - do this for different versions of the product(1.1.0, 1.2.0 and so on) that are released during a time interval for ex. during the last 1 year (so the product is not the same - similar case as with Sling jcr tests); so be doing this I will be able to observe the performance results from the version 1.0.0 to version 1.9.0 for example - the only difference that I see comparing with the Sling jcr performance tests is that by using the option to just download a specific version of the product instead of building them, I do not need a new project for each test suite like in the Sling tests where there is a project for jcr.resource-2.0.10, another one for jcr.resource-2.1.0 - one more thing the performance tests that we are using are not unit tests, are tests that will be run by having http requests so we can easily use the same tests for different versions; we will have some network latency but the team is ok with this approach and they want us to have these kind of tests; also because of these variables I would like to be able to run the tests at a specific moment on various product releases Regards, Cristian Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466679#comment-13466679 ] Antonio Sanso commented on SLING-2593: -- Hi Cristian, the method name is still passed to the ReportLogger. It seems there is an issue though with it. The method passed seems to be always the same. If we solve the issue with the method name I believe we can still come out with some mechanism to have two kind of report formats: one simple and one verbose. Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466696#comment-13466696 ] Antonio Sanso commented on SLING-2593: -- solved method name issue in revision 1392229. Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466734#comment-13466734 ] Justin Edelson commented on SLING-2593: --- A few comments on the changes committed thus far: * Please fix formatting - Sling uses 4 spaces for indentation. * Is it appropriate for the tests (e.g. ResolveNonExistingWith1000AliasTest) to be annotated with @RunWith? AFAIK, they are not runnable tests. * Is the class AbstractPerformanceTest used anymore? It seems like no. If not, why does it exist? * Why is System.getenv() used in ReportLogger rather than System.getProperty() ? * Why is there an XML ReportType enum value if it isn't supported? Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466739#comment-13466739 ] Antonio Sanso commented on SLING-2593: -- fixed formatting in revision 1392281. Thanks Justin. Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466750#comment-13466750 ] Vazzolla-Popa Cristian-George commented on SLING-2593: -- Hi Justin, 1. Regarding the AbstractPerformanceTest and also AbstractTest classes, was my mistake that they did not appear in the initial patch file I've sent. So the two classes should be removed as they are not used anymore in the sling performance tests. I'm not aware of other tests that were using these classes before, but if they are they will need to be modified not to use them anymore. 2. The System.getenv() is used instead of System.getProperty() because if someone wants to set the test suite name from outside the test itself it would not be able to do that. The use case I want to be able to achieve is : - set suite name (maybe equal to product version) - download a specified product version by using maven command line and run the performance tests - copy the result reports for that build - delete the environment variable and do this for several product builds/versions from a bat/sh file (or from a Jenkins job) like below: set testsuitename=build1 call mvn -PdownloadSpecificBuild -PrunTests clean verify test xcopy target/performance-reports performance-reports/%testsuitename% /D /E /C /R /I /K /Y set testsuitename= set testsuitename=build2 call mvn -PdownloadSpecificCQ -PrunTests clean verify test xcopy target/performance-reports performance-reports/%testsuitename% /D /E /C /R /I /K /Y 3. Regarding the RunWith and XML ReportType I've talked with Antonio and he will do the modification: - remove @RunWith for the tests as they are not runnable - remove XML ReportType until will be supported I can create a new patch if you think is necessary. Regards, Cristian Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466781#comment-13466781 ] Justin Edelson commented on SLING-2593: --- bq. The System.getenv() is used instead of System.getProperty() because if someone wants to set the test suite name from outside the test itself it would not be able to do that. Hmmm. I don't see that there's anything about the example which means this couldn't be done with system properties. But more importantly - the pattern used in the example build script above is different than how these tools are used within Sling - namely that in the example script, the same test project is built repeatedly against (I'm guessing) different target environments. Whereas in the Sling tests contain a distinct project per target environment (aka bundle set). Am I understanding that correctly? Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: performance_patch_2.patch, sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466538#comment-13466538 ] Vazzolla-Popa Cristian-George commented on SLING-2593: -- Hi Antonio, If we keep the old format which was class oriented we will have a log report per class, so what happens in the new approach in the case we have more than one test method in a class ? I think we need to add at least the method name in the test report even if we keep the report in some way similar to the one that was used before or maybe come with some type of report that would be between the two . Also I'm not sure that a user would expect the performance framework to correctly report the results just when using the verbose flag for the case in which he has multiple test methods in a class, what do you think ? Regards, Cristian Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466283#comment-13466283 ] Antonio Sanso commented on SLING-2593: -- adding second part of the patch from Christian Vazzolla in revision r1391855. Thanks a lot Christian. The only thing I change from your patch is keeping the old report format. We can still introduce the format you came with having a verbose mode. WDYT? Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2593) Improvement for the Sling performance tools
[ https://issues.apache.org/jira/browse/SLING-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461357#comment-13461357 ] Antonio Sanso commented on SLING-2593: -- I have commit the first patch of the patch 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also in revision 1388992. Thanks Christian! Improvement for the Sling performance tools Key: SLING-2593 URL: https://issues.apache.org/jira/browse/SLING-2593 Project: Sling Issue Type: Improvement Components: Testing Reporter: Vazzolla-Popa Cristian-George Assignee: Antonio Sanso Priority: Minor Attachments: sling_performance_framework_refactoring.patch Added a few improvements to the Sling performance testing tools: 1. Added the possibility to run each test method in a class as a performance test; until now a test was represented by a class (for each new test you had to add a new java class) 2. Added a PerformanceTest annotation that is used to discover the test methods in a java class 3. Added the possibility to provide with the PerformanceTest annotation a few configuration parameters for the test like the warmup time, run time , warm up invocations or run invocations; by default the warmuptime and runtime are used but a user can choose not to count on the time but to prefer setting the number of test invocations that he wants to be made during the test run 4. Created a new maven project that contains only the sling performance tests and left the framework(tool) related part in the base project as we would like to use the framework for performance testing in other projects also 5. Added the possibility to have parameters sent to test suite object, added a before suite and after suite method -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
