[jira] [Commented] (SLING-3510) Check for null classUrls and warn when no @Model classes found by Sling Models
[ https://issues.apache.org/jira/browse/SLING-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082266#comment-14082266 ] ASF GitHub Bot commented on SLING-3510: --- Github user cpilsworth closed the pull request at: https://github.com/apache/sling/pull/15 Check for null classUrls and warn when no @Model classes found by Sling Models -- Key: SLING-3510 URL: https://issues.apache.org/jira/browse/SLING-3510 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Sling Models Implementation 1.0.2 Reporter: Chris Pilsworth Fix For: Sling Models Implementation 1.0.4 When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3510) Check for null classUrls and warn when no @Model classes found by Sling Models
[ https://issues.apache.org/jira/browse/SLING-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979637#comment-13979637 ] Justin Edelson commented on SLING-3510: --- Applied patch along with adding check to integration tests. Thanks! Check for null classUrls and warn when no @Model classes found by Sling Models -- Key: SLING-3510 URL: https://issues.apache.org/jira/browse/SLING-3510 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Sling Models Implementation 1.0.2 Reporter: Chris Pilsworth When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3510) Check for null classUrls and warn when no @Model classes found by Sling Models
[ https://issues.apache.org/jira/browse/SLING-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978202#comment-13978202 ] ASF GitHub Bot commented on SLING-3510: --- GitHub user cpilsworth opened a pull request: https://github.com/apache/sling/pull/15 SLING-3510 Check for null classUrls and warn when no @Model classes found When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpilsworth/sling SLING-3510 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 88e2a197c7fda2922244b42b77499f54ab6a503a Author: Chris Pilsworth cpilswo...@gmail.com Date: 2014-04-23T13:49:20Z SLING-3510 Check for null classUrls and warn when no @Model classes found by Sling Models Check for null classUrls and warn when no @Model classes found by Sling Models -- Key: SLING-3510 URL: https://issues.apache.org/jira/browse/SLING-3510 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Sling Models Implementation 1.0.2 Reporter: Chris Pilsworth When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3510) Check for null classUrls and warn when no @Model classes found by Sling Models
[ https://issues.apache.org/jira/browse/SLING-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978248#comment-13978248 ] Chris Pilsworth commented on SLING-3510: Fix in can be found in pull request here https://github.com/apache/sling/pull/15 with patch available here https://github.com/apache/sling/pull/15.patch Check for null classUrls and warn when no @Model classes found by Sling Models -- Key: SLING-3510 URL: https://issues.apache.org/jira/browse/SLING-3510 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Sling Models Implementation 1.0.2 Reporter: Chris Pilsworth When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null. -- This message was sent by Atlassian JIRA (v6.2#6252)