[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038529#comment-14038529 ] ASF GitHub Bot commented on SLING-3651: --- Github user kwin closed the pull request at: https://github.com/apache/sling/pull/19 Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032180#comment-14032180 ] Konrad Windszus commented on SLING-3651: Yes, the changes are all included in the pull request. Would you consider integrating that in Version 1.0.0? Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032245#comment-14032245 ] Stefan Egli commented on SLING-3651: Yes, I think this should go into 1.0.0. I'll look at it next. Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Stefan Egli Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026316#comment-14026316 ] Stefan Egli commented on SLING-3651: Hi [~kwin], thanks! bq. I also improved the path handling Does 'https://github.com/apache/sling/pull/19' include this change already? Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019714#comment-14019714 ] Konrad Windszus commented on SLING-3651: Also I would like if the ProjectHelper.getInferredContentProjectContentRoot() would only be taken as the default for the dialog (asking for the JCR-Root). But it should be possible to convert projects, even if the JCR-Root is outside the checked folders. In some project the jcr_root is at /src/main/jcr_root. Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019829#comment-14019829 ] ASF GitHub Bot commented on SLING-3651: --- GitHub user kwin opened a pull request: https://github.com/apache/sling/pull/19 SLING-3651, improved error message for conversion to content project always enable the conversion action (to be able to see the error message) You can merge this pull request into a Git repository by running: $ git pull https://github.com/kwin/sling SLING-3651-improve-conversions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 57cebdb13ffb0d380bfdaddece2219d0d4d680ee Author: Konrad Windszus konrad.winds...@netcentric.biz Date: 2014-06-06T13:15:16Z SLING-3651, improved error message for conversion to content project, always enable the conversion action (to be able to see the error message) Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020011#comment-14020011 ] Konrad Windszus commented on SLING-3651: I also improved the path handling (to be platform independent and even support Windows and backslashes :-)). The Conversion To Bundle Wizard will now display a proper tree view to allow me to easily select the JCR root (instead of a simple input field) with the correct validation and error messages in place. Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020022#comment-14020022 ] Konrad Windszus commented on SLING-3651: What would be good to do as well, is to reuse the same dialog with the tree view for the Sling Property Page (because it only shows containers below the project and gives out validation information). [~rombert] Maybe you can do that. Otherwise we can defer that part to a future version. Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
